Re: [VOTE] Release Apache Sling Feature Model Content Extension 1.0.10
+1 On Mon, Mar 15, 2021 at 6:20 AM wrote: > +1 > > David > > On Mon, 15 Mar 2021 at 09:04, Radu Cotescu wrote: > > > +1 > > > > > On 13 Mar 2021, at 01:26, Karl Pauls wrote: > > > > > > Please vote to approve these releases: > > > > > > [ ] +1 Approve the releases > > > [ ] 0 Don't care > > > [ ] -1 Don't release, because ... > > > > >
[jira] [Commented] (SLING-10217) Support multiline string values in cfg.json
[
https://issues.apache.org/jira/browse/SLING-10217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301899#comment-17301899
]
Konrad Windszus commented on SLING-10217:
-
[~cziegeler] WDYT? Has this been discussed at OSGi in the context of
https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.configurator.html?
> Support multiline string values in cfg.json
> ---
>
> Key: SLING-10217
> URL: https://issues.apache.org/jira/browse/SLING-10217
> Project: Sling
> Issue Type: Improvement
> Components: Installer
>Affects Versions: Installer Configuration Factory 1.3.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently configurations of type {{.cfg.json}} only allow the JSON format
> defined by
> https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.configurator.html.
> For some very long values like {{scripts}} property for PID
> {{org.apache.sling.jcr.repoinit.RepositoryInitializer}} this makes the value
> very hard to read, as JSON does not support values spanning multiple lines.
> It would be nice if some line continuation character would be supported which
> allows to distribute a String value across multiple lines.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10217) Support multiline string values in cfg.json
Konrad Windszus created SLING-10217:
---
Summary: Support multiline string values in cfg.json
Key: SLING-10217
URL: https://issues.apache.org/jira/browse/SLING-10217
Project: Sling
Issue Type: Improvement
Components: Installer
Affects Versions: Installer Configuration Factory 1.3.4
Reporter: Konrad Windszus
Currently configurations of type {{.cfg.json}} only allow the JSON format
defined by
https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.configurator.html.
For some very long values like {{scripts}} property for PID
{{org.apache.sling.jcr.repoinit.RepositoryInitializer}} this makes the value
very hard to read, as JSON does not support values spanning multiple lines.
It would be nice if some line continuation character would be supported which
allows to distribute a String value across multiple lines.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-distribution-core] mohiaror commented on a change in pull request #49: SLING-10123 Distribution agent queue processor should implement a backoff in case of retries for
mohiaror commented on a change in pull request #49:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/49#discussion_r594580822
##
File path:
src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java
##
@@ -147,6 +147,9 @@ private boolean processQueueItem(String queueName,
DistributionQueueEntry queueE
} catch (RecoverableDistributionException e) {
distributionLog.warn("[{}] PACKAGE-FAIL {}: could not
deliver {}, {}", queueName, requestId, distributionPackage.getId(),
e.getMessage());
distributionLog.debug("could not deliver package {}",
distributionPackage.getId(), e);
+// since there is a recoverable error, it is possible that
the same error is observed on the retry
+// we should add a linear backoff using random delay
before re-attempting to distribute the same item.
+addRandomDelay(queueItemStatus.getAttempts());
Review comment:
@actinium15 I thought you were suggesting to move this at the top of the
inner try block (because of the catch block you added in the example code). The
inner try block only tries to distribute a valid distribution package. However,
we can add this delay (based on greater than zero retries) at the top of the
outer try block. I will update the PR accordingly.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-9871) Specifying order of ACEs through repoinit directives
[
https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301813#comment-17301813
]
Ashish Chopra commented on SLING-9871:
--
hi [~enorman], [~bdelacretaz], I am sorry I couldn't respond to your calls for
feedback in-time.
I agree that documenting the order in which ACLs are created by repoinit
directives would definitely be a start, but I don't think that can be a
conclusion for this issue.
I raised this because our product uses Sling repoinit as a substitute of
[Jackrabbit Filevault packages|https://jackrabbit.apache.org/filevault/] for
creating ACLs in customer-owned paths of JCR repository (e.g., {{/content}}).
Since it is not a good practice (or even possible, at times) to create the
paths where ACEs are to be applied, we often use restrictions on parent
"root"-paths (e.g., over /content, or /content/dam) for different users/groups.
Developers often end up adding ACLs for users/groups in their own
feature-models. This is where the ability to determine (and specify order)
becomes extremely very important ({{set ACL}} statements present in different
feature models, if applied in a non-deterministic and non-specifiable manner,
can cause final access-control setup to differ significantly from what's
desired to create a secure deployment).
Not being able to order the ACLs once created, even when JCR APIs and
consequently
[Sling|https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#acls-and-principals-1]
and Filevault allow it
([through|http://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling#MERGE_PRESERVE]
[merge|http://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling#MERGE]
modes), will create a parity gap for our internal developers as well as our
customers. I worry that with sole reliance on repoinit directives to manage
Access Control, it may not be possible for us to correct severe security issues
should a flaw be discovered in the ACL setup at a given point in time.
bq. it would be simpler to create a new statement dedicated solely to
re-ordering the ACEs that already exist in an ACL and leave the "set ACL"
syntax alone? Maybe something like this that would be processed after all the
"set ACL" statements were processed
I personally find this approach amenable - this would be similar to how all
{{create path}} directives are applied before all {{set ACL}} directives (i.e.,
all {{order ACL}} directives can be applied after {{set ACL}} directives have
been processed). The order in which {{order ACLs}} directives are aggregated
across features can be same as that for {{set ACL}} directives (which I think
we all agree should be deterministic and documented).
That said, I think the vocabulary would need to evolve to target more specific
ACEs - e.g., we might need to (at least) need to account for deny and allow
ACEs while specifying an order.
[~angela], would you also have an opinion on this ticket in general, and the
[3rd proposal
here|https://issues.apache.org/jira/browse/SLING-9871?focusedCommentId=17298440=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17298440]
in particular?
> Specifying order of ACEs through repoinit directives
>
>
> Key: SLING-9871
> URL: https://issues.apache.org/jira/browse/SLING-9871
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Ashish Chopra
>Priority: Major
>
> As of writing this, repoinit processor (among other things not relevant to
> this JIRA) collects {{create path}} statements and {{set ACL}} statements
> declared in all the feature-models applicable to feature-aggregate under
> consideration.
> Upon repository initialization, it applies all the {{create path}}
> statements, followed by all the {{set ACL}} statements. However, the order in
> which {{set ACL}} statements declared across feature models are applied isn't
> defined (currently, it seems to be based on feature-model-name,
> alphabetically ascending).
> This causes issues at times because we want the order of the ACEs to be
> maintained (e.g., "deny"s for everyone at a given path must be the first ACE,
> followed by "allow"s for specific, non-system-user principals)
> Repoinit should be able to support this requirement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9929) Use PaxExamServer for HTTP-based integration testing
[
https://issues.apache.org/jira/browse/SLING-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301804#comment-17301804
]
Bertrand Delacretaz commented on SLING-9929:
[~olli] you're right that {{slingServlets}} is sufficient in such cases, I have
used that in the [junit-core
ITs|https://github.com/apache/sling-org-apache-sling-junit-core/blob/master/src/it/annotations-it/src/test/java/org/apache/sling/junit/annotations/AnnotationsTestSupport.java]
now, with use {{org.apache.sling.testing.paxexam 4.0.0-SNAPSHOT}}
> Use PaxExamServer for HTTP-based integration testing
>
>
> Key: SLING-9929
> URL: https://issues.apache.org/jira/browse/SLING-9929
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> We've discussed this in SLING-7993 and I have created a minimal example (with
> Karate, but other HTTP clients work similarly) at
> [https://github.com/bdelacretaz/karate-pax-exam]
> This ticket is meant to coordinate efforts around how to use the
> {{PaxExamServer}} utility to run "out-of-process" tests via HTTP against a
> minimal Sling instance setup using the
> https://github.com/apache/sling-org-apache-sling-testing-paxexam/ tools.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-9980) Junit Core ITs fail with jdk11
[
https://issues.apache.org/jira/browse/SLING-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301786#comment-17301786
]
Bertrand Delacretaz edited comment on SLING-9980 at 3/15/21, 5:23 PM:
--
Fixed with commits
[2811d3b8|https://github.com/apache/sling-org-apache-sling-junit-core/commit/2811d3b8f086a309ff9e79562db26cec53932bb5]
and
[88d700a|https://github.com/apache/sling-org-apache-sling-junit-core/commit/88d700a6589a0d080a84ac2f3183773d6794dea3],
using org.apache.sling.testing.paxexam 4.0.0-SNAPSHOT
[~cris] you're right that the servlets-annotations module has the same problem,
I have created SLING-10216 for that.
was (Author: bdelacretaz):
Fixed with commit
[2811d3b8|https://github.com/apache/sling-org-apache-sling-junit-core/commit/2811d3b8f086a309ff9e79562db26cec53932bb5],
using org.apache.sling.testing.paxexam 4.0.0-SNAPSHOT
[~cris] you're right that the servlets-annotations module has the same problem,
I have created SLING-10216 for that.
> Junit Core ITs fail with jdk11
> --
>
> Key: SLING-9980
> URL: https://issues.apache.org/jira/browse/SLING-9980
> Project: Sling
> Issue Type: Improvement
> Components: JUnit Core
>Affects Versions: JUnit Core 1.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: JUnit Core 1.1.2
>
>
> The integration tests under {{src/it/annotations-it}} fail with jdk11 as
> follows:
> {code}
> INFO] [INFO] Running org.apache.sling.junit.annotations.ReferenceIT
> [INFO] [main] INFO org.ops4j.pax.exam.spi.DefaultExamSystem - Pax Exam System
> (Version: 4.13.4) created.
> ...
> [INFO] WARNING: An illegal reflective access operation has occurred
> [INFO] WARNING: Illegal reflective access by
> org.apache.felix.framework.ext.ClassPathExtenderFactory$DefaultClassLoaderExtender
>
> (file:/Users/bert/workspace/apache/sling/sling-org-apache-sling-junit-core/target/it-repo/org/apache/felix/org.apache.felix.framework/6.0.3/org.apache.felix.framework-6.0.3.jar)
> to method java.net.URLClassLoader.addURL(java.net.URL)
> [INFO] WARNING: Please consider reporting this to the maintainers of
> org.apache.felix.framework.ext.ClassPathExtenderFactory$DefaultClassLoaderExtender
> [INFO] WARNING: Use --illegal-access=warn to enable warnings of further
> illegal reflective access operations
> ...
> [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 89.29 s <<< FAILURE! - in
> org.apache.sling.junit.annotations.ReferenceIT
> [INFO] [ERROR] org.apache.sling.junit.annotations.ReferenceIT Time elapsed:
> 89.27 s <<< ERROR!
> [INFO] org.ops4j.pax.exam.TestContainerException:
> org.osgi.framework.BundleException: Could not create bundle object.
> [INFO]at
> org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:168)
> [INFO]at
> org.ops4j.pax.exam.junit.PaxExamServer.before(PaxExamServer.java:87)
> [INFO]at
> org.apache.sling.junit.annotations.it@1.0.0/org.apache.sling.junit.annotations.ReferenceIT$1.before(ReferenceIT.java:61)
> ...
> [INFO] Caused by: org.osgi.framework.BundleException: Could not create bundle
> object.
> [INFO]at
> org.apache.felix.framework.Felix.installBundle(Felix.java:3312)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:120)
> [INFO]at
> org.ops4j.pax.swissbox.framework.RemoteFrameworkImpl.installBundle(RemoteFrameworkImpl.java:132)
> ...
> [INFO] Caused by: java.lang.UnsupportedOperationException: Unable to add
> extension bundle.
> [INFO]at
> org.apache.felix.framework.ExtensionManager.addExtensionBundle(ExtensionManager.java:430)
> [INFO]at
> org.apache.felix.framework.Felix.installBundle(Felix.java:3279)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:120)
> [INFO]at
> org.ops4j.pax.swissbox.framework.RemoteFrameworkImpl.installBundle(RemoteFrameworkImpl.java:132)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9871) Specifying order of ACEs through repoinit directives
[
https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301801#comment-17301801
]
Eric Norman commented on SLING-9871:
{quote}Agreed but I think that's on a "local" basis,
{quote}
That's nonsense, it would be doing exactly the same thing in the end.
> Specifying order of ACEs through repoinit directives
>
>
> Key: SLING-9871
> URL: https://issues.apache.org/jira/browse/SLING-9871
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Ashish Chopra
>Priority: Major
>
> As of writing this, repoinit processor (among other things not relevant to
> this JIRA) collects {{create path}} statements and {{set ACL}} statements
> declared in all the feature-models applicable to feature-aggregate under
> consideration.
> Upon repository initialization, it applies all the {{create path}}
> statements, followed by all the {{set ACL}} statements. However, the order in
> which {{set ACL}} statements declared across feature models are applied isn't
> defined (currently, it seems to be based on feature-model-name,
> alphabetically ascending).
> This causes issues at times because we want the order of the ACEs to be
> maintained (e.g., "deny"s for everyone at a given path must be the first ACE,
> followed by "allow"s for specific, non-system-user principals)
> Repoinit should be able to support this requirement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9871) Specifying order of ACEs through repoinit directives
[
https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301793#comment-17301793
]
Bertrand Delacretaz commented on SLING-9871:
bq. Re-ordering the ACEs has been done for many years...
Agreed but I think that's on a "local" basis, but here I'm afraid we might be
introducing possibly complicated orderings that would depend on repoinit
fragments defined in other Sling Features when those are aggregated.
I'm not opposed to that if there's a demonstrated need but I have a feeling
that here the problem is "just" the somewhat unpredictable aggregation of
features, which should IMO be handled elsewhere.
But, as you say, let's hear from Ashish.
> Specifying order of ACEs through repoinit directives
>
>
> Key: SLING-9871
> URL: https://issues.apache.org/jira/browse/SLING-9871
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Ashish Chopra
>Priority: Major
>
> As of writing this, repoinit processor (among other things not relevant to
> this JIRA) collects {{create path}} statements and {{set ACL}} statements
> declared in all the feature-models applicable to feature-aggregate under
> consideration.
> Upon repository initialization, it applies all the {{create path}}
> statements, followed by all the {{set ACL}} statements. However, the order in
> which {{set ACL}} statements declared across feature models are applied isn't
> defined (currently, it seems to be based on feature-model-name,
> alphabetically ascending).
> This causes issues at times because we want the order of the ACEs to be
> maintained (e.g., "deny"s for everyone at a given path must be the first ACE,
> followed by "allow"s for specific, non-system-user principals)
> Repoinit should be able to support this requirement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9776) Convert sling-scriptingbundle-maven-plugin into Bnd plugin
[ https://issues.apache.org/jira/browse/SLING-9776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301788#comment-17301788 ] Konrad Windszus commented on SLING-9776: As both bundle plugins (maven-bundle-plugin and bnd-maven-plugin) are based on Bnd I don't really see the need to provide this as standalone Mojo. What use case do you have in mind, which wouldn't work as Bnd plugin? > Convert sling-scriptingbundle-maven-plugin into Bnd plugin > -- > > Key: SLING-9776 > URL: https://issues.apache.org/jira/browse/SLING-9776 > Project: Sling > Issue Type: Improvement > Components: Scripting, Tooling >Affects Versions: Scripting Bundle Maven Plugin 0.2.2 >Reporter: Konrad Windszus >Priority: Major > > To directly enrich the Manifest instead just creating new project properties, > the functionality should be embedded in a Bnd plugin like we already have for > Sling Models at > https://github.com/apache/sling-org-apache-sling-bnd-models/blob/master/src/main/java/org/apache/sling/bnd/models/ModelsScannerPlugin.java. > I don't see a need to keep this as dedicated Maven plugin as all bundle > plugins are based on Bnd AFAIK. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9922) scriptingbundle-maven-plugin: Move "metadata" mojo to another default phase
[
https://issues.apache.org/jira/browse/SLING-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301787#comment-17301787
]
Konrad Windszus commented on SLING-9922:
Other plugins may preprocess the scripts directory in {{process-sources}} or
{{process-resources}} phase (e.g.
https://maven.apache.org/plugins/maven-resources-plugin/resources-mojo.html),
so a later phase seems the safer choice. WDYT?
> scriptingbundle-maven-plugin: Move "metadata" mojo to another default phase
> ---
>
> Key: SLING-9922
> URL: https://issues.apache.org/jira/browse/SLING-9922
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Affects Versions: Scripting Bundle Maven Plugin 0.2.2
>Reporter: Konrad Windszus
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.2.4
>
>
> Currently the "metadata" mojo is bound to phase "prepare-package".
> That does not work together with the bnd-maven-plugin which generates all
> metadata in phase "process-classes"
> (https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin#bnd-process-goal).
> Instead I propose the following default phase "process-classes" or "compile".
> Unfortunately it will share the phase with either the htl-maven-plugin or the
> bnd-maven-plugin.
> This becomes obsolete once SLING-9776 is implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9980) Junit Core ITs fail with jdk11
[
https://issues.apache.org/jira/browse/SLING-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-9980.
Resolution: Fixed
Fixed with commit
[2811d3b8|https://github.com/apache/sling-org-apache-sling-junit-core/commit/2811d3b8f086a309ff9e79562db26cec53932bb5],
using org.apache.sling.testing.paxexam 4.0.0-SNAPSHOT
[~cris] you're right that the servlets-annotations module has the same problem,
I have created SLING-10216 for that.
> Junit Core ITs fail with jdk11
> --
>
> Key: SLING-9980
> URL: https://issues.apache.org/jira/browse/SLING-9980
> Project: Sling
> Issue Type: Improvement
> Components: JUnit Core
>Affects Versions: JUnit Core 1.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: JUnit Core 1.1.2
>
>
> The integration tests under {{src/it/annotations-it}} fail with jdk11 as
> follows:
> {code}
> INFO] [INFO] Running org.apache.sling.junit.annotations.ReferenceIT
> [INFO] [main] INFO org.ops4j.pax.exam.spi.DefaultExamSystem - Pax Exam System
> (Version: 4.13.4) created.
> ...
> [INFO] WARNING: An illegal reflective access operation has occurred
> [INFO] WARNING: Illegal reflective access by
> org.apache.felix.framework.ext.ClassPathExtenderFactory$DefaultClassLoaderExtender
>
> (file:/Users/bert/workspace/apache/sling/sling-org-apache-sling-junit-core/target/it-repo/org/apache/felix/org.apache.felix.framework/6.0.3/org.apache.felix.framework-6.0.3.jar)
> to method java.net.URLClassLoader.addURL(java.net.URL)
> [INFO] WARNING: Please consider reporting this to the maintainers of
> org.apache.felix.framework.ext.ClassPathExtenderFactory$DefaultClassLoaderExtender
> [INFO] WARNING: Use --illegal-access=warn to enable warnings of further
> illegal reflective access operations
> ...
> [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 89.29 s <<< FAILURE! - in
> org.apache.sling.junit.annotations.ReferenceIT
> [INFO] [ERROR] org.apache.sling.junit.annotations.ReferenceIT Time elapsed:
> 89.27 s <<< ERROR!
> [INFO] org.ops4j.pax.exam.TestContainerException:
> org.osgi.framework.BundleException: Could not create bundle object.
> [INFO]at
> org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:168)
> [INFO]at
> org.ops4j.pax.exam.junit.PaxExamServer.before(PaxExamServer.java:87)
> [INFO]at
> org.apache.sling.junit.annotations.it@1.0.0/org.apache.sling.junit.annotations.ReferenceIT$1.before(ReferenceIT.java:61)
> ...
> [INFO] Caused by: org.osgi.framework.BundleException: Could not create bundle
> object.
> [INFO]at
> org.apache.felix.framework.Felix.installBundle(Felix.java:3312)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:120)
> [INFO]at
> org.ops4j.pax.swissbox.framework.RemoteFrameworkImpl.installBundle(RemoteFrameworkImpl.java:132)
> ...
> [INFO] Caused by: java.lang.UnsupportedOperationException: Unable to add
> extension bundle.
> [INFO]at
> org.apache.felix.framework.ExtensionManager.addExtensionBundle(ExtensionManager.java:430)
> [INFO]at
> org.apache.felix.framework.Felix.installBundle(Felix.java:3279)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:120)
> [INFO]at
> org.ops4j.pax.swissbox.framework.RemoteFrameworkImpl.installBundle(RemoteFrameworkImpl.java:132)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10216) Servlets annotations ITs fail with Java 11
Bertrand Delacretaz created SLING-10216:
---
Summary: Servlets annotations ITs fail with Java 11
Key: SLING-10216
URL: https://issues.apache.org/jira/browse/SLING-10216
Project: Sling
Issue Type: Bug
Components: Servlets
Affects Versions: Sling Servlet Annotations 1.2.4
Reporter: Bertrand Delacretaz
Similarly to SLING-9980 the tests fail with
{code}
[INFO] org.ops4j.pax.exam.TestContainerException:
org.osgi.framework.BundleException: Could not create bundle object.
[INFO] Caused by: org.osgi.framework.BundleException: Could not create bundle
object.
[INFO] Caused by: java.lang.UnsupportedOperationException: Unable to add
extension bundle.
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9871) Specifying order of ACEs through repoinit directives
[
https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301784#comment-17301784
]
Eric Norman commented on SLING-9871:
[~bdelacretaz] Ok, well I don't really agree that an "order ACL" statement
would be any more dangerous or "less simple" than assuming that the "set ACL"
statements would be invoked in any specific order. Re-ordering the ACEs has
been done for many years by
[https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#acls-and-principals-1]
and
[https://sling.apache.org/documentation/bundles/managing-permissions-jackrabbit-accessmanager.html#add-or-modify-permissions-1]
and I haven't seen anyone report any concerns.
But, with that being said, I am not the original reporter of this issue and it
isn't blocking any work for me at the moment. I'm not motivated to continue to
argue on the behalf of [~ashishc] when there has been no feedback or
acknowledgment of the proposals.
> Specifying order of ACEs through repoinit directives
>
>
> Key: SLING-9871
> URL: https://issues.apache.org/jira/browse/SLING-9871
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Ashish Chopra
>Priority: Major
>
> As of writing this, repoinit processor (among other things not relevant to
> this JIRA) collects {{create path}} statements and {{set ACL}} statements
> declared in all the feature-models applicable to feature-aggregate under
> consideration.
> Upon repository initialization, it applies all the {{create path}}
> statements, followed by all the {{set ACL}} statements. However, the order in
> which {{set ACL}} statements declared across feature models are applied isn't
> defined (currently, it seems to be based on feature-model-name,
> alphabetically ascending).
> This causes issues at times because we want the order of the ACEs to be
> maintained (e.g., "deny"s for everyone at a given path must be the first ACE,
> followed by "allow"s for specific, non-system-user principals)
> Repoinit should be able to support this requirement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9980) Junit Core ITs fail with jdk11
[
https://issues.apache.org/jira/browse/SLING-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-9980:
---
Fix Version/s: JUnit Core 1.1.2
> Junit Core ITs fail with jdk11
> --
>
> Key: SLING-9980
> URL: https://issues.apache.org/jira/browse/SLING-9980
> Project: Sling
> Issue Type: Improvement
> Components: JUnit Core
>Affects Versions: JUnit Core 1.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: JUnit Core 1.1.2
>
>
> The integration tests under {{src/it/annotations-it}} fail with jdk11 as
> follows:
> {code}
> INFO] [INFO] Running org.apache.sling.junit.annotations.ReferenceIT
> [INFO] [main] INFO org.ops4j.pax.exam.spi.DefaultExamSystem - Pax Exam System
> (Version: 4.13.4) created.
> ...
> [INFO] WARNING: An illegal reflective access operation has occurred
> [INFO] WARNING: Illegal reflective access by
> org.apache.felix.framework.ext.ClassPathExtenderFactory$DefaultClassLoaderExtender
>
> (file:/Users/bert/workspace/apache/sling/sling-org-apache-sling-junit-core/target/it-repo/org/apache/felix/org.apache.felix.framework/6.0.3/org.apache.felix.framework-6.0.3.jar)
> to method java.net.URLClassLoader.addURL(java.net.URL)
> [INFO] WARNING: Please consider reporting this to the maintainers of
> org.apache.felix.framework.ext.ClassPathExtenderFactory$DefaultClassLoaderExtender
> [INFO] WARNING: Use --illegal-access=warn to enable warnings of further
> illegal reflective access operations
> ...
> [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 89.29 s <<< FAILURE! - in
> org.apache.sling.junit.annotations.ReferenceIT
> [INFO] [ERROR] org.apache.sling.junit.annotations.ReferenceIT Time elapsed:
> 89.27 s <<< ERROR!
> [INFO] org.ops4j.pax.exam.TestContainerException:
> org.osgi.framework.BundleException: Could not create bundle object.
> [INFO]at
> org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:168)
> [INFO]at
> org.ops4j.pax.exam.junit.PaxExamServer.before(PaxExamServer.java:87)
> [INFO]at
> org.apache.sling.junit.annotations.it@1.0.0/org.apache.sling.junit.annotations.ReferenceIT$1.before(ReferenceIT.java:61)
> ...
> [INFO] Caused by: org.osgi.framework.BundleException: Could not create bundle
> object.
> [INFO]at
> org.apache.felix.framework.Felix.installBundle(Felix.java:3312)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:120)
> [INFO]at
> org.ops4j.pax.swissbox.framework.RemoteFrameworkImpl.installBundle(RemoteFrameworkImpl.java:132)
> ...
> [INFO] Caused by: java.lang.UnsupportedOperationException: Unable to add
> extension bundle.
> [INFO]at
> org.apache.felix.framework.ExtensionManager.addExtensionBundle(ExtensionManager.java:430)
> [INFO]at
> org.apache.felix.framework.Felix.installBundle(Felix.java:3279)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:120)
> [INFO]at
> org.ops4j.pax.swissbox.framework.RemoteFrameworkImpl.installBundle(RemoteFrameworkImpl.java:132)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9980) Junit Core ITs fail with jdk11
[
https://issues.apache.org/jira/browse/SLING-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-9980:
---
Affects Version/s: JUnit Core 1.1.0
> Junit Core ITs fail with jdk11
> --
>
> Key: SLING-9980
> URL: https://issues.apache.org/jira/browse/SLING-9980
> Project: Sling
> Issue Type: Improvement
> Components: JUnit Core
>Affects Versions: JUnit Core 1.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> The integration tests under {{src/it/annotations-it}} fail with jdk11 as
> follows:
> {code}
> INFO] [INFO] Running org.apache.sling.junit.annotations.ReferenceIT
> [INFO] [main] INFO org.ops4j.pax.exam.spi.DefaultExamSystem - Pax Exam System
> (Version: 4.13.4) created.
> ...
> [INFO] WARNING: An illegal reflective access operation has occurred
> [INFO] WARNING: Illegal reflective access by
> org.apache.felix.framework.ext.ClassPathExtenderFactory$DefaultClassLoaderExtender
>
> (file:/Users/bert/workspace/apache/sling/sling-org-apache-sling-junit-core/target/it-repo/org/apache/felix/org.apache.felix.framework/6.0.3/org.apache.felix.framework-6.0.3.jar)
> to method java.net.URLClassLoader.addURL(java.net.URL)
> [INFO] WARNING: Please consider reporting this to the maintainers of
> org.apache.felix.framework.ext.ClassPathExtenderFactory$DefaultClassLoaderExtender
> [INFO] WARNING: Use --illegal-access=warn to enable warnings of further
> illegal reflective access operations
> ...
> [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 89.29 s <<< FAILURE! - in
> org.apache.sling.junit.annotations.ReferenceIT
> [INFO] [ERROR] org.apache.sling.junit.annotations.ReferenceIT Time elapsed:
> 89.27 s <<< ERROR!
> [INFO] org.ops4j.pax.exam.TestContainerException:
> org.osgi.framework.BundleException: Could not create bundle object.
> [INFO]at
> org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:168)
> [INFO]at
> org.ops4j.pax.exam.junit.PaxExamServer.before(PaxExamServer.java:87)
> [INFO]at
> org.apache.sling.junit.annotations.it@1.0.0/org.apache.sling.junit.annotations.ReferenceIT$1.before(ReferenceIT.java:61)
> ...
> [INFO] Caused by: org.osgi.framework.BundleException: Could not create bundle
> object.
> [INFO]at
> org.apache.felix.framework.Felix.installBundle(Felix.java:3312)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:120)
> [INFO]at
> org.ops4j.pax.swissbox.framework.RemoteFrameworkImpl.installBundle(RemoteFrameworkImpl.java:132)
> ...
> [INFO] Caused by: java.lang.UnsupportedOperationException: Unable to add
> extension bundle.
> [INFO]at
> org.apache.felix.framework.ExtensionManager.addExtensionBundle(ExtensionManager.java:430)
> [INFO]at
> org.apache.felix.framework.Felix.installBundle(Felix.java:3279)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
> [INFO]at
> org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:120)
> [INFO]at
> org.ops4j.pax.swissbox.framework.RemoteFrameworkImpl.installBundle(RemoteFrameworkImpl.java:132)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-9776) Convert sling-scriptingbundle-maven-plugin into Bnd plugin
[ https://issues.apache.org/jira/browse/SLING-9776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301782#comment-17301782 ] Radu Cotescu edited comment on SLING-9776 at 3/15/21, 5:06 PM: --- I was talking to [~karlpauls] about this and we were thinking to allow the plugin to be both, depending on how you want to use it. WDYT about this idea? was (Author: radu.cotescu): I was talking to [~pauls] about this and we were thinking to allow the plugin to be both, depending on how you want to use it. WDYT about this idea? > Convert sling-scriptingbundle-maven-plugin into Bnd plugin > -- > > Key: SLING-9776 > URL: https://issues.apache.org/jira/browse/SLING-9776 > Project: Sling > Issue Type: Improvement > Components: Scripting, Tooling >Affects Versions: Scripting Bundle Maven Plugin 0.2.2 >Reporter: Konrad Windszus >Priority: Major > > To directly enrich the Manifest instead just creating new project properties, > the functionality should be embedded in a Bnd plugin like we already have for > Sling Models at > https://github.com/apache/sling-org-apache-sling-bnd-models/blob/master/src/main/java/org/apache/sling/bnd/models/ModelsScannerPlugin.java. > I don't see a need to keep this as dedicated Maven plugin as all bundle > plugins are based on Bnd AFAIK. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (SLING-9776) Convert sling-scriptingbundle-maven-plugin into Bnd plugin
[ https://issues.apache.org/jira/browse/SLING-9776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301782#comment-17301782 ] Radu Cotescu edited comment on SLING-9776 at 3/15/21, 5:06 PM: --- I was talking to [~pauls] about this and we were thinking to allow the plugin to be both, depending on how you want to use it. WDYT about this idea? was (Author: radu.cotescu): I was talking to [~kpauls] about this and we were thinking to allow the plugin to be both, depending on how you want to use it. WDYT about this idea? > Convert sling-scriptingbundle-maven-plugin into Bnd plugin > -- > > Key: SLING-9776 > URL: https://issues.apache.org/jira/browse/SLING-9776 > Project: Sling > Issue Type: Improvement > Components: Scripting, Tooling >Affects Versions: Scripting Bundle Maven Plugin 0.2.2 >Reporter: Konrad Windszus >Priority: Major > > To directly enrich the Manifest instead just creating new project properties, > the functionality should be embedded in a Bnd plugin like we already have for > Sling Models at > https://github.com/apache/sling-org-apache-sling-bnd-models/blob/master/src/main/java/org/apache/sling/bnd/models/ModelsScannerPlugin.java. > I don't see a need to keep this as dedicated Maven plugin as all bundle > plugins are based on Bnd AFAIK. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9776) Convert sling-scriptingbundle-maven-plugin into Bnd plugin
[ https://issues.apache.org/jira/browse/SLING-9776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301782#comment-17301782 ] Radu Cotescu commented on SLING-9776: - I was talking to [~kpauls] about this and we were thinking to allow the plugin to be both, depending on how you want to use it. WDYT about this idea? > Convert sling-scriptingbundle-maven-plugin into Bnd plugin > -- > > Key: SLING-9776 > URL: https://issues.apache.org/jira/browse/SLING-9776 > Project: Sling > Issue Type: Improvement > Components: Scripting, Tooling >Affects Versions: Scripting Bundle Maven Plugin 0.2.2 >Reporter: Konrad Windszus >Priority: Major > > To directly enrich the Manifest instead just creating new project properties, > the functionality should be embedded in a Bnd plugin like we already have for > Sling Models at > https://github.com/apache/sling-org-apache-sling-bnd-models/blob/master/src/main/java/org/apache/sling/bnd/models/ModelsScannerPlugin.java. > I don't see a need to keep this as dedicated Maven plugin as all bundle > plugins are based on Bnd AFAIK. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9922) scriptingbundle-maven-plugin: Move "metadata" mojo to another default phase
[ https://issues.apache.org/jira/browse/SLING-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu reassigned SLING-9922: --- Assignee: Radu Cotescu > scriptingbundle-maven-plugin: Move "metadata" mojo to another default phase > --- > > Key: SLING-9922 > URL: https://issues.apache.org/jira/browse/SLING-9922 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting Bundle Maven Plugin 0.2.2 >Reporter: Konrad Windszus >Assignee: Radu Cotescu >Priority: Major > Fix For: Scripting Bundle Maven Plugin 0.2.4 > > > Currently the "metadata" mojo is bound to phase "prepare-package". > That does not work together with the bnd-maven-plugin which generates all > metadata in phase "process-classes" > (https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin#bnd-process-goal). > Instead I propose the following default phase "process-classes" or "compile". > Unfortunately it will share the phase with either the htl-maven-plugin or the > bnd-maven-plugin. > This becomes obsolete once SLING-9776 is implemented. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9922) scriptingbundle-maven-plugin: Move "metadata" mojo to another default phase
[
https://issues.apache.org/jira/browse/SLING-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301781#comment-17301781
]
Radu Cotescu commented on SLING-9922:
-
What about {{process-sources}}? In the end this is what the mojo does - it
reads the project's file-system structure to determine the provided and
required capabilities.
> scriptingbundle-maven-plugin: Move "metadata" mojo to another default phase
> ---
>
> Key: SLING-9922
> URL: https://issues.apache.org/jira/browse/SLING-9922
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Affects Versions: Scripting Bundle Maven Plugin 0.2.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.2.4
>
>
> Currently the "metadata" mojo is bound to phase "prepare-package".
> That does not work together with the bnd-maven-plugin which generates all
> metadata in phase "process-classes"
> (https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin#bnd-process-goal).
> Instead I propose the following default phase "process-classes" or "compile".
> Unfortunately it will share the phase with either the htl-maven-plugin or the
> bnd-maven-plugin.
> This becomes obsolete once SLING-9776 is implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10105) Onboard the Apache Sling Scripting SPI bundle to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301776#comment-17301776 ] Radu Cotescu commented on SLING-10105: -- Thanks a lot, Fabrice! > Onboard the Apache Sling Scripting SPI bundle to SonarCloud > --- > > Key: SLING-10105 > URL: https://issues.apache.org/jira/browse/SLING-10105 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Radu Cotescu >Assignee: Fabrice Bellingard >Priority: Major > Fix For: Scripting SPI 1.0.0 > > > The Apache Sling Servlets Resolver API bundle is a new Sling module that > should be onboarded to SonarCloud. See > https://github.com/apache/sling-org-apache-sling-servlets-resolver-api. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10105) Onboard the Apache Sling Scripting SPI bundle to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-10105. -- Resolution: Fixed > Onboard the Apache Sling Scripting SPI bundle to SonarCloud > --- > > Key: SLING-10105 > URL: https://issues.apache.org/jira/browse/SLING-10105 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Radu Cotescu >Assignee: Fabrice Bellingard >Priority: Major > Fix For: Scripting SPI 1.0.0 > > > The Apache Sling Servlets Resolver API bundle is a new Sling module that > should be onboarded to SonarCloud. See > https://github.com/apache/sling-org-apache-sling-servlets-resolver-api. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10113) data-sly-resource throwing RecursionTooDeepException
[
https://issues.apache.org/jira/browse/SLING-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301772#comment-17301772
]
Radu Cotescu commented on SLING-10113:
--
[~MFlock], you will have to report AEM bugs to Adobe in order to officially get
support and this is due to the fact that AEM provides its own equivalent of the
{{ResourceRuntimeExtension}}.
> data-sly-resource throwing RecursionTooDeepException
>
>
> Key: SLING-10113
> URL: https://issues.apache.org/jira/browse/SLING-10113
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Marvin Flock
>Priority: Major
> Attachments: image-2021-02-01-17-40-19-873.png
>
>
> AEM Version 6.5.7
> While using data-sly-resource with a path, I get a RecursionTooDeepException.
> See -SLING-7685- for Similarity
> I currently cant make hold of the behavior, using
> __
> will include the current page infinite times (at least it tries) instead of
> the target page
> while using something like this:
> __
> will render the curentPage with the RecursionTooDeepException.
> The HTL Engine I am using is of the following version:
> !image-2021-02-01-17-40-19-873.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9958) HTL Scripting Engine: Document supported encodings
[
https://issues.apache.org/jira/browse/SLING-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301758#comment-17301758
]
Radu Cotescu commented on SLING-9958:
-
The HTL Compiler uses a Reader to read the HTML file it will compile -
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/blob/246afa39ba92bc8aaf6e1042e393aeed4823a92b/src/main/java/org/apache/sling/scripting/sightly/compiler/SightlyCompiler.java#L183.
This will in turn have the encoding the client defined:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/blob/246afa39ba92bc8aaf6e1042e393aeed4823a92b/src/main/java/org/apache/sling/scripting/sightly/compiler/CompilationUnit.java#L43
In the Script Engine implementation, we again use a {{Reader}}. However, this
is controlled by the {{DefaultSlingScript}} and defaults to UTF-8:
https://github.com/apache/sling-org-apache-sling-scripting-core/blob/3d910d1624c940b390e9163c24b6ffaa24287262/src/main/java/org/apache/sling/scripting/core/impl/DefaultSlingScript.java#L157
> HTL Scripting Engine: Document supported encodings
> --
>
> Key: SLING-9958
> URL: https://issues.apache.org/jira/browse/SLING-9958
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Reporter: Konrad Windszus
>Assignee: Radu Cotescu
>Priority: Major
>
> Neither from the HTL spec (https://github.com/adobe/htl-spec) nor from the
> documentation at
> https://sling.apache.org/documentation/bundles/scripting/scripting-htl.html
> it is clear which encoding is supported for *.html files by the Sightly
> Compiler.
> I guess it assumes UTF-8, but it would be good to document that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10215) repoinit analyser fails if there is no repoinit section
[ https://issues.apache.org/jira/browse/SLING-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301751#comment-17301751 ] Carsten Ziegeler commented on SLING-10215: -- Looking again at the message, I think this issue is invalid - clearly repoinit had a line 15 so it is not empty :) I also checked the cp2fm converter and that one only generates repoinit, if the project actually has some repoinit. > repoinit analyser fails if there is no repoinit section > --- > > Key: SLING-10215 > URL: https://issues.apache.org/jira/browse/SLING-10215 > Project: Sling > Issue Type: Bug > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 1.3.22 >Reporter: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model Analyser 1.3.24 > > > As reported by [~joerghoh]: > the analyzer complains about an invalid repoinit, but the created test > project does not contain any repoinit statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#issuecomment-799551602 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_coverage=list) [90.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher
sonarcloud[bot] removed a comment on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#issuecomment-799461267 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_coverage=list) [75.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher
stbischof commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r594482358
##
File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java
##
@@ -312,8 +359,15 @@ public static void main(final String[] args) {
// check if launcher has already been created
final LauncherConfig launcherConfig = new LauncherConfig();
-parseArgs(launcherConfig, args);
-
+Options options= parseArgs(launcherConfig, args);
+
+if(launcherConfig.getFeatureFiles().isEmpty()) {
+Main.LOG().warn("Missing Feature-File(s). Please set an
Feature-File to run.");
+
Review comment:
my last commit wasn't correct, because the Exception was catched before.
Sorry!
I think it would be better this way.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher
stbischof commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r594482358
##
File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java
##
@@ -312,8 +359,15 @@ public static void main(final String[] args) {
// check if launcher has already been created
final LauncherConfig launcherConfig = new LauncherConfig();
-parseArgs(launcherConfig, args);
-
+Options options= parseArgs(launcherConfig, args);
+
+if(launcherConfig.getFeatureFiles().isEmpty()) {
+Main.LOG().warn("Missing Feature-File(s). Please set an
Feature-File to run.");
+
Review comment:
my last commit wasn't correct, because the Exception was catched before.
I think it would be better this way.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (SLING-10177) Multiple data-sly-attribute blocks on one HTL tag don't work correctty
[
https://issues.apache.org/jira/browse/SLING-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu closed SLING-10177.
> Multiple data-sly-attribute blocks on one HTL tag don't work correctty
> --
>
> Key: SLING-10177
> URL: https://issues.apache.org/jira/browse/SLING-10177
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
>
> From [https://github.com/adobe/htl-spec/issues/92:]
> When multiple {{data-sly-attribute="$\{model.map\}"}} are used on a single
> HTL element, only the last one is evaluated.
> Given that the {{model}} and {{model2}} have a method {{map}} that returns a
> String -> String map, the following HTL code will not render attributes
> defined in {{model2.map}}
> {code:html}
> // model1.map -> \{'a' : 'val a'}
> // model2.map -> \{'b': 'val b' }
>data-sly-use.model1="com.Model1"
> data-sly-use.model2="com.Model2"
> data-sly-attribute="${model1.map}"
> data-sly-attribute="${model2.map}">
>
> {code}
> h3. Expected Behaviour
> Expected HTML output
> {code:html}
>
> {code}
> h3. Actual Behaviour
> Actual HTL output
> {code:html}
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10177) Multiple data-sly-attribute blocks on one HTL tag don't work correctty
[
https://issues.apache.org/jira/browse/SLING-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-10177.
--
Fix Version/s: (was: Scripting HTL Engine 1.4.8-1.4.0)
Resolution: Invalid
> Multiple data-sly-attribute blocks on one HTL tag don't work correctty
> --
>
> Key: SLING-10177
> URL: https://issues.apache.org/jira/browse/SLING-10177
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
>
> From [https://github.com/adobe/htl-spec/issues/92:]
> When multiple {{data-sly-attribute="$\{model.map\}"}} are used on a single
> HTL element, only the last one is evaluated.
> Given that the {{model}} and {{model2}} have a method {{map}} that returns a
> String -> String map, the following HTL code will not render attributes
> defined in {{model2.map}}
> {code:html}
> // model1.map -> \{'a' : 'val a'}
> // model2.map -> \{'b': 'val b' }
>data-sly-use.model1="com.Model1"
> data-sly-use.model2="com.Model2"
> data-sly-attribute="${model1.map}"
> data-sly-attribute="${model2.map}">
>
> {code}
> h3. Expected Behaviour
> Expected HTML output
> {code:html}
>
> {code}
> h3. Actual Behaviour
> Actual HTL output
> {code:html}
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature-launcher] karlpauls commented on a change in pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher
karlpauls commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r594400286
##
File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java
##
@@ -312,8 +359,15 @@ public static void main(final String[] args) {
// check if launcher has already been created
final LauncherConfig launcherConfig = new LauncherConfig();
-parseArgs(launcherConfig, args);
-
+Options options= parseArgs(launcherConfig, args);
+
+if(launcherConfig.getFeatureFiles().isEmpty()) {
+Main.LOG().warn("Missing Feature-File(s). Please set an
Feature-File to run.");
+
Review comment:
thats is fine - maybe re-throw the exception if it isn't because of a no
features (just in case it had another cause).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#issuecomment-799461267 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_coverage=list) [75.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher
sonarcloud[bot] removed a comment on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#issuecomment-798809004 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=18=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=18=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_coverage=list) [90.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=18=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher
stbischof commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r594379405
##
File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java
##
@@ -312,8 +359,15 @@ public static void main(final String[] args) {
// check if launcher has already been created
final LauncherConfig launcherConfig = new LauncherConfig();
-parseArgs(launcherConfig, args);
-
+Options options= parseArgs(launcherConfig, args);
+
+if(launcherConfig.getFeatureFiles().isEmpty()) {
+Main.LOG().warn("Missing Feature-File(s). Please set an
Feature-File to run.");
+
Review comment:
I would like to handle this in the Main. There it is easier and I
catched the IllegalStateException.
Hope this is also okay for you
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] karlpauls commented on a change in pull request #18: SLING-10187 - Provide a Dockerfile that delegates all env vars to sling launcher
karlpauls commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r594349562
##
File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java
##
@@ -312,8 +359,15 @@ public static void main(final String[] args) {
// check if launcher has already been created
final LauncherConfig launcherConfig = new LauncherConfig();
-parseArgs(launcherConfig, args);
-
+Options options= parseArgs(launcherConfig, args);
+
+if(launcherConfig.getFeatureFiles().isEmpty()) {
+Main.LOG().warn("Missing Feature-File(s). Please set an
Feature-File to run.");
+
Review comment:
@stbischof - the rest looks good to me now but this one would still need
to be addressed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #19: SLING-10211: add Bundle-Metadata, build with bnd
sonarcloud[bot] commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/19#issuecomment-799416877 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=19=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=19=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=19=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=19=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #19: SLING-10211: add Bundle-Metadata, build with bnd
sonarcloud[bot] removed a comment on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/19#issuecomment-798996864 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=19=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=19=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=19=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=19=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=19=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #19: SLING-10211: add Bundle-Metadata, build with bnd
stbischof commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/19#discussion_r594330525
##
File path: pom.xml
##
@@ -41,34 +42,44 @@
-
-org.apache.maven.plugins
-maven-dependency-plugin
-
-
-unpack-dependencies
-prepare-package
-
-unpack-dependencies
-
-
-META-INF/**
-
${project.build.directory}/classes
-false
-true
-
osgi.core,commons-text,commons-lang3,org.apache.sling.feature,org.osgi.util.function,org.apache.felix.cm.json,org.apache.sling.commons.johnzon,org.apache.felix.converter,commons-cli,slf4j-api,slf4j-simple
+
+biz.aQute.bnd
+bnd-maven-plugin
+
+
[GitHub] [sling-site] kwin opened a new pull request #57: SLING-10150 clarify handling of multivalue properties sling:hideChildren
kwin opened a new pull request #57: URL: https://github.com/apache/sling-site/pull/57 and sling:hideProperties This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] karlpauls commented on a change in pull request #19: SLING-10211: add Bundle-Metadata, build with bnd
karlpauls commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/19#discussion_r594269283
##
File path: pom.xml
##
@@ -41,34 +42,44 @@
-
-org.apache.maven.plugins
-maven-dependency-plugin
-
-
-unpack-dependencies
-prepare-package
-
-unpack-dependencies
-
-
-META-INF/**
-
${project.build.directory}/classes
-false
-true
-
osgi.core,commons-text,commons-lang3,org.apache.sling.feature,org.osgi.util.function,org.apache.felix.cm.json,org.apache.sling.commons.johnzon,org.apache.felix.converter,commons-cli,slf4j-api,slf4j-simple
+
+biz.aQute.bnd
+bnd-maven-plugin
+
+
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #19: SLING-10211: add Bundle-Metadata, build with bnd
stbischof commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/19#discussion_r594263613
##
File path: pom.xml
##
@@ -41,34 +42,44 @@
-
-org.apache.maven.plugins
-maven-dependency-plugin
-
-
-unpack-dependencies
-prepare-package
-
-unpack-dependencies
-
-
-META-INF/**
-
${project.build.directory}/classes
-false
-true
-
osgi.core,commons-text,commons-lang3,org.apache.sling.feature,org.osgi.util.function,org.apache.felix.cm.json,org.apache.sling.commons.johnzon,org.apache.felix.converter,commons-cli,slf4j-api,slf4j-simple
+
+biz.aQute.bnd
+bnd-maven-plugin
+
+
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #388 is BROKEN
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/388/
for details.
No further emails will be sent until the status of the build is changed.
Build log follows below:
[...truncated 29 lines...]
Timeout set to expire after 30 min without activity
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Init)
[Pipeline] checkout
The recommended git tool is: NONE
using credential sling-github-token
Fetching changes from the remote Git repository
Fetching without tags
> git rev-parse --is-inside-work-tree # timeout=10
> git config remote.origin.url
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git #
> timeout=10
Fetching upstream changes from
https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> git --version # timeout=10
> git --version # 'git version 2.17.1'
using GIT_ASKPASS to set credentials Personal access token for Github
repository access. Use with Apache Sling jobs only.
> git fetch --no-tags --progress --
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> +refs/heads/master:refs/remotes/origin/master # timeout=10
Checking out Revision e68051d95a23f4112e2c6c81c4175a018394c10b (master)
Commit message: "mvn clean launcher folder"
> git config core.sparsecheckout # timeout=10
> git checkout -f e68051d95a23f4112e2c6c81c4175a018394c10b # timeout=10
> git rev-list --no-walk e68051d95a23f4112e2c6c81c4175a018394c10b # timeout=10
[Pipeline] sh
+ git clean -fdx
Removing target/
[Pipeline] sh
+ git config remote.origin.url
[Pipeline] fileExists
[Pipeline] readJSON
[Pipeline] echo
Jenkins overrides: [rebuildFrequency:@daily, sonarQubeEnabled:false, jdks:[8,
11, 15], archivePatterns:[**/logs/*.log],
emailRecipients:[dev@sling.apache.org],
upstreamProjects:[../sling-org-apache-sling-starter/master]]
[Pipeline] echo
Final job config: [jdks:[8, 11, 15],
upstreamProjects:[../sling-org-apache-sling-starter/master],
archivePatterns:[**/logs/*.log], mavenGoal:, additionalMavenParams:,
rebuildFrequency:@daily, enabled:true, emailRecipients:[dev@sling.apache.org],
sonarQubeEnabled:false, sonarQubeUseAdditionalMavenParams:true,
sonarQubeAdditionalParams:, repoName:sling-org-apache-sling-launchpad-testing]
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Configure Job)
[Pipeline] properties
[Pipeline] }
[Pipeline] // stage
[Pipeline] readMavenPom
[Pipeline] stage
[Pipeline] { (Build (Java 8, deploy))
[Pipeline] withMaven
[withMaven] Options:
[org.jenkinsci.plugins.pipeline.maven.publishers.GeneratedArtifactsPublisher[disabled=false],
JunitTestsPublisher[disabled=false,healthScaleFactor=,keepLongStdio=false,ignoreAttachments=false],
org.jenkinsci.plugins.pipeline.maven.publishers.TasksScannerPublisher[disabled='false',
healthy='', unHealthy='', thresholdLimit='low'],
org.jenkinsci.plugins.pipeline.maven.publishers.DependenciesFingerprintPublisher[disabled=false,
scopes=[compile, provided, runtime], versions={snapshot:true, release:false}]]
[withMaven] Available options:
[withMaven] using JDK installation jdk_1.8_latest
[withMaven] using Maven installation 'maven_3_latest'
[Pipeline] {
[Pipeline] sh
+ mvn -U clean deploy -Pci
- withMaven Wrapper script -
Picked up JAVA_TOOL_OPTIONS:
-Dmaven.ext.class.path="/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMavenea46f0fe/pipeline-maven-spy.jar"
-Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMavenea46f0fe"
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/jenkins/tools/maven/latest3
Java version: 1.8.0_281, vendor: Oracle Corporation, runtime:
/usr/local/asfpackages/java/oraclejdk-1.8.0-281/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-118-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate
/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMavenea46f0fe/maven-spy-20210315-111740-2318500840574989495915.log.tmp
...
[INFO] Scanning for projects...
[INFO]
[INFO] < org.apache.sling:org.apache.sling.launchpad.testing >-
[INFO] Building Apache Sling Launchpad Testing 12-SNAPSHOT
[INFO] [ jar ]-
[INFO] Downloading from Nexus:
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/maven-metadata.xml
[INFO] Downloaded from Nexus:
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/maven-metadata.xml
(1.0 kB at 1.1 kB/s)
[INFO] Downloading from Nexus:
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/org.apache.sling.launchpad.integr
Re: [VOTE] Release Apache Sling Feature Model Content Extension 1.0.10
+1 David On Mon, 15 Mar 2021 at 09:04, Radu Cotescu wrote: > +1 > > > On 13 Mar 2021, at 01:26, Karl Pauls wrote: > > > > Please vote to approve these releases: > > > > [ ] +1 Approve the releases > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > >
[jira] [Commented] (SLING-10215) repoinit analyser fails if there is no repoinit section
[ https://issues.apache.org/jira/browse/SLING-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301558#comment-17301558 ] Carsten Ziegeler commented on SLING-10215: -- If that's the case, I think we should do two fixed: - fix the analyser that it skips empty values - create an issue for the cp2fm converter to not create a repoinit section if no repoinit is available > repoinit analyser fails if there is no repoinit section > --- > > Key: SLING-10215 > URL: https://issues.apache.org/jira/browse/SLING-10215 > Project: Sling > Issue Type: Bug > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 1.3.22 >Reporter: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model Analyser 1.3.24 > > > As reported by [~joerghoh]: > the analyzer complains about an invalid repoinit, but the created test > project does not contain any repoinit statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (SLING-10215) repoinit analyser fails if there is no repoinit section
[
https://issues.apache.org/jira/browse/SLING-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301555#comment-17301555
]
A. J. David Bosschaert edited comment on SLING-10215 at 3/15/21, 10:03 AM:
---
Hi [~cziegeler] that could very well be. This problem was observed with the
[aemanalyser-maven-plugin|https://github.com/adobe/aemanalyser-maven-plugin]
which converts the content packages first.
Basically it was reporting an error like this appeared on a project does not
contain any repoinit statement:
{code}
[ERROR] repoinit: Parsing error in repoinit from extension : Encountered "" at
line 15, column 37.
Was expecting one of:
[ERROR] Analyser detected errors on feature
{code}
was (Author: davidb):
Hi [~cziegeler] that could very well be. This problem was observed with the
[aemanalyser-maven-plugin|https://github.com/adobe/aemanalyser-maven-plugin]
which converts the content packages first.
Basically it was reporting an error like this appeared on a project does not
contain any repoinit statement
:{code}
[ERROR] repoinit: Parsing error in repoinit from extension : Encountered "" at
line 15, column 37.
Was expecting one of:
[ERROR] Analyser detected errors on feature
{code}
> repoinit analyser fails if there is no repoinit section
> ---
>
> Key: SLING-10215
> URL: https://issues.apache.org/jira/browse/SLING-10215
> Project: Sling
> Issue Type: Bug
> Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.22
>Reporter: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Analyser 1.3.24
>
>
> As reported by [~joerghoh]:
> the analyzer complains about an invalid repoinit, but the created test
> project does not contain any repoinit statement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-10215) repoinit analyser fails if there is no repoinit section
[
https://issues.apache.org/jira/browse/SLING-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301555#comment-17301555
]
A. J. David Bosschaert edited comment on SLING-10215 at 3/15/21, 10:02 AM:
---
Hi [~cziegeler] that could very well be. This problem was observed with the
[aemanalyser-maven-plugin|https://github.com/adobe/aemanalyser-maven-plugin]
which converts the content packages first.
Basically it was reporting an error like this appeared on a project does not
contain any repoinit statement
:{code}
[ERROR] repoinit: Parsing error in repoinit from extension : Encountered "" at
line 15, column 37.
Was expecting one of:
[ERROR] Analyser detected errors on feature
{code}
was (Author: davidb):
Hi [~cziegeler] that could very well be. This problem was observed with the
[aemanalyser-maven-plugin|https://github.com/adobe/aemanalyser-maven-plugin]
which converts the content packages first.
> repoinit analyser fails if there is no repoinit section
> ---
>
> Key: SLING-10215
> URL: https://issues.apache.org/jira/browse/SLING-10215
> Project: Sling
> Issue Type: Bug
> Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.22
>Reporter: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Analyser 1.3.24
>
>
> As reported by [~joerghoh]:
> the analyzer complains about an invalid repoinit, but the created test
> project does not contain any repoinit statement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10215) repoinit analyser fails if there is no repoinit section
[ https://issues.apache.org/jira/browse/SLING-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301555#comment-17301555 ] A. J. David Bosschaert commented on SLING-10215: Hi [~cziegeler] that could very well be. This problem was observed with the [aemanalyser-maven-plugin|https://github.com/adobe/aemanalyser-maven-plugin] which converts the content packages first. > repoinit analyser fails if there is no repoinit section > --- > > Key: SLING-10215 > URL: https://issues.apache.org/jira/browse/SLING-10215 > Project: Sling > Issue Type: Bug > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 1.3.22 >Reporter: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model Analyser 1.3.24 > > > As reported by [~joerghoh]: > the analyzer complains about an invalid repoinit, but the created test > project does not contain any repoinit statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10150) Sling Resource Merger completely hides parent when whitelisting in combination with asterisk is used for sling:hideChildren
[ https://issues.apache.org/jira/browse/SLING-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-10150. --- > Sling Resource Merger completely hides parent when whitelisting in > combination with asterisk is used for sling:hideChildren > --- > > Key: SLING-10150 > URL: https://issues.apache.org/jira/browse/SLING-10150 > Project: Sling > Issue Type: Bug >Affects Versions: Resource Merger 1.3.10 >Reporter: Henry Kuijpers >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Merger 1.4.0 > > Time Spent: 2h > Remaining Estimate: 0h > > Provided a failing test case here: > https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/3/files > TODO: Fix > When trying to configure a whitelisting approach to inheriting nodes from a > parent (i.e. through resource super type, or through overlaying), the > following way: > /apps/base/test/tabs/undesired-tab > /apps/base/test/tabs/desired-tab > /apps/base/test/tabs/desired-tab/items/field@title="title" > & > /apps/overlay/test/tabs@sling:hideChildren="[!desired-tab,*]" > /apps/overlay/test/tabs/desired-tab/items/field@description="test" > One would expect that requesting the children of /merged/test/tabs would > yield the "desired-tab" only, i.e. "undesired-tab" (and other nodes not > whitelisted) being hidden. This is working as expected. > One would also expect the "desired-tab" to have the properties of the > base-structure as well as the properties of the overlay-structure. This is > also working as expected. > One would expect that the underlying nodes of "desired-tab" from the base > would remain intact and would be merged with the underlying nodes of > "desired-tab" in the overlay. So, while listing the items of desired-tab, one > would expect: > MergedResource containing properties [title=test, description=test] > consisting of original resources > [/apps/base/test/tabs/desired-tab/items/field, > /apps/overlay/test/tabs/desired-tab/items/field] > However, instead, the following is returned: > MergedResource containing properties [description=test] consisting of > original resources [/apps/overlay/test/tabs/desired-tab/items/field] > So, the original "base" resource is not considered anymore! > I believe the issue is in MergingResourceProvider.ParentHidingHandler, in the > constructor, actually. At some point, it decides that the parent resource > (which indeed has the sling:hideChildren property defined) defines an exclude > entry which is "*" and adds that entry to the list. > Then, when the class starts checking the parent of the parent (marked with > "// also check on the parent's parent whether that was hiding the parent") - > There it will find that asterisk exclude that was defined on the parent, not > taking into account that it was preceded by a whitelisting "!desired-tab" - > Removing the parent of the parent's children entirely. > I believe this should be changed into a more robust way of handling this > use-case. Probably the asterisk exclude can be global(?), even though it > should still be desired that any child of the parent still is able to remove > that exclude. But whenever those excludes are considered, also the includes > that were preceding it should be considered to figure out if it's a real > include in the case of that specific path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10168) Migrate to Bundle Parent 41 and OSGi annotations
[ https://issues.apache.org/jira/browse/SLING-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-10168. --- > Migrate to Bundle Parent 41 and OSGi annotations > > > Key: SLING-10168 > URL: https://issues.apache.org/jira/browse/SLING-10168 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Resource Merger 1.3.10 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Merger 1.4.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-5469) Resource Merger: Add some name prefixing mechanism for properties which are used by the resource merger itself
[
https://issues.apache.org/jira/browse/SLING-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus closed SLING-5469.
--
> Resource Merger: Add some name prefixing mechanism for properties which are
> used by the resource merger itself
> --
>
> Key: SLING-5469
> URL: https://issues.apache.org/jira/browse/SLING-5469
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Resource Merger 1.2.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Resource Merger 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently within the resource merger it is not possible to
> # use the {{jcr:primaryType}} of the underlying resource, while the
> overlaid/overridden resource has a different {{jcr:primaryType}}.
> That is a problem because for a JCR the primaryType is mandatory for each
> node. Some node type definitions don't allow arbitrary property names like
> {{sling:hideResource}}. To be able to use those properties (which are only
> relevant up the point where the resource has been merged) you might need to
> use a more relaxed node type. Still you don't want that relaxed node type to
> appear as primaryType in the merged resource.
> # use the {{sling:resourceSuperType}} from the underlying resource, while the
> overridden resource has a different {{sling:resourceSuperType}}.
> This is kind of a edge case because sling:resourceSuperType would be used for
> two different things here:
> ** for getting the underlying resource path for the
> {{OverridingResourcePicker}}
> ** for the request resolution of the merged resource
> Sometime the value for each of the cases would be different.
> Therefore I propose a general property name mangling mechanism which allows
> someone to use a prefix like {{sling-resource-merging_}} for the properties,
> which are during the resource merging exposed as properties without the
> prefix. One example for case 1):
> {code}
> /apps/my/resource
> - jcr:primaryType=nt:folder
> - sling:resourceSuperType=apps/my/super/resource
> - sling:hideProperties=customNodeTypePrefix:property1
> - jcr:sling-resource-merging_primaryTypemyCustomNodeRestrictedNodeType
> /apps/my/super/resource
> - jcr:primaryType=myCustomNodeRestrictedNodeType
> - customNodeTypePrefix:property1=test
> - customNodeTypePrefix:property2=test
> /mnt/override/apps/my/resource
> - jcrPrimaryType=nt:unstructured (but should be
> myCustomNodeRestrictedNodeType)
> - customNodeTypePrefix:property2=test
> {code}
> In this example it is impossible to let my merged resource have the nodeType
> {{myCustomNodeRestrictedNodeType}} (because that simply does not allow the
> property {{sling:hideProperties}} to be set in {{/apps/my/resource}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[RESULT] [VOTE] Release Apache Sling Resource Merger 1.4.0
Hi, The vote has passed with the following result : +1 (binding): Robert, Stefan, Radu and myself. I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad > On 10. Mar 2021, at 10:13, Konrad Windszus wrote: > > Hi, > > We solved 3 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12349943 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2419/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2419 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Thanks, > Konrad
[jira] [Commented] (SLING-10215) repoinit analyser fails if there is no repoinit section
[ https://issues.apache.org/jira/browse/SLING-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301522#comment-17301522 ] Carsten Ziegeler commented on SLING-10215: -- The analyser only acts on existing OSGi configurations and an existing repoinit extension What is the actual problem? Could it maybe be that the cp2fm converter creates an empty repoinit extension? Which is then evaluated as invalid? > repoinit analyser fails if there is no repoinit section > --- > > Key: SLING-10215 > URL: https://issues.apache.org/jira/browse/SLING-10215 > Project: Sling > Issue Type: Bug > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 1.3.22 >Reporter: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model Analyser 1.3.24 > > > As reported by [~joerghoh]: > the analyzer complains about an invalid repoinit, but the created test > project does not contain any repoinit statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10215) repoinit analyser fails if there is no repoinit section
A. J. David Bosschaert created SLING-10215: -- Summary: repoinit analyser fails if there is no repoinit section Key: SLING-10215 URL: https://issues.apache.org/jira/browse/SLING-10215 Project: Sling Issue Type: Bug Components: Feature Model Analyser Affects Versions: Feature Model Analyser 1.3.22 Reporter: A. J. David Bosschaert Fix For: Feature Model Analyser 1.3.24 As reported by [~joerghoh]: the analyzer complains about an invalid repoinit, but the created test project does not contain any repoinit statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling Feature Model Content Extension 1.0.10
+1 > On 13 Mar 2021, at 01:26, Karl Pauls wrote: > > Please vote to approve these releases: > > [ ] +1 Approve the releases > [ ] 0 Don't care > [ ] -1 Don't release, because ...
[GitHub] [sling-org-apache-sling-feature-launcher] karlpauls commented on a change in pull request #19: SLING-10211: add Bundle-Metadata, build with bnd
karlpauls commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/19#discussion_r594155190
##
File path: pom.xml
##
@@ -41,34 +42,44 @@
-
-org.apache.maven.plugins
-maven-dependency-plugin
-
-
-unpack-dependencies
-prepare-package
-
-unpack-dependencies
-
-
-META-INF/**
-
${project.build.directory}/classes
-false
-true
-
osgi.core,commons-text,commons-lang3,org.apache.sling.feature,org.osgi.util.function,org.apache.felix.cm.json,org.apache.sling.commons.johnzon,org.apache.felix.converter,commons-cli,slf4j-api,slf4j-simple
+
+biz.aQute.bnd
+bnd-maven-plugin
+
+
Re: [VOTE] Release Apache Sling Resource Merger 1.4.0
+1 > On 10 Mar 2021, at 10:13, Konrad Windszus wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...
Re: [VOTE] Release Apache Sling Feature Model Content Extension 1.0.10
+1 regards, Karl On Sat, Mar 13, 2021 at 3:10 PM Carsten Ziegeler wrote: > > +1 > > Carsten > > Am 13.03.2021 um 01:26 schrieb Karl Pauls: > > We solved 2 issue in these releases: > > https://issues.apache.org/jira/projects/SLING/versions/12349387 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2420 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2420 /tmp/sling-staging > > > > Please vote to approve these releases: > > > >[ ] +1 Approve the releases > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #19: SLING-10211: add Bundle-Metadata, build with bnd
stbischof commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/19#discussion_r594132954
##
File path: pom.xml
##
@@ -41,34 +42,44 @@
-
-org.apache.maven.plugins
-maven-dependency-plugin
-
-
-unpack-dependencies
-prepare-package
-
-unpack-dependencies
-
-
-META-INF/**
-
${project.build.directory}/classes
-false
-true
-
osgi.core,commons-text,commons-lang3,org.apache.sling.feature,org.osgi.util.function,org.apache.felix.cm.json,org.apache.sling.commons.johnzon,org.apache.felix.converter,commons-cli,slf4j-api,slf4j-simple
+
+biz.aQute.bnd
+bnd-maven-plugin
+
+
[jira] [Assigned] (SLING-10205) Support converting packages with custom properties and install hooks
[
https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-10205:
---
Assignee: Konrad Windszus
> Support converting packages with custom properties and install hooks
>
>
> Key: SLING-10205
> URL: https://issues.apache.org/jira/browse/SLING-10205
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.24
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> Currently only specific properties are being transferred to the converted
> package:
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/acf8c533590b9a081d64ca8e4787bed600f36386/src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageAssembler.java#L93.
> That e.g. prevents usage of [external install
> hooks|http://jackrabbit.apache.org/filevault/installhooks.html]
> Also no [internal install
> hooks|http://jackrabbit.apache.org/filevault/installhooks.html] below
> {{META-INF/vault/hooks}} are being copied to the converted package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10205) Support converting packages with custom properties and install hooks
[
https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10205:
Fix Version/s: Content-Package to Feature Model Converter 1.0.26
> Support converting packages with custom properties and install hooks
>
>
> Key: SLING-10205
> URL: https://issues.apache.org/jira/browse/SLING-10205
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.24
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> Currently only specific properties are being transferred to the converted
> package:
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/acf8c533590b9a081d64ca8e4787bed600f36386/src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageAssembler.java#L93.
> That e.g. prevents usage of [external install
> hooks|http://jackrabbit.apache.org/filevault/installhooks.html]
> Also no [internal install
> hooks|http://jackrabbit.apache.org/filevault/installhooks.html] below
> {{META-INF/vault/hooks}} are being copied to the converted package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
