[jira] [Commented] (SLING-10428) Lower the dependency version for oak-commons in sling.jcr.base

[Nitin Gupta (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354792#comment-17354792
 ] 

Nitin Gupta commented on SLING-10428:
-

thanks [~karlpauls]

> Lower the dependency version for oak-commons in sling.jcr.base
> --
>
> Key: SLING-10428
> URL: https://issues.apache.org/jira/browse/SLING-10428
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Affects Versions: JCR Base 3.1.6
>Reporter: Nitin Gupta
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JCR Base 3.1.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As part of SLING-8411 
> ([https://github.com/apache/sling-org-apache-sling-jcr-base/commit/63e79550819e48d436b53903862d68253a501e40)]
>  
> A dependency to oak-commons 1.8.2 was added in sling.jcr.base. This was only 
> to use PathUtils class.
>  
> Due to using a higher version of oak-commons it's causing issues using the 
> latest version of sling.jcr.base in older versions  AEM - an application that 
> uses sling.jcr.base.
>  
> Opening this ticket to make PathUtils class available via an older version of 
> oak-commons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Issue Comment Deleted] (SLING-10428) Lower the dependency version for oak-commons in sling.jcr.base

[Nitin Gupta (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitin Gupta updated SLING-10428:

Comment: was deleted

(was: thanks [~kpauls])

> Lower the dependency version for oak-commons in sling.jcr.base
> --
>
> Key: SLING-10428
> URL: https://issues.apache.org/jira/browse/SLING-10428
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Affects Versions: JCR Base 3.1.6
>Reporter: Nitin Gupta
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JCR Base 3.1.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As part of SLING-8411 
> ([https://github.com/apache/sling-org-apache-sling-jcr-base/commit/63e79550819e48d436b53903862d68253a501e40)]
>  
> A dependency to oak-commons 1.8.2 was added in sling.jcr.base. This was only 
> to use PathUtils class.
>  
> Due to using a higher version of oak-commons it's causing issues using the 
> latest version of sling.jcr.base in older versions  AEM - an application that 
> uses sling.jcr.base.
>  
> Opening this ticket to make PathUtils class available via an older version of 
> oak-commons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10428) Lower the dependency version for oak-commons in sling.jcr.base

[Nitin Gupta (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354791#comment-17354791
 ] 

Nitin Gupta commented on SLING-10428:
-

thanks [~kpauls]

> Lower the dependency version for oak-commons in sling.jcr.base
> --
>
> Key: SLING-10428
> URL: https://issues.apache.org/jira/browse/SLING-10428
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Affects Versions: JCR Base 3.1.6
>Reporter: Nitin Gupta
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JCR Base 3.1.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As part of SLING-8411 
> ([https://github.com/apache/sling-org-apache-sling-jcr-base/commit/63e79550819e48d436b53903862d68253a501e40)]
>  
> A dependency to oak-commons 1.8.2 was added in sling.jcr.base. This was only 
> to use PathUtils class.
>  
> Due to using a higher version of oak-commons it's causing issues using the 
> latest version of sling.jcr.base in older versions  AEM - an application that 
> uses sling.jcr.base.
>  
> Opening this ticket to make PathUtils class available via an older version of 
> oak-commons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10428) Lower the dependency version for oak-commons in sling.jcr.base

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-10428.

Resolution: Fixed

[~ngupta], thanks - I merged it. I'll do a release soon.

> Lower the dependency version for oak-commons in sling.jcr.base
> --
>
> Key: SLING-10428
> URL: https://issues.apache.org/jira/browse/SLING-10428
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Affects Versions: JCR Base 3.1.6
>Reporter: Nitin Gupta
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JCR Base 3.1.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As part of SLING-8411 
> ([https://github.com/apache/sling-org-apache-sling-jcr-base/commit/63e79550819e48d436b53903862d68253a501e40)]
>  
> A dependency to oak-commons 1.8.2 was added in sling.jcr.base. This was only 
> to use PathUtils class.
>  
> Due to using a higher version of oak-commons it's causing issues using the 
> latest version of sling.jcr.base in older versions  AEM - an application that 
> uses sling.jcr.base.
>  
> Opening this ticket to make PathUtils class available via an older version of 
> oak-commons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-10428) Lower the dependency version for oak-commons in sling.jcr.base

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls reassigned SLING-10428:
--

Assignee: Karl Pauls

> Lower the dependency version for oak-commons in sling.jcr.base
> --
>
> Key: SLING-10428
> URL: https://issues.apache.org/jira/browse/SLING-10428
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Affects Versions: JCR Base 3.1.6
>Reporter: Nitin Gupta
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JCR Base 3.1.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As part of SLING-8411 
> ([https://github.com/apache/sling-org-apache-sling-jcr-base/commit/63e79550819e48d436b53903862d68253a501e40)]
>  
> A dependency to oak-commons 1.8.2 was added in sling.jcr.base. This was only 
> to use PathUtils class.
>  
> Due to using a higher version of oak-commons it's causing issues using the 
> latest version of sling.jcr.base in older versions  AEM - an application that 
> uses sling.jcr.base.
>  
> Opening this ticket to make PathUtils class available via an older version of 
> oak-commons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10433) Mutable content dependency removal by convert is ordering dependent

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-10433.

Resolution: Fixed

Done in 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/85

> Mutable content dependency removal by convert is ordering dependent
> ---
>
> Key: SLING-10433
> URL: https://issues.apache.org/jira/browse/SLING-10433
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.2
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.4
>
>
> Following SLING-8649, the converter is trying to remove dependencies on 
> mutable content package from converted packages. That suffers from an 
> ordering problem as it will only learn about mutable content package ids when 
> it hits the package but removes the dependencies directly when it is 
> converting a package. 
> In other words, if a content package contains two sub packages, one mutable 
> and one immutable and the immutable package has a dependency on the mutable 
> one it will depend on the order they are found in the content package whether 
> the dependency is removed or not.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls merged pull request #85: SLING-10433: wait until we processed all packages with creating and d…

[GitBox]

karlpauls merged pull request #85:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/85


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #85: SLING-10433: wait until we processed all packages with creating and d…

[GitBox]

sonarcloud[bot] removed a comment on pull request #85:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/85#issuecomment-850525064


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=85=new_coverage=list)
 [73.5% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=85=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=85=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=85=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #85: SLING-10433: wait until we processed all packages with creating and d…

[GitBox]

sonarcloud[bot] commented on pull request #85:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/85#issuecomment-851696957


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=85=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=85=new_coverage=list)
 [75.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=85=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=85=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=85=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10441) make discovery independent from scheduler thread pools

[Stefan Egli (Jira)]

Stefan Egli created SLING-10441:
---

 Summary: make discovery independent from scheduler thread pools
 Key: SLING-10441
 URL: https://issues.apache.org/jira/browse/SLING-10441
 Project: Sling
  Issue Type: Task
  Components: Discovery
Affects Versions: Discovery Oak 1.2.30, Discovery Base 2.0.8, Discovery 
Impl 1.2.12, Discovery Commons 1.0.20
Reporter: Stefan Egli
Assignee: Stefan Egli


Currently discovery uses the commons.scheduler for a few but mission critical 
cases. Since the commons.scheduler doesn't guarantee timely execution - eg when 
the corresponding thread pool is full - discovery should become independent of 
commons.scheduler.

The easiest solution is to spawn {{new Thread}} in those few cases. This 
shouldn't be problematic since these activities are not happening on a high 
frequency and are only short-lived.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10405) Update embedded jackrabbit vault to version 3.5.0

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10405:

Summary: Update embedded jackrabbit vault to version 3.5.0  (was: Update 
embedded jackrabbit vault)

> Update embedded jackrabbit vault to version 3.5.0
> -
>
> Key: SLING-10405
> URL: https://issues.apache.org/jira/browse/SLING-10405
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Content Extension 1.0.10
>Reporter: Karl Pauls
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Feature Model Content Extension 1.0.12
>
>
> The extension currently uses (and embeds) an old version of vault - namely, 
> 3.2.6. We should update to a newer version.
> https://github.com/apache/sling-org-apache-sling-feature-extension-content/blob/master/pom.xml#L104



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10405) Update embedded jackrabbit vault

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-10405.
-
Fix Version/s: Feature Model Content Extension 1.0.12
   Resolution: Fixed

> Update embedded jackrabbit vault
> 
>
> Key: SLING-10405
> URL: https://issues.apache.org/jira/browse/SLING-10405
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Content Extension 1.0.10
>Reporter: Karl Pauls
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Feature Model Content Extension 1.0.12
>
>
> The extension currently uses (and embeds) an old version of vault - namely, 
> 3.2.6. We should update to a newer version.
> https://github.com/apache/sling-org-apache-sling-feature-extension-content/blob/master/pom.xml#L104



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10405) Update embedded jackrabbit vault

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354541#comment-17354541
 ] 

Konrad Windszus commented on SLING-10405:
-

Fixed in 
https://github.com/apache/sling-org-apache-sling-feature-extension-content/commit/a17572730f020bda83d32f2e76a3a43656fac15f.
 Everything not contained in the Feature Launcher is shaded & relocated.

> Update embedded jackrabbit vault
> 
>
> Key: SLING-10405
> URL: https://issues.apache.org/jira/browse/SLING-10405
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Content Extension 1.0.10
>Reporter: Karl Pauls
>Assignee: Konrad Windszus
>Priority: Major
>
> The extension currently uses (and embeds) an old version of vault - namely, 
> 3.2.6. We should update to a newer version.
> https://github.com/apache/sling-org-apache-sling-feature-extension-content/blob/master/pom.xml#L104



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10417) Create execution plans with "strict" import option

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354540#comment-17354540
 ] 

Konrad Windszus commented on SLING-10417:
-

Fixed in 
https://github.com/apache/sling-org-apache-sling-feature-extension-content/commit/a17572730f020bda83d32f2e76a3a43656fac15f.

> Create execution plans with "strict" import option
> --
>
> Key: SLING-10417
> URL: https://issues.apache.org/jira/browse/SLING-10417
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Content Extension 1.0.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Feature Model Content Extension 1.0.12
>
>
> The execution plans created by the ContentHandler should enforce installation 
> in strict mode. This is possible since JCRVLT-511 and requires FileVault 
> 3.5.0 (compare with SLING-10405).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10417) Create execution plans with "strict" import option

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-10417.
-
Fix Version/s: Feature Model Content Extension 1.0.12
 Assignee: Konrad Windszus
   Resolution: Fixed

> Create execution plans with "strict" import option
> --
>
> Key: SLING-10417
> URL: https://issues.apache.org/jira/browse/SLING-10417
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Content Extension 1.0.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Feature Model Content Extension 1.0.12
>
>
> The execution plans created by the ContentHandler should enforce installation 
> in strict mode. This is possible since JCRVLT-511 and requires FileVault 
> 3.5.0 (compare with SLING-10405).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-extension-content] kwin merged pull request #16: SLING-10405 update FileVault to 3.5.0

[GitBox]

kwin merged pull request #16:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/16


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10225) Files with ".." In Name Throw 400 Exception

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-10225.

Resolution: Fixed

Done in https://github.com/apache/sling-org-apache-sling-engine/pull/15

We now don't allow empty selectors as well as not allowing /.. or really and 
segment with only dots.

> Files with ".." In Name Throw 400 Exception
> ---
>
> Key: SLING-10225
> URL: https://issues.apache.org/jira/browse/SLING-10225
> Project: Sling
>  Issue Type: Bug
>  Components: Engine
>Affects Versions: Engine 2.7.4
>Reporter: Dan Klco
>Assignee: Karl Pauls
>Priority: Critical
> Fix For: Engine 2.7.6
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> SLING-9741 and the [associated 
> PR|https://github.com/apache/sling-org-apache-sling-engine/pull/11] 
> introduced a regression where the Sling Engine will return a 400 error on 
> requests based on the presence of ".." in the URL when not preceded by a 
> slash.
> This is an issue as file names may contain multiple periods and it is not 
> obvious that it would cause an issue to upload a file with two periods in the 
> name. 
> h2. Reproduction steps:
> * Update a Sling instance to use Engine 2.7.4
> * Upload a file containing .. in the path
> * Attempt to get the file or any path with the file as a suffix
> * Note this returns a 400 error



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-auth-form] rombert commented on pull request #1: SLING-10290 Every request renews sling.formauth token

[GitBox]

rombert commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-auth-form/pull/1#issuecomment-851567041


   Thanks @enapps-enorman . Tests looks good, probably a lot of effort to set 
up, considering the harness we already have in the launchpad-testing module, 
but very good to have at any rate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] karlpauls merged pull request #15: SLING-10225: don't allow path segements with only dots

[GitBox]

karlpauls merged pull request #15:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/15


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #15: SLING-10225: don't allow path segements with only dots

[GitBox]

sonarcloud[bot] commented on pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/15#issuecomment-851565532


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
 [1 Security 
Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_coverage=list)
 [57.1% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] removed a comment on pull request #15: SLING-10225: don't allow path segements with only dots

[GitBox]

sonarcloud[bot] removed a comment on pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/15#issuecomment-851554187


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
 [1 Security 
Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_coverage=list)
 [57.1% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #15: SLING-10225: don't allow path segements with only dots

[GitBox]

sonarcloud[bot] commented on pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/15#issuecomment-851554187


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
 [1 Security 
Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_coverage=list)
 [57.1% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] removed a comment on pull request #15: SLING-10225: don't allow path segements with only dots

[GitBox]

sonarcloud[bot] removed a comment on pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/15#issuecomment-850471067


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
 [1 Security 
Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=15=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=15=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_coverage=list)
 [57.1% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=15=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-engine] rombert commented on a change in pull request #15: SLING-10225: don't allow path segements with only dots

[GitBox]

rombert commented on a change in pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-engine/pull/15#discussion_r642522526



##
File path: src/main/java/org/apache/sling/engine/impl/request/RequestData.java
##
@@ -582,28 +582,17 @@ public static void service(SlingHttpServletRequest 
request,
 }
 
 /*
- * Returns true if and only if path contains no consecutive dots
- * except "/..".
- *
- * @param path The path of request object
- * @return true if path contains no consecutive dots except "/..", false 
otherwise
+ * Don't allow path segments that contain only dots or a mix of dots and 
%5B.
+ * Additionally, check that we didn't have an empty selector from a dot 
replacement.
  */
-static boolean isValidRequest(String path) {
-boolean isValidRequest = true;
-if (path.contains("...")) { //any occurrence "..." will mark request 
invalid
-isValidRequest = false;
-} else {
-//consecutive dots will be treated as Invalid request except "/.."
-int doubleDotIndex = path.indexOf(CONSECUTIVE_DOTS);
-while (doubleDotIndex >= 0) {
-if (doubleDotIndex == 0 || path.charAt(doubleDotIndex - 1) != 
'/') {//doubleDotIndex == 0 When path start with ..
-isValidRequest = false;
-break;
-}
-doubleDotIndex = path.indexOf(CONSECUTIVE_DOTS, doubleDotIndex 
+ 2);
+static boolean isValidRequest(SlingHttpServletRequest request) {
+RequestPathInfo info = request.getRequestPathInfo();
+for (String selector : info.getSelectors()) {
+if (selector.trim().isEmpty()) {
+return false;
 }
 }
-return isValidRequest;
+return 
!info.getResourcePath().matches(".*/\\[*\\.\\[*\\.[\\[,\\.]*/.*|.*/\\[*\\.\\[*\\.[\\[,\\.]*$");

Review comment:
   I am not sure what this does, so a comment would help. You might want to 
extract it as a static/instance field and use `Pattern.compile`, it should be a 
bit faster.

##
File path: 
src/test/java/org/apache/sling/engine/impl/request/RequestDataTest.java
##
@@ -150,11 +196,520 @@ public void testValidRequest() {
 assertValidRequest(true, "/path");
 }
 
-private static void assertValidRequest(boolean expected, String path) {
+private static void assertValidRequest(boolean expected, final String 
path) {
 assertEquals(
 "Expected " + expected + " for " + path,
 expected,
-RequestData.isValidRequest(path)
+RequestData.isValidRequest(new SlingHttpServletRequest(){

Review comment:
   Could we make this more compact? As it is it's a lot of effort to 
understand why this was needed. I think we already import jmock so that would 
be an option. We also have a `MockSlingHttpServletRequest` class in the servlet 
helpers module which you can use, but not sure if we get in trouble with cyclic 
dependencies.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling SAML2 Service Provider 0.2.4

[Cris Rockwell]

Hi Robert

Thanks a lot for the feedback. I'm out for a few days. When I get back,
I'll cancel this release, review these items and try again.

Best
Cris


On Mon, May 31, 2021, 9:32 AM Robert Munteanu  wrote:

> Hi,
>
> On Thu, 2021-05-27 at 15:06 -0400, Cris Rockwell wrote:
> > Hi,
> >
> > We solved 3 Jira issues in this initial release:
> > https://issues.apache.org/jira/projects/SLING/versions/12350210 <
> > https://issues.apache.org/jira/projects/SLING/versions/12350210>
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2457
>
> Thanks for setting up the vote, I know it's been quite a journey :-)
>
> A couple of notes/questions from me, see below.
>
> 1. I tried to rebuild the source release, and it seems it's pulling in
> SNAPSHOT version from various repositories
>
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.auth.core/1.4.1-SNAPSHOT/maven-metadata.xml
> Downloaded from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.auth.core/1.4.1-SNAPSHOT/maven-metadata.xml
> (1.0 kB at 8.5 kB/s)
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/jackrabbit/oak-auth-external/1.35-SNAPSHOT/maven-metadata.xml
> Downloading from shibboleth:
> https://build.shibboleth.net/nexus/content/repositories/releases/org/apache/jackrabbit/oak-auth-external/1.35-SNAPSHOT/maven-metadata.xml
> Downloading from shibboleth:
> https://build.shibboleth.net/nexus/content/repositories/releases/org/apache/jackrabbit/oak-parent/1.35-SNAPSHOT/maven-metadata.xml
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/jackrabbit/oak-parent/1.35-SNAPSHOT/maven-metadata.xml
>
> (multiple occurences)
>
> I think this comes from the usage of version ranges in the pom.xml, e.g.
>
> 
>   org.apache.commons
>   commons-lang3
>   [3.5,3.9]
>   provided
> 
>
> Why are there version ranges used in the pom?
>
> 2. The depedendecy list is large, probably needed :-) but I wanted to
> ask about a couple.
>
> There are a number of jars embedded, some of then look like could be
> replaced with bundles:
>
> metrics-core-4.1.9.jar
> velocity-1.7.jar
> xmlsec-2.1.4.jar
>
> Also, do we need the checker framework and annotations at runtime?
>
> checker-qual-2.11.1.jar
> error_prone_annotations-2.3.4.jar
>
> commons-lang 2.6 is EOL and unmaintained, but we include it in the
> bundle.
>
> commons-lang-2.6.jar
>
> I think that embedding only what is needed and allowing the user to
> deploy up-to-date depedencies will improve the security standing of
> installations using the Sling saml bundle.
>
> Thanks,
> Robert
>
>

[jira] [Resolved] (SLING-9821) Error message points to non-existing method

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-9821.
---
Resolution: Fixed

Done in 
https://github.com/apache/sling-org-apache-sling-jcr-base/commit/a69896e9c876c280a7c87c2f3e15127ca9f60018

Thanks!

> Error message points to non-existing method
> ---
>
> Key: SLING-9821
> URL: https://issues.apache.org/jira/browse/SLING-9821
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Reporter: Angela Schreiber
>Assignee: Karl Pauls
>Priority: Trivial
> Fix For: JCR Base 3.1.8
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> https://github.com/apache/sling-org-apache-sling-jcr-base/blame/master/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepositoryManager.java#L573
> logs the following error:
> {code}
> log.error("start: Uncaught Throwable trying to access Repository, calling 
> stopRepository()", e);
> {code}
> but there no method {{stopRepository()}}. the method that is called is 
> {{stop()}}.
> so, the right log output should read instead:
> {code}
> log.error("start: Uncaught Throwable trying to access Repository, calling 
> stop()", e);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-jcr-base] karlpauls closed pull request #4: SLING-9821 - Fix Error message points to non-existing method

[GitBox]

karlpauls closed pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/4


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-base] karlpauls commented on pull request #4: SLING-9821 - Fix Error message points to non-existing method

[GitBox]

karlpauls commented on pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/4#issuecomment-851515946


   done in 
https://github.com/apache/sling-org-apache-sling-jcr-base/commit/a69896e9c876c280a7c87c2f3e15127ca9f60018


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (SLING-9821) Error message points to non-existing method

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls reassigned SLING-9821:
-

Assignee: Karl Pauls

> Error message points to non-existing method
> ---
>
> Key: SLING-9821
> URL: https://issues.apache.org/jira/browse/SLING-9821
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Reporter: Angela Schreiber
>Assignee: Karl Pauls
>Priority: Trivial
> Fix For: JCR Base 3.1.8
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> https://github.com/apache/sling-org-apache-sling-jcr-base/blame/master/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepositoryManager.java#L573
> logs the following error:
> {code}
> log.error("start: Uncaught Throwable trying to access Repository, calling 
> stopRepository()", e);
> {code}
> but there no method {{stopRepository()}}. the method that is called is 
> {{stop()}}.
> so, the right log output should read instead:
> {code}
> log.error("start: Uncaught Throwable trying to access Repository, calling 
> stop()", e);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-jcr-base] rombert closed pull request #3: SLING-9722 - AbstractSlingRepositoryManager.stop throws NullPointerExceptions if invoked multiple times

[GitBox]

rombert closed pull request #3:
URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/3


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-base] rombert commented on pull request #3: SLING-9722 - AbstractSlingRepositoryManager.stop throws NullPointerExceptions if invoked multiple times

[GitBox]

rombert commented on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/3#issuecomment-851514914


   This one was already included in 
https://github.com/apache/sling-org-apache-sling-jcr-base/commit/26eaf8e9d1a37e050479d3f2256dd85dfe644ba1
 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-base] karlpauls merged pull request #5: SLING-10428 : Lower the dependency version for oak-commons in sling.j…

[GitBox]

karlpauls merged pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/5


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling SAML2 Service Provider 0.2.4

[Robert Munteanu]

Hi,

On Thu, 2021-05-27 at 15:06 -0400, Cris Rockwell wrote:
> Hi,
> 
> We solved 3 Jira issues in this initial release:
> https://issues.apache.org/jira/projects/SLING/versions/12350210 < 
> https://issues.apache.org/jira/projects/SLING/versions/12350210>
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2457

Thanks for setting up the vote, I know it's been quite a journey :-)

A couple of notes/questions from me, see below.

1. I tried to rebuild the source release, and it seems it's pulling in
SNAPSHOT version from various repositories

Downloading from apache.snapshots: 
https://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.auth.core/1.4.1-SNAPSHOT/maven-metadata.xml
Downloaded from apache.snapshots: 
https://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.auth.core/1.4.1-SNAPSHOT/maven-metadata.xml
 (1.0 kB at 8.5 kB/s)
Downloading from apache.snapshots: 
https://repository.apache.org/snapshots/org/apache/jackrabbit/oak-auth-external/1.35-SNAPSHOT/maven-metadata.xml
Downloading from shibboleth: 
https://build.shibboleth.net/nexus/content/repositories/releases/org/apache/jackrabbit/oak-auth-external/1.35-SNAPSHOT/maven-metadata.xml
Downloading from shibboleth: 
https://build.shibboleth.net/nexus/content/repositories/releases/org/apache/jackrabbit/oak-parent/1.35-SNAPSHOT/maven-metadata.xml
Downloading from apache.snapshots: 
https://repository.apache.org/snapshots/org/apache/jackrabbit/oak-parent/1.35-SNAPSHOT/maven-metadata.xml

(multiple occurences)

I think this comes from the usage of version ranges in the pom.xml, e.g.


  org.apache.commons
  commons-lang3
  [3.5,3.9]
  provided


Why are there version ranges used in the pom?

2. The depedendecy list is large, probably needed :-) but I wanted to
ask about a couple.

There are a number of jars embedded, some of then look like could be
replaced with bundles:

metrics-core-4.1.9.jar
velocity-1.7.jar
xmlsec-2.1.4.jar

Also, do we need the checker framework and annotations at runtime?

checker-qual-2.11.1.jar
error_prone_annotations-2.3.4.jar

commons-lang 2.6 is EOL and unmaintained, but we include it in the
bundle.

commons-lang-2.6.jar

I think that embedding only what is needed and allowing the user to
deploy up-to-date depedencies will improve the security standing of
installations using the Sling saml bundle.

Thanks,
Robert

[jira] [Created] (SLING-10440) org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to time

[Nicolas Peltier (Jira)]

Nicolas Peltier created SLING-10440:
---

 Summary: org.apache.sling.pipes.it.PipeModelIT.testListComponent 
fails from time to time
 Key: SLING-10440
 URL: https://issues.apache.org/jira/browse/SLING-10440
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Pipes 4.1.2
Reporter: Nicolas Peltier


see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-pipes/job/master/74/console
 for example



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-jspc-maven-plugin] rombert commented on pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml

[GitBox]

rombert commented on pull request #4:
URL: 
https://github.com/apache/sling-jspc-maven-plugin/pull/4#issuecomment-851459436


   PR merged, thanks @rmkellogg ! Note that I decided we still need a Jira 
issue for it since it affects end users so I created 
https://issues.apache.org/jira/browse/SLING-10439 . In the future please also 
create those unless the changes are trivial (formatting, typos).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10439) Ignore 'jspc' goal in Eclipse

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-10439.
-
Resolution: Fixed

Fixed with https://github.com/apache/sling-jspc-maven-plugin/pull/4 .

> Ignore 'jspc' goal in Eclipse
> -
>
> Key: SLING-10439
> URL: https://issues.apache.org/jira/browse/SLING-10439
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: JSPC Maven Plugin 2.2.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-jspc-maven-plugin] rombert merged pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml

[GitBox]

rombert merged pull request #4:
URL: https://github.com/apache/sling-jspc-maven-plugin/pull/4


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10439) Ignore 'jspc' goal in Eclipse

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-10439:
---

 Summary: Ignore 'jspc' goal in Eclipse
 Key: SLING-10439
 URL: https://issues.apache.org/jira/browse/SLING-10439
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: JSPC Maven Plugin 2.2.4






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-jspc-maven-plugin] sonarcloud[bot] commented on pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml

[GitBox]

sonarcloud[bot] commented on pull request #4:
URL: 
https://github.com/apache/sling-jspc-maven-plugin/pull/4#issuecomment-851449590


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin=4=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin=4=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin=4=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin=4=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin=4=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin=4=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-jspc-maven-plugin=4=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-jspc-maven-plugin=4=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-jspc-maven-plugin=4=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin=4=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin=4=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin=4=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-jspc-maven-plugin=4=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-jspc-maven-plugin=4=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-jspc-maven-plugin] rmkellogg commented on pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml

[GitBox]

rmkellogg commented on pull request #4:
URL: 
https://github.com/apache/sling-jspc-maven-plugin/pull/4#issuecomment-851449070


   Missing copyright header added.  Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] rombert commented on pull request #27: SLING-10229: DockerHub build - using hooks to build and push

[GitBox]

rombert commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-851439333


   Got, thanks @stbischof .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-apiregions] sonarcloud[bot] removed a comment on pull request #15: SLING-10434 ArrayIndexOutOfBounds for empty feature list

[GitBox]

sonarcloud[bot] removed a comment on pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/15#issuecomment-850606507


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-apiregions=15=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-apiregions=15=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-apiregions=15=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions=15=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions=15=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions=15=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions=15=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-apiregions] sonarcloud[bot] commented on pull request #15: SLING-10434 ArrayIndexOutOfBounds for empty feature list

[GitBox]

sonarcloud[bot] commented on pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/15#issuecomment-851436851


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-apiregions=15=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-apiregions=15=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-apiregions=15=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions=15=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions=15=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions=15=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions=15=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions=15=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-9531) Add operation which indicates that a more specific servlet is needed

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-9531:
---
Fix Version/s: (was: Servlets POST 2.4.4)

> Add operation which indicates that a more specific servlet is needed
> 
>
> Key: SLING-9531
> URL: https://issues.apache.org/jira/browse/SLING-9531
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Post 2.3.36
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Very often POST servlets rely on OSGi DS which is dynamic. If for whatever 
> reason the specialized servlet component is not running, Sling falls back to 
> the Default POST Servlet. That is very often not intended. To prevent the 
> Default POST Servlet from doing any repository modification operations a new 
> operation should be added which leads to a 500 error and the status message, 
> that a more specific servlet is necessary.
> Compare with the discussion from 
> https://lists.apache.org/thread.html/r00d54024759efe1f0456008e21a994f5bafe512bf65ff9bc1c767999%40%3Cdev.sling.apache.org%3E
> Currently there is only the very generic NOP operation which does not hint at 
> the fact that a necessary servlet is not deployed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Releasing Post Servlets

[Konrad Windszus]

https://issues.apache.org/jira/browse/SLING-9531 
 should not block a release. 
I removed the fix version as I won't work on this in the near future.
Konrad

> On 31. May 2021, at 12:57, Jörg Hoh  wrote:
> 
> Hi,
> 
> I plan to do a release of the Sling Post Servlet, and I see 2 open issues
> [1] scheduled for this release 2.4.4
> 
> * https://issues.apache.org/jira/browse/SLING-8974 (unassigned)
> * https://issues.apache.org/jira/browse/SLING-9531 (assigned to Konrad)
> 
> Should I wait for some more days with the release so they can get included?
> Or is it ok to move these 2 to the next release?
> 
> [1] https://issues.apache.org/jira/projects/SLING/versions/12349585
> 
> Jörg
> 
> -- 
> Cheers,
> Jörg Hoh,
> 
> https://cqdump.joerghoh.de
> Twitter: @joerghoh

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on pull request #27: SLING-10229: DockerHub build - using hooks to build and push

[GitBox]

stbischof commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-851424400


   I am still working on this. Just waiting for an reaction to the Issue on 
https://github.com/docker/hub-feedback/issues/2091 .
   I also contact them via mail. 
   If this issue is resolved (and they may use an ubuntu 20.04 )i will finish 
here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Releasing Post Servlets

[Jörg Hoh]

Hi,

I plan to do a release of the Sling Post Servlet, and I see 2 open issues
[1] scheduled for this release 2.4.4

* https://issues.apache.org/jira/browse/SLING-8974 (unassigned)
* https://issues.apache.org/jira/browse/SLING-9531 (assigned to Konrad)

Should I wait for some more days with the release so they can get included?
Or is it ok to move these 2 to the next release?

[1] https://issues.apache.org/jira/projects/SLING/versions/12349585

Jörg

-- 
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh

[jira] [Updated] (SLING-10351) update sling api to 2.23.4

[Joerg Hoh (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joerg Hoh updated SLING-10351:
--
Fix Version/s: (was: Servlets POST 2.4.4)

> update sling api to 2.23.4
> --
>
> Key: SLING-10351
> URL: https://issues.apache.org/jira/browse/SLING-10351
> Project: Sling
>  Issue Type: Task
>  Components: Servlets
>Reporter: Joerg Hoh
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10290) Every request renews sling.formauth token

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354347#comment-17354347
 ] 

Oliver Lietz commented on SLING-10290:
--

[~enorman], I see. We should have some documented, reusable conditions which 
can be used in Pax Exam. I prefer to inject an "ok" marker service instead of 
having additional boilerplate for polling status of HC (similar to 
{{BootFinished}} in Karaf).

> Every request renews sling.formauth token
> -
>
> Key: SLING-10290
> URL: https://issues.apache.org/jira/browse/SLING-10290
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Affects Versions: Form Based Authentication 1.0.20
>Reporter: Cris Rockwell
>Assignee: Eric Norman
>Priority: Critical
> Fix For: Form Based Authentication 1.0.22
>
> Attachments: image-2021-04-09-14-19-17-509.png
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> When using Apache Sling Form Based Authentication Handler
> Every request and subrequest sets a new value for `sling.formauth`
> Analyzing the code indicates that it not the intended behavior,
> and the cookie value of `sling.formauth` should be consistent for 30 minutes 
> according to the default value of form.auth.timeout
> Debugging shows that the method 
> [getCookieAuthData|https://github.com/apache/sling-org-apache-sling-auth-form/blob/master/src/main/java/org/apache/sling/auth/form/impl/FormAuthenticationHandler.java#L514-L519]
>  always returns null AuthenticationInfo properties are 
> user.jcr.credentials, sling.authType and user.name.  But this is not a 
> property called sling.formauth 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Event Support 4.2.20

[Carsten Ziegeler]

+1

Carsten

Am 31.05.2021 um 10:00 schrieb Stefan Egli:

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12350078

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2459/

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 



Usage:
sh check_staged_release.sh 2459 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
Stefan


--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Event Support 4.2.20

[davidb]

+1

David

On Mon, 31 May 2021 at 09:00, Stefan Egli  wrote:

> Hi,
>
> We solved 1 issue in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12350078
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2459/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2459 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Cheers,
> Stefan
>

[GitHub] [sling-jspc-maven-plugin] rombert commented on pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml

[GitBox]

rombert commented on pull request #4:
URL: 
https://github.com/apache/sling-jspc-maven-plugin/pull/4#issuecomment-851294580


   Thanks for your submission @rmkellogg ! The build failed since the file you 
added is missing a copyright header, can you please add one?
   
   It should be the same one as in 
https://github.com/apache/sling-jspc-maven-plugin/blob/master/pom.xml .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[VOTE] Release Apache Sling Event Support 4.2.20

[Stefan Egli]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12350078

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2459/

You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2459 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
Stefan

[jira] [Resolved] (SLING-10429) Include api jar in sling.event for correct javadoc generation

[Stefan Egli (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli resolved SLING-10429.
-
Resolution: Fixed

> Include api jar in sling.event for correct javadoc generation
> -
>
> Key: SLING-10429
> URL: https://issues.apache.org/jira/browse/SLING-10429
> Project: Sling
>  Issue Type: Task
>  Components: Event
>Affects Versions: Event 4.2.18
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: Event 4.2.20
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> With the switch to using {{bnd.bnd}} in 4.2.18, the sling.event bundle no 
> longer contained the sling.event.api bundle. Downstream javadoc generation 
> failed to locate source files for the embedded sling.event.api classes 
> however. One way to fix this, that I'm aware of, is to include the 
> sling.event.api bundle in the jar again. (Another variant might be to embed 
> source files of the event-api.jar in event.jar..)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10429) Include api jar in sling.event for correct javadoc generation

[Stefan Egli (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354267#comment-17354267
 ] 

Stefan Egli commented on SLING-10429:
-

* PR merged

> Include api jar in sling.event for correct javadoc generation
> -
>
> Key: SLING-10429
> URL: https://issues.apache.org/jira/browse/SLING-10429
> Project: Sling
>  Issue Type: Task
>  Components: Event
>Affects Versions: Event 4.2.18
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: Event 4.2.20
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> With the switch to using {{bnd.bnd}} in 4.2.18, the sling.event bundle no 
> longer contained the sling.event.api bundle. Downstream javadoc generation 
> failed to locate source files for the embedded sling.event.api classes 
> however. One way to fix this, that I'm aware of, is to include the 
> sling.event.api bundle in the jar again. (Another variant might be to embed 
> source files of the event-api.jar in event.jar..)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)