[jira] [Commented] (SLING-10592) Follow an exponential delay between import attempts

2021-07-09 Thread Timothee Maret (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378322#comment-17378322
 ] 

Timothee Maret commented on SLING-10592:


https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/80

> Follow an exponential delay between import attempts
> ---
>
> Key: SLING-10592
> URL: https://issues.apache.org/jira/browse/SLING-10592
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.2.0
>
>
> Currently, DistributionSubscribers attempt to import a given package every 5 
> seconds. This fixed delay is too short for permanent errors and can fill logs 
> with duplicated retries. This delay could also be made shorter for transient 
> errors.
> The delay should follow an exponential delay between 5 seconds and 15 minutes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-10592) Follow an exponential delay between import attempts

2021-07-09 Thread Timothee Maret (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-10592:
---
Fix Version/s: (was: Content Distribution Journal Core 0.2.2)
   Content Distribution Journal Core 0.2.0

> Follow an exponential delay between import attempts
> ---
>
> Key: SLING-10592
> URL: https://issues.apache.org/jira/browse/SLING-10592
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.2.0
>
>
> Currently, DistributionSubscribers attempt to import a given package every 5 
> seconds. This fixed delay is too short for permanent errors and can fill logs 
> with duplicated retries. This delay could also be made shorter for transient 
> errors.
> The delay should follow an exponential delay between 5 seconds and 15 minutes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-10592) Follow an exponential delay between import attempts

2021-07-09 Thread Timothee Maret (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret reassigned SLING-10592:
--

Assignee: Timothee Maret

> Follow an exponential delay between import attempts
> ---
>
> Key: SLING-10592
> URL: https://issues.apache.org/jira/browse/SLING-10592
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.2.2
>
>
> Currently, DistributionSubscribers attempt to import a given package every 5 
> seconds. This fixed delay is too short for permanent errors and can fill logs 
> with duplicated retries. This delay could also be made shorter for transient 
> errors.
> The delay should follow an exponential delay between 5 seconds and 15 minutes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-10206) Install content packages with import option strict

2021-07-09 Thread Timothee Maret (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378281#comment-17378281
 ] 

Timothee Maret commented on SLING-10206:


Thanks [~kwin]!

> Install content packages with import option strict
> --
>
> Key: SLING-10206
> URL: https://issues.apache.org/jira/browse/SLING-10206
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Content Distribution Journal Core 0.2.0
>
>
> Currently content packages are only installed in a best effort manner 
> (compare with JCRVLT-510). To be able to track down issues with content 
> distribution it is crucial that everything is installed in strict mode (as 
> otherwise errors might not get noticed).
> This would require setting {{opts.setStrict(true)}} in 
> https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/ba075183c374a09b86ca6fa4755a05b26e74866d/src/main/java/org/apache/sling/distribution/journal/bookkeeper/ContentPackageExtractor.java#L100.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9051) Package handling should not auto save the session

2021-07-09 Thread Timothee Maret (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378275#comment-17378275
 ] 

Timothee Maret commented on SLING-9051:
---

[~dsuess] The repository can't save arbitrarily large commit, therefore a 
transactional handling is possible only for packages of limited size.

Enforcing a limit in the content package extractor does not seem like a 
sensible option. Unlike today, end users would be required to split large 
package which is extra work and complexity. Moreover, importing those content 
packages won't be transactional.

> Package handling should not auto save the session
> -
>
> Key: SLING-9051
> URL: https://issues.apache.org/jira/browse/SLING-9051
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Dominik Süß
>Priority: Major
> Fix For: Content Distribution Journal Core 0.2.2
>
>
> For clean transactional behavior of replication the session should not be 
> autoSaved - the ootb behavior of filevault is to autoSave the nodes all 1024 
> nodes. This behavior should be changed somehow to keep transactional integrity
> https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/0b977dbd4782291c14f4173e76ef1451568100a2/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/ContentPackageExtractor.java#L95-L97



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-10585) Add support for invalidation requests

2021-07-09 Thread Timothee Maret (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-10585:
---
Fix Version/s: (was: Content Distribution Journal Core 0.1.18)
   Content Distribution Journal Core 0.1.20

> Add support for invalidation requests
> -
>
> Key: SLING-10585
> URL: https://issues.apache.org/jira/browse/SLING-10585
> Project: Sling
>  Issue Type: New Feature
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.20, Content 
> Distribution Core 0.4.8, Content Distribution Journal Messages 0.3.2, Content 
> Distribution API 0.6.0
>
>
> Caching invalidation is typically triggered by content distribution, after 
> processing an `ADD` or `DELETE` distribution request. When distributing 
> referenced content, invalidation must also include on the referencing 
> resources. To support this use case, we'll add support for a new type of 
> distribution request that invalidates the caches without importing content.
> To support this, the org.apache.sling.distribution.DistributionRequestType 
> API will be extended with
> {code:java}
> /**
>  * Action type for invalidating content
>  */
> INVALIDATE,
> {code}
> The PackageMessage.ReqType will be extended with the new INVALIDATION type.
> The DistributionPublisher will handle the invalidation distribution requests 
> by sending a package message with the INVALIDATION type and no payload (like 
> the DELETE package messages).
> The DistributionSubscriber will process invalidation messages by raising 
> imported events and invoking the import post processors.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [feature] Artifacts included in an aggregate not used for validation?

2021-07-09 Thread Eric Norman
Hi Robert,

It looks like you need to define a larger start level for your bundle.  The
features declared in the starter have various "start-order" values from 1
to 20.

For example, something like this should work:

diff --git a/launcher/src/main/features/launcher.json
b/launcher/src/main/features/launcher.json
index 8e81e84..f846e20 100644
--- a/launcher/src/main/features/launcher.json
+++ b/launcher/src/main/features/launcher.json
@@ -1,6 +1,9 @@
 {

 
"id":"${project.groupId}:${project.artifactId}:slingosgifeature:launcher:${project.version}",
   "bundles": [
-"com.example/core/1.0.0-SNAPSHOT"
+{
+"id":"com.example/core/1.0.0-SNAPSHOT",
+"start-order":"20"
+}
   ]
-}
\ No newline at end of file
+}


On Fri, Jul 9, 2021 at 7:22 AM Robert Munteanu  wrote:

> Hi,
>
> I'm prototyping a launcher module for the sling-project-archetype and
> I'm trying to do the following:
>
> - define a separate feature file (launcher.json) which includes a
> single bundle (core)
> - create an aggregate (app) which includes the launcher.json local
> aggregate + 2 features from the sling starter: nosample_base and
> oak_persistence_sns
> - analyse the app aggregate only
>
> However, it seems that the running the analysers errors out, with the
> core bundle listed as having unsatisfied dependencies, e.g.
>
> [ERROR] com.example:core:1.0.0-SNAPSHOT:  is importing package(s)
> [org.slf4j, javax.servlet, org.apache.sling.api.servlets,
> org.apache.sling.api, org.apache.sling.api.resource,
> org.apache.sling.models.annotations.injectorspecific,
> org.apache.sling.models.annotations, javax.jcr] in start level 0 but no
> bundle is exporting these for that start level.
>
> I've pushed the project to GH at
> https://github.com/rombert/sling-project-launcher-module , just run mvn
> clean install to see the error.
>
> What am I missing here? I think I should be able to assemble an
> application from external feature files and have the analyser run over
> all of them.
>
> Also, how can I exclude the validations comming from external
> (includeArtifact) features? They don't really matter to me I think ...
>
> Thanks,
> Robert
>
>
>
>


Re: What to do with an accidentally promoted staging repository (Was: [VOTE] Release Apache Sling SAML2 Service Provider 0.2.6)

2021-07-09 Thread Cris Rockwell
Thanks for researching a possible solution for this.
The artifacts are now uploaded 
https://dist.apache.org/repos/dist/dev/sling/ 




> On Jul 9, 2021, at 3:22 AM, Robert Munteanu  wrote:
> 
> I've been reading the ASF release policy at 
> 
> https://www.apache.org/legal/release-policy.html
> 
> , and this snippet drew my attention:
> 
>> A release isn't 'released' until the contents are in the project's
> distribution directory, which is a subdirectory of
> downloads.apache.org. In addition to the distribution directory,
> project that use Maven or a related build tool sometimes place their
> releases on repository.apache.org beside some convenience binaries. The
> distribution directory is required, while the repository system is an
> optional convenience.
> 
> which leads me to believe that we did not actually 'release' the
> bundle, but are right now in an inconsistent state, with a convenience
> channel being used before the actual vote being released.
> 
> My suggestion would be to continue the voting process in a manual way
> and reach out to infra/ASF board  ( as per [2] ) only if the release
> vote fails.
> 
> For that, I would ask you (Cris) to re-upload the same artifacts to 
> 
>  https://dist.apache.org/repos/dist/dev/sling/
> 
> ( svn co https://dist.apache.org/repos/dist/dev/sling/ )
> 
> and we will resume voting based on those. We may need to patch the
> scripts or run the checks manually, but it's a one-time occurence and
> should not be such a big deal.
> 
> I prefer uploading to dist/dev and validating the artifacts from there
> since it's more in line with the ASF release policy and minimises the
> risk of this release being called out as out of policy.
> 
> Would that work for you?
> 
> Thanks,
> Robert
> 
> 
> [2]: https://www.apache.org/legal/release-policy.html#administration
> 
> On Thu, 2021-07-08 at 14:30 -0400, Cris Rockwell wrote:
>> It’s not much to tweak the script to check a promoted artifact vs a
>> staged artifact. The script below does it. 
>> 
>> $ ./check_promoted_release.sh org.apache.sling.auth.saml2/0.2.6/ .
>> 
>> 
>> 
>> #!/bin/sh
>> 
>> #check_promoted_release.sh
>> STAGING=${1}
>> DOWNLOAD=${2:-/tmp/sling-staging}
>> mkdir ${DOWNLOAD} 2>/dev/null
>> 
>> if [ -z "${STAGING}" -o ! -d "${DOWNLOAD}" ]
>> then
>>  echo "Usage: check_promoted_release.sh  [temp-
>> directory]"
>>  exit
>> fi
>> 
>> if [ ! -e "${DOWNLOAD}/${STAGING}" ]
>> then
>>  echo
>> "##
>> ##"
>>  echo "   DOWNLOAD PROMOTED
>> REPOSITORY "
>>  echo
>> "##
>> ##"
>> 
>>  wget -e "robots=off" --wait 1 -nv -r -np "--
>> reject=html,index.html.tmp,../" "--follow-tags=" \
>>   -P "${DOWNLOAD}/${STAGING}" -nH "--cut-dirs=6" \
>>  
>> "https://repository.apache.org/content/groups/public/org/apache/sling/${STAGING}
>> "
>> 
>> else
>>  echo
>> "##
>> ##"
>>  echo "   USING EXISTING STAGED
>> REPOSITORY "
>>  echo
>> "##
>> ##"
>>  echo "${DOWNLOAD}/${STAGING}"
>> fi
>> 
>> echo
>> "##
>> ##"
>> echo "  CHECK SIGNATURES AND
>> DIGESTS  "
>> echo
>> "##
>> ##"
>> 
>> for i in `find "${DOWNLOAD}/${STAGING}" -type f | grep -v
>> '\.\(asc\|sha1\|md5\)$'`
>> do
>>  f=`echo $i | sed 's/\.asc$//'`
>>  echo "$f"
>>  gpg --verify $f.asc 2>/dev/null
>>  if [ "$?" = "0" ]; then CHKSUM="GOOD"; else CHKSUM="BAD"; fi
>>  if [ ! -f "$f.asc" ]; then CHKSUM=""; fi
>>  echo "gpg:  ${CHKSUM}"
>> 
>>  for tp in md5 sha1
>>  do
>>if [ ! -f "$f.$tp" ]
>>then
>>  CHKSUM=""
>>else
>>  A="`cat $f.$tp 2>/dev/null`"
>>  B="`openssl $tp < $f 2>/dev/null | sed 's/.*= *//' `"
>>  if [ "$A" = "$B" ]; then CHKSUM="GOOD (`cat $f.$tp`)"; else
>> CHKSUM="BAD!! : $A not equal to $B"; fi
>>fi
>>echo "$tp : ${CHKSUM}"
>>  done
>> 
>> done
>> 
>> if [ -z "${CHKSUM}" ]; then echo "WARNING: no files found!"; fi
>> 
>> echo
>> "##
>> ##"
>> 
>> 
>> ###
>> #
>>   CHECK SIGNATURES AND DIGESTS
>> ###
>> #
>> ./org.apache.sling.auth.saml2/0.2.6//org.apache.sling.auth.saml2/0.2.6/
>> org.apache.sling.auth.saml2-0.2.6-source-release.zip
>> gpg:  GOOD
>> md5 : GOOD (39c1e148b0919387a5732628ba604d21)
>> sha1 : GOOD 

[feature] Artifacts included in an aggregate not used for validation?

2021-07-09 Thread Robert Munteanu
Hi,

I'm prototyping a launcher module for the sling-project-archetype and
I'm trying to do the following:

- define a separate feature file (launcher.json) which includes a
single bundle (core)
- create an aggregate (app) which includes the launcher.json local
aggregate + 2 features from the sling starter: nosample_base and
oak_persistence_sns
- analyse the app aggregate only

However, it seems that the running the analysers errors out, with the
core bundle listed as having unsatisfied dependencies, e.g.

[ERROR] com.example:core:1.0.0-SNAPSHOT:  is importing package(s)
[org.slf4j, javax.servlet, org.apache.sling.api.servlets,
org.apache.sling.api, org.apache.sling.api.resource,
org.apache.sling.models.annotations.injectorspecific,
org.apache.sling.models.annotations, javax.jcr] in start level 0 but no
bundle is exporting these for that start level.

I've pushed the project to GH at
https://github.com/rombert/sling-project-launcher-module , just run mvn
clean install to see the error.

What am I missing here? I think I should be able to assemble an
application from external feature files and have the analyser run over
all of them.

Also, how can I exclude the validations comming from external
(includeArtifact) features? They don't really matter to me I think ...

Thanks,
Robert





Re: Should the sling-project-archetype generate a launcher module?

2021-07-09 Thread Robert Munteanu
Hi Ruben,

On Fri, 2021-07-09 at 06:47 -0700, Ruben Reusser wrote:
> Robert,
> 
> I think its a good idea - I wonder however if in that case the sling 
> sample in the sling starter should be removed and the initial content a
> bit rearranged to allow for a cleaner start of a new application on top
> of sling?

That should already the case, see the hints at [1] . For a very basic
setup, include the following features:

- nosample_base
- oak_persistence_sns

I'm actually using this for prototyping the launcher module.

Of course, there is a larger discussion on whether production-ready
setups should be based on the Sling Starter, but I guess that can wait
a bit.

[1]:
https://github.com/apache/sling-org-apache-sling-starter#extending-the-sling-starter



Re: Should the sling-project-archetype generate a launcher module?

2021-07-09 Thread Ruben Reusser

Robert,

I think its a good idea - I wonder however if in that case the sling 
sample in the sling starter should be removed and the initial content a 
bit rearranged to allow for a cleaner start of a new application on top 
of sling?


Ruben

On 7/9/2021 5:25 AM, Robert Munteanu wrote:

Hi,

I was browsing the sling-project-archetype and was wondering whether we
should have a 'launcher' module, generated by default, and based on the
Sling Starter 12 feature model.

I think it would make it simpler to demonstrate 'this is how you start
a Sling project', with the (hopefully) small added cost of maintenance
and the caveat

Thoughts?

Thanks,
Robert



[jira] [Commented] (SLING-10596) Root project pom has lots of extra empty lines

2021-07-09 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378068#comment-17378068
 ] 

Robert Munteanu commented on SLING-10596:
-

Needs an upstream fix

> Root project pom has lots of extra empty lines
> --
>
> Key: SLING-10596
> URL: https://issues.apache.org/jira/browse/SLING-10596
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Priority: Minor
>
> The generated root pom.xml has lots of extra empty lines, e.g.
> {noformat}
>   
> 
> 
> 
> 
> 
> localhost
> 
> 
> 
> 
> 
> 8080
> 
> 
> 
> 
> 
> admin
> {noformat}
> This makes reading the file less pleasant than it should be.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-10596) Root project pom has lots of extra empty lines

2021-07-09 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-10596:
---

Assignee: (was: Robert Munteanu)

> Root project pom has lots of extra empty lines
> --
>
> Key: SLING-10596
> URL: https://issues.apache.org/jira/browse/SLING-10596
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Priority: Minor
>
> The generated root pom.xml has lots of extra empty lines, e.g.
> {noformat}
>   
> 
> 
> 
> 
> 
> localhost
> 
> 
> 
> 
> 
> 8080
> 
> 
> 
> 
> 
> admin
> {noformat}
> This makes reading the file less pleasant than it should be.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-10596) Root project pom has lots of extra empty lines

2021-07-09 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-10596:
---

 Summary: Root project pom has lots of extra empty lines
 Key: SLING-10596
 URL: https://issues.apache.org/jira/browse/SLING-10596
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Reporter: Robert Munteanu
Assignee: Robert Munteanu


The generated root pom.xml has lots of extra empty lines, e.g.

{noformat}
  





localhost





8080





admin
{noformat}

This makes reading the file less pleasant than it should be.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-10595) Project archetype should default to Java 11

2021-07-09 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-10595.
-
Resolution: Fixed

> Project archetype should default to Java 11
> ---
>
> Key: SLING-10595
> URL: https://issues.apache.org/jira/browse/SLING-10595
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Project Archetype 1.0.6
>
>
> The archetype generates projects configured with Java 7, which is really old. 
> Java 11 is probably a better conservative default.
> We should also configure the Jenkins job to build with Java 11.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-10595) Project archetype should default to Java 11

2021-07-09 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-10595:
---

 Summary: Project archetype should default to Java 11
 Key: SLING-10595
 URL: https://issues.apache.org/jira/browse/SLING-10595
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Project Archetype 1.0.6


The archetype generates projects configured with Java 7, which is really old. 
Java 11 is probably a better conservative default.

We should also configure the Jenkins job to build with Java 11.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-10594) Generated project imports with error in Eclipse

2021-07-09 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-10594.
-
Resolution: Fixed

Fixed with https://github.com/apache/sling-project-archetype/pull/2 .

> Generated project imports with error in Eclipse
> ---
>
> Key: SLING-10594
> URL: https://issues.apache.org/jira/browse/SLING-10594
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Sling Project Archetype 1.0.4
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Project Archetype 1.0.6
>
>
> I generated a project using the following command
> {noformat}
> $ mvn archetype:generate \
>  -DarchetypeGroupId=org.apache.sling \
>  -DarchetypeArtifactId=sling-project-archetype \
>  -DarchetypeVersion=1.0.4 \
>  -B \
>  -DgroupId=com.example \
>  -DartifactId=apachecon001 \
>  -Dversion=1.0.0-SNAPSHOT \
>  -DartifactName=ApacheCon \
>  -Dpackage=com.example.apachecon \
>  -DpackageGroup=apachecon \
>  -DappsFolderName=apachecon001 \
>  -DcontentFolderName=apachecon001 \
>  -DslingModelSubPackage=models \
>  -DslingHostName=localhost \
>  -DslingPort=8080 \
>  -DoptionAll=y \
>  -DoptionExample=s
> {noformat}
> And ended up with a couple of compilation error in Eclipse:
> {noformat}
> Description   ResourcePathLocationType
> The declared package "empty" does not match the expected package 
> "com.example.apachecon.empty"DoesNothing.java
> /core/src/main/java/com/example/apachecon/empty line 17 Java Problem
> The declared package "com.example.apachecon.servlet" does not match the 
> expected package "com.example.apachecon.com.example.apachecon.servlet"
> ByPathServletTest.java  
> /core.example/src/test/java/com/example/apachecon/com/example/apachecon/servlet
>  line 17 Java Problem
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-10594) Generated project imports with error in Eclipse

2021-07-09 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10594:

Description: 
I generated a project using the following command

{noformat}
$ mvn archetype:generate \
 -DarchetypeGroupId=org.apache.sling \
 -DarchetypeArtifactId=sling-project-archetype \
 -DarchetypeVersion=1.0.4 \
 -B \
 -DgroupId=com.example \
 -DartifactId=apachecon001 \
 -Dversion=1.0.0-SNAPSHOT \
 -DartifactName=ApacheCon \
 -Dpackage=com.example.apachecon \
 -DpackageGroup=apachecon \
 -DappsFolderName=apachecon001 \
 -DcontentFolderName=apachecon001 \
 -DslingModelSubPackage=models \
 -DslingHostName=localhost \
 -DslingPort=8080 \
 -DoptionAll=y \
 -DoptionExample=s
{noformat}

And ended up with a couple of compilation error in Eclipse:

{noformat}
Description ResourcePathLocationType
The declared package "empty" does not match the expected package 
"com.example.apachecon.empty"  DoesNothing.java
/core/src/main/java/com/example/apachecon/empty line 17 Java Problem
The declared package "com.example.apachecon.servlet" does not match the 
expected package "com.example.apachecon.com.example.apachecon.servlet"  
ByPathServletTest.java  
/core.example/src/test/java/com/example/apachecon/com/example/apachecon/servlet 
line 17 Java Problem
{noformat}

  was:
I generated a project using the following command

{noformat}
$ mvn archetype:generate \
 -DarchetypeGroupId=org.apache.sling \
 -DarchetypeArtifactId=sling-project-archetype \
 -DarchetypeVersion=1.0.4 \
 -B \
 -DgroupId=com.example \
 -DartifactId=apachecon001 \
 -Dversion=1.0.0-SNAPSHOT \
 -DartifactName=ApacheCon \
 -Dpackage=com.example.apachecon \
 -DpackageGroup=apachecon \
 -DappsFolderName=apachecon001 \
 -DcontentFolderName=apachecon001 \
 -DslingModelSubPackage=models \
 -DslingHostName=localhost \
 -DslingPort=8080 \
 -DoptionAll=y \
 -DoptionExample=s
{noformat}

And ended up with a couple of compilation error in Eclipse:

{noformat}
Description ResourcePathLocationType
The declared package "empty" does not match the expected package 
"com.example.apachecon.empty"  DoesNothing.java
/core/src/main/java/com/example/apachecon/empty line 17 Java Problem
Description ResourcePathLocationType
The declared package "com.example.apachecon.servlet" does not match the 
expected package "com.example.apachecon.com.example.apachecon.servlet"  
ByPathServletTest.java  
/core.example/src/test/java/com/example/apachecon/com/example/apachecon/servlet 
line 17 Java Problem
{noformat}


> Generated project imports with error in Eclipse
> ---
>
> Key: SLING-10594
> URL: https://issues.apache.org/jira/browse/SLING-10594
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Sling Project Archetype 1.0.4
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Project Archetype 1.0.6
>
>
> I generated a project using the following command
> {noformat}
> $ mvn archetype:generate \
>  -DarchetypeGroupId=org.apache.sling \
>  -DarchetypeArtifactId=sling-project-archetype \
>  -DarchetypeVersion=1.0.4 \
>  -B \
>  -DgroupId=com.example \
>  -DartifactId=apachecon001 \
>  -Dversion=1.0.0-SNAPSHOT \
>  -DartifactName=ApacheCon \
>  -Dpackage=com.example.apachecon \
>  -DpackageGroup=apachecon \
>  -DappsFolderName=apachecon001 \
>  -DcontentFolderName=apachecon001 \
>  

[jira] [Created] (SLING-10594) Generated project imports with error in Eclipse

2021-07-09 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-10594:
---

 Summary: Generated project imports with error in Eclipse
 Key: SLING-10594
 URL: https://issues.apache.org/jira/browse/SLING-10594
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Affects Versions: Sling Project Archetype 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Project Archetype 1.0.6


I generated a project using the following command

{noformat}
$ mvn archetype:generate \
 -DarchetypeGroupId=org.apache.sling \
 -DarchetypeArtifactId=sling-project-archetype \
 -DarchetypeVersion=1.0.4 \
 -B \
 -DgroupId=com.example \
 -DartifactId=apachecon001 \
 -Dversion=1.0.0-SNAPSHOT \
 -DartifactName=ApacheCon \
 -Dpackage=com.example.apachecon \
 -DpackageGroup=apachecon \
 -DappsFolderName=apachecon001 \
 -DcontentFolderName=apachecon001 \
 -DslingModelSubPackage=models \
 -DslingHostName=localhost \
 -DslingPort=8080 \
 -DoptionAll=y \
 -DoptionExample=s
{noformat}

And ended up with a couple of compilation error in Eclipse:

{noformat}
Description ResourcePathLocationType
The declared package "empty" does not match the expected package 
"com.example.apachecon.empty"  DoesNothing.java
/core/src/main/java/com/example/apachecon/empty line 17 Java Problem
Description ResourcePathLocationType
The declared package "com.example.apachecon.servlet" does not match the 
expected package "com.example.apachecon.com.example.apachecon.servlet"  
ByPathServletTest.java  
/core.example/src/test/java/com/example/apachecon/com/example/apachecon/servlet 
line 17 Java Problem
{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: What to do with an accidentally promoted staging repository (Was: [VOTE] Release Apache Sling SAML2 Service Provider 0.2.6)

2021-07-09 Thread Daniel Klco
+1

On Fri, Jul 9, 2021, 4:35 AM Nicolas Peltier 
wrote:

> +1
>
> Le ven. 9 juil. 2021 à 09:22, Robert Munteanu  a
> écrit :
>
> > I've been reading the ASF release policy at
> >
> >  https://www.apache.org/legal/release-policy.html
> >
> > , and this snippet drew my attention:
> >
> > > A release isn't 'released' until the contents are in the project's
> > distribution directory, which is a subdirectory of
> > downloads.apache.org. In addition to the distribution directory,
> > project that use Maven or a related build tool sometimes place their
> > releases on repository.apache.org beside some convenience binaries. The
> > distribution directory is required, while the repository system is an
> > optional convenience.
> >
> > which leads me to believe that we did not actually 'release' the
> > bundle, but are right now in an inconsistent state, with a convenience
> > channel being used before the actual vote being released.
> >
> > My suggestion would be to continue the voting process in a manual way
> > and reach out to infra/ASF board  ( as per [2] ) only if the release
> > vote fails.
> >
> > For that, I would ask you (Cris) to re-upload the same artifacts to
> >
> >   https://dist.apache.org/repos/dist/dev/sling/
> >
> > ( svn co https://dist.apache.org/repos/dist/dev/sling/ )
> >
> > and we will resume voting based on those. We may need to patch the
> > scripts or run the checks manually, but it's a one-time occurence and
> > should not be such a big deal.
> >
> > I prefer uploading to dist/dev and validating the artifacts from there
> > since it's more in line with the ASF release policy and minimises the
> > risk of this release being called out as out of policy.
> >
> > Would that work for you?
> >
> > Thanks,
> > Robert
> >
> >
> > [2]: https://www.apache.org/legal/release-policy.html#administration
> >
> > On Thu, 2021-07-08 at 14:30 -0400, Cris Rockwell wrote:
> > > It’s not much to tweak the script to check a promoted artifact vs a
> > > staged artifact. The script below does it.
> > >
> > > $ ./check_promoted_release.sh org.apache.sling.auth.saml2/0.2.6/ .
> > >
> > >
> > >
> > > #!/bin/sh
> > >
> > > #check_promoted_release.sh
> > > STAGING=${1}
> > > DOWNLOAD=${2:-/tmp/sling-staging}
> > > mkdir ${DOWNLOAD} 2>/dev/null
> > >
> > > if [ -z "${STAGING}" -o ! -d "${DOWNLOAD}" ]
> > > then
> > >  echo "Usage: check_promoted_release.sh  [temp-
> > > directory]"
> > >  exit
> > > fi
> > >
> > > if [ ! -e "${DOWNLOAD}/${STAGING}" ]
> > > then
> > >  echo
> > > "##
> > > ##"
> > >  echo "   DOWNLOAD PROMOTED
> > > REPOSITORY "
> > >  echo
> > > "##
> > > ##"
> > >
> > >  wget -e "robots=off" --wait 1 -nv -r -np "--
> > > reject=html,index.html.tmp,../" "--follow-tags=" \
> > >   -P "${DOWNLOAD}/${STAGING}" -nH "--cut-dirs=6" \
> > >
> > > "
> >
> https://repository.apache.org/content/groups/public/org/apache/sling/${STAGING}
> > > "
> > >
> > > else
> > >  echo
> > > "##
> > > ##"
> > >  echo "   USING EXISTING STAGED
> > > REPOSITORY "
> > >  echo
> > > "##
> > > ##"
> > >  echo "${DOWNLOAD}/${STAGING}"
> > > fi
> > >
> > > echo
> > > "##
> > > ##"
> > > echo "  CHECK SIGNATURES AND
> > > DIGESTS  "
> > > echo
> > > "##
> > > ##"
> > >
> > > for i in `find "${DOWNLOAD}/${STAGING}" -type f | grep -v
> > > '\.\(asc\|sha1\|md5\)$'`
> > > do
> > >  f=`echo $i | sed 's/\.asc$//'`
> > >  echo "$f"
> > >  gpg --verify $f.asc 2>/dev/null
> > >  if [ "$?" = "0" ]; then CHKSUM="GOOD"; else CHKSUM="BAD"; fi
> > >  if [ ! -f "$f.asc" ]; then CHKSUM=""; fi
> > >  echo "gpg:  ${CHKSUM}"
> > >
> > >  for tp in md5 sha1
> > >  do
> > >if [ ! -f "$f.$tp" ]
> > >then
> > >  CHKSUM=""
> > >else
> > >  A="`cat $f.$tp 2>/dev/null`"
> > >  B="`openssl $tp < $f 2>/dev/null | sed 's/.*= *//' `"
> > >  if [ "$A" = "$B" ]; then CHKSUM="GOOD (`cat $f.$tp`)"; else
> > > CHKSUM="BAD!! : $A not equal to $B"; fi
> > >fi
> > >echo "$tp : ${CHKSUM}"
> > >  done
> > >
> > > done
> > >
> > > if [ -z "${CHKSUM}" ]; then echo "WARNING: no files found!"; fi
> > >
> > > echo
> > > "##
> > > ##"
> > >
> > >
> > > ###
> > > #
> > >   CHECK SIGNATURES AND DIGESTS
> > > 

Should the sling-project-archetype generate a launcher module?

2021-07-09 Thread Robert Munteanu
Hi,

I was browsing the sling-project-archetype and was wondering whether we
should have a 'launcher' module, generated by default, and based on the
Sling Starter 12 feature model.

I think it would make it simpler to demonstrate 'this is how you start
a Sling project', with the (hopefully) small added cost of maintenance
and the caveat 

Thoughts?

Thanks,
Robert



[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #566 is BROKEN

2021-07-09 Thread Apache Jenkins Server
context.name=DavExAuthHttpContext),
 osgi.http.whiteboard.servlet.pattern=/server/*, service.bundleid=116, 
service.description=Sling JcrRemoting Servlet, service.id=1239, 
service.scope=singleton, service.vendor=The Apache Software Foundation, 
servlet.init.createAbsoluteURI=true, servlet.init.csrf-protection=disabled, 
servlet.init.protectedhandlers-config=org.apache.jackrabbit.server.remoting.davex.AclRemoveHandler,
 servlet.init.resource-path-prefix=/server, sling.auth.requirements=-/server}] 
Ignoring unmatching Servlet service
[DEBUG] [ServiceReference 467 from bundle 132 : org.apache.sling.engine:2.7.4 
ref=[javax.servlet.Filter] properties={component.id=227, 
component.name=org.apache.sling.engine.parameters, file.max=-1, 
file.threshold=256000, objectClass=[javax.servlet.Filter], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.filter.pattern=[/], request.max=-1, service.bundleid=132, 
service.description=Filter for request parameter support, service.id=467, 
service.ranking=2147483647, service.scope=bundle, service.vendor=The Apache 
Software Foundation, sling.default.max.parameters=1, 
sling.default.parameter.checkForAdditionalContainerParameters=false, 
sling.default.parameter.encoding=ISO-8859-1}] Ignoring unmatching Filter service
[DEBUG] [ServiceReference 78 from bundle 38 : 
org.apache.sling.launchpad.test-services:12.0.0.SNAPSHOT 
ref=[javax.servlet.Servlet] properties={component.id=53, 
component.name=org.apache.sling.launchpad.testservices.servlets.R6WhiteboardServlet,
 objectClass=[javax.servlet.Servlet], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.servlet.pattern=/whiteboard_r6, service.bundleid=38, 
service.id=78, 
service.pid=org.apache.sling.launchpad.testservices.servlets.R6WhiteboardServlet,
 service.scope=bundle, service.vendor=The Apache Software Foundation}] Ignoring 
unmatching Servlet service
[DEBUG] [ServiceReference 448 from bundle 132 : org.apache.sling.engine:2.7.4 
ref=[javax.servlet.Servlet] properties={objectClass=[javax.servlet.Servlet], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.servlet.name=ApacheSling/2.7, 
osgi.http.whiteboard.servlet.pattern=/, service.bundleid=132, 
service.description=Apache Sling Engine Main Servlet, service.id=448, 
service.scope=singleton, service.vendor=The Apache Software Foundation}] 
Ignoring unmatching Servlet service
[DEBUG] [ServiceReference 464 from bundle 132 : org.apache.sling.engine:2.7.4 
ref=[javax.servlet.Filter] properties={component.id=226, 
component.name=org.apache.sling.engine.impl.log.RequestLoggerFilter, 
objectClass=[javax.servlet.Filter], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.filter.pattern=[/], service.bundleid=132, 
service.description=Request Logger Filter, service.id=464, 
service.ranking=32768, service.scope=bundle, service.vendor=The Apache Software 
Foundation}] Ignoring unmatching Filter service
[INFO] Apachde Felix Http Whiteboard Service stopped
[INFO] Stopped Jetty.
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: src/main/appended-resources/META-INF/*
[INFO] Exclude: velocity.log
[INFO] Exclude: target/*
[INFO] Exclude: README.md
[INFO] Exclude: maven-eclipse.xml
[INFO] Exclude: .*
[INFO] Exclude: .*/**
[INFO] Exclude: **/*.json
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: **/*.rej
[INFO] Exclude: hs_err_*.log
[INFO] Exclude: **/repository/index/*/index-details.txt
[INFO] Exclude: bnd.bnd
[INFO] 6 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 5 licence.
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  03:13 min
[INFO] Finished at: 2021-07-09T11:20:34Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven44661022/maven-spy-20210709-111720-8801594283812461388979.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on 
project org.apache.sling.launc

Re: What to do with an accidentally promoted staging repository (Was: [VOTE] Release Apache Sling SAML2 Service Provider 0.2.6)

2021-07-09 Thread Nicolas Peltier
+1

Le ven. 9 juil. 2021 à 09:22, Robert Munteanu  a écrit :

> I've been reading the ASF release policy at
>
>  https://www.apache.org/legal/release-policy.html
>
> , and this snippet drew my attention:
>
> > A release isn't 'released' until the contents are in the project's
> distribution directory, which is a subdirectory of
> downloads.apache.org. In addition to the distribution directory,
> project that use Maven or a related build tool sometimes place their
> releases on repository.apache.org beside some convenience binaries. The
> distribution directory is required, while the repository system is an
> optional convenience.
>
> which leads me to believe that we did not actually 'release' the
> bundle, but are right now in an inconsistent state, with a convenience
> channel being used before the actual vote being released.
>
> My suggestion would be to continue the voting process in a manual way
> and reach out to infra/ASF board  ( as per [2] ) only if the release
> vote fails.
>
> For that, I would ask you (Cris) to re-upload the same artifacts to
>
>   https://dist.apache.org/repos/dist/dev/sling/
>
> ( svn co https://dist.apache.org/repos/dist/dev/sling/ )
>
> and we will resume voting based on those. We may need to patch the
> scripts or run the checks manually, but it's a one-time occurence and
> should not be such a big deal.
>
> I prefer uploading to dist/dev and validating the artifacts from there
> since it's more in line with the ASF release policy and minimises the
> risk of this release being called out as out of policy.
>
> Would that work for you?
>
> Thanks,
> Robert
>
>
> [2]: https://www.apache.org/legal/release-policy.html#administration
>
> On Thu, 2021-07-08 at 14:30 -0400, Cris Rockwell wrote:
> > It’s not much to tweak the script to check a promoted artifact vs a
> > staged artifact. The script below does it.
> >
> > $ ./check_promoted_release.sh org.apache.sling.auth.saml2/0.2.6/ .
> >
> >
> >
> > #!/bin/sh
> >
> > #check_promoted_release.sh
> > STAGING=${1}
> > DOWNLOAD=${2:-/tmp/sling-staging}
> > mkdir ${DOWNLOAD} 2>/dev/null
> >
> > if [ -z "${STAGING}" -o ! -d "${DOWNLOAD}" ]
> > then
> >  echo "Usage: check_promoted_release.sh  [temp-
> > directory]"
> >  exit
> > fi
> >
> > if [ ! -e "${DOWNLOAD}/${STAGING}" ]
> > then
> >  echo
> > "##
> > ##"
> >  echo "   DOWNLOAD PROMOTED
> > REPOSITORY "
> >  echo
> > "##
> > ##"
> >
> >  wget -e "robots=off" --wait 1 -nv -r -np "--
> > reject=html,index.html.tmp,../" "--follow-tags=" \
> >   -P "${DOWNLOAD}/${STAGING}" -nH "--cut-dirs=6" \
> >
> > "
> https://repository.apache.org/content/groups/public/org/apache/sling/${STAGING}
> > "
> >
> > else
> >  echo
> > "##
> > ##"
> >  echo "   USING EXISTING STAGED
> > REPOSITORY "
> >  echo
> > "##
> > ##"
> >  echo "${DOWNLOAD}/${STAGING}"
> > fi
> >
> > echo
> > "##
> > ##"
> > echo "  CHECK SIGNATURES AND
> > DIGESTS  "
> > echo
> > "##
> > ##"
> >
> > for i in `find "${DOWNLOAD}/${STAGING}" -type f | grep -v
> > '\.\(asc\|sha1\|md5\)$'`
> > do
> >  f=`echo $i | sed 's/\.asc$//'`
> >  echo "$f"
> >  gpg --verify $f.asc 2>/dev/null
> >  if [ "$?" = "0" ]; then CHKSUM="GOOD"; else CHKSUM="BAD"; fi
> >  if [ ! -f "$f.asc" ]; then CHKSUM=""; fi
> >  echo "gpg:  ${CHKSUM}"
> >
> >  for tp in md5 sha1
> >  do
> >if [ ! -f "$f.$tp" ]
> >then
> >  CHKSUM=""
> >else
> >  A="`cat $f.$tp 2>/dev/null`"
> >  B="`openssl $tp < $f 2>/dev/null | sed 's/.*= *//' `"
> >  if [ "$A" = "$B" ]; then CHKSUM="GOOD (`cat $f.$tp`)"; else
> > CHKSUM="BAD!! : $A not equal to $B"; fi
> >fi
> >echo "$tp : ${CHKSUM}"
> >  done
> >
> > done
> >
> > if [ -z "${CHKSUM}" ]; then echo "WARNING: no files found!"; fi
> >
> > echo
> > "##
> > ##"
> >
> >
> > ###
> > #
> >   CHECK SIGNATURES AND DIGESTS
> > ###
> > #
> > ./org.apache.sling.auth.saml2/0.2.6//org.apache.sling.auth.saml2/0.2.6/
> > org.apache.sling.auth.saml2-0.2.6-source-release.zip
> > gpg:  GOOD
> > md5 : GOOD (39c1e148b0919387a5732628ba604d21)
> > sha1 : GOOD (cea7d34a4b78dd651b8fd26ef9464ac3bacc5f6f)
> > 

Re: [VOTE] Release Apache Sling JSPC Maven Plugin 2.3.0, Apache Sling Scripting JSP 2.5.4

2021-07-09 Thread Robert Munteanu
On Thu, 2021-07-08 at 14:40 +, Radu Cotescu wrote:
> Please vote to approve this release:

+1
Robert



Re: [VOTE] Release Apache Sling GraphQL Core V0.0.12

2021-07-09 Thread Robert Munteanu
On Thu, 2021-07-08 at 19:51 +0200, Bertrand Delacretaz wrote:
> Please vote to approve this release:

+1
Robert



Re: What to do with an accidentally promoted staging repository (Was: [VOTE] Release Apache Sling SAML2 Service Provider 0.2.6)

2021-07-09 Thread Robert Munteanu
I've been reading the ASF release policy at 

 https://www.apache.org/legal/release-policy.html

, and this snippet drew my attention:

> A release isn't 'released' until the contents are in the project's
distribution directory, which is a subdirectory of
downloads.apache.org. In addition to the distribution directory,
project that use Maven or a related build tool sometimes place their
releases on repository.apache.org beside some convenience binaries. The
distribution directory is required, while the repository system is an
optional convenience.

which leads me to believe that we did not actually 'release' the
bundle, but are right now in an inconsistent state, with a convenience
channel being used before the actual vote being released.

My suggestion would be to continue the voting process in a manual way
and reach out to infra/ASF board  ( as per [2] ) only if the release
vote fails.

For that, I would ask you (Cris) to re-upload the same artifacts to 

  https://dist.apache.org/repos/dist/dev/sling/

( svn co https://dist.apache.org/repos/dist/dev/sling/ )

and we will resume voting based on those. We may need to patch the
scripts or run the checks manually, but it's a one-time occurence and
should not be such a big deal.

I prefer uploading to dist/dev and validating the artifacts from there
since it's more in line with the ASF release policy and minimises the
risk of this release being called out as out of policy.

Would that work for you?

Thanks,
Robert


[2]: https://www.apache.org/legal/release-policy.html#administration

On Thu, 2021-07-08 at 14:30 -0400, Cris Rockwell wrote:
> It’s not much to tweak the script to check a promoted artifact vs a
> staged artifact. The script below does it. 
> 
> $ ./check_promoted_release.sh org.apache.sling.auth.saml2/0.2.6/ .
> 
> 
> 
> #!/bin/sh
> 
> #check_promoted_release.sh
> STAGING=${1}
> DOWNLOAD=${2:-/tmp/sling-staging}
> mkdir ${DOWNLOAD} 2>/dev/null
> 
> if [ -z "${STAGING}" -o ! -d "${DOWNLOAD}" ]
> then
>  echo "Usage: check_promoted_release.sh  [temp-
> directory]"
>  exit
> fi
> 
> if [ ! -e "${DOWNLOAD}/${STAGING}" ]
> then
>  echo
> "##
> ##"
>  echo "   DOWNLOAD PROMOTED
> REPOSITORY "
>  echo
> "##
> ##"
> 
>  wget -e "robots=off" --wait 1 -nv -r -np "--
> reject=html,index.html.tmp,../" "--follow-tags=" \
>   -P "${DOWNLOAD}/${STAGING}" -nH "--cut-dirs=6" \
>  
> "https://repository.apache.org/content/groups/public/org/apache/sling/${STAGING}
> "
> 
> else
>  echo
> "##
> ##"
>  echo "   USING EXISTING STAGED
> REPOSITORY "
>  echo
> "##
> ##"
>  echo "${DOWNLOAD}/${STAGING}"
> fi
> 
> echo
> "##
> ##"
> echo "  CHECK SIGNATURES AND
> DIGESTS  "
> echo
> "##
> ##"
> 
> for i in `find "${DOWNLOAD}/${STAGING}" -type f | grep -v
> '\.\(asc\|sha1\|md5\)$'`
> do
>  f=`echo $i | sed 's/\.asc$//'`
>  echo "$f"
>  gpg --verify $f.asc 2>/dev/null
>  if [ "$?" = "0" ]; then CHKSUM="GOOD"; else CHKSUM="BAD"; fi
>  if [ ! -f "$f.asc" ]; then CHKSUM=""; fi
>  echo "gpg:  ${CHKSUM}"
> 
>  for tp in md5 sha1
>  do
>    if [ ! -f "$f.$tp" ]
>    then
>  CHKSUM=""
>    else
>  A="`cat $f.$tp 2>/dev/null`"
>  B="`openssl $tp < $f 2>/dev/null | sed 's/.*= *//' `"
>  if [ "$A" = "$B" ]; then CHKSUM="GOOD (`cat $f.$tp`)"; else
> CHKSUM="BAD!! : $A not equal to $B"; fi
>    fi
>    echo "$tp : ${CHKSUM}"
>  done
> 
> done
> 
> if [ -z "${CHKSUM}" ]; then echo "WARNING: no files found!"; fi
> 
> echo
> "##
> ##"
> 
> 
> ###
> #
>   CHECK SIGNATURES AND DIGESTS
> ###
> #
> ./org.apache.sling.auth.saml2/0.2.6//org.apache.sling.auth.saml2/0.2.6/
> org.apache.sling.auth.saml2-0.2.6-source-release.zip
> gpg:  GOOD
> md5 : GOOD (39c1e148b0919387a5732628ba604d21)
> sha1 : GOOD (cea7d34a4b78dd651b8fd26ef9464ac3bacc5f6f)
> ./org.apache.sling.auth.saml2/0.2.6//org.apache.sling.auth.saml2/0.2.6/
> org.apache.sling.auth.saml2-0.2.6.pom
> gpg:  GOOD
> md5 : GOOD (4ac6eb0eb5e4fcd0372a211a1974dc0c)
> sha1 : GOOD (531a963abf49b8db1b8e2584139b793a9bc28bb2)
> ./org.apache.sling.auth.saml2/0.2.6//org.apache.sling.auth.saml2/0.2.6/
> org.apache.sling.auth.saml2-0.2.6-javadoc.jar
> gpg:  GOOD
> md5 : GOOD 

Re: [VOTE] Release Apache Sling GraphQL Core V0.0.12

2021-07-09 Thread Timothee Maret
+1

Timothee

Le jeudi 8 juillet 2021, Bertrand Delacretaz  a
écrit :

> Hi,
>
> We solved 5 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12350226
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2493/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-
> release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2493 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Here's my +1
>
> -Bertrand
>