[GitHub] [sling-org-apache-sling-resourceaccesssecurity] kwin merged pull request #2: SLING-10904 update to parent 46
kwin merged pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #18: SLING-7975 support ordering of resources
kwin commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#discussion_r742298158
##
File path:
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java
##
@@ -478,6 +479,44 @@ public Resource create(final @NotNull
ResolveContext ctx, fina
}
}
+@Override
+public boolean orderBefore(@NotNull ResolveContext ctx,
@NotNull Resource parent, @NotNull String name,
+@Nullable String followingSiblingName) throws PersistenceException
{
+Node node = parent.adaptTo(Node.class);
+try {
+if (node == null) {
+throw new PersistenceException("The resource " +
parent.getPath() + " cannot be adapted to Node. It is probably not provided by
the JcrResourceProvider");
+}
+// check if reordering necessary
+NodeIterator nodeIterator = node.getNodes();
+long existingNodePosition = -1;
+long index = 0;
+while (nodeIterator.hasNext()) {
+Node childNode = nodeIterator.nextNode();
+if (childNode.getName().equals(name)) {
+existingNodePosition = index;
+}
+if (existingNodePosition >= 0) {
Review comment:
No, not necessarily. I added some tests. Hopefully they proof that
`true` is only returned in case the order is actually changed. Let me know if I
missed a case.
##
File path:
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java
##
@@ -478,6 +479,44 @@ public Resource create(final @NotNull
ResolveContext ctx, fina
}
}
+@Override
+public boolean orderBefore(@NotNull ResolveContext ctx,
@NotNull Resource parent, @NotNull String name,
+@Nullable String followingSiblingName) throws PersistenceException
{
+Node node = parent.adaptTo(Node.class);
+try {
+if (node == null) {
Review comment:
Done in
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18/commits/d74a24df6297e7a78acd2127d19229a19752f5a4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] kwin merged pull request #3: SLING-10905 support multivalue properties
kwin merged pull request #3: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] removed a comment on pull request #18: SLING-7975 support ordering of resources
sonarcloud[bot] removed a comment on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#issuecomment-959956597 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_coverage&view=list) [92.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] removed a comment on pull request #2: SLING-10904 update to parent 46
sonarcloud[bot] removed a comment on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2#issuecomment-959117457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #18: SLING-7975 support ordering of resources
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#issuecomment-959956597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #51: SLING-7975 support ordering of resources
sonarcloud[bot] removed a comment on pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51#issuecomment-955670092 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] raducotescu merged pull request #21: SLING-10889 Make the Servlets Resolver compatible with API 2.24.0
raducotescu merged pull request #21: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] commented on pull request #3: SLING-10905 support multivalue properties
sonarcloud[bot] commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/3#issuecomment-959843165 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] kwin merged pull request #1: SLING-7975 add operation for reordering resources
kwin merged pull request #1: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] commented on pull request #15: SLING-10907 Make compatible with API 2.24.0
sonarcloud[bot] commented on pull request #15: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/15#issuecomment-959844661 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #51: SLING-7975 support ordering of resources
sonarcloud[bot] commented on pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51#issuecomment-958754787 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] commented on pull request #2: SLING-10904 update to parent 46
sonarcloud[bot] commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2#issuecomment-959117457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] kwin merged pull request #51: SLING-7975 support ordering of resources
kwin merged pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] kwin merged pull request #1: SLING-7975 add operation for reordering resources
kwin merged pull request #1: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #51: SLING-7975 support ordering of resources
sonarcloud[bot] commented on pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51#issuecomment-958754787 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #51: SLING-7975 support ordering of resources
sonarcloud[bot] removed a comment on pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51#issuecomment-955670092 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] raducotescu merged pull request #21: SLING-10889 Make the Servlets Resolver compatible with API 2.24.0
raducotescu merged pull request #21: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] kwin merged pull request #2: SLING-10904 update to parent 46
kwin merged pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #18: SLING-7975 support ordering of resources
kwin commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#discussion_r742298158
##
File path:
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java
##
@@ -478,6 +479,44 @@ public Resource create(final @NotNull
ResolveContext ctx, fina
}
}
+@Override
+public boolean orderBefore(@NotNull ResolveContext ctx,
@NotNull Resource parent, @NotNull String name,
+@Nullable String followingSiblingName) throws PersistenceException
{
+Node node = parent.adaptTo(Node.class);
+try {
+if (node == null) {
+throw new PersistenceException("The resource " +
parent.getPath() + " cannot be adapted to Node. It is probably not provided by
the JcrResourceProvider");
+}
+// check if reordering necessary
+NodeIterator nodeIterator = node.getNodes();
+long existingNodePosition = -1;
+long index = 0;
+while (nodeIterator.hasNext()) {
+Node childNode = nodeIterator.nextNode();
+if (childNode.getName().equals(name)) {
+existingNodePosition = index;
+}
+if (existingNodePosition >= 0) {
Review comment:
No, not necessarily. I added some tests. Hopefully they proof that
`true` is only returned in case the order is actually changed. Let me know if I
missed a case.
##
File path:
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java
##
@@ -478,6 +479,44 @@ public Resource create(final @NotNull
ResolveContext ctx, fina
}
}
+@Override
+public boolean orderBefore(@NotNull ResolveContext ctx,
@NotNull Resource parent, @NotNull String name,
+@Nullable String followingSiblingName) throws PersistenceException
{
+Node node = parent.adaptTo(Node.class);
+try {
+if (node == null) {
Review comment:
Done in
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18/commits/d74a24df6297e7a78acd2127d19229a19752f5a4.
##
File path:
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java
##
@@ -478,6 +479,44 @@ public Resource create(final @NotNull
ResolveContext ctx, fina
}
}
+@Override
+public boolean orderBefore(@NotNull ResolveContext ctx,
@NotNull Resource parent, @NotNull String name,
+@Nullable String followingSiblingName) throws PersistenceException
{
+Node node = parent.adaptTo(Node.class);
+try {
+if (node == null) {
+throw new PersistenceException("The resource " +
parent.getPath() + " cannot be adapted to Node. It is probably not provided by
the JcrResourceProvider");
+}
+// check if reordering necessary
+NodeIterator nodeIterator = node.getNodes();
+long existingNodePosition = -1;
+long index = 0;
+while (nodeIterator.hasNext()) {
+Node childNode = nodeIterator.nextNode();
+if (childNode.getName().equals(name)) {
+existingNodePosition = index;
+}
+if (existingNodePosition >= 0) {
Review comment:
No, not necessarily. I added some tests. Hopefully they proof that
`true` is only returned in case the order is actually changed. Let me know if I
missed a case.
##
File path:
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java
##
@@ -478,6 +479,44 @@ public Resource create(final @NotNull
ResolveContext ctx, fina
}
}
+@Override
+public boolean orderBefore(@NotNull ResolveContext ctx,
@NotNull Resource parent, @NotNull String name,
+@Nullable String followingSiblingName) throws PersistenceException
{
+Node node = parent.adaptTo(Node.class);
+try {
+if (node == null) {
Review comment:
Done in
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18/commits/d74a24df6297e7a78acd2127d19229a19752f5a4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] kwin merged pull request #3: SLING-10905 support multivalue properties
kwin merged pull request #3: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] removed a comment on pull request #2: SLING-10904 update to parent 46
sonarcloud[bot] removed a comment on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2#issuecomment-959117457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #18: SLING-7975 support ordering of resources
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#issuecomment-959956597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] commented on pull request #15: SLING-10907 Make compatible with API 2.24.0
sonarcloud[bot] commented on pull request #15: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/15#issuecomment-959844661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] removed a comment on pull request #18: SLING-7975 support ordering of resources
sonarcloud[bot] removed a comment on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#issuecomment-959956597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] commented on pull request #3: SLING-10905 support multivalue properties
sonarcloud[bot] commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/3#issuecomment-959843165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] commented on pull request #2: SLING-10904 update to parent 46
sonarcloud[bot] commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2#issuecomment-959117457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] kwin merged pull request #51: SLING-7975 support ordering of resources
kwin merged pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] kwin merged pull request #1: SLING-7975 add operation for reordering resources
kwin merged pull request #1: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #51: SLING-7975 support ordering of resources
sonarcloud[bot] commented on pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51#issuecomment-958754787 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #51: SLING-7975 support ordering of resources
sonarcloud[bot] removed a comment on pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51#issuecomment-955670092 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] raducotescu merged pull request #21: SLING-10889 Make the Servlets Resolver compatible with API 2.24.0
raducotescu merged pull request #21: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling i18n 2.5.18
+1 On Tue, Nov 2, 2021 at 2:15 AM Carsten Ziegeler wrote: > +1 > > Carsten > > Am 01.11.2021 um 19:17 schrieb Jörg Hoh: > > Hi, > > > > We solved 1 issue in this > > release:https://issues.apache.org/jira/projects/SLING/versions/12349990 > > > > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2545/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2545 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > > > Jörg > > > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #18: SLING-7975 support ordering of resources
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#issuecomment-959958080 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_coverage&view=list) [92.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] removed a comment on pull request #18: SLING-7975 support ordering of resources
sonarcloud[bot] removed a comment on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#issuecomment-959956597 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_coverage&view=list) [92.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #18: SLING-7975 support ordering of resources
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#issuecomment-959956597 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_coverage&view=list) [92.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=18&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #18: SLING-7975 support ordering of resources
kwin commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#discussion_r742298613
##
File path:
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java
##
@@ -478,6 +479,44 @@ public Resource create(final @NotNull
ResolveContext ctx, fina
}
}
+@Override
+public boolean orderBefore(@NotNull ResolveContext ctx,
@NotNull Resource parent, @NotNull String name,
+@Nullable String followingSiblingName) throws PersistenceException
{
+Node node = parent.adaptTo(Node.class);
+try {
+if (node == null) {
Review comment:
Done in
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18/commits/d74a24df6297e7a78acd2127d19229a19752f5a4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #18: SLING-7975 support ordering of resources
kwin commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18#discussion_r742298158
##
File path:
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java
##
@@ -478,6 +479,44 @@ public Resource create(final @NotNull
ResolveContext ctx, fina
}
}
+@Override
+public boolean orderBefore(@NotNull ResolveContext ctx,
@NotNull Resource parent, @NotNull String name,
+@Nullable String followingSiblingName) throws PersistenceException
{
+Node node = parent.adaptTo(Node.class);
+try {
+if (node == null) {
+throw new PersistenceException("The resource " +
parent.getPath() + " cannot be adapted to Node. It is probably not provided by
the JcrResourceProvider");
+}
+// check if reordering necessary
+NodeIterator nodeIterator = node.getNodes();
+long existingNodePosition = -1;
+long index = 0;
+while (nodeIterator.hasNext()) {
+Node childNode = nodeIterator.nextNode();
+if (childNode.getName().equals(name)) {
+existingNodePosition = index;
+}
+if (existingNodePosition >= 0) {
Review comment:
No, not necessarily. I added some tests. Hopefully they proof that
`true` is only returned in case the order is actually changed. Let me know if I
missed a case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-10907) Make the Sling Scripting HTL Engine compatible with API 2.24.0
[
https://issues.apache.org/jira/browse/SLING-10907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438269#comment-17438269
]
Eric Norman commented on SLING-10907:
-
PR #15 contains the changes for review
> Make the Sling Scripting HTL Engine compatible with API 2.24.0
> --
>
> Key: SLING-10907
> URL: https://issues.apache.org/jira/browse/SLING-10907
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Scripting HTL Engine 1.4.14-1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> SLING-8742 increased the API version for {{o.a.s.api.request}} to 2.5.0.
> Since the o.a.s.scripting.sightly bundle implements an interface from that
> package, the module has to be recompiled so that it can work with version
> 2.24.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10907) Make the Sling Scripting HTL Engine compatible with API 2.24.0
[
https://issues.apache.org/jira/browse/SLING-10907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman updated SLING-10907:
Description: SLING-8742 increased the API version for {{o.a.s.api.request}}
to 2.5.0. Since the o.a.s.scripting.sightly bundle implements an interface from
that package, the module has to be recompiled so that it can work with version
2.24.0. (was: SLING-8742 increased the API version for {{o.a.s.api.request}}
to 2.5.0. Since the o.a.s.scripting.sightly bundle references some classes from
that package, the module has to be recompiled so that it can work with version
2.24.0.)
> Make the Sling Scripting HTL Engine compatible with API 2.24.0
> --
>
> Key: SLING-10907
> URL: https://issues.apache.org/jira/browse/SLING-10907
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Scripting HTL Engine 1.4.14-1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> SLING-8742 increased the API version for {{o.a.s.api.request}} to 2.5.0.
> Since the o.a.s.scripting.sightly bundle implements an interface from that
> package, the module has to be recompiled so that it can work with version
> 2.24.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] commented on pull request #15: SLING-10907 Make compatible with API 2.24.0
sonarcloud[bot] commented on pull request #15: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/15#issuecomment-959844661 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly&pullRequest=15&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10905) Support multi-value properties "operations" and "finaloperations" instead of assuming comma-separated single value
[ https://issues.apache.org/jira/browse/SLING-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10905. - Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/commit/93aca1c47c4679736ae72ae44146460e9db0f8bc. > Support multi-value properties "operations" and "finaloperations" instead of > assuming comma-separated single value > -- > > Key: SLING-10905 > URL: https://issues.apache.org/jira/browse/SLING-10905 > Project: Sling > Issue Type: Bug > Components: Resource Access Security >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Access Security 1.2.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The service property "operations" and "finaloperations" are supposed to be > multi-value string properties instead of just one comma-separated string > according to > https://sling.apache.org/documentation/bundles/resource-access-security.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] kwin merged pull request #3: SLING-10905 support multivalue properties
kwin merged pull request #3: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] commented on pull request #3: SLING-10905 support multivalue properties
sonarcloud[bot] commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/3#issuecomment-959843165 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=3&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] enapps-enorman opened a new pull request #15: SLING-10907 Make compatible with API 2.24.0
enapps-enorman opened a new pull request #15: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/15 SLING-8742 increased the API version for o.a.s.api.request to 2.5.0. Since the o.a.s.scripting.sightly bundle references some classes from that package, the module has to be recompiled so that it can work with version 2.24.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-10907) Make the Sling Scripting HTL Engine compatible with API 2.24.0
Eric Norman created SLING-10907:
---
Summary: Make the Sling Scripting HTL Engine compatible with API
2.24.0
Key: SLING-10907
URL: https://issues.apache.org/jira/browse/SLING-10907
Project: Sling
Issue Type: Improvement
Components: Scripting
Reporter: Eric Norman
Assignee: Eric Norman
Fix For: Scripting HTL Engine 1.4.14-1.4.0
SLING-8742 increased the API version for {{o.a.s.api.request}} to 2.5.0. Since
the o.a.s.scripting.sightly bundle references some classes from that package,
the module has to be recompiled so that it can work with version 2.24.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-10905) Support multi-value properties "operations" and "finaloperations" instead of assuming comma-separated single value
[ https://issues.apache.org/jira/browse/SLING-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10905: --- Assignee: Konrad Windszus > Support multi-value properties "operations" and "finaloperations" instead of > assuming comma-separated single value > -- > > Key: SLING-10905 > URL: https://issues.apache.org/jira/browse/SLING-10905 > Project: Sling > Issue Type: Bug > Components: Resource Access Security >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Access Security 1.2.0 > > > The service property "operations" and "finaloperations" are supposed to be > multi-value string properties instead of just one comma-separated string > according to > https://sling.apache.org/documentation/bundles/resource-access-security.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10906) Implement ResourceAccessSecurity.can...Value()
[
https://issues.apache.org/jira/browse/SLING-10906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10906:
Description:
Currently all methods:
# {{canReadValue}}
# {{canSetValue}} and
# {{canDeleteValue}}
always return {{false}} in {{ResourceAccessSecurityImpl}}. Although those
methods are not used from the resource resolver or any resource provider they
should be implemented based on information from the {{ResourceAccessGate}}.
At the same time the canCreate...Value(s) methods in the {{ResourceAccessGate}}
need to be deprecated as there is no dedicated create method for a property in
Sling Resource API (both creation and update use the same mechanism).
The {{canReadValue}} must also be evaluated before inside
{{ResourceAccessSecurityImpl.getReadableResource()}} to only expose a subset of
properties.
was:
Currently all methods:
# {{canReadValue}}
# {{canSetValue}} and
# {{canDeleteValue}}
always return {{false}} in {{ResourceAccessSecurityImpl}}. Although those
methods are not used from the resource resolver or any resource provider they
should be implemented based on information from the {{ResourceAccessGate}}.
At the same time the canCreate...Value(s) methods in the {{ResourceAccessGate}}
need to be deprecated as there is no dedicated create method for a property in
Sling Resource API (both creation and update use the same mechanism).
> Implement ResourceAccessSecurity.can...Value()
> ---
>
> Key: SLING-10906
> URL: https://issues.apache.org/jira/browse/SLING-10906
> Project: Sling
> Issue Type: Improvement
> Components: Resource Access Security
>Affects Versions: Resource Access Security 1.0.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently all methods:
> # {{canReadValue}}
> # {{canSetValue}} and
> # {{canDeleteValue}}
> always return {{false}} in {{ResourceAccessSecurityImpl}}. Although those
> methods are not used from the resource resolver or any resource provider they
> should be implemented based on information from the {{ResourceAccessGate}}.
> At the same time the canCreate...Value(s) methods in the
> {{ResourceAccessGate}} need to be deprecated as there is no dedicated create
> method for a property in Sling Resource API (both creation and update use the
> same mechanism).
> The {{canReadValue}} must also be evaluated before inside
> {{ResourceAccessSecurityImpl.getReadableResource()}} to only expose a subset
> of properties.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10904) Update to Parent 46
[ https://issues.apache.org/jira/browse/SLING-10904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10904. - Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/commit/b6657c40c506373c958acb3f88f1c08e9b6b4566. > Update to Parent 46 > --- > > Key: SLING-10904 > URL: https://issues.apache.org/jira/browse/SLING-10904 > Project: Sling > Issue Type: Improvement > Components: Resource Access Security >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Access Security 1.2.0 > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] kwin merged pull request #2: SLING-10904 update to parent 46
kwin merged pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] commented on pull request #2: SLING-10904 update to parent 46
sonarcloud[bot] commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2#issuecomment-959744056 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_coverage&view=list) [73.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] removed a comment on pull request #2: SLING-10904 update to parent 46
sonarcloud[bot] removed a comment on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2#issuecomment-959135343 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_coverage&view=list) [87.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438179#comment-17438179
]
Angela Schreiber edited comment on SLING-10011 at 11/3/21, 5:01 PM:
[~cziegeler], fine with me... i will create a ticket for jackrabbit API in the
oak project and discuss it with the team (see OAK-9613)
was (Author: anchela):
[~cziegeler], fine with me... i will create a ticket for jackrabbit API in the
oak project and discuss it with the team.
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438179#comment-17438179
]
Angela Schreiber commented on SLING-10011:
--
[~cziegeler], fine with me... i will create a ticket for jackrabbit API in the
oak project and discuss it with the team.
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438178#comment-17438178
]
Carsten Ziegeler commented on SLING-10011:
--
[~angela] If I remember correctly it was about the performance related to
needing to catch the exception (or something like that). It might not be
relevant today with never java versions.
I'm fine either way - somehow I prefer having that new method in the api
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438125#comment-17438125
]
Angela Schreiber edited comment on SLING-10011 at 11/3/21, 4:24 PM:
hi [~cziegeler], I am not sure how big the performance benefit would be of a
new API. fact is that the {{AccessDeniedException}} is generated only in the
_oak-jcr_ layer if there exists no accessible parent. so, if we are using
{{Item.getParent}} we have to catch the {{RepositoryException}} to return
{{null}} (as it was returned by Oak API in the first place). but maybe that's
not such a big deal.. the reason why I brought it up was that I vaguely
remembered that those exceptions were the reason for use
{{Session.getItemOrNull}} in the first place, right?
was (Author: anchela):
hi [~cziegeler], I am not sure how big the performance benefit would be of a
new API. fact is that the {{AccessDeniedException}} is generated only in the
_oak-jcr_ layer if the exists no accessible parent. so, if we are using
{{Item.getParent}} we have to catch the {{RepositoryException}} to return
{{null}} (as it was returned by Oak API in the first place). but maybe that's
not such a big deal.. the reason why I brought it up was that I vaguely
remembered that those exceptions were the reason for use
{{Session.getItemOrNull}} in the first place, right?
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438125#comment-17438125
]
Angela Schreiber commented on SLING-10011:
--
hi [~cziegeler], I am not sure how big the performance benefit would be of a
new API. fact is that the {{AccessDeniedException}} is generated only in the
_oak-jcr_ layer if the exists no accessible parent. so, if we are using
{{Item.getParent}} we have to catch the {{RepositoryException}} to return
{{null}} (as it was returned by Oak API in the first place). but maybe that's
not such a big deal.. the reason why I brought it up was that I vaguely
remembered that those exceptions were the reason for use
{{Session.getItemOrNull}} in the first place, right?
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] removed a comment on pull request #2: SLING-10904 update to parent 46
sonarcloud[bot] removed a comment on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2#issuecomment-959117457 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_coverage&view=list) [87.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] commented on pull request #2: SLING-10904 update to parent 46
sonarcloud[bot] commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2#issuecomment-959135343 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_coverage&view=list) [87.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] sonarcloud[bot] commented on pull request #2: SLING-10904 update to parent 46
sonarcloud[bot] commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2#issuecomment-959117457 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_coverage&view=list) [87.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceaccesssecurity&pullRequest=2&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-10906) Implement can...Value()
Konrad Windszus created SLING-10906:
---
Summary: Implement can...Value()
Key: SLING-10906
URL: https://issues.apache.org/jira/browse/SLING-10906
Project: Sling
Issue Type: Improvement
Components: Resource Access Security
Affects Versions: Resource Access Security 1.0.0
Reporter: Konrad Windszus
Currently all methods:
# {{canReadValue}}
# {{canSetValue}} and
# {{canDeleteValue}}
always return {{false}} in {{ResourceAccessSecurityImpl}}. Although those
methods are not used from the resource resolver or any resource provider they
should be implemented based on information from the {{ResourceAccessGate}}.
At the same time the canCreate...Value(s) methods in the {{ResourceAccessGate}}
need to be deprecated as there is no dedicated create method for a property in
Sling Resource API (both creation and update use the same mechanism).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10906) Implement ResourceAccessSecurity.can...Value()
[
https://issues.apache.org/jira/browse/SLING-10906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10906:
Summary: Implement ResourceAccessSecurity.can...Value() (was: Implement
can...Value() )
> Implement ResourceAccessSecurity.can...Value()
> ---
>
> Key: SLING-10906
> URL: https://issues.apache.org/jira/browse/SLING-10906
> Project: Sling
> Issue Type: Improvement
> Components: Resource Access Security
>Affects Versions: Resource Access Security 1.0.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently all methods:
> # {{canReadValue}}
> # {{canSetValue}} and
> # {{canDeleteValue}}
> always return {{false}} in {{ResourceAccessSecurityImpl}}. Although those
> methods are not used from the resource resolver or any resource provider they
> should be implemented based on information from the {{ResourceAccessGate}}.
> At the same time the canCreate...Value(s) methods in the
> {{ResourceAccessGate}} need to be deprecated as there is no dedicated create
> method for a property in Sling Resource API (both creation and update use the
> same mechanism).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10905) Support multi-value properties "operations" and "finaloperations" instead of assuming comma-separated single value
[ https://issues.apache.org/jira/browse/SLING-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10905: Summary: Support multi-value properties "operations" and "finaloperations" instead of assuming comma-separated single value (was: Support multi-value property "operations" and "finaloperations") > Support multi-value properties "operations" and "finaloperations" instead of > assuming comma-separated single value > -- > > Key: SLING-10905 > URL: https://issues.apache.org/jira/browse/SLING-10905 > Project: Sling > Issue Type: Bug > Components: Resource Access Security >Reporter: Konrad Windszus >Priority: Major > Fix For: Resource Access Security 1.2.0 > > > The service property "operations" and "finaloperations" are supposed to be > multi-value string properties instead of just one comma-separated string > according to > https://sling.apache.org/documentation/bundles/resource-access-security.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10904) Update to Parent 46
[ https://issues.apache.org/jira/browse/SLING-10904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438062#comment-17438062 ] Konrad Windszus commented on SLING-10904: - PR in https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/2/files > Update to Parent 46 > --- > > Key: SLING-10904 > URL: https://issues.apache.org/jira/browse/SLING-10904 > Project: Sling > Issue Type: Improvement > Components: Resource Access Security >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Access Security 1.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10895) new "getPropertyMap()" API for ResourceResolver
[
https://issues.apache.org/jira/browse/SLING-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-10895:
Assignee: Joerg Hoh
> new "getPropertyMap()" API for ResourceResolver
> ---
>
> Key: SLING-10895
> URL: https://issues.apache.org/jira/browse/SLING-10895
> Project: Sling
> Issue Type: Improvement
> Components: API, ResourceResolver
>Affects Versions: API 2.23.6, Resource Resolver 1.7.10
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: API 2.24.0, Resource Resolver 1.8.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> As discussed on sling-dev [1] we should add a method
> {code}
> public Map getPropertyMap()
> {code}
> to the Resource Resolver, which can help temporary objects along the lifetime
> of the ResourceResolver
> [1]
> https://lists.apache.org/thread.html/r4944081b8662b6ac3254ae2827280f59012e2bf53399366e7e16cd29%40%3Cdev.sling.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438036#comment-17438036
]
Carsten Ziegeler commented on SLING-10011:
--
[~angela] Would there be any performance benefit from adding such a new method
to Jackrabbit API? If it is just about the exception, we can go with
Item.getParent() and just ignore the exception (returning null)
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438032#comment-17438032
]
Angela Schreiber commented on SLING-10011:
--
[~cziegeler], you are right {{JackrabbitSession.getParentOrNull(Item item)}}
doesn't exist yet. nor does {{JackrabbitItem}} but if we need it, I think
we should extend the API. If we can live with {{Item.getParent}} and reasonably
deal with the exception it would obviously be easier to resolve. otherwise 1
cycle of releasing Oak from trunk would be needed.
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437976#comment-17437976
]
Carsten Ziegeler commented on SLING-10011:
--
[~angela] yes, I would like to get it resolved, too - one way or the other. I'm
fine with using Item.getParent() - we just need to see how to handle the
exception. But Jackrabbit API would be fine too. However I guess that doesn't
exist yet
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10905) Support multi-value property "operations" and "finaloperations"
Konrad Windszus created SLING-10905: --- Summary: Support multi-value property "operations" and "finaloperations" Key: SLING-10905 URL: https://issues.apache.org/jira/browse/SLING-10905 Project: Sling Issue Type: Bug Components: Resource Access Security Reporter: Konrad Windszus Fix For: Resource Access Security 1.2.0 The service property "operations" and "finaloperations" are supposed to be multi-value string properties instead of just one comma-separated string according to https://sling.apache.org/documentation/bundles/resource-access-security.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10873) Provide a generic Content Worker module
[ https://issues.apache.org/jira/browse/SLING-10873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-10873: - Description: To support more AV solutions in Sling besides Clam a generic module is required. The module will use Commons Content Analyzing and Commons Content Processing APIs to hook in various solutions including Sling Commons Clam. The module will target AEMaaCS but stick to Sling and JCR/Oak APIs. See also [Scanning for Malware in Apache Sling and Adobe Experience Manager|https://adapt.to/2020/en/schedule/scanning-for-malware-in-apache-sling-and-aem.html] and [Implement "Anti Virus" (Anti Maleware) scans in AEM Cloud Service (AEMaaCS) - "Anti-Malware as a Cloud Service"|https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-ideas/implement-quot-anti-virus-quot-anti-maleware-scans-in-aem-cloud/idi-p/405511]. *Mandatory features* * Jobs * JCR/Oak Observation * Command via HTTP (work on demand) *Optional features* * Monitoring via HTTP * Result handling was: To support more AV solutions in Sling besides Clam a generic module is required. The module will use Commons Content Analyzing and Commons Content Processing APIs to hook in various solutions including Sling Commons Clam. The module will target AEMaaCS but stick to Sling and JCR/Oak APIs. See also [Scanning for Malware in Apache Sling and Adobe Experience Manager|https://adapt.to/2020/en/schedule/scanning-for-malware-in-apache-sling-and-aem.html] and [Implement "Anti Virus" (Anti Maleware) scans in AEM Cloud Service (AEMaaCS) - "Anti-Malware as a Cloud Service"|https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-ideas/implement-quot-anti-virus-quot-anti-maleware-scans-in-aem-cloud/idi-p/405511]. > Provide a generic Content Worker module > --- > > Key: SLING-10873 > URL: https://issues.apache.org/jira/browse/SLING-10873 > Project: Sling > Issue Type: New Feature > Components: JCR, Oak >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Content Worker 1.0.0 > > > To support more AV solutions in Sling besides Clam a generic module is > required. > The module will use Commons Content Analyzing and Commons Content Processing > APIs to hook in various solutions including Sling Commons Clam. > The module will target AEMaaCS but stick to Sling and JCR/Oak APIs. > See also [Scanning for Malware in Apache Sling and Adobe Experience > Manager|https://adapt.to/2020/en/schedule/scanning-for-malware-in-apache-sling-and-aem.html] > and [Implement "Anti Virus" (Anti Maleware) scans in AEM Cloud Service > (AEMaaCS) - "Anti-Malware as a Cloud > Service"|https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager-ideas/implement-quot-anti-virus-quot-anti-maleware-scans-in-aem-cloud/idi-p/405511]. > *Mandatory features* > * Jobs > * JCR/Oak Observation > * Command via HTTP (work on demand) > *Optional features* > * Monitoring via HTTP > * Result handling -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10904) Update to Parent 46
Konrad Windszus created SLING-10904: --- Summary: Update to Parent 46 Key: SLING-10904 URL: https://issues.apache.org/jira/browse/SLING-10904 Project: Sling Issue Type: Improvement Components: Resource Access Security Reporter: Konrad Windszus Fix For: Resource Access Security 1.2.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10904) Update to Parent 46
[ https://issues.apache.org/jira/browse/SLING-10904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10904: --- Assignee: Konrad Windszus > Update to Parent 46 > --- > > Key: SLING-10904 > URL: https://issues.apache.org/jira/browse/SLING-10904 > Project: Sling > Issue Type: Improvement > Components: Resource Access Security >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Access Security 1.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-7975) Add a Java API for ordering resources
[ https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7975: --- Component/s: Resource Access Security > Add a Java API for ordering resources > - > > Key: SLING-7975 > URL: https://issues.apache.org/jira/browse/SLING-7975 > Project: Sling > Issue Type: New Feature > Components: API, Resource Access Security, ResourceResolver >Reporter: Jean-Christophe Kautzmann >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Access Security 1.2.0, API 2.24.0, Resource > Resolver 1.8.0 > > Time Spent: 7.5h > Remaining Estimate: 0h > > Sling should provide an API (e.g. in Resource, ResourceResolver or > ResourceUtil) to order resources, similar to what the JCR API provides: > [https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/javax/jcr/Node.html#orderBefore(java.lang.String,%20java.lang.String]) > > This would help avoid having to use the JCR API. > > The implementation is already available at: > [https://github.com/apache/sling-old-svn-mirror/blob/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostOperation.java#L411] > > It is only a matter of exposing it as part of the Sling API. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-7975) Add a Java API for ordering resources
[ https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7975: --- Fix Version/s: Resource Access Security 1.0.2 > Add a Java API for ordering resources > - > > Key: SLING-7975 > URL: https://issues.apache.org/jira/browse/SLING-7975 > Project: Sling > Issue Type: New Feature > Components: API, ResourceResolver >Reporter: Jean-Christophe Kautzmann >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Access Security 1.0.2, API 2.24.0, Resource > Resolver 1.8.0 > > Time Spent: 7.5h > Remaining Estimate: 0h > > Sling should provide an API (e.g. in Resource, ResourceResolver or > ResourceUtil) to order resources, similar to what the JCR API provides: > [https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/javax/jcr/Node.html#orderBefore(java.lang.String,%20java.lang.String]) > > This would help avoid having to use the JCR API. > > The implementation is already available at: > [https://github.com/apache/sling-old-svn-mirror/blob/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostOperation.java#L411] > > It is only a matter of exposing it as part of the Sling API. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (SLING-7975) Add a Java API for ordering resources
[ https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435285#comment-17435285 ] Konrad Windszus edited comment on SLING-7975 at 11/3/21, 10:42 AM: --- API changes committed in https://github.com/apache/sling-org-apache-sling-api/commit/4fdc49c61bd686c11877927810a68c8c7faa55c3. ResourceResolver changes committed in https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/e278f15a0bd7e501afe5358728de78a2cb5a9214. Resource Access Security changes committed in https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/commit/27c5c28d062161b36f862efce7fa410bcc7a6805. was (Author: kwin): API changes committed in https://github.com/apache/sling-org-apache-sling-api/commit/4fdc49c61bd686c11877927810a68c8c7faa55c3. ResourceResolver changes committed in https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/e278f15a0bd7e501afe5358728de78a2cb5a9214. > Add a Java API for ordering resources > - > > Key: SLING-7975 > URL: https://issues.apache.org/jira/browse/SLING-7975 > Project: Sling > Issue Type: New Feature > Components: API, ResourceResolver >Reporter: Jean-Christophe Kautzmann >Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Access Security 1.0.2, API 2.24.0, Resource > Resolver 1.8.0 > > Time Spent: 7.5h > Remaining Estimate: 0h > > Sling should provide an API (e.g. in Resource, ResourceResolver or > ResourceUtil) to order resources, similar to what the JCR API provides: > [https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/javax/jcr/Node.html#orderBefore(java.lang.String,%20java.lang.String]) > > This would help avoid having to use the JCR API. > > The implementation is already available at: > [https://github.com/apache/sling-old-svn-mirror/blob/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostOperation.java#L411] > > It is only a matter of exposing it as part of the Sling API. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-resourceaccesssecurity] kwin merged pull request #1: SLING-7975 add operation for reordering resources
kwin merged pull request #1: URL: https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] raducotescu merged pull request #21: SLING-10889 Make the Servlets Resolver compatible with API 2.24.0
raducotescu merged pull request #21: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10889) Make the Servlets Resolver compatible with API 2.24.0
[
https://issues.apache.org/jira/browse/SLING-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437875#comment-17437875
]
Radu Cotescu commented on SLING-10889:
--
I know, they passed until [~kwin] merged
[https://github.com/apache/sling-org-apache-sling-api/commit/4fdc49c61bd686c11877927810a68c8c7faa55c3.]
Thanks for updating the dependency.
> Make the Servlets Resolver compatible with API 2.24.0
> -
>
> Key: SLING-10889
> URL: https://issues.apache.org/jira/browse/SLING-10889
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Servlets Resolver 2.8.4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> SLING-8742 increased the API version for {{o.a.s.api.request}} to 2.5.0.
> Since the {{o.a.s.servlets.resolver}} bundle implements some of the
> interfaces from that package, the module has to be recompiled so that it can
> work with version 2.24.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10740) Repoinit create path statement fails for node types with a mandatory property
[
https://issues.apache.org/jira/browse/SLING-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437874#comment-17437874
]
Angela Schreiber commented on SLING-10740:
--
hi [~enorman], principal-based authorization must only rely on principal
management API. the fact that users/groups are also a source of principals
should be considered an implementation detail and neither oak authorization nor
application code should expect any principal being backed by a user/group.
what you perceive as an inconsistency in the user management between lookup by
id vs principal is caused by the fact that lookup by id results in a UUID-query
in the {{IdentifierManager}}. while the query itself would only be executed
against persisted data, there exists special handling for transient UUIDs in
oak, which does not exist for any other lookup. if you think the default
principal lookup should also come with such a special behavior feel free to
open an improvement request in the Oak project for components 'query' and
'security'. then we can discuss it with the teams involved what the impact
would be and whether that makes sense or not.
> Repoinit create path statement fails for node types with a mandatory property
> -
>
> Key: SLING-10740
> URL: https://issues.apache.org/jira/browse/SLING-10740
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Repoinit JCR 1.1.38
>
>
> The processing of the "create path" statement calls save() at the end which
> will cause a constraint violation if the nodetype of the created path
> contains any properties that are declared as mandatory (and not autocreated).
> No processing of "set properties" statements happens before the save() call
> in AclVisitor#visitCreatePath so it does not seem to be possible to define
> any mandatory properties using the current repoinit grammar.
> I could see this solved in a couple ways:
> # The AclVisitor#visitCreatePath could possibly pre-process any "set
> properties" statements that are applicable to the created path before calling
> save and then skip those same items when NodePropertiesVisitor visits the
> same.
> # Or, the "create path" grammar could be extended to allow defining
> properties to be set at the same time as the create (with a syntax that is
> similar to the "set properties" statement?)
> # Or, perhaps calling save in AclVisitor#visitCreatePath is not necessary?
> I'm not sure of the historical reasons why save() is done there.
> # Or, maybe something else I haven't thought of
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437853#comment-17437853
]
Angela Schreiber edited comment on SLING-10011 at 11/3/21, 9:30 AM:
[~cziegeler], thanks for the update. so, what are the plans for this issue?
IMHO it would be beneficial to have it addressed and I would like to see it
fixed. In other words: let me know what is needed from the Jackrabbit API side.
was (Author: anchela):
[~cziegeler], thanks for the update. so, what are the plans for this issue?
IMHO it would be beneficial to have it addressed and I would like to see it
fixed.
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437853#comment-17437853
]
Angela Schreiber commented on SLING-10011:
--
[~cziegeler], thanks for the update. so, what are the plans for this issue?
IMHO it would be beneficial to have it addressed and I would like to see it
fixed.
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-10838) Remove /system/docroot:/ mapping from the default ResourceResolverFactroy config
[ https://issues.apache.org/jira/browse/SLING-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-10838: Assignee: Carsten Ziegeler > Remove /system/docroot:/ mapping from the default ResourceResolverFactroy > config > > > Key: SLING-10838 > URL: https://issues.apache.org/jira/browse/SLING-10838 > Project: Sling > Issue Type: Task >Reporter: Robert Munteanu >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Resource Resolver 1.8.0 > > > This configuration does not seem to have any use in recent versions of Sling, > so we should remove it since it's confusing and does nothing. See also > https://lists.apache.org/thread.html/r6c5c9a01a9f17e0ebd42267f9dc78d71251c37d4557aa37316886cac%40%3Cdev.sling.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10838) Remove /system/docroot:/ mapping from the default ResourceResolverFactroy config
[ https://issues.apache.org/jira/browse/SLING-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10838. -- Resolution: Fixed Removed in https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/9e06487219a95d7256413adef2b4a73fed433fbf > Remove /system/docroot:/ mapping from the default ResourceResolverFactroy > config > > > Key: SLING-10838 > URL: https://issues.apache.org/jira/browse/SLING-10838 > Project: Sling > Issue Type: Task >Reporter: Robert Munteanu >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Resource Resolver 1.8.0 > > > This configuration does not seem to have any use in recent versions of Sling, > so we should remove it since it's confusing and does nothing. See also > https://lists.apache.org/thread.html/r6c5c9a01a9f17e0ebd42267f9dc78d71251c37d4557aa37316886cac%40%3Cdev.sling.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-7975) Add a Java API for ordering resources
[ https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-7975: Component/s: ResourceResolver > Add a Java API for ordering resources > - > > Key: SLING-7975 > URL: https://issues.apache.org/jira/browse/SLING-7975 > Project: Sling > Issue Type: New Feature > Components: API, ResourceResolver >Reporter: Jean-Christophe Kautzmann >Assignee: Konrad Windszus >Priority: Major > Fix For: API 2.24.0, Resource Resolver 1.7.12 > > Time Spent: 7h 20m > Remaining Estimate: 0h > > Sling should provide an API (e.g. in Resource, ResourceResolver or > ResourceUtil) to order resources, similar to what the JCR API provides: > [https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/javax/jcr/Node.html#orderBefore(java.lang.String,%20java.lang.String]) > > This would help avoid having to use the JCR API. > > The implementation is already available at: > [https://github.com/apache/sling-old-svn-mirror/blob/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostOperation.java#L411] > > It is only a matter of exposing it as part of the Sling API. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-7975) Add a Java API for ordering resources
[ https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7975: --- Fix Version/s: Resource Resolver 1.7.12 > Add a Java API for ordering resources > - > > Key: SLING-7975 > URL: https://issues.apache.org/jira/browse/SLING-7975 > Project: Sling > Issue Type: New Feature > Components: API >Reporter: Jean-Christophe Kautzmann >Assignee: Konrad Windszus >Priority: Major > Fix For: API 2.24.0, Resource Resolver 1.7.12 > > Time Spent: 7h 20m > Remaining Estimate: 0h > > Sling should provide an API (e.g. in Resource, ResourceResolver or > ResourceUtil) to order resources, similar to what the JCR API provides: > [https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/javax/jcr/Node.html#orderBefore(java.lang.String,%20java.lang.String]) > > This would help avoid having to use the JCR API. > > The implementation is already available at: > [https://github.com/apache/sling-old-svn-mirror/blob/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostOperation.java#L411] > > It is only a matter of exposing it as part of the Sling API. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (SLING-7975) Add a Java API for ordering resources
[ https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435285#comment-17435285 ] Konrad Windszus edited comment on SLING-7975 at 11/3/21, 8:56 AM: -- API changes committed in https://github.com/apache/sling-org-apache-sling-api/commit/4fdc49c61bd686c11877927810a68c8c7faa55c3. ResourceResolver changes committed in https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/e278f15a0bd7e501afe5358728de78a2cb5a9214. was (Author: kwin): API changes committed in https://github.com/apache/sling-org-apache-sling-api/commit/4fdc49c61bd686c11877927810a68c8c7faa55c3. > Add a Java API for ordering resources > - > > Key: SLING-7975 > URL: https://issues.apache.org/jira/browse/SLING-7975 > Project: Sling > Issue Type: New Feature > Components: API >Reporter: Jean-Christophe Kautzmann >Assignee: Konrad Windszus >Priority: Major > Fix For: API 2.24.0 > > Time Spent: 7h 20m > Remaining Estimate: 0h > > Sling should provide an API (e.g. in Resource, ResourceResolver or > ResourceUtil) to order resources, similar to what the JCR API provides: > [https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/javax/jcr/Node.html#orderBefore(java.lang.String,%20java.lang.String]) > > This would help avoid having to use the JCR API. > > The implementation is already available at: > [https://github.com/apache/sling-old-svn-mirror/blob/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostOperation.java#L411] > > It is only a matter of exposing it as part of the Sling API. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-resourceresolver] kwin merged pull request #51: SLING-7975 support ordering of resources
kwin merged pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #51: SLING-7975 support ordering of resources
sonarcloud[bot] removed a comment on pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51#issuecomment-955670092 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #51: SLING-7975 support ordering of resources
sonarcloud[bot] commented on pull request #51: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51#issuecomment-958754787 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=51&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-10011:
-
Fix Version/s: (was: JCR Resource 3.0.24)
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10011) Use javax.jcr.Item.getParent() when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437795#comment-17437795
]
Carsten Ziegeler commented on SLING-10011:
--
The PR has been reverted:
https://github.com/apache/sling-org-apache-sling-jcr-resource/commit/8c2621260ca1d7f92d0e9c747503322b33e9f208
> Use javax.jcr.Item.getParent() when resolving parent JCR node in
> JcrResourceProvider#getParent
> --
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Minor
> Fix For: JCR Resource 3.0.24
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10899) Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached
[ https://issues.apache.org/jira/browse/SLING-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-10899: - Fix Version/s: (was: JCR Resource 3.0.24) > Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached > -- > > Key: SLING-10899 > URL: https://issues.apache.org/jira/browse/SLING-10899 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.0.22 >Reporter: Henry Kuijpers >Assignee: Carsten Ziegeler >Priority: Major > > I was performance testing our application. There is a specific part of the > code where we have a set of ~500 resources and we sort them based on a few > properties of the resources. Multiple properties are used (which results in > multiple calls to getValueMap). The sorting is done using a comparator, so > the logic that determines the order is accessed numerous times. > We've seen quite a decrease in performance when doing this with Resources > that are of type JcrNodeResource. Turns out that the result of getValueMap > (or adaptTo((Value)Map.class)) is not cached. > As you can see in the adaptTo()-method implementation: > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java#L136 > this call bypasses the AdapterFactory framework and also bypasses any > caching that happens over there. > What's even more unfortunate, is that JcrValueMap is implementing caching via > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/6e13f4d315ddf2804d2e16c55faee18e805b618e/src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java#L49 > . That caching is not leveraged properly, because every call to getValueMap > returns a new JcrValueMap, instead of reusing a previously created one. > One change that can be done is maybe converting the logic inside the > adaptTo()-method to a dedicated AdapterFactory implementation, so that > caching is done by default? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10899) Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached
[ https://issues.apache.org/jira/browse/SLING-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-10899: Assignee: (was: Carsten Ziegeler) > Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached > -- > > Key: SLING-10899 > URL: https://issues.apache.org/jira/browse/SLING-10899 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.0.22 >Reporter: Henry Kuijpers >Priority: Major > > I was performance testing our application. There is a specific part of the > code where we have a set of ~500 resources and we sort them based on a few > properties of the resources. Multiple properties are used (which results in > multiple calls to getValueMap). The sorting is done using a comparator, so > the logic that determines the order is accessed numerous times. > We've seen quite a decrease in performance when doing this with Resources > that are of type JcrNodeResource. Turns out that the result of getValueMap > (or adaptTo((Value)Map.class)) is not cached. > As you can see in the adaptTo()-method implementation: > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java#L136 > this call bypasses the AdapterFactory framework and also bypasses any > caching that happens over there. > What's even more unfortunate, is that JcrValueMap is implementing caching via > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/6e13f4d315ddf2804d2e16c55faee18e805b618e/src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java#L49 > . That caching is not leveraged properly, because every call to getValueMap > returns a new JcrValueMap, instead of reusing a previously created one. > One change that can be done is maybe converting the logic inside the > adaptTo()-method to a dedicated AdapterFactory implementation, so that > caching is done by default? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10903) Remove duplicate code from value map implementations
[ https://issues.apache.org/jira/browse/SLING-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10903. -- Resolution: Fixed Removed duplicate code and adjusted/added tests https://github.com/apache/sling-org-apache-sling-jcr-resource/commit/bea0c3428a7c97d757ad89ebabbc23a912d84759 > Remove duplicate code from value map implementations > > > Key: SLING-10903 > URL: https://issues.apache.org/jira/browse/SLING-10903 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: JCR Resource 3.0.24 > > > The JcrValueMap and JcrModifiableValueMap classes are identical for reading, > they only differ in write support. We should remove the duplicate code and > let JcrModifiableValueMap extend from JcrValuemap -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10903) Remove duplicate code from value map implementations
Carsten Ziegeler created SLING-10903: Summary: Remove duplicate code from value map implementations Key: SLING-10903 URL: https://issues.apache.org/jira/browse/SLING-10903 Project: Sling Issue Type: Improvement Components: JCR Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: JCR Resource 3.0.24 The JcrValueMap and JcrModifiableValueMap classes are identical for reading, they only differ in write support. We should remove the duplicate code and let JcrModifiableValueMap extend from JcrValuemap -- This message was sent by Atlassian Jira (v8.3.4#803005)
[RESULT][VOTE] Release Apache Sling Feature Model Analyser 1.5.0
This vote passes with 4 binding +1 and 1 nonbinding +1. I will release the artifacts to maven. Could someone from PMC take care of publishing the source to Apache svn? Christian Am Do., 28. Okt. 2021 um 11:58 Uhr schrieb Christian Schneider < ch...@die-schneider.net>: > Hi, > > we solved two issues for the feature model analyser 1.5.0: > https://issues.apache.org/jira/projects/SLING/versions/12350715 > > ** New Feature > * [SLING-10866] - Analyser that runs filevault validations on content > packages > > ** Improvement > * [SLING-10881] - Log timing for scanner and analyser task > > Staging repository > https://repository.apache.org/content/repositories/orgapachesling-2544 > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2525 /tmp/sling-staging > sh check_staged_release.sh 2526 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > > -- > -- > Christian Schneider > http://www.liquid-reality.de > > Computer Scientist > http://www.adobe.com > > -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
