[GitHub] [sling-org-apache-sling-hapi-client] vhochstein commented on pull request #1: update dependencies to current ones
vhochstein commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-hapi-client/pull/1#issuecomment-988553954 Anybody still maintaining this repository ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10977) Exclude JDK packages from version range checks
[ https://issues.apache.org/jira/browse/SLING-10977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10977. -- Resolution: Fixed Updated both analysers , other JDK packages like javax, org.xml and org.w3c where already excluded > Exclude JDK packages from version range checks > -- > > Key: SLING-10977 > URL: https://issues.apache.org/jira/browse/SLING-10977 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Feature Model Analyser >Affects Versions: Feature Model API Regions Extension 1.4.0, Feature Model > Analyser 1.5.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 1.5.2, Feature Model API Regions > Extension 1.4.2 > > > The analysers for package exports/imports currently warn if a bundle is > importing JDK packages without a warning: > [WARNING] [api-regions-exportsimports] foo:1.0-SNAPSHOT: Bundle > foo:1.0-SNAPSHOT is importing package(s) [java.lang.invoke, java.util, > java.util.function, java.io, java.lang, java.util.stream] without specifying > a version range. > As JDK packages usually do not have a version, it doesn't make sense to > require them for an import package statement -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-10977) Exclude JDK packages from version range checks
Carsten Ziegeler created SLING-10977: Summary: Exclude JDK packages from version range checks Key: SLING-10977 URL: https://issues.apache.org/jira/browse/SLING-10977 Project: Sling Issue Type: Improvement Components: Feature Model, Feature Model Analyser Affects Versions: Feature Model Analyser 1.5.0, Feature Model API Regions Extension 1.4.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model API Regions Extension 1.4.2, Feature Model Analyser 1.5.2 The analysers for package exports/imports currently warn if a bundle is importing JDK packages without a warning: [WARNING] [api-regions-exportsimports] foo:1.0-SNAPSHOT: Bundle foo:1.0-SNAPSHOT is importing package(s) [java.lang.invoke, java.util, java.util.function, java.io, java.lang, java.util.stream] without specifying a version range. As JDK packages usually do not have a version, it doesn't make sense to require them for an import package statement -- This message was sent by Atlassian Jira (v8.20.1#820001)
Re: [VOTE] Release Apache Sling Testing OSGi Mock 3.2.2
+1 Le mar. 7 déc. 2021 à 17:44, Konrad Windszus a écrit : > +1 > > Konrad >
Re: [VOTE] Release Apache Sling Testing OSGi Mock 3.2.2
+1 Konrad
Re: [VOTE] Release Apache Sling Testing OSGi Mock 3.2.2
+1 Carsten Am 07.12.2021 um 17:20 schrieb Stefan Seifert: Hi, Testing OSGi Mock 3.2.2 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12350890 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2559/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2559 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan -- Carsten Ziegeler Adobe cziege...@apache.org
RE: [VOTE] Release Apache Sling Testing OSGi Mock 3.2.2
+1
[VOTE] Release Apache Sling Testing OSGi Mock 3.2.2
Hi, Testing OSGi Mock 3.2.2 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12350890 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2559/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2559 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan
[jira] [Created] (SLING-10976) Add options to disable usage of request parameters
Carsten Ziegeler created SLING-10976: Summary: Add options to disable usage of request parameters Key: SLING-10976 URL: https://issues.apache.org/jira/browse/SLING-10976 Project: Sling Issue Type: Improvement Components: Health Check Reporter: Carsten Ziegeler Fix For: Health Check Core 1.2.12 Currently the execution of the health check servlet can be controlled via request parameters. While this is nice, there are scenarios where this is not wanted and the endpoint should exactly report as configured. For this an OSGi configuration like 'disableRequestConfiguration' could be set to true and then most request parameters are ignored. Currently we have the param list [1] in the html rendering, At least the output format should still be controllable via parameters [1] Supported URL parameters tags:Comma-separated list of health checks tags to select - can also be specified via path, e.g. /system/health/tag1,tag2.json. Exclusions can be done by prepending '-' to the tag name names:Comma-separated list of health check names to select. Exclusions can be done by prepending '-' to the health check name format:Output format, html|json|jsonp|txt - an extension in the URL overrides this httpStatus:Specify HTTP result code, for example CRITICAL:503 (status 503 if result >= CRITICAL) or CRITICAL:503,HEALTH_CHECK_ERROR:500,OK:418 for more specific HTTP status combineTagsWithOr:Combine tags with OR, active by default. Set to false to combine with AND forceInstantExecution:If true, forces instant execution by executing async health checks directly, circumventing the cache (2sec by default) of the HealthCheckExecutor timeout:(msec) a timeout status is returned for any health check still running after this period. Overrides the default HealthCheckExecutor timeout hcDebug:Include the DEBUG output of the Health Checks callback:name of the JSONP callback function to use, defaults to processHealthCheckResults [2] https://github.com/apache/felix-dev/blob/master/healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServletConfiguration.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-10975) osgi-mock: Remove duplicate handling of ServiceFactory implementation
[ https://issues.apache.org/jira/browse/SLING-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-10975. Resolution: Fixed https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/commit/0ec917d712c4869462171f0d9aba61eb351e4787 > osgi-mock: Remove duplicate handling of ServiceFactory implementation > - > > Key: SLING-10975 > URL: https://issues.apache.org/jira/browse/SLING-10975 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing OSGi Mock 3.2.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Minor > Fix For: Testing OSGi Mock 3.2.2 > > > since SLING-5090 we have a very simplified ServiceFactory support, which is > not really implemented correctly but it seemed to fulfill the need of some > unit tests. having a proper serviceScope=PROTOTYPE and ServiceFactory > implementation would required much more work, and a full working SCR > component registry which is able to manage multiple service instances per > service factory registrattion. > in this ticket, we remove some misplaced code around the existing > ServiceFactory implementation without improving it: some code around this > handling got duplicated, and would do harm it it would be executed the > intended way. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10975) osgi-mock: Remove duplicate handling of ServiceFactory implementation
[ https://issues.apache.org/jira/browse/SLING-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-10975: --- Description: since SLING-5090 we have a very simplified ServiceFactory support, which is not really implemented correctly but it seemed to fulfill the need of some unit tests. having a proper serviceScope=PROTOTYPE and ServiceFactory implementation would required much more work, and a full working SCR component registry which is able to manage multiple service instances per service factory registrattion. in this ticket, we remove some misplaced code around the existing ServiceFactory implementation without improving it: some code around this handling got duplicated, and would do harm it it would be executed the intended way. was: since SING-5090 we have a very simplified ServiceFactory support, which is not really implemented correctly but it seemed to fulfill the need of some unit tests. having a proper serviceScope=PROTOTYPE and ServiceFactory implementation would required much more work, and a full working SCR component registry which is able to manage multiple service instances per service factory registrattion. in this ticket, we remove some misplaced code around the existing ServiceFactory implementation without improving it: some code around this handling got duplicated, and would do harm it it would be executed the intended way. > osgi-mock: Remove duplicate handling of ServiceFactory implementation > - > > Key: SLING-10975 > URL: https://issues.apache.org/jira/browse/SLING-10975 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing OSGi Mock 3.2.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Minor > Fix For: Testing OSGi Mock 3.2.2 > > > since SLING-5090 we have a very simplified ServiceFactory support, which is > not really implemented correctly but it seemed to fulfill the need of some > unit tests. having a proper serviceScope=PROTOTYPE and ServiceFactory > implementation would required much more work, and a full working SCR > component registry which is able to manage multiple service instances per > service factory registrattion. > in this ticket, we remove some misplaced code around the existing > ServiceFactory implementation without improving it: some code around this > handling got duplicated, and would do harm it it would be executed the > intended way. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-10975) osgi-mock: Remove duplicate handling of ServiceFactory implementation
Stefan Seifert created SLING-10975: -- Summary: osgi-mock: Remove duplicate handling of ServiceFactory implementation Key: SLING-10975 URL: https://issues.apache.org/jira/browse/SLING-10975 Project: Sling Issue Type: Bug Components: Testing Affects Versions: Testing OSGi Mock 3.2.0 Reporter: Stefan Seifert Assignee: Stefan Seifert Fix For: Testing OSGi Mock 3.2.2 since SING-5090 we have a very simplified ServiceFactory support, which is not really implemented correctly but it seemed to fulfill the need of some unit tests. having a proper serviceScope=PROTOTYPE and ServiceFactory implementation would required much more work, and a full working SCR component registry which is able to manage multiple service instances per service factory registrattion. in this ticket, we remove some misplaced code around the existing ServiceFactory implementation without improving it: some code around this handling got duplicated, and would do harm it it would be executed the intended way. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-10974) testing clients - replace org.codehaus.jackson with com.fasterxml.jackson.core
Andrei Dulvac created SLING-10974:
-
Summary: testing clients - replace org.codehaus.jackson with
com.fasterxml.jackson.core
Key: SLING-10974
URL: https://issues.apache.org/jira/browse/SLING-10974
Project: Sling
Issue Type: Improvement
Components: Apache Sling Testing Clients
Affects Versions: Apache Sling Testing Clients 2.0.12
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
Fix For: Apache Sling Testing Clients 2.0.14
Replace {{org.codehaus.jackson}} with the latest {{com.fasterxml.jackson.core}}
in the sling testing clients.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
Re: [VOTE] Release Apache Sling Models API 1.4.0, Models Implementation 1.5.0, Models Jackson Exporter 1.1.0, Models Validation Impl 1.1.0
+1 Le mar. 7 déc. 2021 à 11:01, Carsten Ziegeler a écrit : > +1 > > Carsten > > Am 07.12.2021 um 09:38 schrieb Stefan Seifert: > > Hi, > > > > Models API 1.4.0 (2 issues) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12344415 > > > > Models Implementation 1.5.0 (8 issues) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12349292 > > > > Models Jackson Exporter 1.1.0 (5 issues) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12341410 > > > > Models Validation Impl 1.1.0 (1 issue) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12348377 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2556/ > > > > You can use this UNIX script to download the release and verify the > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2556 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > stefan > > > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
Re: [VOTE] Release Apache Sling Context-Aware Configuration Mock Plugin 1.3.6
+1 Le mar. 7 déc. 2021 à 11:36, Konrad Windszus a écrit : > +1 > > Konrad >
Re: [VOTE] Sling Mock Oak 3.1.2-1.40.0
+1 Le mar. 7 déc. 2021 à 11:45, Stefan Seifert a écrit : > +1 > > stefan >
[jira] [Resolved] (SLING-10973) osgi-mock: Generate Service Registration and Bundle IDs in a thread-safe way
[ https://issues.apache.org/jira/browse/SLING-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-10973. Resolution: Fixed https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/commit/3145203868e4e53381e4a7c93e7a63bc7620d69e > osgi-mock: Generate Service Registration and Bundle IDs in a thread-safe way > > > Key: SLING-10973 > URL: https://issues.apache.org/jira/browse/SLING-10973 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing OSGi Mock 3.2.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing OSGi Mock 3.2.2 > > > after a lot of debugging around a racing conditions which leads to services > that are registered but not found afterwards in context of > https://wcm-io.atlassian.net/browse/WTES-69 if found an actually issue in the > way internal IDs for service registrations and bundle IDs are generated: an > integer field with ++ used. > osgi-mock is doing everything (except sending OSGi events) in a synchronous > way. but if the actual code that is tested is using multiple threads, this > can become a threading issue. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-10973) osgi-mock: Generate Service Registration and Bundle IDs in a thread-safe way
Stefan Seifert created SLING-10973: -- Summary: osgi-mock: Generate Service Registration and Bundle IDs in a thread-safe way Key: SLING-10973 URL: https://issues.apache.org/jira/browse/SLING-10973 Project: Sling Issue Type: Bug Components: Testing Affects Versions: Testing OSGi Mock 3.2.0 Reporter: Stefan Seifert Assignee: Stefan Seifert Fix For: Testing OSGi Mock 3.2.2 after a lot of debugging around a racing conditions which leads to services that are registered but not found afterwards in context of https://wcm-io.atlassian.net/browse/WTES-69 if found an actually issue in the way internal IDs for service registrations and bundle IDs are generated: an integer field with ++ used. osgi-mock is doing everything (except sending OSGi events) in a synchronous way. but if the actual code that is tested is using multiple threads, this can become a threading issue. -- This message was sent by Atlassian Jira (v8.20.1#820001)
RE: [VOTE] Sling Mock Oak 3.1.2-1.40.0
+1 stefan
Re: [VOTE] Release Apache Sling Context-Aware Configuration Mock Plugin 1.3.6
+1 Konrad
Re: [VOTE] Sling Mock Oak 3.1.2-1.40.0
+1 Carsten Am 07.12.2021 um 11:31 schrieb Konrad Windszus: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/projects/SLING/versions/12350892 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2558/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2558 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE] Sling Mock Oak 3.1.2-1.40.0
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/projects/SLING/versions/12350892 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2558/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2558 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
Re: [VOTE] Release Apache Sling Context-Aware Configuration Mock Plugin 1.3.6
+1 Carsten Am 07.12.2021 um 09:55 schrieb Stefan Seifert: Hi, Context-Aware Configuration Mock Plugin 1.3.6 (1 issue) https://issues.apache.org/jira/browse/SLING/fixforversion/12350893 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2557/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2557 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Models API 1.4.0, Models Implementation 1.5.0, Models Jackson Exporter 1.1.0, Models Validation Impl 1.1.0
+1 Carsten Am 07.12.2021 um 09:38 schrieb Stefan Seifert: Hi, Models API 1.4.0 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12344415 Models Implementation 1.5.0 (8 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12349292 Models Jackson Exporter 1.1.0 (5 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12341410 Models Validation Impl 1.1.0 (1 issue) https://issues.apache.org/jira/browse/SLING/fixforversion/12348377 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2556/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2556 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Models API 1.4.0, Models Implementation 1.5.0, Models Jackson Exporter 1.1.0, Models Validation Impl 1.1.0
+1 Thanks, Konrad > On 7. Dec 2021, at 09:38, Stefan Seifert > wrote: > > Hi, > > Models API 1.4.0 (2 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12344415 > > Models Implementation 1.5.0 (8 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12349292 > > Models Jackson Exporter 1.1.0 (5 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12341410 > > Models Validation Impl 1.1.0 (1 issue) > https://issues.apache.org/jira/browse/SLING/fixforversion/12348377 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2556/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2556 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan
Re: Proposal: Recommend mechanism for launching the feature-model based Starter
Hi, On Fri, Dec 3, 2021 at 4:55 PM Robert Munteanu wrote: > ...In the context of the upcoming Sling 12 launch we should settle on a > recommended mechanism for launching the Sling Starter... I don't remember us discussing jbang but it might be a good alternative. As a demo I have setup a stub startup script [1] which you can call with jbang start@apache/sling-whiteboard -p 1234 After installing jbang if needed from [2], without even requiring a JVM to be preinstalled. The right JVM version can be selected by the script [5]. Another example [3] parses a repoinit script after downloading the required dependencies listed in the script with //DEPS : echo "create path /itworks" | jbang repoinitValidator@apache/sling-whiteboard The mapping between those jbang commands and the scripts happens via a jbang catalog JSON file at [4]. I think this would be a nice way of creating the necessary glue to start Sling from scratch, and the instructions fit in a tweet which I like a lot ;-) We'd probably create a specific repository for those scripts, so the above commands would use sling-start instead of sling-whiteboard. -Bertrand [1] https://github.com/apache/sling-whiteboard/blob/master/start.java [2] https://www.jbang.dev/download/ [3] https://github.com/apache/sling-whiteboard/blob/master/jbang/RepoinitValidator.java [4] https://github.com/apache/sling-whiteboard/blob/master/jbang-catalog.json [5] https://www.jbang.dev/documentation/guide/latest/javaversions.html
[jira] [Updated] (SLING-10972) Testing Sling Mock Oak: Shade (embed and relocate) Guava
[ https://issues.apache.org/jira/browse/SLING-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10972: Description: All Oak bundles are already shaded in [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/blob/4f738b2cb2e493c9dc45d0e0f0350705ac548062/pom.xml#L170-L196.] This doesn't include the transitive dependency Guava which must be version 15 as Guava is not 100% backwards compatible (see https://issues.apache.org/jira/browse/OAK-7182). In some cases custom bundles shade/embed newer Guava classes without exporting those (e.g. [https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/77104988d6971e7d43aa973f859bcdf5a9596f25/bundle/pom.xml#L288]). As this currently prevents executing test with Sling Mock Oak, the Guava dependency should be shaded as well in sling-mock-oak. That way one can use Guava 15 (the shaded version from Sling Mock Oak) for testing, while the same bundle can still embed/shade a newer version. Class duplications are prevented as the shaded version in Sling Mock Oak is relocated. was: All Oak bundles are already shaded in [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/blob/4f738b2cb2e493c9dc45d0e0f0350705ac548062/pom.xml#L170-L196.] This doesn't include the transitive dependency Guava which must be version 15 as Guava is not 100% backwards compatible (see https://issues.apache.org/jira/browse/OAK-7182). In some cases custom bundles shade/embed newer Guava classes without exporting those (e.g. [https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/77104988d6971e7d43aa973f859bcdf5a9596f25/bundle/pom.xml#L288]). As this currently prevents executing test with Sling Mock Oak, the Guava dependency should be shaded as well in sling-mock-oak. That way one can use Guava 15 (the shaded version from Sling Mock Oak) for testing, while the same bundle can still embed/shade a newer version (by including it as dependency after sling-mock-oak) to use it at run time. > Testing Sling Mock Oak: Shade (embed and relocate) Guava > > > Key: SLING-10972 > URL: https://issues.apache.org/jira/browse/SLING-10972 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock Oak 3.1.0-1.40.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Testing Sling Mock Oak 3.1.2-1.40.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > All Oak bundles are already shaded in > [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/blob/4f738b2cb2e493c9dc45d0e0f0350705ac548062/pom.xml#L170-L196.] > This doesn't include the transitive dependency Guava which must be version 15 > as Guava is not 100% backwards compatible (see > https://issues.apache.org/jira/browse/OAK-7182). In some cases custom bundles > shade/embed newer Guava classes without exporting those (e.g. > [https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/77104988d6971e7d43aa973f859bcdf5a9596f25/bundle/pom.xml#L288]). > As this currently prevents executing test with Sling Mock Oak, the Guava > dependency should be shaded as well in sling-mock-oak. > That way one can use Guava 15 (the shaded version from Sling Mock Oak) for > testing, while the same bundle can still embed/shade a newer version. Class > duplications are prevented as the shaded version in Sling Mock Oak is > relocated. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10972) Testing Sling Mock Oak: Shade (embed and relocate) Guava
[ https://issues.apache.org/jira/browse/SLING-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10972: Summary: Testing Sling Mock Oak: Shade (embed and relocate) Guava (was: Testing Sling Mock Oak: Shade Guava) > Testing Sling Mock Oak: Shade (embed and relocate) Guava > > > Key: SLING-10972 > URL: https://issues.apache.org/jira/browse/SLING-10972 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock Oak 3.1.0-1.40.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Testing Sling Mock Oak 3.1.2-1.40.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > All Oak bundles are already shaded in > [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/blob/4f738b2cb2e493c9dc45d0e0f0350705ac548062/pom.xml#L170-L196.] > This doesn't include the transitive dependency Guava which must be version 15 > as Guava is not 100% backwards compatible (see > https://issues.apache.org/jira/browse/OAK-7182). In some cases custom bundles > shade/embed newer Guava classes without exporting those (e.g. > [https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/77104988d6971e7d43aa973f859bcdf5a9596f25/bundle/pom.xml#L288]). > As this currently prevents executing test with Sling Mock Oak, the Guava > dependency should be shaded as well in sling-mock-oak. > That way one can use Guava 15 (the shaded version from Sling Mock Oak) for > testing, while the same bundle can still embed/shade a newer version (by > including it as dependency after sling-mock-oak) to use it at run time. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-10972) Testing Sling Mock Oak: Shade Guava
[ https://issues.apache.org/jira/browse/SLING-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10972. - Fix Version/s: Testing Sling Mock Oak 3.1.2-1.40.0 Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/02dc583452ba5841d479233ca158eddf9fa417bd > Testing Sling Mock Oak: Shade Guava > --- > > Key: SLING-10972 > URL: https://issues.apache.org/jira/browse/SLING-10972 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock Oak 3.1.0-1.40.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Testing Sling Mock Oak 3.1.2-1.40.0 > > Time Spent: 1h > Remaining Estimate: 0h > > All Oak bundles are already shaded in > [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/blob/4f738b2cb2e493c9dc45d0e0f0350705ac548062/pom.xml#L170-L196.] > This doesn't include the transitive dependency Guava which must be version 15 > as Guava is not 100% backwards compatible (see > https://issues.apache.org/jira/browse/OAK-7182). In some cases custom bundles > shade/embed newer Guava classes without exporting those (e.g. > [https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/77104988d6971e7d43aa973f859bcdf5a9596f25/bundle/pom.xml#L288]). > As this currently prevents executing test with Sling Mock Oak, the Guava > dependency should be shaded as well in sling-mock-oak. > That way one can use Guava 15 (the shaded version from Sling Mock Oak) for > testing, while the same bundle can still embed/shade a newer version (by > including it as dependency after sling-mock-oak) to use it at run time. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-testing-sling-mock-oak] kwin merged pull request #5: SLING-10972 shade and relocate Guava
kwin merged pull request #5: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
RE: [VOTE] Release Apache Sling Models API 1.4.0, Models Implementation 1.5.0, Models Jackson Exporter 1.1.0, Models Validation Impl 1.1.0
+1 stefan
RE: [VOTE] Release Apache Sling Context-Aware Configuration Mock Plugin 1.3.6
+1 stefan
[VOTE] Release Apache Sling Context-Aware Configuration Mock Plugin 1.3.6
Hi, Context-Aware Configuration Mock Plugin 1.3.6 (1 issue) https://issues.apache.org/jira/browse/SLING/fixforversion/12350893 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2557/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2557 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan
[jira] [Resolved] (SLING-10945) Add metrics to Sling ResourceResolver
[ https://issues.apache.org/jira/browse/SLING-10945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-10945. --- Resolution: Fixed PR is merged > Add metrics to Sling ResourceResolver > - > > Key: SLING-10945 > URL: https://issues.apache.org/jira/browse/SLING-10945 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Resource Resolver 1.8.2 > > Time Spent: 5h 50m > Remaining Estimate: 0h > > Currently the Sling ResourceResolver (bundle) does not expose any metrics, > but from an operational point of view it would be good if at least some basic > metrics could get exposed. > I would like to start with > # number of VanityPaths > # number of aliases > # number of unclosed ResourceResolvers > 1 + 2 are important to determine if the instance might be affected by the > limits of JCR queries, while the third can help to understand quickly if a > memory issue can be caused by leaking ResourceResolvers (with potentially > embedded JCR sessions). > This requires to add a dependency to the Sling Metrics bundle. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10945) Add metrics to Sling ResourceResolver
[ https://issues.apache.org/jira/browse/SLING-10945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-10945: -- Fix Version/s: Resource Resolver 1.8.2 > Add metrics to Sling ResourceResolver > - > > Key: SLING-10945 > URL: https://issues.apache.org/jira/browse/SLING-10945 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Resource Resolver 1.8.2 > > Time Spent: 5h 50m > Remaining Estimate: 0h > > Currently the Sling ResourceResolver (bundle) does not expose any metrics, > but from an operational point of view it would be good if at least some basic > metrics could get exposed. > I would like to start with > # number of VanityPaths > # number of aliases > # number of unclosed ResourceResolvers > 1 + 2 are important to determine if the instance might be affected by the > limits of JCR queries, while the third can help to understand quickly if a > memory issue can be caused by leaking ResourceResolvers (with potentially > embedded JCR sessions). > This requires to add a dependency to the Sling Metrics bundle. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[VOTE] Release Apache Sling Models API 1.4.0, Models Implementation 1.5.0, Models Jackson Exporter 1.1.0, Models Validation Impl 1.1.0
Hi, Models API 1.4.0 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12344415 Models Implementation 1.5.0 (8 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12349292 Models Jackson Exporter 1.1.0 (5 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12341410 Models Validation Impl 1.1.0 (1 issue) https://issues.apache.org/jira/browse/SLING/fixforversion/12348377 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2556/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2556 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan
[GitHub] [sling-org-apache-sling-testing-sling-mock-oak] sonarcloud[bot] removed a comment on pull request #5: SLING-10972 shade and relocate Guava
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5#issuecomment-987665269 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-sling-mock-oak] sonarcloud[bot] commented on pull request #5: SLING-10972 shade and relocate Guava
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5#issuecomment-987686528 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh commented on pull request #53: SLING-10945 add metrics
joerghoh commented on pull request #53: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-987685688 Thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10945) Add metrics to Sling ResourceResolver
[ https://issues.apache.org/jira/browse/SLING-10945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454465#comment-17454465 ] Joerg Hoh commented on SLING-10945: --- The ResourceResolverMetrics service is an optional dependency now; if you don't have Sling Commons Metrics deployed, you won't get these metrics. > Add metrics to Sling ResourceResolver > - > > Key: SLING-10945 > URL: https://issues.apache.org/jira/browse/SLING-10945 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Time Spent: 5h 40m > Remaining Estimate: 0h > > Currently the Sling ResourceResolver (bundle) does not expose any metrics, > but from an operational point of view it would be good if at least some basic > metrics could get exposed. > I would like to start with > # number of VanityPaths > # number of aliases > # number of unclosed ResourceResolvers > 1 + 2 are important to determine if the instance might be affected by the > limits of JCR queries, while the third can help to understand quickly if a > memory issue can be caused by leaking ResourceResolvers (with potentially > embedded JCR sessions). > This requires to add a dependency to the Sling Metrics bundle. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10945) Add metrics to Sling ResourceResolver
[ https://issues.apache.org/jira/browse/SLING-10945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-10945: -- Fix Version/s: (was: Resource Resolver 1.8.0) > Add metrics to Sling ResourceResolver > - > > Key: SLING-10945 > URL: https://issues.apache.org/jira/browse/SLING-10945 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Time Spent: 5h 40m > Remaining Estimate: 0h > > Currently the Sling ResourceResolver (bundle) does not expose any metrics, > but from an operational point of view it would be good if at least some basic > metrics could get exposed. > I would like to start with > # number of VanityPaths > # number of aliases > # number of unclosed ResourceResolvers > 1 + 2 are important to determine if the instance might be affected by the > limits of JCR queries, while the third can help to understand quickly if a > memory issue can be caused by leaking ResourceResolvers (with potentially > embedded JCR sessions). > This requires to add a dependency to the Sling Metrics bundle. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-testing-sling-mock-oak] kwin commented on a change in pull request #5: SLING-10972 shade Guava
kwin commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5#discussion_r763743396 ## File path: pom.xml ## @@ -181,6 +181,7 @@ org.apache.jackrabbit:* +com.google.guava:* Review comment: Relocation does work (as long as the embedded Oak version is used). I therefore relocated in https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5/commits/bdf07b00070b71c5eb2d3a23aa7302300df173ab. That way the order of the class path does not matter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-10945) Add metrics to Sling ResourceResolver
[ https://issues.apache.org/jira/browse/SLING-10945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-10945: -- Fix Version/s: Resource Resolver 1.8.0 > Add metrics to Sling ResourceResolver > - > > Key: SLING-10945 > URL: https://issues.apache.org/jira/browse/SLING-10945 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Resource Resolver 1.8.0 > > Time Spent: 5h 40m > Remaining Estimate: 0h > > Currently the Sling ResourceResolver (bundle) does not expose any metrics, > but from an operational point of view it would be good if at least some basic > metrics could get exposed. > I would like to start with > # number of VanityPaths > # number of aliases > # number of unclosed ResourceResolvers > 1 + 2 are important to determine if the instance might be affected by the > limits of JCR queries, while the third can help to understand quickly if a > memory issue can be caused by leaking ResourceResolvers (with potentially > embedded JCR sessions). > This requires to add a dependency to the Sling Metrics bundle. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh merged pull request #53: SLING-10945 add metrics
joerghoh merged pull request #53: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-sling-mock-oak] stefanseifert commented on a change in pull request #5: SLING-10972 shade Guava
stefanseifert commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5#discussion_r763737562 ## File path: pom.xml ## @@ -181,6 +181,7 @@ org.apache.jackrabbit:* +com.google.guava:* Review comment: oh - relocating does not work because it's references not from our code here but from jackrabbit oak itself. does it then help at all including it without relocating? ## File path: pom.xml ## @@ -181,6 +181,7 @@ org.apache.jackrabbit:* +com.google.guava:* Review comment: oh - relocating does not work because it's referenced not from our code here but from jackrabbit oak itself. does it then help at all including it without relocating? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-sling-mock-oak] stefanseifert commented on a change in pull request #5: SLING-10972 shade Guava
stefanseifert commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5#discussion_r763737113 ## File path: pom.xml ## @@ -181,6 +181,7 @@ org.apache.jackrabbit:* +com.google.guava:* Review comment: i think we have to relocate it as well to really make sure there are no classpath issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-9793) Jackson exporter alphabetical sorting
[ https://issues.apache.org/jira/browse/SLING-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-9793: -- Issue Type: New Feature (was: Improvement) > Jackson exporter alphabetical sorting > - > > Key: SLING-9793 > URL: https://issues.apache.org/jira/browse/SLING-9793 > Project: Sling > Issue Type: New Feature > Components: Sling Models >Reporter: Jasper Simon >Assignee: Stefan Seifert >Priority: Major > Fix For: Models Jackson Exporter 1.1.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > It would be nice to have JSON properties sorted alphabetically by default > when using the jackson exporter. > If that is not possible, an OSGi configuration for the jackson exporter where > you can define the default behaviour of the jackson exporter for your > project.(org.apache.sling.models.jacksonexporter.impl.JacksonExporter) > Now we need to add the sorting option for every exported class, while it > would be beneficial to have this configured project-wide. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-testing-sling-mock-oak] sonarcloud[bot] commented on pull request #5: SLING-10972 shade Guava
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5#issuecomment-987665269 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=5=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
