[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


enapps-enorman commented on PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171858959

   > @enapps-enorman I used your suggestions but that requires the output to 
have quotes when it contains special character like the hashtag 
(RegisterNamespace (foo2) "uri:some-uri/V/1.1/test#") - I hope that works
   
   I think that is because you have a change in 
RegisterNamespace#getParametersDescription that I did not have.  To be honest, 
I'm not sure if quotes or no-quotes is correct in the "toString" output.  It 
looked to me that other places were not using quotes in the "toString" output 
for their quotable strings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


sonarcloud[bot] commented on PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171838566

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-repoinit-parser=24)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=24=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=24=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=24=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=24=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=24=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=24=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=24=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=24=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=24=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=24=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=24=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=24=false=CODE_SMELL)
   
   
[![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png
 
'100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=24=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=24=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=24=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=24=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


schaefa commented on PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171837314

   @enapps-enorman I used your suggestions but that requires the output to have 
quotes when it contains special character like the hashtag (RegisterNamespace 
(foo2) "uri:some-uri/V/1.1/test#") - I hope that works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10740) Repoinit create path statement fails for node types with a mandatory property

2022-06-30 Thread Eric Norman (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman resolved SLING-10740.
-
Resolution: Fixed

Merged PR #27 at: 
[{{d9d50ab}}|https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/d9d50ab951814733fb44cff5427077c335f08349]

> Repoinit create path statement fails for node types with a mandatory property
> -
>
> Key: SLING-10740
> URL: https://issues.apache.org/jira/browse/SLING-10740
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Repoinit Parser 1.6.16, Repoinit JCR 1.1.40
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> The processing of the "create path" statement calls save() at the end which 
> will cause a constraint violation if the nodetype of the created path 
> contains any properties that are declared as mandatory (and not autocreated). 
>  No processing of "set properties" statements happens before the save() call 
> in AclVisitor#visitCreatePath so it does not seem to be possible to define 
> any mandatory properties using the current repoinit grammar.
> I could see this solved in a couple ways:
>  # The AclVisitor#visitCreatePath could possibly pre-process any "set 
> properties" statements that are applicable to the created path before calling 
> save and then skip those same items when NodePropertiesVisitor visits the 
> same.
>  # Or, the "create path" grammar could be extended to allow defining 
> properties to be set at the same time as the create (with a syntax that is 
> similar to the "set properties" statement?)
>  # Or, perhaps calling save in AclVisitor#visitCreatePath is not necessary?  
> I'm not sure of the historical reasons why save() is done there.
>  # Or, maybe something else I haven't thought of
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [sling-org-apache-sling-jcr-repoinit] enapps-enorman merged pull request #27: SLING-10740 implemention for create path with properties

2022-06-30 Thread GitBox 


enapps-enorman merged PR #27:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/27


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-11431) Cleanup compiler and sonar warnings

2022-06-30 Thread Eric Norman (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman resolved SLING-11431.
-
Resolution: Fixed

Merged PR #20 at:  
[{{4bcf2fd}}|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/4bcf2fdc941029e03470837030cf0cf88a01083d]

The eclipse project now shows 0 java problems and 42 problems reported by 
sonarlint.

> Cleanup compiler and sonar warnings
> ---
>
> Key: SLING-11431
> URL: https://issues.apache.org/jira/browse/SLING-11431
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Scripting Core 2.4.10
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When opening the o.a.sling.scripting.core project in eclipse it shows 88 
> warnings about java problems and 165 problems reported by sonarlint.
> Expected:
> Resolve as many of these as possible to reduce the noise so any new problems 
> will be easier to see.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


enapps-enorman commented on PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171766851

   > I did that but now the test fails because the hashtag went missing
   
   @schaefa  Take a look at the what I stashed in my fork at: 
https://github.com/enapps-enorman/sling-org-apache-sling-repoinit-parser/commit/6d8a5401468d4965cc1726236dd7dac206df7cbc
 to see if that works for you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


schaefa commented on PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171763417

   I did that but now the test fails because the hashtag went missing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on a diff in pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


enapps-enorman commented on code in PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#discussion_r911494123


##
src/test/resources/testcases/test-40-output.txt:
##
@@ -1,3 +1,3 @@
 RegisterNamespace (foo) uri:some-uri/V/1.0
 RegisterNamespace (prefix_with-other.things) andSimpleURI
-RegisterNamespace (foo2) uri:some-uri/V/1.1/test#
+RegisterNamespace (foo2) uri:some-uri/V/1.1/test#

Review Comment:
   ~~The URI should be wrapped with quotes here in the output~~
   
   Correction, this should not be wrapped in quotes as this is the output from 
RegisterNamespace#toString and not the output from 
RegisterNamespace#asRepoInitString



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on a diff in pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


enapps-enorman commented on code in PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#discussion_r911494123


##
src/test/resources/testcases/test-40-output.txt:
##
@@ -1,3 +1,3 @@
 RegisterNamespace (foo) uri:some-uri/V/1.0
 RegisterNamespace (prefix_with-other.things) andSimpleURI
-RegisterNamespace (foo2) uri:some-uri/V/1.1/test#
+RegisterNamespace (foo2) uri:some-uri/V/1.1/test#

Review Comment:
   ~~The URI should be wrapped with quotes here in the output~~
   
   Correction, this should not be wrapped in quotes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on a diff in pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


enapps-enorman commented on code in PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#discussion_r911494123


##
src/test/resources/testcases/test-40-output.txt:
##
@@ -1,3 +1,3 @@
 RegisterNamespace (foo) uri:some-uri/V/1.0
 RegisterNamespace (prefix_with-other.things) andSimpleURI
-RegisterNamespace (foo2) uri:some-uri/V/1.1/test#
+RegisterNamespace (foo2) uri:some-uri/V/1.1/test#

Review Comment:
   The URI should be wrapped with quotes here in the output



##
src/test/resources/testcases/test-40.txt:
##
@@ -3,4 +3,4 @@
 # and o.a.s.jcr.repoinit 1.0.2
 register namespace (foo) uri:some-uri/V/1.0
 register namespace ( prefix_with-other.things ) andSimpleURI
-register namespace (foo2) uri:some-uri/V/1.1/test\#
\ No newline at end of file
+register namespace (foo2) "uri:some-uri/V/1.1/test\\#"

Review Comment:
   Should not need to escape the hash character here since the quotableString() 
doesn't need it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


schaefa commented on PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171744468

   I updated the code to showcase the issue. I tried multiple things:
   \#: fails the repo init parser test
   \\#: fails the repo init parser test
   #: fails the output and repo init parser test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-core] enapps-enorman merged pull request #20: SLING-11431 cleanup many compiler and sonar warnings

2022-06-30 Thread GitBox 


enapps-enorman merged PR #20:
URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-11431) Cleanup compiler and sonar warnings

2022-06-30 Thread Eric Norman (Jira) 
Eric Norman created SLING-11431:
---

 Summary: Cleanup compiler and sonar warnings
 Key: SLING-11431
 URL: https://issues.apache.org/jira/browse/SLING-11431
 Project: Sling
  Issue Type: Improvement
Reporter: Eric Norman
Assignee: Eric Norman
 Fix For: Scripting Core 2.4.10


When opening the o.a.sling.scripting.core project in eclipse it shows 88 
warnings about java problems and 165 problems reported by sonarlint.

Expected:

Resolve as many of these as possible to reduce the noise so any new problems 
will be easier to see.

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


schaefa commented on PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171735204

   I tried that but I could not get the '#' in. Either it is ignored or I have 
'\#'. The quotedString() is not converting an escaped backslash. Even when I 
fix the conversion in the RegisterNamespace operation class I get a 
RepIniParsingException because it does not like the '\#' or '\\#'.
   Any suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #86: Bump jsdom from 16.2.2 to 16.7.0 in /slingpost

2022-06-30 Thread GitBox 


sonarcloud[bot] commented on PR #86:
URL: https://github.com/apache/sling-whiteboard/pull/86#issuecomment-1171565959

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-whiteboard=86)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=86=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=86=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=86=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=86=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=86=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=86=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=86=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=86=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=86=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=86=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=86=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=86=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=86=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=86=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #82: Bump async from 2.6.3 to 2.6.4 in /slingpost

2022-06-30 Thread GitBox 


sonarcloud[bot] commented on PR #82:
URL: https://github.com/apache/sling-whiteboard/pull/82#issuecomment-1171565544

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-whiteboard=82)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=82=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=82=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=82=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=82=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=82=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=82=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=82=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=82=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=82=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=82=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=82=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=82=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=82=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=82=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2022-06-30 Thread GitBox 


sonarcloud[bot] commented on PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1171508344

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests=1)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Repo-Init: register Namespace with a trailing hashtag (#)

2022-06-30 Thread Andreas Schaefer 
I created a simple solution to allow for a hashtag inside the URI with:

register namespace (foo2) http://test.com/v/1.0\# 

The PR link is: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24 


- Andy



> On Jun 29, 2022, at 10:26 AM, Andreas Schaefer  
> wrote:
> 
> I created a ticket for it: https://issues.apache.org/jira/browse/SLING-11427 
> 
> 
> - Andy
> 
>> On Jun 28, 2022, at 1:46 PM, Eric Norman  wrote:
>> 
>> Hi Andy,
>> 
>> I agree that it looks like the grammar for parsing the namespace value is
>> too strict.  It should accept any string that is a valid URI.
>> 
>> Can you open up a bug report with your findings?
>> 
>> If you need a temporary workaround, you may also register a namespace using
>> the "register nodetypes" instruction with CND syntax that looks something
>> like this:
>> 
>> register nodetypes
>> <<===
>>   http://ns.adobe.com/xap/1.0/sType/Dimensions#'>
>> ===>>
>> 
>> 
>> Regards,
>> -Eric
>> 
>> 
>> On Mon, Jun 27, 2022 at 4:43 PM Andreas Schaefer 
>> wrote:
>> 
>>> Hi
>>> 
>>> I wanted to register namespaces with the Repo-Init and it works except for
>>> namespaces with a trailing hashtag like:
>>> 
>>> "register namespace (stDim) http://ns.adobe.com/xap/1.0/sType/Dimensions#
>>> ”,
>>> 
>>> Fails with:
>>> 
>>> 7.06.2022 16:12:41.019 *ERROR* [Apache Sling Repository Startup Thread #1]
>>> com.adobe.granite.repository.impl.SlingRepositoryManager Exception in a
>>> SlingRepositoryInitializer, SlingRepository service registration aborted
>>> org.apache.sling.repoinit.parser.RepoInitParsingException: Encountered ""
>>> at line 14, column 1._Was expecting one of:_
>>>   at
>>> org.apache.sling.repoinit.parser.impl.RepoInitParserService.parse(RepoInitParserService.java:45)
>>> [org.apache.sling.repoinit.parser:1.6.14]
>>>   at
>>> org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.processRepository(RepositoryInitializerFactory.java:127)
>>> [org.apache.sling.jcr.repoinit:1.1.39.T20220426093723-a4cd7db]
>>>   at
>>> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.executeRepositoryInitializers(AbstractSlingRepositoryManager.java:627)
>>> [org.apache.sling.jcr.base:3.1.10]
>>>   at
>>> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.initializeAndRegisterRepositoryService(AbstractSlingRepositoryManager.java:575)
>>> [org.apache.sling.jcr.base:3.1.10]
>>>   at
>>> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.access$300(AbstractSlingRepositoryManager.java:96)
>>> [org.apache.sling.jcr.base:3.1.10]
>>>   at
>>> org.apache.sling.jcr.base.AbstractSlingRepositoryManager$4.run(AbstractSlingRepositoryManager.java:544)
>>> [org.apache.sling.jcr.base:3.1.10]
>>> Caused by: org.apache.sling.repoinit.parser.impl.ParseException:
>>> Encountered "" at line 14, column 1._Was expecting one of:_
>>>   at
>>> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.generateParseException(RepoInitParserImpl.java:4888)
>>> [org.apache.sling.repoinit.parser:1.6.14]
>>>   at
>>> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.jj_consume_token(RepoInitParserImpl.java:4770)
>>> [org.apache.sling.repoinit.parser:1.6.14]
>>>   at
>>> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.registerNamespaceStatement(RepoInitParserImpl.java:1590)
>>> [org.apache.sling.repoinit.parser:1.6.14]
>>>   at
>>> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.parse(RepoInitParserImpl.java:69)
>>> [org.apache.sling.repoinit.parser:1.6.14]
>>>   at
>>> org.apache.sling.repoinit.parser.impl.RepoInitParserService.parse(RepoInitParserService.java:43)
>>> [org.apache.sling.repoinit.parser:1.6.14]
>>> 
>>> AEM has many of these namespaces registered out of the box so I should be
>>> able to add one of them.
>>> 
>>> I tried to escape it with \ but that did not work either.
>>> 
>>> - Andy
>

[jira] [Assigned] (SLING-11430) Do no longer generate full baseline report in case of failure

2022-06-30 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-11430:
---

Assignee: Konrad Windszus

> Do no longer generate full baseline report in case of failure
> -
>
> Key: SLING-11430
> URL: https://issues.apache.org/jira/browse/SLING-11430
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Bundle Parent 49
>
>
> The report being emitted by default has been improved in newer 
> bnd-baseline-maven-plugin versions, so the full report is no longer necessary 
> (and actually often way too massive to directly see the conflicting version). 
> It should no longer be enabled by default.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11430) Do no longer generate full baseline report in case of failure

2022-06-30 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-11430:

Description: The report being emitted by default has been improved in newer 
bnd-baseline-maven-plugin versions, so the full report is no longer necessary 
(and actually often way too massive to directly see the conflicting version). 
It should no longer be enabled by default.  (was: The report being emitted by 
default has been improved in newer bnd-baseline-maven-plugin version, so the 
full report is no longer necessary (and actually often way too massive to 
directly see the conflicting version).)

> Do no longer generate full baseline report in case of failure
> -
>
> Key: SLING-11430
> URL: https://issues.apache.org/jira/browse/SLING-11430
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Bundle Parent 49
>
>
> The report being emitted by default has been improved in newer 
> bnd-baseline-maven-plugin versions, so the full report is no longer necessary 
> (and actually often way too massive to directly see the conflicting version). 
> It should no longer be enabled by default.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11430) Do no longer generate full baseline report in case of failure

2022-06-30 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-11430.
-
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-parent/commit/2bbb339fb897425deb4239b4178a2a351d1ada89.

> Do no longer generate full baseline report in case of failure
> -
>
> Key: SLING-11430
> URL: https://issues.apache.org/jira/browse/SLING-11430
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Bundle Parent 49
>
>
> The report being emitted by default has been improved in newer 
> bnd-baseline-maven-plugin version, so the full report is no longer necessary 
> (and actually often way too massive to directly see the conflicting version).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11430) Do no longer generate full baseline report in case of failure

2022-06-30 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-11430:

Description: The report being emitted by default has been improved in newer 
bnd-baseline-maven-plugin version, so the full report is no longer necessary 
(and actually often way too massive to directly see the conflicting version).

> Do no longer generate full baseline report in case of failure
> -
>
> Key: SLING-11430
> URL: https://issues.apache.org/jira/browse/SLING-11430
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Bundle Parent 49
>
>
> The report being emitted by default has been improved in newer 
> bnd-baseline-maven-plugin version, so the full report is no longer necessary 
> (and actually often way too massive to directly see the conflicting version).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-11430) Do no longer generate full baseline report in case of failure

2022-06-30 Thread Konrad Windszus (Jira) 
Konrad Windszus created SLING-11430:
---

 Summary: Do no longer generate full baseline report in case of 
failure
 Key: SLING-11430
 URL: https://issues.apache.org/jira/browse/SLING-11430
 Project: Sling
  Issue Type: Improvement
  Components: General
Reporter: Konrad Windszus
 Fix For: Bundle Parent 49






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [sling-org-apache-sling-discovery-base] kwin commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox 


kwin commented on PR #7:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171471760

   I would recommend moving the impl classes to some non-exported impl packages 
and only ignore those during baselining for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

2022-06-30 Thread GitBox 


sonarcloud[bot] commented on PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1171458985

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-xing-oauth=2)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL)
   
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_coverage=list)
  
   
[![7.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10-16px.png
 
'7.3%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_duplicated_lines_density=list)
 [7.3% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-auth-xing-login] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

2022-06-30 Thread GitBox 


sonarcloud[bot] commented on PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1171459450

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-xing-login=2)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL)
 [6 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL)
   
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-discovery-base] kwin commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox 


kwin commented on PR #7:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171456991

   The major version bump is not necessary due to the annotation type change, 
but due to backwards incompatible changes in 
`org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistryImpl`
 and `org.apache.sling.discovery.base.connectors.ping.ConnectorRegistryImpl`.
   The report (not the full one, but only the one containing the actual 
conflicts) exposes this:
   
   ```
   [ERROR] * org.apache.sling.discovery.base.connectors.announcement PACKAGE
MAJOR  2.0.1  2.0.0  3.0.0  -
   [ERROR]   MAJORPACKAGE
org.apache.sling.discovery.base.connectors.announcement
   [ERROR] MAJOR  CLASS  
org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistryImpl
   [ERROR]   MICROMETHOD activate()
   [ERROR] REMOVEDANNOTATED  
org.apache.felix.scr.annotations.Activate
   [ERROR] ADDED  ANNOTATED  
org.osgi.service.component.annotations.Activate
   [ERROR]   REMOVED  METHOD 
bindConfig(org.apache.sling.discovery.base.connectors.BaseConfig)
   [ERROR] REMOVEDACCESS protected
   [ERROR] REMOVEDRETURN void
   [ERROR]   REMOVED  METHOD 
bindResourceResolverFactory(org.apache.sling.api.resource.ResourceResolverFactory)
   [ERROR] REMOVEDACCESS protected
   [ERROR] REMOVEDRETURN void
   [ERROR]   REMOVED  METHOD 
bindSettingsService(org.apache.sling.settings.SlingSettingsService)
   [ERROR] REMOVEDACCESS protected
   [ERROR] REMOVEDRETURN void
   [ERROR]   REMOVED  METHOD 
unbindConfig(org.apache.sling.discovery.base.connectors.BaseConfig)
   [ERROR] REMOVEDACCESS protected
   [ERROR] REMOVEDRETURN void
   [ERROR]   REMOVED  METHOD 
unbindResourceResolverFactory(org.apache.sling.api.resource.ResourceResolverFactory)
   [ERROR] REMOVEDACCESS protected
   [ERROR] REMOVEDRETURN void
   [ERROR]   REMOVED  METHOD 
unbindSettingsService(org.apache.sling.settings.SlingSettingsService)
   [ERROR] REMOVEDACCESS protected
   [ERROR] REMOVEDRETURN void
   [ERROR]   REMOVED  ANNOTATED  
org.apache.felix.scr.annotations.Component
   [ERROR]   REMOVED  ANNOTATED  
org.apache.felix.scr.annotations.Service
   [ERROR] REMOVEDPROPERTY   
value.0=org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistry
   [ERROR]   ADDEDANNOTATED  
org.osgi.service.component.annotations.Component
   [ERROR] ADDED  PROPERTY   
service.0=org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistry
   [ERROR] REMOVEDANNOTATED  aQute.bnd.annotation.Version
   [ERROR]   REMOVED  PROPERTY   value='2.0.0'
   [ERROR] ADDED  ANNOTATED  
org.osgi.annotation.versioning.Version
   [ERROR]   ADDEDPROPERTY   value='2.0.1'
   [ERROR] REMOVEDVERSION2.0.0
   [ERROR] ADDED  VERSION2.0.1
   [ERROR] * org.apache.sling.discovery.base.connectors.pingPACKAGE
MAJOR  1.0.1  1.0.0  2.0.0  -
   [ERROR]   MAJORPACKAGE
org.apache.sling.discovery.base.connectors.ping
   [ERROR] MAJOR  CLASS  
org.apache.sling.discovery.base.connectors.ping.ConnectorRegistryImpl
   [ERROR]   ADDEDMETHOD 
activate(org.osgi.framework.BundleContext)
   [ERROR] ADDED  ACCESS protected
   [ERROR] ADDED  ANNOTATED  
org.osgi.service.component.annotations.Activate
   [ERROR] ADDED  RETURN void
   [ERROR]   REMOVED  METHOD 
activate(org.osgi.service.component.ComponentContext)
   [ERROR] REMOVEDACCESS protected
   [ERROR] REMOVEDANNOTATED  
org.apache.felix.scr.annotations.Activate
   [ERROR] REMOVEDRETURN void
   [ERROR]   REMOVED  METHOD 
bindAnnouncementRegistry(org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistry)
   [ERROR] REMOVEDACCESS protected
   [ERROR] REMOVEDRETURN void
   [ERROR]   REMOVED  METHOD 
bindConfig(org.apache.sling.discovery.base.connectors.BaseConfig)
   [ERROR] REMOVEDACCESS protected
   [ERROR] REMOVEDRETURN void
   [ERROR]   MICROMETHOD deactivate()
   [ERROR] REMOVEDANNOTATED  
org.apache.felix.scr.annotations.Deactivate
   [ERROR] ADDED  ANNOTATED

[GitHub] [sling-org-apache-sling-discovery-base] sonarcloud[bot] commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox 


sonarcloud[bot] commented on PR #7:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171413600

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-base=7)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=7=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=7=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=7=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=7=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=7=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=7=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-base=7=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-base=7=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-base=7=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=7=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=7=false=CODE_SMELL)
 [6 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-base=7=false=CODE_SMELL)
   
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-base=7=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-base=7=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-base=7=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-base=7=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-discovery-base] ashokmca07 commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox 


ashokmca07 commented on PR #7:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171405183

   @kwin Unfortunately `bnd-baseline-maven-plugin` is still not happy after the 
micro(!) version bump. but to avoid major version bump, I set 
`bnd.baseline.continue.on.error` value to true and continued with minor 
versions increment. 
   
   FYI: @rombert @stefan-egli 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (SLING-11429) OSGi configs on same resource type cause IAE

2022-06-30 Thread Radu Cotescu (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-11429:


Assignee: Radu Cotescu

> OSGi configs on same resource type cause IAE
> 
>
> Key: SLING-11429
> URL: https://issues.apache.org/jira/browse/SLING-11429
> Project: Sling
>  Issue Type: Improvement
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.12
>Reporter: Stefan Grimm
>Assignee: Radu Cotescu
>Priority: Minor
>
> Currently, if we have more than one OSGi configuration for {{GraphQLServlet}} 
> registered on the same resource type, the {{activate}} method throws an 
> {{InvalidArgumentException}}.
> Stacktrace is:
> {noformat}
> org.apache.sling.graphql.core.servlet.GraphQLServlet bundle 
> org.apache.sling.graphql.core:0.0.12 
> (528)[org.apache.sling.graphql.core.servlet.GraphQLServlet(3271)] : The 
> activate method has thrown an exception (java.lang.IllegalArgumentException: 
> A metric named 
> org.apache.sling.graphql.core.servlet.GraphQLServlet.rt:graphql/sites/components/endpoint.m:GET_POST.e:json.cache_hit_rate
>  already exists)
> java.lang.IllegalArgumentException: A metric named 
> org.apache.sling.graphql.core.servlet.GraphQLServlet.rt:graphql/sites/components/endpoint.m:GET_POST.e:json.cache_hit_rate
>  already exists
>   at com.codahale.metrics.MetricRegistry.register(MetricRegistry.java:91)
>   at 
> org.apache.sling.graphql.core.servlet.GraphQLServlet.activate(GraphQLServlet.java:199)
> {noformat}
> Probably some additional data should be used on top of the resource type to 
> create the name for the metric(s). If that's not possible, it would at least 
> be great to handle this more gracefully (log a proper error message instead 
> of throwing an {{IllegalArgumentException}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-11429) OSGi configs on same resource type cause IAE

2022-06-30 Thread Stefan Grimm (Jira) 
Stefan Grimm created SLING-11429:


 Summary: OSGi configs on same resource type cause IAE
 Key: SLING-11429
 URL: https://issues.apache.org/jira/browse/SLING-11429
 Project: Sling
  Issue Type: Improvement
  Components: GraphQL
Affects Versions: GraphQL Core 0.0.12
Reporter: Stefan Grimm


Currently, if we have more than one OSGi configuration for {{GraphQLServlet}} 
registered on the same resource type, the {{activate}} method throws an 
{{InvalidArgumentException}}.

Stacktrace is:

{noformat}
org.apache.sling.graphql.core.servlet.GraphQLServlet bundle 
org.apache.sling.graphql.core:0.0.12 
(528)[org.apache.sling.graphql.core.servlet.GraphQLServlet(3271)] : The 
activate method has thrown an exception (java.lang.IllegalArgumentException: A 
metric named 
org.apache.sling.graphql.core.servlet.GraphQLServlet.rt:graphql/sites/components/endpoint.m:GET_POST.e:json.cache_hit_rate
 already exists)
java.lang.IllegalArgumentException: A metric named 
org.apache.sling.graphql.core.servlet.GraphQLServlet.rt:graphql/sites/components/endpoint.m:GET_POST.e:json.cache_hit_rate
 already exists
at com.codahale.metrics.MetricRegistry.register(MetricRegistry.java:91)
at 
org.apache.sling.graphql.core.servlet.GraphQLServlet.activate(GraphQLServlet.java:199)
{noformat}

Probably some additional data should be used on top of the resource type to 
create the name for the metric(s). If that's not possible, it would at least be 
great to handle this more gracefully (log a proper error message instead of 
throwing an {{IllegalArgumentException}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [sling-org-apache-sling-jcr-contentparser] ashokmca07 closed pull request #3: deprecated labels has been added

2022-06-30 Thread GitBox 


ashokmca07 closed pull request #3: deprecated labels has been added
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentparser/pull/3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-11417) Update parent bundle (48) to sling-installer-provider-installhook

2022-06-30 Thread Ashok Pelluru (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashok Pelluru resolved SLING-11417.
---
Resolution: Fixed

> Update parent bundle (48) to sling-installer-provider-installhook
> -
>
> Key: SLING-11417
> URL: https://issues.apache.org/jira/browse/SLING-11417
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ashok Pelluru
>Assignee: Ashok Pelluru
>Priority: Minor
> Fix For: Installer Vault Package Install Hook 1.1.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [sling-org-apache-sling-installer-provider-installhook] ashokmca07 merged pull request #3: SLING-11417: Upgrade to sling 48

2022-06-30 Thread GitBox 


ashokmca07 merged PR #3:
URL: 
https://github.com/apache/sling-org-apache-sling-installer-provider-installhook/pull/3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


bdelacretaz commented on PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171374356

   We already have a `quotableString()` production in the grammar, would it be 
an option to allow for quoting the namespace URI for such cases? The input 
would then be
   
   register namespace (foo2) "uri:some-uri/V/1.1/test#"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-maven-launchpad-plugin] dependabot[bot] opened a new pull request, #1: Bump plexus-archiver from 1.0-alpha-9 to 3.6.0

2022-06-30 Thread GitBox 


dependabot[bot] opened a new pull request, #1:
URL: https://github.com/apache/sling-maven-launchpad-plugin/pull/1

   Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) 
from 1.0-alpha-9 to 3.6.0.
   
   Release notes
   Sourced from https://github.com/codehaus-plexus/plexus-archiver/releases;>plexus-archiver's
 releases.
   
   Plexus Archiver 3.6.0 requires Java 7.
   :rocket: New features and improvements
   
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/84;>#84,
 https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/57;>#57
 - Added Archiver implementation (JarToolModularJarArchiver) that 
creates modular JAR files using the JDK jar tool. The implementation uses 
java.util.spi.ToolProvider introduced in Java 9, so if it is run 
on Java 7 or 8 the resulting archive will be identical to a one created by 
JarArchiver - the module descriptor is not going to be validated 
and no additional information (such as version, main class and packages) is 
going to be added.
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/67;>#67
 - Added ability to set the module version and main class of a modular JAR 
file
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/83;>#83
 - Added new protected method (postCreateArchive) to 
AbstractArchiver that is called after the archive is created 
successfully
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/87;>#87
 - of Levan Giguashvili (https://github.com/odinn1984;>@​odinn1984)  Snyk eng 
team to fix a possible security issue. (See https://gist.github.com/grnd/eafd7dab7c4cc6197d817a07fa46b2df;>https://gist.github.com/grnd/eafd7dab7c4cc6197d817a07fa46b2df)
   
   :bug: Bug Fixes
   
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/73;>#73
 - Symbolic links not properly encoded in ZIP archives
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/57;>#57
 - ZipArchiver creates archives with inconsistent central 
directory entries
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/79;>#79
 - JarArchiver and PlexusIoZipFileResourceCollection 
leak file descriptors
   
   :toolbox: Maintenance
   
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/77;>#77
 - Fixed the way unit tests modify the timestamp of a file
   
   :package: Dependency updates
   
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/71;>#71,
 https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/72;>#72,
 https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/76;>#76,
 https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/78;>#78,
 https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/85;>#85,
 https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/86;>#86
 - Updated dependencies: commons-compress to 1.16.1, 
plexus-utils to 3.1.0, org.tukaani:xz to 1.8 and 
plexus-io to 3.0.1
   
   Plexus Archiver 3.5 requires Java 7. Now Plexus Archiver uses pure Java 
implementations to deal with file attributes so the useJvmChmod is 
no longer used and it is just ignored. Archiver#setUseJvmChmod, 
Archiver#isUseJvmChmod(), UnArchiver#setUseJvmChmod, 
UnArchiver#isUseJvmChmod(), ArchiveEntryUtils#chmod( File, 
int, Logger, boolean ) and ArchiveEntryUtils#chmod( File, int, 
Logger ) are deprecated and are subject to removal in a future 
version.
   :rocket: New features and improvements
   
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/51;>#51
 - More specific exception for cases when there are no files to archive. Now 
EmptyArchiveException is thrown when you try to create empty 
archive. Previously the more generic ArchiverException was 
thrown.
   
   :bug: Bug Fixes
   
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/47;>#47
 - Archiver follows symlinks on Windows
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/53;>#53
 - AbstractZipArchiver no longer respects 
recompressAddedZips
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/58;>#58
 - Creates corrupt JARs
   
   :package: Dependency updates
   
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/56;>#56
 - Upgrade the minimum required Java version to 7 and Plexus IO to 3.0.0
   https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/60;>#60
 - Upgrade dependencies. plexus-container-default to 
1.0-alpha-30, commons-compress to 1.14, 
org.tukaani.xz to 1.6 and 
com.google.code.findbugs.jsr305 to 3.0.2
   
   Plexus Archiver 3.4.1
   :rocket: New features and improvements

[GitHub] [sling-org-apache-sling-discovery-base] kwin commented on a diff in pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox 


kwin commented on code in PR #7:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#discussion_r910947467


##
src/main/java/org/apache/sling/discovery/base/commons/package-info.java:
##
@@ -23,8 +23,7 @@
  *
  * @version 1.1.0
  */
-@Version("2.0.0")
+@Version("3.0.0")

Review Comment:
   Switching annotations (from Bnd to OSGi only requires a micro(!) version 
bump, i.e. 2.0.1 is totally fine.



##
src/main/java/org/apache/sling/discovery/base/connectors/announcement/package-info.java:
##
@@ -23,8 +23,7 @@
  *
  * @version 1.1.2
  */
-@Version("2.0.0")
+@Version("3.0.0")

Review Comment:
   Switching annotations (from Bnd to OSGi only requires a micro(!) version 
bump, i.e. 2.0.1 is totally fine.



##
src/main/java/org/apache/sling/discovery/base/connectors/ping/wl/package-info.java:
##
@@ -23,8 +23,7 @@
  *
  * @version 1.0.0
  */
-@Version("1.0.0")
+@Version("2.0.0")

Review Comment:
   Switching annotations (from Bnd to OSGi only requires a micro(!) version 
bump, i.e. 2.0.1 is totally fine.



##
src/main/java/org/apache/sling/discovery/base/connectors/ping/package-info.java:
##
@@ -23,8 +23,7 @@
  *
  * @version 1.0.0
  */
-@Version("1.0.0")
+@Version("2.0.0")
 package org.apache.sling.discovery.base.connectors.ping;
 
-import aQute.bnd.annotation.Version;
-
+import org.osgi.annotation.versioning.Version;

Review Comment:
   Switching annotations (from Bnd to OSGi only requires a micro(!) version 
bump, i.e. 2.0.1 is totally fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-discovery-base] ashokmca07 commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox 


ashokmca07 commented on PR #7:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171011270

   > * bump the versions, verify that the consuming Sling bundles ( other 
discovery bundles I assume ) still work, and update the consuming Sling bundles 
import ranges to work with both the new and the old versions
   
   @rombert all tests were green and other discovery modules work fine after 
bumping versions. verified using all discovery current snapshots into sling 
starter and integration tests as well. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-11425) Make URI filtering test more lenient in case of invalid XML input

2022-06-30 Thread Robert Munteanu (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-11425.
-
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-xss/pull/25 merged, thanks 
[~tvogel]!

> Make URI filtering test more lenient in case of invalid XML input
> -
>
> Key: SLING-11425
> URL: https://issues.apache.org/jira/browse/SLING-11425
> Project: Sling
>  Issue Type: Improvement
>  Components: XSS Protection API
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: XSS Protection API 2.2.22
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The AntiSamiPolicyTest validates URI filtering in a scenario where it passes 
> invalid XML, where content is included after the closing slash, i.e.
> {noformat}{noformat}
> in 
> https://github.com/apache/sling-org-apache-sling-xss/blob/bafa22b0c3dfd457bfc8187d17dd8ffd14ab2158/src/test/java/org/apache/sling/xss/impl/AntiSamyPolicyTest.java#L216
>  .
> The test is strict and asserts that no style tag is present, since the XML 
> parser used by AntiSamy does not recognize the tag. This is not in line with 
> how the style tag is treated currently, as invalid values are removed, but 
> the style tag is preserved.
> We should make the test more lenient and accept an empty style tag. This 
> would make it also compatible with the Java HTML Cleaner based implementation 
> worked on in SLING-7231.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-11425) Make URI filtering test more lenient in case of invalid XML input

2022-06-30 Thread Robert Munteanu (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-11425:
---

Assignee: Robert Munteanu

> Make URI filtering test more lenient in case of invalid XML input
> -
>
> Key: SLING-11425
> URL: https://issues.apache.org/jira/browse/SLING-11425
> Project: Sling
>  Issue Type: Improvement
>  Components: XSS Protection API
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: XSS Protection API 2.2.22
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The AntiSamiPolicyTest validates URI filtering in a scenario where it passes 
> invalid XML, where content is included after the closing slash, i.e.
> {noformat}{noformat}
> in 
> https://github.com/apache/sling-org-apache-sling-xss/blob/bafa22b0c3dfd457bfc8187d17dd8ffd14ab2158/src/test/java/org/apache/sling/xss/impl/AntiSamyPolicyTest.java#L216
>  .
> The test is strict and asserts that no style tag is present, since the XML 
> parser used by AntiSamy does not recognize the tag. This is not in line with 
> how the style tag is treated currently, as invalid values are removed, but 
> the style tag is preserved.
> We should make the test more lenient and accept an empty style tag. This 
> would make it also compatible with the Java HTML Cleaner based implementation 
> worked on in SLING-7231.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [sling-org-apache-sling-xss] rombert merged pull request #25: SLING-11425 Make URI filtering test more lenient in case of invalid XML input

2022-06-30 Thread GitBox 


rombert merged PR #25:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/25


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-xss] sonarcloud[bot] commented on pull request #25: SLING-11425 Make URI filtering test more lenient in case of invalid XML input

2022-06-30 Thread GitBox 


sonarcloud[bot] commented on PR #25:
URL: 
https://github.com/apache/sling-org-apache-sling-xss/pull/25#issuecomment-1170998818

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss=25)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=25=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=25=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=25=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=25=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=25=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=25=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=25=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=25=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=25=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=25=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=25=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=25=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=25=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=25=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=25=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-discovery-base] rombert commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-06-30 Thread GitBox 


rombert commented on PR #7:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1170988112

   @ashokmca07 - If I understand correctly, the SCR components are exported, 
which means that changed methods/annotations also change the API. To be honest 
I am not sure at all how to proceed here. We could:
   - force the baseline, and risk that consumers are broken
   - bump the versions, verify that the consuming Sling bundles ( other 
discovery bundles I assume ) still work, and update the consuming Sling bundles 
import ranges to work with both the new and the old versions
   - do nothing and keep this bundle on an old parent ( not feasible on the 
long run )
   
   /cc @stefan-egli @kwin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Testing Sling Mock 3.3.2

2022-06-30 Thread Robert Munteanu 
On Thu, 2022-06-30 at 09:23 +0200, Konrad Windszus wrote:
> Please vote to approve this release: 

+1
Robert


signature.asc
Description: This is a digitally signed message part

[GitHub] [sling-org-apache-sling-repoinit-parser] anchela commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI

2022-06-30 Thread GitBox 


anchela commented on PR #24:
URL: 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1170878577

   @schaefa , thanks for the patch. can you please ask @bdelacretaz for a 
review? i am busy and don't have time for a thorough review, while he is the 
author of repoinit and should have a say here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

RE: [VOTE] Release Apache Sling Testing Sling Mock 3.3.2

2022-06-30 Thread Stefan Seifert 
+1

stefan

Re: [VOTE] Release Apache Sling Health Check Support version 1.0.8

2022-06-30 Thread Georg Henzler 

+1

- Georg


On 2022-06-28 22:30, Eric Norman wrote:

Hi,

We solved 3 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12349321

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2651/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2651 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x

2022-06-30 Thread Georg Henzler (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560889#comment-17560889
 ] 

Georg Henzler commented on SLING-11141:
---

Let's move forward, we can deprecate this ScriptedHealthCheck in the next 
release and for this release, it will work side by side with the Felix 3.x one. 

> Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
> ---
>
> Key: SLING-11141
> URL: https://issues.apache.org/jira/browse/SLING-11141
> Project: Sling
>  Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Health Check Support 1.0.8
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> After updating to the org.apache.felix.healthcheck.generalchecks version 
> 3.0.0 release, the org.apache.sling.hc.support bundle fails during the 
> feature analyzer with this error:
> {noformat}
> [ERROR] [bundle-packages] org.apache.sling:org.apache.sling.hc.support:1.0.6: 
>  is importing package(s) org.apache.felix.hc.generalchecks.util in start 
> level 20 but no bundle is exporting these for that start level.
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE] Release Apache Sling Testing Sling Mock 3.3.2

2022-06-30 Thread Konrad Windszus 
Hi, 
We solved 1 issue in this release: 
https://issues.apache.org/jira/browse/SLING-11362

Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2652/ 
You can use this UNIX script to download the release and verify the signatures: 
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
Usage: sh check_staged_release.sh 2652 /tmp/sling-staging 

Please vote to approve this release: 
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because … 

This majority vote is open for at least 72 hours.
Thanks for voting,
Konrad