[VOTE] Release Apache Sling Content Package to Feature Model Converter 1.1.20
Hi, We solved 2 issues https://issues.apache.org/jira/projects/SLING/versions/12352215 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2684/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2684 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Updated] (SLING-11616) Build and test with Windows
[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-11616: - Fix Version/s: Content-Package to Feature Model Converter 1.1.22 (was: Content-Package to Feature Model Converter 1.1.20) > Build and test with Windows > --- > > Key: SLING-11616 > URL: https://issues.apache.org/jira/browse/SLING-11616 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.22 > > > The ASF Jenkins should build and test on Windows as well to prevent issues > like SLING-11615. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #11: SLING-11619 : safeguard backoff factors config
sonarcloud[bot] commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1276513023 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #11: SLING-11619 : safeguard backoff factors config
sonarcloud[bot] commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1276459995 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=11&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #11: SLING-11619 : safeguard backoff factors config
stefan-egli commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1276443405 @ashokmca07 : this issue (SLING-11619) popped up recently and I started to look into it. As you were involved in the parent 47 upgrade I thought perhaps you have a more elegant idea than coding some explicit guard function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11619) Restore safeguard mechanism for discovery config
[
https://issues.apache.org/jira/browse/SLING-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616564#comment-17616564
]
Stefan Egli commented on SLING-11619:
-
Started work in a [draft
PR|https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11]
> Restore safeguard mechanism for discovery config
>
>
> Key: SLING-11619
> URL: https://issues.apache.org/jira/browse/SLING-11619
> Project: Sling
> Issue Type: Task
> Components: Discovery
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
>
> With the [update to parent
> 47|https://github.com/apache/sling-org-apache-sling-discovery-oak/commit/c306408f36e7636c72b71805d2bb0e3e6f0f0e73#diff-73d443e41e9bfaa5e9c77b6db0e318079f1885f5a7ed9685aae9730209adc579]
> the discovery.oak's Config "lost" the ability to gracefully deal with wrong
> values, such as empty strings. It used to silently swallow these, but now
> fails loudly with
> {noformat}
> org.osgi.service.component.ComponentException:
> java.lang.NumberFormatException: For input string: ""
> at
> org.apache.felix.scr.impl.inject.internal.Annotations$Handler.invoke(Annotations.java:379)
> [org.apache.felix.scr:2.2.0]
> at com.sun.proxy.$Proxy368.backoffStandbyFactor(Unknown Source)
> at org.apache.sling.discovery.oak.Config.configure(Config.java:238)
> [org.apache.sling.discovery.oak:1.2.40]
> at org.apache.sling.discovery.oak.Config.activate(Config.java:159)
> [org.apache.sling.discovery.oak:1.2.40]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11619) Restore safeguard mechanism for discovery config
Stefan Egli created SLING-11619:
---
Summary: Restore safeguard mechanism for discovery config
Key: SLING-11619
URL: https://issues.apache.org/jira/browse/SLING-11619
Project: Sling
Issue Type: Task
Components: Discovery
Reporter: Stefan Egli
Assignee: Stefan Egli
With the [update to parent
47|https://github.com/apache/sling-org-apache-sling-discovery-oak/commit/c306408f36e7636c72b71805d2bb0e3e6f0f0e73#diff-73d443e41e9bfaa5e9c77b6db0e318079f1885f5a7ed9685aae9730209adc579]
the discovery.oak's Config "lost" the ability to gracefully deal with wrong
values, such as empty strings. It used to silently swallow these, but now fails
loudly with
{noformat}
org.osgi.service.component.ComponentException: java.lang.NumberFormatException:
For input string: ""
at
org.apache.felix.scr.impl.inject.internal.Annotations$Handler.invoke(Annotations.java:379)
[org.apache.felix.scr:2.2.0]
at com.sun.proxy.$Proxy368.backoffStandbyFactor(Unknown Source)
at org.apache.sling.discovery.oak.Config.configure(Config.java:238)
[org.apache.sling.discovery.oak:1.2.40]
at org.apache.sling.discovery.oak.Config.activate(Config.java:159)
[org.apache.sling.discovery.oak:1.2.40]
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11618) Webconsole: FilterStatus prints timings with wrong unit
[ https://issues.apache.org/jira/browse/SLING-11618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11618: -- Fix Version/s: Engine 2.13.0 (was: Engine 2.12.0) > Webconsole: FilterStatus prints timings with wrong unit > > > Key: SLING-11618 > URL: https://issues.apache.org/jira/browse/SLING-11618 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.12.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.13.0 > > Time Spent: 40m > Remaining Estimate: 0h > > With the changes in SLING-10582 the filter timing was changed to be recorded > in microseconds as well, while the Webconsole Plugin still expects > miliseconds. > This should be fixed, the unit should still be microseconds. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11618) Webconsole: FilterStatus prints timings with wrong unit
[ https://issues.apache.org/jira/browse/SLING-11618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-11618. --- Fix Version/s: Engine 2.12.0 Resolution: Fixed > Webconsole: FilterStatus prints timings with wrong unit > > > Key: SLING-11618 > URL: https://issues.apache.org/jira/browse/SLING-11618 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.12.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.12.0 > > Time Spent: 40m > Remaining Estimate: 0h > > With the changes in SLING-10582 the filter timing was changed to be recorded > in microseconds as well, while the Webconsole Plugin still expects > miliseconds. > This should be fixed, the unit should still be microseconds. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-engine] joerghoh merged pull request #26: SLING-11618 fix units in the slingfilter webconsole printer
joerghoh merged PR #26: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #26: SLING-11618 fix units in the slingfilter webconsole printer
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/26#issuecomment-1276293131 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=26) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=26&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=26&metric=new_coverage&view=list) [20.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=26&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=26&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=26&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] joerghoh commented on a diff in pull request #26: SLING-11618 fix units in the slingfilter webconsole printer
joerghoh commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/26#discussion_r993429966
##
src/main/java/org/apache/sling/engine/impl/filter/FilterHandle.java:
##
@@ -85,14 +85,16 @@ public long getTime() {
return time.get();
}
+// timing unit is in microseconds
Review Comment:
adjusted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] cziegeler commented on a diff in pull request #26: SLING-11618 fix units in the slingfilter webconsole printer
cziegeler commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/26#discussion_r993422929
##
src/main/java/org/apache/sling/engine/impl/filter/FilterHandle.java:
##
@@ -85,14 +85,16 @@ public long getTime() {
return time.get();
}
+// timing unit is in microseconds
Review Comment:
I think this is supposed to return milliseconds - as it is also used for the
mbean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-11618) Webconsole: FilterStatus prints timings with wrong unit
[ https://issues.apache.org/jira/browse/SLING-11618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616396#comment-17616396 ] Joerg Hoh commented on SLING-11618: --- https://github.com/apache/sling-org-apache-sling-engine/pull/26 > Webconsole: FilterStatus prints timings with wrong unit > > > Key: SLING-11618 > URL: https://issues.apache.org/jira/browse/SLING-11618 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.12.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > With the changes in SLING-10582 the filter timing was changed to be recorded > in microseconds as well, while the Webconsole Plugin still expects > miliseconds. > This should be fixed, the unit should still be microseconds. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11618) Webconsole: FilterStatus prints timings with wrong unit
[ https://issues.apache.org/jira/browse/SLING-11618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11618: -- Description: With the changes in SLING-10582 the filter timing was changed to be recorded in microseconds as well, while the Webconsole Plugin still expects miliseconds. This should be fixed, the unit should still be microseconds. was: With the changes in SLING-10582 the filter timing was changed to be recorded in microseconds as well. Previously the filter status was assuming a milisecond granularity and calculated the average duration per invocation in microseconds. Now the durations are in microseconds instead, so the timing itself should be adjusted. But no need to have a nanosecond resolution. Summary: Webconsole: FilterStatus prints timings with wrong unit (was: Webconsole: FilterStatus prints timings in µs instead of nanosecs) > Webconsole: FilterStatus prints timings with wrong unit > > > Key: SLING-11618 > URL: https://issues.apache.org/jira/browse/SLING-11618 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.12.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > With the changes in SLING-10582 the filter timing was changed to be recorded > in microseconds as well, while the Webconsole Plugin still expects > miliseconds. > This should be fixed, the unit should still be microseconds. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11618) Webconsole: FilterStatus prints timings in µs instead of nanosecs
Joerg Hoh created SLING-11618: - Summary: Webconsole: FilterStatus prints timings in µs instead of nanosecs Key: SLING-11618 URL: https://issues.apache.org/jira/browse/SLING-11618 Project: Sling Issue Type: Improvement Components: Engine Affects Versions: Engine 2.12.0 Reporter: Joerg Hoh Assignee: Joerg Hoh With the changes in SLING-10582 the filter timing was changed to be recorded in microseconds as well. Previously the filter status was assuming a milisecond granularity and calculated the average duration per invocation in microseconds. Now the durations are in microseconds instead, so the timing itself should be adjusted. But no need to have a nanosecond resolution. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #472 is BROKEN
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/472/
for details.
No further emails will be sent until the status of the build is changed.
Build log follows below:
[...truncated 29930 lines...]
}
.Grid .Cell.Large-50 {
flex: 0 0 50%
}
.Grid.Fit-Large > .Cell {
-webkit-box-flex: 1;
-webkit-flex: 1;
-ms-flex: 1;
flex: 1
}
}
@media (min-width: 75em) {
.Grid.Fit-Extra > .Cell {
-webkit-box-flex: 1;
-webkit-flex: 1;
-ms-flex: 1;
flex: 1
}
}
* {
box-sizing: border-box
}
body {
font-family: 'Open Sans', Helvetica, Arial;
color: gray;
position: relative;
height: 100%;
}
h1 {
font-size: 2.4em;
color: #606060
}
h2 {
font-weight: 400;
font-size: 1em
}
a {
color: #00678c;
text-decoration: none
}
a:hover {
text-decoration: underline
}
a img {
border: none
}
.Home-Grid {
min-height: 100%
}
.Home-Grid .Gradient {
flex: 0 0 100%;
height: 16px;
background:
url(data:image/jpeg;base64,/9j/4QPFRXhpZgAATU0AKggABwESAAMBAAEAAAEaAAUBYgEbAAUBagEoAAMBAAIAAAExAAIkcgEyAAIUlodpAAQBrNgACvynEAAK/IAAACcQQWRvYmUgUGhvdG9zaG9wIENDIDIwMTcgKE1hY2ludG9zaCkAMjAxNzowNTowMyAxMDozMToyMAADoAEAAwEAAQAAoAIABAEyoAMABAEAAAQ4AAYBAwADAQAGAAABGgAFAQAAASYBGwAFAQAAAS4BKAADAQACAAACAQAEAQAAATYCAgAEAQAAAocASAEAAABIAf/Y/+0ADEFkb2JlX0NNAAH/7gAOQWRvYmUAZIAB/9sAhAAMCAgICQgMCQkMEQsKCxEVDwwMDxUYExMVExMYEQwMDAwMDBEMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAQ0LCw0ODRAODhAUDg4OFBQODg4OFBEMDAwMDBERDAwMDAwMEQwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAz/wAARCACXAAcDASIAAhEBAxEB/90ABAAB/8QBPwAAAQUBAQEBAQEAAwABAgQFBgcICQoLAQABBQEBAQEBAQABAAIDBAUGBwgJCgsQAAEEAQMCBAIFBwYIBQMMMwEAAhEDBCESMQVBUWETInGBMgYUkaGxQiMkFVLBYjM0coLRQwclklPw4fFjczUWorKDJkSTVGRFwqN0NhfSVeJl8rOEw9N14/NGJ5SkhbSVxNTk9KW1xdXl9VZmdoaWprbG1ub2N0dXZ3eHl6e3x9fn9xEAAgIBAgQEAwQFBgcHBgU1AQACEQMhMRIEQVFhcSITBTKBkRShsUIjwVLR8DMkYuFygpJDUxVjczTxJQYWorKDByY1wtJEk1SjF2RFVTZ0ZeLys4TD03Xj80aUpIW0lcTU5PSltcXV5fVWZnaGlqa2xtbm9ic3R1dnd4eXp7fH/9oADAMBAAIRAxEAPwDrUk0pLCp13//Q6qUlGUljcLsP/9HppSUJSWZwuzT/AP/S6CdElGdElS4Xbf/T3AdEk3ZJQcLtv//U2hwkkOEkOF2rf//V2xwknA0ST6da3//W3QNElIDRJTU6XE//1+gA0SUo0SVhu8T/AP/Q6SNEl4MkrLa1f//Z/+0LglBob3Rvc2hvcCAzLjAAOEJJTQQlAAAQADhCSU0EOgAA5QAAABABAAALcHJpbnRPdXRwdXQFAFBzdFNib29sAQBJbnRlZW51bQBJbnRlAENscm0PcHJpbnRTaXh0ZWVuQml0Ym9vbAALcHJpbnRlck5hbWVURVhUAQAAD3ByaW50UHJvb2ZTZXR1cE9iamMMAFAAcgBvAG8AZgAgAFMAZQB0AHUAcAAACnByb29mU2V0dXABAEJsdG5lbnVtDGJ1aWx0aW5Qcm9vZglwcm9vZkNNWUsAOEJJTQQ7AAItEAEAABJwcmludE91dHB1dE9wdGlvbnMXAENwdG5ib29sAABDbGJyYm9vbAAAUmdzTWJvb2wAAENybkNib29sAABDbnRDYm9vbAAATGJsc2Jvb2wAAE5ndHZib29sAABFbWxEYm9vbAAASW50cmJvb2wAAEJja2dPYmpjAQAAAFJHQkMDAFJkICBkb3ViQG/gR3JuIGRvdWJAb+BCbCAgZG91YkBv4EJyZFRVbnRGI1JsdEJsZCBVbnRGI1JsdFJzbHRVbnRGI1B4bEBSCnZlY3RvckRhdGFib29sAQBQZ1BzZW51bQBQZ1BzAFBnUEMATGVmdFVudEYjUmx0VG9wIFVudEYjUmx0U2NsIFVudEYjUHJjQFkQY3JvcFdoZW5QcmludGluZ2Jvb2wADmNyb3BSZWN0Qm90dG9tbG9uZwAMY3JvcFJlY3RMZWZ0bG9uZwANY3JvcFJlY3RSaWdodGxvbmcAC2Nyb3BSZWN0VG9wbG9uZwAAOEJJTQPtAAAQAEgBAAEASAEAAThCSU0EJgAADgA/gAAAOEJJTQQNAAAEWjhCSU0EGQAABB44QklNA/MAAAkAAAEAOEJJTScQAAAKAAEAAThCSU0D9QAASAAvZmYAAQBsZmYABgAAAQAvZmYAAQChmZoABgAAAQAyAQBaBgAAAQA1AQAtBgAAAThCSU0D+AAAcAAA/wPoAP8D6AD/A+gA/wPoAAA4QklNBAgAABABAAACQkAAOEJJTQQeAAAEADhCSU0EGgADSQYABDgyCgBVAG4AdABpAHQAbABlAGQALQA0AQABAAAyAAAEOAABABABbnVsbAIGYm91bmRzT2JqYwEAAABSY3QxBABUb3AgbG9uZwAATGVmdGxvbmcAAEJ0b21sb25nAAAEOABSZ2h0bG9uZwAAADIGc2xpY2VzVmxMcwFPYmpjAQAABXNsaWNlEgdzbGljZUlEbG9uZwAHZ3JvdXBJRGxvbmcABm9yaWdpbmVudW0MRVNsaWNlT3JpZ2luDWF1dG9HZW5lcmF0ZWQAVH
[GitHub] [sling-org-apache-sling-feature-extension-content] sonarcloud[bot] commented on pull request #18: SLING-11617 - Skip execution plan processing
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/18#issuecomment-1275751904 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&metric=new_coverage&view=list) [96.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-content&pullRequest=18&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-extension-content] DominikSuess commented on pull request #18: SLING-11617 - Skip execution plan processing
DominikSuess commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/18#issuecomment-1275748217 Did reduce cognitive complexity and eliminated codesmells (that were in place before already but sonar complained) - for review best check both commits individually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
