[jira] [Updated] (SLING-11680) Eclipse plugins: Switch from Jarsigning to external GPG signatures
[ https://issues.apache.org/jira/browse/SLING-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11680: Summary: Eclipse plugins: Switch from Jarsigning to external GPG signatures (was: Eclipse plugins: Switch from Jarsigning toeeGPG signatures) > Eclipse plugins: Switch from Jarsigning to external GPG signatures > -- > > Key: SLING-11680 > URL: https://issues.apache.org/jira/browse/SLING-11680 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Konrad Windszus >Priority: Major > > Since recently Eclipse P2 supports external GPG signatures: > https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fp2_pgp.html > We should consider to use that instead of the complicated/error prone > Jarsigner process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11680) Eclipse plugins: Switch from Jarsigning toeeGPG signatures
[ https://issues.apache.org/jira/browse/SLING-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11680: Summary: Eclipse plugins: Switch from Jarsigning toeeGPG signatures (was: Eclipse plugins: Switch from Jarsigning to GPG signing) > Eclipse plugins: Switch from Jarsigning toeeGPG signatures > -- > > Key: SLING-11680 > URL: https://issues.apache.org/jira/browse/SLING-11680 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Konrad Windszus >Priority: Major > > Since recently Eclipse P2 supports external GPG signatures: > https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fp2_pgp.html > We should consider to use that instead of the complicated/error prone > Jarsigner process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11680) Eclipse plugins: Switch from Jarsigning to GPG signing
Konrad Windszus created SLING-11680: --- Summary: Eclipse plugins: Switch from Jarsigning to GPG signing Key: SLING-11680 URL: https://issues.apache.org/jira/browse/SLING-11680 Project: Sling Issue Type: Improvement Components: IDE Reporter: Konrad Windszus Since recently Eclipse P2 supports external GPG signatures: https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fp2_pgp.html We should consider to use that instead of the complicated/error prone Jarsigner process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
sling-site build is failing
Hi, While promoting a release I noticed that the sling-site job at [1] has failed during the last two attempts with an error while doing a git checkout. Anyone know what is going on there? 1. https://ci-builds.apache.org/job/Sling/job/modules/job/sling-site/job/master Regards, Eric
[jira] [Closed] (SLING-11321) The effective acl/ace json output should contain the paths where the privileges were declared
[
https://issues.apache.org/jira/browse/SLING-11321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-11321.
---
> The effective acl/ace json output should contain the paths where the
> privileges were declared
> -
>
> Key: SLING-11321
> URL: https://issues.apache.org/jira/browse/SLING-11321
> Project: Sling
> Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Minor
> Fix For: JCR Jackrabbit Access Manager 3.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Use Case: For debugging purposes, or if you want a UI view of the effective
> ACE or ACL to be able to draw links to where the privileges were defined.
> It would be useful for the effective acl and effective ace json to include a
> "declaredAt" structure for each principal that has the all paths where an
> applicable ACE was defined.
> Expected something like this for node based ACE definitions:
> {noformat}
> {
> "principal": "everyone",
> "privileges": {
> "jcr:read": {
> "allow": true
> },
> "jcr:readAccessControl": {
> "allow": true
> }
> },
> "declaredAt": {
> "node": [
> "/content",
> "/content/pages"
> ]
> }
> }{noformat}
> Where declaredAt/node contains the paths for any entries defined on a node.
> Or something like this for principal based ACE definitions:
> {noformat}
> {
> "principal":"sling-readall",
> "privileges":{
> "jcr:read":{
> "allow":true
> },
> "jcr:readAccessControl":{
> "allow":true
> }
> },
> "declaredAt":{
> "principal":[
> "/content/pages",
> "/"
> ]
> }
> }{noformat}
> Where declaredAt/principal contains the paths for any principalbased access
> control
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11270) Update to Sling Bundle Parent 49
[ https://issues.apache.org/jira/browse/SLING-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-11270. --- > Update to Sling Bundle Parent 49 > > > Key: SLING-11270 > URL: https://issues.apache.org/jira/browse/SLING-11270 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR Jackrabbit Access Manager 3.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11340) Custom restriction fails validation during modifyAce call
[ https://issues.apache.org/jira/browse/SLING-11340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-11340. --- > Custom restriction fails validation during modifyAce call > - > > Key: SLING-11340 > URL: https://issues.apache.org/jira/browse/SLING-11340 > Project: Sling > Issue Type: Bug >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR Jackrabbit Access Manager 3.1.0 > > Time Spent: 50m > Remaining Estimate: 0h > > The validation that is checking the posted restriction name is failing for > any custom restriction. (for example from > [sling-oak-restrictions|https://sling.apache.org/documentation/bundles/sling-oak-restrictions.html]) > This is happening because the ModifyAce (and related) code is only binding to > a single RestrictionProvider component. There may be multiple > RestrictionProvider components available, so the validation should be > checking them all for a match. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11272) Add support to get, modify and delete a principalbased ACE
[
https://issues.apache.org/jira/browse/SLING-11272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-11272.
---
> Add support to get, modify and delete a principalbased ACE
> --
>
> Key: SLING-11272
> URL: https://issues.apache.org/jira/browse/SLING-11272
> Project: Sling
> Issue Type: New Feature
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit Access Manager 3.1.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> For debugging purposes, it would be useful to get a view of what is currently
> defined in a principalbased ACE.
> For example:
> {code:java}
> http://localhost:8080/test/node.pace.json?pid=[userid] {code}
> Also, if changes are required, it would be useful to have the capability to
> modify or delete a principalbased ACE.
> For example, POST to these endpoints with arguments similar to the existing
> modifyAce and deleteAce endpoints:
> {code:java}
> http://localhost:8080/test/node.modifyPAce.json
> http://localhost:8080/test/node.deletePAce.json {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11273) Deprecate the PrivilegesInfo#getDeclaredRestrictionsForPrincipal methods
[ https://issues.apache.org/jira/browse/SLING-11273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-11273. --- > Deprecate the PrivilegesInfo#getDeclaredRestrictionsForPrincipal methods > > > Key: SLING-11273 > URL: https://issues.apache.org/jira/browse/SLING-11273 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR Jackrabbit Access Manager 3.1.0 > > Time Spent: 50m > Remaining Estimate: 0h > > The api should not be used as it assumes that all the privileges have the > same restrictions which may not be true. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11243) Allow modifying an ace with more specific restriction details
[
https://issues.apache.org/jira/browse/SLING-11243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-11243.
---
> Allow modifying an ace with more specific restriction details
> -
>
> Key: SLING-11243
> URL: https://issues.apache.org/jira/browse/SLING-11243
> Project: Sling
> Issue Type: New Feature
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit Access Manager 3.1.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Support for modifying an ace with more specific details to support advanced
> usage of privileges with restrictions.
> These are a few of the use cases:
> # Setting a restriction for a specific privilege instead of for all
> privileges
> # Removing a restriction from a specific privilege
> # Privilege can set for the 'allow' and 'deny' state at the same time if
> those have different restrictions
> # Privilege can be unset for 'allow' or 'deny' state while leaving the other
> state alone
>
> The proposal is to supporting these additional request parameters:
>
> {code:java}
> One param for each privilege to delete. The parameter value must be either
> 'allow', 'deny' or 'all' to specify which state to delete from.
> privilege@[privilege_name]@Delete
> One param for each restriction value. The same parameter name may be used
> again for multi-value restrictions. The @Allow or @Deny suffix specifies
> whether to apply the restriction to the 'allow' or 'deny' privilege. The
> value is the target value of the restriction to be set.
> restriction@[privilege_name]@[restriction_name]@Allow
> restriction@[privilege_name]@[restriction_name]@Deny
> One param for each restriction to delete. The parameter value must be either
> 'allow', 'deny' or 'all' to specify which state to delete from.
> restriction@[privilege_name]@[restriction_name]@Delete {code}
>
> For consistency, also extend the values allowed for the
> "privilege@[privilege_name]" parameter to accept 'allow' or 'deny' as aliases
> for 'granted' or 'denied'.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11271) Provide servlet to get json for the ACE or Effective ACE for a principal
[
https://issues.apache.org/jira/browse/SLING-11271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-11271.
---
> Provide servlet to get json for the ACE or Effective ACE for a principal
>
>
> Key: SLING-11271
> URL: https://issues.apache.org/jira/browse/SLING-11271
> Project: Sling
> Issue Type: New Feature
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Minor
> Fix For: JCR Jackrabbit Access Manager 3.1.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Sometimes it is more convenient to get the json of the ACE of a specific
> principal rather than getting the ACL json and dig out the entry for the
> principal.
> For example:
> {code:java}
> http://localhost:8080/test/node.ace.json?pid=[userid]
> http://localhost:8080/test/node.eace.json?pid=[userid] {code}
> If no ACE exists for that principal than a 404 status is returned.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11233) Change ACL json output structure to be less ambiguous for restrictions
[
https://issues.apache.org/jira/browse/SLING-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-11233.
---
> Change ACL json output structure to be less ambiguous for restrictions
> --
>
> Key: SLING-11233
> URL: https://issues.apache.org/jira/browse/SLING-11233
> Project: Sling
> Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit Access Manager 3.1.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The restriction details in the ACL json output can be ambiguous in some
> situations.
> For example, in the example below it is not clear if the "rep:glob"
> restriction applies to the "jcr:read" privilege or the "rep:write" privilege.
>
> {code:java}
> {
> "user1":{
> "principal":"user1",
> "granted":[
> "jcr:read"
> ],
> "denied":[
> "rep:write"
> ],
> "order":0,
> "restrictions":{
> "rep:glob":"glob1"
> }
> }
> } {code}
>
>
> Expected:
> The JSON structure of the ACE should be enhanced to make it more clear.
> For example, replace the "granted/denied/restrictions" items with a
> "privileges" structure whose items are the granted or denied privileges.
> Each privilege has a "deny" and/or "grant" child whose value is either true
> (no restrictions) or an array of restrictions + values.
> For example:
>
> {code:java}
> {
> "user1":{
> "principal":"user1",
> "order":0,
> "privileges":{
> "jcr:read":{
> "allow":{
> "rep:glob":"glob1"
> }
> },
> "jcr:readAccessControl":{
> "allow":{
> "rep:itemNames":[
> "name1",
> "name2"
> ]
> }
> },
> "rep:write":{
> "deny":true
> }
> }
> }
> } {code}
> The new format should also be flexible enough to describe a privilege that is
> granted and denied with different restrictions for each of those states.
> That scenario is impossible to describe in the old format.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling JCR Jackrabbit Access Manager version 3.1.0
Hi, The vote has passed with the following result : +1 (binding): Carsten Ziegeler, Stefan Seifert, Jörg Hoh, Eric Norman +1 (non binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.
Re: [VOTE] Release Apache Sling JCR Jackrabbit Access Manager version 3.1.0
+1 On Mon, Nov 14, 2022 at 4:04 PM Eric Norman wrote: > Hi, > > We solved 8 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12350300 > > Site documentation updates are staged for review and feedback at: > https://github.com/apache/sling-site/pull/92 > > Starter-content sample acl/ace UI updates are staged for review and > feedback at: > https://github.com/apache/sling-org-apache-sling-starter-content/pull/7 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2692/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2692 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1319076871 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-xing-login] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1319064373 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login&pullRequest=2&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1319063635 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&metric=new_duplicated_lines_density&view=list) [7.3% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth&pullRequest=2&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #41: SLING-11679: Set more descriptive User-Agent for SlingClients
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#issuecomment-1319061011 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_coverage&view=list) [87.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] joerghoh commented on a diff in pull request #41: SLING-11679: Set more descriptive User-Agent for SlingClients
joerghoh commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1025414048
##
src/main/java/org/apache/sling/testing/Constants.java:
##
@@ -37,4 +37,5 @@ public class Constants {
* Http Context Attributes
*/
public static final String EXPECTED_STATUS = "expected_status";
+
Review Comment:
Please remove this unnecessary whitespace-change.
##
src/main/java/org/apache/sling/testing/clients/SystemPropertiesConfig.java:
##
@@ -59,6 +61,18 @@ public class SystemPropertiesConfig {
*/
public static final String HTTP_RETRIES_ERROR_CODES_PROP =
"http.retriesErrorCodes";
+/**
+ * System property for {@link
SystemPropertiesConfig#getClientUserAgentTitle()}
+ * Prefixed by {@link SystemPropertiesConfig#CONFIG_PROP_PREFIX}
+ */
+public static final String CLIENT_USERAGENT_TITLE =
"client.useragent.title";
Review Comment:
nitpick: I think that the useragent has a "name", and not a "title" :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (SLING-11679) Set more descriptive User-Agent for SlingClients
Andrei Dulvac created SLING-11679: - Summary: Set more descriptive User-Agent for SlingClients Key: SLING-11679 URL: https://issues.apache.org/jira/browse/SLING-11679 Project: Sling Issue Type: Improvement Components: Apache Sling Testing Clients Affects Versions: Apache Sling Testing Clients 3.0.16 Reporter: Andrei Dulvac Assignee: Andrei Dulvac Fix For: Apache Sling Testing Clients 3.0.18 Customize and change the User-Agent header used by the http clients. The default User-Agent may be changed or it may be replaced or appended per test. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #41: SLING-XXX: Set more descriptive User-Agent for SlingClients
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#issuecomment-1318709438 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_coverage&view=list) [87.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #41: SLING-XXX: Set more descriptive User-Agent for SlingClients
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#issuecomment-1318677587 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_coverage&view=list) [87.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] Kronnox commented on a diff in pull request #41: SLING-XXX: Set more descriptive User-Agent for SlingClients
Kronnox commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1025222564
##
src/main/java/org/apache/sling/testing/Constants.java:
##
@@ -37,4 +37,9 @@ public class Constants {
* Http Context Attributes
*/
public static final String EXPECTED_STATUS = "expected_status";
+
+/**
+ * User Agent
+ */
+public static final String SLING_CLIENT_USERAGENT_TITLE =
"sling-testing-client";
Review Comment:
I added two system-properties to customise the default user-agent:
- `sling.it.client.useragent.title` Define a alternative user-agent title
(Default is `Java`)
- `sling.it.client.useragent.useversion` Append the sling-testing-client
library-version to it (Default is `false`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-11678) Protect the Tooling Support Install servlet
[ https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635312#comment-17635312 ] Carsten Ziegeler commented on SLING-11678: -- Yes, that why my idea is to remove the "jar" part - use the webconsole for it ; keep the directory part > Protect the Tooling Support Install servlet > --- > > Key: SLING-11678 > URL: https://issues.apache.org/jira/browse/SLING-11678 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > Currently the endpoint provided by Tooling Support Endpoint doesn't require > authentication so every anonymous user can install arbitrary bundles. > I would suggest to migrate the endpoint to a [web console > plugin|https://felix.apache.org/documentation/subprojects/apache-felix-web-console/extending-the-apache-felix-web-console/providing-web-console-plugins.html] > to benefit from its built in authentication. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11678) Protect the Tooling Support Install servlet
[ https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635299#comment-17635299 ] Konrad Windszus commented on SLING-11678: - bq. deploying a local directory as a bundle requires that the app runs locally with access to the file system The servlet also allows to deploy arbitrary JARs sent with a multipart post, therefore I see a risk that this endpoint by mistake ends up on a production server and makes it vulnerable to attacks. > Protect the Tooling Support Install servlet > --- > > Key: SLING-11678 > URL: https://issues.apache.org/jira/browse/SLING-11678 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > Currently the endpoint provided by Tooling Support Endpoint doesn't require > authentication so every anonymous user can install arbitrary bundles. > I would suggest to migrate the endpoint to a [web console > plugin|https://felix.apache.org/documentation/subprojects/apache-felix-web-console/extending-the-apache-felix-web-console/providing-web-console-plugins.html] > to benefit from its built in authentication. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-dynamic-include] anban02 commented on pull request #26: SLING-10110: added a functionality for resolving Star-Wildcards in ig…
anban02 commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1318377289 > @anban02 So when looking at the patch, it just translates a glob `*` into its equivalent regex counterpart `.*`; is this the gist of the patch? That is not all but a big part of it. In the current unpatched version the ignoreUrlParams matching is an exact value matching that did not allow the use of wildcards. But because Apache-Dispatcher Configurations allow wildcards I needed SDI to also correctly resolve ignoreUrlParams that were defined with wildcards. So to summarize it: i added a check for ignoreUrlParams to see if there is a wildcard configured in the style of a dispatcher config. If so then the `*` is translated to `.*` so i can do a regex match for that and see if the parameter that is currently checked should be ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.24
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12352474 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2693 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2693 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Kind regards Angela
[jira] [Updated] (SLING-11616) Build and test with Windows
[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11616: - Fix Version/s: (was: Content-Package to Feature Model Converter 1.1.24) > Build and test with Windows > --- > > Key: SLING-11616 > URL: https://issues.apache.org/jira/browse/SLING-11616 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > > The ASF Jenkins should build and test on Windows as well to prevent issues > like SLING-11615. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11662) Endless loop in QuartzSchedulerThread.run() with maxPoolSize == queueSize
[
https://issues.apache.org/jira/browse/SLING-11662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635219#comment-17635219
]
Stefan Egli commented on SLING-11662:
-
[~cziegeler], great thx! I'll have a look as soon as possible, was also
planning to add perhaps another test case or so (but have to first check how
much coverage there is for these edge cases)..
> Endless loop in QuartzSchedulerThread.run() with maxPoolSize == queueSize
> -
>
> Key: SLING-11662
> URL: https://issues.apache.org/jira/browse/SLING-11662
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Affects Versions: Commons Scheduler 2.7.12
>Reporter: Stefan Egli
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When configuring the ThreadPool with maxPoolSize == queueSize and endless
> loop (can) happen(s) in QuartzSchedulerThread.run() which manifests as
> follows:
> {noformat}
> "MyPool_QuartzSchedulerThread" #123 prio=5 os_prio=0 cpu=5123456.78ms
> elapsed=5163.45s tid=0x12345678ff00 nid=0x1234 runnable
> [0x87654321ff00]
>java.lang.Thread.State: RUNNABLE
> at
> org.quartz.core.QuartzSchedulerThread.run(QuartzSchedulerThread.java:413)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-dynamic-include] joerghoh commented on pull request #26: SLING-10110: added a functionality for resolving Star-Wildcards in ig…
joerghoh commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1318302185 @anban02 So when looking at the patch, it just translates a glob ```*``` into its equivalent regex counterpart ```.*```; is this the gist of the patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #41: SLING-XXX: Set more descriptive User-Agent for SlingClients
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#issuecomment-1318281326 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_coverage&view=list) [97.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=41&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
