[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #529 is BROKEN
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/529/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: [...truncated 13714 lines...] See https://pdfbox.apache.org/2.0/dependencies.html#jai-image-io for optional dependencies. Nov 23, 2022 4:34:44 AM org.apache.tika.config.InitializableProblemHandler$3 handleInitializableProblem WARNING: org.xerial's sqlite-jdbc is not loaded. Please provide the jar on your classpath to parse sqlite files. See tika-parsers/pom.xml for the correct version. [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.805 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingDateValuesTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.teleporter.BasicTeleporterTest Nov 23, 2022 4:34:44 AM org.apache.aries.spifly.BaseActivator log INFO: Registered provider org.eclipse.jetty.http.Http1FieldPreEncoder of service org.eclipse.jetty.http.HttpFieldPreEncoder in bundle org.apache.felix.http.jetty Nov 23, 2022 4:34:44 AM org.apache.aries.spifly.BaseActivator log INFO: Registered provider org.eclipse.jetty.http2.hpack.HpackFieldPreEncoder of service org.eclipse.jetty.http.HttpFieldPreEncoder in bundle org.apache.felix.http.jetty [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.895 s - in org.apache.sling.launchpad.webapp.integrationtest.teleporter.BasicTeleporterTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.GetWithSuffixTest [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.496 s - in org.apache.sling.launchpad.webapp.integrationtest.GetWithSuffixTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.ExecuteScriptTest [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.348 s - in org.apache.sling.launchpad.webapp.integrationtest.ExecuteScriptTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.scripting.htl.HtlTest [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.35 s - in org.apache.sling.launchpad.webapp.integrationtest.scripting.htl.HtlTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.scripting.StandaloneScriptExecutionTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.104 s - in org.apache.sling.launchpad.webapp.integrationtest.scripting.StandaloneScriptExecutionTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.LaunchpadConfigInstallerTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 s - in org.apache.sling.launchpad.webapp.integrationtest.LaunchpadConfigInstallerTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.issues.SLING2094Test [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.377 s - in org.apache.sling.launchpad.webapp.integrationtest.issues.SLING2094Test [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletPrivilegesUpdateTest [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletPrivilegesUpdateTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostResponseCreatorTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostResponseCreatorTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.ExportedPackagesTest [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 s - in org.apache.sling.launchpad.webapp.integrationtest.ExportedPackagesTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.repository.RepoinitPathTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.209 s - in org.apache.sling.launchpad.webapp.integrationtest.repository.RepoinitPathTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.MiscUnsafeTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 s - in org.apache.sling.launchpad.webapp.integrationtest.MiscUnsafeTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.installer.ServerSideInstallerTest [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.503 s - in org.apache.sling.launchpad.webapp.integrationtest.installer.ServerSideInstallerTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.DavExDisabledAnonAccessTest [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.349 s - in org.apache.sling.launchpad.webapp.integrationtest.DavExDisabledAnonAccessTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletCreateTest [INFO] Tests run: 16, Failures: 0, Errors: 0,
[jira] [Closed] (SLING-11687) Update to Sling Bundle Parent 49
[ https://issues.apache.org/jira/browse/SLING-11687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-11687. --- > Update to Sling Bundle Parent 49 > > > Key: SLING-11687 > URL: https://issues.apache.org/jira/browse/SLING-11687 > Project: Sling > Issue Type: Bug >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Health Check Support 1.0.10 > > > Update to Sling Bundle Parent 49 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11596) Mark the DefaultLoginsHealthCheck as deprecated
[ https://issues.apache.org/jira/browse/SLING-11596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-11596. --- > Mark the DefaultLoginsHealthCheck as deprecated > --- > > Key: SLING-11596 > URL: https://issues.apache.org/jira/browse/SLING-11596 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Health Check Support 1.0.10 > > Time Spent: 40m > Remaining Estimate: 0h > > Mark the DefaultLoginsHealthCheck as deprecated and provide instructions to > use the equivalent functionality from the auth core bundle instead. > Log a warning message if the deprecated DefaultLoginsHealthCheck ever gets > invoked. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11445) Mark the ScriptedHealthCheck as deprecated
[ https://issues.apache.org/jira/browse/SLING-11445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-11445. --- > Mark the ScriptedHealthCheck as deprecated > -- > > Key: SLING-11445 > URL: https://issues.apache.org/jira/browse/SLING-11445 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Health Check Support 1.0.10 > > Time Spent: 40m > Remaining Estimate: 0h > > Mark the ScriptedHealthCheck as deprecated and provide instructions to use > the equivalent functionality from the > org.apache.felix.healthcheck.generalchecks bundle instead. > Log a warning message if the deprecated ScriptedHealthCheck ever gets invoked. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11444) Deprecate the org.apache.sling.hc.support bundle
[ https://issues.apache.org/jira/browse/SLING-11444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-11444. --- > Deprecate the org.apache.sling.hc.support bundle > > > Key: SLING-11444 > URL: https://issues.apache.org/jira/browse/SLING-11444 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Health Check Support 1.0.10 > > Time Spent: 20m > Remaining Estimate: 0h > > Per the comment from [~henzlerg] at SLING-11141 the whole HC support bundle > should be deprecated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11378) Execution fails if no launcher arguments are defined
[
https://issues.apache.org/jira/browse/SLING-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-11378.
---
> Execution fails if no launcher arguments are defined
>
>
> Key: SLING-11378
> URL: https://issues.apache.org/jira/browse/SLING-11378
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.4
>
>
> {quote}org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute goal
> org.apache.sling:feature-launcher-maven-plugin:0.1.3-SNAPSHOT:start (default)
> on project bundle-version-override: Execution default of goal
> org.apache.sling:feature-launcher-maven-plugin:0.1.3-SNAPSHOT:start failed:
> Cannot invoke
> "org.apache.sling.maven.feature.launcher.LauncherArguments.getVmOptions()"
> because the return value of
> "org.apache.sling.maven.feature.launcher.Launch.getLauncherArguments()" is
> null
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11528) Provide Maven Site
[ https://issues.apache.org/jira/browse/SLING-11528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-11528. --- > Provide Maven Site > -- > > Key: SLING-11528 > URL: https://issues.apache.org/jira/browse/SLING-11528 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Feature Launcher Maven Plugin 0.1.2 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Feature Launcher Maven Plugin 0.1.4 > > > There should be a modern Maven site being generated (based on latest parent). > At the same time the parent needs to be updated and the Maven dependencies > should be cleaned up. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11685) Update feature-launcher-maven-plugin to use feature launcher assembly to launch
[ https://issues.apache.org/jira/browse/SLING-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman closed SLING-11685. --- > Update feature-launcher-maven-plugin to use feature launcher assembly to > launch > --- > > Key: SLING-11685 > URL: https://issues.apache.org/jira/browse/SLING-11685 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Feature Launcher Maven Plugin 0.1.4 > > > feature-launcher-maven-plugin fails with a NoClassDefFoundError when paired > with a featureLauncherVersion of 1.1.28 or later. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Sling Health Check Support version 1.0.10
Hi, The vote has passed with the following result : +1 (binding): Daniel Klco, Robert Munteanu, Eric Norman +1 (non binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.
Re: [VOTE] Release Apache Sling Health Check Support version 1.0.10
+1 On Sat, Nov 19, 2022 at 3:17 PM Eric Norman wrote: > Hi, > > This is intended to be the last release of this artifact with everything > marked as deprecated. > > We solved 4 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352046 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2695/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2695 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
[RESULT] [VOTE] Release Apache Apache Sling Feature Launcher Maven Plugin version 0.1.4
Hi, The vote has passed with the following result : +1 (binding): Daniel Klco, Robert Munteanu, Eric Norman +1 (non binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.
Re: [VOTE] Release Apache Sling Feature Launcher Maven Plugin version 0.1.4
+1 On Sat, Nov 19, 2022 at 1:42 PM Eric Norman wrote: > Hi, > > We solved 3 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12351070 > > There are still 2 outstanding issues that have been moved to the next > release: > https://issues.apache.org/jira/projects/SLING/versions/12352559 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2694/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2694 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
RE: [Vote] Release Sling Models Impl 1.5.4
+1 stefan
[GitHub] [sling-org-apache-sling-testing-rules] enapps-enorman commented on pull request #2: SLING-11679: Add rule for defining a custom user-agent
enapps-enorman commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1324328375 I don't have any specific concerns with this solution. I'd just point out that this solution would be only for consumers who are still using junit4. For those that have migrated to junit5, a [BeforeEachCallback](https://junit.org/junit5/docs/current/api/org.junit.jupiter.api/org/junit/jupiter/api/extension/BeforeEachCallback.html) extension would be needed instead of this new rule. However, making a fork of the sling-org-apache-sling-testing-rules project that is compatible with junit5 is a larger problem and should probably be considered separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11698) osgi-mock: Support injection of ComponentServiceObjects
[ https://issues.apache.org/jira/browse/SLING-11698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-11698. Resolution: Fixed https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/commit/5259ab9f849c6637c3422a417a4316258e94b0f2 > osgi-mock: Support injection of ComponentServiceObjects > --- > > Key: SLING-11698 > URL: https://issues.apache.org/jira/browse/SLING-11698 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing OSGi Mock 3.3.4 > > Time Spent: 1h > Remaining Estimate: 0h > > https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html > currently we are supporting for injection (field, collection field, > constructor): > * service instance > * ServiceReference instance > we should also support > [ComponentServiceObjects|https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#org.osgi.service.component.ComponentServiceObjects] > which is a combination of both. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-osgi-mock] stefanseifert merged pull request #24: SLING-11698 Full support for ComponentServiceObjects
stefanseifert merged PR #24: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #24: SLING-11698 Full support for ComponentServiceObjects
sonarcloud[bot] commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/24#issuecomment-1324272367 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock=24) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_coverage=list) [85.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #24: SLING-11698 Full support for ComponentServiceObjects
sonarcloud[bot] commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/24#issuecomment-1324263619 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock=24) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_coverage=list) [84.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #24: SLING-11698 Full support for ComponentServiceObjects
sonarcloud[bot] commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/24#issuecomment-1324255040 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock=24) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_coverage=list) [84.4% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #24: SLING-11698 Full support for ComponentServiceObjects
sonarcloud[bot] commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/24#issuecomment-1324253403 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock=24) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [14 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_coverage=list) [26.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_duplicated_lines_density=list) [9.1% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #24: SLING-11698 Full support for ComponentServiceObjects
sonarcloud[bot] commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/24#issuecomment-1324241962 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock=24) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [14 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_coverage=list) [23.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_duplicated_lines_density=list) [7.9% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=24=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637398#comment-17637398
]
Andreas Schaefer commented on SLING-11458:
--
[~radu] I don't mind fixing the issue upstream or does not throw an exception
when someone calls flush / close on an already closed writer. That said I don't
understand why the writer needs to be closed in the GraphQLServlet? This was
not happening before.
Is there a reason why the Servlet Writer needs to be closed? Otherwise we
should keep the Writer open.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-settings] klcodanr merged pull request #4: [SECURITY] Fix Temporary File Information Disclosure Vulnerability
klcodanr merged PR #4: URL: https://github.com/apache/sling-org-apache-sling-settings/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-settings] klcodanr commented on pull request #4: [SECURITY] Fix Temporary File Information Disclosure Vulnerability
klcodanr commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-settings/pull/4#issuecomment-1323989485 Please note that this project has a security policy for vulnerability disclosure: https://github.com/apache/sling-org-apache-sling-settings/security/policy This is not a security vulnerability due to being in a test class, however since it does not introduce any issues, I will merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-ide-tooling] kwin opened a new pull request, #19: SLING-11694 Embed new Tooling Support Install/Source bundles
kwin opened a new pull request, #19: URL: https://github.com/apache/sling-ide-tooling/pull/19 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11698) osgi-mock: Support injection of ComponentServiceObjects
Stefan Seifert created SLING-11698: -- Summary: osgi-mock: Support injection of ComponentServiceObjects Key: SLING-11698 URL: https://issues.apache.org/jira/browse/SLING-11698 Project: Sling Issue Type: Improvement Components: Testing Reporter: Stefan Seifert Fix For: Testing OSGi Mock 3.3.4 https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html currently we are supporting for injection (field, collection field, constructor): * service instance * ServiceReference instance we should also support [ComponentServiceObjects|https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#org.osgi.service.component.ComponentServiceObjects] which is a combination of both. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11698) osgi-mock: Support injection of ComponentServiceObjects
[ https://issues.apache.org/jira/browse/SLING-11698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned SLING-11698: -- Assignee: Stefan Seifert > osgi-mock: Support injection of ComponentServiceObjects > --- > > Key: SLING-11698 > URL: https://issues.apache.org/jira/browse/SLING-11698 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing OSGi Mock 3.3.4 > > > https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html > currently we are supporting for injection (field, collection field, > constructor): > * service instance > * ServiceReference instance > we should also support > [ComponentServiceObjects|https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#org.osgi.service.component.ComponentServiceObjects] > which is a combination of both. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11693) Remove the jar installation feature from the Tooling Support Install bundle
[ https://issues.apache.org/jira/browse/SLING-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11693. - Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-tooling-support-install/commit/8918788ac86e3c1cee6e8ea0279d40f9a832af82. > Remove the jar installation feature from the Tooling Support Install bundle > --- > > Key: SLING-11693 > URL: https://issues.apache.org/jira/browse/SLING-11693 > Project: Sling > Issue Type: Improvement > Components: Tooling >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Tooling Support Install 1.1.0 > > Time Spent: 1h > Remaining Estimate: 0h > > As the endpoint is not protected (SLING-11678) and deployment of JARs is > already supported by the Felix Web Console ReST API > (https://felix.apache.org/documentation/subprojects/apache-felix-web-console/web-console-restful-api.html#_post_requests) > the functionality to deploy bundle JARs via a POST should be removed from > the Tooling Support Install bundle. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-tooling-support-install] kwin merged pull request #5: SLING-11693 Remove the jar installation feature
kwin merged PR #5: URL: https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [Vote] Release Sling Models Impl 1.5.4
hi joerg [x] +1 Approve the release kind regards angela From: Jörg Hoh Sent: Tuesday, November 22, 2022 10:36 To: Sling Developers List Subject: Re: [Vote] Release Sling Models Impl 1.5.4 EXTERNAL: Use caution when clicking on links or opening attachments. my +1 Am Di., 22. Nov. 2022 um 10:34 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/projects/SLING/versions/12351664 > > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2696/ > > You can use this UNIX script to download the release and verify the > signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2696 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[GitHub] [sling-org-apache-sling-commons-fsclassloader] sonarcloud[bot] commented on pull request #3: SLING-11697: upgrade to sling 49
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/pull/3#issuecomment-1323862614 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-fsclassloader=3) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-fsclassloader=3=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-fsclassloader=3=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-fsclassloader=3=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-fsclassloader=3=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11697) Update parent bundle (49) to sling-commons-fsclassloader
[ https://issues.apache.org/jira/browse/SLING-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru updated SLING-11697: -- Fix Version/s: File System ClassLoader 1.0.16 > Update parent bundle (49) to sling-commons-fsclassloader > > > Key: SLING-11697 > URL: https://issues.apache.org/jira/browse/SLING-11697 > Project: Sling > Issue Type: Task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > Fix For: File System ClassLoader 1.0.16 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11697) Update parent bundle (49) to sling-commons-fsclassloader
Ashok Pelluru created SLING-11697: - Summary: Update parent bundle (49) to sling-commons-fsclassloader Key: SLING-11697 URL: https://issues.apache.org/jira/browse/SLING-11697 Project: Sling Issue Type: Task Reporter: Ashok Pelluru Assignee: Ashok Pelluru -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-commons-threaddump] sonarcloud[bot] commented on pull request #1: SLING-11695: upgrade to sling 49
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-commons-threaddump/pull/1#issuecomment-1323836187 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-threaddump=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threaddump=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threaddump=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threaddump=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threaddump=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threaddump=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threaddump=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-threaddump=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-threaddump=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-threaddump=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threaddump=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threaddump=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threaddump=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-threaddump=1=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-threaddump=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-threaddump=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11696) Update parent bundle (49) to sling.commons.threaddump
[ https://issues.apache.org/jira/browse/SLING-11696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru updated SLING-11696: -- Fix Version/s: Extensions Thread Dumper 0.2.4 > Update parent bundle (49) to sling.commons.threaddump > - > > Key: SLING-11696 > URL: https://issues.apache.org/jira/browse/SLING-11696 > Project: Sling > Issue Type: Task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > Fix For: Extensions Thread Dumper 0.2.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11696) Update parent bundle (49) to sling.commons.threaddump
Ashok Pelluru created SLING-11696: - Summary: Update parent bundle (49) to sling.commons.threaddump Key: SLING-11696 URL: https://issues.apache.org/jira/browse/SLING-11696 Project: Sling Issue Type: Task Reporter: Ashok Pelluru Assignee: Ashok Pelluru -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-adapter-annotations] sonarcloud[bot] commented on pull request #4: SLING-11695: upgrade to sling 49
sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-adapter-annotations/pull/4#issuecomment-1323812183 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-adapter-annotations=4) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter-annotations=4=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter-annotations=4=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter-annotations=4=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter-annotations=4=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter-annotations=4=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter-annotations=4=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-adapter-annotations=4=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-adapter-annotations=4=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-adapter-annotations=4=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter-annotations=4=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter-annotations=4=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter-annotations=4=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-adapter-annotations=4) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-adapter-annotations=4=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-adapter-annotations=4=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11695) Update parent bundle (49) to sling-org-apache-sling-adapter-annotations
[ https://issues.apache.org/jira/browse/SLING-11695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru updated SLING-11695: -- Fix Version/s: Adapter Annotations 2.0.2 > Update parent bundle (49) to sling-org-apache-sling-adapter-annotations > --- > > Key: SLING-11695 > URL: https://issues.apache.org/jira/browse/SLING-11695 > Project: Sling > Issue Type: Task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > Fix For: Adapter Annotations 2.0.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11695) Update parent bundle (49) to sling-org-apache-sling-adapter-annotations
Ashok Pelluru created SLING-11695: - Summary: Update parent bundle (49) to sling-org-apache-sling-adapter-annotations Key: SLING-11695 URL: https://issues.apache.org/jira/browse/SLING-11695 Project: Sling Issue Type: Task Reporter: Ashok Pelluru Assignee: Ashok Pelluru -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-rules] Kronnox opened a new pull request, #2: SLING-11679: Add rule for defining a custom user-agent
Kronnox opened a new pull request, #2: URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2 **Blocked by [sling-org-apache-sling-testing-clients #41](https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41) and release of [Apache Sling Testing Clients 3.0.18](https://issues.apache.org/jira/issues/?jql=project+%3D+SLING+AND+fixVersion+%3D+%22Apache+Sling+Testing+Clients+3.0.18%22).** Adds a custom JUnit rule for adjusting the user agent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10064) Switch code signing to use the Digicert code signing service
[ https://issues.apache.org/jira/browse/SLING-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10064. - Resolution: Fixed Fixed in https://github.com/apache/sling-ide-tooling/commit/e63413428091b776dcf914ca8c36360dbe992c4a. Signing is disabled on CI though. > Switch code signing to use the Digicert code signing service > > > Key: SLING-10064 > URL: https://issues.apache.org/jira/browse/SLING-10064 > Project: Sling > Issue Type: Task > Components: Build and Source Control, IDE >Reporter: Robert Munteanu >Assignee: Konrad Windszus >Priority: Major > Fix For: Sling Eclipse IDE 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > See https://infra.apache.org/digicert-access.html. According to infra this > should be easily integrated with the maven-jarsigner-plugin. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11680) Eclipse plugins: Switch from Jarsigning to external GPG signatures
[ https://issues.apache.org/jira/browse/SLING-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637243#comment-17637243 ] Konrad Windszus commented on SLING-11680: - A Maven profile for signing with GPG has been added in https://github.com/apache/sling-ide-tooling/commit/e63413428091b776dcf914ca8c36360dbe992c4a. > Eclipse plugins: Switch from Jarsigning to external GPG signatures > -- > > Key: SLING-11680 > URL: https://issues.apache.org/jira/browse/SLING-11680 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Since recently Eclipse P2 supports external GPG signatures: > https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fp2_pgp.html > We should consider to use that instead of the complicated/error prone > Jarsigner process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-ide-tooling] kwin merged pull request #18: SLING-10064 Sign JARs and build P2 repo in a dedicated stage
kwin merged PR #18: URL: https://github.com/apache/sling-ide-tooling/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-tooling-support-install] sonarcloud[bot] commented on pull request #5: SLING-11693 Remove the jar installation feature
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5#issuecomment-1323633256 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tooling-support-install=5) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tooling-support-install=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tooling-support-install=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tooling-support-install=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-tooling-support-install] sonarcloud[bot] commented on pull request #5: SLING-11693 Remove the jar installation feature
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5#issuecomment-1323632374 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tooling-support-install=5) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tooling-support-install=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tooling-support-install=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tooling-support-install=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-tooling-support-install] github-code-scanning[bot] commented on a diff in pull request #5: SLING-11693 Remove the jar installation feature
github-code-scanning[bot] commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5#discussion_r1029283069
##
src/main/java/org/apache/sling/tooling/support/install/impl/InstallServlet.java:
##
@@ -89,89 +81,21 @@
throws ServletException, IOException {
final String dirPath = req.getParameter(DIR);
final boolean refreshPackages =
Boolean.parseBoolean(req.getParameter(dirPath));
-boolean isMultipart = req.getContentType() != null &&
req.getContentType().toLowerCase().indexOf("multipart/form-data") > -1;
try {
-if (dirPath == null && !isMultipart) {
-logger.error("No dir parameter specified : {} and no multipart
content found", req.getParameterMap());
+if (dirPath == null) {
+logger.error("No dir parameter specified : {}",
req.getParameterMap());
Review Comment:
## Logging should not be vulnerable to injection attacks
Change this code to not log
user-controlled data. See more on https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=AYSfXtSKy7mAZ9dHGpsh=AYSfXtSKy7mAZ9dHGpsh=5;>SonarCloud
[Show more
details](https://github.com/apache/sling-org-apache-sling-tooling-support-install/security/code-scanning/24)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-tooling-support-install] sonarcloud[bot] commented on pull request #5: SLING-11693 Remove the jar installation feature
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5#issuecomment-1323624656 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tooling-support-install=5) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=VULNERABILITY) [1 Vulnerability](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tooling-support-install=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tooling-support-install=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tooling-support-install=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tooling-support-install=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tooling-support-install=5=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-11694) Embed new Tooling Support Source/Install bundles
[ https://issues.apache.org/jira/browse/SLING-11694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11694: --- Assignee: Konrad Windszus > Embed new Tooling Support Source/Install bundles > > > Key: SLING-11694 > URL: https://issues.apache.org/jira/browse/SLING-11694 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Sling Eclipse IDE 2.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11694) Embed new Tooling Support Source/Install bundles
Konrad Windszus created SLING-11694: --- Summary: Embed new Tooling Support Source/Install bundles Key: SLING-11694 URL: https://issues.apache.org/jira/browse/SLING-11694 Project: Sling Issue Type: Improvement Components: IDE Reporter: Konrad Windszus Fix For: Sling Eclipse IDE 2.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-tooling-support-install] kwin opened a new pull request, #5: SLING-11693 Remove the jar installation feature
kwin opened a new pull request, #5: URL: https://github.com/apache/sling-org-apache-sling-tooling-support-install/pull/5 This is provided by the Felix Web Console ReST endpoint already and should require authentication -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-11693) Remove the jar installation feature from the Tooling Support Install bundle
[ https://issues.apache.org/jira/browse/SLING-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11693: --- Assignee: Konrad Windszus > Remove the jar installation feature from the Tooling Support Install bundle > --- > > Key: SLING-11693 > URL: https://issues.apache.org/jira/browse/SLING-11693 > Project: Sling > Issue Type: Improvement > Components: Tooling >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Tooling Support Install 1.0.8 > > > As the endpoint is not protected (SLING-11678) and deployment of JARs is > already supported by the Felix Web Console ReST API > (https://felix.apache.org/documentation/subprojects/apache-felix-web-console/web-console-restful-api.html#_post_requests) > the functionality to deploy bundle JARs via a POST should be removed from > the Tooling Support Install bundle. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11693) Remove the jar installation feature from the Tooling Support Install bundle
Konrad Windszus created SLING-11693: --- Summary: Remove the jar installation feature from the Tooling Support Install bundle Key: SLING-11693 URL: https://issues.apache.org/jira/browse/SLING-11693 Project: Sling Issue Type: Improvement Components: Tooling Reporter: Konrad Windszus Fix For: Tooling Support Install 1.0.8 As the endpoint is not protected (SLING-11678) and deployment of JARs is already supported by the Felix Web Console ReST API (https://felix.apache.org/documentation/subprojects/apache-felix-web-console/web-console-restful-api.html#_post_requests) the functionality to deploy bundle JARs via a POST should be removed from the Tooling Support Install bundle. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11678) Protect the Tooling Support Install servlet
[ https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11678: Component/s: Tooling > Protect the Tooling Support Install servlet > --- > > Key: SLING-11678 > URL: https://issues.apache.org/jira/browse/SLING-11678 > Project: Sling > Issue Type: Improvement > Components: Tooling >Reporter: Konrad Windszus >Priority: Major > > Currently the endpoint provided by Tooling Support Endpoint doesn't require > authentication so every anonymous user can install arbitrary bundles. > I would suggest to migrate the endpoint to a [web console > plugin|https://felix.apache.org/documentation/subprojects/apache-felix-web-console/extending-the-apache-felix-web-console/providing-web-console-plugins.html] > to benefit from its built in authentication. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11680) Eclipse plugins: Switch from Jarsigning to external GPG signatures
[ https://issues.apache.org/jira/browse/SLING-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11680: --- Assignee: Konrad Windszus > Eclipse plugins: Switch from Jarsigning to external GPG signatures > -- > > Key: SLING-11680 > URL: https://issues.apache.org/jira/browse/SLING-11680 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Since recently Eclipse P2 supports external GPG signatures: > https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fp2_pgp.html > We should consider to use that instead of the complicated/error prone > Jarsigner process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11677) Sling Engine Context 'org.apache.sling' has higher ranking than 'default' context
[
https://issues.apache.org/jira/browse/SLING-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637186#comment-17637186
]
Carsten Ziegeler commented on SLING-11677:
--
Sling does not know what else is deployed, guessing does not make sense. For
example, the Sling context might be configured to a different path than the
root, or the other default context might appear later than then Sling engine
etc. There are so many different ways to configure the system, that we should
not go into this territory. We can clearly document what you need to do if you
use the default setup.
> Sling Engine Context 'org.apache.sling' has higher ranking than 'default'
> context
> -
>
> Key: SLING-11677
> URL: https://issues.apache.org/jira/browse/SLING-11677
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Attachments: HTTP-Service-Default-Context.png, Servlet-Contexts.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a servlet is registered with the OSGi HTTP Whiteboard pattern without
> the property {{osgi.http.whiteboard.context.select}} the "default" context
> helper is used
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.common.properties)
> With the Jetty Implementation from Felix in Sling this has the
> {{service.ranking}} {{Integer.MIN_VALUE}}
> (https://github.com/apache/felix-dev/blob/e7d17aca517949dd65a913f9ac5088e653a4a2dc/http/base/src/main/java/org/apache/felix/http/base/internal/whiteboard/WhiteboardManager.java#L182)
> while the one for the default Sling Main Servlet has no explicit ranking
> (i.e. 0). That leads to the fact that the Sling Main servlet always takes
> precedence as
> {quote}
> In the case of two Servlet Context Helpers with the same path, the service
> with the highest ranking is searched first for a match. In the case of a tie,
> the lowest service ID is searched first.
> {quote}
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.servletcontext)
> as both "default" and "org.apache.sling" are registered for path "".
> The Sling Main servlet context should use a lower ranking so that simple
> servlets registered via OSGI HTTP Whiteboard pattern without explicit context
> can kick in at all!
> Attached the web console of Sling Starter 12:
> !Servlet-Contexts.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11692) Remove JMX support from distribution.journal
Christian Schneider created SLING-11692: --- Summary: Remove JMX support from distribution.journal Key: SLING-11692 URL: https://issues.apache.org/jira/browse/SLING-11692 Project: Sling Issue Type: Improvement Components: Content Distribution Reporter: Christian Schneider Assignee: Christian Schneider At some point we introduced JMX support in distribution.journal. As far as I know, no one ever used this feature. Especially in the cloud it does not make a lot of sense at all. So this issue is about removing JMX support from this bundle. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11677) Sling Engine Context 'org.apache.sling' has higher ranking than 'default' context
[
https://issues.apache.org/jira/browse/SLING-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637157#comment-17637157
]
Robert Munteanu commented on SLING-11677:
-
{quote} I see you reported basically the same issue in SLING-5931. Why did you
end up with the workaround of binding to an existing context? What do you think
about the proposed
https://github.com/apache/sling-org-apache-sling-engine/pull/28?{quote}
[~kwin] - I basically poked it until it worked, I did not have a good reason
for the specific choice back then.
> Sling Engine Context 'org.apache.sling' has higher ranking than 'default'
> context
> -
>
> Key: SLING-11677
> URL: https://issues.apache.org/jira/browse/SLING-11677
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Attachments: HTTP-Service-Default-Context.png, Servlet-Contexts.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a servlet is registered with the OSGi HTTP Whiteboard pattern without
> the property {{osgi.http.whiteboard.context.select}} the "default" context
> helper is used
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.common.properties)
> With the Jetty Implementation from Felix in Sling this has the
> {{service.ranking}} {{Integer.MIN_VALUE}}
> (https://github.com/apache/felix-dev/blob/e7d17aca517949dd65a913f9ac5088e653a4a2dc/http/base/src/main/java/org/apache/felix/http/base/internal/whiteboard/WhiteboardManager.java#L182)
> while the one for the default Sling Main Servlet has no explicit ranking
> (i.e. 0). That leads to the fact that the Sling Main servlet always takes
> precedence as
> {quote}
> In the case of two Servlet Context Helpers with the same path, the service
> with the highest ranking is searched first for a match. In the case of a tie,
> the lowest service ID is searched first.
> {quote}
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.servletcontext)
> as both "default" and "org.apache.sling" are registered for path "".
> The Sling Main servlet context should use a lower ranking so that simple
> servlets registered via OSGI HTTP Whiteboard pattern without explicit context
> can kick in at all!
> Attached the web console of Sling Starter 12:
> !Servlet-Contexts.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11677) Sling Engine Context 'org.apache.sling' has higher ranking than 'default' context
[
https://issues.apache.org/jira/browse/SLING-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637127#comment-17637127
]
Konrad Windszus edited comment on SLING-11677 at 11/22/22 9:55 AM:
---
bq. Why should Sling do this?
Because Sling registers the Main servlet in a way which makes the default
context no longer usable.
bq. What if another bundle installed already a default context - how do you
avoid clashes?
I would register it only conditionally if no such service exists yet otherwise
just emit a WARN in case the default ranks lower.
was (Author: kwin):
> Why should Sling do this?
Because Sling registers the Main servlet in a way which makes the default
context no longer usable.
> What if another bundle installed already a default context - how do you avoid
> clashes?
I would register it only conditionally if no such service exists yet otherwise
just emit a WARN in case the default ranks lower.
> Sling Engine Context 'org.apache.sling' has higher ranking than 'default'
> context
> -
>
> Key: SLING-11677
> URL: https://issues.apache.org/jira/browse/SLING-11677
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Attachments: HTTP-Service-Default-Context.png, Servlet-Contexts.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a servlet is registered with the OSGi HTTP Whiteboard pattern without
> the property {{osgi.http.whiteboard.context.select}} the "default" context
> helper is used
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.common.properties)
> With the Jetty Implementation from Felix in Sling this has the
> {{service.ranking}} {{Integer.MIN_VALUE}}
> (https://github.com/apache/felix-dev/blob/e7d17aca517949dd65a913f9ac5088e653a4a2dc/http/base/src/main/java/org/apache/felix/http/base/internal/whiteboard/WhiteboardManager.java#L182)
> while the one for the default Sling Main Servlet has no explicit ranking
> (i.e. 0). That leads to the fact that the Sling Main servlet always takes
> precedence as
> {quote}
> In the case of two Servlet Context Helpers with the same path, the service
> with the highest ranking is searched first for a match. In the case of a tie,
> the lowest service ID is searched first.
> {quote}
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.servletcontext)
> as both "default" and "org.apache.sling" are registered for path "".
> The Sling Main servlet context should use a lower ranking so that simple
> servlets registered via OSGI HTTP Whiteboard pattern without explicit context
> can kick in at all!
> Attached the web console of Sling Starter 12:
> !Servlet-Contexts.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11677) Sling Engine Context 'org.apache.sling' has higher ranking than 'default' context
[
https://issues.apache.org/jira/browse/SLING-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637127#comment-17637127
]
Konrad Windszus commented on SLING-11677:
-
> Why should Sling do this?
Because Sling registers the Main servlet in a way which makes the default
context no longer usable.
> What if another bundle installed already a default context - how do you avoid
> clashes?
I would register it only conditionally if no such service exists yet otherwise
just emit a WARN in case the default ranks lower.
> Sling Engine Context 'org.apache.sling' has higher ranking than 'default'
> context
> -
>
> Key: SLING-11677
> URL: https://issues.apache.org/jira/browse/SLING-11677
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Attachments: HTTP-Service-Default-Context.png, Servlet-Contexts.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a servlet is registered with the OSGi HTTP Whiteboard pattern without
> the property {{osgi.http.whiteboard.context.select}} the "default" context
> helper is used
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.common.properties)
> With the Jetty Implementation from Felix in Sling this has the
> {{service.ranking}} {{Integer.MIN_VALUE}}
> (https://github.com/apache/felix-dev/blob/e7d17aca517949dd65a913f9ac5088e653a4a2dc/http/base/src/main/java/org/apache/felix/http/base/internal/whiteboard/WhiteboardManager.java#L182)
> while the one for the default Sling Main Servlet has no explicit ranking
> (i.e. 0). That leads to the fact that the Sling Main servlet always takes
> precedence as
> {quote}
> In the case of two Servlet Context Helpers with the same path, the service
> with the highest ranking is searched first for a match. In the case of a tie,
> the lowest service ID is searched first.
> {quote}
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.servletcontext)
> as both "default" and "org.apache.sling" are registered for path "".
> The Sling Main servlet context should use a lower ranking so that simple
> servlets registered via OSGI HTTP Whiteboard pattern without explicit context
> can kick in at all!
> Attached the web console of Sling Starter 12:
> !Servlet-Contexts.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11677) Sling Engine Context 'org.apache.sling' has higher ranking than 'default' context
[
https://issues.apache.org/jira/browse/SLING-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637124#comment-17637124
]
Carsten Ziegeler commented on SLING-11677:
--
Why should Sling do this? What if another bundle installed already a default
context - how do you avoid clashes? I think this goes beyond the scope of Sling
to sort out
> Sling Engine Context 'org.apache.sling' has higher ranking than 'default'
> context
> -
>
> Key: SLING-11677
> URL: https://issues.apache.org/jira/browse/SLING-11677
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Attachments: HTTP-Service-Default-Context.png, Servlet-Contexts.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a servlet is registered with the OSGi HTTP Whiteboard pattern without
> the property {{osgi.http.whiteboard.context.select}} the "default" context
> helper is used
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.common.properties)
> With the Jetty Implementation from Felix in Sling this has the
> {{service.ranking}} {{Integer.MIN_VALUE}}
> (https://github.com/apache/felix-dev/blob/e7d17aca517949dd65a913f9ac5088e653a4a2dc/http/base/src/main/java/org/apache/felix/http/base/internal/whiteboard/WhiteboardManager.java#L182)
> while the one for the default Sling Main Servlet has no explicit ranking
> (i.e. 0). That leads to the fact that the Sling Main servlet always takes
> precedence as
> {quote}
> In the case of two Servlet Context Helpers with the same path, the service
> with the highest ranking is searched first for a match. In the case of a tie,
> the lowest service ID is searched first.
> {quote}
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.servletcontext)
> as both "default" and "org.apache.sling" are registered for path "".
> The Sling Main servlet context should use a lower ranking so that simple
> servlets registered via OSGI HTTP Whiteboard pattern without explicit context
> can kick in at all!
> Attached the web console of Sling Starter 12:
> !Servlet-Contexts.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11677) Sling Engine Context 'org.apache.sling' has higher ranking than 'default' context
[
https://issues.apache.org/jira/browse/SLING-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637117#comment-17637117
]
Konrad Windszus commented on SLING-11677:
-
What about registering a context service with name "default" with a higher
service rank then? The goal should IMHO still be that servlets using the
default context should rank higher than Sling Main Servlet.
> Sling Engine Context 'org.apache.sling' has higher ranking than 'default'
> context
> -
>
> Key: SLING-11677
> URL: https://issues.apache.org/jira/browse/SLING-11677
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Attachments: HTTP-Service-Default-Context.png, Servlet-Contexts.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a servlet is registered with the OSGi HTTP Whiteboard pattern without
> the property {{osgi.http.whiteboard.context.select}} the "default" context
> helper is used
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.common.properties)
> With the Jetty Implementation from Felix in Sling this has the
> {{service.ranking}} {{Integer.MIN_VALUE}}
> (https://github.com/apache/felix-dev/blob/e7d17aca517949dd65a913f9ac5088e653a4a2dc/http/base/src/main/java/org/apache/felix/http/base/internal/whiteboard/WhiteboardManager.java#L182)
> while the one for the default Sling Main Servlet has no explicit ranking
> (i.e. 0). That leads to the fact that the Sling Main servlet always takes
> precedence as
> {quote}
> In the case of two Servlet Context Helpers with the same path, the service
> with the highest ranking is searched first for a match. In the case of a tie,
> the lowest service ID is searched first.
> {quote}
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.servletcontext)
> as both "default" and "org.apache.sling" are registered for path "".
> The Sling Main servlet context should use a lower ranking so that simple
> servlets registered via OSGI HTTP Whiteboard pattern without explicit context
> can kick in at all!
> Attached the web console of Sling Starter 12:
> !Servlet-Contexts.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [Vote] Release Sling Models Impl 1.5.4
my +1 Am Di., 22. Nov. 2022 um 10:34 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/projects/SLING/versions/12351664 > > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2696/ > > You can use this UNIX script to download the release and verify the > signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2696 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[Vote] Release Sling Models Impl 1.5.4
Hi, We solved 1 issue in this release:https://issues.apache.org/jira/projects/SLING/versions/12351664 Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2696/ You can use this UNIX script to download the release and verify the signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2696 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[jira] [Commented] (SLING-11677) Sling Engine Context 'org.apache.sling' has higher ranking than 'default' context
[
https://issues.apache.org/jira/browse/SLING-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637107#comment-17637107
]
Carsten Ziegeler commented on SLING-11677:
--
For the record, the upcoming Apache Felix implementation will no longer
register the default context as an OSGi service (see FELIX-6584)
> Sling Engine Context 'org.apache.sling' has higher ranking than 'default'
> context
> -
>
> Key: SLING-11677
> URL: https://issues.apache.org/jira/browse/SLING-11677
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Attachments: HTTP-Service-Default-Context.png, Servlet-Contexts.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a servlet is registered with the OSGi HTTP Whiteboard pattern without
> the property {{osgi.http.whiteboard.context.select}} the "default" context
> helper is used
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.common.properties)
> With the Jetty Implementation from Felix in Sling this has the
> {{service.ranking}} {{Integer.MIN_VALUE}}
> (https://github.com/apache/felix-dev/blob/e7d17aca517949dd65a913f9ac5088e653a4a2dc/http/base/src/main/java/org/apache/felix/http/base/internal/whiteboard/WhiteboardManager.java#L182)
> while the one for the default Sling Main Servlet has no explicit ranking
> (i.e. 0). That leads to the fact that the Sling Main servlet always takes
> precedence as
> {quote}
> In the case of two Servlet Context Helpers with the same path, the service
> with the highest ranking is searched first for a match. In the case of a tie,
> the lowest service ID is searched first.
> {quote}
> (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#service.http.whiteboard.servletcontext)
> as both "default" and "org.apache.sling" are registered for path "".
> The Sling Main servlet context should use a lower ranking so that simple
> servlets registered via OSGI HTTP Whiteboard pattern without explicit context
> can kick in at all!
> Attached the web console of Sling Starter 12:
> !Servlet-Contexts.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-9674) Allow SlingHttpServletRequest based adaptations for ChildResourceInjector
[
https://issues.apache.org/jira/browse/SLING-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-9674:
-
Fix Version/s: (was: Models Implementation 1.5.4)
> Allow SlingHttpServletRequest based adaptations for ChildResourceInjector
> -
>
> Key: SLING-9674
> URL: https://issues.apache.org/jira/browse/SLING-9674
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Reporter: Konrad Windszus
>Priority: Major
>
> The {{ChildResourceInjector}} always returns one/multiple Resource objects
> which makes it impossible to use those return values with another Sling Model
> requiring the adaptable {{SlingHttpServletRequest}}.
> A solution from ACS Commons introduced
> https://adobe-consulting-services.github.io/acs-aem-commons/features/sling-model-injectors/child-resource-from-request/index.html
> in https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1920.
> There should be a solution built into Sling which allows for easier Sling
> Model aggregation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-9036) Sling Models: SlingHttpServletRequestWrapper.adaptTo() unwraps before adapting
[
https://issues.apache.org/jira/browse/SLING-9036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-9036:
-
Fix Version/s: (was: Models Implementation 1.5.4)
> Sling Models: SlingHttpServletRequestWrapper.adaptTo() unwraps before adapting
> --
>
> Key: SLING-9036
> URL: https://issues.apache.org/jira/browse/SLING-9036
> Project: Sling
> Issue Type: New Feature
> Components: Sling Models
>Reporter: Henry Kuijpers
>Priority: Major
>
> Sling Model:
> {code:java}
> @Model(adaptables = SlingHttpServletRequest.class, adapters =
> MySlingModel.class)
> class MySlingModel {
> @Inject
> public MySlingModel(@Self SlingHttpServletRequest req) {
> logger.log(req.getResourceBundle().getClass().getName());
> }
> }
> {code}
> Calling code:
> {code:java}
> // req obtained via JSP/HTL
> final SlingHttpServletRequest myWrappedReq = new
> SlingHttpServletRequestWrapper(req) {
> @Override
> public ResourceBundle getResourceBundle() {
> return new MyCustomResourceBundle();
> }
> };
>
> final MySlingModel myModel = myWrappedReq.adaptTo(MySlingModel.class);
> {code}
> I would expect the log file to contain "MyCustomResourceBundle". Instead it
> contains "NullResourceBundle".
> This is because the request is being "unwrapped" when doing the adaptTo()
> call: It keeps on delegating to the wrapped request. This should not have
> happened, i.e. how can we otherwise overwrite (parts of) requests and
> resources?
> See also:
> [https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/wrappers/SlingHttpServletRequestWrapper.java#L147]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
