[VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10

2023-05-03 Thread Daniel Klco
Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12353195
https://issues.apache.org/jira/projects/SLING/versions/12353051

There are still some outstanding issues:
https://issues.apache.org/jira/projects/SLING/versions/12344634
https://issues.apache.org/jira/projects/SLING/versions/12353196

Staging repositories:
https://repository.apache.org/content/repositories/orgapachesling-2740/
https://repository.apache.org/content/repositories/orgapachesling-2741/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2740 /tmp/sling-staging
sh check_staged_release.sh 2741 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


[jira] [Updated] (SLING-11316) Update sling.event.api to parent 47

2023-05-03 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-11316:
-
Fix Version/s: Event API 1.0.2
   (was: Event API 1.1.0)

> Update sling.event.api to parent 47
> ---
>
> Key: SLING-11316
> URL: https://issues.apache.org/jira/browse/SLING-11316
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ashok Pelluru
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Event API 1.0.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+

2023-05-03 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-9664:

Fix Version/s: Event 4.3.12
   (was: Event 4.3.10)

> org.apache.sling.event.jobs package not present in javadoc for sling10+
> ---
>
> Key: SLING-9664
> URL: https://issues.apache.org/jira/browse/SLING-9664
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Reporter: Joerg Hoh
>Priority: Major
> Fix For: Event 4.3.12
>
>
> While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs 
> package(s), they went missing with the sling10 javadoc [2] and subsequent 
> versions.
> [1] https://sling.apache.org/apidocs/sling9/index.html
> [2] https://sling.apache.org/apidocs/sling10/index.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (SLING-11831) Allow setting job properties for custom job state

2023-05-03 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-11831.
--
Resolution: Fixed

> Allow setting job properties for custom job state
> -
>
> Key: SLING-11831
> URL: https://issues.apache.org/jira/browse/SLING-11831
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.3.8
>Reporter: Andrew Khoury
>Assignee: Dan Klco
>Priority: Major
> Fix For: Event 4.3.10, Event API 1.0.2
>
>
> The 
> [JobExecutionContext|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28]
>  currently allows updating Job progress info and the progress log but it 
> doesn't allow storing of custom properties.  The reason we would want to 
> support custom properties is to allow storing resume information.
> For example, let's say we have a job where we are moving multiple resources 
> around in a clustered environment with many sling instances pointing to the 
> same JCR repository (for example Oak MongoMK).  If the instance that is 
> running the move job crashes in the middle of the job execution we would want 
> some information stored so the job can be resumed on another node.
> To solve this issue, we can introduce a setProperty method to the 
> [JobExecutionContext.|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28]
> This method would allow us to save some state information for use in case the 
> job is resumed on another node.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-11422) Stop embedding the event.api package in the event bundle

2023-05-03 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-11422:
-
Fix Version/s: Event 4.3.12
   (was: Event 4.3.10)

> Stop embedding the event.api package in the event bundle
> 
>
> Key: SLING-11422
> URL: https://issues.apache.org/jira/browse/SLING-11422
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Event 4.3.12
>
>
> As discussed in SLING-9664, deploying the Sling Event and Event API bundles 
> separately would be more in line with how we deploy bundles and also fix the 
> Javadoc generation.
> We should make this a minor version bump for the event bundle, to make it 
> clear that deployers need to adapt. Probably the baselining mechanism will 
> complain, but it's something we can ignore for the release.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-11831) Allow setting job properties for custom job state

2023-05-03 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-11831:
-
Fix Version/s: Event 4.3.10

> Allow setting job properties for custom job state
> -
>
> Key: SLING-11831
> URL: https://issues.apache.org/jira/browse/SLING-11831
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.3.8
>Reporter: Andrew Khoury
>Assignee: Dan Klco
>Priority: Major
> Fix For: Event 4.3.10, Event API 1.0.2
>
>
> The 
> [JobExecutionContext|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28]
>  currently allows updating Job progress info and the progress log but it 
> doesn't allow storing of custom properties.  The reason we would want to 
> support custom properties is to allow storing resume information.
> For example, let's say we have a job where we are moving multiple resources 
> around in a clustered environment with many sling instances pointing to the 
> same JCR repository (for example Oak MongoMK).  If the instance that is 
> running the move job crashes in the middle of the job execution we would want 
> some information stored so the job can be resumed on another node.
> To solve this issue, we can introduce a setProperty method to the 
> [JobExecutionContext.|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28]
> This method would allow us to save some state information for use in case the 
> job is resumed on another node.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-11831) Allow setting job properties for custom job state

2023-05-03 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-11831:
-
Fix Version/s: Event API 1.0.2

> Allow setting job properties for custom job state
> -
>
> Key: SLING-11831
> URL: https://issues.apache.org/jira/browse/SLING-11831
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.3.8
>Reporter: Andrew Khoury
>Assignee: Dan Klco
>Priority: Major
> Fix For: Event API 1.0.2
>
>
> The 
> [JobExecutionContext|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28]
>  currently allows updating Job progress info and the progress log but it 
> doesn't allow storing of custom properties.  The reason we would want to 
> support custom properties is to allow storing resume information.
> For example, let's say we have a job where we are moving multiple resources 
> around in a clustered environment with many sling instances pointing to the 
> same JCR repository (for example Oak MongoMK).  If the instance that is 
> running the move job crashes in the middle of the job execution we would want 
> some information stored so the job can be resumed on another node.
> To solve this issue, we can introduce a setProperty method to the 
> [JobExecutionContext.|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28]
> This method would allow us to save some state information for use in case the 
> job is resumed on another node.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [sling-org-apache-sling-event] klcodanr merged pull request #26: SLING-11831 - Allow setting job properties for custom job state

2023-05-03 Thread via GitHub


klcodanr merged PR #26:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/26


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-event-api] sonarcloud[bot] commented on pull request #1: SLING-5884 : deprecate job queries, introduce query-free JobManager2,…

2023-05-03 Thread via GitHub


sonarcloud[bot] commented on PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-event-api/pull/1#issuecomment-1533270597

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event-api=1)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=CODE_SMELL)
 
[![B](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B-16px.png
 
'B')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=CODE_SMELL)
 [6 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=1=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-event-api] klcodanr merged pull request #4: SLING-11831 - Update API to use @NotNull annotations

2023-05-03 Thread via GitHub


klcodanr merged PR #4:
URL: https://github.com/apache/sling-org-apache-sling-event-api/pull/4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #31: SLING-11558 part1: remove the LocationIterator

2023-05-03 Thread via GitHub


sonarcloud[bot] commented on PR #31:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/31#issuecomment-1533024702

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=31)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=31=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=31=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=31=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=CODE_SMELL)
   
   
[![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png
 
'100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2023-05-03 Thread via GitHub


sonarcloud[bot] commented on PR #7:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-1533018201

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=7)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
   
   
[![70.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'70.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list)
 [70.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (SLING-11849) Create osgiContext#unregisterService() for easy unregistering of services

2023-05-03 Thread Stefan Seifert (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718858#comment-17718858
 ] 

Stefan Seifert commented on SLING-11849:


you're right - it's more complex than just calling 
context.bundleContext().registerService - all the static methods in 
MockOsgi.register* also do not return the service registration, so it's really 
not that easy to get hold of the service registration. i will think about a 
long-term solution as part of a bigger refactoring how components/services are 
handled in OSGi mocks, that, along with other improvements, should make it 
possible to easier get the service registrations.

> Create osgiContext#unregisterService() for easy unregistering of services
> -
>
> Key: SLING-11849
> URL: https://issues.apache.org/jira/browse/SLING-11849
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing OSGi Mock 3.3.6
>Reporter: Henry Kuijpers
>Priority: Major
>
> Since we can do:
> {code:java}
> this.underTest = context.registerInjectActivateService(Test.class);
> {code}
> it would be very useful if we can also do:
> {code:java}
> context.unregisterService(this.underTest);
> {code}
> for example.
> It would be very convenient to do this, since the OSGi Mock API is easy and 
> simple to write and to be able to unregister services, it would be needed to 
> have a ServiceRegistration and also a ServiceReference to be able 
> to call .unregister() on it
> If we add this method, then all this logic can be put in this method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)