[jira] [Resolved] (SLING-10674) Publish/Unpubilsh button not working
[ https://issues.apache.org/jira/browse/SLING-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Raynor resolved SLING-10674. -- Fix Version/s: App CMS 1.1.0 Resolution: Not A Problem This is for future use in author or publish mode, not a bug, to be tested again later. > Publish/Unpubilsh button not working > > > Key: SLING-10674 > URL: https://issues.apache.org/jira/browse/SLING-10674 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.0.2 >Reporter: James Raynor >Priority: Major > Fix For: App CMS 1.1.0 > > Attachments: 1.png > > > Steps to reproduce: > 1.Run SlingCMS, visit the page > [http://localhost:8080/apache/sling-apache-org/index.html] > then go to > [http://localhost:8080/cms/site/content.html/content/apache/sling-apache-org|https://localhost:9019/cms/site/content.html/content/apache/sling-apache-org] > 2.Click Unpubilsh button and then check the page: > [http://localhost:8080/apache/sling-apache-org/index.html] > It is still accessible, the correct result should be inaccessible. > > Add a test page, then click publish button, go to > [http://localhost:8080/bin/browser.html] > There are two duplicate 'published' attributes, 'published' and > 'sling:published'. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11860) OsgiServiceUtil#activateDeactivate may invoke the wrong activate method
Eric Norman created SLING-11860:
---
Summary: OsgiServiceUtil#activateDeactivate may invoke the wrong
activate method
Key: SLING-11860
URL: https://issues.apache.org/jira/browse/SLING-11860
Project: Sling
Issue Type: Bug
Components: Testing
Reporter: Eric Norman
Assignee: Eric Norman
Fix For: Testing OSGi Mock 3.3.8
The scenario where this happens is when the parent class has an activate(Map)
method and the subclass has an activate(Config) method.
When the context.registerInjectActivateService(..) call is invoked, it finds
the activate(Map) method from the parent class and invokes it and then returns.
Expected:
The activate(Config) method from the subclass should have been the activate
method that was invoked.
For example:
{code:java}
public class ParentComponent {
protected void activate(Map props) {
// this should not be invoked when activating SubComponent
}
}
@Designate(ocd=SubComponent.Config.class)
public class SubComponent extends ParentComponent {
@ObjectClassDefinition(name = "SubComponent Config")
public @interface Config {
@AttributeDefinition(name = "Prop One")
boolean prop1() default true;
}
@Activate
protected void activate(Config cfg) {
// should be invoked when activating
}
} {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #167: SLING-11750 : Support the new repoinit statements
sonarcloud[bot] commented on PR #167: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/167#issuecomment-1535229665 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=167) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=167=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=167=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=167=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=167=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #163: [draft] remove toobig check
sonarcloud[bot] commented on PR #163: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/163#issuecomment-1535228850 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=163) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1535172102 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #137: Bump gson from 2.8.6 to 2.8.9
sonarcloud[bot] commented on PR #137: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/137#issuecomment-1535119536 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=137) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=137=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=137=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=137=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-xing-login] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1535119647 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-xing-login=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1535119428 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-xing-oauth=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_duplicated_lines_density=list) [7.3% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11844) Index definitions must not be extracted from empty nodes
[ https://issues.apache.org/jira/browse/SLING-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11844: Fix Version/s: Content-Package to Feature Model Converter 1.3.4 (was: Content-Package to Feature Model Converter 1.3.2) > Index definitions must not be extracted from empty nodes > > > Key: SLING-11844 > URL: https://issues.apache.org/jira/browse/SLING-11844 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Robert Munteanu >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > Under certain conditions, extracted index definitions will contain empty > nodes. These are useless and should be skipped. They can also confuse tooling > processing the index definitions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11778) Test that the feature models generated by the CPConverter are deployable
[ https://issues.apache.org/jira/browse/SLING-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11778: Fix Version/s: Content-Package to Feature Model Converter 1.3.4 (was: Content-Package to Feature Model Converter 1.3.2) > Test that the feature models generated by the CPConverter are deployable > > > Key: SLING-11778 > URL: https://issues.apache.org/jira/browse/SLING-11778 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Robert Munteanu >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > We have a set of tests in the CPConverter that validate what the output looks > like. I have a feeling that we would be better off if we would validate that > the feature models and associated artifacts can actually be installed. > We can do this by setting up a Sling application that contains the > prerequisites ( Oak/FileVault mostly ) and starting that application with the > feature models generated. The application can be parameterised to use > different FileVault versions, so we are certain that we don't run into > problems like SLING-11777 . > We can then validate that > - all bundles are started > - all content packages are installed > I think this would cover a gap that we have regarding validating the > correctness of the artifacts that we generate with the CPConverter. > We don't have to start with a lot of tests, but having 1-3 content packages > with good coverages validated as "installable" would IMO be a great step > forward. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.2
Hi, We solved 7 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12352904 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2742/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2742 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Updated] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11750: Fix Version/s: Content-Package to Feature Model Converter 1.3.4 (was: Content-Package to Feature Model Converter 1.3.2) > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #167: SLING-11750 : Support the new repoinit statements
sonarcloud[bot] commented on PR #167: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/167#issuecomment-1535085398 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=167) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=167=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=167=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=167=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=167=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=167=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event-api] sonarcloud[bot] commented on pull request #1: SLING-5884 : deprecate job queries, introduce query-free JobManager2,…
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-event-api/pull/1#issuecomment-1535079467 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event-api=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=1=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-6995) Sling 6 is not deploying in wildfly 10.1.0
[ https://issues.apache.org/jira/browse/SLING-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-6995. - Resolution: Won't Fix > Sling 6 is not deploying in wildfly 10.1.0 > -- > > Key: SLING-6995 > URL: https://issues.apache.org/jira/browse/SLING-6995 > Project: Sling > Issue Type: Bug > Components: Launchpad > Environment: Windows 10,Wildfly10.1.0-final,Java 8 >Reporter: Shivanand >Priority: Major > > Hi, > > When we tried to deploy org.apache.sling.launchpad-6.war from Apache Download > Mirrors in Wildfly-10.1.0.Final getting the following exception on server > startup. > > 017-04-18 16:25:16,173 ERROR [io.undertow.servlet] (ServerService Thread Pool > -- 58) ERROR: Error parsing system bundle export statement: > org.osgi.framework; version=1.5, org.osgi.framework.hooks.service; > version=1.0, org.osgi.framework.launch; version=1.0, > org.osgi.service.packageadmin; version=1.2, org.osgi.service.startlevel; > version=1.1, org.osgi.service.url; version=1.0, > org.osgi.util.tracker;version="1.4", > org.apache.sling.launchpad.api;version=1.0.0, > ,javax.servlet;javax.servlet.http;javax.servlet.resources; version=3.1 > (java.lang.IllegalArgumentException: No paths specified in header: ): > java.lang.IllegalArgumentException: No paths specified in header: > at > org.apache.felix.framework.util.manifestparser.ManifestParser.parseStandardHeaderClause(ManifestParser.java:1432) > at > org.apache.felix.framework.util.manifestparser.ManifestParser.parseStandardHeader(ManifestParser.java:1400) > at > org.apache.felix.framework.util.manifestparser.ManifestParser.(ManifestParser.java:162) > at > org.apache.felix.framework.ExtensionManager.(ExtensionManager.java:193) > at org.apache.felix.framework.Felix.(Felix.java:374) > at org.apache.sling.launchpad.base.impl.SlingFelix.(SlingFelix.java:39) > at org.apache.sling.launchpad.base.impl.Sling.(Sling.java:235) > at > org.apache.sling.launchpad.base.webapp.SlingBridge.(SlingBridge.java:41) > at > org.apache.sling.launchpad.base.webapp.SlingServletDelegate.init(SlingServletDelegate.java:203) > at javax.servlet.GenericServlet.init(GenericServlet.java:244) > at > org.apache.sling.launchpad.webapp.SlingServlet.startSling(SlingServlet.java:358) > at > org.apache.sling.launchpad.webapp.SlingServlet.startSling(SlingServlet.java:300) > at org.apache.sling.launchpad.webapp.SlingServlet.init(SlingServlet.java:111) > at javax.servlet.GenericServlet.init(GenericServlet.java:244) > at > io.undertow.servlet.core.LifecyleInterceptorInvocation.proceed(LifecyleInterceptorInvocation.java:117) > at > org.wildfly.extension.undertow.security.RunAsLifecycleInterceptor.init(RunAsLifecycleInterceptor.java:78) > at > io.undertow.servlet.core.LifecyleInterceptorInvocation.proceed(LifecyleInterceptorInvocation.java:103) > at > io.undertow.servlet.core.ManagedServlet$DefaultInstanceStrategy.start(ManagedServlet.java:250) > at > io.undertow.servlet.core.ManagedServlet.createServlet(ManagedServlet.java:133) > at > io.undertow.servlet.core.DeploymentManagerImpl$2.call(DeploymentManagerImpl.java:546) > at > io.undertow.servlet.core.DeploymentManagerImpl$2.call(DeploymentManagerImpl.java:517) > at > io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:42) > at > io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43) > at > io.undertow.servlet.api.LegacyThreadSetupActionWrapper$1.call(LegacyThreadSetupActionWrapper.java:44) > at > io.undertow.servlet.api.LegacyThreadSetupActionWrapper$1.call(LegacyThreadSetupActionWrapper.java:44) > at > io.undertow.servlet.api.LegacyThreadSetupActionWrapper$1.call(LegacyThreadSetupActionWrapper.java:44) > at > io.undertow.servlet.api.LegacyThreadSetupActionWrapper$1.call(LegacyThreadSetupActionWrapper.java:44) > at > io.undertow.servlet.api.LegacyThreadSetupActionWrapper$1.call(LegacyThreadSetupActionWrapper.java:44) > at > io.undertow.servlet.core.DeploymentManagerImpl.start(DeploymentManagerImpl.java:559) > at > org.wildfly.extension.undertow.deployment.UndertowDeploymentService.startContext(UndertowDeploymentService.java:101) > at > org.wildfly.extension.undertow.deployment.UndertowDeploymentService$1.run(UndertowDeploymentService.java:82) > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > at org.jboss.threads.JBossThread.run(JBossThread.java:320) -- This message was sent by
[jira] [Resolved] (SLING-4301) Support user.jcr.session.logout option for the jcr resource provider
[
https://issues.apache.org/jira/browse/SLING-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-4301.
-
Resolution: Won't Fix
> Support user.jcr.session.logout option for the jcr resource provider
>
>
> Key: SLING-4301
> URL: https://issues.apache.org/jira/browse/SLING-4301
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Reporter: Alexander Klimetschek
>Priority: Major
> Attachments: SLING-4301.patch
>
>
> Add a new AuthenticationInfo option {{user.jcr.session.logout}} that if set
> to true would automatically close the session passed via {{user.jcr.session}}
> at the end of the request.
> Purpose: As discussed on the
> [list|http://sling.markmail.org/thread/ceshw42z63r4bu7i], when using
> [user.jcr.session|http://sling.apache.org/apidocs/sling6/org/apache/sling/jcr/resource/JcrResourceConstants.html#AUTHENTICATION_INFO_SESSION]
> to pass a session created by an AuthenticationHandler itself, this is
> currently never closed (since the original use case for it comes from
> somewhere else where this wasn't required). The only way to use it from an
> AuthenticationHandler is to also implement a ServletFilter that tracks it and
> closes the session "manually" at the end of the request, which is bad since
> this would create another servlet filter for each authentication handler that
> wishes to use this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-5868) API to define and retrieve login path with along with authentication requirements
[ https://issues.apache.org/jira/browse/SLING-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-5868. - Resolution: Won't Fix > API to define and retrieve login path with along with authentication > requirements > - > > Key: SLING-5868 > URL: https://issues.apache.org/jira/browse/SLING-5868 > Project: Sling > Issue Type: Sub-task > Components: Authentication >Reporter: Angela Schreiber >Priority: Major > > When defining parts of the hierarchy that require authentication it would be > handy to also be able to defined an optional, individual login path for that > particular subtree. > This functionality could additionally come with an API that would allow to > identify the login path that corresponds to a given sling request. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-5016) SlingWebConsoleSecurityProvider2 does not work if ResourceResolver cannot be adapted to Session
[
https://issues.apache.org/jira/browse/SLING-5016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-5016.
-
Resolution: Won't Fix
> SlingWebConsoleSecurityProvider2 does not work if ResourceResolver cannot be
> adapted to Session
> ---
>
> Key: SLING-5016
> URL: https://issues.apache.org/jira/browse/SLING-5016
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Web Console Security Provider 1.1.6
>Reporter: Konrad Windszus
>Priority: Major
>
> After the deployment of several configurations (affecting for example the JCR
> Resource Resolver Factory) we ran into the issue that the
> {{SlingWebConsoleSecurityProvider2}} is active but it always returned a 401.
> The according log from the {{SlingAuthenticator}} for this failed
> authentication to the web console looks like this
> {code}
> 11.09.2015 09:52:14.371 *DEBUG* [qtp851550369-82]
> org.apache.sling.auth.core.impl.SlingAuthenticator doHandleSecurity: Trying
> to get a session for admin
> 11.09.2015 09:52:14.372 *DEBUG* [qtp851550369-82]
> org.apache.sling.auth.core.impl.SlingAuthenticator setAttributes:
> ResourceResolver stored as request attribute: user=admin
> 11.09.2015 09:52:14.372 *DEBUG* [qtp851550369-82]
> org.apache.sling.auth.core.impl.SlingAuthenticator login: requesting
> authentication using handler:
> com.adobe.cq.creativecloud.cloudims.impl.auth.CloudIMSAuthenticationHandler@47a78ad3
> 11.09.2015 09:52:14.372 *DEBUG* [qtp851550369-82]
> org.apache.sling.auth.core.impl.SlingAuthenticator login: requesting
> authentication using handler:
> com.day.cq.auth.impl.LoginSelectorHandler@76a68a34
> 11.09.2015 09:52:14.372 *DEBUG* [qtp851550369-82]
> org.apache.sling.auth.core.impl.SlingAuthenticator login: requesting
> authentication using handler:
> com.adobe.granite.auth.cert.impl.ClientCertAuthHandler@7fad0b6d
> 11.09.2015 09:52:14.372 *DEBUG* [qtp851550369-82]
> org.apache.sling.auth.core.impl.SlingAuthenticator login: requesting
> authentication using handler: Token Authentication Handler
> 11.09.2015 09:52:14.372 *DEBUG* [qtp851550369-82]
> org.apache.sling.auth.core.impl.SlingAuthenticator login: requesting
> authentication using handler:
> com.adobe.cq.dam.s7imaging.impl.auth.MemoryTokenAuthHandler@4bdc6939
> 11.09.2015 09:52:14.878 *DEBUG* [qtp851550369-81]
> org.apache.sling.auth.core.impl.SlingAuthenticator doHandleSecurity: Trying
> to get a session for admin
> {code}
> From these logs and from looking at the sources I assume the following
> happens here:
> # {{SlingWebConsoleSecurityProvider2.authenticate}} calls
> {{Authenticator.handleSecurity}} (which returns true)
> # {{SlingWebConsoleSecurityProvider2.authenticate}} tries to adapt resource
> resolver to session -> this fails and therefore {{Authenticator.login}} is
> called
> IMHO the SlingWebConsoleSecurityProvider2 should only be registered if the
> adaptation from resource resolver to session works. I am not sure under which
> circumstances this may fail, but if this fails the whole security provider
> should be inactive!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-5675) Logout only called if AuthenticationHandler is registered to "/"
[
https://issues.apache.org/jira/browse/SLING-5675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-5675.
-
Resolution: Won't Fix
> Logout only called if AuthenticationHandler is registered to "/"
>
>
> Key: SLING-5675
> URL: https://issues.apache.org/jira/browse/SLING-5675
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
>Affects Versions: Auth Core 1.3.14
>Reporter: Lars Krapf
>Priority: Major
> Labels: authentication
>
> In {{SlingAuthenticator.logout()}} only the AuthenticationHandlers which are
> registered on paths which are roots of
> {{SlingAuthenticator.getHandlerSelectionPath()}} are selected.
> This path should either be taken from the servlet path, or will be read from
> the {{Authenticator.LOGIN_RESOURCE}} request attribute _if it is present_.
> Now, in {{LogoutServlet.service()}} the LOGIN_RESOURCE is _always_ set to
> it's default value ("/") by calling {{AuthUtil.setLoginResourceAttribute()}}.
> As a result, {{dropCredentials()}} will only be called on authentication
> handlers which are registered to "/".
> My expectation is that the selection of logout handlers should be independent
> of their registration paths, in order to allow a POST to
> {{/system/sling/logout}} have *all* registered handlers drop credentials.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-3961) Rhino on Windows: UTF-8 encoded source file causes script execution failure
[
https://issues.apache.org/jira/browse/SLING-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-3961.
-
Resolution: Won't Fix
> Rhino on Windows: UTF-8 encoded source file causes script execution failure
> ---
>
> Key: SLING-3961
> URL: https://issues.apache.org/jira/browse/SLING-3961
> Project: Sling
> Issue Type: Bug
>Affects Versions: Scripting JavaScript 2.0.14
> Environment: Adobe AEM 6.0 with Service Pack 1 on Windows machine
>Reporter: David Herges
>Priority: Major
> Labels: encoding, javascript, rhino
>
> JavaScript execution crashes on Windows machines for .js source files with
> certain UTF-8 characters, e.g. "Í". We get an EvaluatorException with message
> _Property "Ã?" already defined in this object literal."_. It looks like the
> encoding of the source files causes the Rhino to go bust.
> Source file is UTF-8, no bom:
> https://github.com/pid/speakingurl/blob/v0.12.0/lib/index.js#L214
> *Note that line 214 causes the error, but lines 201-213 seem to be ok!*
> Here's where the execution stops:
> http://grepcode.com/file/repo1.maven.org$maven2@org.apache.sling$org.apache.sling.scripting.javascript@2.0.14@org$apache$sling$scripting$javascript$internal$RhinoJavaScriptEngine.java#116
> We were able to work around it by setting start-up parameters for Adobe AEM,
> but only by setting both {{-Xdebug}} and {{-Dfile.encoding=UTF-8}}:
> {code}
> java -Xdebug -Dfile.encoding=UTF-8 .. -jar AEM_6.0_Quickstart-author-p4502.jar
> {code}
> If needed, I can try to figure out more detailed system configuration
> (Windows version, Java version). We have the same error on at least three
> Windows machines (same config, same source on OS X is fine).
>
> System Information
> OSGi Bundle:
> Apache Sling Scripting JavaScript Supportorg.apache.sling.scripting.javascript
> Symbolic Name org.apache.sling.scripting.javascript
> Version 2.0.14
> OSGi configurations:
> Persistent Identity (PID):
> org.apache.sling.scripting.java.impl.JavaScriptEngineFactory
> Configuration Binding: Apache Sling Scripting Java Support
> (org.apache.sling.scripting.java), Version 2.0.11.R1607999
> {code}
> java.compilerSourceVM=auto
> java.compilerTargetVM=auto
> java.classdebuginfo=true
> java.javaEncoding=UTF-8
> {code}
> Persistent Identity (PID)
> org.apache.sling.scripting.javascript.internal.RhinoJavaScriptEngineFactory
> Configuration Binding Unbound or new configuration
> {code}
> org.apache.sling.scripting.javascript.rhino.optLevel=-1
> {code}
> Full Stack Trace:
> {code}
> 22.09.2014 13:09:53.533 *ERROR* [0:0:0:0:0:0:0:1 [1411384191394] GET
> /content/procato/de_de/login.html HTTP/1.1]
> com.day.cq.wcm.core.impl.WCMDeveloperModeFilter Error during includ
> e of SlingRequestPathInfo:
> path='/content/procato/de_de/login/jcr:content/quicksearch',
> selectorString='null', extension='html', suffix='null'
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> io.sightly.java.api.SightlyUseException: javax.script.ScriptException:
> Failure running script /apps/myapp/components/quicksearch/quicksearch.html:
> Property "Ã?" already defined in this object literal.
> (/apps/myapp/components/quicksearch/quicksearch.html#222)
> at
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:481)
> at
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:511)
> at
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:45)
>at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:64)
> at
> com.day.cq.wcm.core.impl.WCMDeveloperModeFilter.doFilterWithErrorHandling(WCMDeveloperModeFilter.java:150)
> at
> com.day.cq.wcm.core.impl.WCMDeveloperModeFilter.doFilter(WCMDeveloperModeFilter.java:118)
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:60)
> at
> com.day.cq.wcm.core.impl.WCMDebugFilter.doFilterWithErrorHandling(WCMDebugFilter.java:182)
> at
> com.day.cq.wcm.core.impl.WCMDebugFilter.doFilter(WCMDebugFilter.java:149)
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:60)
> at
> com.cognifide.cq.includefilter.DynamicIncludeFilter.doFilter(DynamicIncludeFilter.java:81)
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:60)
> at
> com.day.cq.wcm.core.impl.WCMComponentFilter.doFilter(WCMComponentFilter.java:252)
> at
>
[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on pull request #167: SLING-11750 : Support the new repoinit statements
anchela commented on PR #167: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/167#issuecomment-1534952783 @kwin , afaik a conversion of repoinit-statements may occur in the following scenarios: - resource-based ac setup for a service user that needs to be converted to principal-based - service user creation without a path that allows for principal-based ac setup there is no conversion (thus a simple identical repoinit output) for - prinicpal-based ac setup - service users that have / can have principal-based ac setup - any other repo-init statements from what i can see none of the new statements falls into the category that would require a conversion and thus they should be added 1:1. hope that makes sense and helps illustrating my train of thought for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11750: --- Assignee: Angela Schreiber > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10
> On 4. May 2023, at 09:53, Stefan Seifert > wrote: > > i've two remarks on this release: > > a) on both modules org.jetbrains:annotations was added with compile scope - > should be provided. although not a problem for the bundle in OSGi runtime, it > should be fixed. i would propose making a new release for it, esp. > considering that the API bundle is released very rarely. Maybe we can prevent that a config of https://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html#banned-dependencies in the Sling parent. I think there are potentially more candidates for that (OSGi annotation dependencies). WDYT? > > b) cosmetic: the bnd.bnd. in the event module contains an explicit reference > to sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid > the redundancy and define the actual version only in the POM, otherwise it > might be forgotten to update in in both places in future updates. i think > there are possibilities to express this via expressions. this could be done > in a follow-up release. > > stefan > >> -Original Message- >> From: Daniel Klco >> Sent: Wednesday, May 3, 2023 10:04 PM >> To: dev@sling.apache.org >> Subject: [VOTE] Release Apache Sling Event API version 1.0.2 and Event >> 4.3.10 >> >> Hi, >> >> We solved 2 issues in this release: >> https://issues.apache.org/jira/projects/SLING/versions/12353195 >> https://issues.apache.org/jira/projects/SLING/versions/12353051 >> >> There are still some outstanding issues: >> https://issues.apache.org/jira/projects/SLING/versions/12344634 >> https://issues.apache.org/jira/projects/SLING/versions/12353196 >> >> Staging repositories: >> https://repository.apache.org/content/repositories/orgapachesling-2740/ >> https://repository.apache.org/content/repositories/orgapachesling-2741/ >> >> You can use this UNIX script to download the release and verify the >> signatures: >> https://gitbox.apache.org/repos/asf?p=sling-tooling- >> release.git;a=blob;f=check_staged_release.sh;hb=HEAD >> >> Usage: >> sh check_staged_release.sh 2740 /tmp/sling-staging sh >> check_staged_release.sh 2741 /tmp/sling-staging >> >> Please vote to approve this release: >> >> [ ] +1 Approve the release >> [ ] 0 Don't care >> [ ] -1 Don't release, because ... >> >> This majority vote is open for at least 72 hours.
[jira] [Assigned] (SLING-11858) Fix Scope of org.jetbrains:annotations in Events / Events API
[ https://issues.apache.org/jira/browse/SLING-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-11858: Assignee: Dan Klco > Fix Scope of org.jetbrains:annotations in Events / Events API > - > > Key: SLING-11858 > URL: https://issues.apache.org/jira/browse/SLING-11858 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > > Found by Stefan Seifert: > on both modules org.jetbrains:annotations was added with compile scope - > should be provided. although not a problem for the bundle in OSGi runtime, it > should be fixed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11859) Avoid Duplicating API Version in Events BND
Dan Klco created SLING-11859: Summary: Avoid Duplicating API Version in Events BND Key: SLING-11859 URL: https://issues.apache.org/jira/browse/SLING-11859 Project: Sling Issue Type: Improvement Components: Event Reporter: Dan Klco Assignee: Dan Klco Found by Stefan Seifert: osmetic: the bnd.bnd. in the event module contains an explicit reference to sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the redundancy and define the actual version only in the POM, otherwise it might be forgotten to update in in both places in future updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11858) Fix Scope of org.jetbrains:annotations in Events / Events API
Dan Klco created SLING-11858: Summary: Fix Scope of org.jetbrains:annotations in Events / Events API Key: SLING-11858 URL: https://issues.apache.org/jira/browse/SLING-11858 Project: Sling Issue Type: Bug Components: Event Reporter: Dan Klco Found by Stefan Seifert: on both modules org.jetbrains:annotations was added with compile scope - should be provided. although not a problem for the bundle in OSGi runtime, it should be fixed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10
Stefan, Thanks for the feedback, would you suggest canceling this release over remark A? Not a problem if so, these are small changes to make. -Dan On Thu, May 4, 2023 at 3:53 AM Stefan Seifert wrote: > i've two remarks on this release: > > a) on both modules org.jetbrains:annotations was added with compile scope > - should be provided. although not a problem for the bundle in OSGi > runtime, it should be fixed. i would propose making a new release for it, > esp. considering that the API bundle is released very rarely. > > b) cosmetic: the bnd.bnd. in the event module contains an explicit > reference to sling.event.api-1.0.2, same as the pom.xml. it would be better > to avoid the redundancy and define the actual version only in the POM, > otherwise it might be forgotten to update in in both places in future > updates. i think there are possibilities to express this via expressions. > this could be done in a follow-up release. > > stefan > > > -Original Message- > > From: Daniel Klco > > Sent: Wednesday, May 3, 2023 10:04 PM > > To: dev@sling.apache.org > > Subject: [VOTE] Release Apache Sling Event API version 1.0.2 and Event > > 4.3.10 > > > > Hi, > > > > We solved 2 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12353195 > > https://issues.apache.org/jira/projects/SLING/versions/12353051 > > > > There are still some outstanding issues: > > https://issues.apache.org/jira/projects/SLING/versions/12344634 > > https://issues.apache.org/jira/projects/SLING/versions/12353196 > > > > Staging repositories: > > https://repository.apache.org/content/repositories/orgapachesling-2740/ > > https://repository.apache.org/content/repositories/orgapachesling-2741/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling- > > release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2740 /tmp/sling-staging sh > > check_staged_release.sh 2741 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. >
[jira] [Commented] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719327#comment-17719327 ] Angela Schreiber commented on SLING-11750: -- also 'addMixin' and 'removeMixin' are new statements and not covered by the converter so far. > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719327#comment-17719327 ] Angela Schreiber edited comment on SLING-11750 at 5/4/23 1:32 PM: -- also 'addMixin' and 'removeMixin' are new statements and not covered by the converter so far. https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/167 was (Author: anchela): also 'addMixin' and 'removeMixin' are new statements and not covered by the converter so far. > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11750: - Summary: Support the new repoinit statements (was: Support the new repoinit statements "enforce principal ACL" and "enforce nodes") > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela opened a new pull request, #167: SLING-11750 : Support the new repoinit statements
anchela opened a new pull request, #167: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/167 hi @rombert and @kwin , while searching for tickets related to sling-initial-content in jira, i stumbled across this one here. IMHO none of the new repo-init statements requires any conversion and thus they can be written out in their original form (similar to CreatePath and SetAclPrincipalBased). i would still appreciate if you could take a careful look. thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-10243) Extract Sling-Initial-Content from bundles and put into dedicated packages
[
https://issues.apache.org/jira/browse/SLING-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-10243:
-
Labels: regression (was: )
> Extract Sling-Initial-Content from bundles and put into dedicated packages
> --
>
> Key: SLING-10243
> URL: https://issues.apache.org/jira/browse/SLING-10243
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Labels: regression
> Fix For: Content-Package to Feature Model Converter 1.1.0
>
>
> As described in
> https://lists.apache.org/thread.html/r1162d545922381187a0530f838b684b60f2a8ea28a12649ae79372e8%40%3Cdev.sling.apache.org%3E
> Sling-Initial-Content leads to ERRORs when used with Oak Composite Node
> Store, as those are evaluated during each bundle start. At times when that
> part of the repo is read-only an ERROR is logged.
> The following steps are necessary:
> # Check manifest from bundle for header {{Sling-Initial-Content}}
> # For all entry paths in the header split up by mutable/immutable and create
> a content package for each category
> # Modify manifest to no longer include {{Sling-Initial-Content}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11855) Conversion of old factory config names to new one is not checking for tilde
[ https://issues.apache.org/jira/browse/SLING-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11855: - Labels: (was: regression) > Conversion of old factory config names to new one is not checking for tilde > --- > > Key: SLING-11855 > URL: https://issues.apache.org/jira/browse/SLING-11855 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > The code in > AbstractConfigurationEntryHandler#extractId converts an old factory > configuration name into a new one (with a tilde). Unfortunately it only > checks for a dash but not a tilde, which means in the case of > factory~a-b this is converted to factory~a~b instead of keeping it as > factory~a-b > > A similar bug might lurk in other places dealing with factory configurations -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11855) Conversion of old factory config names to new one is not checking for tilde
[ https://issues.apache.org/jira/browse/SLING-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11855: - Labels: regression (was: ) > Conversion of old factory config names to new one is not checking for tilde > --- > > Key: SLING-11855 > URL: https://issues.apache.org/jira/browse/SLING-11855 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Labels: regression > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > The code in > AbstractConfigurationEntryHandler#extractId converts an old factory > configuration name into a new one (with a tilde). Unfortunately it only > checks for a dash but not a tilde, which means in the case of > factory~a-b this is converted to factory~a~b instead of keeping it as > factory~a-b > > A similar bug might lurk in other places dealing with factory configurations -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10168) Migrate to Bundle Parent 41 and OSGi annotations
[ https://issues.apache.org/jira/browse/SLING-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10168: - Labels: regression (was: ) > Migrate to Bundle Parent 41 and OSGi annotations > > > Key: SLING-10168 > URL: https://issues.apache.org/jira/browse/SLING-10168 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Resource Merger 1.3.10 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Labels: regression > Fix For: Resource Merger 1.4.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11112) Regression in content loader : Diffent behaviour when initial content is missing
[ https://issues.apache.org/jira/browse/SLING-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-2: - Labels: regression (was: ) > Regression in content loader : Diffent behaviour when initial content is > missing > > > Key: SLING-2 > URL: https://issues.apache.org/jira/browse/SLING-2 > Project: Sling > Issue Type: Improvement >Affects Versions: JCR ContentLoader 2.5.0 >Reporter: Carsten Ziegeler >Priority: Blocker > Labels: regression > Fix For: JCR ContentLoader 2.6.2 > > > With a bundle that does not have SLING-INF and the following initial content > instruction: > SLING-INF/content;path:=/libs/foo/bar;overwrite:=true; > it seems that prior versions handled this case differently and did not touch > /libs/foo/bar while the new behaviour removes all child nodes of /libs/foo/bar -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Starter ITs failing when updating to the latest Apache Felix HTTP 4.x
My best guess is that it is due to this new code in 4.2.0: https://github.com/apache/felix-dev/blob/http-4.x/http/base/src/main/java/org/apache/felix/http/base/internal/dispatch/ServletRequestWrapper.java#L166 Regards Carsten On 04.05.2023 10:46, Carsten Ziegeler wrote: I don't really have a very helpful reply. I'm not aware of changes in this area. As far as I remember, the attributes are set by the http base implementation. I'm also not sure what the IncludeTest is actually testing; is it testing a Sling include or a servlet include? Http base has tests for the includes andh whether the attribute is set. I fear the only way to figure out what is going on is debugging the test run and see what happens (or not happens). Regards Carsten On 04.05.2023 09:50, Robert Munteanu wrote: Hi, I am looking at a renovate PR [1] that updates org.apache.felix:org.apache.felix.http.jetty from 4.1.14 to 4.2.10 and org.apache.felix:org.apache.felix.http.servlet-api from 1.1.4 to 1.2.0 . There are 3 failures in the IncludeIT that show that the javax.servlet.include.request_uri attribute is no longer present: [ERROR] Failures: [ERROR] IncludeTest.testForcedResourceType:149->assertIncludeRequestAttributes:154->assertIncludeRequestAttributes:167->assertRequestAttribute:189 Expected content contains '--javax.servlet.include.request_uri-' [ERROR] IncludeTest.testWithInclude:114->assertIncludeRequestAttributes:154->assertIncludeRequestAttributes:167->assertRequestAttribute:189 Expected content contains '--javax.servlet.include.request_uri-' [ERROR] IncludeTest.testWithIncludeAndExtension:123->assertIncludeRequestAttributes:154->assertIncludeRequestAttributes:167->assertRequestAttribute:189 Expected content contains '--javax.servlet.include.request_uri-' The test failures happen with version 4.2.0 as well, so this has something to do with the minor version bump. Looking at the Felix changelog [2] this could be related to supporting the Servlet API 4.0 [3], but I didn't manage to figure out what is going on. If anyone has an idea about how to make this progress, please share, I'm out of ideas at the moment. Thanks, Robert [1]: https://github.com/apache/sling-org-apache-sling-starter/pull/142 [2]: https://issues.apache.org/jira/projects/FELIX/versions/12351176 [3]: https://issues.apache.org/jira/browse/FELIX-6498 -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Resolved] (SLING-3342) Do not use SlingBindings in Java code
[ https://issues.apache.org/jira/browse/SLING-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3342. - Resolution: Won't Fix > Do not use SlingBindings in Java code > - > > Key: SLING-3342 > URL: https://issues.apache.org/jira/browse/SLING-3342 > Project: Sling > Issue Type: Task > Components: Best practices >Reporter: Bertrand Delacretaz >Priority: Minor > > **DRAFT** - to be reviewed, and we need to update the SlingBindings javadocs > as well. > SlingBindings is meant to be used in Sling scripts. > It might be available as a Request attribute in some cases, as Sling sets > that before running scripts, but one cannot rely on that in java code. > There’s usually no reason to use it in Java code anyway, all the services > that it provides are available directly, for example via an @Reference > annotation. > Here’s a typical counter-example which should use an @Reference to the FooBar > service instead: > // Do NOT do that! > SlingBindings bindings = > (SlingBindings)request.getAttribute(SlingBindings.class.getName()); > SlingScriptHelper scriptHelper = bindings.getSling(); > FooBar fb = scriptHelper.getService(FoorBar.class); -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3333) Avoid mounting Sling servlets on paths, prefer resource types
[ https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-. - Resolution: Won't Fix > Avoid mounting Sling servlets on paths, prefer resource types > - > > Key: SLING- > URL: https://issues.apache.org/jira/browse/SLING- > Project: Sling > Issue Type: Improvement > Components: Best practices >Reporter: Bertrand Delacretaz >Priority: Major > > As mentioned at > http://sling.apache.org/documentation/the-sling-engine/servlets.html, > mounting a servlet on a resource type can be done for most servlets that are > mounted on paths using the sling.servlet.paths service property, and in most > cases mounting on a resource type is preferable. > Mounting a Sling servlet on a path does not allow one to setup fine-grained > access control. There's no way to prevent some users from accessing the > servlet if any users have access to it. > The way to avoid this is to mount the servlet on a specific Sling resource > type, and create resources that point to it by their sling:resourceType > property. You can then set access control on those nodes as required. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3307) Updated launchpad bundle list is not reflected after upgrade
[ https://issues.apache.org/jira/browse/SLING-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3307. - Resolution: Won't Fix > Updated launchpad bundle list is not reflected after upgrade > > > Key: SLING-3307 > URL: https://issues.apache.org/jira/browse/SLING-3307 > Project: Sling > Issue Type: Bug > Components: Launchpad >Affects Versions: Launchpad Installer 1.2.2 >Reporter: Robert Munteanu >Priority: Major > Attachments: SLING-3307-repro.zip > > > This is a follow-up bug report for > http://markmail.org/thread/6us2jyrkcz6wjwxr . > I've run into a bug when trying to update an existing Sling launchad to add a > new bundle. The steps I've taken were: > * Create a launchpad ( using the maven-launchpad-plugin ) and executed the > jar file > * Updated the bundle list to include a new bundle and executed the jar file > on top of the existing launchpad directory > The end result was that the new bundle was not deployed. > Digging in the code a bit, I've noticed that the upgrade goes well if I force > the startup mode to update. > The sling/conf/launchpad_timestamp.txt exists and is valid. It seems that the > StartupManager.getSelfTimeStamp() method does not get the correct timestamp: > * looks for the last-modified date of the jar loading StartupManager.class - > org.apache.sling.launchpad.base.jar > * looks for the last-modified date of the jar loading > LaunchpadContentProvider.class - still org.apache.sling.launchpad.base.jar > * looks for the last-modified date of all the bundles from sling/startup > folder > The problem is that at this point, the new/modified bundles are not present > in the sling/startup folder, so they are not taken into account. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3263) use custom user agent for topology connector
[ https://issues.apache.org/jira/browse/SLING-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3263. - Resolution: Won't Fix > use custom user agent for topology connector > > > Key: SLING-3263 > URL: https://issues.apache.org/jira/browse/SLING-3263 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Discovery Impl 1.0.2 >Reporter: Stefan Egli >Priority: Major > > The current topology connector uses the default (httpclient) user agent. This > could be explicitly set instead of using the default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3292) Web Hooks for Resource Observation
[ https://issues.apache.org/jira/browse/SLING-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3292. - Resolution: Won't Fix > Web Hooks for Resource Observation > -- > > Key: SLING-3292 > URL: https://issues.apache.org/jira/browse/SLING-3292 > Project: Sling > Issue Type: New Feature > Components: Extensions >Reporter: Lars Trieloff >Priority: Minor > > I have an application that is storing resources for multiple other web > applications and makes them available through the Sling REST API. Each of the > consuming web applications has implemented their own caching and polling > strategy for the resources made available by my Sling web application. > In order to reduce latency when resources get updated in my Sling web > application, and to reduce the need for polling resources on the side of my > consuming web application, I would like to support Web Hooks > (https://webhooks.pbworks.com/w/page/13385124/FrontPage - a pattern also > supported by applications such as GitHub > https://help.github.com/articles/post-receive-hooks or Evernote > http://dev.evernote.com/doc/articles/polling_notification.php), so that > client applications can register callbacks when one of the resources in my > web application changes. > The events to be observed should be: > * resource added > * resource moved > * resource deleted > * resource updated > An observing application should be able to specify: > * a pattern of resource paths it is interested in > * a collection of resource types it is interested in > * a collection of events it is interested in > * a callback URL that should receive POST requests when a change matching the > pattern above has been made > The subsequent POST request should contain following information > * timestamp of the change > * URL of the changed resource > * event type of the change > * user initiating the change > Furthermore, observing applications should be able to > * create a new listener using a POST request > * GET the list of listeners already registered > * POST to update or delete an existing listener > h5. Error Handling > In case the registered callback URL is not available, Sling should retry the > notification POST request, with increasing time between retries. > After a maximum number of retries, the listener should be blacklisted, so > that no further retries are being made > h5. Configuration > * maximum number of retries > * enforce HTTPS (for production use) > * authentication for outgoing requests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3266) RhinoJavaScriptEngine should Implement javax.script.Compilable
[ https://issues.apache.org/jira/browse/SLING-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3266. - Resolution: Won't Fix > RhinoJavaScriptEngine should Implement javax.script.Compilable > -- > > Key: SLING-3266 > URL: https://issues.apache.org/jira/browse/SLING-3266 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting JavaScript 2.0.12 >Reporter: Sameer Charles >Priority: Minor > > AFAIK, Rhino javascript engine bundled with java 5 implement > javax.script.Compilable. It would be good if the sling RhinoJavascriptEngine > would implement compilable and provide a javax.script.CompiledScript > extension. > Currently if you want to compile JS, you are forced to use Rhino directly. > In addition, it would also be nice to have a support for any Compilable > engine. ie. if the engine implement Compilable, sling should compile and keep > the CompiledScript in repository for subsequent evaluation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3248) Proposed Improvements to the Tenant Administrative Web Console Plugin
[ https://issues.apache.org/jira/browse/SLING-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3248. - Resolution: Won't Fix > Proposed Improvements to the Tenant Administrative Web Console Plugin > - > > Key: SLING-3248 > URL: https://issues.apache.org/jira/browse/SLING-3248 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Tenant 1.0.0 >Reporter: Felix Meschberger >Assignee: Timothee Maret >Priority: Major > Attachments: SLING-3248.patch > > > As suggested in [1]: > You might want to add some more handling in the Web Console Plugin: > * Display an error if adding the tenant failed > * Display information after successfully adding or removing a Tenant > [1] > https://issues.apache.org/jira/browse/SLING-2676?focusedCommentId=13506464=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13506464 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3217) Automatically expose SlingBindings object through EL
[ https://issues.apache.org/jira/browse/SLING-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3217. - Resolution: Won't Fix > Automatically expose SlingBindings object through EL > > > Key: SLING-3217 > URL: https://issues.apache.org/jira/browse/SLING-3217 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Justin Edelson >Priority: Major > Attachments: SLING-3217.patch > > > JSP scripts need to use the (or a subclass) in order > to expose the Sling Bindings objects (i.e. `resource`) for use in a JSP page. > This shouldn't be necessary if we provide a custom ELResolver. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3181) Use the *IT.java name pattern to separate between unit and integration tests
[ https://issues.apache.org/jira/browse/SLING-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3181. - Resolution: Won't Fix > Use the *IT.java name pattern to separate between unit and integration tests > > > Key: SLING-3181 > URL: https://issues.apache.org/jira/browse/SLING-3181 > Project: Sling > Issue Type: Improvement > Components: Best practices >Reporter: Bertrand Delacretaz >Priority: Minor > > When a module contains both unit and integration tests, naming integration > test classes *IT allows the surefire and failsafe plugins to automatically > select the right tests, without requiring pom configurations. > In the bundles/scripting/core module for example, the > BindingsValuesProvidersByContextIT test is run in the integration-tests > phase, and other tests in the test phase, based only on the test names: > src/test/java/org/apache/sling/scripting/core/impl/BindingsValuesProvidersByContextIT.java > src/test/java/org/apache/sling/scripting/core/impl/DummyScriptEngineFactory.java > src/test/java/org/apache/sling/scripting/core/impl/helper/ProtectedBindingsTest.java > src/test/java/org/apache/sling/scripting/core/impl/LogWriterTest.java > src/test/java/org/apache/sling/scripting/core/impl/ScriptEngineManagerFactoryTest.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3215) Use RetryRule in integration tests to avoid timing-related issues
[ https://issues.apache.org/jira/browse/SLING-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3215. - Resolution: Won't Fix > Use RetryRule in integration tests to avoid timing-related issues > - > > Key: SLING-3215 > URL: https://issues.apache.org/jira/browse/SLING-3215 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Bertrand Delacretaz >Priority: Minor > > We should use the SLING-3212 retry rule in integration tests that assume > things happen instantly, as this is not always the case. > Tests need to be converted to JUnit4 style for that, SLING-3214 will help > make that transition. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3152) Allow for SlingPostServlet to force creation
[
https://issues.apache.org/jira/browse/SLING-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-3152.
-
Resolution: Won't Fix
> Allow for SlingPostServlet to force creation
>
>
> Key: SLING-3152
> URL: https://issues.apache.org/jira/browse/SLING-3152
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Reporter: Roland Schaer
>Priority: Minor
>
> A POST request to a resource of type {{StarSyntheticResource}} with a
> {{:nameHint}} parameter containing an existing node name will fail with an
> {{javax.jcr.AccessDeniedException}} if the user is not allowed to read the
> existing node.
> JCR
> /a (deny:everyone:jcr:all,allow:user1:jcr:all,allow:user2:jcr:all)
> /a/test (deny:everyone:jcr:all, allow:user1:jcr:all)
> user2 Request:
> POST /a/*
> :nameHint=test
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-3173) Job Engine: Support custome queue implementations
[ https://issues.apache.org/jira/browse/SLING-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3173. - Resolution: Won't Fix > Job Engine: Support custome queue implementations > - > > Key: SLING-3173 > URL: https://issues.apache.org/jira/browse/SLING-3173 > Project: Sling > Issue Type: New Feature > Components: Extensions >Reporter: Stefan Seifert >Priority: Minor > > follow-up from SLING-3028 > Q: is it possible to add own queue implementations? does not seem so, its > using a hardcoded enum. in our own job implementation we have e.g. a "time > window queue" think, which queues up jobs and executes them only in defined > time windows where low user traffic is expected on the instance. > A: Own queue implementations: these are not possible at all. For your use > case of a time window queue, you maybe could use the scheduled jobs? If you > think it's worth exploring this, please create a separate issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3146) Out-of date "Discover Sling in 15 minutes"
[ https://issues.apache.org/jira/browse/SLING-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3146. - Resolution: Won't Fix > Out-of date "Discover Sling in 15 minutes" > -- > > Key: SLING-3146 > URL: https://issues.apache.org/jira/browse/SLING-3146 > Project: Sling > Issue Type: Bug > Components: Documentation, Launchpad > Environment: W7 >Reporter: Eric Estievenart >Priority: Major > > When following instructions from "Discover Sling in 15 minutes" > (http://sling.apache.org/documentation/getting-started/discover-sling-in-15-minutes.html), > the steps ask to download org.apache.sling.launchpad-6-standalone.jar, > and run it via java -jar > Indeed when running it, I stumble upon an AIOB exception, > which looks like the one described in SLING-2348. > However this bug should have been fixed in May, 2012, > and the jar seems to be from Jan, 2013. > I'm not sure whether: > - the link to the launchpad jar is the good one > - the apache mirrors are providing the good file > - or there has been a regression (in which case SLING-2348 should be reopened > ?) > In any case, the first impression is disappointing ;-) > Thanks, > Eric > detailed infos > java 1.7.0.21 64 bit on W7. > C:\tmp\>java -jar org.apache.sling.launchpad-6-standalone.jar -l 4 > 04.10.2013 13:59:38.781 *INFO* [main] Setting sling.home=sling (default) > 04.10.2013 13:59:38.782 *INFO* [main] Starting Sling in sling (C:\tmp\sling) > 04.10.2013 13:59:38.794 *INFO* [main] Checking launcher JAR in folder sling > 04.10.2013 13:59:38.809 *INFO* [main] Existing launcher is up to date, using > it: 2.3.0 (org.apache.sling.launchpad.base.jar) > 04.10.2013 13:59:38.812 *INFO* [main] Loading launcher class > org.apache.sling.launchpad.base.app.MainDelegate from > org.apache.sling.launchpad.base.jar > 04.10.2013 13:59:38.823 *INFO* [main] Starting launcher ... > 04.10.2013 13:59:38.828 *INFO* [main] HTTP server port: 8080 > 04.10.2013 13:59:38.894 *ERROR* [main] Failed to Start OSGi framework > org.osgi.framework.BundleException: Uncaught Instantiation Issue: > java.lang.ArrayIndexOutOfBoundsException: -1 > at org.apache.sling.launchpad.base.impl.Sling.(Sling.java:245) > at > org.apache.sling.launchpad.base.app.MainDelegate$1.(MainDelegate.java:159) > at > org.apache.sling.launchpad.base.app.MainDelegate.start(MainDelegate.java:159) > at org.apache.sling.launchpad.app.Main.startSling(Main.java:244) > at org.apache.sling.launchpad.app.Main.(Main.java:107) > at org.apache.sling.launchpad.app.Main.main(Main.java:56) > Caused by: java.lang.ArrayIndexOutOfBoundsException: -1 > at java.util.ArrayList.elementData(Unknown Source) > at java.util.ArrayList.get(Unknown Source) > at > org.apache.felix.framework.BundleImpl.getCurrentModule(BundleImpl.java:1046) > at > org.apache.felix.framework.BundleImpl.getSymbolicName(BundleImpl.java:863) > at > org.apache.sling.launchpad.base.impl.SlingFelix.getSymbolicName(SlingFelix.java:32) > at org.apache.felix.framework.Felix.toString(Felix.java:1012) > at org.apache.felix.framework.Logger.doLog(Logger.java:128) > at org.apache.felix.framework.Logger._log(Logger.java:181) > at org.apache.felix.framework.Logger.log(Logger.java:114) > at > org.apache.felix.framework.ExtensionManager.(ExtensionManager.java:201) > at org.apache.felix.framework.Felix.(Felix.java:374) > at > org.apache.sling.launchpad.base.impl.SlingFelix.(SlingFelix.java:39) > at org.apache.sling.launchpad.base.impl.Sling.(Sling.java:235) > ... 5 more > 04.10.2013 13:59:38.898 *ERROR* [main] There was a problem launching Sling > 04.10.2013 13:59:38.898 *INFO* [Sling Terminator] Java VM is shutting down -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3133) [Proposal] Sling POST workflow
[ https://issues.apache.org/jira/browse/SLING-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3133. - Resolution: Won't Fix > [Proposal] Sling POST workflow > -- > > Key: SLING-3133 > URL: https://issues.apache.org/jira/browse/SLING-3133 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Francesco Mari >Priority: Minor > Attachments: SLING-3133.patch > > > I would like to propose a quick proof of concept about handling POST requests > in Sling. This could be a replacement (or an enhancement) for the current > implementation of the POST Servlet. The proposal is mainly inspired by the > talk by Dominik Süß at adaptTo() 2013. > I implemented a Filter which monitors incoming requests for an :operation > parameter. If this parameter is present, the POST workflow is executed. I > opted for a filter because I don't want the resource/script resolution logic > to trigger, I want to completely override it if the :operation parameter is > present in the request. > The workflow is an aggregation of two different components: > - POST phases: each phase has a name, which is a symbolic identifier used by > POST steps to attach to it. > - POST steps: a step is the unit of work of the component. It is associated > to one or more POST phase by means of a multi-value service parameter > targeting the symbolic name of one or more phase. > Steps and phases can be registered dynamically as OSGi components. > The execution of the workflow sort each phase by service ranking, and for > each of them executes the steps associated to it. Steps are executed in > service ranking order, too. > Please keep in mind that the attached patch is just a quick sketch of my > idea, is far from being complete. In particular, I'm still think about the > following topics: > - How to enable steps (e.g. validation steps) to abort the workflow for the > current operation? What happens to the work executed by previous steps? > - Should steps be able to pass information to one another? Is some kind of > shared context needed to glue them together (without strictly coupling them)? > - How to track changes made by steps? And how to communicate which changes > have been made to the end user? > I would like to know if this could be of any interested to the community, and > of course it would be great to hear from you. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3144) UserAdmin and GroupAdmin groups are missing on our Oak setup
[ https://issues.apache.org/jira/browse/SLING-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3144. - Resolution: Won't Fix > UserAdmin and GroupAdmin groups are missing on our Oak setup > > > Key: SLING-3144 > URL: https://issues.apache.org/jira/browse/SLING-3144 > Project: Sling > Issue Type: Bug >Reporter: Bertrand Delacretaz >Priority: Minor > Attachments: SLING-3144-patch.txt > > > Some of my SLING-2788 integration tests (for example PrivilegesInfoTest) fail > as the UserAdmin and GroupAdmin don't initially exist. > In Jackrabbit those groups are apparently created by > UserAccessControlProvider [1] - I'll ask the Oak team how to have the > equivalent in Oak. > As a workaround, creating those groups as follows allows a few more tests to > pass - but for the final setup the groups need to be created with specific > security-related parameters. > curl -u admin:admin -F:name=GroupAdmin > http://localhost:8080/system/userManager/group.create.html > curl -u admin:admin -F:name=UserAdmin > http://localhost:8080/system/userManager/group.create.html > [1] > http://jackrabbit.apache.org/api/2.2/org/apache/jackrabbit/core/security/user/UserAccessControlProvider.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3107) initial-content archetype does not reflect current practices
[ https://issues.apache.org/jira/browse/SLING-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3107. - Resolution: Won't Fix > initial-content archetype does not reflect current practices > > > Key: SLING-3107 > URL: https://issues.apache.org/jira/browse/SLING-3107 > Project: Sling > Issue Type: Bug > Components: Maven Plugins and Archetypes >Affects Versions: Initial Content Archetype 1.0.4 >Reporter: Andrew Savory >Priority: Minor > Attachments: SLING-3107.diff > > > The initial content archetype has a number of deficiencies: > - it uses xml rather than the more modern json format for content > - the layout of initial projects doesn't match the most recent sample apps -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3103) Groovy extemsions for dealing with JCR and Spock
[ https://issues.apache.org/jira/browse/SLING-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3103. - Resolution: Won't Fix > Groovy extemsions for dealing with JCR and Spock > > > Key: SLING-3103 > URL: https://issues.apache.org/jira/browse/SLING-3103 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Victor Saar >Priority: Major > Attachments: SLING-3103.patch, sling-groovy-extensions.pdf > > > A while ago I wrote a set of Groovy extensions aimed at making it easier to > work with JCR. The main use case for this is probably testing and it includes > an extension for the Spock testing framework, as well. But it could certainly > be used for non-testing code. > I think that Sling would be a good place for these extensions to live in. > They are not particularly tied to Sling, but could be further extended to the > Resource API for example. > I'll attach a patch and some documentation so that people can get an idea of > what's covered. (The patch currently adds a separate groovy artifact in > contrib/extensions/groovy, because I didn't know where to put it else. I just > realized that there is a Groovy extension bundle already, so it could > certainly be added there.) > I'm looking forward to feedback. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3055) initial-content archetype has invalid markup
[ https://issues.apache.org/jira/browse/SLING-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3055. - Resolution: Won't Fix > initial-content archetype has invalid markup > > > Key: SLING-3055 > URL: https://issues.apache.org/jira/browse/SLING-3055 > Project: Sling > Issue Type: Bug > Components: Maven Plugins and Archetypes >Affects Versions: Initial Content Archetype 1.0.0 >Reporter: Andrew Savory >Priority: Minor > > Content of html.esp is invalid, contains --!> instead of --> between html and > head. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3099) Support launching the request analyzer Swing GUI from the Web Console
[ https://issues.apache.org/jira/browse/SLING-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3099. - Resolution: Won't Fix > Support launching the request analyzer Swing GUI from the Web Console > - > > Key: SLING-3099 > URL: https://issues.apache.org/jira/browse/SLING-3099 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Felix Meschberger >Assignee: Felix Meschberger >Priority: Major > > The Request Analyzer filter currently only records a single file and embeds a > standalone Java Application to analyze the recorded log. > There is no hook to (a) download the recorded log or to (b) launch the GUI > from within the Sling application for in-situ analysis. > A simple Web Console plugin is to be written to allow downloading the file > and -- if Sling is launched in non-headless mode -- to launch the Swing GUI > for in-situ analysis. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-3040) Selector Restriction
[ https://issues.apache.org/jira/browse/SLING-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3040. - Resolution: Won't Fix > Selector Restriction > > > Key: SLING-3040 > URL: https://issues.apache.org/jira/browse/SLING-3040 > Project: Sling > Issue Type: Wish > Components: Extensions >Reporter: Ben Zahler >Priority: Minor > Labels: security > Attachments: SlingSelectorConfig.java, SlingSelectorFilter.java > > > Sling selectors have been identified as a possible means of DoS attacks in > CQ5. Therefore, this ticket contains proposals on how selector restrictions > can be implemented in Sling. > I propose two mechanisms that can/should be used together: > - define selectors frequently used in the Sling instance and allow them > on any request > - define selectors per resource/resource type that are only allowed for > that resource/resource type (already proposed in [1]) > The original requestor is not necessarily aware of the resources that are > included internally. Therefore, all checks are performed in request scope > filters. Also, this implies that selectors added internally (e.g. through > sling:include) are not affected. > The two mechanisms in more detail: > 1. The generally allowed selectors can be configured as a list of entries > * A configuration entry can contain multiple selectors, "*" allows all > selectors > * selectors can be configured only for specific repository trees as follows: > repositorypath:selectors > ** the repository path is evaluated as a regular expression > ** example: /content/.*:myselector,anotherselector > ** If a configuration entry contains multiple selectors, a request containing > these selectors must contain them in the same order as in the configuration. > 2. On a resource or on its resource type, the property > sling:resourceSelectors can be implemented. On that resource, the specified > selectors are allowed in addition to the ones specified in mechanism 1. > * A resource/resource type without the property sling:resourceSelectors does > not allow any selectors except the ones defined in mechanism 1. > * Inheritance must be considered: if a resource has a sling:resourceSuperType > set, the inherited selectors must be applied and the selectors added to the > ones of the current resource. (see examples below) > ** If both the current resource and its resource type and or its resource > supertype have the property set, all selectors specified in either node are > allowed. > * If multiple selectors are defined on a resource, a request that has > multiple selectors must contain them in the same order as defined on the > resource. > ** Fixed ordering can be switched off configuratively > * Checks are performed only on request scope, therefore the check is only > performed on the resource actually requested. > 3.Selectors defined by a Servlet in property sling.servlet.selectors are > treated as any other selector: either these selectors must be configured in > the generally allowed selectors or the resource requested must specifically > allow for them. > Attached is a sample implementation (definitely not production ready!). > [1] > http://svn.apache.org/repos/asf/sling/trunk/samples/urlfilter/src/main/java/org/apache/sling/samples/urlfilter/impl/UrlFilter.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11837) Align index definition generation logic with the one from Oak
[
https://issues.apache.org/jira/browse/SLING-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11837.
-
Resolution: Fixed
> Align index definition generation logic with the one from Oak
> -
>
> Key: SLING-11837
> URL: https://issues.apache.org/jira/browse/SLING-11837
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> The logic used to generate the "str:" prefix for string values comes from
> here:
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/a98317ba836d9acedb334518a438f4bcc8ce721d/src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java#L108
> For prefixes, we should probably use the logic used in Oak. AFAIK this is
> implemented in
> https://github.com/apache/jackrabbit-oak/blob/838780a7aaf9775ad0bf7b6be65c1a1619e65eb7/oak-store-spi/src/main/java/org/apache/jackrabbit/oak/json/JsonSerializer.java#L269-L291:
> {noformat}
> public void serialize(PropertyState property, Type type, int index) {
> if (type == BOOLEAN) {
> json.value(property.getValue(BOOLEAN, index));
> } else if (type == LONG) {
> json.value(property.getValue(LONG, index));
> } else if (type == DOUBLE) {
> Double value = property.getValue(DOUBLE, index);
> if (value.isNaN() || value.isInfinite()) {
> json.value(TypeCodes.encode(type.tag(), value.toString()));
> } else {
> json.encodedValue(value.toString());
> }
> } else if (type == BINARY) {
> Blob blob = property.getValue(BINARY, index);
> json.value(TypeCodes.encode(type.tag(), blobs.serialize(blob)));
> } else {
> String value = property.getValue(STRING, index);
> if (type != STRING || TypeCodes.split(value) != -1) {
> value = TypeCodes.encode(type.tag(), value);
> }
> json.value(value);
> }
> }
> public static int split(String jsonString) {
> if (jsonString.startsWith(":blobId:")) { // See OAK-428
> return 7;
> }
> else if (jsonString.length() >= 4 && jsonString.charAt(3) == ':') {
> return 3;
> }
> else {
> return -1;
> }
> }
> {noformat}
> So basically, the logic for String types is: if there is a ':' at position 4,
> then the "str:" prefix is needed. Otherwise, not. Note that we can't reuse
> the code since it uses the NodeState/PropertyState API.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert merged pull request #166: SLING-11837 - Align index definition generation logic with the one from Oak
rombert merged PR #166: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Starter ITs failing when updating to the latest Apache Felix HTTP 4.x
I don't really have a very helpful reply. I'm not aware of changes in this area. As far as I remember, the attributes are set by the http base implementation. I'm also not sure what the IncludeTest is actually testing; is it testing a Sling include or a servlet include? Http base has tests for the includes andh whether the attribute is set. I fear the only way to figure out what is going on is debugging the test run and see what happens (or not happens). Regards Carsten On 04.05.2023 09:50, Robert Munteanu wrote: Hi, I am looking at a renovate PR [1] that updates org.apache.felix:org.apache.felix.http.jetty from 4.1.14 to 4.2.10 and org.apache.felix:org.apache.felix.http.servlet-api from 1.1.4 to 1.2.0 . There are 3 failures in the IncludeIT that show that the javax.servlet.include.request_uri attribute is no longer present: [ERROR] Failures: [ERROR] IncludeTest.testForcedResourceType:149->assertIncludeRequestAttributes:154->assertIncludeRequestAttributes:167->assertRequestAttribute:189 Expected content contains '--javax.servlet.include.request_uri-' [ERROR] IncludeTest.testWithInclude:114->assertIncludeRequestAttributes:154->assertIncludeRequestAttributes:167->assertRequestAttribute:189 Expected content contains '--javax.servlet.include.request_uri-' [ERROR] IncludeTest.testWithIncludeAndExtension:123->assertIncludeRequestAttributes:154->assertIncludeRequestAttributes:167->assertRequestAttribute:189 Expected content contains '--javax.servlet.include.request_uri-' The test failures happen with version 4.2.0 as well, so this has something to do with the minor version bump. Looking at the Felix changelog [2] this could be related to supporting the Servlet API 4.0 [3], but I didn't manage to figure out what is going on. If anyone has an idea about how to make this progress, please share, I'm out of ideas at the moment. Thanks, Robert [1]: https://github.com/apache/sling-org-apache-sling-starter/pull/142 [2]: https://issues.apache.org/jira/projects/FELIX/versions/12351176 [3]: https://issues.apache.org/jira/browse/FELIX-6498 -- Carsten Ziegeler Adobe cziege...@apache.org
RE: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10
i've two remarks on this release: a) on both modules org.jetbrains:annotations was added with compile scope - should be provided. although not a problem for the bundle in OSGi runtime, it should be fixed. i would propose making a new release for it, esp. considering that the API bundle is released very rarely. b) cosmetic: the bnd.bnd. in the event module contains an explicit reference to sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the redundancy and define the actual version only in the POM, otherwise it might be forgotten to update in in both places in future updates. i think there are possibilities to express this via expressions. this could be done in a follow-up release. stefan > -Original Message- > From: Daniel Klco > Sent: Wednesday, May 3, 2023 10:04 PM > To: dev@sling.apache.org > Subject: [VOTE] Release Apache Sling Event API version 1.0.2 and Event > 4.3.10 > > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12353195 > https://issues.apache.org/jira/projects/SLING/versions/12353051 > > There are still some outstanding issues: > https://issues.apache.org/jira/projects/SLING/versions/12344634 > https://issues.apache.org/jira/projects/SLING/versions/12353196 > > Staging repositories: > https://repository.apache.org/content/repositories/orgapachesling-2740/ > https://repository.apache.org/content/repositories/orgapachesling-2741/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling- > release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2740 /tmp/sling-staging sh > check_staged_release.sh 2741 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.
Re: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10
+1 angela From: Daniel Klco Sent: Wednesday, May 3, 2023 22:04 To: dev@sling.apache.org Subject: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10 Hi, We solved 2 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12353195 https://issues.apache.org/jira/projects/SLING/versions/12353051 There are still some outstanding issues: https://issues.apache.org/jira/projects/SLING/versions/12344634 https://issues.apache.org/jira/projects/SLING/versions/12353196 Staging repositories: https://repository.apache.org/content/repositories/orgapachesling-2740/ https://repository.apache.org/content/repositories/orgapachesling-2741/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2740 /tmp/sling-staging sh check_staged_release.sh 2741 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
Starter ITs failing when updating to the latest Apache Felix HTTP 4.x
Hi, I am looking at a renovate PR [1] that updates org.apache.felix:org.apache.felix.http.jetty from 4.1.14 to 4.2.10 and org.apache.felix:org.apache.felix.http.servlet-api from 1.1.4 to 1.2.0 . There are 3 failures in the IncludeIT that show that the javax.servlet.include.request_uri attribute is no longer present: [ERROR] Failures: [ERROR] IncludeTest.testForcedResourceType:149->assertIncludeRequestAttributes:154->assertIncludeRequestAttributes:167->assertRequestAttribute:189 Expected content contains '--javax.servlet.include.request_uri-' [ERROR] IncludeTest.testWithInclude:114->assertIncludeRequestAttributes:154->assertIncludeRequestAttributes:167->assertRequestAttribute:189 Expected content contains '--javax.servlet.include.request_uri-' [ERROR] IncludeTest.testWithIncludeAndExtension:123->assertIncludeRequestAttributes:154->assertIncludeRequestAttributes:167->assertRequestAttribute:189 Expected content contains '--javax.servlet.include.request_uri-' The test failures happen with version 4.2.0 as well, so this has something to do with the minor version bump. Looking at the Felix changelog [2] this could be related to supporting the Servlet API 4.0 [3], but I didn't manage to figure out what is going on. If anyone has an idea about how to make this progress, please share, I'm out of ideas at the moment. Thanks, Robert [1]: https://github.com/apache/sling-org-apache-sling-starter/pull/142 [2]: https://issues.apache.org/jira/projects/FELIX/versions/12351176 [3]: https://issues.apache.org/jira/browse/FELIX-6498
