[jira] [Created] (SLING-11861) ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url
Sagar Miglani created SLING-11861:
-
Summary: ResourceMapper.getAllMappings returns empty mapping ""
when a vanity paths is pathless url
Key: SLING-11861
URL: https://issues.apache.org/jira/browse/SLING-11861
Project: Sling
Issue Type: Bug
Components: ResourceResolver
Affects Versions: Resource Resolver 1.10.0
Reporter: Sagar Miglani
When a resource has a path less url as vanity path (eg:
"http://www.example.com";) ResourceMapper.getAllMappings returns mappings
consisting of an empty path "".
This "" mapping can make {{SlingAuthenticatorServiceListener}} stop listening
to further authentication requirements [0]:
{code:xml}
Exception in thread "pool-14-thread-1" java.lang.IllegalArgumentException:
Configuration must not be null or empty
at
org.apache.sling.auth.core.impl.AuthenticationRequirementHolder.fromConfig(AuthenticationRequirementHolder.java:30)
at
org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.addService(AuthenticationRequirementsManager.java:374)
at
org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.process(AuthenticationRequirementsManager.java:300)
at
org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.processQueue(AuthenticationRequirementsManager.java:281)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
{code}
Clarification required:
- Is "" mapping/path a valid path? Should we store and return vanity path as
"/" in case of pathless url as vanity path?
cc: [~cziegeler] [~rombert] [~reschke]
[0]:
https://github.com/apache/sling-org-apache-sling-auth-core/blob/org.apache.sling.auth.core-1.5.0/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticatorServiceListener.java#L345-L351
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11856) Statistics for Sling Event Queue do not reset correctly
[ https://issues.apache.org/jira/browse/SLING-11856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719701#comment-17719701 ] Roy Teeuwen commented on SLING-11856: - [~cziegeler] could you have a look at this? You did the changes to the statistics last time > Statistics for Sling Event Queue do not reset correctly > --- > > Key: SLING-11856 > URL: https://issues.apache.org/jira/browse/SLING-11856 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Roy Teeuwen >Priority: Major > > When doing a reset on the statistics, the activeJobs and queuedJobs are not > correctly reset. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourceresolver] sagarmiglani opened a new pull request, #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…
sagarmiglani opened a new pull request, #96: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96 …en a vanity paths is pathless url -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11861) ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url
[
https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719702#comment-17719702
]
Sagar Miglani commented on SLING-11861:
---
Potential changes:
[https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96]
> ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths
> is pathless url
> ---
>
> Key: SLING-11861
> URL: https://issues.apache.org/jira/browse/SLING-11861
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Sagar Miglani
>Priority: Major
>
> When a resource has a path less url as vanity path (eg:
> "http://www.example.com";) ResourceMapper.getAllMappings returns mappings
> consisting of an empty path "".
> This "" mapping can make {{SlingAuthenticatorServiceListener}} stop listening
> to further authentication requirements [0]:
> {code:xml}
> Exception in thread "pool-14-thread-1" java.lang.IllegalArgumentException:
> Configuration must not be null or empty
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementHolder.fromConfig(AuthenticationRequirementHolder.java:30)
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.addService(AuthenticationRequirementsManager.java:374)
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.process(AuthenticationRequirementsManager.java:300)
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.processQueue(AuthenticationRequirementsManager.java:281)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
> Clarification required:
> - Is "" mapping/path a valid path? Should we store and return vanity path as
> "/" in case of pathless url as vanity path?
> cc: [~cziegeler] [~rombert] [~reschke]
> [0]:
> https://github.com/apache/sling-org-apache-sling-auth-core/blob/org.apache.sling.auth.core-1.5.0/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticatorServiceListener.java#L345-L351
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…
sonarcloud[bot] commented on PR #96: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#issuecomment-1535835990 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=96&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11861) ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url
[
https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719715#comment-17719715
]
Julian Reschke commented on SLING-11861:
Not convinced.
This is a change in behavior that could possibly cause breakage elsewhere
(that's why we improved test coverage after all).
IMHO this needs to be fixed in the consumers of the API.
> ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths
> is pathless url
> ---
>
> Key: SLING-11861
> URL: https://issues.apache.org/jira/browse/SLING-11861
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Sagar Miglani
>Priority: Major
>
> When a resource has a path less url as vanity path (eg:
> "http://www.example.com";) ResourceMapper.getAllMappings returns mappings
> consisting of an empty path "".
> This "" mapping can make {{SlingAuthenticatorServiceListener}} stop listening
> to further authentication requirements [0]:
> {code:xml}
> Exception in thread "pool-14-thread-1" java.lang.IllegalArgumentException:
> Configuration must not be null or empty
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementHolder.fromConfig(AuthenticationRequirementHolder.java:30)
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.addService(AuthenticationRequirementsManager.java:374)
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.process(AuthenticationRequirementsManager.java:300)
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.processQueue(AuthenticationRequirementsManager.java:281)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
> Clarification required:
> - Is "" mapping/path a valid path? Should we store and return vanity path as
> "/" in case of pathless url as vanity path?
> cc: [~cziegeler] [~rombert] [~reschke]
> [0]:
> https://github.com/apache/sling-org-apache-sling-auth-core/blob/org.apache.sling.auth.core-1.5.0/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticatorServiceListener.java#L345-L351
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…
reschke commented on code in PR #96:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185786325
##
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java:
##
@@ -397,8 +397,8 @@ public void mapResourceWithVanityPathsURLTargetNoPath() {
ExpectedMappings.existingResource("/vain-url-nopath")
.singleMapping("/vain-url-nopath")
.singleMappingWithRequest("/app/vain-url-nopath")
-.allMappings("/vain-url-nopath", "")
-.allMappingsWithRequest("/app/vain-url-nopath", "")
Review Comment:
This changes existing behavior. I believe this is very risky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-11861) ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url
[
https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719734#comment-17719734
]
Sagar Miglani commented on SLING-11861:
---
[~reschke] I believe it is a missed edge case at resourceresolver side, in case
of URL based vanity paths.
IMO empty path/mapping "" does not make any sense. I'm not sure if we are
allowed to add "" vanity path, but if API doesn't allow to add why it returns
an ""?
But if you think this is incorrect please feel free to close the PR as well as
this ticket, Thanks!
BTW, [~cziegeler] and [~rombert] what is you opinion on this?
> ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths
> is pathless url
> ---
>
> Key: SLING-11861
> URL: https://issues.apache.org/jira/browse/SLING-11861
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Sagar Miglani
>Priority: Major
>
> When a resource has a path less url as vanity path (eg:
> "http://www.example.com";) ResourceMapper.getAllMappings returns mappings
> consisting of an empty path "".
> This "" mapping can make {{SlingAuthenticatorServiceListener}} stop listening
> to further authentication requirements [0]:
> {code:xml}
> Exception in thread "pool-14-thread-1" java.lang.IllegalArgumentException:
> Configuration must not be null or empty
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementHolder.fromConfig(AuthenticationRequirementHolder.java:30)
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.addService(AuthenticationRequirementsManager.java:374)
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.process(AuthenticationRequirementsManager.java:300)
> at
> org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.processQueue(AuthenticationRequirementsManager.java:281)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
> Clarification required:
> - Is "" mapping/path a valid path? Should we store and return vanity path as
> "/" in case of pathless url as vanity path?
> cc: [~cziegeler] [~rombert] [~reschke]
> [0]:
> https://github.com/apache/sling-org-apache-sling-auth-core/blob/org.apache.sling.auth.core-1.5.0/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticatorServiceListener.java#L345-L351
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourceresolver] sagarmiglani commented on a diff in pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…
sagarmiglani commented on code in PR #96:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185836833
##
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java:
##
@@ -397,8 +397,8 @@ public void mapResourceWithVanityPathsURLTargetNoPath() {
ExpectedMappings.existingResource("/vain-url-nopath")
.singleMapping("/vain-url-nopath")
.singleMappingWithRequest("/app/vain-url-nopath")
-.allMappings("/vain-url-nopath", "")
-.allMappingsWithRequest("/app/vain-url-nopath", "")
Review Comment:
I agree, this is changing the behaviour, but what would be the blast radius?
Could there be too many people using pathless url based vanity paths?
Also test you pointed is from "improved test coverage" \[0] (changes under
SLING-11757):
```
@Test
public void mapResourceWithVanityPathsURLTargetNoPath() {
ExpectedMappings.existingResource("/vain-url-nopath")
.singleMapping("/vain-url-nopath")
.singleMappingWithRequest("/app/vain-url-nopath")
.allMappings("/vain-url-nopath", "")
.allMappingsWithRequest("/app/vain-url-nopath", "")
.verify(resolver, req);
}
```
and it has the following expectation which itself seems wrong:
`allMappingsWithRequest("/app/vain-url-nopath", "")`
Does it look right to you? Shouldn't the there be "/app" ("" appended with
the request context path) instead of ""?
When I run this test`[main] WARN
org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl - map: Unable
to mangle namespaces for returning unmangled`
[0]:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/94/files#diff-f6a4a27e96e7b9934452dc38379974ed9583083294ebe795081b1963ac4b2c6fR401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
RE: Prevent certain compile dependencies (was: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10)
yes, for this one and the OSGi annotations it would make sense. they are even in an unit test environment no candidates for compile scope. stefan > -Original Message- > From: Konrad Windszus > Sent: Thursday, May 4, 2023 4:08 PM > To: dev@sling.apache.org > Subject: Re: [VOTE] Release Apache Sling Event API version 1.0.2 and Event > 4.3.10 > > > a) on both modules org.jetbrains:annotations was added with compile > scope - should be provided. although not a problem for the bundle in OSGi > runtime, it should be fixed. i would propose making a new release for it, > esp. considering that the API bundle is released very rarely. > > Maybe we can prevent that a config of > https://maven.apache.org/enforcer/enforcer- > rules/bannedDependencies.html#banned-dependencies in the Sling parent. > I think there are potentially more candidates for that (OSGi annotation > dependencies). > WDYT?
RE: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10
yes, i would rather propose to do a new release to solve a), otherwise this issues stays around for quite a while. stefan > -Original Message- > From: Daniel Klco > Sent: Thursday, May 4, 2023 3:59 PM > To: dev@sling.apache.org > Subject: Re: [VOTE] Release Apache Sling Event API version 1.0.2 and Event > 4.3.10 > > Stefan, > > Thanks for the feedback, would you suggest canceling this release over > remark A? Not a problem if so, these are small changes to make. > > -Dan > > On Thu, May 4, 2023 at 3:53 AM Stefan Seifert e.com.invalid> wrote: > > > i've two remarks on this release: > > > > a) on both modules org.jetbrains:annotations was added with compile > > scope > > - should be provided. although not a problem for the bundle in OSGi > > runtime, it should be fixed. i would propose making a new release for > > it, esp. considering that the API bundle is released very rarely. > > > > b) cosmetic: the bnd.bnd. in the event module contains an explicit > > reference to sling.event.api-1.0.2, same as the pom.xml. it would be > > better to avoid the redundancy and define the actual version only in > > the POM, otherwise it might be forgotten to update in in both places > > in future updates. i think there are possibilities to express this via > expressions. > > this could be done in a follow-up release. > > > > stefan > > > > > -Original Message- > > > From: Daniel Klco > > > Sent: Wednesday, May 3, 2023 10:04 PM > > > To: dev@sling.apache.org > > > Subject: [VOTE] Release Apache Sling Event API version 1.0.2 and > > > Event > > > 4.3.10 > > > > > > Hi, > > > > > > We solved 2 issues in this release: > > > https://issues.apache.org/jira/projects/SLING/versions/12353195 > > > https://issues.apache.org/jira/projects/SLING/versions/12353051 > > > > > > There are still some outstanding issues: > > > https://issues.apache.org/jira/projects/SLING/versions/12344634 > > > https://issues.apache.org/jira/projects/SLING/versions/12353196 > > > > > > Staging repositories: > > > https://repository.apache.org/content/repositories/orgapachesling-27 > > > 40/ > > > https://repository.apache.org/content/repositories/orgapachesling-27 > > > 41/ > > > > > > You can use this UNIX script to download the release and verify the > > > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling- > > > release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > > sh check_staged_release.sh 2740 /tmp/sling-staging sh > > > check_staged_release.sh 2741 /tmp/sling-staging > > > > > > Please vote to approve this release: > > > > > > [ ] +1 Approve the release > > > [ ] 0 Don't care > > > [ ] -1 Don't release, because ... > > > > > > This majority vote is open for at least 72 hours. > >
[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…
reschke commented on code in PR #96:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185843290
##
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java:
##
@@ -397,8 +397,8 @@ public void mapResourceWithVanityPathsURLTargetNoPath() {
ExpectedMappings.existingResource("/vain-url-nopath")
.singleMapping("/vain-url-nopath")
.singleMappingWithRequest("/app/vain-url-nopath")
-.allMappings("/vain-url-nopath", "")
-.allMappingsWithRequest("/app/vain-url-nopath", "")
Review Comment:
When I added the tests, the goal was to capture the current functionality,
not to reason what the right functionality is. So what we add was adding test
coverage, and then fixing the NPE. That's it.
I understand you believe the behavior is wrong. You are likely right. But I
have zero insight what could break when we change it. IMHO it's safer, not
necessarily "better", to work around this in the calling code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
RE: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.2
+1 stefan
[GitHub] [sling-org-apache-sling-resourceresolver] sagarmiglani commented on a diff in pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…
sagarmiglani commented on code in PR #96:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185850447
##
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java:
##
@@ -397,8 +397,8 @@ public void mapResourceWithVanityPathsURLTargetNoPath() {
ExpectedMappings.existingResource("/vain-url-nopath")
.singleMapping("/vain-url-nopath")
.singleMappingWithRequest("/app/vain-url-nopath")
-.allMappings("/vain-url-nopath", "")
-.allMappingsWithRequest("/app/vain-url-nopath", "")
Review Comment:
> I understand you believe the behavior is wrong. You are likely right. But
I have zero insight what could break when we change it. IMHO it's safer, not
necessarily "better", to work around this in the calling code.
I agree with you, but atleast we should improve the API documentation that
`getAllMappings` could return "" as well in some cases. (i personally feel
blast radius of this should be small and we should correct the behaviour here)
cc: @cziegeler @rombert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.2
+1 (although having https://issues.apache.org/jira/browse/SLING-11750 integrated would have been nice, but for sure no blocker of this release) Konrad > On 4. May 2023, at 18:59, Robert Munteanu wrote: > > Hi, > > We solved 7 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352904 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2742/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2742 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu
[jira] [Created] (SLING-11862) Prevent usage of annotation dependencies with compile scope
Konrad Windszus created SLING-11862: --- Summary: Prevent usage of annotation dependencies with compile scope Key: SLING-11862 URL: https://issues.apache.org/jira/browse/SLING-11862 Project: Sling Issue Type: Improvement Components: General Reporter: Konrad Windszus Assignee: Konrad Windszus Fix For: Parent 50, Bundle Parent 50 As discussed in https://lists.apache.org/thread/b5yt7qs3gd9863p9868041v1f4gdd5l2 the annotations which don't have runtime retention should never appear in a runtime classpath nor as transitive dependency. Therefore for the OSGi annotation libraries as well as the Jetbrains annotations the dependencies should always have scope provided. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-parent] stefanseifert commented on pull request #34: SLING-11862 Prevent usage of annotation dependencies with compile scope
stefanseifert commented on PR #34: URL: https://github.com/apache/sling-parent/pull/34#issuecomment-1536140579 i get the same build error locally as reported by jenkins: "No rules are configured. Use the skip flag if you want to disable execution." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-parent] kwin commented on pull request #34: SLING-11862 Prevent usage of annotation dependencies with compile scope
kwin commented on PR #34: URL: https://github.com/apache/sling-parent/pull/34#issuecomment-1536177234 > i get the same build error locally as reported by jenkins: "No rules are configured. Use the skip flag if you want to disable execution." Sorry, my bad. Is fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-parent] sonarcloud[bot] commented on pull request #34: SLING-11862 Prevent usage of annotation dependencies with compile scope
sonarcloud[bot] commented on PR #34: URL: https://github.com/apache/sling-parent/pull/34#issuecomment-1536184918 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=34) [](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=34&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=34&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=34&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=34&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=34&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=34&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=34&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=34&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=34&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=34&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=34&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=34&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=34) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=34&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=34&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11482: - Labels: regression (was: ) > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Labels: regression > Fix For: JCR Resource 3.2.2 > > Time Spent: 2h 32m > Remaining Estimate: 0h > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719861#comment-17719861 ] Angela Schreiber commented on SLING-11482: -- see also SLING-11567 > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Labels: regression > Fix For: JCR Resource 3.2.2 > > Time Spent: 2h 32m > Remaining Estimate: 0h > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #163: [draft] remove toobig check
sonarcloud[bot] commented on PR #163: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/163#issuecomment-1536591545 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=163&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #137: Bump gson from 2.8.6 to 2.8.9
sonarcloud[bot] commented on PR #137: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/137#issuecomment-1536591283 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=137&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11860) OsgiServiceUtil may invoke the wrong method
[
https://issues.apache.org/jira/browse/SLING-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman updated SLING-11860:
Summary: OsgiServiceUtil may invoke the wrong method (was:
OsgiServiceUtil#activateDeactivate may invoke the wrong activate method)
> OsgiServiceUtil may invoke the wrong method
> ---
>
> Key: SLING-11860
> URL: https://issues.apache.org/jira/browse/SLING-11860
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Testing OSGi Mock 3.3.8
>
>
> The scenario where this happens is when the parent class has an activate(Map)
> method and the subclass has an activate(Config) method.
> When the context.registerInjectActivateService(..) call is invoked, it finds
> the activate(Map) method from the parent class and invokes it and then
> returns.
> Expected:
> The activate(Config) method from the subclass should have been the activate
> method that was invoked.
>
> For example:
>
> {code:java}
> public class ParentComponent {
> protected void activate(Map props) {
> // this should not be invoked when activating SubComponent
> }
> }
> @Designate(ocd=SubComponent.Config.class)
> public class SubComponent extends ParentComponent {
> @ObjectClassDefinition(name = "SubComponent Config")
> public @interface Config {
> @AttributeDefinition(name = "Prop One")
> boolean prop1() default true;
> }
> @Activate
> protected void activate(Config cfg) {
> // should be invoked when activating
> }
> } {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11860) OsgiServiceUtil may invoke the wrong method
[
https://issues.apache.org/jira/browse/SLING-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman updated SLING-11860:
Description:
Impacts both the activate/deactivate methods and the bind/unbind methods
The scenario where this happens is when the parent class has an
activate/deactivate/bind/unbind method with one set of arguments and the
subclass has an activate/deactivate/bind/unbind method with a different set of
arguments.
For example, when the context.registerInjectActivateService(..) call is
invoked, it finds the activate(Map) method from the parent class and invokes
it and then returns instead of calling the more specific activate(Config)
methods from the subclass.
{code:java}
public class ParentComponent {
protected void activate(Map props) {
// this should not be invoked when activating SubComponent
}
}
@Designate(ocd=SubComponent.Config.class)
public class SubComponent extends ParentComponent {
@ObjectClassDefinition(name = "SubComponent Config")
public @interface Config {
@AttributeDefinition(name = "Prop One")
boolean prop1() default true;
}
@Activate
protected void activate(Config cfg) {
// should be invoked when activating
}
} {code}
was:
The scenario where this happens is when the parent class has an activate(Map)
method and the subclass has an activate(Config) method.
When the context.registerInjectActivateService(..) call is invoked, it finds
the activate(Map) method from the parent class and invokes it and then returns.
Expected:
The activate(Config) method from the subclass should have been the activate
method that was invoked.
For example:
{code:java}
public class ParentComponent {
protected void activate(Map props) {
// this should not be invoked when activating SubComponent
}
}
@Designate(ocd=SubComponent.Config.class)
public class SubComponent extends ParentComponent {
@ObjectClassDefinition(name = "SubComponent Config")
public @interface Config {
@AttributeDefinition(name = "Prop One")
boolean prop1() default true;
}
@Activate
protected void activate(Config cfg) {
// should be invoked when activating
}
} {code}
> OsgiServiceUtil may invoke the wrong method
> ---
>
> Key: SLING-11860
> URL: https://issues.apache.org/jira/browse/SLING-11860
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Testing OSGi Mock 3.3.8
>
>
> Impacts both the activate/deactivate methods and the bind/unbind methods
> The scenario where this happens is when the parent class has an
> activate/deactivate/bind/unbind method with one set of arguments and the
> subclass has an activate/deactivate/bind/unbind method with a different set
> of arguments.
> For example, when the context.registerInjectActivateService(..) call is
> invoked, it finds the activate(Map) method from the parent class and invokes
> it and then returns instead of calling the more specific activate(Config)
> methods from the subclass.
> {code:java}
> public class ParentComponent {
> protected void activate(Map props) {
> // this should not be invoked when activating SubComponent
> }
> }
> @Designate(ocd=SubComponent.Config.class)
> public class SubComponent extends ParentComponent {
> @ObjectClassDefinition(name = "SubComponent Config")
> public @interface Config {
> @AttributeDefinition(name = "Prop One")
> boolean prop1() default true;
> }
> @Activate
> protected void activate(Config cfg) {
> // should be invoked when activating
> }
> } {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11860) OsgiServiceUtil may invoke the wrong method
[
https://issues.apache.org/jira/browse/SLING-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman updated SLING-11860:
Description:
Impacts both the activate/deactivate methods and the bind/unbind methods
The scenario where this happens is when the parent class has an
activate/deactivate/bind/unbind method with one set of arguments and the
subclass has an activate/deactivate/bind/unbind method with the same name but
with a different set of arguments.
For example, when the context.registerInjectActivateService(..) call is
invoked, it finds the activate(Map) method from the parent class and invokes
it and then returns instead of calling the more specific activate(Config)
methods from the subclass.
{code:java}
public class ParentComponent {
protected void activate(Map props) {
// this should not be invoked when activating SubComponent
}
}
@Designate(ocd=SubComponent.Config.class)
public class SubComponent extends ParentComponent {
@ObjectClassDefinition(name = "SubComponent Config")
public @interface Config {
@AttributeDefinition(name = "Prop One")
boolean prop1() default true;
}
@Activate
protected void activate(Config cfg) {
// should be invoked when activating
}
} {code}
was:
Impacts both the activate/deactivate methods and the bind/unbind methods
The scenario where this happens is when the parent class has an
activate/deactivate/bind/unbind method with one set of arguments and the
subclass has an activate/deactivate/bind/unbind method with a different set of
arguments.
For example, when the context.registerInjectActivateService(..) call is
invoked, it finds the activate(Map) method from the parent class and invokes
it and then returns instead of calling the more specific activate(Config)
methods from the subclass.
{code:java}
public class ParentComponent {
protected void activate(Map props) {
// this should not be invoked when activating SubComponent
}
}
@Designate(ocd=SubComponent.Config.class)
public class SubComponent extends ParentComponent {
@ObjectClassDefinition(name = "SubComponent Config")
public @interface Config {
@AttributeDefinition(name = "Prop One")
boolean prop1() default true;
}
@Activate
protected void activate(Config cfg) {
// should be invoked when activating
}
} {code}
> OsgiServiceUtil may invoke the wrong method
> ---
>
> Key: SLING-11860
> URL: https://issues.apache.org/jira/browse/SLING-11860
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Testing OSGi Mock 3.3.8
>
>
> Impacts both the activate/deactivate methods and the bind/unbind methods
> The scenario where this happens is when the parent class has an
> activate/deactivate/bind/unbind method with one set of arguments and the
> subclass has an activate/deactivate/bind/unbind method with the same name but
> with a different set of arguments.
> For example, when the context.registerInjectActivateService(..) call is
> invoked, it finds the activate(Map) method from the parent class and invokes
> it and then returns instead of calling the more specific activate(Config)
> methods from the subclass.
> {code:java}
> public class ParentComponent {
> protected void activate(Map props) {
> // this should not be invoked when activating SubComponent
> }
> }
> @Designate(ocd=SubComponent.Config.class)
> public class SubComponent extends ParentComponent {
> @ObjectClassDefinition(name = "SubComponent Config")
> public @interface Config {
> @AttributeDefinition(name = "Prop One")
> boolean prop1() default true;
> }
> @Activate
> protected void activate(Config cfg) {
> // should be invoked when activating
> }
> } {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-osgi-mock] enapps-enorman opened a new pull request, #26: SLING-11860 OsgiServiceUtil may invoke the wrong method
enapps-enorman opened a new pull request, #26: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26 Impacts both the activate/deactivate methods and the bind/unbind methods. The scenario where this happens is when the parent class has an activate/deactivate/bind/unbind method with one set of arguments and the subclass has an activate/deactivate/bind/unbind method with the same name but with a different set of arguments. For example, when the context.registerInjectActivateService(..) call is invoked, it finds the activate(Map) method from the parent class and invokes it and then returns instead of calling the more specific activate(Config) methods from the subclass. The fix proposed here is to change the method matching algorithm to be a "nearest match" approach where it checks all the possibilities on the current candidate class before walking up the superclasses to find a match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #26: SLING-11860 OsgiServiceUtil may invoke the wrong method
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26#issuecomment-1536609570 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_coverage&view=list) [93.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #26: SLING-11860 OsgiServiceUtil may invoke the wrong method
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26#issuecomment-1536619176 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_coverage&view=list) [93.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #26: SLING-11860 OsgiServiceUtil may invoke the wrong method
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26#issuecomment-1536622575 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_coverage&view=list) [93.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=26&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1536940263 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests&pullRequest=1&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #4: Bump activemq-client from 5.13.2 to 5.15.9
sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/4#issuecomment-1536949568 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jms&pullRequest=4) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms&pullRequest=4&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms&pullRequest=4&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms&pullRequest=4&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #1: Convert XML config to Java-Config
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-1536949635 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jms&pullRequest=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms&pullRequest=1&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms&pullRequest=1&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms&pullRequest=1&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1536949697 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jms&pullRequest=3) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms&pullRequest=3&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms&pullRequest=3&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms&pullRequest=3&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms&pullRequest=3&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
