[jira] [Resolved] (SLING-11869) MockUserManager should load and save home folder items
[
https://issues.apache.org/jira/browse/SLING-11869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman resolved SLING-11869.
-
Resolution: Fixed
Merged PR at:
[{{ea08010}}|https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/commit/ea08010516b8827430487adf3010976f3d1ac5cd]
> MockUserManager should load and save home folder items
> --
>
> Key: SLING-11869
> URL: https://issues.apache.org/jira/browse/SLING-11869
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Testing JCR Mock 1.6.10
>
>
> To support unit tests that interact with data stored in the user/group home
> folder, the MockUserManager should ensure that:
> # When creating a new user or group, ensure that the authorizable's path
> exists.
> # The MockUserManager needs to be aware of the items under the /home folder
> to discover users or groups that already exist.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-jcr-mock] enapps-enorman merged pull request #21: SLING-11869 MockUserManager should load and save home folder items
enapps-enorman merged PR #21: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-security] sonarcloud[bot] commented on pull request #8: SLING-11871 - Adding support for bypassing the ReferrerFilter for requests with an Origin header
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-security/pull/8#issuecomment-1544986313 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-security=8) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-security=8=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-security=8=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-security=8=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-security=8=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-security=8=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-security=8=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-security=8=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-security=8=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-security=8=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-security=8=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-security=8=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-security=8=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-security=8=new_coverage=list) [80.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-security=8=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-security=8=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-security=8=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-security] klcodanr opened a new pull request, #8: SLING-11871 - Adding support for bypassing the ReferrerFilter for requests with an Origin header
klcodanr opened a new pull request, #8: URL: https://github.com/apache/sling-org-apache-sling-security/pull/8 Adding support for bypassing the ReferrerFilter for requests with an Origin header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721970#comment-17721970 ] Dan Klco commented on SLING-11871: -- PR: https://github.com/apache/sling-org-apache-sling-security/pull/8 > Referrer Filter - Enable Bypass for Requests with Origin Header > --- > > Key: SLING-11871 > URL: https://issues.apache.org/jira/browse/SLING-11871 > Project: Sling > Issue Type: Improvement > Components: Sling Security >Affects Versions: Security 1.1.24 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Security 1.1.26 > > > The Referrer Filter in Apache Sling Security blocks requests without a > Referrer or a non-allow listed Referrer. Therefore Referrer filter will also > block external CORS requests which rather than using the Referrer, like > standard browser requests, use the Origin header. > We should therefore enable bypassing the ReferrerFilter for requests > containing an Origin header. These requests would need to be separately > validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
Dan Klco created SLING-11871: Summary: Referrer Filter - Enable Bypass for Requests with Origin Header Key: SLING-11871 URL: https://issues.apache.org/jira/browse/SLING-11871 Project: Sling Issue Type: Improvement Components: Sling Security Affects Versions: Security 1.1.24 Reporter: Dan Klco Assignee: Dan Klco Fix For: Security 1.1.26 The Referrer Filter in Apache Sling Security blocks requests without a Referrer or a non-allow listed Referrer. Therefore Referrer filter will also block external CORS requests which rather than using the Referrer, like standard browser requests, use the Origin header. We should therefore enable bypassing the ReferrerFilter for requests containing an Origin header. These requests would need to be separately validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11859) Avoid Duplicating API Version in Events BND
[ https://issues.apache.org/jira/browse/SLING-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11859. > Avoid Duplicating API Version in Events BND > --- > > Key: SLING-11859 > URL: https://issues.apache.org/jira/browse/SLING-11859 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Fix For: Event 4.3.12 > > > Found by Stefan Seifert: > cosmetic: the bnd.bnd. in the event module contains an explicit reference to > sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the > redundancy and define the actual version only in the POM, otherwise it might > be forgotten to update in in both places in future updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11831) Allow setting job properties for custom job state
[ https://issues.apache.org/jira/browse/SLING-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11831. > Allow setting job properties for custom job state > - > > Key: SLING-11831 > URL: https://issues.apache.org/jira/browse/SLING-11831 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Event 4.3.8 >Reporter: Andrew Khoury >Assignee: Dan Klco >Priority: Major > Fix For: Event 4.3.12, Event API 1.0.4 > > > The > [JobExecutionContext|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > currently allows updating Job progress info and the progress log but it > doesn't allow storing of custom properties. The reason we would want to > support custom properties is to allow storing resume information. > For example, let's say we have a job where we are moving multiple resources > around in a clustered environment with many sling instances pointing to the > same JCR repository (for example Oak MongoMK). If the instance that is > running the move job crashes in the middle of the job execution we would want > some information stored so the job can be resumed on another node. > To solve this issue, we can introduce a setProperty method to the > [JobExecutionContext.|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > This method would allow us to save some state information for use in case the > job is resumed on another node. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11316) Update sling.event.api to parent 47
[ https://issues.apache.org/jira/browse/SLING-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11316. > Update sling.event.api to parent 47 > --- > > Key: SLING-11316 > URL: https://issues.apache.org/jira/browse/SLING-11316 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Robert Munteanu >Priority: Major > Fix For: Event API 1.0.4 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11858) Fix Scope of org.jetbrains:annotations in Events / Events API
[ https://issues.apache.org/jira/browse/SLING-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11858. > Fix Scope of org.jetbrains:annotations in Events / Events API > - > > Key: SLING-11858 > URL: https://issues.apache.org/jira/browse/SLING-11858 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Event 4.3.12, Event API 1.0.4 > > > Found by Stefan Seifert: > on both modules org.jetbrains:annotations was added with compile scope - > should be provided. although not a problem for the bundle in OSGi runtime, it > should be fixed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Event API version 1.0.4 and Event 4.3.12
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Dan Klco, Jörg Hoh +1 (non binding): N/A I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. On Tue, May 9, 2023 at 4:20 PM Jörg Hoh wrote: > > +1 > > Jörg > > Am Mo., 8. Mai 2023 um 20:30 Uhr schrieb Daniel Klco : > > > Hi, > > > > We solved 4 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12353216 > > https://issues.apache.org/jira/projects/SLING/versions/12353196 > > > > There are still some outstanding issues: > > https://issues.apache.org/jira/projects/SLING/versions/12344634 > > https://issues.apache.org/jira/projects/SLING/versions/12353217 > > > > Staging repositories: > > https://repository.apache.org/content/repositories/orgapachesling-2743 > > https://repository.apache.org/content/repositories/orgapachesling-2745 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2743 /tmp/sling-staging > > sh check_staged_release.sh 2745 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1544430549 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-xing-login] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1544338489 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-xing-login=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-login=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-login=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-login=2=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1544338483 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-xing-oauth=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-xing-oauth=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_duplicated_lines_density=list) [7.3% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-xing-oauth=2=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #19: SLING-11231 - Support setting a version for MockBundles
sonarcloud[bot] commented on PR #19: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/19#issuecomment-1544209655 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock=19) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock=19=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=19=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=19=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=19=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=19=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11839) caconfig-mock-plugin: Support writing nested configurations and configuration collections
[ https://issues.apache.org/jira/browse/SLING-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-11839. Resolution: Fixed https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/commit/8d6b363600277858541e314a22558043c8eb928f > caconfig-mock-plugin: Support writing nested configurations and configuration > collections > - > > Key: SLING-11839 > URL: https://issues.apache.org/jira/browse/SLING-11839 > Project: Sling > Issue Type: New Feature > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Context-Aware Configuration Mock Plugin 1.5.0 > > > currently it's quite cumbersome to persist nested context-aware > configurations in unit tests, as the helper methods in > MockContextAwareConfig.writeConfiguration* only support writing single > configurations and configurations lists without nested structures. > without changing the API signatures of those, it should be supported that the > maps passed to this helper methods contain: > * nested maps which are persisted as nested configurations with the given key > * nested lists with maps with are persisted as nested configuration lists > with the given key -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-caconfig-mock-plugin] stefanseifert merged pull request #3: SLING-11839 Support writing nested configurations and configuration collections
stefanseifert merged PR #3: URL: https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11870) jcr-mock: Use org.apache.jackrabbit:oak-jcr as only oak dependency
[
https://issues.apache.org/jira/browse/SLING-11870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-11870:
---
Description:
jcr-mock users some helper classes from jackrabbit and oak for implementing the
mocks.
for this, some individual oak dependencies are declared in the POM, e.g.
{{oak-jackrabbit-api}} and recently added {{oak-security-spi}}, in
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/20 was
also discussion about {{oak-commons}}.
although usually it is best practice to reference exactly the artifact that
contains the required classes, it makes managing the oak version in downstream
projects more difficult, when the downstream projects want to test against a
newer version of oak. that downstream projects usually do not define every
single oak-dependency, but only {{oak-jcr}} which pulls in all other deps.
example:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/blob/e1692937ea4094ad5689429bdfae2dc0e85cf70d/pom.xml#L85-L105
to simplify the oak version management in unit test contexts, jcr-mock should
also directly reference {{oak-jcr}} and can use any classes in it's
dependencies.
was:
jcr-mock users some helper classes from jackrabbit and oak for implementing the
mocks.
for this, some individual oak dependencies are declared in the POM, e.g.
{{oak-jackrabbit-api}} and recently added {{oak-security-spi\\, in
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/20 was
also discussion about {{oak-commons}}.
although usually it is best practice to reference exactly the artifact that
contains the required classes, it makes managing the oak version in downstream
projects more difficult, when the downstream projects want to test against a
newer version of oak. that downstream projects usually do not define every
single oak-dependency, but only {{oak-jcr}} which pulls in all other deps.
example:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/blob/e1692937ea4094ad5689429bdfae2dc0e85cf70d/pom.xml#L85-L105
to simplify the oak version management in unit test contexts, jcr-mock should
also directly reference {{oak-jcr}} and can use any classes in it's
dependencies.
> jcr-mock: Use org.apache.jackrabbit:oak-jcr as only oak dependency
> --
>
> Key: SLING-11870
> URL: https://issues.apache.org/jira/browse/SLING-11870
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Affects Versions: Testing JCR Mock 1.6.8
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Testing JCR Mock 1.6.10
>
>
> jcr-mock users some helper classes from jackrabbit and oak for implementing
> the mocks.
> for this, some individual oak dependencies are declared in the POM, e.g.
> {{oak-jackrabbit-api}} and recently added {{oak-security-spi}}, in
> https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/20 was
> also discussion about {{oak-commons}}.
> although usually it is best practice to reference exactly the artifact that
> contains the required classes, it makes managing the oak version in
> downstream projects more difficult, when the downstream projects want to test
> against a newer version of oak. that downstream projects usually do not
> define every single oak-dependency, but only {{oak-jcr}} which pulls in all
> other deps. example:
> https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/blob/e1692937ea4094ad5689429bdfae2dc0e85cf70d/pom.xml#L85-L105
> to simplify the oak version management in unit test contexts, jcr-mock should
> also directly reference {{oak-jcr}} and can use any classes in it's
> dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-jcr-mock] stefanseifert commented on a diff in pull request #20: SLING-11868 jcr-mock: MockAuthorizable must not use java.nio.file.Paths
stefanseifert commented on code in PR #20:
URL:
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/20#discussion_r1190744250
##
src/main/java/org/apache/sling/testing/mock/jcr/MockAuthorizable.java:
##
@@ -67,7 +66,7 @@ abstract class MockAuthorizable implements Authorizable {
intermediatePath = "/home/users"; // NOSONAR
}
}
-this.path = Paths.get(intermediatePath, this.id).toString();
+this.path = intermediatePath + "/" + this.id;
Review Comment:
i've created https://issues.apache.org/jira/browse/SLING-11870 to streamline
the oak dependency in jcr-mock, we can approach this after #21 was merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (SLING-11870) jcr-mock: Use org.apache.jackrabbit:oak-jcr as only oak dependency
Stefan Seifert created SLING-11870:
--
Summary: jcr-mock: Use org.apache.jackrabbit:oak-jcr as only oak
dependency
Key: SLING-11870
URL: https://issues.apache.org/jira/browse/SLING-11870
Project: Sling
Issue Type: Improvement
Components: Testing
Affects Versions: Testing JCR Mock 1.6.8
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Fix For: Testing JCR Mock 1.6.10
jcr-mock users some helper classes from jackrabbit and oak for implementing the
mocks.
for this, some individual oak dependencies are declared in the POM, e.g.
{{oak-jackrabbit-api}} and recently added {{oak-security-spi\\, in
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/20 was
also discussion about {{oak-commons}}.
although usually it is best practice to reference exactly the artifact that
contains the required classes, it makes managing the oak version in downstream
projects more difficult, when the downstream projects want to test against a
newer version of oak. that downstream projects usually do not define every
single oak-dependency, but only {{oak-jcr}} which pulls in all other deps.
example:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/blob/e1692937ea4094ad5689429bdfae2dc0e85cf70d/pom.xml#L85-L105
to simplify the oak version management in unit test contexts, jcr-mock should
also directly reference {{oak-jcr}} and can use any classes in it's
dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11868) jcr-mock: MockAuthorizable must not use java.nio.file.Paths
[ https://issues.apache.org/jira/browse/SLING-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721647#comment-17721647 ] Stefan Seifert commented on SLING-11868: this will be fixed alongside the PR https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/21 for SLING-11869 which eliminates the code line using java.nio.file.Paths > jcr-mock: MockAuthorizable must not use java.nio.file.Paths > --- > > Key: SLING-11868 > URL: https://issues.apache.org/jira/browse/SLING-11868 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing JCR Mock 1.6.8 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing JCR Mock 1.6.10 > > > MockAuthorizable must not use java.nio.file.Paths to build JCR paths, as it > fails utterly on OS where the file separator is not "/" (windows). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-jcr-mock] stefanseifert commented on pull request #20: SLING-11868 jcr-mock: MockAuthorizable must not use java.nio.file.Paths
stefanseifert commented on PR #20: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/20#issuecomment-1543439324 superseded by #21 which eliminates the problematic code line using java.nio.file.Paths -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-jcr-mock] stefanseifert closed pull request #20: SLING-11868 jcr-mock: MockAuthorizable must not use java.nio.file.Paths
stefanseifert closed pull request #20: SLING-11868 jcr-mock: MockAuthorizable must not use java.nio.file.Paths URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
