[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration
[
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735995#comment-17735995
]
Angela Schreiber commented on SLING-11910:
--
[~madamcin] , yes, that's the oak side of it. the only class you missed to
mention is
org.apache.jackrabbit.oak.plugins.nodetype.TypeRegistration
see
[https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeRegistration.java]
for the list of validation it performs.
would what you found in oak address your concerns specified in you comment at
https://issues.apache.org/jira/browse/SLING-11910?focusedCommentId=17735814&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17735814
?
then the repoinit implementation in jcr.repoinit could simply rely on the JCR
repository to prevent troublesome modifications instead of trying to spot them
itself, which it likely cannot do to the full extend the repository is actually
able to do it.
in other words: we were back at my original suggestion to either introduce an
optional flag 'allowUpdate' or introduce a new method. either way the repoinit
implementation would not perform any validation but would just pass the boolean
flag with the registration method (either on NodeTypeManagere or on the
CND-registration from commons which calls the NodeTypeManager)
> Repoinit should support 'allowUpdate' option with node type registration
>
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with
> {{NodeTypeManager#registerNodeType}} and
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that
> specifies how to handle existing node type definitions upon registration.
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is
> no way to update an existing nodetype definition through RepoInit. Consumers
> of the API need to resort to programmatically update the node type using JCR
> API in a service.
> Here the extract from the specification (copied from
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an existing node type using the
> specified definition and returns the resulting NodeType object. Typically,
> the object passed to this method will be a NodeTypeTemplate (a subclass of
> NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and
> then filled-in with definition information. If allowUpdate is true then an
> attempt to change the definition of an already registered node type will be
> made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to
> register a node type with the same name as an already registered one will
> fail immediately.
> NodeTypeIterator NodeTypeManager.
> registerNodeTypes(NodeTypeDefinition[] ntds,
> boolean allowUpdate)
> registers or updates the specified array of NodeTypeDefinition objects. This
> method is used to register or update a set of node types with mutual
> dependencies. It returns an iterator over the resulting NodeType objects. The
> effect of the method is “all or nothing”; if an error occurs, no changes are
> made.
> h4. 19.2.4.1 Updating Node Types
> A repository that supports node type management may support updates to a node
> type already in use as the type of an existing node. The extent of any such
> capability is implementation dependent. For example, some implementations may
> permit only changes which do not invalidate existing content, while others
> may allow larger changes. How any resulting incompatibilities are resolved is
> also implementation dependent. Any changes to the type of an exiting node
> must take effect in accordance with the _node type assignment behavior_ of
> the repository (see §10.10.1 {_}Node Type Assignment Behavior{_}).
> {quote}
> We would therefore suggestion to either add an optional 'allowUpdate' (or
> 'reregister') flag the existing {{register nodetypes}} command (default would
> be 'false' to ensure backwards compatible behavior) or introduce a new
> command {{{}reregister nodetypes{}}}.
>
> Original use case from [~cschneider]:
> My use case is to extend an existing mixin with an additional property.
> For new repositories this works but for existing repositories the existing
> mixin is unchanged.
> As my code requires the new property I get errors.
>
[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration
[
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735864#comment-17735864
]
Mark Adamcin commented on SLING-11910:
--
[~angela] I tried to trace the behavior from NodeTypeManager in oak and this is
what I found:
An attempt to save a new nodetype registration state that contains at least one
non-"trivial" change will cause a full content scan with a
ConstraintViolationException to be thrown if the change is incompatible [1].
The definition of a "trivial change" is implemented in the NodeTypeDefDiff
class in both jackrabbit-spi-commons [2] and oak-core [3].
{quote}A *{{TRIVIAL}}* modification has no impact on the consistency of
existing content. The following modifications are considered {{{}TRIVIAL{}}}:
* changing node type {{orderableChildNodes}} flag
* changing node type {{primaryItemName}} value
* adding non-{{{}mandatory{}}} property/child node
* changing property/child node {{protected}} flag
* changing property/child node {{onParentVersion}} value
* changing property/child node {{mandatory}} flag to {{false}}
* changing property/child node {{autoCreated}} flag
* changing specific property/child node {{name}} to {{*}}
* changing child node {{defaultPrimaryType}}
* changing child node {{sameNameSiblings}} flag to {{true}}
* weaken child node {{requiredPrimaryTypes}} (e.g. by removing)
* weaken property {{valueConstraints}} (e.g. by removing a constraint or by
making a specific constraint less restrictive)
* changing property {{defaultValues}}
* changing specific property {{requiredType}} to {{undefined}}
* changing property {{multiple}} flag to {{true}}
A *{{MAJOR}}* modification potentially _affects_ the consistency of existing
content. All modifications that are not *{{TRIVIAL}}* are considered
{*}{{MAJOR}}{*}.
{quote}
[1]
[https://github.com/apache/jackrabbit-oak/blob/4352bb31fe5ef74e8601ff1feb44d8f200bec303/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeEditorProvider.java#L81-L111]
[2]
[https://github.com/apache/jackrabbit/blob/37ede49f7161bf627c5ed3b50202184d7111f38c/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/nodetype/NodeTypeDefDiff.java]
[3]
[https://github.com/apache/jackrabbit-oak/blob/4352bb31fe5ef74e8601ff1feb44d8f200bec303/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/NodeTypeDefDiff.java]
> Repoinit should support 'allowUpdate' option with node type registration
>
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with
> {{NodeTypeManager#registerNodeType}} and
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that
> specifies how to handle existing node type definitions upon registration.
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is
> no way to update an existing nodetype definition through RepoInit. Consumers
> of the API need to resort to programmatically update the node type using JCR
> API in a service.
> Here the extract from the specification (copied from
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an existing node type using the
> specified definition and returns the resulting NodeType object. Typically,
> the object passed to this method will be a NodeTypeTemplate (a subclass of
> NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and
> then filled-in with definition information. If allowUpdate is true then an
> attempt to change the definition of an already registered node type will be
> made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to
> register a node type with the same name as an already registered one will
> fail immediately.
> NodeTypeIterator NodeTypeManager.
> registerNodeTypes(NodeTypeDefinition[] ntds,
> boolean allowUpdate)
> registers or updates the specified array of NodeTypeDefinition objects. This
> method is used to register or update a set of node types with mutual
> dependencies. It returns an iterator over the resulting NodeType objects. The
> effect of the method is “all or nothing”; if an error occurs, no changes are
> made.
> h4. 19.2.4.1 Updating Node Types
> A repository that supports node type management may support updates to a node
> type already in use as the type of an existing node. The extent of any such
> capability i
[jira] [Commented] (SLING-11905) Starter builds fail on Windows nodes: Error getting the credentials for docker.io from the configured credential helper
[
https://issues.apache.org/jira/browse/SLING-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735830#comment-17735830
]
Robert Munteanu commented on SLING-11905:
-
After help from the ASF infra team we got to another error
{noformat}[ERROR] Failed to execute goal
io.fabric8:docker-maven-plugin:0.43.0:build (build-docker-image) on project
org.apache.sling.starter: Unable to pull 'docker.io/openjdk:17-slim' from
registry 'docker.io' : no matching manifest for windows/amd64 10.0.17763 in the
manifest list entries -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
io.fabric8:docker-maven-plugin:0.43.0:build (build-docker-image) on project
org.apache.sling.starter: Unable to pull 'docker.io/openjdk:17-slim' from
registry 'docker.io' : no matching manifest for windows/amd64 10.0.17763 in the
manifest list entries
{noformat}
Looks like we need to find a multi-arch JDK image.
> Starter builds fail on Windows nodes: Error getting the credentials for
> docker.io from the configured credential helper
>
>
> Key: SLING-11905
> URL: https://issues.apache.org/jira/browse/SLING-11905
> Project: Sling
> Issue Type: Bug
> Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 13
>
>
> The reported error is
> {noformat}[ERROR] Failed to execute goal
> io.fabric8:docker-maven-plugin:0.42.1:build (build-docker-image) on project
> org.apache.sling.starter: Error getting the credentials for docker.io from
> the configured credential helper: Failed to start 'docker-credential-desktop
> get' : Cannot run program "docker-credential-desktop": CreateProcess error=2,
> The system cannot find the file specified -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal io.fabric8:docker-maven-plugin:0.42.1:build (build-docker-image) on
> project org.apache.sling.starter: Error getting the credentials for docker.io
> from the configured credential helper
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:347)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:330)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:175)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:76)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:163)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:910)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:348)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error getting the
> credentials for docker.io from the configured credential helper
> at io.fabric8.maven.docker.util.CredentialHelperClient.getAuthConfig
> (CredentialHelperClient.java:49)
> at
> io.fabric8.ma
[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration
[
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735823#comment-17735823
]
Konrad Windszus commented on SLING-11910:
-
I think Oak and JR2 anyhow only ever allow Nodetype registration updates in
case they are additive i.e. don't make any existing node leveraging that type
invalid.
> Repoinit should support 'allowUpdate' option with node type registration
>
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with
> {{NodeTypeManager#registerNodeType}} and
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that
> specifies how to handle existing node type definitions upon registration.
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is
> no way to update an existing nodetype definition through RepoInit. Consumers
> of the API need to resort to programmatically update the node type using JCR
> API in a service.
> Here the extract from the specification (copied from
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an existing node type using the
> specified definition and returns the resulting NodeType object. Typically,
> the object passed to this method will be a NodeTypeTemplate (a subclass of
> NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and
> then filled-in with definition information. If allowUpdate is true then an
> attempt to change the definition of an already registered node type will be
> made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to
> register a node type with the same name as an already registered one will
> fail immediately.
> NodeTypeIterator NodeTypeManager.
> registerNodeTypes(NodeTypeDefinition[] ntds,
> boolean allowUpdate)
> registers or updates the specified array of NodeTypeDefinition objects. This
> method is used to register or update a set of node types with mutual
> dependencies. It returns an iterator over the resulting NodeType objects. The
> effect of the method is “all or nothing”; if an error occurs, no changes are
> made.
> h4. 19.2.4.1 Updating Node Types
> A repository that supports node type management may support updates to a node
> type already in use as the type of an existing node. The extent of any such
> capability is implementation dependent. For example, some implementations may
> permit only changes which do not invalidate existing content, while others
> may allow larger changes. How any resulting incompatibilities are resolved is
> also implementation dependent. Any changes to the type of an exiting node
> must take effect in accordance with the _node type assignment behavior_ of
> the repository (see §10.10.1 {_}Node Type Assignment Behavior{_}).
> {quote}
> We would therefore suggestion to either add an optional 'allowUpdate' (or
> 'reregister') flag the existing {{register nodetypes}} command (default would
> be 'false' to ensure backwards compatible behavior) or introduce a new
> command {{{}reregister nodetypes{}}}.
>
> Original use case from [~cschneider]:
> My use case is to extend an existing mixin with an additional property.
> For new repositories this works but for existing repositories the existing
> mixin is unchanged.
> As my code requires the new property I get errors.
>
> So I propose that repoinit allows to update existing mixins (and possibly
> other structures).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration
[
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735814#comment-17735814
]
Angela Schreiber commented on SLING-11910:
--
[~madamcin] , good point. I am not entirely sure though how you would find out
about the pure 'additive' nature of a node type definition. but as usual: feel
free to contribute a patch, it will be welcome.
> Repoinit should support 'allowUpdate' option with node type registration
>
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with
> {{NodeTypeManager#registerNodeType}} and
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that
> specifies how to handle existing node type definitions upon registration.
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is
> no way to update an existing nodetype definition through RepoInit. Consumers
> of the API need to resort to programmatically update the node type using JCR
> API in a service.
> Here the extract from the specification (copied from
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an existing node type using the
> specified definition and returns the resulting NodeType object. Typically,
> the object passed to this method will be a NodeTypeTemplate (a subclass of
> NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and
> then filled-in with definition information. If allowUpdate is true then an
> attempt to change the definition of an already registered node type will be
> made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to
> register a node type with the same name as an already registered one will
> fail immediately.
> NodeTypeIterator NodeTypeManager.
> registerNodeTypes(NodeTypeDefinition[] ntds,
> boolean allowUpdate)
> registers or updates the specified array of NodeTypeDefinition objects. This
> method is used to register or update a set of node types with mutual
> dependencies. It returns an iterator over the resulting NodeType objects. The
> effect of the method is “all or nothing”; if an error occurs, no changes are
> made.
> h4. 19.2.4.1 Updating Node Types
> A repository that supports node type management may support updates to a node
> type already in use as the type of an existing node. The extent of any such
> capability is implementation dependent. For example, some implementations may
> permit only changes which do not invalidate existing content, while others
> may allow larger changes. How any resulting incompatibilities are resolved is
> also implementation dependent. Any changes to the type of an exiting node
> must take effect in accordance with the _node type assignment behavior_ of
> the repository (see §10.10.1 {_}Node Type Assignment Behavior{_}).
> {quote}
> We would therefore suggestion to either add an optional 'allowUpdate' (or
> 'reregister') flag the existing {{register nodetypes}} command (default would
> be 'false' to ensure backwards compatible behavior) or introduce a new
> command {{{}reregister nodetypes{}}}.
>
> Original use case from [~cschneider]:
> My use case is to extend an existing mixin with an additional property.
> For new repositories this works but for existing repositories the existing
> mixin is unchanged.
> As my code requires the new property I get errors.
>
> So I propose that repoinit allows to update existing mixins (and possibly
> other structures).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration
[
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735801#comment-17735801
]
Mark Adamcin commented on SLING-11910:
--
[~cschneid] [~angela] I would ask that we add a stipulation that the
allowUpdate flag be passed to the NodeTypeManager only if the changes to
existing nodetype definitions are purely additive, so that on rollback to a
previous repoinit configuration, no attempt will be made to disallow properties
or child nodes that were created using the expanded nodetypes, which would
likely throw and prevent startup.
> Repoinit should support 'allowUpdate' option with node type registration
>
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with
> {{NodeTypeManager#registerNodeType}} and
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that
> specifies how to handle existing node type definitions upon registration.
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is
> no way to update an existing nodetype definition through RepoInit. Consumers
> of the API need to resort to programmatically update the node type using JCR
> API in a service.
> Here the extract from the specification (copied from
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an existing node type using the
> specified definition and returns the resulting NodeType object. Typically,
> the object passed to this method will be a NodeTypeTemplate (a subclass of
> NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and
> then filled-in with definition information. If allowUpdate is true then an
> attempt to change the definition of an already registered node type will be
> made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to
> register a node type with the same name as an already registered one will
> fail immediately.
> NodeTypeIterator NodeTypeManager.
> registerNodeTypes(NodeTypeDefinition[] ntds,
> boolean allowUpdate)
> registers or updates the specified array of NodeTypeDefinition objects. This
> method is used to register or update a set of node types with mutual
> dependencies. It returns an iterator over the resulting NodeType objects. The
> effect of the method is “all or nothing”; if an error occurs, no changes are
> made.
> h4. 19.2.4.1 Updating Node Types
> A repository that supports node type management may support updates to a node
> type already in use as the type of an existing node. The extent of any such
> capability is implementation dependent. For example, some implementations may
> permit only changes which do not invalidate existing content, while others
> may allow larger changes. How any resulting incompatibilities are resolved is
> also implementation dependent. Any changes to the type of an exiting node
> must take effect in accordance with the _node type assignment behavior_ of
> the repository (see §10.10.1 {_}Node Type Assignment Behavior{_}).
> {quote}
> We would therefore suggestion to either add an optional 'allowUpdate' (or
> 'reregister') flag the existing {{register nodetypes}} command (default would
> be 'false' to ensure backwards compatible behavior) or introduce a new
> command {{{}reregister nodetypes{}}}.
>
> Original use case from [~cschneider]:
> My use case is to extend an existing mixin with an additional property.
> For new repositories this works but for existing repositories the existing
> mixin is unchanged.
> As my code requires the new property I get errors.
>
> So I propose that repoinit allows to update existing mixins (and possibly
> other structures).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-servlets-resolver] joerghoh commented on a diff in pull request #37: SLING-11558 cache already resolved resources
joerghoh commented on code in PR #37:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/37#discussion_r1237045543
##
src/main/java/org/apache/sling/servlets/resolver/internal/helper/LocationCollector.java:
##
@@ -208,4 +209,75 @@ private void collectPaths() {
}
return rst;
}
+
+/**
+ * Resolve a path to a resource; the cacheMap is used for it.
+ * @param path the path
+ * @return the resource for it or null
+ */
+private @Nullable Resource resolveResource(@NotNull String path) {
+ if (cacheMap.containsKey(path)) {
+ return cacheMap.get(path);
+ } else {
+ Resource r = resolver.getResource(path);
+ cacheMap.put(path, r);
+ return r;
+ }
+}
+
+
+
+// static helpers ---
+
+ static @NotNull List getLocations(String resourceType, String
resourceSuperType, String baseResourceType,
+ ResourceResolver resolver) {
+
+ @SuppressWarnings("unchecked")
+ Map m = (Map)
resolver.getPropertyMap().get(CACHE_KEY);
+ if (m == null) {
+ m = new HashMap<>();
+ resolver.getPropertyMap().put(CACHE_KEY, m);
Review Comment:
The ``propertyMap`` of the ResourceResolver is "public" in a way, that
everyone who has access to that ResourceResolver can read and write it. That
means that any code accessing it can read and modify it.
I don't think that this is a big security concern, because at that point if
you have access to that object, you have your code already running in the JVM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] anchela commented on a diff in pull request #37: SLING-11558 cache already resolved resources
anchela commented on code in PR #37:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/37#discussion_r1236998781
##
src/main/java/org/apache/sling/servlets/resolver/internal/helper/LocationCollector.java:
##
@@ -73,12 +74,13 @@ class LocationCollector {
private final List result = new ArrayList<>();
private LocationCollector(String resourceType, String resourceSuperType,
String baseResourceType,
- ResourceResolver resolver) {
+ ResourceResolver resolver, Map
cacheMap) {
Review Comment:
i would suggest to consistently add @NotNull/@Nullable annotations to the
parameters. IMHO it improves maintainability of the code... when looking at the
patch it seems clear that 'cacheMap' is never null. but i wasn't so sure about
the other params.
##
src/main/java/org/apache/sling/servlets/resolver/internal/helper/LocationCollector.java:
##
@@ -208,4 +209,75 @@ private void collectPaths() {
}
return rst;
}
+
+/**
+ * Resolve a path to a resource; the cacheMap is used for it.
+ * @param path the path
+ * @return the resource for it or null
+ */
+private @Nullable Resource resolveResource(@NotNull String path) {
+ if (cacheMap.containsKey(path)) {
+ return cacheMap.get(path);
+ } else {
+ Resource r = resolver.getResource(path);
+ cacheMap.put(path, r);
+ return r;
+ }
+}
+
+
+
+// static helpers ---
+
+ static @NotNull List getLocations(String resourceType, String
resourceSuperType, String baseResourceType,
+ ResourceResolver resolver) {
+
+ @SuppressWarnings("unchecked")
+ Map m = (Map)
resolver.getPropertyMap().get(CACHE_KEY);
+ if (m == null) {
+ m = new HashMap<>();
+ resolver.getPropertyMap().put(CACHE_KEY, m);
Review Comment:
i have a few concerns regarding adding the cache to the property map of the
resource-resolver:
- the property map is public right? so this cache map might leak out, no?
- is there any chance that someone relies on the current values of the
property map? in other words: could adding a value that is purely for internal
processing cause regressions?
- i am not too familiar with the servlet-resolution bundle: but if the
resource-resolver instance is shared, this cache might be updated
concurrently so using a regular hashmap is likely causing issues with
concurrent updates as it is being populated upon the 'resolveResource' call.
my gut feeling: i would feel more comfortable if the resolver would
optionally allow for a separate internal caching mechanism instead of adding it
to the regular property map.
##
src/main/java/org/apache/sling/servlets/resolver/internal/helper/LocationCollector.java:
##
@@ -208,4 +209,75 @@ private void collectPaths() {
}
return rst;
}
+
+/**
+ * Resolve a path to a resource; the cacheMap is used for it.
+ * @param path the path
+ * @return the resource for it or null
+ */
+private @Nullable Resource resolveResource(@NotNull String path) {
+ if (cacheMap.containsKey(path)) {
+ return cacheMap.get(path);
+ } else {
+ Resource r = resolver.getResource(path);
+ cacheMap.put(path, r);
+ return r;
+ }
+}
+
+
+
+// static helpers ---
+
+ static @NotNull List getLocations(String resourceType, String
resourceSuperType, String baseResourceType,
+ ResourceResolver resolver) {
+
+ @SuppressWarnings("unchecked")
+ Map m = (Map)
resolver.getPropertyMap().get(CACHE_KEY);
+ if (m == null) {
+ m = new HashMap<>();
+ resolver.getPropertyMap().put(CACHE_KEY, m);
+ }
+ final Map cacheMap = m;
Review Comment:
that extra assignment is not really needed, is it?
##
src/main/java/org/apache/sling/servlets/resolver/internal/helper/LocationCollector.java:
##
@@ -208,4 +209,75 @@ private void collectPaths() {
}
return rst;
}
+
+/**
+ * Resolve a path to a resource; the cacheMap is used for it.
+ * @param path the path
+ * @return the resource for it or null
+ */
+private @Nullable Resource resolveResource(@NotNull String path) {
+ if (cacheMap.containsKey(path)) {
+ return cacheMap.get(path);
+ } else {
+ Resource r = resolver.getResource(path);
+ cacheMap.put(path, r);
+ return r;
+ }
+}
+
+
+
+// static helpers ---
+
+ static @NotNull List
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #882 is BROKEN
.validation' property with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE] [WARNING] [INFO] [jenkins-event-spy] Generated /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_11_latest@tmp/withMaven32d423a7/maven-spy-20230621-111840-1473339799789475971324.log [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:3.0.0-M5:verify (default) on project org.apache.sling.starter: There are test failures. [ERROR] [ERROR] Please refer to /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_11_latest/target/failsafe-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:3.0.0-M5:verify (default) on project org.apache.sling.starter: There are test failures. Please refer to /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_11_latest/target/failsafe-reports for the individual test results. Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:347) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175) at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76) at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163) at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:910) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283) at org.apache.maven.cli.MavenCli.main (MavenCli.java:206) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:566) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348) Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures. Please refer to /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_11_latest/target/failsafe-reports for the individual test results. Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. at org.apache.maven.plugin.surefire.SurefireHelper.throwException (SurefireHelper.java:271) at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution (SurefireHelper.java:159) at org.apache.maven.plugin.failsafe.VerifyMojo.execute (VerifyMojo.java:192) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:342) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175) at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76) at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163) at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160) at org.apache.maven.lifecycl
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #36: workaround RB issue from depends-maven-plugin
sonarcloud[bot] commented on PR #36: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/36#issuecomment-1600642218 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=36&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #37: SLING-11558 cache already resolved resources
sonarcloud[bot] commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/37#issuecomment-1600641766 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=37&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-1600641477 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_coverage&view=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_duplicated_lines_density&view=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-serviceusermapper] kwin commented on a diff in pull request #8: SLING-11912 - Empty configuration in ServiceUserMapperImpl's Required…
kwin commented on code in PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-serviceusermapper/pull/8#discussion_r1236737027
##
src/main/java/org/apache/sling/serviceusermapping/impl/ServiceUserMapperImpl.java:
##
@@ -559,6 +560,10 @@ private List
getPrincipalsValidators() {
return getValidatorsIfPresent(principalsValidators);
}
+private List filterEmptyStringValues(String[] arr) {
Review Comment:
I would add the null check on the array in here instead of outside this
method.
##
src/main/java/org/apache/sling/serviceusermapping/impl/ServiceUserMapperImpl.java:
##
@@ -559,6 +560,10 @@ private List
getPrincipalsValidators() {
return getValidatorsIfPresent(principalsValidators);
}
+private List filterEmptyStringValues(String[] arr) {
+return Arrays.stream(arr).filter(p ->
!p.trim().isEmpty()).collect(Collectors.toList());
Review Comment:
I would at least log that empty values are disregarded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (SLING-11912) Empty configuration in ServiceUserMapperImpl's Required Principal/User validators results in 503
[
https://issues.apache.org/jira/browse/SLING-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735639#comment-17735639
]
Konrad Windszus edited comment on SLING-11912 at 6/21/23 9:57 AM:
--
This sounds like a bug in the Felix web console. IMHO empty values are not
reasonable to support here. [~sagarmiglani] Can you propose a fix for
https://github.com/apache/felix-dev/blob/master/webconsole/src/main/java/org/apache/felix/webconsole/internal/configuration/ConfigManager.java
instead?
was (Author: kwin):
This sounds like a bug in the Felix web console. IMHO empty values are not
reasonable to support here.
> Empty configuration in ServiceUserMapperImpl's Required Principal/User
> validators results in 503
>
>
> Key: SLING-11912
> URL: https://issues.apache.org/jira/browse/SLING-11912
> Project: Sling
> Issue Type: Bug
> Components: Service User Mapper
>Affects Versions: Service User Mapper 1.5.6
>Reporter: Sagar Miglani
>Assignee: Sagar Miglani
>Priority: Major
> Fix For: Service User Mapper 1.5.8
>
>
> 1) In webconsole configuration manager, open {{Apache Sling Service User
> Mapper Serviceorg.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl}}
> 2) Before making any change the configuration is:
> {code:xml}
> :org.apache.felix.configadmin.revision:=L"1"
> require.validation=B"true"
> service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl"
> user.enable.default.mapping=B"false"
> {code}
> 3) Without changing the configuration click on {{save}}, the configuration
> becomes:
> {code:xml}
> :org.apache.felix.configadmin.revision:=L"8"
> require.validation=B"true"
> required.principal.validators=[ \
> "", \
> ]
> required.user.validators=[ \
> "", \
> ]
> service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl"
> user.default=""
> user.enable.default.mapping=B"false"
> {code}
> i.e {{required.principal.validators}} and {{required.user.validators}} have
> an empty value and due to this all sling requests return
> {code:xml}
> "HTTP ERROR 503 ServletResolver service missing, cannot service requests".
> {code}
> This persistence of empty configuration seems to be behaviour of
> {{felix.webconsole}}. But IMO sling requests should not fail due to empty
> values.
> (The above scenario was reproduced in an AEM instance)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11912) Empty configuration in ServiceUserMapperImpl's Required Principal/User validators results in 503
[
https://issues.apache.org/jira/browse/SLING-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735639#comment-17735639
]
Konrad Windszus commented on SLING-11912:
-
This sounds like a bug in the Felix web console. IMHO empty values are not
reasonable to support here.
> Empty configuration in ServiceUserMapperImpl's Required Principal/User
> validators results in 503
>
>
> Key: SLING-11912
> URL: https://issues.apache.org/jira/browse/SLING-11912
> Project: Sling
> Issue Type: Bug
> Components: Service User Mapper
>Affects Versions: Service User Mapper 1.5.6
>Reporter: Sagar Miglani
>Assignee: Sagar Miglani
>Priority: Major
> Fix For: Service User Mapper 1.5.8
>
>
> 1) In webconsole configuration manager, open {{Apache Sling Service User
> Mapper Serviceorg.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl}}
> 2) Before making any change the configuration is:
> {code:xml}
> :org.apache.felix.configadmin.revision:=L"1"
> require.validation=B"true"
> service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl"
> user.enable.default.mapping=B"false"
> {code}
> 3) Without changing the configuration click on {{save}}, the configuration
> becomes:
> {code:xml}
> :org.apache.felix.configadmin.revision:=L"8"
> require.validation=B"true"
> required.principal.validators=[ \
> "", \
> ]
> required.user.validators=[ \
> "", \
> ]
> service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl"
> user.default=""
> user.enable.default.mapping=B"false"
> {code}
> i.e {{required.principal.validators}} and {{required.user.validators}} have
> an empty value and due to this all sling requests return
> {code:xml}
> "HTTP ERROR 503 ServletResolver service missing, cannot service requests".
> {code}
> This persistence of empty configuration seems to be behaviour of
> {{felix.webconsole}}. But IMO sling requests should not fail due to empty
> values.
> (The above scenario was reproduced in an AEM instance)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11912) Empty configuration in ServiceUserMapperImpl's Required Principal/User validators results in 503
[
https://issues.apache.org/jira/browse/SLING-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-11912:
Fix Version/s: Service User Mapper 1.5.8
> Empty configuration in ServiceUserMapperImpl's Required Principal/User
> validators results in 503
>
>
> Key: SLING-11912
> URL: https://issues.apache.org/jira/browse/SLING-11912
> Project: Sling
> Issue Type: Bug
> Components: Service User Mapper
>Affects Versions: Service User Mapper 1.5.6
>Reporter: Sagar Miglani
>Assignee: Sagar Miglani
>Priority: Major
> Fix For: Service User Mapper 1.5.8
>
>
> 1) In webconsole configuration manager, open {{Apache Sling Service User
> Mapper Serviceorg.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl}}
> 2) Before making any change the configuration is:
> {code:xml}
> :org.apache.felix.configadmin.revision:=L"1"
> require.validation=B"true"
> service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl"
> user.enable.default.mapping=B"false"
> {code}
> 3) Without changing the configuration click on {{save}}, the configuration
> becomes:
> {code:xml}
> :org.apache.felix.configadmin.revision:=L"8"
> require.validation=B"true"
> required.principal.validators=[ \
> "", \
> ]
> required.user.validators=[ \
> "", \
> ]
> service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl"
> user.default=""
> user.enable.default.mapping=B"false"
> {code}
> i.e {{required.principal.validators}} and {{required.user.validators}} have
> an empty value and due to this all sling requests return
> {code:xml}
> "HTTP ERROR 503 ServletResolver service missing, cannot service requests".
> {code}
> This persistence of empty configuration seems to be behaviour of
> {{felix.webconsole}}. But IMO sling requests should not fail due to empty
> values.
> (The above scenario was reproduced in an AEM instance)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11912) Empty configuration in ServiceUserMapperImpl's Required Principal/User validators results in 503
[
https://issues.apache.org/jira/browse/SLING-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-11912:
---
Assignee: Sagar Miglani
> Empty configuration in ServiceUserMapperImpl's Required Principal/User
> validators results in 503
>
>
> Key: SLING-11912
> URL: https://issues.apache.org/jira/browse/SLING-11912
> Project: Sling
> Issue Type: Bug
> Components: Service User Mapper
>Affects Versions: Service User Mapper 1.5.6
>Reporter: Sagar Miglani
>Assignee: Sagar Miglani
>Priority: Major
>
> 1) In webconsole configuration manager, open {{Apache Sling Service User
> Mapper Serviceorg.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl}}
> 2) Before making any change the configuration is:
> {code:xml}
> :org.apache.felix.configadmin.revision:=L"1"
> require.validation=B"true"
> service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl"
> user.enable.default.mapping=B"false"
> {code}
> 3) Without changing the configuration click on {{save}}, the configuration
> becomes:
> {code:xml}
> :org.apache.felix.configadmin.revision:=L"8"
> require.validation=B"true"
> required.principal.validators=[ \
> "", \
> ]
> required.user.validators=[ \
> "", \
> ]
> service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl"
> user.default=""
> user.enable.default.mapping=B"false"
> {code}
> i.e {{required.principal.validators}} and {{required.user.validators}} have
> an empty value and due to this all sling requests return
> {code:xml}
> "HTTP ERROR 503 ServletResolver service missing, cannot service requests".
> {code}
> This persistence of empty configuration seems to be behaviour of
> {{felix.webconsole}}. But IMO sling requests should not fail due to empty
> values.
> (The above scenario was reproduced in an AEM instance)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11911) Use proper resource resolving in Sling Servlet Resolver web console
[
https://issues.apache.org/jira/browse/SLING-11911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-11911.
-
Resolution: Fixed
Fixed in
https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/b3eb8e642b71fea0c9cbd74b5f71b707e5d8e7ab.
> Use proper resource resolving in Sling Servlet Resolver web console
> ---
>
> Key: SLING-11911
> URL: https://issues.apache.org/jira/browse/SLING-11911
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Affects Versions: Servlets Resolver 2.9.12
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Servlets Resolver 2.9.14
>
>
> For historical reason the servlet resolver web console didn't actually
> resolve the resource to correctly decompose the URL but always used a
> heuristics. With SlingUriBuilder providing the method
> {{SlingUriBuilder.rebaseResourcePath()}} this now became much simpler and we
> can easily do the resolving in the web console in the same way like it is
> done in Sling.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-servlets-resolver] kwin merged pull request #38: SLING-11911 Use resource resolver in servlet resolver web console plugin
kwin merged PR #38: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories
[ https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-7486. - Resolution: Done > Remove tags of canceled releases from Subversion and Git repositories > - > > Key: SLING-7486 > URL: https://issues.apache.org/jira/browse/SLING-7486 > Project: Sling > Issue Type: Task > Components: Best practices, General >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > > ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO|| > |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|-remove- > keep (reactor is wrong, module is fine)| > |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|-remove- > keep (reactor is wrong, module is fine)| > |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|remove| > |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|remove| > |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|remove| > |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|remove| > |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|remove| > |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|remove| > |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|remove| > |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8|remove| > |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|remove| > |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT|remove| > |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT|remove| > |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0|remove| > |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0|remove| > |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|remove| > |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|remove| > |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|remove| > |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|remove| > |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|remove| > |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|remove| > |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|remove| > |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|remove| > |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|remove| > |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|remove| > |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|remove| > |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|remove| > |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|remove| > |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|remove| > |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|remove| > |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|remove| > |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|remove| > |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|remove| > |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT|remove| > |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT|remove| > |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3|remove| > |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10|keep| > |sling-ide-tooling-1.0.2|org.apache.sling.ide|reactor|1.0.2|keep| > |sling-ide-tooling-1.0.4|org.apache.sling.ide|reactor|1.0.4|keep| > |sling-ide-tooling-1.0.6|org.apache.sling.ide|reactor|1.0.6|keep| > |sling-ide-tooling-1.0.8|org.apache.sling.ide|reactor|1.0.8|keep| > |sling-ide-tooling-1.1.0|org.apache.sling.ide|reactor|1.1.0|keep| > |sling-initi
[jira] [Closed] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories
[ https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz closed SLING-7486. --- > Remove tags of canceled releases from Subversion and Git repositories > - > > Key: SLING-7486 > URL: https://issues.apache.org/jira/browse/SLING-7486 > Project: Sling > Issue Type: Task > Components: Best practices, General >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > > ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO|| > |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|-remove- > keep (reactor is wrong, module is fine)| > |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|-remove- > keep (reactor is wrong, module is fine)| > |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|remove| > |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|remove| > |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|remove| > |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|remove| > |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|remove| > |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|remove| > |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|remove| > |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8|remove| > |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|remove| > |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT|remove| > |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT|remove| > |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0|remove| > |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0|remove| > |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|remove| > |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|remove| > |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|remove| > |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|remove| > |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|remove| > |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|remove| > |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|remove| > |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|remove| > |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|remove| > |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|remove| > |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|remove| > |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|remove| > |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|remove| > |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|remove| > |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|remove| > |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|remove| > |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|remove| > |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|remove| > |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT|remove| > |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT|remove| > |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3|remove| > |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10|keep| > |sling-ide-tooling-1.0.2|org.apache.sling.ide|reactor|1.0.2|keep| > |sling-ide-tooling-1.0.4|org.apache.sling.ide|reactor|1.0.4|keep| > |sling-ide-tooling-1.0.6|org.apache.sling.ide|reactor|1.0.6|keep| > |sling-ide-tooling-1.0.8|org.apache.sling.ide|reactor|1.0.8|keep| > |sling-ide-tooling-1.1.0|org.apache.sling.ide|reactor|1.1.0|keep| > |sling-initial-content-archetype-1.0.
[jira] [Resolved] (SLING-7849) Support file channel operations
[ https://issues.apache.org/jira/browse/SLING-7849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-7849. - Resolution: Won't Do > Support file channel operations > --- > > Key: SLING-7849 > URL: https://issues.apache.org/jira/browse/SLING-7849 > Project: Sling > Issue Type: Sub-task > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons JCR File 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-5122) Use Oak security framework for XING Login
[
https://issues.apache.org/jira/browse/SLING-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-5122.
-
Resolution: Won't Do
> Use Oak security framework for XING Login
> -
>
> Key: SLING-5122
> URL: https://issues.apache.org/jira/browse/SLING-5122
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
>Affects Versions: Authentication XING Login 0.0.2
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Authentication XING Login 0.0.4
>
>
> use Oak security ({{javax.security.auth.spi.LoginModule}}) instead of
> {{org.apache.sling.jcr.jackrabbit.server.security.AuthenticationPlugin}}
> http://jackrabbit.apache.org/oak/docs/security/overview.html
> http://jackrabbit.apache.org/oak/docs/security/authentication/externalloginmodule.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-5123) Use Oak security framework for XING OAuth
[
https://issues.apache.org/jira/browse/SLING-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-5123.
---
> Use Oak security framework for XING OAuth
> -
>
> Key: SLING-5123
> URL: https://issues.apache.org/jira/browse/SLING-5123
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
>Affects Versions: Authentication XING OAuth 0.0.2
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Authentication XING OAuth 0.0.4
>
>
> use Oak security ({{javax.security.auth.spi.LoginModule}}) instead of
> {{org.apache.sling.jcr.jackrabbit.server.security.AuthenticationPlugin}}
> http://jackrabbit.apache.org/oak/docs/security/overview.html
> http://jackrabbit.apache.org/oak/docs/security/authentication/externalloginmodule.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-5122) Use Oak security framework for XING Login
[
https://issues.apache.org/jira/browse/SLING-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-5122.
---
> Use Oak security framework for XING Login
> -
>
> Key: SLING-5122
> URL: https://issues.apache.org/jira/browse/SLING-5122
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
>Affects Versions: Authentication XING Login 0.0.2
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Authentication XING Login 0.0.4
>
>
> use Oak security ({{javax.security.auth.spi.LoginModule}}) instead of
> {{org.apache.sling.jcr.jackrabbit.server.security.AuthenticationPlugin}}
> http://jackrabbit.apache.org/oak/docs/security/overview.html
> http://jackrabbit.apache.org/oak/docs/security/authentication/externalloginmodule.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-5123) Use Oak security framework for XING OAuth
[
https://issues.apache.org/jira/browse/SLING-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-5123.
-
Resolution: Won't Do
> Use Oak security framework for XING OAuth
> -
>
> Key: SLING-5123
> URL: https://issues.apache.org/jira/browse/SLING-5123
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
>Affects Versions: Authentication XING OAuth 0.0.2
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Authentication XING OAuth 0.0.4
>
>
> use Oak security ({{javax.security.auth.spi.LoginModule}}) instead of
> {{org.apache.sling.jcr.jackrabbit.server.security.AuthenticationPlugin}}
> http://jackrabbit.apache.org/oak/docs/security/overview.html
> http://jackrabbit.apache.org/oak/docs/security/authentication/externalloginmodule.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-7849) Support file channel operations
[ https://issues.apache.org/jira/browse/SLING-7849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz closed SLING-7849. --- > Support file channel operations > --- > > Key: SLING-7849 > URL: https://issues.apache.org/jira/browse/SLING-7849 > Project: Sling > Issue Type: Sub-task > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons JCR File 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-7846) Provide a NIO.2 file system implementation for JCR
[ https://issues.apache.org/jira/browse/SLING-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz closed SLING-7846. --- > Provide a NIO.2 file system implementation for JCR > -- > > Key: SLING-7846 > URL: https://issues.apache.org/jira/browse/SLING-7846 > Project: Sling > Issue Type: New Feature > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons JCR File 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-7846) Provide a NIO.2 file system implementation for JCR
[ https://issues.apache.org/jira/browse/SLING-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-7846. - Resolution: Won't Do > Provide a NIO.2 file system implementation for JCR > -- > > Key: SLING-7846 > URL: https://issues.apache.org/jira/browse/SLING-7846 > Project: Sling > Issue Type: New Feature > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons JCR File 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-7850) Support chroot
[ https://issues.apache.org/jira/browse/SLING-7850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-7850. - Resolution: Won't Do > Support chroot > -- > > Key: SLING-7850 > URL: https://issues.apache.org/jira/browse/SLING-7850 > Project: Sling > Issue Type: Sub-task > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons JCR File 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-7848) Support file and path operations
[ https://issues.apache.org/jira/browse/SLING-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-7848. - Resolution: Won't Do > Support file and path operations > > > Key: SLING-7848 > URL: https://issues.apache.org/jira/browse/SLING-7848 > Project: Sling > Issue Type: Sub-task > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons JCR File 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-7850) Support chroot
[ https://issues.apache.org/jira/browse/SLING-7850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz closed SLING-7850. --- > Support chroot > -- > > Key: SLING-7850 > URL: https://issues.apache.org/jira/browse/SLING-7850 > Project: Sling > Issue Type: Sub-task > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons JCR File 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-7851) Provide file transfer over SFTP for JCR
[ https://issues.apache.org/jira/browse/SLING-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-7851. - Resolution: Won't Do > Provide file transfer over SFTP for JCR > --- > > Key: SLING-7851 > URL: https://issues.apache.org/jira/browse/SLING-7851 > Project: Sling > Issue Type: New Feature > Components: JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: JCR File Transfer 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-7851) Provide file transfer over SFTP for JCR
[ https://issues.apache.org/jira/browse/SLING-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz closed SLING-7851. --- > Provide file transfer over SFTP for JCR > --- > > Key: SLING-7851 > URL: https://issues.apache.org/jira/browse/SLING-7851 > Project: Sling > Issue Type: New Feature > Components: JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: JCR File Transfer 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-7848) Support file and path operations
[ https://issues.apache.org/jira/browse/SLING-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz closed SLING-7848. --- > Support file and path operations > > > Key: SLING-7848 > URL: https://issues.apache.org/jira/browse/SLING-7848 > Project: Sling > Issue Type: Sub-task > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons JCR File 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-7847) Support basic file attributes
[ https://issues.apache.org/jira/browse/SLING-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-7847. - Resolution: Won't Do > Support basic file attributes > - > > Key: SLING-7847 > URL: https://issues.apache.org/jira/browse/SLING-7847 > Project: Sling > Issue Type: Sub-task > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons JCR File 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-7847) Support basic file attributes
[ https://issues.apache.org/jira/browse/SLING-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz closed SLING-7847. --- > Support basic file attributes > - > > Key: SLING-7847 > URL: https://issues.apache.org/jira/browse/SLING-7847 > Project: Sling > Issue Type: Sub-task > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons JCR File 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (SLING-11790) Provide Commons Permissions Option
[ https://issues.apache.org/jira/browse/SLING-11790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz reopened SLING-11790: -- > Provide Commons Permissions Option > -- > > Key: SLING-11790 > URL: https://issues.apache.org/jira/browse/SLING-11790 > Project: Sling > Issue Type: New Feature > Components: Testing >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Testing PaxExam 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (SLING-11791) Provide Commons Permissions Sling Option
[ https://issues.apache.org/jira/browse/SLING-11791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz reopened SLING-11791: -- > Provide Commons Permissions Sling Option > > > Key: SLING-11791 > URL: https://issues.apache.org/jira/browse/SLING-11791 > Project: Sling > Issue Type: New Feature > Components: Testing >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Testing PaxExam 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (SLING-11788) Provide Commons Permissions Sling feature
[ https://issues.apache.org/jira/browse/SLING-11788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz reopened SLING-11788: -- > Provide Commons Permissions Sling feature > - > > Key: SLING-11788 > URL: https://issues.apache.org/jira/browse/SLING-11788 > Project: Sling > Issue Type: New Feature > Components: Karaf >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Karaf Integration Tests 1.0.0, Karaf Distribution 1.0.0, > Karaf Features 1.0.0, Karaf Configs 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (SLING-11787) Provide Commons Permissions feature
[ https://issues.apache.org/jira/browse/SLING-11787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz reopened SLING-11787: -- > Provide Commons Permissions feature > --- > > Key: SLING-11787 > URL: https://issues.apache.org/jira/browse/SLING-11787 > Project: Sling > Issue Type: New Feature > Components: Karaf >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Karaf Integration Tests 1.0.0, Karaf Distribution 1.0.0, > Karaf Features 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (SLING-11341) Provide Commons Permissions API
[
https://issues.apache.org/jira/browse/SLING-11341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz reopened SLING-11341:
--
[No consent|https://lists.apache.org/thread/8vskcks9n1l0t6d0lljzdmpxm6c5k3m6].
> Provide Commons Permissions API
> ---
>
> Key: SLING-11341
> URL: https://issues.apache.org/jira/browse/SLING-11341
> Project: Sling
> Issue Type: New Feature
> Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Permissions 1.0.0
>
>
> {noformat}
> PermissionsService#hasPermission(principal:Principal,
> permission:String):boolean
> {noformat}
> https://github.com/apache/sling-org-apache-sling-commons-permissions
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (SLING-11688) Provide Commons Permissions Sling
[ https://issues.apache.org/jira/browse/SLING-11688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz reopened SLING-11688: -- > Provide Commons Permissions Sling > - > > Key: SLING-11688 > URL: https://issues.apache.org/jira/browse/SLING-11688 > Project: Sling > Issue Type: New Feature > Components: Commons, JCR >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Permissions Sling 1.0.0 > > > Implementation of the Sling Commons Permissions API based on Sling Resource > and JCR APIs > https://github.com/apache/sling-org-apache-sling-commons-permissions-sling -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11801) Switch to Commons Permissions API
[ https://issues.apache.org/jira/browse/SLING-11801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz closed SLING-11801. > Switch to Commons Permissions API > - > > Key: SLING-11801 > URL: https://issues.apache.org/jira/browse/SLING-11801 > Project: Sling > Issue Type: Improvement > Components: Sling Pipes >Affects Versions: Pipes 4.0.0 >Reporter: Oliver Lietz >Priority: Minor > > A common Permissions API was discussed in SLING-9556 (SLING-9644) and offline > ([~npeltier], [~bdelacretaz], [~pa.hupe]). > API: [https://github.com/apache/sling-org-apache-sling-commons-permissions] > Implementation: > [https://github.com/apache/sling-org-apache-sling-commons-permissions-sling] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11801) Switch to Commons Permissions API
[ https://issues.apache.org/jira/browse/SLING-11801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11801. -- Assignee: (was: Nicolas Peltier) Resolution: Won't Do [No consent for Commons Permissions|https://lists.apache.org/thread/8vskcks9n1l0t6d0lljzdmpxm6c5k3m6]. > Switch to Commons Permissions API > - > > Key: SLING-11801 > URL: https://issues.apache.org/jira/browse/SLING-11801 > Project: Sling > Issue Type: Improvement > Components: Sling Pipes >Affects Versions: Pipes 4.0.0 >Reporter: Oliver Lietz >Priority: Minor > > A common Permissions API was discussed in SLING-9556 (SLING-9644) and offline > ([~npeltier], [~bdelacretaz], [~pa.hupe]). > API: [https://github.com/apache/sling-org-apache-sling-commons-permissions] > Implementation: > [https://github.com/apache/sling-org-apache-sling-commons-permissions-sling] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-serviceusermapper] sagarmiglani commented on pull request #8: SLING-11912 - Empty configuration in ServiceUserMapperImpl's Required…
sagarmiglani commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-serviceusermapper/pull/8#issuecomment-1600414055 @anchela @kwin @cziegeler Could you please help with the review? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE][CANCELED] Release Apache Sling Commons Permissions 1.0.0
On Thursday, 9 March 2023 17:29:55 CEST Oliver Lietz wrote: > Hi, > > We solved 2 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/123525564 > > This is the initial release of the API module: > https://github.com/apache/sling-org-apache-sling-commons-permissions > > And implementation module can be found here: > https://github.com/apache/sling-org-apache-sling-commons-permissions-sling > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2723 [...] No consent. O.
[GitHub] [sling-org-apache-sling-serviceusermapper] sagarmiglani opened a new pull request, #8: SLING-11912 - Empty configuration in ServiceUserMapperImpl's Required…
sagarmiglani opened a new pull request, #8: URL: https://github.com/apache/sling-org-apache-sling-serviceusermapper/pull/8 … Principal/User validators results in 503 This PR is filtering out the empty values provided in `required.user.validators` and`required.principal.validators`. Empty values present in these configuration make sling request to return: `HTTP ERROR 503 ServletResolver service missing, cannot service requests` For more information, please have a look at SLING-11912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11912) Empty configuration in ServiceUserMapperImpl's Required Principal/User validators results in 503
Sagar Miglani created SLING-11912:
-
Summary: Empty configuration in ServiceUserMapperImpl's Required
Principal/User validators results in 503
Key: SLING-11912
URL: https://issues.apache.org/jira/browse/SLING-11912
Project: Sling
Issue Type: Bug
Components: Service User Mapper
Affects Versions: Service User Mapper 1.5.6
Reporter: Sagar Miglani
1) In webconsole configuration manager, open {{Apache Sling Service User Mapper
Serviceorg.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl}}
2) Before making any change the configuration is:
{code:xml}
:org.apache.felix.configadmin.revision:=L"1"
require.validation=B"true"
service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl"
user.enable.default.mapping=B"false"
{code}
3) Without changing the configuration click on {{save}}, the configuration
becomes:
{code:xml}
:org.apache.felix.configadmin.revision:=L"8"
require.validation=B"true"
required.principal.validators=[ \
"", \
]
required.user.validators=[ \
"", \
]
service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl"
user.default=""
user.enable.default.mapping=B"false"
{code}
i.e {{required.principal.validators}} and {{required.user.validators}} have an
empty value and due to this all sling requests return
{code:xml}
"HTTP ERROR 503 ServletResolver service missing, cannot service requests".
{code}
This persistence of empty configuration seems to be behaviour of
{{felix.webconsole}}. But IMO sling requests should not fail due to empty
values.
(The above scenario was reproduced in an AEM instance)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
