Re: Disabling dependabot for the whiteboard
+1 Robert Munteanu schrieb am Do. 6. Juli 2023 um 17:05: > Hi, > > Dependabot keeps creating PRs for the whiteboard module [1]. No one is > addressing them, and they're just lingering there. > > I think that this makes it harder to find actually useful PRs and that > it creates Jenkins checks for not good reason. > > Additionally, the Jenkins checks are not really useful since they use a > outdated reactor POM which does not contain all projects. > > Given this, I would disable dependabot checks outright for this repo. > > Thoughts? > > Thanks, > Robert > > [1]: https://github.com/apache/sling-whiteboard/pulls/app%2Fdependabot > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[jira] [Resolved] (SLING-11936) Sling Feature Maven Plugin fails on Java 17: module java.base does not "opens java.lang" to unnamed module @74fa148d
[ https://issues.apache.org/jira/browse/SLING-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11936. - Resolution: Fixed > Sling Feature Maven Plugin fails on Java 17: module java.base does not "opens > java.lang" to unnamed module @74fa148d > > > Key: SLING-11936 > URL: https://issues.apache.org/jira/browse/SLING-11936 > Project: Sling > Issue Type: Bug > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.7.2 > > > We probably need to upgrade Mockito, as documented at > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690#CommonIssueswhenbuildingwithnewerJDKs(11or17)-TestfailureswhentryingtoinstrumentclasseswithMockito > {noformat}[ERROR] > org.apache.sling.feature.maven.mojos.AnalyseFeaturesMojoTest.testTaskConfigurationSupplied > Time elapsed: 0.044 s <<< ERROR! > java.lang.ExceptionInInitializerError > at > org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167) > at > org.mockito.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25) > at > org.mockito.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:217) > at > org.mockito.cglib.core.KeyFactory$Generator.create(KeyFactory.java:145) > at org.mockito.cglib.core.KeyFactory.create(KeyFactory.java:117) > at org.mockito.cglib.core.KeyFactory.create(KeyFactory.java:109) > at org.mockito.cglib.core.KeyFactory.create(KeyFactory.java:105) > at org.mockito.cglib.proxy.Enhancer.(Enhancer.java:70) > at > org.mockito.internal.creation.cglib.ClassImposterizer.createProxyClass(ClassImposterizer.java:95) > at > org.mockito.internal.creation.cglib.ClassImposterizer.imposterise(ClassImposterizer.java:57) > at > org.mockito.internal.creation.cglib.ClassImposterizer.imposterise(ClassImposterizer.java:49) > at > org.mockito.internal.creation.cglib.CglibMockMaker.createMock(CglibMockMaker.java:24) > at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:33) > at org.mockito.internal.MockitoCore.mock(MockitoCore.java:59) > at org.mockito.Mockito.mock(Mockito.java:1285) > at org.mockito.Mockito.mock(Mockito.java:1163) > at > org.apache.sling.feature.maven.mojos.AnalyseFeaturesMojoTest.testTaskConfigurationSupplied(AnalyseFeaturesMojoTest.java:57) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:568) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at > org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) > at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) > at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158) > at >
[GitHub] [sling-slingfeature-maven-plugin] rombert merged pull request #73: SLING-11936 - Sling Feature Maven Plugin fails on Java 17: module java.base does not "opens java.lang" to unnamed module @74
rombert merged PR #73: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Disabling dependabot for the whiteboard
+1 On Thu, Jul 6, 2023 at 11:05 AM Robert Munteanu wrote: > Hi, > > Dependabot keeps creating PRs for the whiteboard module [1]. No one is > addressing them, and they're just lingering there. > > I think that this makes it harder to find actually useful PRs and that > it creates Jenkins checks for not good reason. > > Additionally, the Jenkins checks are not really useful since they use a > outdated reactor POM which does not contain all projects. > > Given this, I would disable dependabot checks outright for this repo. > > Thoughts? > > Thanks, > Robert > > [1]: https://github.com/apache/sling-whiteboard/pulls/app%2Fdependabot >
[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #73: SLING-11936 - Sling Feature Maven Plugin fails on Java 17: module java.base does not "opens java.lang" to unna
sonarcloud[bot] commented on PR #73: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/73#issuecomment-1623918767 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-slingfeature-maven-plugin=73) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=73=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=73=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=73=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=73=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=73=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=73=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=73=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=73=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=73=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=73=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=73=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=73=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=73=coverage=list) No Coverage information [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=73=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=73=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #904 is BROKEN
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/904/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: [...truncated 14357 lines...] } @media (min-width: 34em) { .Grid.Fit-Small > .Cell { -webkit-box-flex: 1; -webkit-flex: 1; -ms-flex: 1; flex: 1 } } @media (min-width: 48em) { .Grid.Fit-Medium > .Cell { -webkit-box-flex: 1; -webkit-flex: 1; -ms-flex: 1; flex: 1 } } @media (min-width: 62em) { .Grid .Cell.Large-15 { flex: 0 0 15% } .Grid .Cell.Large-25 { flex: 0 0 25% } .Grid .Cell.Large-35 { flex: 0 0 35% } .Grid .Cell.Large-50 { flex: 0 0 50% } .Grid.Fit-Large > .Cell { -webkit-box-flex: 1; -webkit-flex: 1; -ms-flex: 1; flex: 1 } } @media (min-width: 75em) { .Grid.Fit-Extra > .Cell { -webkit-box-flex: 1; -webkit-flex: 1; -ms-flex: 1; flex: 1 } } * { box-sizing: border-box } body { font-family: 'Open Sans', Helvetica, Arial; color: gray; position: relative; height: 100%; } h1 { font-size: 2.4em; color: #606060 } h2 { font-weight: 400; font-size: 1em } a { color: #00678c; text-decoration: none } a:hover { text-decoration: underline } a img { border: none } .Home-Grid { min-height: 100% } .Home-Grid .Gradient { flex: 0 0 100%; height: 16px; background:
[jira] [Commented] (SLING-11935) JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
[ https://issues.apache.org/jira/browse/SLING-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740670#comment-17740670 ] Robert Munteanu commented on SLING-11935: - I think you're spot on [~davidb], thanks for looking into this. That file has 124 lines, which is precisely the difference between the 'expected' and 'actual' sizes. I've disabled this particular test on Windows for now, I won't have time to make an actual fix, but if anyone has the time (and probably a Windows machine), PRs are welcome > JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows > > > Key: SLING-11935 > URL: https://issues.apache.org/jira/browse/SLING-11935 > Project: Sling > Issue Type: Bug > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Robert Munteanu >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.7.2 > > > This is the only CI failure, but I don't understand enough about the > JarDecompressor to make an informed fix. I will ignore the test on Windows > for now, but it would be great to understand the root cause and fix it. > {noformat}[ERROR] > org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar > Time elapsed: 0.071 s <<< FAILURE! > java.lang.AssertionError: expected:<2108> but was:<1984> > at org.junit.Assert.fail(Assert.java:89) > at org.junit.Assert.failNotEquals(Assert.java:835) > at org.junit.Assert.assertEquals(Assert.java:647) > at org.junit.Assert.assertEquals(Assert.java:633) > at > org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar(JarDecompressorTest.java:81) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:566) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at > org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) > at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) > at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428) > at > org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) > at > org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-slingfeature-maven-plugin] rombert merged pull request #72: SLING-11935 - JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
rombert merged PR #72: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11934) Plug-in ITs fail on Windows
[ https://issues.apache.org/jira/browse/SLING-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740661#comment-17740661 ] Robert Munteanu commented on SLING-11934: - I've disabled the invoker ITs on Windows to make the build pass. We will re-enable them once fixed. > Plug-in ITs fail on Windows > --- > > Key: SLING-11934 > URL: https://issues.apache.org/jira/browse/SLING-11934 > Project: Sling > Issue Type: Bug >Reporter: Robert Munteanu >Priority: Major > Fix For: Feature Launcher Maven Plugin 0.1.6 > > > Seen at > https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-feature-launcher-maven-plugin/detail/master/179/pipeline/59 > > {noformat} > [INFO] --- invoker:3.3.0:integration-test (integration-test) @ > feature-launcher-maven-plugin --- > [INFO] Building: empty-config-it\pom.xml > [INFO] run post-build script verify.groovy > [INFO] empty-config-it\pom.xml .. SUCCESS > (39.8 s) > [INFO] Building: simple-for-SLING-10956-it\pom.xml > Sending interrupt signal to process > [INFO] run post-build script verify.groovy > [INFO] simple-for-SLING-10956-it\pom.xml SUCCESS > (1622.0 s) > [INFO] Building: simple-it\pom.xml > script returned exit code -1 > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #72: SLING-11935 - JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
sonarcloud[bot] commented on PR #72: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/72#issuecomment-1623866449 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-slingfeature-maven-plugin=72) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=72=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=72=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=72=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=72=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=72=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=72=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=72=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=72=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=72=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=72=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=72=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=72=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=72=coverage=list) No Coverage information [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=72=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=72=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Disabling dependabot for the whiteboard
Hi, Dependabot keeps creating PRs for the whiteboard module [1]. No one is addressing them, and they're just lingering there. I think that this makes it harder to find actually useful PRs and that it creates Jenkins checks for not good reason. Additionally, the Jenkins checks are not really useful since they use a outdated reactor POM which does not contain all projects. Given this, I would disable dependabot checks outright for this repo. Thoughts? Thanks, Robert [1]: https://github.com/apache/sling-whiteboard/pulls/app%2Fdependabot
[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #185: chore(deps): update dependency com.h2database:h2-mvstore to v2.2.220
rombert merged PR #185: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11935) JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
[ https://issues.apache.org/jira/browse/SLING-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740637#comment-17740637 ] A. J. David Bosschaert commented on SLING-11935: I have no access to a Windows machine at the moment, but looking into it briefly I found that the test seems to be failing on this line: https://github.com/apache/sling-slingfeature-maven-plugin/blob/master/src/test/java/org/apache/sling/feature/maven/mojos/JarDecompressorTest.java#L81C35-L81C35 That line is comparing this file https://github.com/apache/sling-slingfeature-maven-plugin/blob/master/src/test/resources/repository/textfile.txt with the result of what was extracted out of the jar file. It looks like some automatic line feed conversion is done on the file compared against, because I think the difference is that the line feeds on windows are {{\r\n}} whereas in unix they're just {{\n}} which would add probably this number of bytes. > JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows > > > Key: SLING-11935 > URL: https://issues.apache.org/jira/browse/SLING-11935 > Project: Sling > Issue Type: Bug > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Robert Munteanu >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.7.2 > > > This is the only CI failure, but I don't understand enough about the > JarDecompressor to make an informed fix. I will ignore the test on Windows > for now, but it would be great to understand the root cause and fix it. > {noformat}[ERROR] > org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar > Time elapsed: 0.071 s <<< FAILURE! > java.lang.AssertionError: expected:<2108> but was:<1984> > at org.junit.Assert.fail(Assert.java:89) > at org.junit.Assert.failNotEquals(Assert.java:835) > at org.junit.Assert.assertEquals(Assert.java:647) > at org.junit.Assert.assertEquals(Assert.java:633) > at > org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar(JarDecompressorTest.java:81) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:566) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at > org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) > at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) > at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428) > at > org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) > at > org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-slingfeature-maven-plugin] rombert opened a new pull request, #73: SLING-11936 - Sling Feature Maven Plugin fails on Java 17: module java.base does not "opens java.lang" to unnamed mod
rombert opened a new pull request, #73: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/73 - updated to the latest version of mockito-core - replace usage of removed APIs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11936) Sling Feature Maven Plugin fails on Java 17: module java.base does not "opens java.lang" to unnamed module @74fa148d
Robert Munteanu created SLING-11936: --- Summary: Sling Feature Maven Plugin fails on Java 17: module java.base does not "opens java.lang" to unnamed module @74fa148d Key: SLING-11936 URL: https://issues.apache.org/jira/browse/SLING-11936 Project: Sling Issue Type: Bug Components: Feature Model, Maven Plugins and Archetypes Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: OSGi Feature Maven Plugin 1.7.2 We probably need to upgrade Mockito, as documented at https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690#CommonIssueswhenbuildingwithnewerJDKs(11or17)-TestfailureswhentryingtoinstrumentclasseswithMockito {noformat}[ERROR] org.apache.sling.feature.maven.mojos.AnalyseFeaturesMojoTest.testTaskConfigurationSupplied Time elapsed: 0.044 s <<< ERROR! java.lang.ExceptionInInitializerError at org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167) at org.mockito.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25) at org.mockito.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:217) at org.mockito.cglib.core.KeyFactory$Generator.create(KeyFactory.java:145) at org.mockito.cglib.core.KeyFactory.create(KeyFactory.java:117) at org.mockito.cglib.core.KeyFactory.create(KeyFactory.java:109) at org.mockito.cglib.core.KeyFactory.create(KeyFactory.java:105) at org.mockito.cglib.proxy.Enhancer.(Enhancer.java:70) at org.mockito.internal.creation.cglib.ClassImposterizer.createProxyClass(ClassImposterizer.java:95) at org.mockito.internal.creation.cglib.ClassImposterizer.imposterise(ClassImposterizer.java:57) at org.mockito.internal.creation.cglib.ClassImposterizer.imposterise(ClassImposterizer.java:49) at org.mockito.internal.creation.cglib.CglibMockMaker.createMock(CglibMockMaker.java:24) at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:33) at org.mockito.internal.MockitoCore.mock(MockitoCore.java:59) at org.mockito.Mockito.mock(Mockito.java:1285) at org.mockito.Mockito.mock(Mockito.java:1163) at org.apache.sling.feature.maven.mojos.AnalyseFeaturesMojoTest.testTaskConfigurationSupplied(AnalyseFeaturesMojoTest.java:57) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548) Caused by: java.lang.reflect.InaccessibleObjectException: Unable to
[jira] [Commented] (SLING-11935) JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
[ https://issues.apache.org/jira/browse/SLING-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740597#comment-17740597 ] Robert Munteanu commented on SLING-11935: - The jar decompression was added by [~davidb] for SLING-8692. David, maybe you have an idea about this specific test failure on Windows? > JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows > > > Key: SLING-11935 > URL: https://issues.apache.org/jira/browse/SLING-11935 > Project: Sling > Issue Type: Bug > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Robert Munteanu >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.7.2 > > > This is the only CI failure, but I don't understand enough about the > JarDecompressor to make an informed fix. I will ignore the test on Windows > for now, but it would be great to understand the root cause and fix it. > {noformat}[ERROR] > org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar > Time elapsed: 0.071 s <<< FAILURE! > java.lang.AssertionError: expected:<2108> but was:<1984> > at org.junit.Assert.fail(Assert.java:89) > at org.junit.Assert.failNotEquals(Assert.java:835) > at org.junit.Assert.assertEquals(Assert.java:647) > at org.junit.Assert.assertEquals(Assert.java:633) > at > org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar(JarDecompressorTest.java:81) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:566) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at > org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) > at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) > at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428) > at > org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) > at > org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-slingfeature-maven-plugin] rombert opened a new pull request, #72: SLING-11935 - JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
rombert opened a new pull request, #72: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/72 Don't run the problematic test on Windows -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11935) JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
Robert Munteanu created SLING-11935: --- Summary: JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows Key: SLING-11935 URL: https://issues.apache.org/jira/browse/SLING-11935 Project: Sling Issue Type: Bug Components: Feature Model, Maven Plugins and Archetypes Reporter: Robert Munteanu Fix For: OSGi Feature Maven Plugin 1.7.2 This is the only CI failure, but I don't understand enough about the JarDecompressor to make an informed fix. I will ignore the test on Windows for now, but it would be great to understand the root cause and fix it. {noformat}[ERROR] org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar Time elapsed: 0.071 s <<< FAILURE! java.lang.AssertionError: expected:<2108> but was:<1984> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar(JarDecompressorTest.java:81) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
RE: [VOTE] Release Apache Sling Maven Enforcer Rules 1.2.0
+1 stefan
RE: [VOTE] Release Apache Sling Parent and Bundle Parent version 50
+1 stefan
[jira] [Comment Edited] (SLING-11906) Migrate to slf4j 2.x
[ https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740111#comment-17740111 ] Konrad Windszus edited comment on SLING-11906 at 7/6/23 11:48 AM: -- Seems that was a deliberate decision from SLF4J to not export {{org.slf4j.helpers}} and {{org.slf4j.event}}, compare with https://jira.qos.ch/browse/SLF4J-579?focusedId=21673=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-21673: Maybe if we have a convincing use case for using the other packages outside of logging backends we can adjust that. Update: I added a comment in https://jira.qos.ch/browse/SLF4J-579?focusedId=21735=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-21735 was (Author: kwin): Seems that was a deliberate decision from SLF4J, compare with https://jira.qos.ch/browse/SLF4J-579?focusedId=21673=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-21673: Maybe if we have a convincing use case for using the other packages outside of logging backends we can adjust that. Update: I added a comment in https://jira.qos.ch/browse/SLF4J-579?focusedId=21735=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-21735 > Migrate to slf4j 2.x > > > Key: SLING-11906 > URL: https://issues.apache.org/jira/browse/SLING-11906 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Priority: Major > Fix For: Commons Log 6.0.0 > > > Increasingly more libraries have been migrating to slf4j 2.x (for example > logback 1.3+, tika 2.5+ and jetty 10+) > To be compatible with those, the sling commons log bundle should migrate to > slf4j v2.0.7 (and logback v1.4.7) > It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported > packages, so it should hopefully be compatible with existing bundles that are > importing the 1.x version of the slf4j packages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (SLING-11906) Migrate to slf4j 2.x
[ https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740111#comment-17740111 ] Konrad Windszus edited comment on SLING-11906 at 7/6/23 6:22 AM: - Seems that was a deliberate decision from SLF4J, compare with https://jira.qos.ch/browse/SLF4J-579?focusedId=21673=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-21673: Maybe if we have a convincing use case for using the other packages outside of logging backends we can adjust that. Update: I added a comment in https://jira.qos.ch/browse/SLF4J-579?focusedId=21735=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-21735 was (Author: kwin): Seems that was a deliberate decision from SLF4J, compare with https://jira.qos.ch/browse/SLF4J-579?focusedId=21673=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-21673: Maybe if we have a convincing use case for using the other packages outside of logging backends we can adjust that. > Migrate to slf4j 2.x > > > Key: SLING-11906 > URL: https://issues.apache.org/jira/browse/SLING-11906 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Priority: Major > Fix For: Commons Log 6.0.0 > > > Increasingly more libraries have been migrating to slf4j 2.x (for example > logback 1.3+, tika 2.5+ and jetty 10+) > To be compatible with those, the sling commons log bundle should migrate to > slf4j v2.0.7 (and logback v1.4.7) > It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported > packages, so it should hopefully be compatible with existing bundles that are > importing the 1.x version of the slf4j packages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x
[ https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740424#comment-17740424 ] Konrad Windszus commented on SLING-11906: - There are some hints in https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues/588 on how Eclipse managed to update. > Migrate to slf4j 2.x > > > Key: SLING-11906 > URL: https://issues.apache.org/jira/browse/SLING-11906 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Priority: Major > Fix For: Commons Log 6.0.0 > > > Increasingly more libraries have been migrating to slf4j 2.x (for example > logback 1.3+, tika 2.5+ and jetty 10+) > To be compatible with those, the sling commons log bundle should migrate to > slf4j v2.0.7 (and logback v1.4.7) > It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported > packages, so it should hopefully be compatible with existing bundles that are > importing the 1.x version of the slf4j packages. -- This message was sent by Atlassian Jira (v8.20.10#820010)