[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1636597289 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jms=3) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] hboutemy commented on pull request #36: workaround RB issue from depends-maven-plugin
hboutemy commented on PR #36: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/36#issuecomment-1636355988 @joerghoh 1.5.0 release available https://repo1.maven.org/maven2/org/apache/servicemix/tooling/depends-maven-plugin/ :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-11680) Eclipse plugins: Switch from Jarsigning to external GPG signatures
[ https://issues.apache.org/jira/browse/SLING-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11680: --- Assignee: (was: Konrad Windszus) > Eclipse plugins: Switch from Jarsigning to external GPG signatures > -- > > Key: SLING-11680 > URL: https://issues.apache.org/jira/browse/SLING-11680 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Konrad Windszus >Priority: Major > > Since recently Eclipse P2 supports external GPG signatures: > https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fp2_pgp.html > We should consider to use that instead of the complicated/error prone > Jarsigner process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11843. - Resolution: Fixed Fixed in https://github.com/apache/sling-tooling-jenkins/commit/f24fd764750cf29d00e8985a37e95e37b44c. > Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows > - > > Key: SLING-11843 > URL: https://issues.apache.org/jira/browse/SLING-11843 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Attachments: java11-install-build.log, > sling-org-apache-sling-scripting-groovy-#183.txt > > > Currently our Jenkins jobs by default only run on JDK8 with Linux. > I would propose to change the default (mentioned in > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues) > to > * Build with JDK 11 and 17 on > * Windows and Linux > Although this might break some builds, I think it is time now to make all > modules compatible with it once we touch it for whatever reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-11843. --- > Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows > - > > Key: SLING-11843 > URL: https://issues.apache.org/jira/browse/SLING-11843 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Attachments: java11-install-build.log, > sling-org-apache-sling-scripting-groovy-#183.txt > > > Currently our Jenkins jobs by default only run on JDK8 with Linux. > I would propose to change the default (mentioned in > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues) > to > * Build with JDK 11 and 17 on > * Windows and Linux > Although this might break some builds, I think it is time now to make all > modules compatible with it once we touch it for whatever reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #76: SLING-11948 Remove legacy maven-compat dependency
sonarcloud[bot] commented on PR #76: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/76#issuecomment-1636093679 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-slingfeature-maven-plugin=76) [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=76=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=76=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=76=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=76=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=76=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=76=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=76=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=76=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=76=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=76=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=76=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=76=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=76=new_coverage=list) [36.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=76=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=76=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=76=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-annotations] kwin merged pull request #5: Update parent to 51 to build with Java 17
kwin merged PR #5: URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-annotations] sonarcloud[bot] commented on pull request #5: Update parent to 51 to build with Java 17
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/5#issuecomment-1635974352 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-annotations=5) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-annotations=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-annotations=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-annotations=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-annotations=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-annotations=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-annotations=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-annotations=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-annotations=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-annotations=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-annotations=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-annotations=5=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-annotations=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-annotations=5=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-annotations=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-annotations=5=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-annotations] kwin opened a new pull request, #5: Update parent to 51 to build with Java 17
kwin opened a new pull request, #5: URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/5 Cleanup of ITs pom.xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-sling-mock] rubnig commented on a diff in pull request #24: SLING-10391 Implement encoding methods
rubnig commented on code in PR #24:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/24#discussion_r1263774621
##
core/src/main/java/org/apache/sling/testing/mock/sling/MockXSSAPIImpl.java:
##
@@ -127,32 +128,32 @@ public String getValidXML(@Nullable String xml, @Nullable
String defaultXml) {
@Override
public @Nullable String encodeForHTML(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forHtml(source);
}
@Override
public @Nullable String encodeForHTMLAttr(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forHtmlAttribute(source);
}
@Override
public @Nullable String encodeForXML(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forXml(source);
}
@Override
public @Nullable String encodeForXMLAttr(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forXmlAttribute(source);
}
@Override
public @Nullable String encodeForJSString(@Nullable String source) {
-return source;
+return source == null ? null :
Encode.forJavaScript(source).replace("\\-", "\\u002D");
Review Comment:
It was part of https://issues.apache.org/jira/browse/SLING-5946 and this is
how it is done in
https://github.com/apache/sling-org-apache-sling-xss/blame/b4c305a741cfe5a9ebad0e3c63f104ad1768d2e9/src/main/java/org/apache/sling/xss/impl/XSSAPIImpl.java#L401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-sling-mock] henrykuijpers commented on a diff in pull request #24: SLING-10391 Implement encoding methods
henrykuijpers commented on code in PR #24:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/24#discussion_r1263760741
##
core/src/main/java/org/apache/sling/testing/mock/sling/MockXSSAPIImpl.java:
##
@@ -127,32 +128,32 @@ public String getValidXML(@Nullable String xml, @Nullable
String defaultXml) {
@Override
public @Nullable String encodeForHTML(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forHtml(source);
}
@Override
public @Nullable String encodeForHTMLAttr(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forHtmlAttribute(source);
}
@Override
public @Nullable String encodeForXML(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forXml(source);
}
@Override
public @Nullable String encodeForXMLAttr(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forXmlAttribute(source);
}
@Override
public @Nullable String encodeForJSString(@Nullable String source) {
-return source;
+return source == null ? null :
Encode.forJavaScript(source).replace("\\-", "\\u002D");
}
@Override
public @Nullable String encodeForCSSString(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forCssString(source);
}
@Override
Review Comment:
It would have been nice to implement filterHTML too, maybe?
##
core/src/main/java/org/apache/sling/testing/mock/sling/MockXSSAPIImpl.java:
##
@@ -127,32 +128,32 @@ public String getValidXML(@Nullable String xml, @Nullable
String defaultXml) {
@Override
public @Nullable String encodeForHTML(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forHtml(source);
}
@Override
public @Nullable String encodeForHTMLAttr(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forHtmlAttribute(source);
}
@Override
public @Nullable String encodeForXML(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forXml(source);
}
@Override
public @Nullable String encodeForXMLAttr(@Nullable String source) {
-return source;
+return source == null ? null : Encode.forXmlAttribute(source);
}
@Override
public @Nullable String encodeForJSString(@Nullable String source) {
-return source;
+return source == null ? null :
Encode.forJavaScript(source).replace("\\-", "\\u002D");
Review Comment:
Would be nice to not do a regex replace here (`String.replace` accepts a
regex as parameter) + it replaces only the first hyphen. Then again, why is
this hyphen replace needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-10391) Improve MockXSSAPIImpl
[ https://issues.apache.org/jira/browse/SLING-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743173#comment-17743173 ] Henry Kuijpers commented on SLING-10391: Yes [~robin.bro...@amplexor.com] > Improve MockXSSAPIImpl > -- > > Key: SLING-10391 > URL: https://issues.apache.org/jira/browse/SLING-10391 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing Sling Mock 3.0.2 >Reporter: Henry Kuijpers >Priority: Major > > MockXSSAPIImpl only has a few very simplistic method implementations (i.e. > for encodeForHTML it returns the input as-is). > I think we can make some improvements to it, by: > * Use StringEscapeUtils.escapeHtml4() to do HTML escaping (so that we can at > least see a difference in the output) > * Use StringEscapeUtils.escapeXml() to do XML escaping > etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (SLING-10391) Improve MockXSSAPIImpl
[ https://issues.apache.org/jira/browse/SLING-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743170#comment-17743170 ] Robin Brouns edited comment on SLING-10391 at 7/14/23 1:42 PM: --- PR: [https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/24] is this what you need [~Henry Kuijpers] ? was (Author: robin.bro...@amplexor.com): PR: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/24 > Improve MockXSSAPIImpl > -- > > Key: SLING-10391 > URL: https://issues.apache.org/jira/browse/SLING-10391 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing Sling Mock 3.0.2 >Reporter: Henry Kuijpers >Priority: Major > > MockXSSAPIImpl only has a few very simplistic method implementations (i.e. > for encodeForHTML it returns the input as-is). > I think we can make some improvements to it, by: > * Use StringEscapeUtils.escapeHtml4() to do HTML escaping (so that we can at > least see a difference in the output) > * Use StringEscapeUtils.escapeXml() to do XML escaping > etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10391) Improve MockXSSAPIImpl
[ https://issues.apache.org/jira/browse/SLING-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743170#comment-17743170 ] Robin Brouns commented on SLING-10391: -- PR: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/24 > Improve MockXSSAPIImpl > -- > > Key: SLING-10391 > URL: https://issues.apache.org/jira/browse/SLING-10391 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing Sling Mock 3.0.2 >Reporter: Henry Kuijpers >Priority: Major > > MockXSSAPIImpl only has a few very simplistic method implementations (i.e. > for encodeForHTML it returns the input as-is). > I think we can make some improvements to it, by: > * Use StringEscapeUtils.escapeHtml4() to do HTML escaping (so that we can at > least see a difference in the output) > * Use StringEscapeUtils.escapeXml() to do XML escaping > etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-sling-mock] rubnig opened a new pull request, #24: SLING-10391 Implement encoding methods
rubnig opened a new pull request, #24: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/24 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #49: SLING-11546: Edited calendar toString method so it explicitly adds th…
sonarcloud[bot] commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-api/pull/49#issuecomment-1635879260 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-api=49) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=49=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=49=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=49=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=49=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=49=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=49=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api=49=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api=49=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api=49=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=49=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=49=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=49=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api=49=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api=49=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api=49=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api=49=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-api] rombert commented on pull request #49: SLING-11546: Edited calendar toString method so it explicitly adds th…
rombert commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-api/pull/49#issuecomment-1635828586 @JesseOosterwijk The master branch now builds cleanly on Java 17, can you please rebase your changes and push them so we get a meaningful CI check? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11965) Make API build with Java 17
[ https://issues.apache.org/jira/browse/SLING-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11965. - Resolution: Fixed > Make API build with Java 17 > --- > > Key: SLING-11965 > URL: https://issues.apache.org/jira/browse/SLING-11965 > Project: Sling > Issue Type: Task > Components: API >Affects Versions: API 2.27.2 >Reporter: Joerg Hoh >Assignee: Robert Munteanu >Priority: Major > Fix For: API 2.27.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-api] rombert merged pull request #50: SLING-11965 - Make API build with Java 17
rombert merged PR #50: URL: https://github.com/apache/sling-org-apache-sling-api/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #919 is BROKEN
implicit excludes. [INFO] 15 explicit excludes. [INFO] 21 resources included [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 20 licenses. [INFO] [INFO] --- docker:0.43.0:stop (stop-mongo) @ org.apache.sling.starter --- ESAPI: WARNING: System property [org.owasp.esapi.opsteam] is not set ESAPI: WARNING: System property [org.owasp.esapi.devteam] is not set ESAPI: Attempting to load ESAPI.properties via file I/O. ESAPI: Attempting to load ESAPI.properties as resource file via file I/O. ESAPI: Not found in 'org.owasp.esapi.resources' directory or file not readable: /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_21_latest/target/launchers/ESAPI.properties ESAPI: Not found in SystemResource Directory/resourceDirectory: .esapi/ESAPI.properties ESAPI: Not found in 'user.home' (/home/jenkins) directory: /home/jenkins/esapi/ESAPI.properties ESAPI: Loading ESAPI.properties via file I/O failed. Exception was: java.io.FileNotFoundException ESAPI: Attempting to load ESAPI.properties via the classpath. ESAPI: SUCCESSFULLY LOADED ESAPI.properties via the CLASSPATH from '/ (root)' using class loader for DefaultSecurityConfiguration class! ESAPI: SecurityConfiguration for Validator.ConfigurationFile.MultiValued not found in ESAPI.properties. Using default: false ESAPI: Attempting to load validation.properties via file I/O. ESAPI: Attempting to load validation.properties as resource file via file I/O. ESAPI: Not found in 'org.owasp.esapi.resources' directory or file not readable: /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_21_latest/target/launchers/validation.properties ESAPI: Not found in SystemResource Directory/resourceDirectory: .esapi/validation.properties ESAPI: Not found in 'user.home' (/home/jenkins) directory: /home/jenkins/esapi/validation.properties ESAPI: Loading validation.properties via file I/O failed. ESAPI: Attempting to load validation.properties via the classpath. ESAPI: SUCCESSFULLY LOADED validation.properties via the CLASSPATH from '/ (root)' using class loader for DefaultSecurityConfiguration class! [INFO] DOCKER> [mongo:4.4.6] "mongo": Stop and removed container 81d309f9acb8 after 0 ms [INFO] [INFO] --- failsafe:3.0.0-M5:verify (default) @ org.apache.sling.starter --- [INFO] Failsafe report directory: /home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master/jdk_17_latest/target/failsafe-reports [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 07:11 min [INFO] Finished at: 2023-07-14T11:25:34Z [INFO] [INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master/jdk_17_latest@tmp/withMaven2b716d6b/maven-spy-20230714-111823-2447390514955800192629.log [Pipeline] } [withMaven] Jenkins FindBugs Plugin not found, don't display org.codehaus.mojo:findbugs-maven-plugin:findbugs results in pipeline screen. [withMaven] jgivenPublisher - Jenkins JGiven Plugin not found, do not archive jgiven reports. [WARNING] Stream closed java.io.IOException: Stream closed at java.io.BufferedInputStream.getBufIfOpen (BufferedInputStream.java:188) at java.io.BufferedInputStream.read1 (BufferedInputStream.java:343) at java.io.BufferedInputStream.implRead (BufferedInputStream.java:420) at java.io.BufferedInputStream.read (BufferedInputStream.java:405) at sun.nio.cs.StreamDecoder.readBytes (StreamDecoder.java:329) at sun.nio.cs.StreamDecoder.implRead (StreamDecoder.java:372) at sun.nio.cs.StreamDecoder.lockedRead (StreamDecoder.java:215) at sun.nio.cs.StreamDecoder.read (StreamDecoder.java:169) at java.io.InputStreamReader.read (InputStreamReader.java:189) at java.io.BufferedReader.fill (BufferedReader.java:161) at java.io.BufferedReader.implReadLine (BufferedReader.java:371) at java.io.BufferedReader.readLine (BufferedReader.java:348) at java.io.BufferedReader.readLine (BufferedReader.java:437) at org.apache.sling.maven.feature.launcher.StartMojo$1.run (StartMojo.java:278) [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 07:12 min [INFO] Finished at: 2023-07-14T11:25:53Z [INFO] [INFO] [jenkins-event-spy] Generated /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_21_latest@tmp/withMaven97ee0744/maven-spy-20230714-111840-2647726132886869912511.log [ERROR] Failed to execute goal org.apache.sling:feature-launcher-maven-plugin:0.1.6:start (default) on project org.apache.sling.starter: Launch sling-starter-oak-tar failed to start in 120 second
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-1635705484 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=7) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #36: workaround RB issue from depends-maven-plugin
sonarcloud[bot] commented on PR #36: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/36#issuecomment-1635704255 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=36) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=36=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=36=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=36=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=36=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=36=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=36=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=36=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=36=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=36=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=36=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=36=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=36=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=36=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=36=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=36=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #37: SLING-11558 cache already resolved resources
sonarcloud[bot] commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/37#issuecomment-1635704203 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=37) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=37=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=37=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=37=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=37=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=37=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=37=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=37=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=37=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=37=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=37=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=37=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=37=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=37=new_coverage=list) [91.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=37=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=37=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=37=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11947) Convert Plexus to JSR330 components
[ https://issues.apache.org/jira/browse/SLING-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11947. - Resolution: Fixed Fixed in https://github.com/apache/sling-slingfeature-maven-plugin/commit/15be440adfc046f859a68203a74eace080a1740e. > Convert Plexus to JSR330 components > --- > > Key: SLING-11947 > URL: https://issues.apache.org/jira/browse/SLING-11947 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: OSGi Feature Maven Plugin 1.7.2 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.7.4 > > > As Plexus component descriptors are deprecated > (https://codehaus-plexus.github.io/plexus-containers/#deprecated) one should > migrate instead to the standard JSR330 annotations which are evaluated at run > time (https://github.com/eclipse/sisu.plexus/wiki/Plexus-to-JSR330) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-slingfeature-maven-plugin] kwin merged pull request #75: SLING-11947 Convert Plexus to JSR 330 components
kwin merged PR #75: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Rewriter: resource structure forcing a dependency on OSGI services
Hi, I want to bring up a topic, which has caused me headaches for quite some time. We have a rewriter configuration, which is stored within in the Sling Repository, and which is picked up any request. But we often see messages like this in the logs: org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught SlingException java.io.IOException: Unable to get component of class 'interface org.apache.sling.rewriter.Transformer' with type 'externallinks'. This is normally caused by the requested rewriter not being present and should vanish as soon as that service is present. But I also have seen cases, that the instance was not getting up because of this; *at least that's my impression, I have not closely analyzed it. (I hoped that this problem of instances not starting up properly was fixed with SSLING-11317, but I spotted this behavior afterwards as well.) The problem is the dependency of a repository structure to an OSGI service, which we cannot model with the means of OSGI (at least I am not aware of that); it will be always a polling mechanism to see if the service is present, and fail with an exception if not. Are you aware of a way to change this dependency and make it more OSGI-aware, and not starting the relevant parts of the sling engine if the requested rewriter is not present? Jörg -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
