[jira] [Commented] (SLING-11031) Registration of DisposalCallback is prone to lock contention
[
https://issues.apache.org/jira/browse/SLING-11031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743689#comment-17743689
]
Joerg Hoh commented on SLING-11031:
---
The problem is, that the {{RequestDisposableCallbacks.put()}} is synchronized
on the member {{callbacks}}, which is a ConcurrentHashMap.
So while the map itself does not require locking, the computation itself is in
its current form not atomic.
> Registration of DisposalCallback is prone to lock contention
>
>
> Key: SLING-11031
> URL: https://issues.apache.org/jira/browse/SLING-11031
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Affects Versions: Models Implementation 1.5.0
>Reporter: Joerg Hoh
>Priority: Major
>
> Under load the registration of the DisposalCallback for a Sling Model can
> block:
> {noformat}
> "80.187.114.130 [1639483979813] GET /content/foobar.html HTTP/1.1" #304
> prio=5 os_prio=0 cpu=6511.55ms elapsed=150.62s tid=0x5617e1dc0800
> nid=0x1d75 waiting for monitor entry [0x7ff060073000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at
> org.apache.sling.models.impl.ModelAdapterFactory$RequestDisposalCallbacks.put(ModelAdapterFactory.java:180)
> - waiting to lock <0x000669b01360> (a
> java.util.concurrent.ConcurrentHashMap)
> at
> org.apache.sling.models.impl.ModelAdapterFactory.registerRequestCallbackRegistry(ModelAdapterFactory.java:679)
> at
> org.apache.sling.models.impl.ModelAdapterFactory.createObject(ModelAdapterFactory.java:747)
> at
> org.apache.sling.models.impl.ModelAdapterFactory.internalCreateModel(ModelAdapterFactory.java:428)
> at
> org.apache.sling.models.impl.ModelAdapterFactory.getAdapter(ModelAdapterFactory.java:270)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapter(AdapterManagerImpl.java:143)
> at
> org.apache.sling.engine.impl.SlingMainServlet.adaptTo(SlingMainServlet.java:625)
> {noformat}
> We should check if it's possible to make the synchronized block smaller
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11946) Project Archetype build fails with Java 17
[
https://issues.apache.org/jira/browse/SLING-11946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-11946.
---
> Project Archetype build fails with Java 17
> --
>
> Key: SLING-11946
> URL: https://issues.apache.org/jira/browse/SLING-11946
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Project Archetype 1.0.12
>
>
> We are using outdated versions of the maven-bundle-plugin
> {noformat}[INFO] [ERROR] Failed to execute goal
> org.apache.felix:maven-bundle-plugin:4.2.0:bundle (default-bundle) on project
> core: Internal error in maven-bundle-plugin: ConcurrentModificationException
> -> [Help 1]
> [INFO] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute goal org.apache.felix:maven-bundle-plugin:4.2.0:bundle
> (default-bundle) on project core: Internal error in
> maven-bundle-plugin{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[RESULT] [VOTE] Release Project Archetype 1.0.12
Hi, The vote has passed with the following result: +1 (binding): Dan Klco, Joerg Hoh, Robert Munteanu +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
Re: [VOTE] Release Project Archetype 1.0.12
+1 Am Do., 13. Juli 2023 um 13:44 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12351459 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2768/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2768 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Project Archetype 1.0.12
On Thu, 2023-07-13 at 11:44 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
