[jira] [Resolved] (SLING-11912) Empty configuration in ServiceUserMapperImpl's Required Principal/User validators results in 503
[ https://issues.apache.org/jira/browse/SLING-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11912. -- Resolution: Fixed > Empty configuration in ServiceUserMapperImpl's Required Principal/User > validators results in 503 > > > Key: SLING-11912 > URL: https://issues.apache.org/jira/browse/SLING-11912 > Project: Sling > Issue Type: Bug > Components: Service User Mapper >Affects Versions: Service User Mapper 1.5.6 >Reporter: Sagar Miglani >Assignee: Sagar Miglani >Priority: Major > Fix For: Service User Mapper 1.5.8 > > > 1) In webconsole configuration manager, open {{Apache Sling Service User > Mapper Serviceorg.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl}} > 2) Before making any change the configuration is: > {code:xml} > :org.apache.felix.configadmin.revision:=L"1" > require.validation=B"true" > service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl" > user.enable.default.mapping=B"false" > {code} > 3) Without changing the configuration click on {{save}}, the configuration > becomes: > {code:xml} > :org.apache.felix.configadmin.revision:=L"8" > require.validation=B"true" > required.principal.validators=[ \ > "", \ > ] > required.user.validators=[ \ > "", \ > ] > service.pid="org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl" > user.default="" > user.enable.default.mapping=B"false" > {code} > i.e {{required.principal.validators}} and {{required.user.validators}} have > an empty value and due to this all sling requests return > {code:xml} > "HTTP ERROR 503 ServletResolver service missing, cannot service requests". > {code} > This persistence of empty configuration seems to be behaviour of > {{felix.webconsole}}. But IMO sling requests should not fail due to empty > values. > (The above scenario was reproduced in an AEM instance) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-serviceusermapper] cziegeler merged pull request #8: SLING-11912 - Empty configuration in ServiceUserMapperImpl's Required…
cziegeler merged PR #8: URL: https://github.com/apache/sling-org-apache-sling-serviceusermapper/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling Auth Core 1.6.2
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING-11867 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2771 You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2771 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[GitHub] [sling-org-apache-sling-serviceusermapper] cziegeler commented on pull request #8: SLING-11912 - Empty configuration in ServiceUserMapperImpl's Required…
cziegeler commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-serviceusermapper/pull/8#issuecomment-1643193182 @sagarmiglani Could you maybe add the logging as requested by @kwin ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Apache Sling Parent & Bundle Parent 52
+1 On Wed, Jul 19, 2023 at 4:54 AM Robert Munteanu wrote: > On Tue, 2023-07-18 at 14:27 +0200, Konrad Windszus wrote: > > Please vote to approve this release: > > +1 > Robert >
Re: [VOTE] Release Apache Sling Commons Johnzon Wrapper Library 1.2.16
+1 On Wed, Jul 19, 2023 at 1:24 PM Jörg Hoh wrote: > +1 > > Am Mi., 19. Juli 2023 um 18:08 Uhr schrieb Robert Munteanu < > romb...@apache.org>: > > > Hi, > > > > We solved 1 issue in this release: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12351880=Text > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2770 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 2770 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Thanks, > > Robert > > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh >
[GitHub] [sling-org-apache-sling-commons-johnzon] coheigea commented on pull request #3: SLING-11973 - Updating to Johnzon 1.2.21
coheigea commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-commons-johnzon/pull/3#issuecomment-1642627382 Awesome thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Commons Johnzon Wrapper Library 1.2.16
+1 Am Mi., 19. Juli 2023 um 18:08 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 1 issue in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12351880=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2770 > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2770 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Thanks, > Robert > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #927 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/927/ for details. No further emails will be sent until the status of the build is changed.
RE: [VOTE] Release Apache Sling Commons Johnzon Wrapper Library 1.2.16
+1 stefan
[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #193: chore(deps): update dependency org.apache.jackrabbit.vault:org.apache.jackrabbit.vault to v3.7.0
rombert merged PR #193: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Commons Johnzon Wrapper Library 1.2.16
On Wed, 2023-07-19 at 19:07 +0300, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling Commons Johnzon Wrapper Library 1.2.16
+1 Carsten On 19.07.2023 18:07, Robert Munteanu wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12351880=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2770 You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2770 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Thanks, Robert -- Carsten Ziegeler Adobe cziege...@apache.org
[GitHub] [sling-org-apache-sling-commons-johnzon] rombert commented on pull request #3: SLING-11973 - Updating to Johnzon 1.2.21
rombert commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-commons-johnzon/pull/3#issuecomment-1642370998 Release vote started - https://lists.apache.org/thread/368kg8s9dz4z33h2concmt33wb38m8qq . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling Commons Johnzon Wrapper Library 1.2.16
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12351880=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2770 You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2770 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Thanks, Robert
[jira] [Resolved] (SLING-11973) Update to Johnzon 1.2.21
[ https://issues.apache.org/jira/browse/SLING-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11973. - Resolution: Fixed > Update to Johnzon 1.2.21 > > > Key: SLING-11973 > URL: https://issues.apache.org/jira/browse/SLING-11973 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Commons Johnzon 1.2.16 > > > This fixes https://nvd.nist.gov/vuln/detail/CVE-2023-33008 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-commons-johnzon] rombert merged pull request #3: SLING-11973 - Updating to Johnzon 1.2.21
rombert merged PR #3: URL: https://github.com/apache/sling-org-apache-sling-commons-johnzon/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #20: [SECURITY] Fix Temporary File Information Disclosure Vulnerability
sonarcloud[bot] commented on PR #20: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/20#issuecomment-1642335523 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-post=20) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=20=false=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=20=false=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=20=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=CODE_SMELL) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=20=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=20=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=20=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=20=new_duplicated_lines_density=list) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'sonarlint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #38: SLING-11970 : Avoid restarting of components on configuration change
sonarcloud[bot] commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#issuecomment-1642335198 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine=38) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [![B](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B-16px.png 'B')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [5 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [![B](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B-16px.png 'B')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_duplicated_lines_density=list) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'sonarlint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11970) Avoid restarting of services on configuration change
[ https://issues.apache.org/jira/browse/SLING-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11970. -- Resolution: Fixed > Avoid restarting of services on configuration change > > > Key: SLING-11970 > URL: https://issues.apache.org/jira/browse/SLING-11970 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.15.2 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.15.4 > > > When the configuration for the Engine changes, the components consuming this > configuration all implement "modified" - so these components itself do not > restart. > However, components depending (referencing) the above might restart as they > have a static reference. > We could avoid restarting on configuration change by using dynamic (required) > references -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-commons-johnzon] sonarcloud[bot] commented on pull request #3: SLING-11973 - Updating to Johnzon 1.2.21
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-commons-johnzon/pull/3#issuecomment-1642333269 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-johnzon=3) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-johnzon=3=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-johnzon=3=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-johnzon=3=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-johnzon=3=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-johnzon=3=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-johnzon=3=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-johnzon=3=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-johnzon=3=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-johnzon=3=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-johnzon=3=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-johnzon=3=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-johnzon=3=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-johnzon=3) No Coverage information [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-johnzon=3=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-johnzon=3=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #38: SLING-11970 : Avoid restarting of components on configuration change
sonarcloud[bot] commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#issuecomment-1642330344 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine=38) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [![B](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B-16px.png 'B')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [5 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [![B](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B-16px.png 'B')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [![13.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '13.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_coverage=list) [13.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_duplicated_lines_density=list) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'sonarlint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #193: chore(deps): update dependency org.apache.jackrabbit.vault:org.apache.jackrabbit.vault to v3.7.0
renovate-bot opened a new pull request, #193: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/193 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.jackrabbit.vault:org.apache.jackrabbit.vault](https://jackrabbit.apache.org/filevault/) | `3.6.8` -> `3.7.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.jackrabbit.vault:org.apache.jackrabbit.vault/3.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.jackrabbit.vault:org.apache.jackrabbit.vault/3.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.jackrabbit.vault:org.apache.jackrabbit.vault/3.6.8/3.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.jackrabbit.vault:org.apache.jackrabbit.vault/3.6.8/3.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #22: SLING-11971 Adding additional logging for sling post processors
sonarcloud[bot] commented on PR #22: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22#issuecomment-1642298463 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-post=22) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=22=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=22=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=22=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=CODE_SMELL) [![15.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '15.8%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=22=new_coverage=list) [15.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=22=new_coverage=list) [![3.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5-16px.png '3.3%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=22=new_duplicated_lines_density=list) [3.3% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=22=new_duplicated_lines_density=list) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'sonarlint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: More Sling GraphQL Core Jenkins Wows
Please check out https://issues.apache.org/jira/browse/INFRA-24767. > On 19. Jul 2023, at 14:58, Andreas Schaefer wrote: > > Hi > > After limiting the Jenkins build to JDK 11 to release a fix required for the > last release the build is still failing with a pretty weird issue: > > https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/4/pipeline/ > > > It cannot download the JAR file: > > Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not > transfer artifact commons-lang:commons-lang:pom:2.3 from/to central > (https://repo.maven.apache.org/maven2): Connection reset > at > org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed > (ArtifactTransportListener.java:44) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run > (BasicRepositoryConnector.java:417) > > Right before that the build could download the commons-lang POM file w/o any > issues so I am not sure what is going on. > > - Andy
[GitHub] [sling-org-apache-sling-commons-johnzon] rombert commented on pull request #3: Updating to Johnzon 1.2.21
rombert commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-commons-johnzon/pull/3#issuecomment-1642156476 Thanks for the PR @coheigea . I reverted the versioning change in 9d949509e33dcbe39983db89e95f8b7a9249653c, see the commit message for the reasoning. Hope that's ok with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11973) Update to Johnzon 1.2.21
Robert Munteanu created SLING-11973: --- Summary: Update to Johnzon 1.2.21 Key: SLING-11973 URL: https://issues.apache.org/jira/browse/SLING-11973 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Commons Johnzon 1.2.16 This fixes https://nvd.nist.gov/vuln/detail/CVE-2023-33008 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-commons-johnzon] coheigea opened a new pull request, #3: Updating to Johnzon 1.2.21
coheigea opened a new pull request, #3: URL: https://github.com/apache/sling-org-apache-sling-commons-johnzon/pull/3 To fix https://nvd.nist.gov/vuln/detail/CVE-2023-33008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] cziegeler commented on a diff in pull request #38: SLING-11970 : Avoid restarting of components on configuration change
cziegeler commented on code in PR #38: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#discussion_r1268072945 ## src/main/java/org/apache/sling/engine/impl/SlingRequestProcessorImpl.java: ## @@ -355,12 +361,22 @@ public void dispatchRequest(final ServletRequest request, final RequestPathInfo resolvedURL, final DispatchingInfo dispatchingInfo) throws IOException, ServletException { - // we need a SlingHttpServletRequest/SlingHttpServletResponse tupel // to continue final SlingHttpServletRequest cRequest = RequestData.toSlingHttpServletRequest(request); final SlingHttpServletResponse cResponse = RequestData.toSlingHttpServletResponse(response); +// check that we have all required services +final ServletResolver sr = this.servletResolver; +if (sr == null) { +final int status = HttpServletResponse.SC_SERVICE_UNAVAILABLE; +String errorMessage = "Required service missing (ServletResolver)"; +log.debug("{}), cannot dispatch requests, sending status {}", errorMessage, status); Review Comment: thanks, will be removed with the next update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
More Sling GraphQL Core Jenkins Wows
Hi After limiting the Jenkins build to JDK 11 to release a fix required for the last release the build is still failing with a pretty weird issue: https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/4/pipeline/ It cannot download the JAR file: Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not transfer artifact commons-lang:commons-lang:pom:2.3 from/to central (https://repo.maven.apache.org/maven2): Connection reset at org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed (ArtifactTransportListener.java:44) at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run (BasicRepositoryConnector.java:417) Right before that the build could download the commons-lang POM file w/o any issues so I am not sure what is going on. - Andy
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #36: SLING-11920 - Expose Object Type Names as replacement for Inlined Fragments
sonarcloud[bot] commented on PR #36: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/36#issuecomment-1642019265 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=36) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=36=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=36=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=36=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=36=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=36=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=36=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=36=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=36=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=36=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=36=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=36=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=36=false=CODE_SMELL) [![88.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '88.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=36=new_coverage=list) [88.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=36=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=36=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=36=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] rombert commented on a diff in pull request #38: SLING-11970 : Avoid restarting of components on configuration change
rombert commented on code in PR #38: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#discussion_r1268002616 ## src/main/java/org/apache/sling/engine/impl/SlingRequestProcessorImpl.java: ## @@ -355,12 +361,22 @@ public void dispatchRequest(final ServletRequest request, final RequestPathInfo resolvedURL, final DispatchingInfo dispatchingInfo) throws IOException, ServletException { - // we need a SlingHttpServletRequest/SlingHttpServletResponse tupel // to continue final SlingHttpServletRequest cRequest = RequestData.toSlingHttpServletRequest(request); final SlingHttpServletResponse cResponse = RequestData.toSlingHttpServletResponse(response); +// check that we have all required services +final ServletResolver sr = this.servletResolver; +if (sr == null) { +final int status = HttpServletResponse.SC_SERVICE_UNAVAILABLE; +String errorMessage = "Required service missing (ServletResolver)"; +log.debug("{}), cannot dispatch requests, sending status {}", errorMessage, status); Review Comment: @cziegeler - there seems to be a stray `)` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: CI Build issue for GraphQL Core
Hi Robert Yeah, looks like it but the fix mentioned there is not working with GraphQL. I am running into the same problem with the Pax Exam tests but I also running into OSGi based unit test failures. GraphQL Core is not using sling-mock-oak but rather the OAK version that comes with sling-mock.junit4. That said I did upgrade the used Oak version in that module to 1.52.0 and it still did not work. - Andy > On Jul 19, 2023, at 10:44 AM, Robert Munteanu wrote: > > On Wed, 2023-07-19 at 10:40 +0200, Andreas Schaefer wrote: >> After some back and forth I saw that the Pax Exam container fails due >> to issues with java.security.acl.Group class not found issue: >> >> org.apache.sling.jcr.base[org.apache.sling.jcr.oak.server.internal.O >> akSlingRepositoryManager] : Exception in a >> SlingRepositoryInitializer, SlingRepository service registration >> aborted >> java.lang.NoClassDefFoundError: java/security/acl/Group >> at java.base/java.lang.ClassLoader.defineClass1(Native >> Method) >> at >> java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012) > > This seems to be > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690#CommonIssueswhenbuildingwithnewerJDKs(11or17)-OldversionofOak(%3C1.26)pulledinviaSling-Mock-Oak > > Robert
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #925 is BROKEN
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/925/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: [...truncated 13645 lines...] [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar (480 kB at 4.7 MB/s) [INFO] Enabled default license matchers. [INFO] Will parse SCM ignores for exclusions... [INFO] Parsing exclusions from /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_17_latest/.gitignore [INFO] Finished adding exclusions from SCM ignore files. [INFO] 79 implicit excludes. [INFO] 15 explicit excludes. [INFO] 21 resources included [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 20 licenses. [INFO] [INFO] --- docker:0.43.0:stop (stop-mongo) @ org.apache.sling.starter --- [INFO] Tests run: 62, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 60.055 s - in org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.HtmlDefaultServletTest [INFO] DOCKER> [mongo:4.4.6] "mongo": Stop and removed container afa2f4383d88 after 0 ms [INFO] [INFO] --- failsafe:3.0.0-M5:verify (default) @ org.apache.sling.starter --- [INFO] Failsafe report directory: /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_17_latest/target/failsafe-reports [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 08:15 min [INFO] Finished at: 2023-07-19T11:34:28Z [INFO] [INFO] [jenkins-event-spy] Generated /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_17_latest@tmp/withMaven473e8bf6/maven-spy-20230719-112612-6935399775342138500460.log [Pipeline] } [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.739 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.HtmlDefaultServletTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.PathsServletWithNodeTest [withMaven] Jenkins FindBugs Plugin not found, don't display org.codehaus.mojo:findbugs-maven-plugin:findbugs results in pipeline screen. [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.36 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.PathsServletWithNodeTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.RequestUriOptingServletTest [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.886 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.RequestUriOptingServletTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.PathsServletTest [withMaven] jgivenPublisher - Jenkins JGiven Plugin not found, do not archive jgiven reports. [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.491 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.PathsServletTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.RequestDispatcherServletTest [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.036 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.RequestDispatcherServletTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.repository.RepositoryNameTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.043 s - in org.apache.sling.launchpad.webapp.integrationtest.repository.RepositoryNameTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.SelectorServletTest [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.737 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.SelectorServletTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletVersionableTest [INFO] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.039 s - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletVersionableTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.scripting.SlingJSPTaglibTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.492 s - in org.apache.sling.launchpad.webapp.integrationtest.scripting.SlingJSPTaglibTest [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.xml.XPathTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.07 s - in org.apache.sling.launchpad.webapp.integrationtest.xml.XPathTest [
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #38: SLING-11970 : Avoid restarting of components on configuration change
sonarcloud[bot] commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#issuecomment-1641909698 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine=38) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [![B](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B-16px.png 'B')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [7 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [![B](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B-16px.png 'B')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [![2.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '2.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_coverage=list) [2.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_duplicated_lines_density=list) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'sonarlint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Apache Sling Parent & Bundle Parent 52
On Tue, 2023-07-18 at 14:27 +0200, Konrad Windszus wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: CI Build issue for GraphQL Core
On Wed, 2023-07-19 at 10:40 +0200, Andreas Schaefer wrote: > After some back and forth I saw that the Pax Exam container fails due > to issues with java.security.acl.Group class not found issue: > > org.apache.sling.jcr.base[org.apache.sling.jcr.oak.server.internal.O > akSlingRepositoryManager] : Exception in a > SlingRepositoryInitializer, SlingRepository service registration > aborted > java.lang.NoClassDefFoundError: java/security/acl/Group > at java.base/java.lang.ClassLoader.defineClass1(Native > Method) > at > java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012) This seems to be https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690#CommonIssueswhenbuildingwithnewerJDKs(11or17)-OldversionofOak(%3C1.26)pulledinviaSling-Mock-Oak Robert
Re: CI Build issue for GraphQL Core
After some back and forth I saw that the Pax Exam container fails due to issues with java.security.acl.Group class not found issue: org.apache.sling.jcr.base[org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager] : Exception in a SlingRepositoryInitializer, SlingRepository service registration aborted java.lang.NoClassDefFoundError: java/security/acl/Group at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012) There are other issues but I think that is the main one. GraphQL Core is using org.apache.sling.testing.sling-mock.junit4 and so I tried to use a newer version of oak-jcr (1.52.0) but that did not solve the issue. Any idea on how to fix this? - Andy > On Jul 18, 2023, at 4:00 PM, Andreas Schaefer > wrote: > > I tried to upgrade a few dependencies but eventually I am running into the > issue on Java 17 that the pax-exam is not able to find the Sling service (in > time). > > Upgrading the pax-exam to 4.3.15 lead to an issue where it is not able to > find org.sl4j.LoggerFactory: > > java.rmi.ServerError: Error occurred in server thread; nested exception is: > java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory > at > org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:168) > … > Caused by: java.rmi.ServerError: Error occurred in server thread; nested > exception is: > java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory > … > Caused by: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory > at > org.ops4j.pax.swissbox.tracker.ServiceLookup.(ServiceLookup.java:41) > ... > Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory > … > > Any idea on how to fix that? > > - Andy > > >> On Jul 18, 2023, at 10:46 AM, Andreas Schaefer >> wrote: >> >> Hi Robert >> >> My problem is not there yet but I updated the wiki page with the issue and >> my discovery so far. >> >> When I upgrade to Mockito-Inline 5.2.0 the compilation issue goes away but >> the pax-exam IT tests are time out when looking up Sling services. >> >> In the past when I tried to upgrade Pax-Exam I ran into other issues so I >> don’t think upgrading would work but I don’t know. >> >> - Andy >> >>> On Jul 18, 2023, at 9:59 AM, Robert Munteanu wrote: >>> >>> Hi Andy, >>> >>> On Tue, 2023-07-18 at 09:47 +0200, Andreas Schaefer wrote: Hi For my latest PR for Sling GraphQL Core I am running into CI build issues on Java 17: https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/3/pipeline Any idea on how to resolve this? >>> >>> [1] gathers the problem patterns we saw when migrating builds to Java >>> 11/17, maybe your problem is already listed? >>> >>> Thanks, >>> Robert >>> >>> [1]: >>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690 >> >
[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #192: chore(deps): update dependency org.apache.sling:org.apache.sling.models.jacksonexporter to v1.1.4
rombert merged PR #192: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-post] joerghoh commented on a diff in pull request #22: SLING-11971 Adding additional logging for sling post processors
joerghoh commented on code in PR #22: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22#discussion_r1267653540 ## src/main/java/org/apache/sling/servlets/post/impl/operations/AbstractPostOperation.java: ## @@ -106,7 +108,10 @@ public void run(final SlingHttpServletRequest request, try { if (processors != null) { for (SlingPostProcessor processor : processors) { +Instant start = Instant.now(); +log.debug("About to perform processor {}", processor.getClass().getName()); processor.process(request, changes); +log.debug("Performed processor {} in {}", processor.getClass().getName(), Duration.between(start, Instant.now()).toMillis()); Review Comment: can you please also log into the RequestProgressTracker? ## src/main/java/org/apache/sling/servlets/post/AbstractPostOperation.java: ## @@ -108,11 +112,15 @@ public void run(final SlingHttpServletRequest request, // invoke processors if (processors != null) { for (SlingPostProcessor processor : processors) { +Instant start = Instant.now(); +log.debug("About to perform processor {}", processor.getClass().getName()); processor.process(request, changes); +log.debug("Performed processor {} in {}", processor.getClass().getName(), Duration.between(start, Instant.now()).toMillis()); Review Comment: Can you please also log this message to the RequestProgressTracker? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-post] joerghoh commented on pull request #22: SLING-11971 Adding additional logging for sling post processors
joerghoh commented on PR #22: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22#issuecomment-1641554032 @pat-lego Can you rebase to the latest master update? I fixed the Java17 build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11972) Make Sling Post Servlets build with Java 17
[ https://issues.apache.org/jira/browse/SLING-11972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-11972. --- Resolution: Fixed > Make Sling Post Servlets build with Java 17 > --- > > Key: SLING-11972 > URL: https://issues.apache.org/jira/browse/SLING-11972 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets POST 2.5.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets POST 2.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-servlets-post] joerghoh merged pull request #23: SLING-11972 add support for java 17 build
joerghoh merged PR #23: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org