[GitHub] [sling-site] renovate-bot opened a new pull request, #115: Configure Renovate
renovate-bot opened a new pull request, #115: URL: https://github.com/apache/sling-site/pull/115 [](https://renovatebot.com) Welcome to [Renovate](https://togithub.com/renovatebot/renovate)! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin. To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged. --- ### Detected Package Files * `pom.xml` (maven) ### Configuration Summary Based on the default config's presets, Renovate will: - Start dependency updates only once this onboarding PR is merged - Show all Merge Confidence badges for pull requests. - Enable Renovate Dependency Dashboard creation. - Use semantic commit type `fix` for dependencies and `chore` for all others if semantic commits are in use. - Ignore `node_modules`, `bower_components`, `vendor` and various test/tests directories. - Group known monorepo packages together. - Use curated list of recommended non-monorepo package groupings. - Apply crowd-sourced package replacement rules. - Apply crowd-sourced workarounds for known problems with packages. Would you like to change the way Renovate is upgrading your dependencies? Simply edit the `renovate.json` in this branch with your custom config and the list of Pull Requests in the "What to Expect" section below will be updated the next time Renovate runs. --- ### What to Expect With your current configuration, Renovate will create 3 Pull Requests: Update dependency org.asciidoctor:asciidoctorj to v2.5.10 - Schedule: ["at any time"] - Branch name: `renovate/org.asciidoctor-asciidoctorj-2.x` - Merge into: `master` - Upgrade [org.asciidoctor:asciidoctorj](https://togithub.com/asciidoctor/asciidoctorj) to `2.5.10` Update dependency org.jbake:jbake-maven-plugin to v2.7.0-rc.7 - Schedule: ["at any time"] - Branch name: `renovate/org.jbake-jbake-maven-plugin-2.x` - Merge into: `master` - Upgrade [org.jbake:jbake-maven-plugin](https://togithub.com/jbake-org/jbake-maven-plugin) to `2.7.0-rc.7` Update dependency org.apache.maven.plugins:maven-enforcer-plugin to v3.4.1 - Schedule: ["at any time"] - Branch name: `renovate/org.apache.maven.plugins-maven-enforcer-plugin-3.x` - Merge into: `master` - Upgrade org.apache.maven.plugins:maven-enforcer-plugin to `3.4.1` Branch creation will be limited to maximum 2 per hour, so it doesn't swamp any CI resources or overwhelm the project. See docs for `prhourlylimit` for details. --- ❓ Got questions? Check out Renovate's [Docs](https://docs.renovatebot.com/), particularly the Getting Started section. If you need any further assistance then you can also [request help here](https://togithub.com/renovatebot/renovate/discussions). --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-site). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12051) Create a list of provider type interfaces of the API
Carsten Ziegeler created SLING-12051: Summary: Create a list of provider type interfaces of the API Key: SLING-12051 URL: https://issues.apache.org/jira/browse/SLING-12051 Project: Sling Issue Type: Improvement Components: Feature Model, Maven Plugins and Archetypes Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: OSGi Feature Maven Plugin 1.7.4 To simplify checking if consumers of an api have implemented a provider type, the api generation could (optionally) add the list of provider type interfaces to the feature model -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on pull request #59: SLING-9883 Export merged provided capabilities in 'Provide-Capability'
cziegeler commented on PR #59: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/59#issuecomment-1738461612 @kwin the PR looks ok to me, we have the open question about a bundle not export api into a region which we can ignore for now and get to it if it becomes important -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a diff in pull request #59: SLING-9883 Export merged provided capabilities in 'Provide-Capability'
cziegeler commented on code in PR #59:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/59#discussion_r1339542728
##
src/main/java/org/apache/sling/feature/maven/mojos/ApisJarMojo.java:
##
@@ -871,6 +880,9 @@ private void onArtifact(final ApisJarContext ctx, Artifact
artifact) throws Mojo
ApisUtil.buildJavadocClasspath(getLog(), repositorySystem,
mavenSession, artifact.getId())
.forEach(ctx::addJavadocClasspath);
}
+
+} else {
Review Comment:
If this is important, we could add allow to add metadata like
"api-export-capabilities":"true" to a bundle. Otherwise I would just remove the
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (SLING-12050) Jenkins Tooling - Allow Specifying Build Timeout
Dan Klco created SLING-12050: Summary: Jenkins Tooling - Allow Specifying Build Timeout Key: SLING-12050 URL: https://issues.apache.org/jira/browse/SLING-12050 Project: Sling Issue Type: Improvement Components: Tooling Reporter: Dan Klco Assignee: Dan Klco The Jenkins Tooling sets the build timeout to 30 minutes: https://github.com/apache/sling-tooling-jenkins/blob/77cc9bce6d10c2f40323721f37b098990f666b90/vars/slingOsgiBundleBuild.groovy#L59 Generally, this works, however, the Windows build executors seem to be significantly slower than the Ubuntu executors which for the CMS app is causing build failures due to the Windows builds timing out. Increasing the timeout at the project level should resolve the issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12049) Update the Sling downloads list using renovate
Robert Munteanu created SLING-12049: --- Summary: Update the Sling downloads list using renovate Key: SLING-12049 URL: https://issues.apache.org/jira/browse/SLING-12049 Project: Sling Issue Type: Improvement Components: Documentation Reporter: Robert Munteanu Assignee: Robert Munteanu We can simplify the release management process by having Renovate update the downloads list. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Automatically updating the downloads list for out website
On Fri, 2023-09-22 at 11:35 +0200, Robert Munteanu wrote: > Hi, > > I did a quick experiment on automatically updating the download list > for the sling web site with renovate. > > You can see how it would look like at [1]. We would still need to > manually merge PRs but I think it's better than manually updating the > downloads list after a release. > > It already shows 12 missed updates and a typo. > > We need to ask infra to install the 'forking-renovate' app, just like > they did for the Sling Starter, so I would like to make sure there > are > no objections before I do that. I heard no objections, created https://issues.apache.org/jira/browse/SLING-12049 to track the work. Thanks, Robert > > I plan to ask infra on Tuesday, please voice concerns before that. > > Thanks, > Robert > > > [1]: https://github.com/rombert/sling-site/pull/1
[jira] [Closed] (SLING-12039) Provide a bundle that exports metrics in the Prometheus format
[ https://issues.apache.org/jira/browse/SLING-12039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12039. --- > Provide a bundle that exports metrics in the Prometheus format > -- > > Key: SLING-12039 > URL: https://issues.apache.org/jira/browse/SLING-12039 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Commons Prometheus Metrics Exporter 0.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Commons Prometheus Metrics Exporter 0.1.0
Hi, The vote has passed with the following result: +1 (binding): Dan Klco, Christian Schneider, Robert Munteanu +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
[GitHub] [sling-org-apache-sling-jcr-jackrabbit-usermanager] sonarcloud[bot] commented on pull request #19: SLING-12023 Fix test compatibility with java 17
sonarcloud[bot] commented on PR #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-usermanager/pull/19#issuecomment-1737982874 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-jackrabbit-usermanager=19=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-jackrabbit-usermanager] enapps-enorman opened a new pull request, #19: SLING-12023 Fix test compatibility with java 17
enapps-enorman opened a new pull request, #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-usermanager/pull/19 Some of the tests are failing when building with java 17. Need a bump of some dependencies to later versions and other refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] forking-renovate[bot] commented on pull request #212: chore(deps): update apache pdfbox to v3 (major)
forking-renovate[bot] commented on PR #212: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/212#issuecomment-1737619728 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ **Warning**: custom changes will be lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12048) Migrate to PDFBox 3.x
[
https://issues.apache.org/jira/browse/SLING-12048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769656#comment-17769656
]
Robert Munteanu commented on SLING-12048:
-
We need PDFBOX-5687 fixed first, but even after applying the fix locally the
FullTextIndexing ITs are failing.
{noformat}
ERROR] Failures:
[ERROR] FullTextIndexingTest.testUploadedPdfIsIndexed:97 RetryLoop failed,
condition is false after 15 seconds: A document containing 'Excepteur' is found
under /tmp/test-FullTextIndexingTest
[ERROR] FullTextIndexingTest.testUploadedPdfIsIndexed:97 RetryLoop failed,
condition is false after 15 seconds: A document containing 'some text that we
will search for' is found under /var/test-FullTextIndexingTest
[ERROR] FullTextIndexingTest.testUploadedPdfIsIndexed:97 RetryLoop failed,
condition is false after 15 seconds: A document containing 'un autre PDF pour
le test fulltext' is found under /libs/test-FullTextIndexingTest
{noformat}
WIP renovate PR at
https://github.com/apache/sling-org-apache-sling-starter/pull/212
> Migrate to PDFBox 3.x
> -
>
> Key: SLING-12048
> URL: https://issues.apache.org/jira/browse/SLING-12048
> Project: Sling
> Issue Type: Improvement
> Components: Starter
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Starter 13
>
>
> PDFBox 3.0 is out and we should upgrade to benefit from the latest
> enhancements.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12048) Migrate to PDFBox 3.x
Robert Munteanu created SLING-12048: --- Summary: Migrate to PDFBox 3.x Key: SLING-12048 URL: https://issues.apache.org/jira/browse/SLING-12048 Project: Sling Issue Type: Improvement Components: Starter Reporter: Robert Munteanu Fix For: Starter 13 PDFBox 3.0 is out and we should upgrade to benefit from the latest enhancements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #212: chore(deps): update apache pdfbox to v3 (major)
rombert commented on PR #212: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/212#issuecomment-1737538876 The OSGi imports will be fixed with https://issues.apache.org/jira/browse/PDFBOX-5687 . But tests still fail after the bundles resolve ``` [ERROR] Failures: [ERROR] FullTextIndexingTest.testUploadedPdfIsIndexed:97 RetryLoop failed, condition is false after 15 seconds: A document containing 'Excepteur' is found under /tmp/test-FullTextIndexingTest [ERROR] FullTextIndexingTest.testUploadedPdfIsIndexed:97 RetryLoop failed, condition is false after 15 seconds: A document containing 'some text that we will search for' is found under /var/test-FullTextIndexingTest [ERROR] FullTextIndexingTest.testUploadedPdfIsIndexed:97 RetryLoop failed, condition is false after 15 seconds: A document containing 'un autre PDF pour le test fulltext' is found under /libs/test-FullTextIndexingTest ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #29: SLING-11458 - fixed a regresssion for the original Ticket SLING-9626
sonarcloud[bot] commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/29#issuecomment-1737526964 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=29) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=29=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=29=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=29=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=29=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=29=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=29=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=29=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=29=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-oak-server] sonarcloud[bot] commented on pull request #7: Bump org.apache.sling.jcr.base from 3.0.4 to 3.1.12
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/7#issuecomment-1737474342 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-oak-server=7) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-oak-server=7=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server=7=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server=7=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-oak-server=7=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-11590) AbstractBundleProjectConfigurator no longer compatible with m2e 2.x
[
https://issues.apache.org/jira/browse/SLING-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769618#comment-17769618
]
mainagioia edited comment on SLING-11590 at 9/27/23 1:47 PM:
-
No, the nightly build itself works; this temporary fix is for cases when this
fix is needed in Eclipse plugins which have 1.2.2 version as a dependency. For
example, this problem arises in latest AEM Tools for Eclipse, which has 1.2.2
as a dependency, in which "Maven - Update project" no longer works.
If I try to install nightly build of Sling, Eclipse installer requires
uninstalling AEM Tools because of the now-invalid dependency; by taking the
JAR I modified and replacing it in Eclipse plugins directory, AEM Tools and
this "temporary" version of Sling Tools can coexist... obviously until 2.0.0 is
released and AEM Tools (and others) update their dependency requirement.
was (Author: JIRAUSER302374):
No, the nightly build itself works; this temporary fix is for cases when this
fix is needed in Eclipse plugins which have 1.2.2 version as a dependency. For
example, this problem arises in latest AEM Tools for Eclipse, which has 1.2.2
as a dependency, in which "Maven - Update project" no longer works.
If I try to install nightly build of Sling, Eclipse installer requires
uninstalling AEM Tools because of the changed dependency; by taking the JAR I
modified and replacing it in Eclipse plugins directory, AEM Tools and this
"temporary" version of Sling Tools can coexist... obviously until 2.0.0 is
released and AEM Tools (and others) update their dependency requirement.
> AbstractBundleProjectConfigurator no longer compatible with m2e 2.x
> ---
>
> Key: SLING-11590
> URL: https://issues.apache.org/jira/browse/SLING-11590
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.2.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Eclipse IDE 2.0.0
>
> Attachments: AbstractBundleProjectConfigurator.java,
> ContentPackageProjectConfigurator.java, MavenProjectUtils.java,
> org.apache.sling.ide.eclipse-m2e-ui_1.2.2.jar
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The following stacktrace can be observed when trying to update a Maven
> configuration of a bundle project with m2e 2.x
> {code}
> java.lang.NoSuchMethodError: 'org.eclipse.core.resources.IProject
> org.eclipse.m2e.core.project.configurator.ProjectConfigurationRequest.getProject()'
> at
> org.apache.sling.ide.eclipse.m2e.internal.AbstractBundleProjectConfigurator.configure(AbstractBundleProjectConfigurator.java:48)
> at
> org.eclipse.m2e.core.project.configurator.AbstractLifecycleMapping.configure(AbstractLifecycleMapping.java:125)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$6(ProjectConfigurationManager.java:475)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:350)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:262)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:469)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$4(ProjectConfigurationManager.java:413)
> at java.base/java.util.Collection.removeIf(Collection.java:576)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:407)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$3(ProjectConfigurationManager.java:339)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:350)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:262)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:205)
> at
> org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1093)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:338)
> at
> org.eclipse.m2e.core.ui.internal.UpdateMavenProjectJob.runInWorkspace(UpdateMavenProjectJob.java:80)
> at
> org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:43)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
> {code}
> due to this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11590) AbstractBundleProjectConfigurator no longer compatible with m2e 2.x
[
https://issues.apache.org/jira/browse/SLING-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769618#comment-17769618
]
mainagioia commented on SLING-11590:
No, the nightly build itself works; this temporary fix is for cases when this
fix is needed in Eclipse plugins which have 1.2.2 version as a dependency. For
example, this problem arises in latest AEM Tools for Eclipse, which has 1.2.2
as a dependency, in which "Maven - Update project" no longer works.
If I try to install nightly build of Sling, Eclipse installer requires
uninstalling AEM Tools because of the changed dependency; by taking the JAR I
modified and replacing it in Eclipse plugins directory, AEM Tools and this
"temporary" version of Sling Tools can coexist... obviously until 2.0.0 is
released and AEM Tools (and others) update their dependency requirement.
> AbstractBundleProjectConfigurator no longer compatible with m2e 2.x
> ---
>
> Key: SLING-11590
> URL: https://issues.apache.org/jira/browse/SLING-11590
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.2.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Eclipse IDE 2.0.0
>
> Attachments: AbstractBundleProjectConfigurator.java,
> ContentPackageProjectConfigurator.java, MavenProjectUtils.java,
> org.apache.sling.ide.eclipse-m2e-ui_1.2.2.jar
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The following stacktrace can be observed when trying to update a Maven
> configuration of a bundle project with m2e 2.x
> {code}
> java.lang.NoSuchMethodError: 'org.eclipse.core.resources.IProject
> org.eclipse.m2e.core.project.configurator.ProjectConfigurationRequest.getProject()'
> at
> org.apache.sling.ide.eclipse.m2e.internal.AbstractBundleProjectConfigurator.configure(AbstractBundleProjectConfigurator.java:48)
> at
> org.eclipse.m2e.core.project.configurator.AbstractLifecycleMapping.configure(AbstractLifecycleMapping.java:125)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$6(ProjectConfigurationManager.java:475)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:350)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:262)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:469)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$4(ProjectConfigurationManager.java:413)
> at java.base/java.util.Collection.removeIf(Collection.java:576)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:407)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$3(ProjectConfigurationManager.java:339)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:350)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:262)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:205)
> at
> org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1093)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:338)
> at
> org.eclipse.m2e.core.ui.internal.UpdateMavenProjectJob.runInWorkspace(UpdateMavenProjectJob.java:80)
> at
> org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:43)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
> {code}
> due to this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741
cziegeler commented on code in PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1338633803
##
src/main/java/org/apache/sling/jcr/base/internal/LegacyFragment.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.jcr.base.internal;
+
+import org.osgi.service.component.annotations.Activate;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.component.annotations.ConfigurationPolicy;
+import org.osgi.service.component.annotations.Deactivate;
+import org.osgi.service.component.annotations.Reference;
+import org.osgi.util.converter.Converters;
+
+import java.util.Map;
+
+/**
+ * Legacy fragment configuration. Use {@link AllowListFragment} instead.
+ */
+@Component(
+configurationPid = LegacyFragment.LEGACY_FACTORY_PID,
+configurationPolicy = ConfigurationPolicy.REQUIRE,
+service = LegacyFragment.class
+)
+public class LegacyFragment {
+
+public static final String LEGACY_FACTORY_PID =
"org.apache.sling.jcr.base.internal.LoginAdminWhitelist.fragment";
+
+private static final String LEGACY_NAME = "whitelist.name";
+private static final String LEGACY_BUNDLES = "whitelist.bundles";
+
+private final AllowListFragment fragment;
+
+private final LoginAdminAllowList allowList;
+
+@Activate
+public LegacyFragment(final @Reference LoginAdminAllowList allowList,
final Map config) {
+LoginAdminAllowList.LOG.warn("Using deprecated factory configuration
'{}'. " +
+"Update your configuration to use configuration '{}' instead.",
+LEGACY_FACTORY_PID, AllowListFragment.FACTORY_PID);
+this.allowList = allowList;
+final String name =
Converters.standardConverter().convert(config.get(LEGACY_NAME)).to(String.class);
+final String[] bundles =
Converters.standardConverter().convert(config.get(LEGACY_BUNDLES)).to(String[].class);
+this.fragment = new AllowListFragment(name, bundles);
+this.allowList.bindAllowListFragment(fragment);
Review Comment:
I think this code is fine, but if you want to change it, please update this
branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741
cziegeler commented on code in PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1338631696
##
src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java:
##
@@ -133,24 +124,47 @@ public boolean allowLoginAdministrative(Bundle b) {
}
// encapsulate configuration state for atomic configuration updates
-private static class ConfigurationState {
+static class ConfigurationState {
+
+public final boolean bypassAllowList;
-private final boolean bypassAllowList;
+public final Pattern allowListRegexp;
-private final Pattern allowListRegexp;
+ConfigurationState(final LoginAdminAllowListConfiguration config,
final Map properties) {
+// first check for legacy properties
+boolean bypass = config.allowlist_bypass();
+final Object legacyBypassObject =
properties.get(LEGACY_BYPASS_PROPERTY);
+if (legacyBypassObject != null) {
+LOG.warn("Using deprecated configuration property '{}' from
configuration '{}'. " +
+"Update your configuration to use configuration '{}' and
property '{}' instead.",
+LEGACY_BYPASS_PROPERTY, LEGACY_PID, PID,
"allowlist.bypass");
+bypass =
Converters.standardConverter().convert(legacyBypassObject).defaultValue(false).to(Boolean.class);
+}
+String legacyRegexp = null;
+final Object legacyBundlesObject =
properties.get(LEGACY_BUNDLES_PROPERTY);
+if (legacyBypassObject != null) {
+LOG.warn("Using deprecated configuration property '{}' from
configuration '{}'. " +
+"Update your configuration to use configuration '{}' and
property '{}' instead.",
+LEGACY_BUNDLES_PROPERTY, LEGACY_PID, PID,
"allowlist.bundles.regexp");
+legacyRegexp =
Converters.standardConverter().convert(legacyBundlesObject).to(String.class);
+}
-private ConfigurationState(final LoginAdminAllowListConfiguration
config) {
final String regexp = config.allowlist_bundles_regexp();
-if(regexp.trim().length() > 0) {
-allowListRegexp = Pattern.compile(regexp);
-LOG.warn("A 'allowlist.bundles.regexp' is configured, this is
NOT RECOMMENDED for production: {}",
-allowListRegexp);
+if (regexp.trim().length() > 0) {
+if (legacyRegexp != null) {
+LOG.warn("Both deprecated configuration property '{}' and
configuration property '{}' are set. " +
+"The deprecated property '{}' is ignored.",
+LEGACY_BUNDLES_PROPERTY, "allowlist.bundles.regexp",
LEGACY_BUNDLES_PROPERTY);
+}
+this.allowListRegexp = Pattern.compile(regexp);
} else {
-allowListRegexp = null;
+this.allowListRegexp = legacyRegexp != null ?
Pattern.compile(legacyRegexp) : null;
}
-
-bypassAllowList = config.allowlist_bypass();
-if(bypassAllowList) {
+if (this.allowListRegexp != null) {
+LOG.warn("A 'allowlist.bundles.regexp' is configured, this is
NOT RECOMMENDED for production: {}", allowListRegexp);
+}
+this.bypassAllowList = bypass;
+if (this.bypassAllowList) {
LOG.info("bypassAllowlist=true, allowlisted BSNs=");
LOG.warn("All bundles are allowed to use loginAdministrative
due to the 'allowlist.bypass' " +
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741
cziegeler commented on code in PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1338631416
##
src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java:
##
@@ -133,24 +124,47 @@ public boolean allowLoginAdministrative(Bundle b) {
}
// encapsulate configuration state for atomic configuration updates
-private static class ConfigurationState {
+static class ConfigurationState {
+
+public final boolean bypassAllowList;
-private final boolean bypassAllowList;
+public final Pattern allowListRegexp;
-private final Pattern allowListRegexp;
+ConfigurationState(final LoginAdminAllowListConfiguration config,
final Map properties) {
+// first check for legacy properties
+boolean bypass = config.allowlist_bypass();
+final Object legacyBypassObject =
properties.get(LEGACY_BYPASS_PROPERTY);
+if (legacyBypassObject != null) {
+LOG.warn("Using deprecated configuration property '{}' from
configuration '{}'. " +
+"Update your configuration to use configuration '{}' and
property '{}' instead.",
+LEGACY_BYPASS_PROPERTY, LEGACY_PID, PID,
"allowlist.bypass");
+bypass =
Converters.standardConverter().convert(legacyBypassObject).defaultValue(false).to(Boolean.class);
+}
+String legacyRegexp = null;
+final Object legacyBundlesObject =
properties.get(LEGACY_BUNDLES_PROPERTY);
+if (legacyBypassObject != null) {
+LOG.warn("Using deprecated configuration property '{}' from
configuration '{}'. " +
+"Update your configuration to use configuration '{}' and
property '{}' instead.",
+LEGACY_BUNDLES_PROPERTY, LEGACY_PID, PID,
"allowlist.bundles.regexp");
+legacyRegexp =
Converters.standardConverter().convert(legacyBundlesObject).to(String.class);
+}
-private ConfigurationState(final LoginAdminAllowListConfiguration
config) {
final String regexp = config.allowlist_bundles_regexp();
-if(regexp.trim().length() > 0) {
-allowListRegexp = Pattern.compile(regexp);
-LOG.warn("A 'allowlist.bundles.regexp' is configured, this is
NOT RECOMMENDED for production: {}",
-allowListRegexp);
+if (regexp.trim().length() > 0) {
+if (legacyRegexp != null) {
+LOG.warn("Both deprecated configuration property '{}' and
configuration property '{}' are set. " +
+"The deprecated property '{}' is ignored.",
+LEGACY_BUNDLES_PROPERTY, "allowlist.bundles.regexp",
LEGACY_BUNDLES_PROPERTY);
+}
+this.allowListRegexp = Pattern.compile(regexp);
} else {
-allowListRegexp = null;
+this.allowListRegexp = legacyRegexp != null ?
Pattern.compile(legacyRegexp) : null;
}
-
-bypassAllowList = config.allowlist_bypass();
-if(bypassAllowList) {
+if (this.allowListRegexp != null) {
+LOG.warn("A 'allowlist.bundles.regexp' is configured, this is
NOT RECOMMENDED for production: {}", allowListRegexp);
Review Comment:
if we do this we should do it in a different issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-11590) AbstractBundleProjectConfigurator no longer compatible with m2e 2.x
[
https://issues.apache.org/jira/browse/SLING-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769614#comment-17769614
]
Konrad Windszus commented on SLING-11590:
-
[~mainagioia] Any issues with the nightly build referenced above which makes
you want to build your own custom version?
> AbstractBundleProjectConfigurator no longer compatible with m2e 2.x
> ---
>
> Key: SLING-11590
> URL: https://issues.apache.org/jira/browse/SLING-11590
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.2.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Eclipse IDE 2.0.0
>
> Attachments: AbstractBundleProjectConfigurator.java,
> ContentPackageProjectConfigurator.java, MavenProjectUtils.java,
> org.apache.sling.ide.eclipse-m2e-ui_1.2.2.jar
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The following stacktrace can be observed when trying to update a Maven
> configuration of a bundle project with m2e 2.x
> {code}
> java.lang.NoSuchMethodError: 'org.eclipse.core.resources.IProject
> org.eclipse.m2e.core.project.configurator.ProjectConfigurationRequest.getProject()'
> at
> org.apache.sling.ide.eclipse.m2e.internal.AbstractBundleProjectConfigurator.configure(AbstractBundleProjectConfigurator.java:48)
> at
> org.eclipse.m2e.core.project.configurator.AbstractLifecycleMapping.configure(AbstractLifecycleMapping.java:125)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$6(ProjectConfigurationManager.java:475)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:350)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:262)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:469)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$4(ProjectConfigurationManager.java:413)
> at java.base/java.util.Collection.removeIf(Collection.java:576)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:407)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$3(ProjectConfigurationManager.java:339)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:350)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:262)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:205)
> at
> org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1093)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:338)
> at
> org.eclipse.m2e.core.ui.internal.UpdateMavenProjectJob.runInWorkspace(UpdateMavenProjectJob.java:80)
> at
> org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:43)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
> {code}
> due to this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12047) Migrate to Tika 2.x
[ https://issues.apache.org/jira/browse/SLING-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769611#comment-17769611 ] Robert Munteanu commented on SLING-12047: - A WIP PR from Renovate is at https://github.com/apache/sling-org-apache-sling-starter/pull/148 . > Migrate to Tika 2.x > --- > > Key: SLING-12047 > URL: https://issues.apache.org/jira/browse/SLING-12047 > Project: Sling > Issue Type: Improvement > Components: Starter >Reporter: Robert Munteanu >Priority: Major > Fix For: Starter 13 > > > Apache Tika 2.0 has been out for some time (2 years?). We shouldp ugrade to > the latest 2.x version. See also > https://cwiki.apache.org/confluence/display/TIKA/Migrating+to+Tika+2.0.0 . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12047) Migrate to Tika 2.x
[ https://issues.apache.org/jira/browse/SLING-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769609#comment-17769609 ] Robert Munteanu commented on SLING-12047: - Tika requires slf4j 2.0 as of version 2.5, but we could upgrade to 2.4 if other dependencies are ready ( Jackrabbit, Oak ). > Migrate to Tika 2.x > --- > > Key: SLING-12047 > URL: https://issues.apache.org/jira/browse/SLING-12047 > Project: Sling > Issue Type: Improvement > Components: Starter >Reporter: Robert Munteanu >Priority: Major > Fix For: Starter 13 > > > Apache Tika 2.0 has been out for some time (2 years?). We shouldp ugrade to > the latest 2.x version. See also > https://cwiki.apache.org/confluence/display/TIKA/Migrating+to+Tika+2.0.0 . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-starter] forking-renovate[bot] commented on pull request #148: chore(deps): update apache tika to v2 (major)
forking-renovate[bot] commented on PR #148: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/148#issuecomment-1737402154 ### Renovate Ignore Notification Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for *any* future 2.x releases. But if you manually upgrade to 2.x then Renovate will re-enable `minor` and `patch` updates automatically. If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert closed pull request #148: chore(deps): update apache tika to v2 (major)
rombert closed pull request #148: chore(deps): update apache tika to v2 (major) URL: https://github.com/apache/sling-org-apache-sling-starter/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12047) Migrate to Tika 2.x
Robert Munteanu created SLING-12047: --- Summary: Migrate to Tika 2.x Key: SLING-12047 URL: https://issues.apache.org/jira/browse/SLING-12047 Project: Sling Issue Type: Improvement Components: Starter Reporter: Robert Munteanu Fix For: Starter 13 Apache Tika 2.0 has been out for some time (2 years?). We shouldp ugrade to the latest 2.x version. See also https://cwiki.apache.org/confluence/display/TIKA/Migrating+to+Tika+2.0.0 . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #148: chore(deps): update apache tika to v2 (major)
rombert commented on PR #148:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/148#issuecomment-1737384435
The update needs to be corrected
```diff
diff --git a/src/main/features/base.json b/src/main/features/base.json
index 158603c..408caa7 100644
--- a/src/main/features/base.json
+++ b/src/main/features/base.json
@@ -219,7 +219,7 @@
"start-order":"10"
},
{
-"id":"org.apache.tika:tika-parsers:2.9.0",
+"id":"org.apache.tika:tika-parsers-standard-package:2.9.0",
"start-order":"10"
},
{
~/s/a/s/org
```
Once that is done the resolution problems are visible
```
[ERROR] [bundle-packages]
org.apache.sling:org.apache.sling.jcr.webdav:2.3.8: Bundle is importing
packages [Package org.apache.tika.metadata;version=[1.0,2), Package
org.apache.tika.mime;version=[1.2,2), Package
org.apache.tika.detect;version=[1.0,2)] with start order 15 but no bundle is
exporting these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.tika:tika-core:2.9.0: Bundle is
importing package org.slf4j;version=[2.0,3) with start order 10 but no bundle
is exporting these for that start order in the required version range.
[ERROR] [bundle-packages] org.apache.jackrabbit:oak-lucene:1.54.0: Bundle is
importing packages [Package org.apache.tika.mime;version=[1.26,2), Package
org.apache.tika.metadata;version=[1.26,2), Package
org.apache.tika.sax;version=[1.26,2), Package
org.apache.tika.parser;version=[1.26,2), Package
org.apache.tika.config;version=[1.26,2), Package
org.apache.tika.exception;version=[1.26,2)] with start order 15 but no bundle
is exporting these for that start order in the required version range
```
So we need
- slf4j-api 2.0 in Sling
- tika 2.0 support in Jackrabbbit and Oak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769571#comment-17769571 ] Henry Kuijpers commented on SLING-10447: [~ngupta] Did you do any of your additional testing yet? > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Assignee: Robert Munteanu >Priority: Major > Fix For: Resource Resolver 1.8.0 > > Attachments: with-path-restrictions.json, > without-path-restrictions.json > > Time Spent: 7h 10m > Remaining Estimate: 0h > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11590) AbstractBundleProjectConfigurator no longer compatible with m2e 2.x
[
https://issues.apache.org/jira/browse/SLING-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mainagioia updated SLING-11590:
---
Attachment: AbstractBundleProjectConfigurator.java
ContentPackageProjectConfigurator.java
MavenProjectUtils.java
org.apache.sling.ide.eclipse-m2e-ui_1.2.2.jar
> AbstractBundleProjectConfigurator no longer compatible with m2e 2.x
> ---
>
> Key: SLING-11590
> URL: https://issues.apache.org/jira/browse/SLING-11590
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.2.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Eclipse IDE 2.0.0
>
> Attachments: AbstractBundleProjectConfigurator.java,
> ContentPackageProjectConfigurator.java, MavenProjectUtils.java,
> org.apache.sling.ide.eclipse-m2e-ui_1.2.2.jar
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The following stacktrace can be observed when trying to update a Maven
> configuration of a bundle project with m2e 2.x
> {code}
> java.lang.NoSuchMethodError: 'org.eclipse.core.resources.IProject
> org.eclipse.m2e.core.project.configurator.ProjectConfigurationRequest.getProject()'
> at
> org.apache.sling.ide.eclipse.m2e.internal.AbstractBundleProjectConfigurator.configure(AbstractBundleProjectConfigurator.java:48)
> at
> org.eclipse.m2e.core.project.configurator.AbstractLifecycleMapping.configure(AbstractLifecycleMapping.java:125)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$6(ProjectConfigurationManager.java:475)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:350)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:262)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:469)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$4(ProjectConfigurationManager.java:413)
> at java.base/java.util.Collection.removeIf(Collection.java:576)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:407)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$3(ProjectConfigurationManager.java:339)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:350)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:262)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:205)
> at
> org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1093)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:338)
> at
> org.eclipse.m2e.core.ui.internal.UpdateMavenProjectJob.runInWorkspace(UpdateMavenProjectJob.java:80)
> at
> org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:43)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
> {code}
> due to this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11590) AbstractBundleProjectConfigurator no longer compatible with m2e 2.x
[
https://issues.apache.org/jira/browse/SLING-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769569#comment-17769569
]
mainagioia commented on SLING-11590:
Temporary fix for 1.2.2 version, until 2.0.0 will be released:
* Sources taken from current master;
* Slightly modified some java files (attached), sources recompiled;
* Starting from the current 1.2.2 JAR, the attached JAR has these classes
replaced from compiled ones:
** SlingstartProjectConfigurator
** The attached Java files after
compiling[^AbstractBundleProjectConfigurator.java]
> AbstractBundleProjectConfigurator no longer compatible with m2e 2.x
> ---
>
> Key: SLING-11590
> URL: https://issues.apache.org/jira/browse/SLING-11590
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.2.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Eclipse IDE 2.0.0
>
> Attachments: AbstractBundleProjectConfigurator.java,
> ContentPackageProjectConfigurator.java, MavenProjectUtils.java,
> org.apache.sling.ide.eclipse-m2e-ui_1.2.2.jar
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The following stacktrace can be observed when trying to update a Maven
> configuration of a bundle project with m2e 2.x
> {code}
> java.lang.NoSuchMethodError: 'org.eclipse.core.resources.IProject
> org.eclipse.m2e.core.project.configurator.ProjectConfigurationRequest.getProject()'
> at
> org.apache.sling.ide.eclipse.m2e.internal.AbstractBundleProjectConfigurator.configure(AbstractBundleProjectConfigurator.java:48)
> at
> org.eclipse.m2e.core.project.configurator.AbstractLifecycleMapping.configure(AbstractLifecycleMapping.java:125)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$6(ProjectConfigurationManager.java:475)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:350)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:262)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:469)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$4(ProjectConfigurationManager.java:413)
> at java.base/java.util.Collection.removeIf(Collection.java:576)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:407)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.lambda$3(ProjectConfigurationManager.java:339)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:350)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:262)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:205)
> at
> org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1093)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:338)
> at
> org.eclipse.m2e.core.ui.internal.UpdateMavenProjectJob.runInWorkspace(UpdateMavenProjectJob.java:80)
> at
> org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:43)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
> {code}
> due to this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11983) Clear propertyMap when resourceResolver.refresh() is called
[ https://issues.apache.org/jira/browse/SLING-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769550#comment-17769550 ] Henry Kuijpers commented on SLING-11983: To me it seems we should not do this: It's still the same ResourceResolver, it's just being refreshed to be up-to-date with new information committed etc by other resourceresolvers. It could be that clearing this map is desirable for this use-case, but definitely for other use-cases (values you want to keep there for the lifetime of the ResourceResolver object, to use as some sort of cache) it is definitely not desirable to clear this map suddenly when calling refresh. > Clear propertyMap when resourceResolver.refresh() is called > --- > > Key: SLING-11983 > URL: https://issues.apache.org/jira/browse/SLING-11983 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Affects Versions: Resource Resolver 1.10.0 >Reporter: Joerg Hoh >Priority: Major > > The ResourceResolver should clear the the propertyMap when refresh is called. > Also the Javadoc needs to be updated to reflect that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10899) Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached
[ https://issues.apache.org/jira/browse/SLING-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769540#comment-17769540 ] Henry Kuijpers commented on SLING-10899: [~joerghoh] This is the ticket I mentioned at adaptTo(), when you did your session about AEM Backend performance. The thing is: Everytime Resource#adaptTo is called with `ValueMap.class` is parameter, a new JcrValueMap (which has a cache of type Map) is created and returned. Therefore, the cached entries inside that ValueMap are not of much use. As you know, it is not so easy to reuse the same ValueMap in all pieces of the application (as you can only obtain a ValueMap inside your piece of code by doing request.getResource().getValueMap() or request.getResource().adaptTo(ValueMap.class)). This will always yield a new ValueMap, instead of reusing the same one (and reusing the cache, making the cache actually useful). > Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached > -- > > Key: SLING-10899 > URL: https://issues.apache.org/jira/browse/SLING-10899 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.0.22 >Reporter: Henry Kuijpers >Priority: Major > > I was performance testing our application. There is a specific part of the > code where we have a set of ~500 resources and we sort them based on a few > properties of the resources. Multiple properties are used (which results in > multiple calls to getValueMap). The sorting is done using a comparator, so > the logic that determines the order is accessed numerous times. > We've seen quite a decrease in performance when doing this with Resources > that are of type JcrNodeResource. Turns out that the result of getValueMap > (or adaptTo((Value)Map.class)) is not cached. > As you can see in the adaptTo()-method implementation: > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java#L136 > this call bypasses the AdapterFactory framework and also bypasses any > caching that happens over there. > What's even more unfortunate, is that JcrValueMap is implementing caching via > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/6e13f4d315ddf2804d2e16c55faee18e805b618e/src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java#L49 > . That caching is not leveraged properly, because every call to getValueMap > returns a new JcrValueMap, instead of reusing a previously created one. > One change that can be done is maybe converting the logic inside the > adaptTo()-method to a dedicated AdapterFactory implementation, so that > caching is done by default? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12027) GraphQL core fails to build with Java 17
[ https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12027. - Resolution: Fixed > GraphQL core fails to build with Java 17 > > > Key: SLING-12027 > URL: https://issues.apache.org/jira/browse/SLING-12027 > Project: Sling > Issue Type: Bug > Components: GraphQL >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > 1. Mockito fails to create mocks, probably due to old version > 2. Pax-Exam tests time out -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-graphql-core] rombert commented on pull request #38: SLING-12027 - GraphQL core fails to build with Java 17
rombert commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#issuecomment-1736978676 Thanks @schaefa , @raducotescu , @cziegeler for your help, this has been a fun ride :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] rombert merged pull request #38: SLING-12027 - GraphQL core fails to build with Java 17
rombert merged PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] rombert commented on a diff in pull request #38: SLING-12027 - GraphQL core fails to build with Java 17
rombert commented on code in PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#discussion_r1338254898 ## pom.xml: ## @@ -249,7 +249,7 @@ org.apache.sling org.apache.sling.testing.paxexam - 3.1.0 + 4.0.0 Review Comment: Nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #38: SLING-12027 - GraphQL core fails to build with Java 17
sonarcloud[bot] commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#issuecomment-1736915623 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=38) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=38=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=38=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=38=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=38=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=38=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=38=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=38=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=38=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=38=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=38=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=38=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=38=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=38=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=38=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=38=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on a diff in pull request #38: SLING-12027 - GraphQL core fails to build with Java 17
raducotescu commented on code in PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#discussion_r1338185241 ## pom.xml: ## @@ -249,7 +249,7 @@ org.apache.sling org.apache.sling.testing.paxexam - 3.1.0 + 4.0.0 Review Comment: This update brought `org.apache.felix.jetty-5.0.0`, which uses Jetty 11. Unfortunately, there's a Servlet Request Wrapper in Felix that doesn't correctly return the set attributes if they were `RequestDispatcher` attributes - see https://github.com/apache/felix-dev/blob/d691a59c9e78749fad20a10a002c969e4e583800/http/wrappers/src/main/java/org/apache/felix/http/javaxwrappers/ServletRequestWrapper.java#L108-L182 @cziegeler will fix this in Felix and for this test setup we could override the Jetty version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Commons Prometheus Metrics Exporter 0.1.0
On Sun, 2023-09-24 at 18:13 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
