[PR] chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.14.2 [sling-site]
renovate-bot opened a new pull request, #141: URL: https://github.com/apache/sling-site/pull/141 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.github.eirslett:frontend-maven-plugin](https://togithub.com/eirslett/frontend-maven-plugin) | `1.14.1` -> `1.14.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.github.eirslett:frontend-maven-plugin/1.14.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.github.eirslett:frontend-maven-plugin/1.14.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.github.eirslett:frontend-maven-plugin/1.14.1/1.14.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.github.eirslett:frontend-maven-plugin/1.14.1/1.14.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes eirslett/frontend-maven-plugin (com.github.eirslett:frontend-maven-plugin) ### [`v1.14.2`](https://togithub.com/eirslett/frontend-maven-plugin/blob/HEAD/CHANGELOG.md#1142) - Prevent corrupt downloaded files by waiting for the download to complete before writing the file to disk. --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-site). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] trivial - re-enable windows builds [sling-org-apache-sling-app-cms]
sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/45#issuecomment-1780121273 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-app-cms=45) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=45=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=45=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=45=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=45=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=45=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=45=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=45=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=45=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=45=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=45=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=45=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=45=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms=45=coverage=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms=45=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump the npm_and_yarn at /it security update group in /it with 1 update [sling-org-apache-sling-app-cms]
dependabot[bot] opened a new pull request, #46: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/46 Bumps the npm_and_yarn at /it security update group in /it with 1 update: [cypress](https://github.com/cypress-io/cypress). Release notes Sourced from https://github.com/cypress-io/cypress/releases;>cypress's releases. v13.3.3 Changelog: https://docs.cypress.io/guides/references/changelog#13-3-3;>https://docs.cypress.io/guides/references/changelog#13-3-3 v13.3.2 Changelog: https://docs.cypress.io/guides/references/changelog#13-3-2;>https://docs.cypress.io/guides/references/changelog#13-3-2 v13.3.1 Changelog: https://docs.cypress.io/guides/references/changelog#13-3-1;>https://docs.cypress.io/guides/references/changelog#13-3-1 v13.3.0 Changelog: https://docs.cypress.io/guides/references/changelog#13-3-0;>https://docs.cypress.io/guides/references/changelog#13-3-0 v13.2.0 Changelog: https://docs.cypress.io/guides/references/changelog#13-2-0;>https://docs.cypress.io/guides/references/changelog#13-2-0 v13.1.0 Changelog: https://docs.cypress.io/guides/references/changelog#13-1-0;>https://docs.cypress.io/guides/references/changelog#13-1-0 v13.0.0 Changelog: https://docs.cypress.io/guides/references/changelog#13-0-0;>https://docs.cypress.io/guides/references/changelog#13-0-0 v12.17.4 Changelog: https://docs.cypress.io/guides/references/changelog#12-17-4;>https://docs.cypress.io/guides/references/changelog#12-17-4 v12.17.3 Changelog: https://docs.cypress.io/guides/references/changelog#12-17-3;>https://docs.cypress.io/guides/references/changelog#12-17-3 v12.17.2 Changelog: https://docs.cypress.io/guides/references/changelog#12-17-2;>https://docs.cypress.io/guides/references/changelog#12-17-2 v12.17.1 Changelog: https://docs.cypress.io/guides/references/changelog#12-17-1;>https://docs.cypress.io/guides/references/changelog#12-17-1 v12.17.0 Changelog: https://docs.cypress.io/guides/references/changelog#12-17-0;>https://docs.cypress.io/guides/references/changelog#12-17-0 v12.16.0 Changelog: https://docs.cypress.io/guides/references/changelog#12-16-0;>https://docs.cypress.io/guides/references/changelog#12-16-0 v12.15.0 Changelog: https://docs.cypress.io/guides/references/changelog#12-15-0;>https://docs.cypress.io/guides/references/changelog#12-15-0 v12.14.0 Changelog: https://docs.cypress.io/guides/references/changelog#12-14-0;>https://docs.cypress.io/guides/references/changelog#12-14-0 v12.13.0 Changelog: https://docs.cypress.io/guides/references/changelog#12-13-0;>https://docs.cypress.io/guides/references/changelog#12-13-0 v12.12.0 Changelog: https://docs.cypress.io/guides/references/changelog#12-12-0;>https://docs.cypress.io/guides/references/changelog#12-12-0 ... (truncated) Commits https://github.com/cypress-io/cypress/commit/058f3a80b033f16bf57f50ee78f63d8b82e75851;>058f3a8 test: fix spec search in windows (https://redirect.github.com/cypress-io/cypress/issues/28130;>#28130) https://github.com/cypress-io/cypress/commit/7f01e8dffcc4c4310890b374f989d155e8c35720;>7f01e8d chore: 13.3.3 release updates (https://redirect.github.com/cypress-io/cypress/issues/28129;>#28129) https://github.com/cypress-io/cypress/commit/dbd213926c0a6d116d7a392fe679d30519dd9f17;>dbd2139 fix: issue with proxy correlations and web/shared workers (https://redirect.github.com/cypress-io/cypress/issues/28105;>#28105) https://github.com/cypress-io/cypress/commit/d9606868c5201fc7dde5645094b756602b65f4f7;>d960686 fix: fix failures and correlation in proxy (https://redirect.github.com/cypress-io/cypress/issues/28094;>#28094) https://github.com/cypress-io/cypress/commit/74a06c53b886e73f4943f381aefef3697fc1b551;>74a06c5 fix: ignore dash, underscore and space in search (https://redirect.github.com/cypress-io/cypress/issues/28012;>#28012) https://github.com/cypress-io/cypress/commit/04a1156ccd6093441c17ea04c98570ef8470a239;>04a1156 chore: 13.3.2 release (https://redirect.github.com/cypress-io/cypress/issues/28086;>#28086) https://github.com/cypress-io/cypress/commit/5d667b339773c6439a83422190ebf89b875ab95d;>5d667b3 chore: update cache-version date (https://redirect.github.com/cypress-io/cypress/issues/28084;>#28084) https://github.com/cypress-io/cypress/commit/ff89ffa2b2ef36d02bff0588bb0582cfa8a6002d;>ff89ffa fix: proxy issues with service workers and clean up at end of specs (https://redirect.github.com/cypress-io/cypress/issues/28060;>#28060) https://github.com/cypress-io/cypress/commit/a96b9b1f53bf35433f6cfa1f150221499f151152;>a96b9b1 chore: remove Cypress Conf promo from README (https://redirect.github.com/cypress-io/cypress/issues/28076;>#28076) https://github.com/cypress-io/cypress/commit/ca6d30d7bf1811dda32c389bdb99aaeb975701c0;>ca6d30d fix: force gzip when no accept encoding header is sent and use identity if gz... Additional commits
Re: [PR] Bump the npm_and_yarn at /it security update group in /it with 2 updates [sling-org-apache-sling-app-cms]
dependabot[bot] closed pull request #42: Bump the npm_and_yarn at /it security update group in /it with 2 updates URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump the npm_and_yarn at /it security update group in /it with 2 updates [sling-org-apache-sling-app-cms]
dependabot[bot] commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/42#issuecomment-1780100952 Looks like these dependencies are updatable in another way, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] trivial - re-enable windows builds [sling-org-apache-sling-app-cms]
klcodanr opened a new pull request, #45: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/45 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump the npm_and_yarn at /it security update group in /it with 2 updates [sling-org-apache-sling-app-cms]
klcodanr commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/42#issuecomment-1780099106 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] trivial: re-enabling Java 17 build [sling-org-apache-sling-app-cms]
klcodanr merged PR #44: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency jakarta.json:jakarta.json-api to v2.1.3 [sling-org-apache-sling-starter]
rombert merged PR #262: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump socket.io-parser from 3.4.2 to 3.4.3 in /it [sling-org-apache-sling-app-cms]
klcodanr merged PR #37: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] trivial: re-enabling Java 17 build [sling-org-apache-sling-app-cms]
sonarcloud[bot] commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/44#issuecomment-1779755396 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-app-cms=44) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=44=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=44=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=44=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=44=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=44=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=44=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=44=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=44=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=44=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=44=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=44=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=44=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms=44=coverage=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms=44=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump socket.io-parser from 3.4.2 to 3.4.3 in /it [sling-org-apache-sling-app-cms]
sonarcloud[bot] commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/37#issuecomment-1779745924 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-app-cms=37) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=37=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=37=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=37=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms=37=coverage=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms=37=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump socket.io-parser from 3.4.2 to 3.4.3 in /it [sling-org-apache-sling-app-cms]
sonarcloud[bot] commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/37#issuecomment-1779740686 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-app-cms=37) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=37=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=37=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=37=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=37=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms=37=coverage=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms=37=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] trivial: re-enabling Java 17 build [sling-org-apache-sling-app-cms]
klcodanr opened a new pull request, #44: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/44 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11069 - Sync Latest Change from Starter [sling-org-apache-sling-app-cms]
sonarcloud[bot] commented on PR #43: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/43#issuecomment-1779717342 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-app-cms=43) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=43=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=43=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=43=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=43=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=43=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=43=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=43=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=43=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms=43=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=43=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=43=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms=43=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms=43=coverage=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms=43=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.sling.i18n from 2.5.18 to 2.6.2 [sling-org-apache-sling-app-cms]
dependabot[bot] closed pull request #33: Bump org.apache.sling.i18n from 2.5.18 to 2.6.2 URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.sling.i18n from 2.5.18 to 2.6.2 [sling-org-apache-sling-app-cms]
dependabot[bot] commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/33#issuecomment-1779709344 Looks like org.apache.sling:org.apache.sling.i18n is no longer updatable, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump socket.io-parser from 3.4.2 to 3.4.3 in /it [sling-org-apache-sling-app-cms]
klcodanr commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/37#issuecomment-1779709987 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.sling.i18n from 2.5.18 to 2.6.2 [sling-org-apache-sling-app-cms]
klcodanr commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/33#issuecomment-1779708818 https://github.com/dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-11069 - Sync Latest Change from Starter [sling-org-apache-sling-app-cms]
klcodanr opened a new pull request, #43: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/43 diff --git a/feature/src/main/features/base-repoinit.txt b/feature/src/main/features/base-repoinit.txt index 3ad1228..99b3cd7 100644 --- a/feature/src/main/features/base-repoinit.txt +++ b/feature/src/main/features/base-repoinit.txt @@ -84 +84 @@ create path (sling:Folder) /etc/map -create path (sling:Folder) /etc/map/http +create path (sling:Folder) /etc/map/http \ No newline at end of file diff --git a/feature/src/main/features/boot.json b/feature/src/main/features/boot.json index 37024a9..623372b 100644 --- a/feature/src/main/features/boot.json +++ b/feature/src/main/features/boot.json @@ -116 +116 @@ - "id":"org.eclipse.parsson:parsson:1.1.4", + "id":"org.eclipse.parsson:parsson:1.1.5", This PR is auto-generated by [sync-cms](https://github.com/klcodanr/Scripts/blob/master/.github/workflows/sync-cms.yaml). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12120) Align Feature Structure with Starter
[ https://issues.apache.org/jira/browse/SLING-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779541#comment-17779541 ] Dan Klco commented on SLING-12120: -- That's a really good question [~rombert]. For the moment, I was planning on syncing the directories manually. We could consider a "sling base" type feature aggregate which contains the common configurations and dependencies for a generic sling application. The problem is that with the [ASF release process|https://www.apache.org/legal/release-policy.html#release-approval], we'd either have to go through a full release vote for this _very_ frequently or accept that the base will only be updated when we decide to do a major Sling release. Another option would be to designate certain features / directories as "base" features which would make synchronizing these features easier or potentially even automated by just copying the relevant directories. > Align Feature Structure with Starter > > > Key: SLING-12120 > URL: https://issues.apache.org/jira/browse/SLING-12120 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.8 > > > There's a significant delta between the configuration of the CMS app and the > Sling Starter. Now that the Sling Starter is receiving regular updates, it'd > be beneficial to align the feature structure in the CMS App with the starter > to enable easy syncing of updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1097 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1097/ for details. No further emails will be sent until the status of the build is changed.
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1096 is BROKEN
] [INFO] --- docker:0.43.4:stop (stop-mongo) @ org.apache.sling.starter --- [INFO] DOCKER> [mongo:4.4.6] "mongo": Stop and removed container 58aa1fc7da58 after 0 ms [INFO] [INFO] --- failsafe:3.0.0-M5:verify (default) @ org.apache.sling.starter --- [INFO] Failsafe report directory: /home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master/jdk_21_latest/target/failsafe-reports [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 06:43 min [INFO] Finished at: 2023-10-25T12:28:24Z [INFO] [INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master/jdk_21_latest@tmp/withMavendf62c442/maven-spy-20231025-122140-54411053008877888360406.log [Pipeline] } [withMaven] Jenkins FindBugs Plugin not found, don't display org.codehaus.mojo:findbugs-maven-plugin:findbugs results in pipeline screen. [withMaven] jgivenPublisher - Jenkins JGiven Plugin not found, do not archive jgiven reports. [DevOpticsMavenPublisher] dependencies consumed: 0, artifacts produced: 32 [withMaven] Publishers: Pipeline Graph Publisher: 15 ms, Findbugs Publisher: 1 ms, CloudBees DevOptics Gate Artifact Publisher: 190505 ms [Pipeline] // withMaven [Pipeline] } [Pipeline] // stage [Pipeline] } [Pipeline] // timeout [Pipeline] } [Pipeline] // dir [Pipeline] } [Pipeline] // node [Pipeline] } [DevOpticsMavenPublisher] dependencies consumed: 0, artifacts produced: 32 [withMaven] Publishers: Pipeline Graph Publisher: 14 ms, Findbugs Publisher: 1 ms, JGiven Publisher: 1 ms, CloudBees DevOptics Gate Artifact Publisher: 178652 ms [Pipeline] // withMaven [Pipeline] } [Pipeline] // stage [Pipeline] } [Pipeline] // timeout [Pipeline] } [Pipeline] // dir [Pipeline] } [Pipeline] // node [Pipeline] } ESAPI: WARNING: System property [org.owasp.esapi.opsteam] is not set ESAPI: WARNING: System property [org.owasp.esapi.devteam] is not set ESAPI: Attempting to load ESAPI.properties via file I/O. ESAPI: Attempting to load ESAPI.properties as resource file via file I/O. ESAPI: Not found in 'org.owasp.esapi.resources' directory or file not readable: /home/jenkins/jenkins-agent/712657a4/workspace/_org-apache-sling-starter_master/jdk_11_latest/target/launchers/ESAPI.properties ESAPI: Not found in SystemResource Directory/resourceDirectory: .esapi/ESAPI.properties ESAPI: Not found in 'user.home' (/home/jenkins) directory: /home/jenkins/esapi/ESAPI.properties ESAPI: Loading ESAPI.properties via file I/O failed. Exception was: java.io.FileNotFoundException ESAPI: Attempting to load ESAPI.properties via the classpath. ESAPI: SUCCESSFULLY LOADED ESAPI.properties via the CLASSPATH from '/ (root)' using class loader for DefaultSecurityConfiguration class! ESAPI: SecurityConfiguration for Validator.ConfigurationFile.MultiValued not found in ESAPI.properties. Using default: false ESAPI: Attempting to load validation.properties via file I/O. ESAPI: Attempting to load validation.properties as resource file via file I/O. ESAPI: Not found in 'org.owasp.esapi.resources' directory or file not readable: /home/jenkins/jenkins-agent/712657a4/workspace/_org-apache-sling-starter_master/jdk_11_latest/target/launchers/validation.properties ESAPI: Not found in SystemResource Directory/resourceDirectory: .esapi/validation.properties ESAPI: Not found in 'user.home' (/home/jenkins) directory: /home/jenkins/esapi/validation.properties ESAPI: Loading validation.properties via file I/O failed. ESAPI: Attempting to load validation.properties via the classpath. ESAPI: SUCCESSFULLY LOADED validation.properties via the CLASSPATH from '/ (root)' using class loader for DefaultSecurityConfiguration class! [ERROR] Tests run: 6, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 982.374 s <<< FAILURE! - in org.apache.sling.launchpad.SmokeIT [ERROR] org.apache.sling.launchpad.SmokeIT.ensureRepositoryIsStarted[Port: 43109] Time elapsed: 966.52 s <<< ERROR! java.lang.RuntimeException: Starter not ready or path not found after 60 tries (966485 msec). Request to URL http://localhost:43109//server/default/jcr:root/content failed with message 'Status code is HTTP/1.1 503 Service Unavailable' [ERROR] org.apache.sling.launchpad.SmokeIT.verifyAllBundlesStarted[Port: 43109] Time elapsed: 0 s <<< ERROR! java.lang.RuntimeException: StarterReadyRule failed previously on port 43109, refusing to run more tests Caused by: java.lang.RuntimeException: Starter not ready or path not found after 60 tries (966485 msec). Request to URL http://localhost:43109//server/default/jcr:root/content failed with message 'Status code is HTTP/1.1 503 Service Unavailable' [ERROR] org.apache.sling.launchpad.SmokeIT.checkReadableUrls[Port: 43109] Time elapsed: 0.001 s <<< ERROR! java.lang.Run
Re: [PR] SLING-12122 - Add unit-test creating group with rep:externalId property [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #46: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/46#issuecomment-1779141506 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=46) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=46=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=46=coverage=list) No Coverage information [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=46=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=46=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]
anchela commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1779107332 @jsedding , the options were initially introduced into the parser to add the same option-nightmare that we are having in filevault. fortunately, this was never implemented in jcr-repoinit and i hoped to make it clear in JIRA why I would oppose to that. if we can repurpose the options for something sensible, i don't mind but maybe you also want to reach out @bdelacretaz . he might want to have a say here as the original author of repoinit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12122 - Add unit-test creating group with rep:externalId property [sling-org-apache-sling-jcr-repoinit]
anchela commented on code in PR #46: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/46#discussion_r1371602673 ## src/test/java/org/apache/sling/jcr/repoinit/CreateGroupWithExternalIdTest.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.sling.jcr.repoinit; + +import org.apache.jackrabbit.api.security.user.Authorizable; +import org.apache.jackrabbit.oak.jcr.Jcr; +import org.apache.jackrabbit.oak.security.internal.SecurityProviderBuilder; +import org.apache.jackrabbit.oak.spi.security.ConfigurationParameters; +import org.apache.jackrabbit.oak.spi.security.SecurityProvider; +import org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.ExternalPrincipalConfiguration; +import org.apache.sling.jcr.repoinit.impl.TestUtil; +import org.apache.sling.jcr.repoinit.impl.UserUtil; +import org.apache.sling.repoinit.parser.RepoInitParsingException; +import org.jetbrains.annotations.NotNull; +import org.junit.Test; + +import javax.jcr.Repository; +import javax.jcr.RepositoryException; +import javax.jcr.Session; +import javax.jcr.SimpleCredentials; +import javax.jcr.Value; +import javax.jcr.nodetype.ConstraintViolationException; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertThrows; + +public class CreateGroupWithExternalIdTest { + +private static final String GROUP_NAME = "testGroup"; + +@Test +public void setRepExternalIdPropertyOnExistingGroupFails() throws RepositoryException, RepoInitParsingException { +// validates the test setup more than anything else +TestUtil U = createTestUtil(); + +U.assertGroup(GROUP_NAME + " should not yet exist", GROUP_NAME, false); + +U.parseAndExecute("create group " + GROUP_NAME); +U.assertGroup(GROUP_NAME + " should exist", GROUP_NAME, true); + +assertThrows(ConstraintViolationException.class, () -> U.parseAndExecute( +"set properties on authorizable(" + GROUP_NAME + ")", +" set rep:externalId to \"" + GROUP_NAME + ";ldap\"", +"end" +)); +// The ConstraintViolationException does not refresh the session automatically, +// so the invalid changes are still transiently present and need to be explicitly dropped. +U.getAdminSession().refresh(false); + +final Authorizable group = UserUtil.getAuthorizable(U.getAdminSession(), GROUP_NAME); +assertNull(GROUP_NAME + " should not have a rep:externalId property", group.getProperty("rep:externalId")); +} + +@Test +public void setRepExternalIdPropertyOnNewGroupSucceeds() throws RepositoryException, RepoInitParsingException { +TestUtil U = createTestUtil(); + +U.assertGroup(GROUP_NAME + " should not yet exist", GROUP_NAME, false); + +// Do this twice in order to test initial creation and update scenarios. +for (int i = 0; i < 2; i++) { +U.parseAndExecute( +"create group " + GROUP_NAME, +"set properties on authorizable(" + GROUP_NAME + ")", +" set rep:externalId to \"" + GROUP_NAME + ";ldap\"", +"end" +); +U.assertGroup(GROUP_NAME + " should have been created", GROUP_NAME, true); + +final Authorizable group = UserUtil.getAuthorizable(U.getAdminSession(), GROUP_NAME); +final Value[] externalIdValues = group.getProperty("rep:externalId"); +assertEquals(1, externalIdValues.length); +assertEquals(GROUP_NAME + ";ldap", externalIdValues[0].getString()); +} +} + +@NotNull +private static TestUtil createTestUtil() throws RepositoryException { +final SecurityProvider securityProvider = createSecurityProvider(); + +final Repository repository = new Jcr() +.with(securityProvider) +.createRepository(); +final Session adminSession = repository.login(new SimpleCredentials("admin", "admin".toCharArray())); +return new TestUtil(adminSession); +} + +@NotNull
[PR] SLING-12122 - Add unit-test creating group with rep:externalId property [sling-org-apache-sling-jcr-repoinit]
jsedding opened a new pull request, #46: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/46 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12122) Add unit-test creating group with rep:externalId property
Julian Sedding created SLING-12122: -- Summary: Add unit-test creating group with rep:externalId property Key: SLING-12122 URL: https://issues.apache.org/jira/browse/SLING-12122 Project: Sling Issue Type: Test Components: Repoinit Affects Versions: Repoinit JCR 1.1.44 Reporter: Julian Sedding Assignee: Julian Sedding Fix For: Repoinit JCR 1.1.46 Add a unit-test validating that repoinit can successfully create a new group with the {{rep:externalId}} property, that can only be set on creation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] chore(deps): update dependency org.eclipse.parsson:parsson to v1.1.5 [sling-org-apache-sling-starter]
rombert merged PR #263: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12120) Align Feature Structure with Starter
[ https://issues.apache.org/jira/browse/SLING-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779396#comment-17779396 ] Robert Munteanu commented on SLING-12120: - [~dklco] - I'm curious to hear if you have any ideas about keeping the Starter and downstream apps (CMS for instance) in sync, other than manually watching and applying the changes. Version updates might be easy to do with similar renovate configurations, but for structural changes like SLING-12117 I am not sure what can be done. > Align Feature Structure with Starter > > > Key: SLING-12120 > URL: https://issues.apache.org/jira/browse/SLING-12120 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.8 > > > There's a significant delta between the configuration of the CMS app and the > Sling Starter. Now that the Sling Starter is receiving regular updates, it'd > be beneficial to align the feature structure in the CMS App with the starter > to enable easy syncing of updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.14.1 [sling-site]
rombert merged PR #140: URL: https://github.com/apache/sling-site/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12107 - JCR Repoinit executes operations out of order [sling-org-apache-sling-jcr-repoinit]
kwin commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/44#issuecomment-1778690993 I don't think this change does any harm and better fulfils the [principle of least surprise](https://en.wikipedia.org/wiki/Principle_of_least_astonishment). Therefore I won't revert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12107 - JCR Repoinit executes operations out of order [sling-org-apache-sling-jcr-repoinit]
jsedding commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/44#issuecomment-1778682001 **Update:** Yesterday evening I wrote a unit test around the repoinit snippet below, making sure the repository is initialized with the validator for `rep:externalId`. I'll contribute this test today via a separate PR. It turns out that I was wrong (my manual tests must have been incorrect) and this snippet works (test passes). I even went back to org.apache.sling.jcr.repoinit-1.1.38 and the test also passes. ``` create group fooBar set properties on authorizable(fooBar) set rep:externalId to "fooBar;ldap" end ``` Subsequently, I repeated my manual tests twice and they also passed. Now the question is whether this change should be reverted? I still consider it a valuable change/fix that better aligns the implementation with implicit expectations of the users of repoinit. WDYT @anchela, @kwin ? @kwin I saw your comment regarding documentation and will add a paragraph if we decide to keep this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]
jsedding commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1778664454 I like @kwin's suggestion to use options. Especially if that does not require a parser change. Would that work for you @anchela? @anchela yes, I am aware of the (or at least some) complications of updating the repoinit parser. I'll exercise caution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org