Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
henrykuijpers commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1797852858 @rmcdouga That is indeed an infinite loop. Nicely spotted! Given that this whole thing would really boil down to a thing in very old (unsupported) jdk versions and given that Dictionary should not be used anymore (however, it is still being used in OSGi!), it can be safely removed. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] trivial - adding jenkins build m2 repo to IT launcher config [sling-org-apache-sling-app-cms]
klcodanr opened a new pull request, #50: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/50 Build with new snapshot fails due to not being able to retrieve installed artifacts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-11069 - Sync Latest Change from Starter [sling-org-apache-sling-app-cms]
klcodanr opened a new pull request, #49: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/49 This PR is auto-generated by [sync-cms](https://github.com/klcodanr/Scripts/blob/master/.github/workflows/sync-cms.yaml). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12130) Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest libraries
[ https://issues.apache.org/jira/browse/SLING-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783402#comment-17783402 ] Rob McDougall commented on SLING-12130: --- So, I went ahead and fixed it, but I am running across a code coverage issue with SonarCube. There's some code I didn't write but that I modified (added types to an untyped Generic). This particular class didn't have good code coverage to begin with but, being keen, I added tests. The problem is the new test code uncovered a problem with the previously untested code. The code pertains to an if statement that tries to handle the case where the object passed in is a Map or a Dictionary object. The Map code works just fine, but the Dictionary code creates a Stack Overflow error. I'd like to just remove it. Dictionary is old and its only subclass is HashTable (which implements Map), so the only use case we lose is if someone has a custom class the derives from Dictionary but does not implement Map. Given how old Dictionary is, I would like to just remove that code and not handle that case. Strictly speaking this is a breaking change however it seems like quite a remote possibility that any code would, in practice, actually break. Before I do that however, I'd like to get the OK to make that change. > Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest > libraries > - > > Key: SLING-12130 > URL: https://issues.apache.org/jira/browse/SLING-12130 > Project: Sling > Issue Type: Task >Reporter: Rob McDougall >Priority: Major > Fix For: Testing Hamcrest 1.0.4 > > > The Apache Sling Hamcrest Matchers use hamcrest-library 1.3 > ([here|[https://github.com/apache/sling-org-apache-sling-testing-hamcrest/blob/master/pom.xml]).] > This version is circa 2012. The latest (2.2) is from 2019 ([as shown > here|[https://central.sonatype.com/artifact/org.hamcrest/hamcrest-core/versions]).] > > Is it OK if I make a PR to update to the latest version? -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
rmcdouga commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1797023577 There's a serious issue in the MapUtils code. The code tries to handle a Dictionary object but does so poorly (generates a StackOverflow error). Now it turns out this wasn't caught before because Dictionary is an abstract class with only one subclass in the JDK (HashTable). HashTable implements Map, so Hashtables don't ever make it down to the Dictionary-specific code. The only code that will make it down there is a custom subclass of Dictionary. Given how old and unused Dictionary is (it was replaced by Map in JDK 1.2), I think it's safe to remove the section of code that tries (unsuccessfully) to deal with Dictionary subclasses, but I would like to verify that this is OK with a committer before I do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1797018177 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-hamcrest=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_coverage=list) [66.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1796977008 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-hamcrest=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_coverage=list) [33.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12130) Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest libraries
[
https://issues.apache.org/jira/browse/SLING-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783394#comment-17783394
]
Rob McDougall commented on SLING-12130:
---
OK, PR created:
[https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2]
It's failing because of some JavaDoc comments that I didn't change. If you're
OK with it, I will fix it by converting text using `` tags to use \{@code}
instead.
> Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest
> libraries
> -
>
> Key: SLING-12130
> URL: https://issues.apache.org/jira/browse/SLING-12130
> Project: Sling
> Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
> Fix For: Testing Hamcrest 1.0.4
>
>
> The Apache Sling Hamcrest Matchers use hamcrest-library 1.3
> ([here|[https://github.com/apache/sling-org-apache-sling-testing-hamcrest/blob/master/pom.xml]).]
> This version is circa 2012. The latest (2.2) is from 2019 ([as shown
> here|[https://central.sonatype.com/artifact/org.hamcrest/hamcrest-core/versions]).]
>
> Is it OK if I make a PR to update to the latest version?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
rmcdouga commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1796858810
The build failure was not in a file I changed. The line in question uses
the tag in a JavaDoc comment. The JavaDoc compiler says that this tag is
unsupported in this version of HTML.
Should I change the files to use {@code} instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
rmcdouga opened a new pull request, #2: URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2 Moved assertThat in tests over to Hamcrest's assertThat. Moved from deprecated IsCollectionContaining to IsIterableContaining in MapUtil. Addressed some type warnings by adding types to untyped generics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12130) Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest libraries
[ https://issues.apache.org/jira/browse/SLING-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12130: Fix Version/s: Testing Hamcrest 1.0.4 > Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest > libraries > - > > Key: SLING-12130 > URL: https://issues.apache.org/jira/browse/SLING-12130 > Project: Sling > Issue Type: Task >Reporter: Rob McDougall >Priority: Major > Fix For: Testing Hamcrest 1.0.4 > > > The Apache Sling Hamcrest Matchers use hamcrest-library 1.3 > ([here|[https://github.com/apache/sling-org-apache-sling-testing-hamcrest/blob/master/pom.xml]).] > This version is circa 2012. The latest (2.2) is from 2019 ([as shown > here|[https://central.sonatype.com/artifact/org.hamcrest/hamcrest-core/versions]).] > > Is it OK if I make a PR to update to the latest version? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12130) Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest libraries
[ https://issues.apache.org/jira/browse/SLING-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783387#comment-17783387 ] Robert Munteanu commented on SLING-12130: - Hi [~RobMcDougall] - sure, feel free to create a PR! > Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest > libraries > - > > Key: SLING-12130 > URL: https://issues.apache.org/jira/browse/SLING-12130 > Project: Sling > Issue Type: Task >Reporter: Rob McDougall >Priority: Major > > The Apache Sling Hamcrest Matchers use hamcrest-library 1.3 > ([here|[https://github.com/apache/sling-org-apache-sling-testing-hamcrest/blob/master/pom.xml]).] > This version is circa 2012. The latest (2.2) is from 2019 ([as shown > here|[https://central.sonatype.com/artifact/org.hamcrest/hamcrest-core/versions]).] > > Is it OK if I make a PR to update to the latest version? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12130) Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest libraries
Rob McDougall created SLING-12130: - Summary: Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest libraries Key: SLING-12130 URL: https://issues.apache.org/jira/browse/SLING-12130 Project: Sling Issue Type: Task Reporter: Rob McDougall The Apache Sling Hamcrest Matchers use hamcrest-library 1.3 ([here|[https://github.com/apache/sling-org-apache-sling-testing-hamcrest/blob/master/pom.xml]).] This version is circa 2012. The latest (2.2) is from 2019 ([as shown here|[https://central.sonatype.com/artifact/org.hamcrest/hamcrest-core/versions]).] Is it OK if I make a PR to update to the latest version? -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling ResourceResolver 1.11.2
+1 On Mon, Nov 6, 2023 at 5:32 AM Carsten Ziegeler wrote: > +1 > > Carsten > > On 05.11.2023 12:21, Jörg Hoh wrote: > > Hi, > > > > We solved 4 issues in this > > release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353649=Text > > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2802/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > > sh check_staged_release.sh 2802 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > > > > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1116 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1116/ for details. No further emails will be sent until the status of the build is changed.
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1115 is BROKEN
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1115/
for details.
No further emails will be sent until the status of the build is changed.
Build log follows below:
[...truncated 51142 lines...]
flex: 0 0 35%
}
.Grid .Cell.Large-50 {
flex: 0 0 50%
}
.Grid.Fit-Large > .Cell {
-webkit-box-flex: 1;
-webkit-flex: 1;
-ms-flex: 1;
flex: 1
}
}
@media (min-width: 75em) {
.Grid.Fit-Extra > .Cell {
-webkit-box-flex: 1;
-webkit-flex: 1;
-ms-flex: 1;
flex: 1
}
}
* {
box-sizing: border-box
}
body {
font-family: 'Open Sans', Helvetica, Arial;
color: gray;
position: relative;
height: 100%;
}
h1 {
font-size: 2.4em;
color: #606060
}
h2 {
font-weight: 400;
font-size: 1em
}
a {
color: #00678c;
text-decoration: none
}
a:hover {
text-decoration: underline
}
a img {
border: none
}
.Home-Grid {
min-height: 100%
}
.Home-Grid .Gradient {
flex: 0 0 100%;
height: 16px;
background:
Re: [PR] chore(deps): update dependency org.apache.jackrabbit.vault:org.apache.jackrabbit.vault to v3.7.2 [sling-org-apache-sling-starter]
rombert merged PR #268: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.jackrabbit.vault:org.apache.jackrabbit.vault to v3.7.2 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #268: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/268 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.jackrabbit.vault:org.apache.jackrabbit.vault](https://jackrabbit.apache.org/filevault/) | `3.7.0` -> `3.7.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update apache pdfbox to v2.0.30 [sling-org-apache-sling-starter]
rombert merged PR #267: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1113 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1113/ for details. No further emails will be sent until the status of the build is changed.
Re: [VOTE] Release Apache Sling ResourceResolver 1.11.2
+1 Carsten On 05.11.2023 12:21, Jörg Hoh wrote: Hi, We solved 4 issues in this release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353649=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2802/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2802 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Carsten Ziegeler Adobe cziege...@apache.org
[PR] chore(deps): update apache pdfbox to v2.0.30 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #267: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/267 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.pdfbox:fontbox](http://pdfbox.apache.org/) ([source](https://togithub.com/apache/maven-apache-parent)) | `2.0.29` -> `2.0.30` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [org.apache.pdfbox:pdfbox](https://www.apache.org/) ([source](https://togithub.com/apache/maven-apache-parent)) | `2.0.29` -> `2.0.30` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.felix:org.apache.felix.http.jetty to v5.1.4 [sling-org-apache-sling-starter]
rombert merged PR #266: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1382983926
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -156,8 +156,11 @@ private static void setAcl(Session session, List
principals, String jcrP
if (principal == null) {
// backwards compatibility: fallback to original code treating
principal name as authorizable ID (see SLING-8604)
final Authorizable authorizable =
UserUtil.getAuthorizable(session, name);
-checkState(authorizable != null, "Authorizable not found:
{0}", name);
-principal = authorizable.getPrincipal();
+if (authorizable != null) {
+principal = authorizable.getPrincipal();
+} else {
+principal = () -> name;
Review Comment:
I think this is resolved with my latest changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]
jsedding commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1794381325 If there are no objections, I will merge this PR tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12107) JCR Repoinit executes operations out of order
[
https://issues.apache.org/jira/browse/SLING-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding resolved SLING-12107.
Resolution: Fixed
> JCR Repoinit executes operations out of order
> -
>
> Key: SLING-12107
> URL: https://issues.apache.org/jira/browse/SLING-12107
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.44
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Major
> Fix For: Repoinit JCR 1.1.46
>
>
> When applying ACLs, repoinit checks if the referenced authorizable exists,
> and it fails if it doesn't.
> However, my goal was to set up ACLs with my deployment for a group that was
> to be sync'ed from an {{ExternalIdentityProvider}} once the first member of
> that group logs in.
> To work around this limitation, I tried running the following repoinit script:
> {noformat}
> create group testGroup
> set ACL for testGroup
> allow jcr:read on /content/foo
> deny jcr:write on /content/foo
> end
> delete group testGroup
> {noformat}
> It turned out that the statements were executed in the following order:
> {noformat}
> create group testGroup
> delete group testGroup
> set ACL for testGroup
> allow jcr:read on /content/foo
> deny jcr:write on /content/foo
> end
> {noformat}
> Of course that caused the script to fail just as if no group was created.
> The incorrect ordering may also cause other scenarios to fail.
> The {{ExecutionOrderTest}} suggests that some re-ordering is done on purpose.
> E.g. namespaces and nodetypes should be created before e.g. paths are created.
> I would expect that registration of custom privileges should also be executed
> before other operations. I don't see how that could be harmful.
> But for all other statements, I would expect the execution order to match the
> order of the statements within the repoinit script.
> cc [~bdelacretaz], [~cziegeler], [~angela]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [VOTE] Release Apache Sling ResourceResolver 1.11.2
+1 - all checks ok Regards Julian On Sun, Nov 5, 2023 at 12:22 PM Jörg Hoh wrote: > > my +1 > > Am So., 5. Nov. 2023 um 12:21 Uhr schrieb Jörg Hoh : > > > Hi, > > > > We solved 4 issues in this > > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353649=Text > > > > Staging > > repository:https://repository.apache.org/content/repositories/orgapachesling-2802/ > > > > You can use this UNIX script to download the release and verify the > > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > > sh check_staged_release.sh 2802 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > > > > > -- > > Cheers, > > Jörg Hoh, > > > > https://cqdump.joerghoh.de > > Twitter: @joerghoh > > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh
