[jira] [Resolved] (SLING-12153) Update maven-archiver and maven-filtering
[ https://issues.apache.org/jira/browse/SLING-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12153. - Resolution: Fixed > Update maven-archiver and maven-filtering > - > > Key: SLING-12153 > URL: https://issues.apache.org/jira/browse/SLING-12153 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Minor > Fix For: OSGi Feature Maven Plugin 1.8.2 > > > [~jsedding] noticed that the plug-in brings in older versions of the > maven-archiver and maven-filtering. Those dependencies > {quote}drag an ancient guava version into the classpath via a transitive > dependency that was moved into "test" scope in newer versions of these two > libraries{quote} > This causes various problems with IntelliJ and Eclipse integration. And > upgrading dependencies is always a good idea :-) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12153 - Update maven-archiver and maven-filtering [sling-slingfeature-maven-plugin]
rombert merged PR #81: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11067) Extend URIProvider to not rely on exceptions if URIs can not be provided for a resource
[ https://issues.apache.org/jira/browse/SLING-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786201#comment-17786201 ] Carsten Ziegeler commented on SLING-11067: -- [~kwin] Can we close this please? > Extend URIProvider to not rely on exceptions if URIs can not be provided for > a resource > --- > > Key: SLING-11067 > URL: https://issues.apache.org/jira/browse/SLING-11067 > Project: Sling > Issue Type: Improvement > Components: API >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently URIProvider is not allowed to return null according to > https://github.com/apache/sling-org-apache-sling-api/blob/333fa20f07a1d42897c9e0b6253bec5dcedb3e0b/src/main/java/org/apache/sling/api/resource/external/URIProvider.java#L48. > This forces every URIProvider to throw an exception for the (pretty common) > case it cannot provide a URI for a resource. > As creating exceptions comes with quite some overhead, I would propose to > enhance that interface. > As just allowing null return values would be backwards-incompatible I would > propose to instead add a second method called {{Optional > getOptionalUriForResource(Resource, Scope, Operation)}} with a default > implementation which calls {{toUri(...)}} and properly catches and logs > IllegalArgumentExceptions. At the same time I would deprecate the existing > method {{toURI(...)}}. > Compare with the discussion at > https://lists.apache.org/thread/xfgmrxbv6n1k5y57v6kq9pxnkyr6hcyb -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-9662) Introduce an URI Mapping SPI
[ https://issues.apache.org/jira/browse/SLING-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-9662. - Resolution: Won't Fix No activity, seems everyone lost interest, therefore closing > Introduce an URI Mapping SPI > > > Key: SLING-9662 > URL: https://issues.apache.org/jira/browse/SLING-9662 > Project: Sling > Issue Type: New Feature > Components: API >Reporter: Georg Henzler >Assignee: Georg Henzler >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > _an earlier version used the terms ResourceUri/ResourceToUriMapper (updated > this description during the discussion)_ > Introduce a simple SPI that allows to contribute to the resource resolver's > map() and resolve() methods: > Prerequisite *SlingUri:* (SLING-9745 to be completed first) > General purpose class to represent a ResourceUri (like e.g. a link in an html > tag). Immutable itself but adjustable using the builder pattern. Part of > the Sling API and can be used anywhere to simplify handling/modification of > Sling ResourceUri. Implements RequestPathInfo. ResourceUri can be created > easily from a String, a Request, a Resource, a URI or a RequestPathInfo. > *SlingUriMapper:* > SPI interface to be implemented as OSGi Service. All registered services > build a conceptual chain sorted by service ranking. The resource link is > passed through the chain while any SlingUriMapper chain member may or may not > make adjustments to the resource link. > rr.resolve() passes through the chain starting at the SlingUriMapper with > the highest service ranking and rr.map() passes through the > chain starting at the SlingUriMapper with the lowest service > ranking > *PathToUriMappingService:* > The new OSGi service to provide path to URI resolution and path to URI > mapping. The methods rr.resolve() and rr.map() and should delegate to this > service. > > _Mailing List References:_ > [https://www.mail-archive.com/dev@sling.apache.org/msg93537.html] > [https://www.mail-archive.com/dev@sling.apache.org/msg87736.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Feature/sling 9662 introduce sling uri mapping spi v3 [sling-org-apache-sling-auth-core]
cziegeler closed pull request #6: Feature/sling 9662 introduce sling uri mapping spi v3 URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-9662 Introduce Resource Mapping SPI [sling-org-apache-sling-resourceresolver]
cziegeler closed pull request #22: SLING-9662 Introduce Resource Mapping SPI URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-9745 Sling Uri Mapping SPI [sling-org-apache-sling-api]
cziegeler closed pull request #25: SLING-9745 Sling Uri Mapping SPI URL: https://github.com/apache/sling-org-apache-sling-api/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Engine 2.15.8
+1 Am Di., 14. Nov. 2023 um 19:50 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 3 issues > > https://issues.apache.org/jira/browse/SLING-12152?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Engine%202.15.8%22 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2809/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2809 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[jira] [Commented] (SLING-12154) 404 on Composum Nodes Health Check
[ https://issues.apache.org/jira/browse/SLING-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786171#comment-17786171 ] Dan Klco commented on SLING-12154: -- Pull request with a fix: https://github.com/apache/sling-org-apache-sling-starter/pull/275 > 404 on Composum Nodes Health Check > -- > > Key: SLING-12154 > URL: https://issues.apache.org/jira/browse/SLING-12154 > Project: Sling > Issue Type: Bug > Components: Starter >Affects Versions: Starter 12 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Starter 13 > > Attachments: image-2023-11-15-00-05-08-595.png > > > Composum Nodes in the Sling Starter logs a 404 response and is unable to load > the System Health due to the Composum Generic Request Proxy not being > configured: > !image-2023-11-15-00-05-08-595.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] SLING-12154 - Add Generic Proxy configuration for Composum Health Checks [sling-org-apache-sling-starter]
klcodanr opened a new pull request, #275: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/275 Currently returns a 404 due to the proxy not being configured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12154) 404 on Composum Nodes Health Check
Dan Klco created SLING-12154: Summary: 404 on Composum Nodes Health Check Key: SLING-12154 URL: https://issues.apache.org/jira/browse/SLING-12154 Project: Sling Issue Type: Bug Components: Starter Affects Versions: Starter 12 Reporter: Dan Klco Assignee: Dan Klco Fix For: Starter 13 Attachments: image-2023-11-15-00-05-08-595.png Composum Nodes in the Sling Starter logs a 404 response and is unable to load the System Health due to the Composum Generic Request Proxy not being configured: !image-2023-11-15-00-05-08-595.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling Resource Resolver 1.11.4
+1 On Tue, Nov 14, 2023 at 1:48 PM Carsten Ziegeler wrote: > +1 > > Carsten > > On 14.11.2023 09:38, Jörg Hoh wrote: > > Hi, > > > > We solved 1 issue in this > > release: > https://issues.apache.org/jira/projects/SLING/versions/12353817=Text > > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2808/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > > sh check_staged_release.sh 2808 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours1 > > > > > > > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
Re: [VOTE] Release Apache Sling Engine 2.15.8
+1 Carsten On 14.11.2023 19:48, Carsten Ziegeler wrote: Hi, We solved 3 issues https://issues.apache.org/jira/browse/SLING-12152?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Engine%202.15.8%22 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2809/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2809 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [PR] Various improvements for the webconsole plugin [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-1811093184 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=78) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=78=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=78=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=78=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=CODE_SMELL) [![2.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '2.1%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_coverage=list) [2.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_duplicated_lines_density=list) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'sonarlint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11352 - Fix parsing of path-only mappings [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1811090786 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=84) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png '100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling Engine 2.15.8
Hi, We solved 3 issues https://issues.apache.org/jira/browse/SLING-12152?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Engine%202.15.8%22 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2809/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2809 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Resource Resolver 1.11.4
+1 Carsten On 14.11.2023 09:38, Jörg Hoh wrote: Hi, We solved 1 issue in this release:https://issues.apache.org/jira/projects/SLING/versions/12353817=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2808/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2808 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours1 -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Commented] (SLING-12152) IOException is not properly handled by error handling
[ https://issues.apache.org/jira/browse/SLING-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786027#comment-17786027 ] Carsten Ziegeler commented on SLING-12152: -- Handle FileNotFoundException as 404 : https://github.com/apache/sling-org-apache-sling-engine/commit/b48045687c47c4e0bbc72dec0705a3aa11dca997 > IOException is not properly handled by error handling > - > > Key: SLING-12152 > URL: https://issues.apache.org/jira/browse/SLING-12152 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.15.6 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.15.8 > > > When a servlet (or code called by a servlet) is throwing an IOException, this > is currently not passed to the error handler. Instead the processor is > passing it on to the main servlet, assuming it is handling the case. However, > the main servlet is just logging and therefore an IOException does not result > in an error response send to the client -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12152) IOException is not properly handled by error handling
[ https://issues.apache.org/jira/browse/SLING-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12152. -- Resolution: Fixed > IOException is not properly handled by error handling > - > > Key: SLING-12152 > URL: https://issues.apache.org/jira/browse/SLING-12152 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.15.6 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.15.8 > > > When a servlet (or code called by a servlet) is throwing an IOException, this > is currently not passed to the error handler. Instead the processor is > passing it on to the main servlet, assuming it is handling the case. However, > the main servlet is just logging and therefore an IOException does not result > in an error response send to the client -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12124) Inconsistent handling of empty selectors
[ https://issues.apache.org/jira/browse/SLING-12124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12124. -- Resolution: Fixed > Inconsistent handling of empty selectors > > > Key: SLING-12124 > URL: https://issues.apache.org/jira/browse/SLING-12124 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.15.6 >Reporter: Sagar Miglani >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.15.8 > > Attachments: inconsistent_empty_selectors.patch > > > In accordance with the code found > [here|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L563], > empty selectors are explicitly disallowed. However, the [parsing of > selectors|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/request/SlingRequestPathInfo.java#L93-L95] > is making request with all empty selector as valid. > i.e: > Requests will empty selectors like: "/test/resource/path..a...html" are > invalid > While requests with all empty selectos "/test/resource/path.html" are > valid > Which indicates an inconsistent behaviour. > Attached tests to demonstrate the same ([^inconsistent_empty_selectors.patch]) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling Resource Resolver 1.11.4
+1 Regards Julian On Tue, Nov 14, 2023 at 11:37 AM Stefan Seifert wrote: > > +1 > > stefan
Re: [VOTE] Release Apache Sling slingfeature maven plugin 1.8.0
+1 Regards Julian On Tue, Nov 14, 2023 at 8:21 AM Jörg Hoh wrote: > > +1 > > Am Mo., 13. Nov. 2023 um 10:41 Uhr schrieb Carsten Ziegeler < > cziege...@apache.org>: > > > Hi, > > > > We solved 6 issues in the feature model > > https://issues.apache.org/jira/projects/SLING/versions/12353832 > > > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2806/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2806 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh
[jira] [Commented] (SLING-12153) Update maven-archiver and maven-filtering
[ https://issues.apache.org/jira/browse/SLING-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785985#comment-17785985 ] Julian Sedding commented on SLING-12153: The dependency in question is {{org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M2a}}, which pulls in {{com.google.guava:guava:10.0.1}}. After updating both the {{maven-archiver}} and {{maven-filtering}} dependencies, the dependency to {{org.eclipse.sisu:org.eclipse.sisu.plexus}} becomes a test dependency and thus no longer appears in the transitive dependency graph. The exception stack trace was: {noformat} java.lang.NoSuchMethodError: 'com.google.common.cache.CacheBuilder com.google.common.cache.CacheBuilder.maximumSize(long)' at com.github.fge.jsonschema.core.load.SchemaLoader.(SchemaLoader.java:105) at com.github.fge.jsonschema.main.JsonSchemaFactory.(JsonSchemaFactory.java:138) at com.github.fge.jsonschema.main.JsonSchemaFactoryBuilder.freeze(JsonSchemaFactoryBuilder.java:139) at com.github.fge.jsonschema.main.JsonSchemaFactory.byDefault(JsonSchemaFactory.java:113) at org.apache.sling.feature.maven.Preprocessor.(Preprocessor.java:66) at org.apache.sling.feature.maven.mojos.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:79) at org.jetbrains.idea.maven.server.utils.Maven3XProjectResolver.loadExtensions(Maven3XProjectResolver.java:391) at org.jetbrains.idea.maven.server.utils.Maven3XProjectResolver.lambda$doResolveProject$2(Maven3XProjectResolver.java:153) at org.jetbrains.idea.maven.server.Maven3ServerEmbedder.executeWithSessionScope(Maven3ServerEmbedder.java:289) at org.jetbrains.idea.maven.server.Maven3ServerEmbedder.executeWithMavenSession(Maven3ServerEmbedder.java:232) at org.jetbrains.idea.maven.server.utils.Maven3XProjectResolver.doResolveProject(Maven3XProjectResolver.java:117) at org.jetbrains.idea.maven.server.utils.Maven3XProjectResolver.resolveProjects(Maven3XProjectResolver.java:88) at org.jetbrains.idea.maven.server.Maven3XServerEmbedder.resolveProjects(Maven3XServerEmbedder.java:528) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360) at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200) at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197) at java.base/java.security.AccessController.doPrivileged(AccessController.java:712) at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196) at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:587) at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:828) at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:705) at java.base/java.security.AccessController.doPrivileged(AccessController.java:399) at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:704) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:833) {noformat} The problem is a signature change from {{CacheBuilder#maximumSize(int)}} to {{CacheBuilder#maximumSize(long)}} somewhere between guava 10.0.1 and more modern versions. > Update maven-archiver and maven-filtering > - > > Key: SLING-12153 > URL: https://issues.apache.org/jira/browse/SLING-12153 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Minor > Fix For: OSGi Feature Maven Plugin 1.8.2 > > > [~jsedding] noticed that the plug-in brings in older versions of the > maven-archiver and maven-filtering. Those dependencies > {quote}drag an ancient guava version into the classpath via a transitive > dependency that was moved into "test" scope in newer versions of these two > libraries{quote} > This causes various problems with IntelliJ and Eclipse integration. And > upgrading dependencies is always a good idea :-) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12153 - Update maven-archiver and maven-filtering [sling-slingfeature-maven-plugin]
sonarcloud[bot] commented on PR #81: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/81#issuecomment-1810713081 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-slingfeature-maven-plugin=81) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=81=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=81=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=81=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=81=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=81=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=81=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=81=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=81=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=81=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=81=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=81=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=81=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=81=coverage=list) No Coverage information [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=81=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=81=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12153) Update maven-archiver and maven-filtering
Robert Munteanu created SLING-12153: --- Summary: Update maven-archiver and maven-filtering Key: SLING-12153 URL: https://issues.apache.org/jira/browse/SLING-12153 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: OSGi Feature Maven Plugin 1.8.2 [~jsedding] noticed that the plug-in brings in older versions of the maven-archiver and maven-filtering. Those dependencies {quote}drag an ancient guava version into the classpath via a transitive dependency that was moved into "test" scope in newer versions of these two libraries{quote} This causes various problems with IntelliJ and Eclipse integration. And upgrading dependencies is always a good idea :-) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] chore(deps): update dependency org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle to v1.3.7 [sling-org-apache-sling-starter]
rombert merged PR #274: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12144 - Bump non-sling dependencies to latest in org.apache.sling.testing.sling-mock [sling-org-apache-sling-testing-sling-mock]
rmcdouga commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/31#issuecomment-1810370859 > in general i'm completely on your side, but if you are e.g. stuck in an older AEM 6.5 project, you are bound to work with a certain set of outdated 3rdparty dependencies - but still may want to use the latest features provided by [sling-mock](https://issues.apache.org/jira/browse/SLING-mock). Ironically, I had the opposite problem. I'm using the latest version of AEM and I am using the latest aem-mock but was stuck with the old dependencies (thanks to old dependencies in sling-testing-hamcrest). You can't please everyone. Since you can't please everyone, personally, I would aim to please the people who stay current. This makes their life easier and it puts additional pressure on the laggards to upgrade more regularly if they want the latest features (which is the "right thing to do", so while they may not like it, it's in their best interest and if they do it more regularly it will become easier). > normally we prefer separate JIRA issues for separate topics and PRs, but in this case it's fine to link them to the already existing ticket as they are all related to dependency updates. OK, will do. Thanks for reviewing this and for the detailed comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle to v1.3.7 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #274: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/274 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle](https://www.apache.org/spifly/org.apache.aries.spifly.dynamic.bundle/) ([source](https://gitbox.apache.org/repos/asf?p=aries.git;a=summary)) | `1.3.6` -> `1.3.7` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle/1.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle/1.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle/1.3.6/1.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle/1.3.6/1.3.7?slim=true)](https:// docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12144 - Bump non-sling dependencies to latest in org.apache.sling.testing.sling-mock [sling-org-apache-sling-testing-sling-mock]
stefanseifert commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/31#issuecomment-1810204110 > I'm not sure I agree with the idea of using older dependency versions for compatibility with older downstream product versions. Older versions of [sling-mock](https://issues.apache.org/jira/browse/SLING-mock) are still available for projects targeting these older product versions. I'm used to (and am comfortable with) projects like Spring that move to the latest versions of dependencies pretty aggressively. It encourages the whole ecosystem to continuously upgrade their dependencies. Upgrading dependencies is like exercise - the more frequently you do it, the easier it gets. in general i'm completely on your side, but if you are e.g. stuck in an older AEM 6.5 project, you are bound to work with a certain set of outdated 3rdparty dependencies - but still may want to use the latest features provided by sling-mock. > One more thing - How would you like to handle the JIRA issues? Should I raise separate issues for each PR or can I continue to use the same JIRA issue for all PRs? normally we prefer separate JIRA issues for separate topics and PRs, but in this case it's fine to link them to the already existing ticket as they are all related to dependency updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[CANCELLED] Release Apache Sling Content Distribution Journal Messages 0.5.8
Hi, Thanks everyone for your votes and comments ! The release has been canceled following a veto. We'll move the interface at a lower level in the stack. I have already completed the steps documented in [0]. Next Content Distribution Journal Messages release tracked at : https://issues.apache.org/jira/projects/SLING/versions/12353859 Regards, Timothee [0] https://sling.apache.org/documentation/development/release-management.html#canceling-the-release-1
Re: [PR] SLING-12144 - Bump non-sling dependencies to latest in org.apache.sling.testing.sling-mock [sling-org-apache-sling-testing-sling-mock]
rmcdouga commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/31#issuecomment-1810126968 OK, I will split up the changes into multiple PRs as requested. I'm not sure I agree with the idea of using older dependency versions for compatibility with older downstream product versions. Older versions of sling-mock are still available for projects targeting these older product versions. I'm used to (and am comfortable with) projects like Spring that move to the latest versions of dependencies pretty aggressively. It encourages the whole ecosystem to continuously upgrade their dependencies. Upgrading dependencies is like exercise - the more frequently you do it, the easier it gets. Having said that, the dependencies we're talking about are only a couple of point releases old, so that's pretty current. I don't feel too bad about leaving them alone. I will split into a PR for testing dependencies in this project, one for commons-lang (but to version 3.9), and will have a look at the other projects you mention and I'll raise PRs in those projects for the testing dependencies. If that plan is acceptable, then feel free to close this PR. One more thing - How would you like to handle the JIRA issues? Should I raise separate issues for each PR or can I continue to use the same JIRA issue for all PRs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12132) Add package message metadata provider SPI
[ https://issues.apache.org/jira/browse/SLING-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785872#comment-17785872 ] Timothee Maret commented on SLING-12132: The proposed change is not part of any release. > Add package message metadata provider SPI > - > > Key: SLING-12132 > URL: https://issues.apache.org/jira/browse/SLING-12132 > Project: Sling > Issue Type: Task > Components: Content Distribution >Reporter: José Correia >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Messages 0.5.8 > > > We want to add additional metadata to the PackageMessage objects created > during content distribution and that are sent through the Message Provider. > > In order to do this, the distribution journal codebase should provide a > Service Provider Interface that allows for implementing logic that adds > specific metadata for different use-cases. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12132) Add package message metadata provider SPI
[ https://issues.apache.org/jira/browse/SLING-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret resolved SLING-12132. Resolution: Abandoned Abandoned for a SPI at the messaging level. > Add package message metadata provider SPI > - > > Key: SLING-12132 > URL: https://issues.apache.org/jira/browse/SLING-12132 > Project: Sling > Issue Type: Task > Components: Content Distribution >Reporter: José Correia >Assignee: Timothee Maret >Priority: Major > > We want to add additional metadata to the PackageMessage objects created > during content distribution and that are sent through the Message Provider. > > In order to do this, the distribution journal codebase should provide a > Service Provider Interface that allows for implementing logic that adds > specific metadata for different use-cases. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (SLING-12132) Add package message metadata provider SPI
[ https://issues.apache.org/jira/browse/SLING-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reopened SLING-12132: Reopening following the vote veto in 0.5.8 > Add package message metadata provider SPI > - > > Key: SLING-12132 > URL: https://issues.apache.org/jira/browse/SLING-12132 > Project: Sling > Issue Type: Task > Components: Content Distribution >Reporter: José Correia >Assignee: José Correia >Priority: Major > Fix For: Content Distribution Journal Messages 0.5.8 > > > We want to add additional metadata to the PackageMessage objects created > during content distribution and that are sent through the Message Provider. > > In order to do this, the distribution journal codebase should provide a > Service Provider Interface that allows for implementing logic that adds > specific metadata for different use-cases. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12132) Add package message metadata provider SPI
[ https://issues.apache.org/jira/browse/SLING-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reassigned SLING-12132: -- Assignee: Timothee Maret (was: José Correia) > Add package message metadata provider SPI > - > > Key: SLING-12132 > URL: https://issues.apache.org/jira/browse/SLING-12132 > Project: Sling > Issue Type: Task > Components: Content Distribution >Reporter: José Correia >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Messages 0.5.8 > > > We want to add additional metadata to the PackageMessage objects created > during content distribution and that are sent through the Message Provider. > > In order to do this, the distribution journal codebase should provide a > Service Provider Interface that allows for implementing logic that adds > specific metadata for different use-cases. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12144 - Bump non-sling dependencies to latest in org.apache.sling.testing.sling-mock [sling-org-apache-sling-testing-sling-mock]
stefanseifert commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/31#issuecomment-1809987488 thanks for this PR! some comments: * updating the testing dependencies junit and and mockito is an non-brainer and should be done immediately * however, we should keep those testing deps in all the mocks and we should update it also in osgi-mock, jcr-mock, resourceresolver-mock - but this is separate form this PR * it's also a good thing that we can finally get rid of commons-lang 2 (it was still there because former dependencies required it, but it's no longer the case) * for updating the other dependencies it's always a balancing act: sling-mock is used in a lot of projects, and most of them do not have the luxury to always use the latest dependencies from everything. in fact, it's used a lot in downstream products as AEM and i try to keep compatibility for the versions still in use. in those cases, the dependencies that are actually used in the test run are not determined by the POM here, but but the dependencies defined in the project and target environment, e.g. using the ways described here: https://wcm.io/testing/aem-mock/usage-maven-dependencies.html * so in sling-mock, i usually keep the dependencies older and only update in a bunch every 1-2 years with a focus on maximum compatibility (last time in [SLING-11295](https://issues.apache.org/jira/browse/SLING-11295)). * if we update those 3rparty deps (or sling deps) too early, we risk that new features are used in the code of sling-mock itself, and that breaks the tests if used in older environment's projects best thing would be to split up this PR in one only affecting the testing dependencies, probably one for removing commons-lang 2. i'm not sure if there is benefit in updating the other 3rdparty dependencies currently (commons-lang3 is used in version 3.9 as inherited form osgi-mock). i also keep those 3dparty deps in sync across all mocks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-12144) Bump non-sling dependencies to latest in org.apache.sling.testing.sling-mock
[ https://issues.apache.org/jira/browse/SLING-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned SLING-12144: -- Component/s: Testing Fix Version/s: Testing Sling Mock 3.4.16 Assignee: Stefan Seifert > Bump non-sling dependencies to latest in org.apache.sling.testing.sling-mock > > > Key: SLING-12144 > URL: https://issues.apache.org/jira/browse/SLING-12144 > Project: Sling > Issue Type: Task > Components: Testing >Reporter: Rob McDougall >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing Sling Mock 3.4.16 > > > Bump dependencies: > Mockito: 4.7.0 -> 5.7.0 > commons-lang 2.6 -> commons-lang3 3.13.0 > commons-io 2.11.0 -> 2.13.0 > commons-collectios4 4.2 -> 4.4 > JUnit5 5.2.0 -> 5.10.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
RE: [VOTE] Release Apache Sling Resource Resolver 1.11.4
+1 stefan
Re: [PR] chore(deps): update dependency org.apache.sling:slingfeature-maven-plugin to v1.7.4 [sling-org-apache-sling-starter]
rombert merged PR #271: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.resourceresolver to v1.11.2 [sling-org-apache-sling-starter]
forking-renovate[bot] commented on PR #272: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/272#issuecomment-1809868910 ### Renovate Ignore Notification Because you closed this PR without merging, Renovate will ignore this update (`1.11.2`). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the `ignoreDeps` array of your Renovate config. If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.resourceresolver to v1.11.2 [sling-org-apache-sling-starter]
rombert commented on PR #272: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/272#issuecomment-1809868535 Will wait for the follow-up 1.11.4 release - https://lists.apache.org/thread/f8c4x9r0o0fg54rm1q0mf1wmcm715s01 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.resourceresolver to v1.11.2 [sling-org-apache-sling-starter]
rombert closed pull request #272: chore(deps): update dependency org.apache.sling:org.apache.sling.resourceresolver to v1.11.2 URL: https://github.com/apache/sling-org-apache-sling-starter/pull/272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.xss to v2.4.0 [sling-org-apache-sling-starter]
rombert merged PR #273: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Resource Resolver 1.11.4
FWIW, the correct changelog link is https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Resource%20Resolver%201.11.4%22 On Tue, 2023-11-14 at 09:38 +0100, Jörg Hoh wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling Resource Resolver 1.11.4
My +1 Am Di., 14. Nov. 2023 um 09:38 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/projects/SLING/versions/12353817=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2808/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2808 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours1 > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[VOTE] Release Apache Sling Resource Resolver 1.11.4
Hi, We solved 1 issue in this release:https://issues.apache.org/jira/projects/SLING/versions/12353817=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2808/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2808 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours1 -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[jira] [Updated] (SLING-11513) Allow impersonating an user when checking the result of a map/resolve call
[ https://issues.apache.org/jira/browse/SLING-11513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11513: -- Fix Version/s: Resource Resolver 1.11.6 (was: Resource Resolver 1.11.4) > Allow impersonating an user when checking the result of a map/resolve call > -- > > Key: SLING-11513 > URL: https://issues.apache.org/jira/browse/SLING-11513 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Resource Resolver 1.11.6 > > Attachments: screenshot-1.png > > > When debugging various resolve/map issues ( e.g. SLING-10844 ) it is useful > to be able to impersonate a user that does not have access to the web console. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11511) Allow checking the map/resolve result for an empty path
[ https://issues.apache.org/jira/browse/SLING-11511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11511: -- Fix Version/s: Resource Resolver 1.11.6 (was: Resource Resolver 1.11.4) > Allow checking the map/resolve result for an empty path > --- > > Key: SLING-11511 > URL: https://issues.apache.org/jira/browse/SLING-11511 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Resource Resolver 1.11.6 > > > The resource resolver API supports mapping/resolving empty paths, although > this is an invalid path. > The web console plug-in should support this as well, to better support > debugging for scenarios like SLING-10844 . -- This message was sent by Atlassian Jira (v8.20.10#820010)