Re: [PR] SLING-11917 Evaluate constructor parameter names via reflection [sling-org-apache-sling-models-impl]
henrykuijpers commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/45#issuecomment-1817419374 Wouldn't that be as simple as adding another compile step in the project, for a separate source folder, that will have a sling model available to test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12164) Metadata Extraction Broken
[ https://issues.apache.org/jira/browse/SLING-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12164. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/6eb6abb410baebe1fd9e1efecde6c03d3fea1554 > Metadata Extraction Broken > -- > > Key: SLING-12164 > URL: https://issues.apache.org/jira/browse/SLING-12164 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.8 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.10 > > > SLING-12120 introduced a regression where the metadata extraction broke due > to both the tika-parsers and tika-bundle being present in the feature model. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12164) Metadata Extraction Broken
Dan Klco created SLING-12164: Summary: Metadata Extraction Broken Key: SLING-12164 URL: https://issues.apache.org/jira/browse/SLING-12164 Project: Sling Issue Type: Bug Components: App CMS Affects Versions: App CMS 1.1.8 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.1.10 SLING-12120 introduced a regression where the metadata extraction broke due to both the tika-parsers and tika-bundle being present in the feature model. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11917 Evaluate constructor parameter names via reflection [sling-org-apache-sling-models-impl]
sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/45#issuecomment-1817100109 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl=45) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=45=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=45=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=45=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=45=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=45=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=45=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=45=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=45=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=45=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=45=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=45=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=45=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=45=new_coverage=list) [93.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=45=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=45=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=45=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Sling Johnzon Wrapper & Jakarta JSON
Is the johnzon 2.x implementation better than the parsson library that we are already including in the starter? I've just been switching the geronimo-json_1.0_spec and johnzon-core dependencies to these: jakarta.json jakarta.json-api 2.1.1 provided org.eclipse.parsson parsson 1.1.1 test Regards, -Eric On Fri, Nov 17, 2023 at 3:03 AM Stefan Seifert wrote: > in context of SLING-12058 we are migrating lots of modules from javax.json > to jakarta.json. this works fine for modules using javax.json directly. > > however, we have a few modules which are using johnzon, which uses > javax.json internally. since version johnzon 1.2.5 (we are using johnzon > 1.2.21 in latest wrapper bundle) johnzon ships an additional artifact with > classifier "jakarta", which uses jakarta.json internally. both artifacts > with and without "jakarta" are identical, except the internal usage of the > package name. our wrapper bundle contains the version using javax.json. > > for non-bundles like maven plugins we can just switch to the artifact with > "jakarta". but this will not work for our bundles. we cannot ship both > artifacts with and without "jakarta" classifier as wrapper bundles and > export them both in OSGi with the same version number. i've found at least > one bundle where this is already used (but not released) [1]. it stumbled > about this in PR [2]. the bundles might work anyway as the bundle compiled > against the johnzon "jakarta" affect should also work with the javax.json > version at runtime, but this feels like a slippery slope. > > according to [3] johnzon is using a different way starting from version > 2.0 (which seems to be released a few days ago, although the homepage is > not updated yet): in version 2.0 johnzon uses only jakarta.json. > > so it think the correct way is to create and deploy an additional wrapper > bundle for johnzon 2.0, which we can deploy side-by-side with the old > wrapper bundle with 1.x. i assume we have to support both of them for quite > a time, as there is a lot of code out there using johnzon 1.x. > > WDYT? > > stefan > > [1] > https://github.com/apache/sling-org-apache-sling-installer-factory-feature/blob/867bd44f0991cedd130314d833c9aac29ae3f36c/pom.xml#L134-L140 > [2] https://github.com/apache/sling-org-apache-sling-fsresource/pull/2 > [3] https://johnzon.apache.org/download.html >
Re: [VOTE] Release Apache Sling Testing OSGi Mock 3.4.0
+1 On Fri, Nov 17, 2023 at 10:57 AM Jörg Hoh wrote: > +1 > > Am Fr., 17. Nov. 2023 um 10:06 Uhr schrieb Stefan Seifert > : > > > Hi, > > > > We solved 5 issues in this release: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353545=Text=12310710 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2810/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 2810 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > stefan > > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh >
Re: [PR] SLING-12160 Prevent ConcurrentModificationException in [sling-org-apache-sling-resourceresolver]
kwin commented on PR #107: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/107#issuecomment-1816772549 @joerghoh Any idea if the test failures are related? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12163 Update ASF Parent to v31 [sling-parent]
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-parent/pull/39#issuecomment-1816746022 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-parent=39) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=39=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=39=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=39=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-parent=39) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-parent=39=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-parent=39=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12163 Update ASF Parent to v31 [sling-parent]
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-parent/pull/39#issuecomment-1816741865 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-parent=39) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=39=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=39=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=39=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-parent=39=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-parent=39) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-parent=39=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-parent=39=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11842 Drop Java 8 as build JDK [sling-parent]
sonarcloud[bot] commented on PR #38: URL: https://github.com/apache/sling-parent/pull/38#issuecomment-1816740565 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-parent=38) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=38=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=38=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=38=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-parent=38) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-parent=38=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-parent=38=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11842 Drop Java 8 as build JDK [sling-parent]
sonarcloud[bot] commented on PR #38: URL: https://github.com/apache/sling-parent/pull/38#issuecomment-1816736209 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-parent=38) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=38=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=38=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=38=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-parent=38=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-parent=38) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-parent=38=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-parent=38=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12163 Update ASF Parent to v31 [sling-parent]
kwin opened a new pull request, #39: URL: https://github.com/apache/sling-parent/pull/39 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12163) Update ASF Parent to 31
Konrad Windszus created SLING-12163: --- Summary: Update ASF Parent to 31 Key: SLING-12163 URL: https://issues.apache.org/jira/browse/SLING-12163 Project: Sling Issue Type: Improvement Components: General Reporter: Konrad Windszus Assignee: Konrad Windszus Fix For: Parent 60 (Java 11) https://github.com/apache/maven-apache-parent/releases/tag/apache-31 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12080) Update to Bnd 7.0 and require at least Java 17 for build
[ https://issues.apache.org/jira/browse/SLING-12080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-12080. - Resolution: Fixed Fixed in https://github.com/apache/sling-parent/commit/4ab420b0ceadb057358fe1e957a93ba86b04c6f8. > Update to Bnd 7.0 and require at least Java 17 for build > > > Key: SLING-12080 > URL: https://issues.apache.org/jira/browse/SLING-12080 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Bundle Parent 60 (Java 17) > > > Bnd 7.0 (https://github.com/bndtools/bnd/wiki/Changes-in-7.0.0) is out and > requires Java 17 for build. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11842) Drop Java 8 support from Parent
[ https://issues.apache.org/jira/browse/SLING-11842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11842: --- Assignee: Konrad Windszus > Drop Java 8 support from Parent > --- > > Key: SLING-11842 > URL: https://issues.apache.org/jira/browse/SLING-11842 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 60 (Java 11) > > > Given that Java 8 is EOL since quite some time, and soon Java 21 will be the > default LTS release we should drop support for Java 8 (that allows to get rid > of some profiles and plugins like > https://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12080 Update to Bnd 7.0.0 [sling-parent]
kwin merged PR #37: URL: https://github.com/apache/sling-parent/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12080 Update to Bnd 7.0.0 [sling-parent]
sonarcloud[bot] commented on PR #37: URL: https://github.com/apache/sling-parent/pull/37#issuecomment-1816721935 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-parent=37) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=37=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=37=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-parent=37=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=37=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=37=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-parent=37=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=37=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=37=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent=37=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=37=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-parent=37=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-parent=37=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-parent=37) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-parent=37=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-parent=37=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SLING-12149) ResourceResolver: Illegal mode passthrough for resource provider null
[
https://issues.apache.org/jira/browse/SLING-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-12149.
-
> ResourceResolver: Illegal mode passthrough for resource provider null
> -
>
> Key: SLING-12149
> URL: https://issues.apache.org/jira/browse/SLING-12149
> Project: Sling
> Issue Type: Task
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.11.2
>Reporter: Joerg Hoh
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Resource Resolver 1.11.4
>
>
> When trying the new ResourcResolver 1.11.2 I get this log message for
> many/all ResourceProvider and the instance does not work:
> {noformat}
> 13.11.2023 15:41:18.003 *ERROR* [FelixStartLevel]
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderInfo Illegal
> mode passthrough for resource provider null
> 13.11.2023 15:41:18.005 *WARN* [FelixStartLevel]
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker
> Ignoring invalid resource provider ResourceProviderInfo
> [ref=[org.apache.sling.spi.resource.provider.ResourceProvider], path=/apps/,
> useResourceAccessSecurity=false, authType=no, modifiable=false]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[RESULT][VOTE] Release Apache Sling Resource Resolver 1.11.4
Hi, The vote has passed with the following result : +1 (binding): Jörg Hoh, Robert Munteanu, Stefan Seifert, Julian Sedding, Carsten Ziegeler, Daniel Klco I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Am Di., 14. Nov. 2023 um 09:38 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/projects/SLING/versions/12353817=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2808/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2808 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours1 > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Testing OSGi Mock 3.4.0
+1 Am Fr., 17. Nov. 2023 um 10:06 Uhr schrieb Stefan Seifert : > Hi, > > We solved 5 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353545=Text=12310710 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2810/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2810 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[PR] SLING-12161: sling-org-apache-sling-testing-sling-mock: update to latest Oak releases [sling-org-apache-sling-testing-sling-mock]
reschke opened a new pull request, #34: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/34 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-12161) sling-org-apache-sling-testing-sling-mock: update to latest Oak releases
[ https://issues.apache.org/jira/browse/SLING-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned SLING-12161: -- Assignee: Julian Reschke > sling-org-apache-sling-testing-sling-mock: update to latest Oak releases > > > Key: SLING-12161 > URL: https://issues.apache.org/jira/browse/SLING-12161 > Project: Sling > Issue Type: Task > Components: Testing >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > > sling-org-apache-sling-testing-sling-mock currently uses Oak 1.22.5; it > should use the current maintenance release 1.22.17. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12161) sling-org-apache-sling-testing-sling-mock: update to latest Oak releases
[ https://issues.apache.org/jira/browse/SLING-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated SLING-12161: --- Summary: sling-org-apache-sling-testing-sling-mock: update to latest Oak releases (was: sling-org-apache-sling-testing-sling-mock: update to latest Oak maintenance release 1.22.17) > sling-org-apache-sling-testing-sling-mock: update to latest Oak releases > > > Key: SLING-12161 > URL: https://issues.apache.org/jira/browse/SLING-12161 > Project: Sling > Issue Type: Task > Components: Testing >Reporter: Julian Reschke >Priority: Major > > sling-org-apache-sling-testing-sling-mock currently uses Oak 1.22.5; it > should use the current maintenance release 1.22.17. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] SLING-12162 - Update o.a.s.junit.core to jupiter 5.10.1 [sling-org-apache-sling-junit-core]
jsedding opened a new pull request, #21: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/21 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12162) Update o.a.s.junit.core to jupiter 5.10.1
Julian Sedding created SLING-12162: -- Summary: Update o.a.s.junit.core to jupiter 5.10.1 Key: SLING-12162 URL: https://issues.apache.org/jira/browse/SLING-12162 Project: Sling Issue Type: Task Components: JUnit Core Affects Versions: JUnit Core 1.1.6 Reporter: Julian Sedding Assignee: Julian Sedding In the context of [PR #20|https://github.com/apache/sling-org-apache-sling-junit-core/pull/20], it turned out that a change between jupiter 5.10.0 and 5.10.1 brakes a test case. I have identified the [relevant change|https://github.com/junit-team/junit5/pull/3500/files#diff-eec44cb3c2bd65dc0944562c5b919097b7995cbbd874f3ff6f9cd1dd170a2814R1506-L1510] to be stricter enforcement of a test method predicate. It turns out that we have a meta-test (we're running tests within tests for o.a.s.junit.core) that overrides and inherited test method, but does not itself add the `@Test` annotation on it. That way the test method in question is not found, which fails an assertion that checks if any meta-tests were run. cc [~apelluru] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12071: upgrade to sling parent 52 [sling-org-apache-sling-fsresource]
stefanseifert commented on code in PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-fsresource/pull/2#discussion_r1397426714
##
.sling-module.json:
##
@@ -0,0 +1,6 @@
+{
Review Comment:
i was able to build it locally on my windows 11 machine without problems -
did not had time to dig deeper into the jenkins logs yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump junit from 4.8.2 to 4.13.1 [sling-org-apache-sling-junit-remote]
dependabot[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-junit-remote/pull/1#issuecomment-1816550629 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junit from 4.8.2 to 4.13.1 [sling-org-apache-sling-junit-remote]
apelluru closed pull request #1: Bump junit from 4.8.2 to 4.13.1 URL: https://github.com/apache/sling-org-apache-sling-junit-remote/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junit from 4.8.2 to 4.13.1 [sling-org-apache-sling-junit-remote]
apelluru commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-junit-remote/pull/1#issuecomment-1816550561 No longer required since `4.13.2` is already using. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12068) Migrate junit.remote to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru resolved SLING-12068. --- Resolution: Fixed > Migrate junit.remote to jakarta.json > > > Key: SLING-12068 > URL: https://issues.apache.org/jira/browse/SLING-12068 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12068: migrate to jakarta.json [sling-org-apache-sling-junit-remote]
apelluru merged PR #2: URL: https://github.com/apache/sling-org-apache-sling-junit-remote/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12161) sling-org-apache-sling-testing-sling-mock: update to latest Oak maintenance release 1.22.17
Julian Reschke created SLING-12161: -- Summary: sling-org-apache-sling-testing-sling-mock: update to latest Oak maintenance release 1.22.17 Key: SLING-12161 URL: https://issues.apache.org/jira/browse/SLING-12161 Project: Sling Issue Type: Task Components: Testing Reporter: Julian Reschke sling-org-apache-sling-testing-sling-mock currently uses Oak 1.22.5; it should use the current maintenance release 1.22.17. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12071: upgrade to sling parent 52 [sling-org-apache-sling-fsresource]
apelluru commented on code in PR #2: URL: https://github.com/apache/sling-org-apache-sling-fsresource/pull/2#discussion_r1397402517 ## pom.xml: ## @@ -199,7 +199,8 @@ org.apache.johnzon johnzon-core -1.1.1 +jakarta Review Comment: Thanks for moving the discussion into mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12071: upgrade to sling parent 52 [sling-org-apache-sling-fsresource]
apelluru commented on code in PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-fsresource/pull/2#discussion_r1397401791
##
.sling-module.json:
##
@@ -0,0 +1,6 @@
+{
Review Comment:
@stefanseifert Sure, temporarily disabled Windows builds because one of the
test cases is failing. Unfortunately, addressing the issue is proving to be a
bit challenging with MacBook. However, I'm exploring the possibility of using
Windows Docker instances to see if I can tackle the problem from that angle.
Do you have or anyone has suggestions or alternative approaches might help
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (SLING-12124) Inconsistent handling of empty selectors
[ https://issues.apache.org/jira/browse/SLING-12124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12124. > Inconsistent handling of empty selectors > > > Key: SLING-12124 > URL: https://issues.apache.org/jira/browse/SLING-12124 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.15.6 >Reporter: Sagar Miglani >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.15.8 > > Attachments: inconsistent_empty_selectors.patch > > > In accordance with the code found > [here|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L563], > empty selectors are explicitly disallowed. However, the [parsing of > selectors|https://github.com/apache/sling-org-apache-sling-engine/blob/master/src/main/java/org/apache/sling/engine/impl/request/SlingRequestPathInfo.java#L93-L95] > is making request with all empty selector as valid. > i.e: > Requests will empty selectors like: "/test/resource/path..a...html" are > invalid > While requests with all empty selectos "/test/resource/path.html" are > valid > Which indicates an inconsistent behaviour. > Attached tests to demonstrate the same ([^inconsistent_empty_selectors.patch]) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12152) IOException is not properly handled by error handling
[ https://issues.apache.org/jira/browse/SLING-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12152. > IOException is not properly handled by error handling > - > > Key: SLING-12152 > URL: https://issues.apache.org/jira/browse/SLING-12152 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.15.6 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.15.8 > > > When a servlet (or code called by a servlet) is throwing an IOException, this > is currently not passed to the error handler. Instead the processor is > passing it on to the main servlet, assuming it is handling the case. However, > the main servlet is just logging and therefore an IOException does not result > in an error response send to the client -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12133) Include time spend in authentication in request log
[ https://issues.apache.org/jira/browse/SLING-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12133. > Include time spend in authentication in request log > --- > > Key: SLING-12133 > URL: https://issues.apache.org/jira/browse/SLING-12133 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.15.8 > > > The request logging is currently triggered by a servlet filter. Filters run > after authentication and therefore the time spent in authentication is not > included. In addition time spent in anything before authentication (like > preprocessors) is not included either. > We should change RequestLoggerFilter from a filter to an early running > Preprocessor. However,currently the RequestLoggerFilter has two purposes - > one is the logging and the other one is preparing request and response > objects. We need to split that functionality and keep it in the filter - > Preprocessors run for every http context, not just Sling so we need to avoid > that this code runs outside of Sling's context. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE RESULT] Release Apache Sling Engine 2.15.8
The vote passed with five binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [PR] SLING-12107 - JCR Repoinit executes operations out of order [sling-site]
jsedding merged PR #143: URL: https://github.com/apache/sling-site/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SLING-12115) Repoinit should leave importBehaviour for ACL creation to JCR
[
https://issues.apache.org/jira/browse/SLING-12115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-12115.
--
> Repoinit should leave importBehaviour for ACL creation to JCR
> -
>
> Key: SLING-12115
> URL: https://issues.apache.org/jira/browse/SLING-12115
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.44
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Major
> Fix For: Repoinit JCR 1.1.46
>
>
> JCR Repoinit checks the existence of the principal, for which ACLs should be
> created. In an Oak repository, this check depends on the {{ImportBehaviour}}
> configured for the {{SecurityProvider}}. JCR Repoinit should not check, but
> instead rely on the repository's behaviour.
> cc [~angela]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12107) JCR Repoinit executes operations out of order
[
https://issues.apache.org/jira/browse/SLING-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding closed SLING-12107.
--
> JCR Repoinit executes operations out of order
> -
>
> Key: SLING-12107
> URL: https://issues.apache.org/jira/browse/SLING-12107
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.44
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Major
> Fix For: Repoinit JCR 1.1.46
>
>
> When applying ACLs, repoinit checks if the referenced authorizable exists,
> and it fails if it doesn't.
> However, my goal was to set up ACLs with my deployment for a group that was
> to be sync'ed from an {{ExternalIdentityProvider}} once the first member of
> that group logs in.
> To work around this limitation, I tried running the following repoinit script:
> {noformat}
> create group testGroup
> set ACL for testGroup
> allow jcr:read on /content/foo
> deny jcr:write on /content/foo
> end
> delete group testGroup
> {noformat}
> It turned out that the statements were executed in the following order:
> {noformat}
> create group testGroup
> delete group testGroup
> set ACL for testGroup
> allow jcr:read on /content/foo
> deny jcr:write on /content/foo
> end
> {noformat}
> Of course that caused the script to fail just as if no group was created.
> The incorrect ordering may also cause other scenarios to fail.
> The {{ExecutionOrderTest}} suggests that some re-ordering is done on purpose.
> E.g. namespaces and nodetypes should be created before e.g. paths are created.
> I would expect that registration of custom privileges should also be executed
> before other operations. I don't see how that could be harmful.
> But for all other statements, I would expect the execution order to match the
> order of the statements within the repoinit script.
> cc [~bdelacretaz], [~cziegeler], [~angela]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12114) Update org.apache.sling.jcr.repoinit to parent pom 52
[ https://issues.apache.org/jira/browse/SLING-12114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed SLING-12114. -- > Update org.apache.sling.jcr.repoinit to parent pom 52 > - > > Key: SLING-12114 > URL: https://issues.apache.org/jira/browse/SLING-12114 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.44 >Reporter: Julian Sedding >Assignee: Julian Sedding >Priority: Minor > Fix For: Repoinit JCR 1.1.46 > > > Update to parent pom version 52, update used and remove unnecessary > dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12122) Add unit-test creating group with rep:externalId property
[
https://issues.apache.org/jira/browse/SLING-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-12122:
---
Fix Version/s: Repoinit JCR 1.1.48
(was: Repoinit JCR 1.1.46)
> Add unit-test creating group with rep:externalId property
> -
>
> Key: SLING-12122
> URL: https://issues.apache.org/jira/browse/SLING-12122
> Project: Sling
> Issue Type: Test
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.44
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Minor
> Fix For: Repoinit JCR 1.1.48
>
>
> Add a unit-test validating that repoinit can successfully create a new group
> with the {{rep:externalId}} property, that can only be set on creation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11621) Outdated JCR dependencies
[
https://issues.apache.org/jira/browse/SLING-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-11621:
---
Fix Version/s: Repoinit JCR 1.1.48
(was: Repoinit JCR 1.1.46)
> Outdated JCR dependencies
> -
>
> Key: SLING-11621
> URL: https://issues.apache.org/jira/browse/SLING-11621
> Project: Sling
> Issue Type: Task
> Components: Repoinit
>Reporter: Julian Reschke
>Priority: Major
> Fix For: Repoinit JCR 1.1.48
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/9913b787574186a7a31d184480cec3862816438f/pom.xml#L39:
> {noformat}
> 2.18.2
> 1.22.1
> {noformat}
> Jackrabbit 2.18 has been EOLd quite some time ago...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12158) Log affected Sling Model class for messages emitted from AbstractInjectableElement
[ https://issues.apache.org/jira/browse/SLING-12158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-12158. - Fix Version/s: Models Implementation 1.6.6 Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-models-impl/commit/cf088713c402177b9d96a5229567804510ef9918. > Log affected Sling Model class for messages emitted from > AbstractInjectableElement > -- > > Key: SLING-12158 > URL: https://issues.apache.org/jira/browse/SLING-12158 > Project: Sling > Issue Type: Improvement > Components: Sling Models >Affects Versions: Models Implementation 1.6.4 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Models Implementation 1.6.6 > > > Both > https://github.com/apache/sling-org-apache-sling-models-impl/blob/b0647a3419924c46e58b78aa6384e0f49491a0c6/src/main/java/org/apache/sling/models/impl/model/AbstractInjectableElement.java > and classes derived from it emit some log messages. Those log message miss > the context of the Sling Model class where that happens. > This is e.g. the case in > https://github.com/apache/sling-org-apache-sling-models-impl/blob/b701d76cd02fcbcbb5a9470400bdf3afc803cf2c/src/main/java/org/apache/sling/models/impl/model/AbstractInjectableElement.java#L182 > where only the type but neither the name nor the container model class is > emitted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12158 improve logging in InjectableElements [sling-org-apache-sling-models-impl]
kwin merged PR #47: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[RESULT] [VOTE] Release Apache Sling Repoinit JCR 1.1.46
Hi, The vote has passed with the following result: +1 (binding): Stefan Seifert, Carsten Ziegeler, Dan Klco, Joerg Hoh, Julian Sedding +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards Julian On Fri, Nov 17, 2023 at 11:44 AM Julian Sedding wrote: > > +1 > > Regards > Julian > > On Tue, Nov 14, 2023 at 8:22 AM Jörg Hoh > wrote: > > > > +1 > > > > Am Mo., 13. Nov. 2023 um 13:25 Uhr schrieb Julian Sedding < > > jsedd...@gmail.com>: > > > > > Hi, > > > > > > We solved 3 issues in this release: > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12352870=Text > > > > > > Staging repository: > > > https://repository.apache.org/content/repositories/orgapachesling-2807/ > > > > > > You can use this UNIX script to download the release and verify the > > > signatures: > > > > > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > > > > > Usage: > > > sh check_staged_release.sh 2807 /tmp/sling-staging > > > > > > Please vote to approve this release: > > > > > > [ ] +1 Approve the release > > > [ ] 0 Don't care > > > [ ] -1 Don't release, because ... > > > > > > This majority vote is open for at least 72 hours. > > > > > > Regards > > > Julian > > > > > > > > > -- > > Cheers, > > Jörg Hoh, > > > > https://cqdump.joerghoh.de > > Twitter: @joerghoh
[PR] SLING-12160 Prevent ConcurrentModificationException in [sling-org-apache-sling-resourceresolver]
kwin opened a new pull request, #107: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/107 readAliasesOptimized(...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12160) ConcurrentModificationException in ResourceMapperImpl.readAliases()
[
https://issues.apache.org/jira/browse/SLING-12160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787141#comment-17787141
]
Konrad Windszus commented on SLING-12160:
-
I think the easiest fix is to create a new map in
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/938fbfd176c58a9fb5bc5d18a37b47eb5c3c53bd/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L289
before iterating.
> ConcurrentModificationException in ResourceMapperImpl.readAliases()
> ---
>
> Key: SLING-12160
> URL: https://issues.apache.org/jira/browse/SLING-12160
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.10
>Reporter: Konrad Windszus
>Priority: Major
>
> I have seen the following exception with Resource Resolver 1.7.10 triggered
> by calling {{ResourceResolver.map(...)}}
> {code}
> java.util.ConcurrentModificationException
> at
> java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at
> java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:751)
> at
> java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:749)
> at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
> at
> java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.readAliases(ResourceMapperImpl.java:249)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.loadAliasesIfApplicable(ResourceMapperImpl.java:209)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:147)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:444)
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:431)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12160) ConcurrentModificationException in ResourceMapperImpl.readAliases()
[
https://issues.apache.org/jira/browse/SLING-12160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787139#comment-17787139
]
Konrad Windszus commented on SLING-12160:
-
[~joerghoh] Can you maybe look a that?
> ConcurrentModificationException in ResourceMapperImpl.readAliases()
> ---
>
> Key: SLING-12160
> URL: https://issues.apache.org/jira/browse/SLING-12160
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.10
>Reporter: Konrad Windszus
>Priority: Major
>
> I have seen the following exception with Resource Resolver 1.7.10 triggered
> by calling {{ResourceResolver.map(...)}}
> {code}
> java.util.ConcurrentModificationException
> at
> java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at
> java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:751)
> at
> java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:749)
> at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
> at
> java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.readAliases(ResourceMapperImpl.java:249)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.loadAliasesIfApplicable(ResourceMapperImpl.java:209)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:147)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:444)
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:431)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-12160) ConcurrentModificationException in ResourceMapperImpl.readAliases()
[
https://issues.apache.org/jira/browse/SLING-12160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787137#comment-17787137
]
Konrad Windszus edited comment on SLING-12160 at 11/17/23 11:13 AM:
I think this may happen when the {{MappingEntries}} are modified while
iterating through
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/a314ef3ce2e826bfde26493738ed94316c18bfbf/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L246
Even in master (although now due to refactoring in a different line) this may
still happen in
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/938fbfd176c58a9fb5bc5d18a37b47eb5c3c53bd/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L297.
was (Author: kwin):
I think this may happen when the {{MappingEntries}} are modified while
iterating through
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/a314ef3ce2e826bfde26493738ed94316c18bfbf/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L246
> ConcurrentModificationException in ResourceMapperImpl.readAliases()
> ---
>
> Key: SLING-12160
> URL: https://issues.apache.org/jira/browse/SLING-12160
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.10
>Reporter: Konrad Windszus
>Priority: Major
>
> I have seen the following exception with Resource Resolver 1.7.10 triggered
> by calling {{ResourceResolver.map(...)}}
> {code}
> java.util.ConcurrentModificationException
> at
> java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at
> java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:751)
> at
> java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:749)
> at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
> at
> java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.readAliases(ResourceMapperImpl.java:249)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.loadAliasesIfApplicable(ResourceMapperImpl.java:209)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:147)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:444)
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:431)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12160) ConcurrentModificationException in ResourceMapperImpl.readAliases()
[
https://issues.apache.org/jira/browse/SLING-12160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787137#comment-17787137
]
Konrad Windszus commented on SLING-12160:
-
I think this may happen when the {{MappingEntries}} are modified while
iterating through
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/a314ef3ce2e826bfde26493738ed94316c18bfbf/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L246
> ConcurrentModificationException in ResourceMapperImpl.readAliases()
> ---
>
> Key: SLING-12160
> URL: https://issues.apache.org/jira/browse/SLING-12160
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.10
>Reporter: Konrad Windszus
>Priority: Major
>
> I have seen the following exception with Resource Resolver 1.7.10 triggered
> by calling {{ResourceResolver.map(...)}}
> {code}
> java.util.ConcurrentModificationException
> at
> java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at
> java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:751)
> at
> java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:749)
> at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
> at
> java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.readAliases(ResourceMapperImpl.java:249)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.loadAliasesIfApplicable(ResourceMapperImpl.java:209)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:147)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:444)
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:431)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12160) ConcurrentModificationException in ResourceMapperImpl.readAliases()
Konrad Windszus created SLING-12160:
---
Summary: ConcurrentModificationException in
ResourceMapperImpl.readAliases()
Key: SLING-12160
URL: https://issues.apache.org/jira/browse/SLING-12160
Project: Sling
Issue Type: Bug
Components: ResourceResolver
Affects Versions: Resource Resolver 1.7.10
Reporter: Konrad Windszus
I have seen the following exception with Resource Resolver 1.7.10 triggered by
calling {{ResourceResolver.map(...)}}
{code}
java.util.ConcurrentModificationException
at
java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
at
java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:751)
at
java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:749)
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
at
java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
at
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
at
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at
java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
at
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at
java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
at
org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.readAliases(ResourceMapperImpl.java:249)
at
org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.loadAliasesIfApplicable(ResourceMapperImpl.java:209)
at
org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:147)
at
org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
at
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:444)
at
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:431)
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] SLING-12071: upgrade to sling parent 52 [sling-org-apache-sling-fsresource]
stefanseifert commented on code in PR #2: URL: https://github.com/apache/sling-org-apache-sling-fsresource/pull/2#discussion_r1397098919 ## pom.xml: ## @@ -199,7 +199,8 @@ org.apache.johnzon johnzon-core -1.1.1 +jakarta Review Comment: started: https://lists.apache.org/thread/w640bj7d8xkw0vxt3x25dsp9shzyb44y -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Sling Johnzon Wrapper & Jakarta JSON
in context of SLING-12058 we are migrating lots of modules from javax.json to jakarta.json. this works fine for modules using javax.json directly. however, we have a few modules which are using johnzon, which uses javax.json internally. since version johnzon 1.2.5 (we are using johnzon 1.2.21 in latest wrapper bundle) johnzon ships an additional artifact with classifier "jakarta", which uses jakarta.json internally. both artifacts with and without "jakarta" are identical, except the internal usage of the package name. our wrapper bundle contains the version using javax.json. for non-bundles like maven plugins we can just switch to the artifact with "jakarta". but this will not work for our bundles. we cannot ship both artifacts with and without "jakarta" classifier as wrapper bundles and export them both in OSGi with the same version number. i've found at least one bundle where this is already used (but not released) [1]. it stumbled about this in PR [2]. the bundles might work anyway as the bundle compiled against the johnzon "jakarta" affect should also work with the javax.json version at runtime, but this feels like a slippery slope. according to [3] johnzon is using a different way starting from version 2.0 (which seems to be released a few days ago, although the homepage is not updated yet): in version 2.0 johnzon uses only jakarta.json. so it think the correct way is to create and deploy an additional wrapper bundle for johnzon 2.0, which we can deploy side-by-side with the old wrapper bundle with 1.x. i assume we have to support both of them for quite a time, as there is a lot of code out there using johnzon 1.x. WDYT? stefan [1] https://github.com/apache/sling-org-apache-sling-installer-factory-feature/blob/867bd44f0991cedd130314d833c9aac29ae3f36c/pom.xml#L134-L140 [2] https://github.com/apache/sling-org-apache-sling-fsresource/pull/2 [3] https://johnzon.apache.org/download.html
Re: [VOTE] Release Apache Sling Repoinit JCR 1.1.46
+1 Regards Julian On Tue, Nov 14, 2023 at 8:22 AM Jörg Hoh wrote: > > +1 > > Am Mo., 13. Nov. 2023 um 13:25 Uhr schrieb Julian Sedding < > jsedd...@gmail.com>: > > > Hi, > > > > We solved 3 issues in this release: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12352870=Text > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2807/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 2807 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Julian > > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Testing OSGi Mock 3.4.0
+1 Thank you Stefan! Regards Julian On Fri, Nov 17, 2023 at 10:10 AM Stefan Seifert wrote: > > +1 > > stefan
Re: [PR] SLING-12071: upgrade to sling parent 52 [sling-org-apache-sling-fsresource]
rombert commented on code in PR #2: URL: https://github.com/apache/sling-org-apache-sling-fsresource/pull/2#discussion_r1397041977 ## pom.xml: ## @@ -199,7 +199,8 @@ org.apache.johnzon johnzon-core -1.1.1 +jakarta Review Comment: > maybe we should start a discussion on this on the mailing list. I think that's a good idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12158 improve logging in InjectableElements [sling-org-apache-sling-models-impl]
sonarcloud[bot] commented on PR #47: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/47#issuecomment-1816099888 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl=47) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=47=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=47=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=47=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=47=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=47=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=47=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=47=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=47=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=47=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=47=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=47=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=47=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=47=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=47=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=47=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=47=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12071: upgrade to sling parent 52 [sling-org-apache-sling-fsresource]
stefanseifert commented on code in PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-fsresource/pull/2#discussion_r1396971761
##
pom.xml:
##
@@ -199,7 +199,8 @@
org.apache.johnzon
johnzon-core
-1.1.1
+jakarta
Review Comment:
i think this is not a way we ca go here. we ship johnzon in sling starter as
part of this wrapper bundle:
https://github.com/apache/sling-org-apache-sling-commons-johnzon - and this
contains only the non-jakarta version. and we cannot just add the jakarta
version as well as we cannot export two different variants of the same code
with the same version number via OSGi.
i think the correct way would be to switch to Johnzon 2.0 (see
https://johnzon.apache.org/download.html, it seems to be already released
although the documentation page is not updated yet). however, to do this we
would need to prepare a new version of the johnzon wrapper bundle first
including the 2.0 version range.
and i assume that for a longer time we need to support both 1.x and 2.x
johnzon version range, as we have a lot of modules out there relying on 1.x and
the javax.json packages.
maybe we should start a discussion on this on the mailing list.
##
.sling-module.json:
##
@@ -0,0 +1,6 @@
+{
Review Comment:
we should deviate from the default build environments for all sling modules
only with a good reason - why do you exclude windows here, and limit the jdks
to 11 and 17?
if there is an issue with the build an windows, we should fix the root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
RE: [VOTE] Release Apache Sling Testing OSGi Mock 3.4.0
+1 stefan
[VOTE] Release Apache Sling Testing OSGi Mock 3.4.0
Hi, We solved 5 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353545=Text=12310710 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2810/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2810 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan
[jira] [Updated] (SLING-12157) [osgi-mock] late binding does not work for non-service DS components
[
https://issues.apache.org/jira/browse/SLING-12157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-12157:
---
Issue Type: Improvement (was: Task)
> [osgi-mock] late binding does not work for non-service DS components
> -
>
> Key: SLING-12157
> URL: https://issues.apache.org/jira/browse/SLING-12157
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Affects Versions: Testing OSGi Mock 3.3.10
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Major
> Fix For: Testing OSGi Mock 3.4.0
>
>
> A DS component that is not a service can be "injected" and "activated", but
> if a service becomes available, that satisfies a dynamic reference, the
> "bind" method is not called. The same should be true for the "unbind"
> scenario.
> I observed this when I was registering a {{ResourceDecorator}} service in a
> test case, and it did not get bound by the
> {{ResourceResolverFactoryActivator}} that was already registered by the
> {{SlingContext}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] SLING-12071: upgrade to sling parent 49 [sling-org-apache-sling-fsresource]
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-fsresource/pull/2#issuecomment-1815968595 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-fsresource=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-fsresource=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-fsresource=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-fsresource=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=2=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-fsresource=2=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-fsresource=2=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-fsresource=2=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junit from 4.13 to 4.13.1 in /src/it/annotations-it [sling-org-apache-sling-junit-core]
dependabot[bot] commented on PR #19: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/19#issuecomment-1815953096 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junit from 4.13 to 4.13.1 in /src/it/annotations-it [sling-org-apache-sling-junit-core]
apelluru commented on PR #19: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/19#issuecomment-1815953039 `4.13.2` using already -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junit from 4.13 to 4.13.1 in /src/it/annotations-it [sling-org-apache-sling-junit-core]
apelluru closed pull request #19: Bump junit from 4.13 to 4.13.1 in /src/it/annotations-it URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junit from 4.13 to 4.13.1 [sling-org-apache-sling-junit-core]
dependabot[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/18#issuecomment-1815951731 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junit from 4.13 to 4.13.1 [sling-org-apache-sling-junit-core]
apelluru commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/18#issuecomment-1815951647 `4.13.2` using already -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junit from 4.13 to 4.13.1 [sling-org-apache-sling-junit-core]
apelluru closed pull request #18: Bump junit from 4.13 to 4.13.1 URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12072) Migrate sling.junit.core to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru resolved SLING-12072. --- Resolution: Fixed > Migrate sling.junit.core to jakarta.json > > > Key: SLING-12072 > URL: https://issues.apache.org/jira/browse/SLING-12072 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
