Re: [PR] SLING-11382: Sling update to 47 [sling-org-apache-sling-jms]

2023-12-15 Thread via GitHub


sonarcloud[bot] commented on PR #3:
URL: 
https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1858648959

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jms=3)
 **Quality Gate passed**  
   Kudos, no new issues were introduced!
   
   [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=true)
  
   [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=true)
  
   No data about Coverage  
   [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jms=3)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [VOTE] Release Apache Sling Engine 2.15.10

2023-12-15 Thread Eric Norman
0 for me.

I would probably prefer that the SLING-12124 changes not be reverted as
leaving the old behavior could be somewhat of a security risk.  For
example, I could put enough extra dots in the url to push some details of
the address off the right edge of the browser's address bar in order to
obscure information from the user in order to trick them into doing
something they wouldn't otherwise do if the canonical address was fully
visible.

Perhaps there is a convenient way that the SLING-12124 behavior could be
made optional via some configuration flag?  Or at least some feedback
somewhere to nudge the end user into using a well formed address?

Regards,
-Eric

On Fri, Dec 15, 2023 at 3:56 AM Carsten Ziegeler 
wrote:

> Hi,
>
> We solved 1 issue in this release
> https://issues.apache.org/jira/browse/SLING-12201
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2823/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2823 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe
> cziege...@apache.org
>


Re: [VOTE] Release Apache Sling GraphQL 0.0.26

2023-12-15 Thread Jörg Hoh
+1

Am Mi., 13. Dez. 2023 um 07:15 Uhr schrieb Carsten Ziegeler <
cziege...@apache.org>:

> Hi,
>
> We solved 2 issues in this release
> https://issues.apache.org/jira/projects/SLING/versions/12353628
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2822/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2822 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe
> cziege...@apache.org
>


-- 
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh


RE: [VOTE] Release Apache Sling Engine 2.15.10

2023-12-15 Thread Stefan Seifert
+1

stefan 


[jira] [Closed] (SLING-12192) caconfig-mock-plugin: Fix nested config path building when writing config with custom persistence strategies

2023-12-15 Thread Stefan Seifert (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-12192.
--

> caconfig-mock-plugin: Fix nested config path building when writing config 
> with custom persistence strategies
> 
>
> Key: SLING-12192
> URL: https://issues.apache.org/jira/browse/SLING-12192
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Context-Aware Configuration Mock Plugin 1.5.2
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Context-Aware Configuration Mock Plugin 1.5.4
>
>
> as reported in https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/25 
> there is currently an issue when custom persistence strategies are in place: 
> nested configurations may be written in invalid paths, resulting in not found 
> when reading the configuration again.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-12191) caconfig-mock-plugin: Update to Parent 52

2023-12-15 Thread Stefan Seifert (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-12191.
--

> caconfig-mock-plugin: Update to Parent 52
> -
>
> Key: SLING-12191
> URL: https://issues.apache.org/jira/browse/SLING-12191
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Context-Aware Configuration Mock Plugin 1.5.2
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: Context-Aware Configuration Mock Plugin 1.5.4
>
>
> update to latest parent



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[RESULT] [VOTE] Release Apache Sling Context-Aware Configuration Mock Plugin 1.5.4

2023-12-15 Thread Stefan Seifert
Hi,

The vote has passed with the following result :

+1 (binding): Stefan Seifert, Radu Cotescu, Robert Munteanu

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

stefan


Re: [VOTE] Release Apache Sling Engine 2.15.10

2023-12-15 Thread Jörg Hoh
+1

Am Fr., 15. Dez. 2023 um 12:55 Uhr schrieb Carsten Ziegeler <
cziege...@apache.org>:

> Hi,
>
> We solved 1 issue in this release
> https://issues.apache.org/jira/browse/SLING-12201
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2823/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2823 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe
> cziege...@apache.org
>


-- 
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh


[jira] [Comment Edited] (SLING-12181) Evaluate provider type information also directly from annotations

2023-12-15 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-12181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797151#comment-17797151
 ] 

Konrad Windszus edited comment on SLING-12181 at 12/15/23 12:20 PM:


This is the same as for provider type retrieved via {{META-INF/api-info.json}}. 
And yes, for bundles who are supposed to implement/extend providers it must not 
be used! Also the readme is pretty clear in this regard:

bq. This module contains a Bnd plugin enforcing that no class of the current 
bundle extends or implements a provider type. Note that using a provider type 
(i.e. calling its methods without implementing or extending it) is still 
allowed (even for consumers).

[~cziegeler] You obviously never had to deal with limitation of distributions 
like these: 
https://experienceleague.adobe.com/docs/experience-manager-cloud-manager/content/using/custom-code-quality-rules.html?lang=en#product-apis-annotated-with-providertype-should-not-be-implemented-or-extended-by-customers


was (Author: kwin):
This is the same as for provider type retrieved via {{META-INF/api-info.json}}. 
And yes, for bundles who are supposed to implement/extend providers it must not 
be used! Also the readme is pretty clear in this regard:

bq. This module contains a Bnd plugin enforcing that no class of the current 
bundle extends or implements a provider type. Note that using a provider type 
(i.e. calling its methods without implementing or extending it) is still 
allowed (even for consumers).

> Evaluate provider type information also directly from annotations
> -
>
> Key: SLING-12181
> URL: https://issues.apache.org/jira/browse/SLING-12181
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Provider Type Checker Bnd Plugin 1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Provider Type Checker Bnd Plugin 1.1.0
>
>
> Currently the check implemented in SLING-12026 only retrieves the provider 
> type information from the META-INF/api-info.json (being generated by 
> SLING-12135).
> As fallback there should be direct evaluation of the annotations.
> The logic needs to be the same as in 
> https://github.com/bndtools/bnd/blob/d06df066f402f1433b70c51f568c40a444b4518d/biz.aQute.bndlib/src/aQute/bnd/osgi/Analyzer.java#L1991,
>  i.e. the annotation provider type needs to be evaluated both on package as 
> well as on type level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (SLING-12181) Evaluate provider type information also directly from annotations

2023-12-15 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-12181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797151#comment-17797151
 ] 

Konrad Windszus edited comment on SLING-12181 at 12/15/23 12:14 PM:


This is the same as for provider type retrieved via {{META-INF/api-info.json}}. 
And yes, for bundles who are supposed to implement/extend providers it must not 
be used! Also the readme is pretty clear in this regard:

bq. This module contains a Bnd plugin enforcing that no class of the current 
bundle extends or implements a provider type. Note that using a provider type 
(i.e. calling its methods without implementing or extending it) is still 
allowed (even for consumers).


was (Author: kwin):
This is the same as for provider type retrieved via {{META-INF/api-info.json}}. 
And yes, for bundles who are supposed to implement/extend providers it must not 
be used!

> Evaluate provider type information also directly from annotations
> -
>
> Key: SLING-12181
> URL: https://issues.apache.org/jira/browse/SLING-12181
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Provider Type Checker Bnd Plugin 1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Provider Type Checker Bnd Plugin 1.1.0
>
>
> Currently the check implemented in SLING-12026 only retrieves the provider 
> type information from the META-INF/api-info.json (being generated by 
> SLING-12135).
> As fallback there should be direct evaluation of the annotations.
> The logic needs to be the same as in 
> https://github.com/bndtools/bnd/blob/d06df066f402f1433b70c51f568c40a444b4518d/biz.aQute.bndlib/src/aQute/bnd/osgi/Analyzer.java#L1991,
>  i.e. the annotation provider type needs to be evaluated both on package as 
> well as on type level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[VOTE] Release Apache Sling Engine 2.15.10

2023-12-15 Thread Carsten Ziegeler

Hi,

We solved 1 issue in this release
https://issues.apache.org/jira/browse/SLING-12201

Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2823/


You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2823 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org


[jira] [Commented] (SLING-12181) Evaluate provider type information also directly from annotations

2023-12-15 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-12181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797148#comment-17797148
 ] 

Carsten Ziegeler commented on SLING-12181:
--

Very often you have a combination of provider type and consumer type 
implementations in your bundle - in which case you can't use the plugin without 
any further information. I'm not against implementing this, but I wonder how 
useful it is in the end.

> Evaluate provider type information also directly from annotations
> -
>
> Key: SLING-12181
> URL: https://issues.apache.org/jira/browse/SLING-12181
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Provider Type Checker Bnd Plugin 1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Provider Type Checker Bnd Plugin 1.1.0
>
>
> Currently the check implemented in SLING-12026 only retrieves the provider 
> type information from the META-INF/api-info.json (being generated by 
> SLING-12135).
> As fallback there should be direct evaluation of the annotations.
> The logic needs to be the same as in 
> https://github.com/bndtools/bnd/blob/d06df066f402f1433b70c51f568c40a444b4518d/biz.aQute.bndlib/src/aQute/bnd/osgi/Analyzer.java#L1991,
>  i.e. the annotation provider type needs to be evaluated both on package as 
> well as on type level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (SLING-12201) Regression introduced by SLING-12124

2023-12-15 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12201.
--
Resolution: Fixed

Reverted in 
https://github.com/apache/sling-org-apache-sling-engine/commit/7d84c3d3cde95421fe597f5977bf735e50ed55d3

> Regression introduced by SLING-12124
> 
>
> Key: SLING-12201
> URL: https://issues.apache.org/jira/browse/SLING-12201
> Project: Sling
>  Issue Type: Bug
>  Components: Engine
>Affects Versions: Engine 2.15.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Engine 2.15.10
>
>
> With SLING-12124 urls containing consecutive dots are regarded invalid, 
> however there is a lot of code out there asuming that these are valid ones. 
> Its also easy to mistype a url with two dots.
> To avoid disruption, we should revert.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (SLING-12201) Regression introduced by SLING-12124

2023-12-15 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-12201:


 Summary: Regression introduced by SLING-12124
 Key: SLING-12201
 URL: https://issues.apache.org/jira/browse/SLING-12201
 Project: Sling
  Issue Type: Bug
  Components: Engine
Affects Versions: Engine 2.15.8
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Engine 2.15.10


With SLING-12124 urls containing consecutive dots are regarded invalid, however 
there is a lot of code out there asuming that these are valid ones. Its also 
easy to mistype a url with two dots.
To avoid disruption, we should revert.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-12026) Check for implementation/extension of provider types

2023-12-15 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797140#comment-17797140
 ] 

Konrad Windszus commented on SLING-12026:
-

[~bellingard] Can you onboard 
https://github.com/apache/sling-org-apache-sling-providertype-bnd-plugin to 
SonarCloud as well? Thanks.

> Check for implementation/extension of provider types
> 
>
> Key: SLING-12026
> URL: https://issues.apache.org/jira/browse/SLING-12026
> Project: Sling
>  Issue Type: New Feature
>  Components: Bnd Plugins
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Provider Type Checker Bnd Plugin 1.0.0
>
>
> OSGi distinguishes between 
> [consumer|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ConsumerType.html]
>  and 
> [provider|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html]
>  types (either interfaces or classes).
> Some bundles/features are only supposed to implement/extend consumer types in 
> order to be more stable against API changes. There should be a -feature model 
> analyser- bnd plugin enforcing this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-12026) Check for implementation/extension of provider types

2023-12-15 Thread Roy Teeuwen (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797135#comment-17797135
 ] 

Roy Teeuwen commented on SLING-12026:
-

OK, we were on 2023.10 ;) that explains, thanks!

> Check for implementation/extension of provider types
> 
>
> Key: SLING-12026
> URL: https://issues.apache.org/jira/browse/SLING-12026
> Project: Sling
>  Issue Type: New Feature
>  Components: Bnd Plugins
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Provider Type Checker Bnd Plugin 1.0.0
>
>
> OSGi distinguishes between 
> [consumer|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ConsumerType.html]
>  and 
> [provider|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html]
>  types (either interfaces or classes).
> Some bundles/features are only supposed to implement/extend consumer types in 
> order to be more stable against API changes. There should be a -feature model 
> analyser- bnd plugin enforcing this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-12026) Check for implementation/extension of provider types

2023-12-15 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797133#comment-17797133
 ] 

Konrad Windszus commented on SLING-12026:
-

Having a dependency is enough. Are you sure that that you reference a version 
that is new enough?

> Check for implementation/extension of provider types
> 
>
> Key: SLING-12026
> URL: https://issues.apache.org/jira/browse/SLING-12026
> Project: Sling
>  Issue Type: New Feature
>  Components: Bnd Plugins
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Provider Type Checker Bnd Plugin 1.0.0
>
>
> OSGi distinguishes between 
> [consumer|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ConsumerType.html]
>  and 
> [provider|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html]
>  types (either interfaces or classes).
> Some bundles/features are only supposed to implement/extend consumer types in 
> order to be more stable against API changes. There should be a -feature model 
> analyser- bnd plugin enforcing this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-12026) Check for implementation/extension of provider types

2023-12-15 Thread Roy Teeuwen (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797130#comment-17797130
 ] 

Roy Teeuwen commented on SLING-12026:
-

[~kwin]  I do have a dependency on the aem-sdk-api in the bundle that is using 
the plugin, so just having a dependency is not enough then I guess?

> Check for implementation/extension of provider types
> 
>
> Key: SLING-12026
> URL: https://issues.apache.org/jira/browse/SLING-12026
> Project: Sling
>  Issue Type: New Feature
>  Components: Bnd Plugins
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Provider Type Checker Bnd Plugin 1.0.0
>
>
> OSGi distinguishes between 
> [consumer|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ConsumerType.html]
>  and 
> [provider|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html]
>  types (either interfaces or classes).
> Some bundles/features are only supposed to implement/extend consumer types in 
> order to be more stable against API changes. There should be a -feature model 
> analyser- bnd plugin enforcing this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-12181) Evaluate provider type information also directly from annotations

2023-12-15 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-12181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797129#comment-17797129
 ] 

Carsten Ziegeler commented on SLING-12181:
--

How do you distinguish between allowed implementations of a ProviderType and 
forbidden ones?

> Evaluate provider type information also directly from annotations
> -
>
> Key: SLING-12181
> URL: https://issues.apache.org/jira/browse/SLING-12181
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Provider Type Checker Bnd Plugin 1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Provider Type Checker Bnd Plugin 1.1.0
>
>
> Currently the check implemented in SLING-12026 only retrieves the provider 
> type information from the META-INF/api-info.json (being generated by 
> SLING-12135).
> As fallback there should be direct evaluation of the annotations.
> The logic needs to be the same as in 
> https://github.com/bndtools/bnd/blob/d06df066f402f1433b70c51f568c40a444b4518d/biz.aQute.bndlib/src/aQute/bnd/osgi/Analyzer.java#L1991,
>  i.e. the annotation provider type needs to be evaluated both on package as 
> well as on type level.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [VOTE] Release Apache Sling Context-Aware Configuration Mock Plugin 1.5.4

2023-12-15 Thread Robert Munteanu
On Mon, 2023-12-11 at 15:15 +, Stefan Seifert wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part


Re: [PR] SLING-12186 Enforce source code formatting with spotless-maven-plugin [sling-parent]

2023-12-15 Thread via GitHub


kwin commented on PR #41:
URL: https://github.com/apache/sling-parent/pull/41#issuecomment-1857592197

   > initially when switchting to this new parent which enforces the formatting 
to ensure existing code is complient
   > and later when contributing new code/PRs and build starts failing do to 
formatting violation
   
   Maven emits in its failure message the way to fix it:
   
   ```
   [INFO] 

   [INFO] BUILD FAILURE
   [INFO] 

   [INFO] Total time:  3.219 s
   [INFO] Finished at: 2023-12-15T10:55:25+01:00
   [INFO] 

   [ERROR] Failed to execute goal 
com.diffplug.spotless:spotless-maven-plugin:2.37.0:check (default) on project 
...: The following files had format violations:
   ...
   [ERROR] Run 'mvn spotless:apply' to fix these violations.
   [ERROR] -> [Help 1]
   ```
   
   For me this looks obvious enough.
   Regarding IDE support, there is m2e support in spotless-maven-plugin and 
palantir comes with dedicated IDE plugins as well 
(https://github.com/palantir/palantir-java-format?tab=readme-ov-file#palantir-java-format)
 but the idea is really that Maven does the job and no one should need to 
install any additional plugins.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] SLING-12186 Enforce source code formatting with spotless-maven-plugin [sling-parent]

2023-12-15 Thread via GitHub


stefanseifert commented on PR #41:
URL: https://github.com/apache/sling-parent/pull/41#issuecomment-1857569256

   can we also create a how-to document/wiki page what to do:
   
   * initially when switchting to this new parent which enforces the formatting 
to ensure existing code is complient
   * and later when contributing new code/PRs and build starts failing do to 
formatting violation
   * and maybe even some hints/links how to include the formatting rules in the 
IDEs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (SLING-12026) Check for implementation/extension of provider types

2023-12-15 Thread Roy Teeuwen (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797099#comment-17797099
 ] 

Roy Teeuwen commented on SLING-12026:
-

[~kwin]  I tried implementing it in our codebase, but it complains 
META-INF/api-info.json is not available. What file should be generating this 
json file? 

> Check for implementation/extension of provider types
> 
>
> Key: SLING-12026
> URL: https://issues.apache.org/jira/browse/SLING-12026
> Project: Sling
>  Issue Type: New Feature
>  Components: Bnd Plugins
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Provider Type Checker Bnd Plugin 1.0.0
>
>
> OSGi distinguishes between 
> [consumer|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ConsumerType.html]
>  and 
> [provider|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html]
>  types (either interfaces or classes).
> Some bundles/features are only supposed to implement/extend consumer types in 
> order to be more stable against API changes. There should be a -feature model 
> analyser- bnd plugin enforcing this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


RE: [VOTE] Release Apache Sling Context-Aware Configuration Mock Plugin 1.5.4

2023-12-15 Thread Stefan Seifert
i need one more binding vote ...

stefan

> -Original Message-
> From: Stefan Seifert 
> Sent: Monday, December 11, 2023 4:16 PM
> To: dev@sling.apache.org
> Subject: [VOTE] Release Apache Sling Context-Aware Configuration Mock
> Plugin 1.5.4
> 
> Hi,
> 
> We solved 2 issues in this release:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353380
> yleName=Text=12310710
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2821/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://raw.githubusercontent.com/apache/sling-tooling-
> release/master/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 2821 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> stefan