Re: [PR] SLING-11352 - Fix parsing of path-only mappings [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1892696229 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=84) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=true) [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list) [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=84) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Various improvements for the webconsole plugin [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-1892695977 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=78) **Quality Gate failed** Failed conditions [2.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=78) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12222: INFO-level log not only query time but also # of resources (and rate) for sling:alias and sling:vanityPath [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #112: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/112#issuecomment-1892458855 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=112) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=112=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=112=false=true) [81.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=112=new_coverage=list) [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=112=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=112) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Testing Clients 3.0.22
+1 Am Mo., 15. Jan. 2024 um 11:09 Uhr schrieb Andrei Dulvac : > Hi, > > We solved 5 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12353709 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2829/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2829 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > - Andrei > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Rewriter 1.3.8
+1 Am Mo., 15. Jan. 2024 um 10:58 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354083 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2828/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2828 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [PR] SLING-12222: INFO-level log not only query time but also # of resources (and rate) for sling:alias and sling:vanityPath [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #112: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/112#issuecomment-1892282459 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=112) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=112=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=112=false=true) [81.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=112=new_coverage=list) [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=112=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=112) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1225 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1225/ for details. No further emails will be sent until the status of the build is changed.
RE: [VOTE] Release Apache Sling Testing Clients 3.0.22
+1 stefan
RE: [VOTE] Release Apache Sling Rewriter 1.3.8
+1 stefan
Re: [VOTE] Release Apache Sling Testing Clients 3.0.22
+1 Carsten On 15.01.2024 11:08, Andrei Dulvac wrote: Hi, We solved 5 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12353709 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2829/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2829 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. - Andrei -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Rewriter 1.3.8
+1 On Mon, Jan 15, 2024 at 10:58 AM Carsten Ziegeler wrote: > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354083 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2828/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2828 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
[VOTE] Release Apache Sling Testing Clients 3.0.22
Hi, We solved 5 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12353709 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2829/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2829 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. - Andrei
[VOTE] Release Apache Sling Rewriter 1.3.8
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354083 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2828/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2828 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.3.10 (was: Rewriter 1.3.8) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.3.10 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter
[ https://issues.apache.org/jira/browse/SLING-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12230. -- Resolution: Fixed Changed in https://github.com/apache/sling-org-apache-sling-rewriter/commit/2960e0b480f53308a7184dc63dc45b958b46e6e6 > Replace usage of Sling Commons OSGi with OSGi converter > --- > > Key: SLING-12230 > URL: https://issues.apache.org/jira/browse/SLING-12230 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > We should replace the usage of Sling Commons OSGi with the OSGi converter to > remove all usage of commons osgi. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter
Carsten Ziegeler created SLING-12230: Summary: Replace usage of Sling Commons OSGi with OSGi converter Key: SLING-12230 URL: https://issues.apache.org/jira/browse/SLING-12230 Project: Sling Issue Type: Improvement Components: General Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.3.8 We should replace the usage of Sling Commons OSGi with the OSGi converter to remove all usage of commons osgi. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12228) Status printer does not display global transformers
[ https://issues.apache.org/jira/browse/SLING-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12228. -- Assignee: Carsten Ziegeler Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-rewriter/commit/5ef0f8e0fe857fe03a5e1770838359fb654ecb1f > Status printer does not display global transformers > --- > > Key: SLING-12228 > URL: https://issues.apache.org/jira/browse/SLING-12228 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.6 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > Global transformers are currently not displayed at all on the status report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12229) Update jackson and jsoup dependencies
[ https://issues.apache.org/jira/browse/SLING-12229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-12229. --- Resolution: Fixed > Update jackson and jsoup dependencies > - > > Key: SLING-12229 > URL: https://issues.apache.org/jira/browse/SLING-12229 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.20 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Major > Fix For: Apache Sling Testing Clients 3.0.22 > > > jackson-core - 2.13.0, jackson-databind-2.13.2.1, jsoup-1.14.3 need to be > updated because they cause: > CVE-2022-42003 > CVE-2022-42004 > CVE-2022-36033 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-10868) Search pattern in getSlingLocation method only works if id is the last attribute
[ https://issues.apache.org/jira/browse/SLING-10868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac reassigned SLING-10868: - Assignee: Andrei Dulvac > Search pattern in getSlingLocation method only works if id is the last > attribute > > > Key: SLING-10868 > URL: https://issues.apache.org/jira/browse/SLING-10868 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Reporter: Michael Kitanovski >Assignee: Andrei Dulvac >Priority: Major > Labels: sling-IT > Attachments: response_content.txt > > > The method getSlingLocation in class SlingHttpResponse uses a search pattern > which only works if the "id" attribute is the last one. We have implemented a > link rewriter transformer in our project which adds a class="internal" to > each internal link. In our case now the class attribute is the last one and > the method extractFromHTMLResponse(String searchPattern) will return null > because it won't find the the searched string in the content (see attached > response_content.txt). > > [https://github.com/apache/sling-org-apache-sling-testing-clients/blob/c8a6d4bd9c3e92a2c00920d86f3d27d58478050e/src/main/java/org/apache/sling/testing/clients/SlingHttpResponse.java#L201] > > The same issue exists for other methods like > - getSlingParentLocation() > - getSlingReferer() > > It seems AEMaaCs uses the aem-test-samples > ([https://github.com/adobe/aem-test-samples)] for integration tests during > the production pipeline run. One of the tests is using the getSlingLocation > method which causes termination of the deployment process. > > [https://github.com/adobe/aem-test-samples/blob/4f7653db344c3f31f4a1a6440bf0f01db75ea382/smoke/src/main/java/com/adobe/cq/cloud/testing/it/smoke/CreatePageAsAuthorUserIT.java#L78] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-6072) The testing rules do not call CloseableHttpClient.close()
[
https://issues.apache.org/jira/browse/SLING-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-6072.
--
Resolution: Fixed
> The testing rules do not call CloseableHttpClient.close()
> -
>
> Key: SLING-6072
> URL: https://issues.apache.org/jira/browse/SLING-6072
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.0.0, Apache Sling Testing
> Rules 1.0.0
>Reporter: Konrad Windszus
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Rules 1.0.1, Apache Sling Testing
> Clients 1.0.1
>
>
> The rules being provided by the sling testing rules do not automatically call
> close on the underlying {{ClosableHttpClient}} which is necessary to close
> the dangling http connections being managed by the underlying connection
> manager (see
> https://hc.apache.org/httpcomponents-client-ga/tutorial/html/fundamentals.html#d5e217).
> Even custom code cannot call close, because the underlying
> {{ClosableHttpClient}} is not really exposed.
> I guess there is also a change necessary in testing/http/client to expose
> such a close method as well, and also clarify under which circumstances a new
> HttpClient is created or when an existing one is reused.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-6072) The testing rules do not call CloseableHttpClient.close()
[
https://issues.apache.org/jira/browse/SLING-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-6072:
-
Fix Version/s: Apache Sling Testing Rules 1.0.1
Apache Sling Testing Clients 1.0.1
> The testing rules do not call CloseableHttpClient.close()
> -
>
> Key: SLING-6072
> URL: https://issues.apache.org/jira/browse/SLING-6072
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.0.0, Apache Sling Testing
> Rules 1.0.0
>Reporter: Konrad Windszus
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.0.1, Apache Sling Testing
> Rules 1.0.1
>
>
> The rules being provided by the sling testing rules do not automatically call
> close on the underlying {{ClosableHttpClient}} which is necessary to close
> the dangling http connections being managed by the underlying connection
> manager (see
> https://hc.apache.org/httpcomponents-client-ga/tutorial/html/fundamentals.html#d5e217).
> Even custom code cannot call close, because the underlying
> {{ClosableHttpClient}} is not really exposed.
> I guess there is also a change necessary in testing/http/client to expose
> such a close method as well, and also clarify under which circumstances a new
> HttpClient is created or when an existing one is reused.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-7035) [http.testing.clients] OsgiConsoleClient#editConfigurationWithWait does not wait for bundle to be restarted
[ https://issues.apache.org/jira/browse/SLING-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-7035. -- Resolution: Cannot Reproduce > [http.testing.clients] OsgiConsoleClient#editConfigurationWithWait does not > wait for bundle to be restarted > --- > > Key: SLING-7035 > URL: https://issues.apache.org/jira/browse/SLING-7035 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.1.4 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Major > > https://github.com/apache/sling/blob/trunk/testing/http/clients/src/main/java/org/apache/sling/testing/clients/osgi/OsgiConsoleClient.java#L342 > doesn't wait for the affected bundle to be restarted. > We need a mechanism to wait for the bundle that's restarted after the config > change. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-8114) Allow to do polling of code failing on asserts
[
https://issues.apache.org/jira/browse/SLING-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-8114.
--
Resolution: Won't Do
> Allow to do polling of code failing on asserts
> --
>
> Key: SLING-8114
> URL: https://issues.apache.org/jira/browse/SLING-8114
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.0
>Reporter: Thierry Ygé
>Priority: Major
>
> Currently if you polling check uses assertions , it will not be retried, this
> is due to this line
> [https://github.com/apache/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java#L118]
> Which is only catching Exceptions while failing Assertions are an error kind
> (AssertionError).
> It would be nice to handle it so that code wouldn't have to "transform" it to
> exception.
> To reproduce simply use assertion in your polling check and let it fail if a
> counter is lower than a value. make the polling retries so that at the next
> retry counter it should pass.
>
> {quote}int count = 0;
> new Polling(() -> { count++; Assert.assertTrue(count == 2); return true;
> }
> ).poll(2000, 500);
> {quote}
> Observation: it exist the poll directly as the assert fail already.
> Expected: It should have polled until the check pass here.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-9188) Sling Testing Clients does not work on GET with parameters
[ https://issues.apache.org/jira/browse/SLING-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-9188. -- Resolution: Cannot Reproduce > Sling Testing Clients does not work on GET with parameters > -- > > Key: SLING-9188 > URL: https://issues.apache.org/jira/browse/SLING-9188 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 2.0.0 > Environment: Sling 12 >Reporter: Andreas Schaefer >Priority: Major > > There is an issue with Sling Client's doGet() as parameters (?a=b) will cause > an error. The question mark is encoded %3F which makes the call fail. > > I created a test project: [https://github.com/schaefa/sling-testing-client-it] > > Run it with: mvn clean install -P it -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11611) Provide method to retrieve Pid for OSGI Configurations in Sling Testing Clients
[ https://issues.apache.org/jira/browse/SLING-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-11611. --- Fix Version/s: Apache Sling Testing Clients 3.0.22 Resolution: Fixed > Provide method to retrieve Pid for OSGI Configurations in Sling Testing > Clients > --- > > Key: SLING-11611 > URL: https://issues.apache.org/jira/browse/SLING-11611 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.16 >Reporter: Nicola Scendoni >Assignee: Andrei Dulvac >Priority: Minor > Fix For: Apache Sling Testing Clients 3.0.22 > > > During development of IT Tests it may be needed to search the pid for some > OSGI Configuration not created by the test itself. > I will provide an implementation to search the pid of configurations from > serviceType and the value of a property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11125) SlingClient.exists(...) should use expected status in order to support http retries parameters
[ https://issues.apache.org/jira/browse/SLING-11125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-11125. --- Resolution: Not A Bug > SlingClient.exists(...) should use expected status in order to support http > retries parameters > -- > > Key: SLING-11125 > URL: https://issues.apache.org/jira/browse/SLING-11125 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.10 >Reporter: Thierry Ygé >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Currently if tests need to retries on some errors which are likely to happen > in clustered setup (AEM in Cloud for example). > usually the use of > "-Dsling.it.http.retriesErrorCodes=401,404,405,429,500,501,503" would include > 404 cases. > The issue is then SlingClient.exists(...) would always fail in case we try to > check for "not existing path" as the test would expect also 404 to be > returned. > The current implementation of ServerErrorRetryStrategy support that if the > expected values are passed , this would bypass the retriesErrorCodes. > Thus it would make sense to pass the possible returned code for the request > done by SlingClient.exists(...) call. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] dependency updates [sling-org-apache-sling-testing-clients]
dulvac merged PR #46: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12229) Update jackson-core dependencies
Andrei Dulvac created SLING-12229: - Summary: Update jackson-core dependencies Key: SLING-12229 URL: https://issues.apache.org/jira/browse/SLING-12229 Project: Sling Issue Type: Bug Components: Apache Sling Testing Clients Affects Versions: Apache Sling Testing Clients 3.0.20 Reporter: Andrei Dulvac Assignee: Andrei Dulvac Fix For: Apache Sling Testing Clients 3.0.22 jackson-core - 2.13.0, jackson-databind-2.13.2.1, jsoup-1.14.3 need to be updated because they cause: CVE-2022-42003 CVE-2022-42004 CVE-2022-36033 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12229) Update jackson and jsoup dependencies
[ https://issues.apache.org/jira/browse/SLING-12229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-12229: -- Summary: Update jackson and jsoup dependencies (was: Update jackson-core dependencies) > Update jackson and jsoup dependencies > - > > Key: SLING-12229 > URL: https://issues.apache.org/jira/browse/SLING-12229 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.20 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Major > Fix For: Apache Sling Testing Clients 3.0.22 > > > jackson-core - 2.13.0, jackson-databind-2.13.2.1, jsoup-1.14.3 need to be > updated because they cause: > CVE-2022-42003 > CVE-2022-42004 > CVE-2022-36033 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12096) Testing clients - don't log request headers
[
https://issues.apache.org/jira/browse/SLING-12096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-12096.
---
Fix Version/s: Apache Sling Testing Clients 3.0.22
Resolution: Fixed
> Testing clients - don't log request headers
> ---
>
> Key: SLING-12096
> URL: https://issues.apache.org/jira/browse/SLING-12096
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Marc Pfaff
>Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 3.0.22
>
>
> The ServerErrorRetryStrategy used in the testing clients logs when a retry
> condition is met.
> I propose to improve this output with more request/response details and retry
> condition details, in order to help troubleshooting test failures.
> Current output (example from the unit test):
> {code:java}
> Request retry needed due to service unavailable response
> Response headers contained:
> Header Date:Wed, 11 Jan 2023 08:36:43 GMT
> Header Server:TEST/1.1
> Header Content-Length:8
> Header Content-Type:text/plain; charset=ISO-8859-1
> Header Connection:Keep-Alive
> Response content: TEST_NOK
> {code}
> Proposed improvement (example from the unit test):
> {code:java}
> Request retry condition met: [count=1/4], [expected-codes=[200]],
> [retry-codes=[500, 503]]
> Request: GET /test/internalerror/resource HTTP/1.1 [Host: 127.0.0.1:32953,
> Connection: Keep-Alive, User-Agent: Java, Accept-Encoding: gzip,deflate,
> Authorization: Basic dXNlcjpwYXNz]
> Response: HTTP/1.1 500 Internal Server Error [Date: Wed, 11 Jan 2023 08:39:59
> GMT, Server: TEST/1.1, Content-Length: 8, Content-Type: text/plain;
> charset=ISO-8859-1, Connection: Keep-Alive, ]
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11279) Make SlingClient.exists() more resilient with http retries codes
[ https://issues.apache.org/jira/browse/SLING-11279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-11279. --- Fix Version/s: Apache Sling Testing Clients 3.0.22 Resolution: Fixed > Make SlingClient.exists() more resilient with http retries codes > - > > Key: SLING-11279 > URL: https://issues.apache.org/jira/browse/SLING-11279 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.12 >Reporter: Thierry Ygé >Assignee: Andrei Dulvac >Priority: Major > Fix For: Apache Sling Testing Clients 3.0.22 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently if we are in cluster with affinity cookie and use httpRetries code > to retries on 404 to avoid sync problems, the exists() method can be confused > for 404 responses. > In order to fix it, it need to explicitely list generally expected code that > might not need retries in that context. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11609) Provide doGetWithRetry methods in Sling Testing Clients
[ https://issues.apache.org/jira/browse/SLING-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-11609. --- Fix Version/s: Apache Sling Testing Clients 3.0.22 Assignee: Andrei Dulvac (was: Nicola Scendoni) Resolution: Fixed > Provide doGetWithRetry methods in Sling Testing Clients > --- > > Key: SLING-11609 > URL: https://issues.apache.org/jira/browse/SLING-11609 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.16 >Reporter: Nicola Scendoni >Assignee: Andrei Dulvac >Priority: Minor > Fix For: Apache Sling Testing Clients 3.0.22 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > In several situations during IT Tests development we need to retry doGet > method until some assertion are verified. > I propose in the attached pull request an implementation and test for new > methods doGetWithRetry -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] dependency updates [sling-org-apache-sling-testing-clients]
sonarcloud[bot] commented on PR #46: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/46#issuecomment-1891611771 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-clients=46) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=46=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients=46=false=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=46=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-clients=46) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-11279) Make SlingClient.exists() more resilient with http retries codes
[ https://issues.apache.org/jira/browse/SLING-11279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac reassigned SLING-11279: - Assignee: Andrei Dulvac > Make SlingClient.exists() more resilient with http retries codes > - > > Key: SLING-11279 > URL: https://issues.apache.org/jira/browse/SLING-11279 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.12 >Reporter: Thierry Ygé >Assignee: Andrei Dulvac >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently if we are in cluster with affinity cookie and use httpRetries code > to retries on 404 to avoid sync problems, the exists() method can be confused > for 404 responses. > In order to fix it, it need to explicitely list generally expected code that > might not need retries in that context. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11279 Fixing to specify exactly expected code on which httpRetr… [sling-org-apache-sling-testing-clients]
dulvac merged PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11609: Provide doGetWithRetry methods in Sling Testing Clients [sling-org-apache-sling-testing-clients]
dulvac merged PR #38: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11611: Provide method to retrieve Pid for OSGI Configurations in Sling Testing Clients [sling-org-apache-sling-testing-clients]
dulvac merged PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-11611) Provide method to retrieve Pid for OSGI Configurations in Sling Testing Clients
[ https://issues.apache.org/jira/browse/SLING-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac reassigned SLING-11611: - Assignee: Andrei Dulvac (was: Nicola Scendoni) > Provide method to retrieve Pid for OSGI Configurations in Sling Testing > Clients > --- > > Key: SLING-11611 > URL: https://issues.apache.org/jira/browse/SLING-11611 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.16 >Reporter: Nicola Scendoni >Assignee: Andrei Dulvac >Priority: Minor > > During development of IT Tests it may be needed to search the pid for some > OSGI Configuration not created by the test itself. > I will provide an implementation to search the pid of configurations from > serviceType and the value of a property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump jsoup from 1.14.3 to 1.15.3 [sling-org-apache-sling-testing-clients]
dependabot[bot] commented on PR #36: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/36#issuecomment-1891569361 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump jsoup from 1.14.3 to 1.15.3 [sling-org-apache-sling-testing-clients]
dulvac closed pull request #36: Bump jsoup from 1.14.3 to 1.15.3 URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11748 - Improve logging output of HTTP retries in testing clients [sling-org-apache-sling-testing-clients]
dulvac merged PR #43: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump jackson-databind from 2.13.2.1 to 2.13.4.2 [sling-org-apache-sling-testing-clients]
dulvac merged PR #44: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12222: INFO-level log not only query time but also # of resources (and rate) for sling:alias and sling:vanityPath [sling-org-apache-sling-resourceresolver]
joerghoh commented on code in PR #112:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/112#discussion_r1452054103
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1163,14 +1166,17 @@ private Map>>
loadAliases(final ResourceR
it = queryUnpaged("alias", baseQueryString);
}
+log.debug("alias initialization - start");
long count = 0;
long processStart = System.nanoTime();
while (it.hasNext()) {
count += 1;
loadAlias(it.next(), map);
}
long processElapsed = System.nanoTime() - processStart;
-log.debug("processed {} resources with sling:alias properties in
{}ms", count, TimeUnit.NANOSECONDS.toMillis(processElapsed));
+long resourcePerSecond = (count * TimeUnit.SECONDS.toNanos(1) /
(processElapsed == 0 ? 1 : processElapsed));
+log.info("alias initialization - end, processed {} resources with
sling:alias properties in {}ms (~{} resource/s)", count,
Review Comment:
same as above
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -352,7 +352,10 @@ private void execute() {
drainQueue(resourceChangeQueue);
long initElapsed = System.nanoTime() - initStart;
-log.info("vanity path initialization - end, elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(initElapsed));
+long resourcesPerSecond = (vanityResourcesOnStartup.get() *
TimeUnit.SECONDS.toNanos(1) / (initElapsed == 0 ? 1 : initElapsed));
+log.info(
+"vanity path initialization - end, processed {}
resources with sling:vanityPath properties in {}ms (~{} resource/s)",
Review Comment:
instead of "end" I would prefer "completed" (IMO it's a bit more
descriptive).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (SLING-12227) Status printer does not properly display array values
[
https://issues.apache.org/jira/browse/SLING-12227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-12227.
--
Assignee: Carsten Ziegeler
Resolution: Fixed
https://github.com/apache/sling-org-apache-sling-rewriter/commit/a557549c07324aa0ec5797aba8181ade51731888
Also fixed the toString() method which suffered from the same problem
> Status printer does not properly display array values
> -
>
> Key: SLING-12227
> URL: https://issues.apache.org/jira/browse/SLING-12227
> Project: Sling
> Issue Type: Improvement
> Components: General
>Affects Versions: Rewriter 1.3.6
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.8
>
>
> The status printer for the pipeline components does not properly display
> array values, for example the current output looks like this:
> {noformat}
> Pipeline :
> Generator :
> htmlparser : {includeTags=[Ljava.lang.String;@19a2db46}
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved SLING-12225. Fix Version/s: Resource Resolver 1.11.6 Resolution: Fixed System properties removed. https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/56507f067ce057240ba9abdd2e8663b9206ef456 > resource resolver: revise documentation and naming of system properties for > query paging > > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: Resource Resolver 1.11.6 > > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12225: remove system properties for setting query page size [sling-org-apache-sling-resourceresolver]
reschke merged PR #113: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
