Re: [PR] Bump gson from 2.8.6 to 2.8.9 [sling-org-apache-sling-feature-cpconverter]
sonarcloud[bot] commented on PR #137: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/137#issuecomment-1961766683 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=137) **Quality Gate passed** Issues ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=true) Measures ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=137=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=137) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] issue/binary indexing [sling-org-apache-sling-feature-cpconverter]
sonarcloud[bot] commented on PR #174: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/174#issuecomment-1961765971 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=174) **Quality Gate passed** Issues ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=174=false=true) Measures ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=174=false=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=174) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1961317550 @sufyanharoon - thanks for the PR. You asked me about > Detected JDK version 11.0.16-1 (JAVA_HOME=/usr/local/asfpackages/java/adoptium-jdk-11.0.16.1+1) is not in the allowed range [17,). But this does not seem to be a problem anymore. It would be great if you could remove the whitespace changes, there seem to be a lots of those and it's making the change hard to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12254) jcr:data node missing for file resources generated in binaries index defintions
[ https://issues.apache.org/jira/browse/SLING-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820049#comment-17820049 ] Robert Munteanu commented on SLING-12254: - Thanks for the contribution [~abhigarg]! > jcr:data node missing for file resources generated in binaries index > defintions > --- > > Key: SLING-12254 > URL: https://issues.apache.org/jira/browse/SLING-12254 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.4 >Reporter: Abhishek Garg >Assignee: Abhishek Garg >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.6 > > > The index definition files generated by the cpcconvertor are missing > mandatory jcr:data nodes. > How the resource should look: > {code:java} > "tika": { > "jcr:primaryType": "nam:nt:unstructured", > "config.xml": { > "jcr:primaryType": "nam:nt:file", > "jcr:content": { > "jcr:primaryType": "nam:nt:unstructured", > "jcr:mimeType": "text/xml" > } > } > } > {code} > > How it looks like now: > {code:java} > "tika": { > "jcr:primaryType": "nam:nt:unstructured", > "config.xml": { > "jcr:primaryType": "nam:nt:file", > > "jcr:content": { > "jcr:primaryType": "nam:nt:unstructured", > "jcr:mimeType": "text/xml", > "jcr:data": "" > } > } > } {code} > There is no `jcr:data` node present > This happens when node structure is like: > {code:java} > > > jcr:primaryType="nt:unstructured" > jcr:mimeType="text/xml"/> > > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12254) jcr:data node missing for file resources generated in binaries index defintions
[ https://issues.apache.org/jira/browse/SLING-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12254. - Fix Version/s: Content-Package to Feature Model Converter 1.3.6 Resolution: Fixed > jcr:data node missing for file resources generated in binaries index > defintions > --- > > Key: SLING-12254 > URL: https://issues.apache.org/jira/browse/SLING-12254 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.4 >Reporter: Abhishek Garg >Assignee: Abhishek Garg >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.6 > > > The index definition files generated by the cpcconvertor are missing > mandatory jcr:data nodes. > How the resource should look: > {code:java} > "tika": { > "jcr:primaryType": "nam:nt:unstructured", > "config.xml": { > "jcr:primaryType": "nam:nt:file", > "jcr:content": { > "jcr:primaryType": "nam:nt:unstructured", > "jcr:mimeType": "text/xml" > } > } > } > {code} > > How it looks like now: > {code:java} > "tika": { > "jcr:primaryType": "nam:nt:unstructured", > "config.xml": { > "jcr:primaryType": "nam:nt:file", > > "jcr:content": { > "jcr:primaryType": "nam:nt:unstructured", > "jcr:mimeType": "text/xml", > "jcr:data": "" > } > } > } {code} > There is no `jcr:data` node present > This happens when node structure is like: > {code:java} > > > jcr:primaryType="nt:unstructured" > jcr:mimeType="text/xml"/> > > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12254 handling jcr:data node missing for file resources generated in binaries index defintions [sling-org-apache-sling-feature-cpconverter]
rombert merged PR #175: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-12254) jcr:data node missing for file resources generated in binaries index defintions
[ https://issues.apache.org/jira/browse/SLING-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12254: --- Assignee: Abhishek Garg > jcr:data node missing for file resources generated in binaries index > defintions > --- > > Key: SLING-12254 > URL: https://issues.apache.org/jira/browse/SLING-12254 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.4 >Reporter: Abhishek Garg >Assignee: Abhishek Garg >Priority: Major > > The index definition files generated by the cpcconvertor are missing > mandatory jcr:data nodes. > How the resource should look: > {code:java} > "tika": { > "jcr:primaryType": "nam:nt:unstructured", > "config.xml": { > "jcr:primaryType": "nam:nt:file", > "jcr:content": { > "jcr:primaryType": "nam:nt:unstructured", > "jcr:mimeType": "text/xml" > } > } > } > {code} > > How it looks like now: > {code:java} > "tika": { > "jcr:primaryType": "nam:nt:unstructured", > "config.xml": { > "jcr:primaryType": "nam:nt:file", > > "jcr:content": { > "jcr:primaryType": "nam:nt:unstructured", > "jcr:mimeType": "text/xml", > "jcr:data": "" > } > } > } {code} > There is no `jcr:data` node present > This happens when node structure is like: > {code:java} > > > jcr:primaryType="nt:unstructured" > jcr:mimeType="text/xml"/> > > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)