Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2131554764 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2131550683 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [55.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.13 [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/49#issuecomment-2131547814 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=49) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=49=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=49=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=49=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=49=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=49) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131368553 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) **Quality Gate failed** Failed conditions  [56.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_coverage=list) (required ≥ 80%)  [9.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_duplicated_lines_density=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
kwin commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614785674 ## pom.xml: ## @@ -41,27 +41,133 @@ Apache Sling Scripting HTL Compiler - -The Apache Sling Scripting HTL Compiler provides support for compiling HTML Template Language scripts into an Abstract -Syntax Tree. - +The Apache Sling Scripting HTL Compiler provides support for compiling HTML Template Language scripts into an Abstract +Syntax Tree. scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-scripting-sightly-compiler.git scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-scripting-sightly-compiler.git - https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler.git org.apache.sling.scripting.sightly.compiler-1.2.6-1.4.0 + https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler.git Review Comment: I would suggest setting an explicit java bytecode version (no need to upgrade > 8 for now) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
csaboka commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131315388 Well, now I get the blame for all the code duplication and missing coverage on the code I "touched". I hope that isn't a blocker for merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131313550 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) **Quality Gate failed** Failed conditions  [55.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_coverage=list) (required ≥ 80%)  [9.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_duplicated_lines_density=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
csaboka commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614722374 ## pom.xml: ## @@ -25,7 +25,7 @@ org.apache.sling sling-bundle-parent -44 +52 Review Comment: Oh, after reading the linked page I can see that it still targets JDK 11, but requires JDK 17+ for the build process. I'll have a try at it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
csaboka commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614720582 ## pom.xml: ## @@ -25,7 +25,7 @@ org.apache.sling sling-bundle-parent -44 +52 Review Comment: The latest parent only builds with Java 17 or later. Is that OK? Aren't there any clients that need to run on JDK 11? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
kwin commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614687706 ## pom.xml: ## @@ -25,7 +25,7 @@ org.apache.sling sling-bundle-parent -44 +52 Review Comment: Can you update to latest? There are hints on what you need to consider in https://cwiki.apache.org/confluence/x/SI75E -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131264743 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling Repoinit JCR 1.1.48
Hi, We solved 3 issues in the Apache Sling Repoinit JCR 1.1.48 release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353873=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2862/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2862 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ]0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Julian
[jira] [Resolved] (SLING-12323) [RepoInit] Avoid java.nio.file.Path for parsing repository paths
[
https://issues.apache.org/jira/browse/SLING-12323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding resolved SLING-12323.
Fix Version/s: Repoinit JCR 1.1.48
Resolution: Fixed
> [RepoInit] Avoid java.nio.file.Path for parsing repository paths
>
>
> Key: SLING-12323
> URL: https://issues.apache.org/jira/browse/SLING-12323
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.46
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Major
> Fix For: Repoinit JCR 1.1.48
>
>
> RepoInit uses {{java.nio.file.Path}} to determine the "parent path" and
> "name" of a relative repository path. This fails on Windows when the relative
> repository path contains a colon ":".
> The implementation should not be platform dependent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
