Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2134102353 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [55.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2134099708 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12328) Metric for number of seconds current package import is running
Christian Schneider created SLING-12328: --- Summary: Metric for number of seconds current package import is running Key: SLING-12328 URL: https://issues.apache.org/jira/browse/SLING-12328 Project: Sling Issue Type: Improvement Components: Content Distribution Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution Journal Core 0.4.0 In some cases the call to apply a content package can take very long or even not return at all. We should expose a metric that shows the seconds the current package import took already. This allows detect from the outside when a package import is stuck. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12327) Use async to send package distributed event
Christian Schneider created SLING-12327: --- Summary: Use async to send package distributed event Key: SLING-12327 URL: https://issues.apache.org/jira/browse/SLING-12327 Project: Sling Issue Type: Bug Components: Content Distribution Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution Journal Core 0.4.0 We had an issue where a customer implemented an event handler for org/apache/sling/distribution/agent/package/distributed The event handler did not return in some cases and caused the whole update on queues to stop working. We should use postEvent to make sure we do not get blocked by customer event handlers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Fix section title [sling-site]
rombert merged PR #165: URL: https://github.com/apache/sling-site/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix section title [sling-site]
paulochang opened a new pull request, #165: URL: https://github.com/apache/sling-site/pull/165 The "Passing parameters to Javascript Use-Objects" section had some extra # in its formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Repoinit JCR 1.1.48
+1 Am Sa., 25. Mai 2024 um 11:55 Uhr schrieb Julian Sedding : > Hi, > > We solved 3 issues in the Apache Sling Repoinit JCR 1.1.48 release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353873=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2862/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: sh check_staged_release.sh 2862 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ]0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Julian > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Repoinit JCR 1.1.48
+1 On Sat, 25 May 2024 at 11:54, Julian Sedding wrote: > Please vote to approve this release: > > [ ] +1 Approve the release > [ ]0 Don't care > [ ] -1 Don't release, because ...
[jira] [Closed] (SLING-12320) Add support for retrieving a service resource resolver with impersonation without requiring extra configuration
[ https://issues.apache.org/jira/browse/SLING-12320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-12320. > Add support for retrieving a service resource resolver with impersonation > without requiring extra configuration > --- > > Key: SLING-12320 > URL: https://issues.apache.org/jira/browse/SLING-12320 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: JCR Resource 3.3.2 > > > SLING-4888 simplified retrieving impersonated sessions from service users, > however the JCR Resource Provider seems to still use the approach before this > improvement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling JCR Resource 3.3.2
Hi, The vote has passed with the following result: +1 (binding): Radu Cotescu, Robert Munteanu, Stefan Seifert, Joerg Hoh +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Radu Cotescu
[jira] [Resolved] (SLING-12326) SocketExceptions are no longer handled as error
[ https://issues.apache.org/jira/browse/SLING-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12326. --- Resolution: Fixed > SocketExceptions are no longer handled as error > --- > > Key: SLING-12326 > URL: https://issues.apache.org/jira/browse/SLING-12326 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.8, Engine 2.15.10, Engine 2.15.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > > [This > commit|https://github.com/apache/sling-org-apache-sling-engine/commit/8ab96759cd435520a228271fbbb9d37955954c80] > introduced a special handling for SocketExceptions under the assumptions > that the only Socket Exceptions can happen when Sling/Jetty fails to stream > back the response to the client (browser). > But there are other types of SocketExceptions, which can happen during page > rendering, e.g. when a Servlet/Script does connections on its own, for > example to fetch data from a backend system. If these exceptions are wrapped > and thrown, it could lead to a situation, that the error handling in this > place is actually not kicking in at all, and also no logging for this > exception is done at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12326 remove the special handling for SocketExceptions [sling-org-apache-sling-engine]
joerghoh merged PR #47: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12321) Update parent pom to latest
[ https://issues.apache.org/jira/browse/SLING-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12321: -- Fix Version/s: Engine 2.15.16 (was: Engine 2.16.0) > Update parent pom to latest > --- > > Key: SLING-12321 > URL: https://issues.apache.org/jira/browse/SLING-12321 > Project: Sling > Issue Type: Task > Components: Engine >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > > Updating to parent 60 an force the result to be runable with Java 8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12317) Make Sling Engine build with Java 21
[
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12317:
--
Fix Version/s: Engine 2.15.16
(was: Engine 2.16.0)
> Make Sling Engine build with Java 21
>
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> {noformat}[ERROR]
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
> Time elapsed: 0 s <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
> at
> java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
> at org.jmock.Mockery.mock(Mockery.java:167)
> at org.jmock.Mockery.mock(Mockery.java:143)
> at
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12316) Servlet Name might be set incorrectly after an exception
[
https://issues.apache.org/jira/browse/SLING-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12316:
--
Fix Version/s: Engine 2.15.16
(was: Engine 2.16.0)
> Servlet Name might be set incorrectly after an exception
>
>
> Key: SLING-12316
> URL: https://issues.apache.org/jira/browse/SLING-12316
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> In case an exception happens, the name is not reset properly:
> [https://github.com/apache/sling-org-apache-sling-engine/blob/ad11b3b108764312e6db87aea7de18c3fa00db34/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L553]
> {{requestData.setActiveServletName(callerServlet);}} must be moved into the
> finally block
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] SLING-12321 update parent to 60 [sling-org-apache-sling-engine]
joerghoh merged PR #46: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12326) SocketExceptions are no longer handled as error
[ https://issues.apache.org/jira/browse/SLING-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12326: -- Fix Version/s: Engine 2.15.16 > SocketExceptions are no longer handled as error > --- > > Key: SLING-12326 > URL: https://issues.apache.org/jira/browse/SLING-12326 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.8, Engine 2.15.10, Engine 2.15.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > > [This > commit|https://github.com/apache/sling-org-apache-sling-engine/commit/8ab96759cd435520a228271fbbb9d37955954c80] > introduced a special handling for SocketExceptions under the assumptions > that the only Socket Exceptions can happen when Sling/Jetty fails to stream > back the response to the client (browser). > But there are other types of SocketExceptions, which can happen during page > rendering, e.g. when a Servlet/Script does connections on its own, for > example to fetch data from a backend system. If these exceptions are wrapped > and thrown, it could lead to a situation, that the error handling in this > place is actually not kicking in at all, and also no logging for this > exception is done at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12326) SocketExceptions are no longer handled as error
[ https://issues.apache.org/jira/browse/SLING-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12326: - Assignee: Joerg Hoh > SocketExceptions are no longer handled as error > --- > > Key: SLING-12326 > URL: https://issues.apache.org/jira/browse/SLING-12326 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.8, Engine 2.15.10, Engine 2.15.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > [This > commit|https://github.com/apache/sling-org-apache-sling-engine/commit/8ab96759cd435520a228271fbbb9d37955954c80] > introduced a special handling for SocketExceptions under the assumptions > that the only Socket Exceptions can happen when Sling/Jetty fails to stream > back the response to the client (browser). > But there are other types of SocketExceptions, which can happen during page > rendering, e.g. when a Servlet/Script does connections on its own, for > example to fetch data from a backend system. If these exceptions are wrapped > and thrown, it could lead to a situation, that the error handling in this > place is actually not kicking in at all, and also no logging for this > exception is done at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] SLING-12326 remove the special handling for SocketExceptions [sling-org-apache-sling-engine]
joerghoh opened a new pull request, #47: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/47 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Repoinit JCR 1.1.48
On Sat, 2024-05-25 at 11:53 +0200, Julian Sedding wrote: > Please vote to approve this release: +1 Robert P.S. Would be great to upgrade the build to work with Java 17 or newer. Many tests fail with java.lang.ClassNotFoundException: java.security.acl.Group signature.asc Description: This is a digitally signed message part
[jira] [Created] (SLING-12326) SocketExceptions are no longer handled as error
Joerg Hoh created SLING-12326: - Summary: SocketExceptions are no longer handled as error Key: SLING-12326 URL: https://issues.apache.org/jira/browse/SLING-12326 Project: Sling Issue Type: Task Components: Engine Affects Versions: Engine 2.15.14, Engine 2.15.10, Engine 2.15.8 Reporter: Joerg Hoh [This commit|https://github.com/apache/sling-org-apache-sling-engine/commit/8ab96759cd435520a228271fbbb9d37955954c80] introduced a special handling for SocketExceptions under the assumptions that the only Socket Exceptions can happen when Sling/Jetty fails to stream back the response to the client (browser). But there are other types of SocketExceptions, which can happen during page rendering, e.g. when a Servlet/Script does connections on its own, for example to fetch data from a backend system. If these exceptions are wrapped and thrown, it could lead to a situation, that the error handling in this place is actually not kicking in at all, and also no logging for this exception is done at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] chore(deps): update dependency org.apache.servicemix.bundles:org.apache.servicemix.bundles.rhino to v1.7.15_1 [sling-org-apache-sling-starter]
rombert merged PR #329: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.13 [sling-org-apache-sling-jcr-repoinit]
jsedding merged PR #49: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
