[jira] [Updated] (SLING-12363) ServerErrorRetryStrategy throws ClassCastException for BasicHttpRequest (not assignable to HttpRequestWrapper)
[
https://issues.apache.org/jira/browse/SLING-12363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Adamcin updated SLING-12363:
-
Description:
Relates to SLING-11748 .
[https://github.com/apache/sling-org-apache-sling-testing-clients/pull/42]
During a network outage, some executions of integration tests using SlingClient
started failing with the following stack trace:
{code:java}
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 327.4 s
<<< FAILURE! -- in com.adobe.cq.cloud.testing.it.smoke.PublishEndToEndIT
[ERROR]
com.adobe.cq.cloud.testing.it.smoke.PublishEndToEndIT.testActivateAndDeactivate
-- Time elapsed: 327.2 s <<< ERROR!
java.lang.ClassCastException: Cannot cast
org.apache.http.message.BasicHttpRequest to
org.apache.http.client.methods.HttpRequestWrapper
at java.base/java.lang.Class.cast(Class.java:3889)
at
org.apache.http.protocol.HttpCoreContext.getAttribute(HttpCoreContext.java:119)
at
org.apache.sling.testing.clients.util.ServerErrorRetryStrategy.getRequestDetails(ServerErrorRetryStrategy.java:96)
at
org.apache.sling.testing.clients.util.ServerErrorRetryStrategy.retryRequest(ServerErrorRetryStrategy.java:58)
at
org.apache.http.impl.execchain.ServiceUnavailableRetryExec.execute(ServiceUnavailableRetryExec.java:88)
at
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
at
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:72)
at
org.apache.sling.testing.clients.interceptors.FormBasedAuthInterceptor.doLogin(FormBasedAuthInterceptor.java:141)
at
org.apache.sling.testing.clients.interceptors.FormBasedAuthInterceptor.process(FormBasedAuthInterceptor.java:80)
at
org.apache.http.protocol.ImmutableHttpProcessor.process(ImmutableHttpProcessor.java:133)
at
org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
at
org.apache.http.impl.execchain.ServiceUnavailableRetryExec.execute(ServiceUnavailableRetryExec.java:85)
at
org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
at
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
at
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
at
org.apache.sling.testing.clients.AbstractSlingClient.execute(AbstractSlingClient.java:698)
at
org.apache.sling.testing.clients.AbstractSlingClient.doStreamRequest(AbstractSlingClient.java:326)
at
org.apache.sling.testing.clients.AbstractSlingClient.doStreamGet(AbstractSlingClient.java:440)
at
org.apache.sling.testing.clients.AbstractSlingClient.doGet(AbstractSlingClient.java:503)
at
org.apache.sling.testing.clients.AbstractSlingClient.doGet(AbstractSlingClient.java:539)
at
org.apache.sling.testing.clients.SlingClient.exists(SlingClient.java:202)
at com.adobe.cq.testing.junit.rules.Page.prepare(Page.java:151)
at com.adobe.cq.testing.junit.rules.Page.before(Page.java:82) {code}
The type expected by
[getRequestDetails()|https://github.com/apache/sling-org-apache-sling-testing-clients/blob/da878173581fd2a8f667b365de0fd05318b12443/src/main/java/org/apache/sling/testing/clients/util/ServerErrorRetryStrategy.java#L96]
should probably be changed from HttpRequestWrapper to
{{{}org.apache.http.HttpRequest{}}}, which is a common interface for both
BasicHttpRequest and HttpRequestWrapper, and which happens to define the
getRequestLine() method .
was:
Relates to SLING-11748 .
[https://github.com/apache/sling-org-apache-sling-testing-clients/pull/42]
During a network outage, some executions of integration tests using SlingClient
started failing with the following stack trace:
{code:java}
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 327.4 s
<<< FAILURE! -- in com.adobe.cq.cloud.testing.it.smoke.PublishEndToEndIT
[ERROR]
com.adobe.cq.cloud.testing.it.smoke.PublishEndToEndIT.testActivateAndDeactivate
-- Time elapsed: 327.2 s <<< ERROR!
java.lang.ClassCastException: Cannot cast
org.apache.http.message.BasicHttpRequest to
org.apache.http.client.methods.HttpRequestWrapper
at java.base/java.lang.Class.cast(Class.java:3889)
at
org.apache.http.protocol.HttpCoreContext.getAttribute(HttpCoreContext.java:119)
at
org.apache.sling.testing.clients.util.ServerErrorRetryStrategy.getRequestDetails(ServerErrorRetryStrategy.java:96)
at
org.apache.sling.testing.clients.util.ServerErrorRetryStrategy.retryRequest(ServerErrorRetryStrategy.java:58)
at
org.apache.http.impl.execchain.ServiceUnavailableRetryExec.execute(ServiceUnavailableRetryExec.java:88)
at
[jira] [Created] (SLING-12363) ServerErrorRetryStrategy throws ClassCastException for BasicHttpRequest (not assignable to HttpRequestWrapper)
Mark Adamcin created SLING-12363:
Summary: ServerErrorRetryStrategy throws ClassCastException for
BasicHttpRequest (not assignable to HttpRequestWrapper)
Key: SLING-12363
URL: https://issues.apache.org/jira/browse/SLING-12363
Project: Sling
Issue Type: Bug
Components: Apache Sling Testing Clients
Affects Versions: Apache Sling Testing Clients 3.0.24, Apache Sling Testing
Clients 3.0.22, Apache Sling Testing Clients 3.0.20
Reporter: Mark Adamcin
Relates to SLING-11748 .
[https://github.com/apache/sling-org-apache-sling-testing-clients/pull/42]
During a network outage, some executions of integration tests using SlingClient
started failing with the following stack trace:
{code:java}
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 327.4 s
<<< FAILURE! -- in com.adobe.cq.cloud.testing.it.smoke.PublishEndToEndIT
[ERROR]
com.adobe.cq.cloud.testing.it.smoke.PublishEndToEndIT.testActivateAndDeactivate
-- Time elapsed: 327.2 s <<< ERROR!
java.lang.ClassCastException: Cannot cast
org.apache.http.message.BasicHttpRequest to
org.apache.http.client.methods.HttpRequestWrapper
at java.base/java.lang.Class.cast(Class.java:3889)
at
org.apache.http.protocol.HttpCoreContext.getAttribute(HttpCoreContext.java:119)
at
org.apache.sling.testing.clients.util.ServerErrorRetryStrategy.getRequestDetails(ServerErrorRetryStrategy.java:96)
at
org.apache.sling.testing.clients.util.ServerErrorRetryStrategy.retryRequest(ServerErrorRetryStrategy.java:58)
at
org.apache.http.impl.execchain.ServiceUnavailableRetryExec.execute(ServiceUnavailableRetryExec.java:88)
at
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
at
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:72)
at
org.apache.sling.testing.clients.interceptors.FormBasedAuthInterceptor.doLogin(FormBasedAuthInterceptor.java:141)
at
org.apache.sling.testing.clients.interceptors.FormBasedAuthInterceptor.process(FormBasedAuthInterceptor.java:80)
at
org.apache.http.protocol.ImmutableHttpProcessor.process(ImmutableHttpProcessor.java:133)
at
org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
at
org.apache.http.impl.execchain.ServiceUnavailableRetryExec.execute(ServiceUnavailableRetryExec.java:85)
at
org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
at
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
at
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
at
org.apache.sling.testing.clients.AbstractSlingClient.execute(AbstractSlingClient.java:698)
at
org.apache.sling.testing.clients.AbstractSlingClient.doStreamRequest(AbstractSlingClient.java:326)
at
org.apache.sling.testing.clients.AbstractSlingClient.doStreamGet(AbstractSlingClient.java:440)
at
org.apache.sling.testing.clients.AbstractSlingClient.doGet(AbstractSlingClient.java:503)
at
org.apache.sling.testing.clients.AbstractSlingClient.doGet(AbstractSlingClient.java:539)
at
org.apache.sling.testing.clients.SlingClient.exists(SlingClient.java:202)
at com.adobe.cq.testing.junit.rules.Page.prepare(Page.java:151)
at com.adobe.cq.testing.junit.rules.Page.before(Page.java:82) {code}
The type expected by
[getRequestDetails()|https://github.com/apache/sling-org-apache-sling-testing-clients/blob/da878173581fd2a8f667b365de0fd05318b12443/src/main/java/org/apache/sling/testing/clients/util/ServerErrorRetryStrategy.java#L100]
should probably be changed from HttpRequestWrapper to
{{{}org.apache.http.HttpRequest{}}}, which is a common interface for both
BasicHttpRequest and HttpRequestWrapper, and which happens to define the
getRequestLine() method .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Release of Content Distribution Journal Core 0.4.0 soon?
I plan to release this module soon. Please speak up if you want to get a change in on short notice. https://issues.apache.org/jira/projects/SLING/versions/12354121 Christian
[jira] [Resolved] (SLING-12362) Update to version 2.0.8 of the feature model analysers
[ https://issues.apache.org/jira/browse/SLING-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12362. - Resolution: Fixed > Update to version 2.0.8 of the feature model analysers > -- > > Key: SLING-12362 > URL: https://issues.apache.org/jira/browse/SLING-12362 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Minor > Fix For: OSGi Feature Maven Plugin 1.8.6 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12362) Update to version 2.0.8 of the feature model analysers
Robert Munteanu created SLING-12362: --- Summary: Update to version 2.0.8 of the feature model analysers Key: SLING-12362 URL: https://issues.apache.org/jira/browse/SLING-12362 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: OSGi Feature Maven Plugin 1.8.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12305) Build fails on Java 21 due to invoker plug-in: Unsupported class file major version 65
[
https://issues.apache.org/jira/browse/SLING-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-12305.
---
> Build fails on Java 21 due to invoker plug-in: Unsupported class file major
> version 65
> --
>
> Key: SLING-12305
> URL: https://issues.apache.org/jira/browse/SLING-12305
> Project: Sling
> Issue Type: Bug
>Affects Versions: OSGi Feature Maven Plugin 1.8.0
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.4
>
>
> The invoker plugin-ins runs groovy scripts in the {{verify}} goal, and this
> fails on Java 21 with
> {noformat}
> [INFO] --- invoker:3.5.1:integration-test (integration-test) @
> slingfeature-maven-plugin ---
> [INFO] Building: analyzer-apiregions-errors-detected/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] BUG! exception in phase 'semantic analysis' in source unit
> 'Script1.groovy' Unsupported class file major version 65
> [INFO] analyzer-apiregions-errors-detected/pom.xml .. FAILED
> (3.0 s)
> {noformat}
> The stack trace seems to indicate that Groovy tries to parse Java 21 bytecode
> and fails.
> {noformat}
> Caused by: java.lang.IllegalArgumentException: Unsupported class file major
> version 65
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:199)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:180)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:166)
> at groovyjarjarasm.asm.ClassReader.(ClassReader.java:287)
> at
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12355) Use the TemporaryFolder JUnit rule instead of manually managing temp directories
[ https://issues.apache.org/jira/browse/SLING-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12355. --- > Use the TemporaryFolder JUnit rule instead of manually managing temp > directories > > > Key: SLING-12355 > URL: https://issues.apache.org/jira/browse/SLING-12355 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.8.4 > > > We use less code and also we don't have to remember to clean up in each test > (we missed a couple). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12354) Set sling.java.version to 11
[ https://issues.apache.org/jira/browse/SLING-12354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12354. --- > Set sling.java.version to 11 > > > Key: SLING-12354 > URL: https://issues.apache.org/jira/browse/SLING-12354 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.8.4 > > > The project already uses dependencies that require Java 11: mockito 5.3 and > Johnzon. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12356) Allow configuring additional post process handlers
[ https://issues.apache.org/jira/browse/SLING-12356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-12356. --- > Allow configuring additional post process handlers > -- > > Key: SLING-12356 > URL: https://issues.apache.org/jira/browse/SLING-12356 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.8.4 > > > We should allow configuring PostProcessHandler instances that are not > available by default through the ServiceLoader. See SLING-12353 for an > example. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.8.4
Hi, The vote has passed with the following result: +1 (binding): Stefan Seifert, Robert Munteanu, Joerg Hoh +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
[jira] [Closed] (SLING-12351) Create a default implementation for generating the analyser-metadata extension
[
https://issues.apache.org/jira/browse/SLING-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-12351.
---
> Create a default implementation for generating the analyser-metadata extension
> --
>
> Key: SLING-12351
> URL: https://issues.apache.org/jira/browse/SLING-12351
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model Analyser
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 2.0.8
>
>
> The feature model analysers contains and use the
> {{AnalyserMetaDataExtension}} -
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/c8518ebd7c8fa245781ad8062f2c2d6b52174345/src/main/java/org/apache/sling/feature/analyser/extensions/AnalyserMetaDataExtension.java
> .
> This class is read and used (error reporting, cached manifests) but there is
> currently no automated way of generating the metadata.
> We should provide a default implementation that simplifies the metadata
> generation. The same implementation should also support generating the
> framework capabilities metadata as discussed in SLING-10288 .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-10288) FelixFrameworkScanner sets framework properties always for current Java version
[
https://issues.apache.org/jira/browse/SLING-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-10288.
---
> FelixFrameworkScanner sets framework properties always for current Java
> version
> ---
>
> Key: SLING-10288
> URL: https://issues.apache.org/jira/browse/SLING-10288
> Project: Sling
> Issue Type: Bug
> Components: Feature Model Analyser
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 2.0.8
>
>
> Sometimes the analyser is executed with a different java version than the one
> executing the actual OSGi container. There should be a possibility to
> explicitly set a Java version.
> Currently the framework properties are gathered in a dedicated java process
> executing
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/730b7d3297ab9f17f484e7b557e4ec47c3d9b3e9/src/main/java/org/apache/sling/feature/scanner/impl/fwk/FrameworkPropertiesGatherer.java#L41.
> That new process always takes the current {{java.home}} which therefore
> returns the wrong properties (i.e. the ones for the current java version
> instead of the one used to execute the framework).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12353) The AnalyserMetadataHandler is executed too often
[
https://issues.apache.org/jira/browse/SLING-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-12353.
---
> The AnalyserMetadataHandler is executed too often
> -
>
> Key: SLING-12353
> URL: https://issues.apache.org/jira/browse/SLING-12353
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model Analyser
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 2.0.8
>
>
> Consider the following scenario:
> 1. In feature A, the analyser-metadata extension is configured with:
> {code}
> {
> "analyser-metadata:JSON|true":
> {
> "org.apache.sling:org.apache.sling.api:2.0.6" : {
> "manifest": null,
> "report": {
> "error": false,
> "warning": false
> }
> }
> }
> {code}
> 2. During aggregation, feature A is processed with the analyser-metadata
> extension, resulting in feature B.
> This will result in a the "report" key being retained but not the manifest.
> 3. At a later point, feature B is aggregated again, resulting in feature C.
> During the aggregation process, the manifest will be cached because the
> {{"manifest": null}} key was not preserved during the first aggregation. This
> is unexpected and should be fixed.
> The metadata handler will no longer be registered for being picked up by the
> ServiceLoader and must instead be configured manually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Feature Model Analyser 2.0.8
Hi, The vote has passed with the following result: +1 (binding): Stefan Seifert, Robert Munteanu, Joerg Hoh +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
[jira] [Closed] (SLING-12329) Backwards compatibility for legacy repoinit statement reordering
[ https://issues.apache.org/jira/browse/SLING-12329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed SLING-12329. -- > Backwards compatibility for legacy repoinit statement reordering > > > Key: SLING-12329 > URL: https://issues.apache.org/jira/browse/SLING-12329 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Julian Sedding >Assignee: Julian Sedding >Priority: Minor > Fix For: Repoinit JCR 1.1.50 > > > The fix for repoinit statement reordering can cause issues for users relying > on the legacy ordering. > We should support a fallback to the legacy ordering and log a deprecation > message, warning users that their repoinit script relies on the legacy > ordering, support for which may be removed in the future. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Repoinit JCR 1.1.50
Hi, The vote has passed with the following result: +1 (binding): Joerg Hoh, Eric Norman, Andrei Dulvac, Julian Sedding +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards Julian
Re: [VOTE] Release Apache Sling Models API 1.5.2, Models Implementation 1.7.0
+1 Am Di., 25. Juni 2024 um 17:08 Uhr schrieb Stefan Seifert : > Hi, > > Models API 1.5.2 (3 issues) > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353054=Text=12310710 > > Models Implementation 1.7.0 (4 issues) > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353296=Text=12310710 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2870/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2870 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan > -- https://cqdump.joerghoh.de
