[jira] [Resolved] (SLING-12322) Stream Reader should Return SC_OK if content length is less than specified range
[
https://issues.apache.org/jira/browse/SLING-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhishek Garg resolved SLING-12322.
---
Resolution: Not A Problem
> Stream Reader should Return SC_OK if content length is less than specified
> range
>
>
> Key: SLING-12322
> URL: https://issues.apache.org/jira/browse/SLING-12322
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Affects Versions: Servlets Get 2.2.0
>Reporter: Abhishek Garg
>Priority: Major
>
> if the Request contains following header :
> {code:java}
> Range: bytes=0-8388607 {code}
> and file length is less than this, then we should return SC_OK(200) instead
> of
> SC_PARTIAL_CONTENT(206).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12322) Stream Reader should Return SC_OK if content length is less than specified range
[
https://issues.apache.org/jira/browse/SLING-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848822#comment-17848822
]
Abhishek Garg commented on SLING-12322:
---
This PR was handling the case when the request with the RANGE header and
response size was less than the RANGE HEADER.
Apparently, this is against HTTP RFC
[https://greenbytes.de/tech/webdav/rfc9110.html#field.range]
marking this as closed.
thanks [~kwin]
> Stream Reader should Return SC_OK if content length is less than specified
> range
>
>
> Key: SLING-12322
> URL: https://issues.apache.org/jira/browse/SLING-12322
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Affects Versions: Servlets Get 2.2.0
>Reporter: Abhishek Garg
>Priority: Major
>
> if the Request contains following header :
> {code:java}
> Range: bytes=0-8388607 {code}
> and file length is less than this, then we should return SC_OK(200) instead
> of
> SC_PARTIAL_CONTENT(206).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12322) Stream Reader should Return SC_OK if content length is less than specified range
[
https://issues.apache.org/jira/browse/SLING-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848813#comment-17848813
]
Abhishek Garg commented on SLING-12322:
---
create a draft PR
[https://github.com/apache/sling-org-apache-sling-servlets-get/pull/14]
> Stream Reader should Return SC_OK if content length is less than specified
> range
>
>
> Key: SLING-12322
> URL: https://issues.apache.org/jira/browse/SLING-12322
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Affects Versions: Servlets Get 2.2.0
>Reporter: Abhishek Garg
>Priority: Major
>
> if the Request contains following header :
> {code:java}
> Range: bytes=0-8388607 {code}
> and file length is less than this, then we should return SC_OK(200) instead
> of
> SC_PARTIAL_CONTENT(206).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12322) Stream Reader should Return SC_OK if content length is less than specified range
Abhishek Garg created SLING-12322:
-
Summary: Stream Reader should Return SC_OK if content length is
less than specified range
Key: SLING-12322
URL: https://issues.apache.org/jira/browse/SLING-12322
Project: Sling
Issue Type: Bug
Components: Servlets
Affects Versions: Servlets Get 2.2.0
Reporter: Abhishek Garg
if the Request contains following header :
{code:java}
Range: bytes=0-8388607 {code}
and file length is less than this, then we should return SC_OK(200) instead of
SC_PARTIAL_CONTENT(206).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12254) jcr:data node missing for file resources generated in binaries index defintions
[
https://issues.apache.org/jira/browse/SLING-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818659#comment-17818659
]
Abhishek Garg commented on SLING-12254:
---
PR:[https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/175]
> jcr:data node missing for file resources generated in binaries index
> defintions
> ---
>
> Key: SLING-12254
> URL: https://issues.apache.org/jira/browse/SLING-12254
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Abhishek Garg
>Priority: Major
>
> The index definition files generated by the cpcconvertor are missing
> mandatory jcr:data nodes.
> How the resource should look:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
> "jcr:content": {
> "jcr:primaryType": "nam:nt:unstructured",
> "jcr:mimeType": "text/xml"
> }
> }
> }
> {code}
>
> How it looks like now:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
>
> "jcr:content": {
> "jcr:primaryType": "nam:nt:unstructured",
> "jcr:mimeType": "text/xml",
> "jcr:data": ""
> }
> }
> } {code}
> There is no `jcr:data` node present
> This happens when node structure is like:
> {code:java}
>
>
> jcr:primaryType="nt:unstructured"
> jcr:mimeType="text/xml"/>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12254) jcr:data node missing for file resources generated in binaries index defintions
[
https://issues.apache.org/jira/browse/SLING-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhishek Garg updated SLING-12254:
--
Description:
The index definition files generated by the cpcconvertor are missing mandatory
jcr:data nodes.
How the resource should look:
{code:java}
"tika": {
"jcr:primaryType": "nam:nt:unstructured",
"config.xml": {
"jcr:primaryType": "nam:nt:file",
"jcr:content": {
"jcr:primaryType": "nam:nt:unstructured",
"jcr:mimeType": "text/xml"
}
}
}
{code}
How it looks like now:
{code:java}
"tika": {
"jcr:primaryType": "nam:nt:unstructured",
"config.xml": {
"jcr:primaryType": "nam:nt:file",
"jcr:content": {
"jcr:primaryType": "nam:nt:unstructured",
"jcr:mimeType": "text/xml",
"jcr:data": ""
}
}
} {code}
There is no `jcr:data` node present
This happens when node structure is like:
{code:java}
{code}
was:
The index definition files generated by the cpcconvertor are missing mandatory
jcr:data nodes.
How the resource should look:
{code:java}
"tika": {
"jcr:primaryType": "nam:nt:unstructured",
"config.xml": {
"jcr:primaryType": "nam:nt:file",
"jcr:content": {
"jcr:primaryType": "nam:nt:unstructured",
"jcr:mimeType": "text/xml"
}
}
}
{code}
How it looks like now:
{code:java}
"tika": {
"jcr:primaryType": "nam:nt:unstructured",
"config.xml": {
"jcr:primaryType": "nam:nt:file",
"jcr:data": ""
"jcr:content": {
"jcr:primaryType": "nam:nt:unstructured",
"jcr:mimeType": "text/xml"
}
}
} {code}
There is no `jcr:data` node present
This happens when node structure is like:
{code:java}
{code}
> jcr:data node missing for file resources generated in binaries index
> defintions
> ---
>
> Key: SLING-12254
> URL: https://issues.apache.org/jira/browse/SLING-12254
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Abhishek Garg
>Priority: Major
>
> The index definition files generated by the cpcconvertor are missing
> mandatory jcr:data nodes.
> How the resource should look:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
> "jcr:content": {
> "jcr:primaryType": "nam:nt:unstructured",
> "jcr:mimeType": "text/xml"
> }
> }
> }
> {code}
>
> How it looks like now:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
>
> "jcr:content": {
> "jcr:primaryType": "nam:nt:unstructured",
> "jcr:mimeType": "text/xml",
> "jcr:data": ""
> }
> }
> } {code}
> There is no `jcr:data` node present
> This happens when node structure is like:
> {code:java}
>
>
> jcr:primaryType="nt:unstructured"
> jcr:mimeType="text/xml"/>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12254) jcr:data node missing for file resources generated in binaries index defintions
Abhishek Garg created SLING-12254:
-
Summary: jcr:data node missing for file resources generated in
binaries index defintions
Key: SLING-12254
URL: https://issues.apache.org/jira/browse/SLING-12254
Project: Sling
Issue Type: Bug
Components: Content-Package to Feature Model Converter
Affects Versions: Content-Package to Feature Model Converter 1.3.4
Reporter: Abhishek Garg
The index definition files generated by the cpcconvertor are missing mandatory
jcr:data nodes.
How the resource should look:
{code:java}
"tika": {
"jcr:primaryType": "nam:nt:unstructured",
"config.xml": {
"jcr:primaryType": "nam:nt:file",
"jcr:content": {
"jcr:primaryType": "nam:nt:unstructured",
"jcr:mimeType": "text/xml"
}
}
}
{code}
How it looks like now:
{code:java}
"tika": {
"jcr:primaryType": "nam:nt:unstructured",
"config.xml": {
"jcr:primaryType": "nam:nt:file",
"jcr:data": ""
"jcr:content": {
"jcr:primaryType": "nam:nt:unstructured",
"jcr:mimeType": "text/xml"
}
}
} {code}
There is no `jcr:data` node present
This happens when node structure is like:
{code:java}
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11844) Index definitions must not be extracted from empty nodes
[ https://issues.apache.org/jira/browse/SLING-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731939#comment-17731939 ] Abhishek Garg commented on SLING-11844: --- Added a PR [https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/169] cc : [~rombert] > Index definitions must not be extracted from empty nodes > > > Key: SLING-11844 > URL: https://issues.apache.org/jira/browse/SLING-11844 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Robert Munteanu >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > Under certain conditions, extracted index definitions will contain empty > nodes. These are useless and should be skipped. They can also confuse tooling > processing the index definitions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11844) Index definitions must not be extracted from empty nodes
[ https://issues.apache.org/jira/browse/SLING-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730054#comment-17730054 ] Abhishek Garg commented on SLING-11844: --- Can we get a little more details under which conditions or what the index definitions look like with empty node types and sample input? > Index definitions must not be extracted from empty nodes > > > Key: SLING-11844 > URL: https://issues.apache.org/jira/browse/SLING-11844 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Robert Munteanu >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > Under certain conditions, extracted index definitions will contain empty > nodes. These are useless and should be skipped. They can also confuse tooling > processing the index definitions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11764) jcr:content node missing for file resources generated in binaries index defintions
[
https://issues.apache.org/jira/browse/SLING-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683089#comment-17683089
]
Abhishek Garg commented on SLING-11764:
---
PR:
[https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/155]
cc : [~rombert]
> jcr:content node missing for file resources generated in binaries index
> defintions
> --
>
> Key: SLING-11764
> URL: https://issues.apache.org/jira/browse/SLING-11764
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.26
>Reporter: Abhishek Garg
>Assignee: Abhishek Garg
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.26
>
>
> The index definition files generated by the cpcconvertor are missing
> mandatory jcr:content nodes.
> How the resource should look:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
> "jcr:content": {
> "jcr:mimeType": "text/xml",
> "jcr:data": ":blobId:",
> "jcr:primaryType": "nam:nt:resource"
> }
> }
> }
> {code}
>
> How it looks like now:
> {code:java}
> "tika":{
> "jcr:primaryType":"nam:nt:unstructured",
> "config.xml":{
> "jcr:primaryType":"nam:nt:file",
> "jcr:data":":blobid:"
> }
> }{code}
>
> there is no jcr:content node present
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11764) jcr:content node missing for file resources generated in binaries index defintions
[
https://issues.apache.org/jira/browse/SLING-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683082#comment-17683082
]
Abhishek Garg edited comment on SLING-11764 at 2/1/23 4:32 PM:
---
jcr:primaryType is still missing from index definitions.
was (Author: abhigarg):
jcr
> jcr:content node missing for file resources generated in binaries index
> defintions
> --
>
> Key: SLING-11764
> URL: https://issues.apache.org/jira/browse/SLING-11764
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.26
>Reporter: Abhishek Garg
>Assignee: Abhishek Garg
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.26
>
>
> The index definition files generated by the cpcconvertor are missing
> mandatory jcr:content nodes.
> How the resource should look:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
> "jcr:content": {
> "jcr:mimeType": "text/xml",
> "jcr:data": ":blobId:",
> "jcr:primaryType": "nam:nt:resource"
> }
> }
> }
> {code}
>
> How it looks like now:
> {code:java}
> "tika":{
> "jcr:primaryType":"nam:nt:unstructured",
> "config.xml":{
> "jcr:primaryType":"nam:nt:file",
> "jcr:data":":blobid:"
> }
> }{code}
>
> there is no jcr:content node present
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (SLING-11764) jcr:content node missing for file resources generated in binaries index defintions
[
https://issues.apache.org/jira/browse/SLING-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhishek Garg reopened SLING-11764:
---
jcr
> jcr:content node missing for file resources generated in binaries index
> defintions
> --
>
> Key: SLING-11764
> URL: https://issues.apache.org/jira/browse/SLING-11764
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.26
>Reporter: Abhishek Garg
>Assignee: Abhishek Garg
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.26
>
>
> The index definition files generated by the cpcconvertor are missing
> mandatory jcr:content nodes.
> How the resource should look:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
> "jcr:content": {
> "jcr:mimeType": "text/xml",
> "jcr:data": ":blobId:",
> "jcr:primaryType": "nam:nt:resource"
> }
> }
> }
> {code}
>
> How it looks like now:
> {code:java}
> "tika":{
> "jcr:primaryType":"nam:nt:unstructured",
> "config.xml":{
> "jcr:primaryType":"nam:nt:file",
> "jcr:data":":blobid:"
> }
> }{code}
>
> there is no jcr:content node present
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11764) jcr:content node missing for file resources generated in binaries index defintions
[
https://issues.apache.org/jira/browse/SLING-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682983#comment-17682983
]
Abhishek Garg commented on SLING-11764:
---
PR:[https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/154]
> jcr:content node missing for file resources generated in binaries index
> defintions
> --
>
> Key: SLING-11764
> URL: https://issues.apache.org/jira/browse/SLING-11764
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.26
>Reporter: Abhishek Garg
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.26
>
>
> The index definition files generated by the cpcconvertor are missing
> mandatory jcr:content nodes.
> How the resource should look:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
> "jcr:content": {
> "jcr:mimeType": "text/xml",
> "jcr:data": ":blobId:",
> "jcr:primaryType": "nam:nt:resource"
> }
> }
> }
> {code}
>
> How it looks like now:
> {code:java}
> "tika":{
> "jcr:primaryType":"nam:nt:unstructured",
> "config.xml":{
> "jcr:primaryType":"nam:nt:file",
> "jcr:data":":blobid:"
> }
> }{code}
>
> there is no jcr:content node present
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11764) jcr:content node missing for file resources generated in binaries index defintions
[
https://issues.apache.org/jira/browse/SLING-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhishek Garg updated SLING-11764:
--
Issue Type: Bug (was: Improvement)
> jcr:content node missing for file resources generated in binaries index
> defintions
> --
>
> Key: SLING-11764
> URL: https://issues.apache.org/jira/browse/SLING-11764
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.26
>Reporter: Abhishek Garg
>Priority: Major
>
> The index definition files generated by the cpcconvertor are missing
> mandatory jcr:content nodes.
> How the resource should look:
> {code:java}
> "tika": {
> "jcr:primaryType": "nam:nt:unstructured",
> "config.xml": {
> "jcr:primaryType": "nam:nt:file",
> "jcr:content": {
> "jcr:mimeType": "text/xml",
> "jcr:data": ":blobId:",
> "jcr:primaryType": "nam:nt:resource"
> }
> }
> }
> {code}
>
> How it looks like now:
> {code:java}
> "tika":{
> "jcr:primaryType":"nam:nt:unstructured",
> "config.xml":{
> "jcr:primaryType":"nam:nt:file",
> "jcr:data":":blobid:"
> }
> }{code}
>
> there is no jcr:content node present
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11764) jcr:content node missing for file resources generated in binaries index defintions
Abhishek Garg created SLING-11764:
-
Summary: jcr:content node missing for file resources generated in
binaries index defintions
Key: SLING-11764
URL: https://issues.apache.org/jira/browse/SLING-11764
Project: Sling
Issue Type: Improvement
Components: Content-Package to Feature Model Converter
Affects Versions: Content-Package to Feature Model Converter 1.1.26
Reporter: Abhishek Garg
The index definition files generated by the cpcconvertor are missing mandatory
jcr:content nodes.
How the resource should look:
{code:java}
"tika": {
"jcr:primaryType": "nam:nt:unstructured",
"config.xml": {
"jcr:primaryType": "nam:nt:file",
"jcr:content": {
"jcr:mimeType": "text/xml",
"jcr:data": ":blobId:",
"jcr:primaryType": "nam:nt:resource"
}
}
}
{code}
How it looks like now:
{code:java}
"tika":{
"jcr:primaryType":"nam:nt:unstructured",
"config.xml":{
"jcr:primaryType":"nam:nt:file",
"jcr:data":":blobid:"
}
}{code}
there is no jcr:content node present
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11739) Index definition extraction from content packages is missing binary files data
[ https://issues.apache.org/jira/browse/SLING-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Garg updated SLING-11739: -- Description: Currently, binaries are stored in indexDefinitions at [1] and these binaries should be written in JSONOutput at [2], However each time we are getting it as empty at [2]. The reason is that we are storing binaries against its repositoryPath instead it should be its parent path. i.e we are storing tika config.xml binaries at repositoryPath `oak:index/damAssetLucene-8-custom-2/tika/config.xml` and while writing at [2],we are trying to fetch it from `oak:index/damAssetLucene-8-custom-2/tika/` because of this we are getting it as empty as nodeName is till `oak:index/damAssetLucene-8-custom-2/tika` only. [1]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java] [2]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java#L137] was: Currently, binaries are stored in indexDefinitions at [1] and these binaries should be written in JSONOutput at [2], However each time we are it. as empty at [2]. The reason is that we are storing binaries against its repositoryPath instead it should be its parent path. i.e we are tika config.xml binaries at repositoryPath `oak:index/damAssetLucene-8-custom-2/tika/config.xml` and while writing at [2],we are trying to fetch it from `oak:index/damAssetLucene-8-custom-2/tika/` which is causing it empty as nodeName is till `oak:index/damAssetLucene-8-custom-2/tika` only. [1]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java] [2]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java#L137] > Index definition extraction from content packages is missing binary files data > -- > > Key: SLING-11739 > URL: https://issues.apache.org/jira/browse/SLING-11739 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.24 >Reporter: Abhishek Garg >Priority: Major > > Currently, binaries are stored in indexDefinitions at [1] and these binaries > should be written in JSONOutput at [2], However each time we are getting it > as empty at [2]. > The reason is that we are storing binaries against its repositoryPath instead > it should be its parent path. > i.e we are storing tika config.xml binaries at repositoryPath > `oak:index/damAssetLucene-8-custom-2/tika/config.xml` > and while writing at [2],we are trying to fetch it from > `oak:index/damAssetLucene-8-custom-2/tika/` > because of this we are getting it as empty as nodeName is till > `oak:index/damAssetLucene-8-custom-2/tika` only. > [1]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java] > [2]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java#L137] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11739) Index definition extraction from content packages is missing binary files data
[ https://issues.apache.org/jira/browse/SLING-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649265#comment-17649265 ] Abhishek Garg commented on SLING-11739: --- PR to fix that [https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152] cc : [~rombert] [~Sc0rpic0m] > Index definition extraction from content packages is missing binary files data > -- > > Key: SLING-11739 > URL: https://issues.apache.org/jira/browse/SLING-11739 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.24 >Reporter: Abhishek Garg >Priority: Major > > Currently, binaries are stored in indexDefinitions at [1] and these binaries > should be written in JSONOutput at [2], However each time we are it. as empty > at [2]. > The reason is that we are storing binaries against its repositoryPath instead > it should be its parent path. > i.e we are tika config.xml binaries at repositoryPath > `oak:index/damAssetLucene-8-custom-2/tika/config.xml` > and while writing at [2],we are trying to fetch it from > `oak:index/damAssetLucene-8-custom-2/tika/` > which is causing it empty as nodeName is till > `oak:index/damAssetLucene-8-custom-2/tika` only. > [1]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java] > [2]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java#L137] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11739) Index definition extraction from content packages is missing binary files data
Abhishek Garg created SLING-11739: - Summary: Index definition extraction from content packages is missing binary files data Key: SLING-11739 URL: https://issues.apache.org/jira/browse/SLING-11739 Project: Sling Issue Type: Bug Components: Content-Package to Feature Model Converter Affects Versions: Content-Package to Feature Model Converter 1.1.24 Reporter: Abhishek Garg Currently, binaries are stored in indexDefinitions at [1] and these binaries should be written in JSONOutput at [2], However each time we are it. as empty at [2]. The reason is that we are storing binaries against its repositoryPath instead it should be its parent path. i.e we are tika config.xml binaries at repositoryPath `oak:index/damAssetLucene-8-custom-2/tika/config.xml` and while writing at [2],we are trying to fetch it from `oak:index/damAssetLucene-8-custom-2/tika/` which is causing it empty as nodeName is till `oak:index/damAssetLucene-8-custom-2/tika` only. [1]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java] [2]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java#L137] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10273) Add null check in modifiedService for authReqPaths
[ https://issues.apache.org/jira/browse/SLING-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315711#comment-17315711 ] Abhishek Garg commented on SLING-10273: --- not failing on convertor,written two test cases. but not getting value null for any case. [https://github.com/apache/felix-dev/pull/73/files] > Add null check in modifiedService for authReqPaths > -- > > Key: SLING-10273 > URL: https://issues.apache.org/jira/browse/SLING-10273 > Project: Sling > Issue Type: Improvement > Components: Authentication >Affects Versions: Auth Core 1.5.0 >Reporter: Abhishek Garg >Priority: Major > > Getting null pointer in SlingAuthenticatorListener on replication pages. in > org.apache.sling.auth.core-1.5.0 > Exception in thread "pool-15-thread-1" java.lang.NullPointerException > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.modifiedService(SlingAuthenticatorServiceListener.java:369) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.process(SlingAuthenticatorServiceListener.java:280) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.processQueue(SlingAuthenticatorServiceListener.java:257) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.lambda$schedule$0(SlingAuthenticatorServiceListener.java:166) > at > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > at > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > at java.base/java.lang.Thread.run(Thread.java:834) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10273) Add null check in modifiedService for authReqPaths
[
https://issues.apache.org/jira/browse/SLING-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315669#comment-17315669
]
Abhishek Garg commented on SLING-10273:
---
On adding logging in modified service
[https://github.com/apache/sling-org-apache-sling-auth-core/pull/9/files]
we are getting authReqPaths null for the following values :
{code:java}
[com.adobe.granite.auth.requirement.impl.RequirementHandler]]
06.04.2021 20:59:05.661 *INFO* [pool-31-thread-1]
org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener reference is
null = false
06.04.2021 20:59:05.661 *INFO* [pool-31-thread-1]
org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener AUTH
Requirements = [/content/we-retail/language-masters/en/test/test22,
/content/we-retail/language-masters/en/test/test23,
/content/we-retail/language-masters/en/test/test20,
/content/we-retail/language-masters/en/test/test21,
/content/we-retail/language-masters/en/test/test25,
/content/we-retail/language-masters/en/test/test28,
/content/we-retail/language-masters/en/test/test29,
/content/we-retail/language-masters/en/test/test33,
/content/we-retail/language-masters/en/test/test34,
/content/we-retail/language-masters/en/test/test31,
/content/we-retail/language-masters/en/test/test35,
/content/we-retail/language-masters/en/test/test36,
/content/we-retail/language-masters/en/test/test104,
/content/we-retail/language-masters/en/test/test103,
/content/we-retail/language-masters/en/test/test101,
/content/we-retail/language-masters/en/test/test30,
/content/we-retail/language-masters/en/test/test106,
/content/we-retail/language-masters/en/test/test105,
/content/we-retail/language-masters/en/test/test109,
/content/we-retail/language-masters/en/test/test39,
/content/we-retail/language-masters/en/test/test44,
/content/we-retail/language-masters/en/test/test45,
/content/we-retail/language-masters/en/test/test155,
/content/we-retail/language-masters/en/test/test49,
/content/we-retail/language-masters/en/test/test154,
/content/we-retail/language-masters/en/test/test46,
/content/we-retail/language-masters/en/test/test153,
/content/we-retail/language-masters/en/test/test47,
/content/we-retail/language-masters/en/test/test152,
/content/we-retail/language-masters/en/test/test157,
/content/we-retail/language-masters/en/test/test156,
/content/we-retail/language-masters/en/test/test41,
/content/we-retail/language-masters/en/test/test,
/content/we-retail/language-masters/en/test/test55,
/content/we-retail/language-masters/en/test/test160,
/content/we-retail/language-masters/en/test/test59,
/content/we-retail/language-masters/en/test/test57,
/content/we-retail/language-masters/en/test/test58,
/content/we-retail/language-masters/en/test/test163,
/content/we-retail/language-masters/en/test/test51,
/content/we-retail/language-masters/en/test/test52,
/content/we-retail/language-masters/en/test/test50,
/content/we-retail/language-masters/en/test/test65,
/content/we-retail/language-masters/en/test/test133,
/content/we-retail/language-masters/en/test/test132,
/content/we-retail/language-masters/en/test/test68,
/content/we-retail/language-masters/en/test/test131,
/content/we-retail/language-masters/en/test/test69,
/content/we-retail/language-masters/en/test/test130,
/content/we-retail/language-masters/en/test/test136,
/content/we-retail/language-masters/en/test/test62,
/content/we-retail/language-masters/en/test/test63,
/content/we-retail/language-masters/en/test/test60,
/content/we-retail/language-masters/en/test/test139,
/content/we-retail/language-masters/en/test/test138,
/content/we-retail/language-masters/en/test/test6,
/content/we-retail/language-masters/en/test/test8,
/content/we-retail/language-masters/en/test/test75,
/content/we-retail/language-masters/en/test/test9,
/content/we-retail/language-masters/en/test/test76,
/content/we-retail/language-masters/en/test/test2,
/content/we-retail/language-masters/en/test/test144,
/content/we-retail/language-masters/en/test/test3,
/content/we-retail/language-masters/en/test/test143,
/content/we-retail/language-masters/en/test/test79,
/content/we-retail/language-masters/en/test/test142,
/content/we-retail/language-masters/en/test/test141,
/content/we-retail/language-masters/en/test/test70,
/content/we-retail/language-masters/en/test/test146,
/content/we-retail/language-masters/en/test/test1,
/content/we-retail/language-masters/en/test/test73,
/content/we-retail/language-masters/en/test/test74,
/content/we-retail/language-masters/en/test/test149,
/content/we-retail/language-masters/en/test/test86,
/content/we-retail/language-masters/en/test/test87,
/content/we-retail/language-masters/en/test/test115,
/content/we-retail/language-masters/en/test/test81,
/content/we-retail/language-masters/en/test/test114,
/content/we-retail/language-masters/en/test/test84,
/co
[jira] [Commented] (SLING-10273) Add null check in modifiedService for authReqPaths
[ https://issues.apache.org/jira/browse/SLING-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315454#comment-17315454 ] Abhishek Garg commented on SLING-10273: --- PR: [https://github.com/apache/sling-org-apache-sling-auth-core/pull/8] > Add null check in modifiedService for authReqPaths > -- > > Key: SLING-10273 > URL: https://issues.apache.org/jira/browse/SLING-10273 > Project: Sling > Issue Type: Improvement > Components: Authentication >Affects Versions: Auth Core 1.5.0 >Reporter: Abhishek Garg >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Auth Core 1.5.2 > > > Getting null pointer in SlingAuthenticatorListener on replication pages. in > org.apache.sling.auth.core-1.5.0 > Exception in thread "pool-15-thread-1" java.lang.NullPointerException > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.modifiedService(SlingAuthenticatorServiceListener.java:369) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.process(SlingAuthenticatorServiceListener.java:280) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.processQueue(SlingAuthenticatorServiceListener.java:257) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.lambda$schedule$0(SlingAuthenticatorServiceListener.java:166) > at > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > at > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > at java.base/java.lang.Thread.run(Thread.java:834) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10273) Add null check in modifiedService for authReqPaths
[ https://issues.apache.org/jira/browse/SLING-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Garg updated SLING-10273: -- Description: Getting null pointer in SlingAuthenticatorListener on replication pages. in org.apache.sling.auth.core-1.5.0 Exception in thread "pool-15-thread-1" java.lang.NullPointerException at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.modifiedService(SlingAuthenticatorServiceListener.java:369) at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.process(SlingAuthenticatorServiceListener.java:280) at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.processQueue(SlingAuthenticatorServiceListener.java:257) at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.lambda$schedule$0(SlingAuthenticatorServiceListener.java:166) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) was: Getting null pointer in SlingAuthenticatorListener on replication pages. Exception in thread "pool-15-thread-1" java.lang.NullPointerException at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.modifiedService(SlingAuthenticatorServiceListener.java:369) at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.process(SlingAuthenticatorServiceListener.java:280) at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.processQueue(SlingAuthenticatorServiceListener.java:257) at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.lambda$schedule$0(SlingAuthenticatorServiceListener.java:166) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) > Add null check in modifiedService for authReqPaths > -- > > Key: SLING-10273 > URL: https://issues.apache.org/jira/browse/SLING-10273 > Project: Sling > Issue Type: Improvement > Components: Authentication >Reporter: Abhishek Garg >Priority: Major > > Getting null pointer in SlingAuthenticatorListener on replication pages. in > org.apache.sling.auth.core-1.5.0 > Exception in thread "pool-15-thread-1" java.lang.NullPointerException > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.modifiedService(SlingAuthenticatorServiceListener.java:369) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.process(SlingAuthenticatorServiceListener.java:280) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.processQueue(SlingAuthenticatorServiceListener.java:257) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.lambda$schedule$0(SlingAuthenticatorServiceListener.java:166) > at > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > at > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > at java.base/java.lang.Thread.run(Thread.java:834) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10273) Add null check in modifiedService for authReqPaths
[ https://issues.apache.org/jira/browse/SLING-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Garg updated SLING-10273: -- Affects Version/s: Auth Core 1.5.0 > Add null check in modifiedService for authReqPaths > -- > > Key: SLING-10273 > URL: https://issues.apache.org/jira/browse/SLING-10273 > Project: Sling > Issue Type: Improvement > Components: Authentication >Affects Versions: Auth Core 1.5.0 >Reporter: Abhishek Garg >Priority: Major > > Getting null pointer in SlingAuthenticatorListener on replication pages. in > org.apache.sling.auth.core-1.5.0 > Exception in thread "pool-15-thread-1" java.lang.NullPointerException > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.modifiedService(SlingAuthenticatorServiceListener.java:369) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.process(SlingAuthenticatorServiceListener.java:280) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.processQueue(SlingAuthenticatorServiceListener.java:257) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.lambda$schedule$0(SlingAuthenticatorServiceListener.java:166) > at > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > at > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > at java.base/java.lang.Thread.run(Thread.java:834) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10273) Add null check in modifiedService for authReqPaths
[ https://issues.apache.org/jira/browse/SLING-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Garg updated SLING-10273: -- Component/s: Authentication > Add null check in modifiedService for authReqPaths > -- > > Key: SLING-10273 > URL: https://issues.apache.org/jira/browse/SLING-10273 > Project: Sling > Issue Type: Improvement > Components: Authentication >Reporter: Abhishek Garg >Priority: Major > > Getting null pointer in SlingAuthenticatorListener on replication pages. > Exception in thread "pool-15-thread-1" java.lang.NullPointerException > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.modifiedService(SlingAuthenticatorServiceListener.java:369) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.process(SlingAuthenticatorServiceListener.java:280) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.processQueue(SlingAuthenticatorServiceListener.java:257) > at > org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.lambda$schedule$0(SlingAuthenticatorServiceListener.java:166) > at > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > at > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > at java.base/java.lang.Thread.run(Thread.java:834) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10273) Add null check in modifiedService for authReqPaths
Abhishek Garg created SLING-10273: - Summary: Add null check in modifiedService for authReqPaths Key: SLING-10273 URL: https://issues.apache.org/jira/browse/SLING-10273 Project: Sling Issue Type: Improvement Reporter: Abhishek Garg Getting null pointer in SlingAuthenticatorListener on replication pages. Exception in thread "pool-15-thread-1" java.lang.NullPointerException at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.modifiedService(SlingAuthenticatorServiceListener.java:369) at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.process(SlingAuthenticatorServiceListener.java:280) at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.processQueue(SlingAuthenticatorServiceListener.java:257) at org.apache.sling.auth.core.impl.SlingAuthenticatorServiceListener.lambda$schedule$0(SlingAuthenticatorServiceListener.java:166) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) -- This message was sent by Atlassian Jira (v8.3.4#803005)
