[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: performance_factory.svn.patch performance_reportlogger.svn.patch Attached svn patches > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Assignee: Antonio Sanso >Priority: Minor > Labels: PatchAvailable > Attachments: performance_factory.patch, > performance_factory.svn.patch, performance_reportlogger.patch, > performance_reportlogger.svn.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory, when used with > @PerformanceTestSuites. The method can be used (this is optional) on a "test > case" object that is added to the ParameterizedTestList returned by the > @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, > the behaviour stays the same as before. If a @PerformanceTestFactory exists, > the PerformanceRunner adds all the test case instances returned by the > factory to the testObjects list, instead of the test case itself. > Optionally, the test cases can implement an IdentifiableTestCase interface, > which gives the ability to have custom names for tests running on different > instances. > The motivation behind this is that a suite can contain test cases that are > different logically, but the test case should be able to be parameterized. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2085) RequestHistoryConsolePlugin should escape HTML text
[ https://issues.apache.org/jira/browse/SLING-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811410#comment-13811410 ] Andrei Dulvac commented on SLING-2085: -- SLING-3222 might affect this. Is it a concern? > RequestHistoryConsolePlugin should escape HTML text > --- > > Key: SLING-2085 > URL: https://issues.apache.org/jira/browse/SLING-2085 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.2.2 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Engine 2.2.4 > > > The RequestHistoryConsolePlugin should escape the HTML text that it outputs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (SLING-3222) RequestUtil#escapeXml doesn't escape quotes
Andrei Dulvac created SLING-3222: Summary: RequestUtil#escapeXml doesn't escape quotes Key: SLING-3222 URL: https://issues.apache.org/jira/browse/SLING-3222 Project: Sling Issue Type: Bug Components: API Affects Versions: API 2.2.0 Reporter: Andrei Dulvac According to http://www.w3.org/TR/xml/#syntax , there are 5 characters which should be escaped in XML. ResponseUtil#escapeXml(String input) only escapes brackets and ampersand. It should also escape single and double quotes. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (SLING-2085) RequestHistoryConsolePlugin should escape HTML text
[ https://issues.apache.org/jira/browse/SLING-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811438#comment-13811438 ] Andrei Dulvac commented on SLING-2085: -- [~bdelacretaz], What I meant is that using RequestUtil in RequestHistoryConsolePlugin might not be safe right now, as using quotes can be part of an XSS attack. > RequestHistoryConsolePlugin should escape HTML text > --- > > Key: SLING-2085 > URL: https://issues.apache.org/jira/browse/SLING-2085 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.2.2 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Engine 2.2.4 > > > The RequestHistoryConsolePlugin should escape the HTML text that it outputs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (SLING-3222) RequestUtil#escapeXml doesn't escape quotes
[ https://issues.apache.org/jira/browse/SLING-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-3222: - Labels: PatchAvailable (was: ) > RequestUtil#escapeXml doesn't escape quotes > --- > > Key: SLING-3222 > URL: https://issues.apache.org/jira/browse/SLING-3222 > Project: Sling > Issue Type: Bug > Components: API >Affects Versions: API 2.2.0 >Reporter: Andrei Dulvac > Labels: PatchAvailable > Attachments: SLING-3222.patch > > > According to http://www.w3.org/TR/xml/#syntax , there are 5 characters which > should be escaped in XML. > ResponseUtil#escapeXml(String input) only escapes brackets and ampersand. It > should also escape single and double quotes. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (SLING-3222) RequestUtil#escapeXml doesn't escape quotes
[ https://issues.apache.org/jira/browse/SLING-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-3222: - Attachment: SLING-3222.patch Attached patch > RequestUtil#escapeXml doesn't escape quotes > --- > > Key: SLING-3222 > URL: https://issues.apache.org/jira/browse/SLING-3222 > Project: Sling > Issue Type: Bug > Components: API >Affects Versions: API 2.2.0 >Reporter: Andrei Dulvac > Labels: PatchAvailable > Attachments: SLING-3222.patch > > > According to http://www.w3.org/TR/xml/#syntax , there are 5 characters which > should be escaped in XML. > ResponseUtil#escapeXml(String input) only escapes brackets and ampersand. It > should also escape single and double quotes. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (SLING-2085) RequestHistoryConsolePlugin should escape HTML text
[ https://issues.apache.org/jira/browse/SLING-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811451#comment-13811451 ] Andrei Dulvac commented on SLING-2085: -- Attached a trivial patch on SLING-3222, could you close it? > RequestHistoryConsolePlugin should escape HTML text > --- > > Key: SLING-2085 > URL: https://issues.apache.org/jira/browse/SLING-2085 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.2.2 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Engine 2.2.4 > > > The RequestHistoryConsolePlugin should escape the HTML text that it outputs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: performance_factory.diff > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Attachments: performance_factory.diff > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory. The method should > return a scalar, an array or a list of objects which contain methods. > annotated with the existent @PerformanceTest. Optionally, the class(es) > returned by the factory method can implement an IdentifiableTestCase > interface, which gives the ability to have custom names for tests running on > different instances. The test collection is done statically, so this works > with the existing @Before/AfterMethodInvocation, allowing to have different > test setups at once. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This is important > for patch 1 to distinguish between different test setups. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
Andrei Dulvac created SLING-2727: Summary: Allow PerformanceRunner to run tests provided by a factory method Key: SLING-2727 URL: https://issues.apache.org/jira/browse/SLING-2727 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac Priority: Minor Attachments: performance_factory.diff 1. I have modified PerformanceRunner to be able to run tests provided through a factory method annotated with @PerformanceTestFactory. The method should return a scalar, an array or a list of objects which contain methods. annotated with the existent @PerformanceTest. Optionally, the class(es) returned by the factory method can implement an IdentifiableTestCase interface, which gives the ability to have custom names for tests running on different instances. The test collection is done statically, so this works with the existing @Before/AfterMethodInvocation, allowing to have different test setups at once. 2. Modified ReportLogger to log the test case name as well. Also, changed the method signatures so that it's clear what is being logged. This is important for patch 1 to distinguish between different test setups. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: performance_reportlogger.diff > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Attachments: performance_reportlogger.diff > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory. The method should > return a scalar, an array or a list of objects which contain methods. > annotated with the existent @PerformanceTest. Optionally, the class(es) > returned by the factory method can implement an IdentifiableTestCase > interface, which gives the ability to have custom names for tests running on > different instances. The test collection is done statically, so this works > with the existing @Before/AfterMethodInvocation, allowing to have different > test setups at once. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This is important > for patch 1 to distinguish between different test setups. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: (was: performance_factory.diff) > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Attachments: performance_reportlogger.diff > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory. The method should > return a scalar, an array or a list of objects which contain methods. > annotated with the existent @PerformanceTest. Optionally, the class(es) > returned by the factory method can implement an IdentifiableTestCase > interface, which gives the ability to have custom names for tests running on > different instances. The test collection is done statically, so this works > with the existing @Before/AfterMethodInvocation, allowing to have different > test setups at once. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This is important > for patch 1 to distinguish between different test setups. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: (was: performance_reportlogger.diff) > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory. The method should > return a scalar, an array or a list of objects which contain methods. > annotated with the existent @PerformanceTest. Optionally, the class(es) > returned by the factory method can implement an IdentifiableTestCase > interface, which gives the ability to have custom names for tests running on > different instances. The test collection is done statically, so this works > with the existing @Before/AfterMethodInvocation, allowing to have different > test setups at once. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This is important > for patch 1 to distinguish between different test setups. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: performance_factory.patch > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Attachments: performance_factory.patch, performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory. The method should > return a scalar, an array or a list of objects which contain methods. > annotated with the existent @PerformanceTest. Optionally, the class(es) > returned by the factory method can implement an IdentifiableTestCase > interface, which gives the ability to have custom names for tests running on > different instances. The test collection is done statically, so this works > with the existing @Before/AfterMethodInvocation, allowing to have different > test setups at once. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This is important > for patch 1 to distinguish between different test setups. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: performance_reportlogger.patch > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Attachments: performance_factory.patch, performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory. The method should > return a scalar, an array or a list of objects which contain methods. > annotated with the existent @PerformanceTest. Optionally, the class(es) > returned by the factory method can implement an IdentifiableTestCase > interface, which gives the ability to have custom names for tests running on > different instances. The test collection is done statically, so this works > with the existing @Before/AfterMethodInvocation, allowing to have different > test setups at once. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This is important > for patch 1 to distinguish between different test setups. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Labels: PatchAvailable (was: ) Added patches > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Labels: PatchAvailable > Attachments: performance_factory.patch, performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory. The method should > return a scalar, an array or a list of objects which contain methods. > annotated with the existent @PerformanceTest. Optionally, the class(es) > returned by the factory method can implement an IdentifiableTestCase > interface, which gives the ability to have custom names for tests running on > different instances. The test collection is done statically, so this works > with the existing @Before/AfterMethodInvocation, allowing to have different > test setups at once. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This is important > for patch 1 to distinguish between different test setups. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: (was: performance_factory.patch) > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Labels: PatchAvailable > Attachments: performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory. The method should > return a scalar, an array or a list of objects which contain methods. > annotated with the existent @PerformanceTest. Optionally, the class(es) > returned by the factory method can implement an IdentifiableTestCase > interface, which gives the ability to have custom names for tests running on > different instances. The test collection is done statically, so this works > with the existing @Before/AfterMethodInvocation, allowing to have different > test setups at once. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This is important > for patch 1 to distinguish between different test setups. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: performance_factory.patch > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Labels: PatchAvailable > Attachments: performance_factory.patch, performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory. The method should > return a scalar, an array or a list of objects which contain methods. > annotated with the existent @PerformanceTest. Optionally, the class(es) > returned by the factory method can implement an IdentifiableTestCase > interface, which gives the ability to have custom names for tests running on > different instances. The test collection is done statically, so this works > with the existing @Before/AfterMethodInvocation, allowing to have different > test setups at once. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This is important > for patch 1 to distinguish between different test setups. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Description: 1. I have modified PerformanceRunner to be able to run tests provided through a factory method annotated with @PerformanceTestFactory, when used with @PerformanceTestSuites. The method can be used (this is optional) on a "test case" object that is added to the ParameterizedTestList returned by the @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, the behaviour stays the same as before. If a @PerformanceTestFactory exists, the PerformanceRunner adds all the test case instances returned by the factory to the testObjects list, instead of the test case itself. Optionally, the test cases can implement an IdentifiableTestCase interface, which gives the ability to have custom names for tests running on different instances. 2. Modified ReportLogger to log the test case name as well. Also, changed the method signatures so that it's clear what is being logged. This works with patch 1 to distinguish between different test case instances The motivation behind this is that a suite can contain test cases that are different logically, but the test case should be able to be parameterized. was: 1. I have modified PerformanceRunner to be able to run tests provided through a factory method annotated with @PerformanceTestFactory. The method should return a scalar, an array or a list of objects which contain methods. annotated with the existent @PerformanceTest. Optionally, the class(es) returned by the factory method can implement an IdentifiableTestCase interface, which gives the ability to have custom names for tests running on different instances. The test collection is done statically, so this works with the existing @Before/AfterMethodInvocation, allowing to have different test setups at once. 2. Modified ReportLogger to log the test case name as well. Also, changed the method signatures so that it's clear what is being logged. This is important for patch 1 to distinguish between different test setups. > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Labels: PatchAvailable > Attachments: performance_factory.patch, performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory, when used with > @PerformanceTestSuites. The method can be used (this is optional) on a "test > case" object that is added to the ParameterizedTestList returned by the > @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, > the behaviour stays the same as before. If a @PerformanceTestFactory exists, > the PerformanceRunner adds all the test case instances returned by the > factory to the testObjects list, instead of the test case itself. > Optionally, the test cases can implement an IdentifiableTestCase interface, > which gives the ability to have custom names for tests running on different > instances. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This works with > patch 1 to distinguish between different test case instances > The motivation behind this is that a suite can contain test cases that are > different logically, but the test case should be able to be parameterized. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575822#comment-13575822 ] Andrei Dulvac commented on SLING-2727: -- Updated the description and the patch after looking at the PerformanceTestSuite functionality more in-depth. > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Labels: PatchAvailable > Attachments: performance_factory.patch, performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory, when used with > @PerformanceTestSuites. The method can be used (this is optional) on a "test > case" object that is added to the ParameterizedTestList returned by the > @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, > the behaviour stays the same as before. If a @PerformanceTestFactory exists, > the PerformanceRunner adds all the test case instances returned by the > factory to the testObjects list, instead of the test case itself. > Optionally, the test cases can implement an IdentifiableTestCase interface, > which gives the ability to have custom names for tests running on different > instances. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This works with > patch 1 to distinguish between different test case instances > The motivation behind this is that a suite can contain test cases that are > different logically, but the test case should be able to be parameterized. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: (was: performance_factory.patch) > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Labels: PatchAvailable > Attachments: performance_factory.patch, performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory, when used with > @PerformanceTestSuites. The method can be used (this is optional) on a "test > case" object that is added to the ParameterizedTestList returned by the > @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, > the behaviour stays the same as before. If a @PerformanceTestFactory exists, > the PerformanceRunner adds all the test case instances returned by the > factory to the testObjects list, instead of the test case itself. > Optionally, the test cases can implement an IdentifiableTestCase interface, > which gives the ability to have custom names for tests running on different > instances. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This works with > patch 1 to distinguish between different test case instances > The motivation behind this is that a suite can contain test cases that are > different logically, but the test case should be able to be parameterized. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: performance_factory.patch > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Labels: PatchAvailable > Attachments: performance_factory.patch, performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory, when used with > @PerformanceTestSuites. The method can be used (this is optional) on a "test > case" object that is added to the ParameterizedTestList returned by the > @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, > the behaviour stays the same as before. If a @PerformanceTestFactory exists, > the PerformanceRunner adds all the test case instances returned by the > factory to the testObjects list, instead of the test case itself. > Optionally, the test cases can implement an IdentifiableTestCase interface, > which gives the ability to have custom names for tests running on different > instances. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This works with > patch 1 to distinguish between different test case instances > The motivation behind this is that a suite can contain test cases that are > different logically, but the test case should be able to be parameterized. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: performance_factory.patch > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Labels: PatchAvailable > Attachments: performance_factory.patch, performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory, when used with > @PerformanceTestSuites. The method can be used (this is optional) on a "test > case" object that is added to the ParameterizedTestList returned by the > @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, > the behaviour stays the same as before. If a @PerformanceTestFactory exists, > the PerformanceRunner adds all the test case instances returned by the > factory to the testObjects list, instead of the test case itself. > Optionally, the test cases can implement an IdentifiableTestCase interface, > which gives the ability to have custom names for tests running on different > instances. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This works with > patch 1 to distinguish between different test case instances > The motivation behind this is that a suite can contain test cases that are > different logically, but the test case should be able to be parameterized. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: (was: performance_factory.patch) > Allow PerformanceRunner to run tests provided by a factory method > - > > Key: SLING-2727 > URL: https://issues.apache.org/jira/browse/SLING-2727 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Labels: PatchAvailable > Attachments: performance_factory.patch, performance_reportlogger.patch > > > 1. I have modified PerformanceRunner to be able to run tests provided through > a factory method annotated with @PerformanceTestFactory, when used with > @PerformanceTestSuites. The method can be used (this is optional) on a "test > case" object that is added to the ParameterizedTestList returned by the > @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, > the behaviour stays the same as before. If a @PerformanceTestFactory exists, > the PerformanceRunner adds all the test case instances returned by the > factory to the testObjects list, instead of the test case itself. > Optionally, the test cases can implement an IdentifiableTestCase interface, > which gives the ability to have custom names for tests running on different > instances. > 2. Modified ReportLogger to log the test case name as well. Also, changed the > method signatures so that it's clear what is being logged. This works with > patch 1 to distinguish between different test case instances > The motivation behind this is that a suite can contain test cases that are > different logically, but the test case should be able to be parameterized. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-9053) Implement retries mechanism for AbstractSlingClient.doRequest(...)
[ https://issues.apache.org/jira/browse/SLING-9053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac reassigned SLING-9053: Assignee: Andrei Dulvac > Implement retries mechanism for AbstractSlingClient.doRequest(...) > -- > > Key: SLING-9053 > URL: https://issues.apache.org/jira/browse/SLING-9053 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.2.4 >Reporter: Thierry Ygé >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Apache Sling Testing Clients 1.2.6 > > Time Spent: 2h > Remaining Estimate: 0h > > In cloud environment, it is likely to have 503 or broken connection at a very > low rate <1% of requests. This add unwanted flakiness to tests. > Generally 503 or broken connection should be retried (at least that is > recommended), thus it would be nice to introduce it on the > AbstractSlingClient.doRequest(...) which seems to be the best place as common > code (doGet, doPost etc..). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9053) Implement retries mechanism for http 5XX response codes
[ https://issues.apache.org/jira/browse/SLING-9053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-9053: - Summary: Implement retries mechanism for http 5XX response codes (was: Implement retries mechanism for AbstractSlingClient.doRequest(...)) > Implement retries mechanism for http 5XX response codes > --- > > Key: SLING-9053 > URL: https://issues.apache.org/jira/browse/SLING-9053 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.2.4 >Reporter: Thierry Ygé >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Apache Sling Testing Clients 1.2.6 > > Time Spent: 2h > Remaining Estimate: 0h > > In cloud environment, it is likely to have 503 or broken connection at a very > low rate <1% of requests. This add unwanted flakiness to tests. > Generally 503 or broken connection should be retried (at least that is > recommended), thus it would be nice to introduce it on the > AbstractSlingClient.doRequest(...) which seems to be the best place as common > code (doGet, doPost etc..). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9069) Polling format exception in case of TimeoutException
Andrei Dulvac created SLING-9069: Summary: Polling format exception in case of TimeoutException Key: SLING-9069 URL: https://issues.apache.org/jira/browse/SLING-9069 Project: Sling Issue Type: Improvement Components: Apache Sling Testing Clients Affects Versions: Apache Sling Testing Clients 1.2.4 Reporter: Thierry Ygé Assignee: Andrei Dulvac Fix For: Apache Sling Testing Clients 1.2.6 In cloud environment, it is likely to have 503 or broken connection at a very low rate <1% of requests. This add unwanted flakiness to tests. Generally 503 or broken connection should be retried (at least that is recommended), thus it would be nice to introduce it on the AbstractSlingClient.doRequest(...) which seems to be the best place as common code (doGet, doPost etc..). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9069) Polling format exception in case of TimeoutException
[ https://issues.apache.org/jira/browse/SLING-9069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-9069: - Reporter: Andrei Dulvac (was: Thierry Ygé) > Polling format exception in case of TimeoutException > > > Key: SLING-9069 > URL: https://issues.apache.org/jira/browse/SLING-9069 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.2.4 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Apache Sling Testing Clients 1.2.6 > > > In cloud environment, it is likely to have 503 or broken connection at a very > low rate <1% of requests. This add unwanted flakiness to tests. > Generally 503 or broken connection should be retried (at least that is > recommended), thus it would be nice to introduce it on the > AbstractSlingClient.doRequest(...) which seems to be the best place as common > code (doGet, doPost etc..). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9069) Polling format exception in case of TimeoutException
[
https://issues.apache.org/jira/browse/SLING-9069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-9069:
-
Description:
The {{Polling}} class has a line that can throw a format exception in case the
message of lastException contains a "%":
{{throw new TimeoutException(String.format(message(), effectiveTimeout,
delay));}}
was:
In cloud environment, it is likely to have 503 or broken connection at a very
low rate <1% of requests. This add unwanted flakiness to tests.
Generally 503 or broken connection should be retried (at least that is
recommended), thus it would be nice to introduce it on the
AbstractSlingClient.doRequest(...) which seems to be the best place as common
code (doGet, doPost etc..).
> Polling format exception in case of TimeoutException
>
>
> Key: SLING-9069
> URL: https://issues.apache.org/jira/browse/SLING-9069
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 1.2.6
>
>
> The {{Polling}} class has a line that can throw a format exception in case
> the message of lastException contains a "%":
> {{throw new TimeoutException(String.format(message(), effectiveTimeout,
> delay));}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9053) Implement retries mechanism for http 5XX response codes
[ https://issues.apache.org/jira/browse/SLING-9053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-9053. -- Resolution: Fixed > Implement retries mechanism for http 5XX response codes > --- > > Key: SLING-9053 > URL: https://issues.apache.org/jira/browse/SLING-9053 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.2.4 >Reporter: Thierry Ygé >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Apache Sling Testing Clients 1.2.6 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > In cloud environment, it is likely to have 503 or broken connection at a very > low rate <1% of requests. This add unwanted flakiness to tests. > Generally 503 or broken connection should be retried (at least that is > recommended), thus it would be nice to introduce it on the > AbstractSlingClient.doRequest(...) which seems to be the best place as common > code (doGet, doPost etc..). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-8710) IndexingClient should have configurable lanes
[
https://issues.apache.org/jira/browse/SLING-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac reassigned SLING-8710:
Assignee: Andrei Dulvac
> IndexingClient should have configurable lanes
> -
>
> Key: SLING-8710
> URL: https://issues.apache.org/jira/browse/SLING-8710
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Reporter: Vikas Saurabh
>Assignee: Andrei Dulvac
>Priority: Major
> Labels: sling-IT
> Fix For: Apache Sling Testing Clients 1.2.4
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> {{IndexingClient}} currently relies on {{OsgiConsoleCient}} to peek into
> system's lane configuration. That, in turn, requires access to
> /system/console which might be blocked on the system which is being tested.
> As indexing lanes in a setup isn't a very dynamic property, a quick work
> around could be for {{IndexingClient}} to allow setting up "expected index
> lanes in target setup".
> This issue would be an improvement over what was implemented in SLING-7169.
> [~rombert] and [~volteanu], since most of the comments over there are from
> you guys, wdyt about this improvement?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-8921) requestPath must to be encoded in SlingClient#doGet()
[ https://issues.apache.org/jira/browse/SLING-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-8921. -- Resolution: Fixed > requestPath must to be encoded in SlingClient#doGet() > - > > Key: SLING-8921 > URL: https://issues.apache.org/jira/browse/SLING-8921 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Reporter: Valentin Olteanu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > [SlingClient#doGet()|https://github.com/apache/sling-org-apache-sling-testing-clients/blob/609cb61fd2dec08657556b9adc91e889911a230e/src/main/java/org/apache/sling/testing/clients/AbstractSlingClient.java#L492] > requires `requestPath` to be encoded (because it's passed to multiple URI > constructors). > The contract should be uniform: all the parameters are passed decoded and the > method takes care to encode them properly before creating the request. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-8921) requestPath must to be encoded in SlingClient#doGet()
[ https://issues.apache.org/jira/browse/SLING-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac reassigned SLING-8921: Assignee: Andrei Dulvac > requestPath must to be encoded in SlingClient#doGet() > - > > Key: SLING-8921 > URL: https://issues.apache.org/jira/browse/SLING-8921 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Reporter: Valentin Olteanu >Assignee: Andrei Dulvac >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > [SlingClient#doGet()|https://github.com/apache/sling-org-apache-sling-testing-clients/blob/609cb61fd2dec08657556b9adc91e889911a230e/src/main/java/org/apache/sling/testing/clients/AbstractSlingClient.java#L492] > requires `requestPath` to be encoded (because it's passed to multiple URI > constructors). > The contract should be uniform: all the parameters are passed decoded and the > method takes care to encode them properly before creating the request. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9069) Polling format exception in case of TimeoutException
[
https://issues.apache.org/jira/browse/SLING-9069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-9069.
--
Resolution: Fixed
> Polling format exception in case of TimeoutException
>
>
> Key: SLING-9069
> URL: https://issues.apache.org/jira/browse/SLING-9069
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 1.2.6
>
>
> The {{Polling}} class has a line that can throw a format exception in case
> the message of lastException contains a "%":
> {{throw new TimeoutException(String.format(message(), effectiveTimeout,
> delay));}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-8921) requestPath must to be encoded in SlingClient#doGet()
[ https://issues.apache.org/jira/browse/SLING-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-8921: - Fix Version/s: Apache Sling Testing Clients 1.2.6 > requestPath must to be encoded in SlingClient#doGet() > - > > Key: SLING-8921 > URL: https://issues.apache.org/jira/browse/SLING-8921 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Reporter: Valentin Olteanu >Assignee: Andrei Dulvac >Priority: Minor > Fix For: Apache Sling Testing Clients 1.2.6 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > [SlingClient#doGet()|https://github.com/apache/sling-org-apache-sling-testing-clients/blob/609cb61fd2dec08657556b9adc91e889911a230e/src/main/java/org/apache/sling/testing/clients/AbstractSlingClient.java#L492] > requires `requestPath` to be encoded (because it's passed to multiple URI > constructors). > The contract should be uniform: all the parameters are passed decoded and the > method takes care to encode them properly before creating the request. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9069) Polling format exception in case of TimeoutException
[
https://issues.apache.org/jira/browse/SLING-9069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-9069:
-
Issue Type: Bug (was: Improvement)
> Polling format exception in case of TimeoutException
>
>
> Key: SLING-9069
> URL: https://issues.apache.org/jira/browse/SLING-9069
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 1.2.6
>
>
> The {{Polling}} class has a line that can throw a format exception in case
> the message of lastException contains a "%":
> {{throw new TimeoutException(String.format(message(), effectiveTimeout,
> delay));}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-9089) RemoteLogDumperRule is too verbose if the logs cannot be retrieved
[
https://issues.apache.org/jira/browse/SLING-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac reassigned SLING-9089:
Assignee: Andrei Dulvac
> RemoteLogDumperRule is too verbose if the logs cannot be retrieved
> --
>
> Key: SLING-9089
> URL: https://issues.apache.org/jira/browse/SLING-9089
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Rules
>Reporter: Valentin Olteanu
>Assignee: Andrei Dulvac
>Priority: Minor
>
> In case of a test failure, if the testlog servlet is not installed or cannot
> be accessed, RemoteLogDumperRule prints a very verbose message to stderr,
> confusing the user which thinks this is the root error:
> {code}
> Error occurred while fetching test logs from server [https://example.com/]
> org.apache.sling.testing.clients.ClientException: Expected HTTP Status: 200 .
> Instead 404 was returned!
> Response Content:
>
>
> 404 Resource at '/system/sling/testlog' not found: No
> resource found
> ...
> {code}
> I think we can move this to debug level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9089) RemoteLogDumperRule is too verbose if the logs cannot be retrieved
[
https://issues.apache.org/jira/browse/SLING-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-9089.
--
Resolution: Fixed
> RemoteLogDumperRule is too verbose if the logs cannot be retrieved
> --
>
> Key: SLING-9089
> URL: https://issues.apache.org/jira/browse/SLING-9089
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Rules
>Reporter: Valentin Olteanu
>Assignee: Andrei Dulvac
>Priority: Minor
>
> In case of a test failure, if the testlog servlet is not installed or cannot
> be accessed, RemoteLogDumperRule prints a very verbose message to stderr,
> confusing the user which thinks this is the root error:
> {code}
> Error occurred while fetching test logs from server [https://example.com/]
> org.apache.sling.testing.clients.ClientException: Expected HTTP Status: 200 .
> Instead 404 was returned!
> Response Content:
>
>
> 404 Resource at '/system/sling/testlog' not found: No
> resource found
> ...
> {code}
> I think we can move this to debug level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-9129) ResourceUtils add extra line break at the end of the file
[ https://issues.apache.org/jira/browse/SLING-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac reassigned SLING-9129: Assignee: Andrei Dulvac > ResourceUtils add extra line break at the end of the file > - > > Key: SLING-9129 > URL: https://issues.apache.org/jira/browse/SLING-9129 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.2.6 >Reporter: Thierry Ygé >Assignee: Andrei Dulvac >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > This method > [https://github.com/apache/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/ResourceUtil.java#L49-L65] > is adding extra line break at the end of the file it read which is not > expected. > Best would be that it doesn't read line by line but using > IOUtils.toString(InputStream.class, "utf-8"), that would make sure it > preserve the original file characters (including line breaks style if that > would be required in a test). > > Mainly the cultprit code is at line > [https://github.com/apache/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/ResourceUtil.java#L57] > The line break append all the time even at last line, which is why it add > this extra line. quickfix would be as suggested above or adding a condition > so that it does only add line break before it append the next line (so if the > StringBuffer is not empty) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9089) RemoteLogDumperRule is too verbose if the logs cannot be retrieved
[
https://issues.apache.org/jira/browse/SLING-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-9089:
-
Fix Version/s: Apache Sling Testing Rules 1.0.10
> RemoteLogDumperRule is too verbose if the logs cannot be retrieved
> --
>
> Key: SLING-9089
> URL: https://issues.apache.org/jira/browse/SLING-9089
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Rules
>Reporter: Valentin Olteanu
>Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Rules 1.0.10
>
>
> In case of a test failure, if the testlog servlet is not installed or cannot
> be accessed, RemoteLogDumperRule prints a very verbose message to stderr,
> confusing the user which thinks this is the root error:
> {code}
> Error occurred while fetching test logs from server [https://example.com/]
> org.apache.sling.testing.clients.ClientException: Expected HTTP Status: 200 .
> Instead 404 was returned!
> Response Content:
>
>
> 404 Resource at '/system/sling/testlog' not found: No
> resource found
> ...
> {code}
> I think we can move this to debug level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9129) ResourceUtils add extra line break at the end of the file
[ https://issues.apache.org/jira/browse/SLING-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-9129. -- Fix Version/s: Apache Sling Testing Clients 1.2.8 Resolution: Fixed > ResourceUtils add extra line break at the end of the file > - > > Key: SLING-9129 > URL: https://issues.apache.org/jira/browse/SLING-9129 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.2.6 >Reporter: Thierry Ygé >Assignee: Andrei Dulvac >Priority: Major > Fix For: Apache Sling Testing Clients 1.2.8 > > Time Spent: 1h > Remaining Estimate: 0h > > This method > [https://github.com/apache/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/ResourceUtil.java#L49-L65] > is adding extra line break at the end of the file it read which is not > expected. > Best would be that it doesn't read line by line but using > IOUtils.toString(InputStream.class, "utf-8"), that would make sure it > preserve the original file characters (including line breaks style if that > would be required in a test). > > Mainly the cultprit code is at line > [https://github.com/apache/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/ResourceUtil.java#L57] > The line break append all the time even at last line, which is why it add > this extra line. quickfix would be as suggested above or adding a condition > so that it does only add line break before it append the next line (so if the > StringBuffer is not empty) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9329) Implement configurable retries mechanism for http 5XX response codes
Andrei Dulvac created SLING-9329: Summary: Implement configurable retries mechanism for http 5XX response codes Key: SLING-9329 URL: https://issues.apache.org/jira/browse/SLING-9329 Project: Sling Issue Type: Improvement Components: Apache Sling Testing Clients Affects Versions: Apache Sling Testing Clients 1.2.4 Reporter: Thierry Ygé Assignee: Andrei Dulvac Fix For: Apache Sling Testing Clients 1.2.6 In cloud environment, it is likely to have 503 or broken connection at a very low rate <1% of requests. This add unwanted flakiness to tests. Generally 503 or broken connection should be retried (at least that is recommended), thus it would be nice to introduce it on the AbstractSlingClient.doRequest(...) which seems to be the best place as common code (doGet, doPost etc..). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9329) Implement configurable retries mechanism for http 5XX response codes
[ https://issues.apache.org/jira/browse/SLING-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-9329: - Reporter: Andrei Dulvac (was: Thierry Ygé) > Implement configurable retries mechanism for http 5XX response codes > > > Key: SLING-9329 > URL: https://issues.apache.org/jira/browse/SLING-9329 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.2.4 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Apache Sling Testing Clients 1.2.8 > > > In cloud environment, it is likely to have 503 or broken connection at a very > low rate <1% of requests. This add unwanted flakiness to tests. > Generally 503 or broken connection should be retried (at least that is > recommended), thus it would be nice to introduce it on the > AbstractSlingClient.doRequest(...) which seems to be the best place as common > code (doGet, doPost etc..). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9329) Implement configurable retries mechanism for http 5XX response codes
[ https://issues.apache.org/jira/browse/SLING-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-9329: - Fix Version/s: (was: Apache Sling Testing Clients 1.2.6) Apache Sling Testing Clients 1.2.8 > Implement configurable retries mechanism for http 5XX response codes > > > Key: SLING-9329 > URL: https://issues.apache.org/jira/browse/SLING-9329 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.2.4 >Reporter: Thierry Ygé >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Apache Sling Testing Clients 1.2.8 > > > In cloud environment, it is likely to have 503 or broken connection at a very > low rate <1% of requests. This add unwanted flakiness to tests. > Generally 503 or broken connection should be retried (at least that is > recommended), thus it would be nice to introduce it on the > AbstractSlingClient.doRequest(...) which seems to be the best place as common > code (doGet, doPost etc..). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9329) Implement configurable retries mechanism for http 5XX response codes
[ https://issues.apache.org/jira/browse/SLING-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-9329. -- Resolution: Fixed > Implement configurable retries mechanism for http 5XX response codes > > > Key: SLING-9329 > URL: https://issues.apache.org/jira/browse/SLING-9329 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.2.4 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Apache Sling Testing Clients 1.2.8 > > > Make http retry mechanism configurable. > More specifically, configure the error codes for which to retry the test http > calls. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9329) Implement configurable retries mechanism for http 5XX response codes
[ https://issues.apache.org/jira/browse/SLING-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-9329: - Description: Make http retry mechanism configurable. More specifically, configure the error codes for which to retry the test http calls. was: In cloud environment, it is likely to have 503 or broken connection at a very low rate <1% of requests. This add unwanted flakiness to tests. Generally 503 or broken connection should be retried (at least that is recommended), thus it would be nice to introduce it on the AbstractSlingClient.doRequest(...) which seems to be the best place as common code (doGet, doPost etc..). > Implement configurable retries mechanism for http 5XX response codes > > > Key: SLING-9329 > URL: https://issues.apache.org/jira/browse/SLING-9329 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.2.4 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Apache Sling Testing Clients 1.2.8 > > > Make http retry mechanism configurable. > More specifically, configure the error codes for which to retry the test http > calls. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8196) [Sling testing rules] RemoteLogDumperRule hides original test failure if /system/sling/testlog is unavailable
[ https://issues.apache.org/jira/browse/SLING-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-8196. -- Resolution: Fixed > [Sling testing rules] RemoteLogDumperRule hides original test failure if > /system/sling/testlog is unavailable > - > > Key: SLING-8196 > URL: https://issues.apache.org/jira/browse/SLING-8196 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Rules >Affects Versions: Apache Sling Testing Rules 1.0.8 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Major > Fix For: Apache Sling Testing Rules 1.0.10 > > > RemoteLogDumperRule hides original test failure if /system/sling/testlog is > unavailable on the instance under test. > Logging that with WARN and throwing the original test failure is a more > useful behaviour. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9334) Refactor configurable retries mechanism to make them consistent
Andrei Dulvac created SLING-9334: Summary: Refactor configurable retries mechanism to make them consistent Key: SLING-9334 URL: https://issues.apache.org/jira/browse/SLING-9334 Project: Sling Issue Type: Improvement Components: Apache Sling Testing Clients Affects Versions: Apache Sling Testing Clients 1.2.4 Reporter: Andrei Dulvac Assignee: Andrei Dulvac Fix For: Apache Sling Testing Clients 2.0.0 Make http retry mechanism configurable. More specifically, configure the error codes for which to retry the test http calls. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9334) Refactor configurable retries mechanism to make them consistent
[
https://issues.apache.org/jira/browse/SLING-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-9334:
-
Description: The {{o.a.s.testing.util.Constants}} class has some static
fields that are not constants at all. Those values should be moved into
methods. (was: Make http retry mechanism configurable.
More specifically, configure the error codes for which to retry the test http
calls.)
> Refactor configurable retries mechanism to make them consistent
> ---
>
> Key: SLING-9334
> URL: https://issues.apache.org/jira/browse/SLING-9334
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 2.0.0
>
>
> The {{o.a.s.testing.util.Constants}} class has some static fields that are
> not constants at all. Those values should be moved into methods.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9334) Refactor configurable retries mechanism to make them consistent
[
https://issues.apache.org/jira/browse/SLING-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076306#comment-17076306
]
Andrei Dulvac commented on SLING-9334:
--
This took care of
https://builds.apache.org/blue/organizations/jenkins/Sling%2Fsling-org-apache-sling-testing-clients/detail/master/92/pipeline
> Refactor configurable retries mechanism to make them consistent
> ---
>
> Key: SLING-9334
> URL: https://issues.apache.org/jira/browse/SLING-9334
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 2.0.0
>
>
> The {{o.a.s.testing.util.Constants}} class has some static fields that are
> not constants at all. Those values should be moved into methods.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9334) Refactor configurable retries mechanism to make them consistent
[
https://issues.apache.org/jira/browse/SLING-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-9334.
--
Resolution: Fixed
> Refactor configurable retries mechanism to make them consistent
> ---
>
> Key: SLING-9334
> URL: https://issues.apache.org/jira/browse/SLING-9334
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.4
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Critical
> Fix For: Apache Sling Testing Clients 2.0.0
>
>
> The {{o.a.s.testing.util.Constants}} class has some static fields that are
> not constants at all. Those values should be moved into methods.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal
Andrei Dulvac created SLING-9449: Summary: Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal Key: SLING-9449 URL: https://issues.apache.org/jira/browse/SLING-9449 Project: Sling Issue Type: Bug Components: Repoinit Affects Versions: Repoinit JCR 1.1.26 Reporter: Andrei Dulvac Assignee: Andrei Dulvac The check at https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191 is very aggressive and results in an error getting thrown, which potentially causes the repository service to not start up. It should be replaced with a log message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal
[ https://issues.apache.org/jira/browse/SLING-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106383#comment-17106383 ] Andrei Dulvac commented on SLING-9449: -- resolved in https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/55aa500da6805482d6972330e37125eacedaca8f > Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry > exists for principal > - > > Key: SLING-9449 > URL: https://issues.apache.org/jira/browse/SLING-9449 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.26 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > > The check at > https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191 > is very aggressive and results in an error getting thrown, which potentially > causes the repository service to not start up. > It should be replaced with a log message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal
[ https://issues.apache.org/jira/browse/SLING-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-9449. -- Fix Version/s: Repoinit JCR 1.1.28 Resolution: Fixed > Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry > exists for principal > - > > Key: SLING-9449 > URL: https://issues.apache.org/jira/browse/SLING-9449 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.26 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Repoinit JCR 1.1.28 > > > The check at > https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191 > is very aggressive and results in an error getting thrown, which potentially > causes the repository service to not start up. > It should be replaced with a log message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9633) Testing Clients Polling does not return all exceptions encountered while polling
Andrei Dulvac created SLING-9633:
Summary: Testing Clients Polling does not return all exceptions
encountered while polling
Key: SLING-9633
URL: https://issues.apache.org/jira/browse/SLING-9633
Project: Sling
Issue Type: Bug
Affects Versions: Apache Sling Testing Clients 2.0.0
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
Fix For: Apache Sling Testing Clients 2.0.2
It can happen with {{Polling}} that the last exception thrown is not the same
as the subsequent ones, for example in case of an operation with side effects
that might have thrown a particular exception, after which it throws some sort
of "conflict" exception. That first exception is thus lost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9633) Testing Clients Polling does not return all exceptions encountered while polling
[
https://issues.apache.org/jira/browse/SLING-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-9633.
--
Resolution: Fixed
> Testing Clients Polling does not return all exceptions encountered while
> polling
>
>
> Key: SLING-9633
> URL: https://issues.apache.org/jira/browse/SLING-9633
> Project: Sling
> Issue Type: Bug
>Affects Versions: Apache Sling Testing Clients 2.0.0
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Minor
> Fix For: Apache Sling Testing Clients 2.0.2
>
>
> It can happen with {{Polling}} that the last exception thrown is not the same
> as the subsequent ones, for example in case of an operation with side effects
> that might have thrown a particular exception, after which it throws some
> sort of "conflict" exception. That first exception is thus lost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9647) [Testing Clients] Store request and response on a ClientException
Andrei Dulvac created SLING-9647: Summary: [Testing Clients] Store request and response on a ClientException Key: SLING-9647 URL: https://issues.apache.org/jira/browse/SLING-9647 Project: Sling Issue Type: Improvement Components: Apache Sling Testing Clients Affects Versions: Apache Sling Testing Clients 2.0.0 Reporter: Andrei Dulvac Assignee: Andrei Dulvac Fix For: Apache Sling Testing Clients 2.0.2 Allow for ClientException to optionally store the request and response. This would be useful for logging them as part of exception handling -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9647) [Testing Clients] Store request and response on a ClientException
[ https://issues.apache.org/jira/browse/SLING-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-9647. -- Resolution: Fixed > [Testing Clients] Store request and response on a ClientException > --- > > Key: SLING-9647 > URL: https://issues.apache.org/jira/browse/SLING-9647 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 2.0.0 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Minor > Fix For: Apache Sling Testing Clients 2.0.2 > > > Allow for ClientException to optionally store the request and response. This > would be useful for logging them as part of exception handling -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-7272) [Testing Rules] Allow customizing the Sling Client Builder from an Instance junit rule
Andrei Dulvac created SLING-7272: Summary: [Testing Rules] Allow customizing the Sling Client Builder from an Instance junit rule Key: SLING-7272 URL: https://issues.apache.org/jira/browse/SLING-7272 Project: Sling Issue Type: Improvement Components: Apache Sling Testing Rules Affects Versions: Apache Sling Testing Rules 1.0.1 Reporter: Andrei Dulvac Assignee: Andrei Dulvac Fix For: Apache Sling Testing Rules 1.0.2 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SLING-7273) [Testing Rules] Instance#getClient should cache the clients
Andrei Dulvac created SLING-7273: Summary: [Testing Rules] Instance#getClient should cache the clients Key: SLING-7273 URL: https://issues.apache.org/jira/browse/SLING-7273 Project: Sling Issue Type: Improvement Components: Apache Sling Testing Rules Affects Versions: Apache Sling Testing Rules 1.0.1 Reporter: Andrei Dulvac Assignee: Andrei Dulvac Fix For: Apache Sling Testing Rules 1.0.2 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7116) [http.testing.clients] o.a.s.testing.clients.osgi.ComponentsInfo.findBy() does not honor the value parameter
[ https://issues.apache.org/jira/browse/SLING-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-7116: - Fix Version/s: org.apache.sling.testing.clients 1.1.10 > [http.testing.clients] o.a.s.testing.clients.osgi.ComponentsInfo.findBy() > does not honor the value parameter > > > Key: SLING-7116 > URL: https://issues.apache.org/jira/browse/SLING-7116 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.1.4 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac > Fix For: org.apache.sling.testing.clients 1.1.10 > > > o.a.s.testing.clients.osgi.ComponentsInfo.findBy() and thus all the public > methods do not honor the value parameter and just return the first value > found. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7116) [http.testing.clients] o.a.s.testing.clients.osgi.ComponentsInfo.findBy() does not honor the value parameter
[ https://issues.apache.org/jira/browse/SLING-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-7116: - Fix Version/s: (was: org.apache.sling.testing.clients 1.1.10) > [http.testing.clients] o.a.s.testing.clients.osgi.ComponentsInfo.findBy() > does not honor the value parameter > > > Key: SLING-7116 > URL: https://issues.apache.org/jira/browse/SLING-7116 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.1.4 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac > Fix For: Apache Sling Testing Clients 1.1.6 > > > o.a.s.testing.clients.osgi.ComponentsInfo.findBy() and thus all the public > methods do not honor the value parameter and just return the first value > found. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7116) [http.testing.clients] o.a.s.testing.clients.osgi.ComponentsInfo.findBy() does not honor the value parameter
[ https://issues.apache.org/jira/browse/SLING-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-7116: - Fix Version/s: Apache Sling Testing Clients 1.1.6 > [http.testing.clients] o.a.s.testing.clients.osgi.ComponentsInfo.findBy() > does not honor the value parameter > > > Key: SLING-7116 > URL: https://issues.apache.org/jira/browse/SLING-7116 > Project: Sling > Issue Type: Bug > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 1.1.4 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac > Fix For: Apache Sling Testing Clients 1.1.6 > > > o.a.s.testing.clients.osgi.ComponentsInfo.findBy() and thus all the public > methods do not honor the value parameter and just return the first value > found. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (SLING-7273) [Testing Rules] Instance#getClient should cache the clients
[ https://issues.apache.org/jira/browse/SLING-7273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-7273. -- Resolution: Fixed > [Testing Rules] Instance#getClient should cache the clients > --- > > Key: SLING-7273 > URL: https://issues.apache.org/jira/browse/SLING-7273 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Rules >Affects Versions: Apache Sling Testing Rules 1.0.1 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac > Fix For: Apache Sling Testing Rules 1.0.4 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (SLING-7272) [Testing Rules] Allow customizing the Sling Client Builder from an Instance junit rule
[ https://issues.apache.org/jira/browse/SLING-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-7272. -- Resolution: Fixed > [Testing Rules] Allow customizing the Sling Client Builder from an Instance > junit rule > -- > > Key: SLING-7272 > URL: https://issues.apache.org/jira/browse/SLING-7272 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Rules >Affects Versions: Apache Sling Testing Rules 1.0.1 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac > Fix For: Apache Sling Testing Rules 1.0.4 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
[
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292600#comment-16292600
]
Andrei Dulvac commented on SLING-7297:
--
@kwin, I'll do that later today. Thanks!
> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
>
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service
> to be available (i.e. active). Just waiting for the bundle is not necessarily
> enough, as the contained services/components might not yet have been started.
> Therefore having the following additional two methods would be beneficial:
> # {{waitComponentRegistered(String componentName, long, long}} to wait until
> the component with given name is active and
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long,
> long)}} to wait until a service of the given type is available. If the
> bundleSymbolicName is not null it should also check that this service is
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to
> check for that.
> {{/system/console/components/.json}} returns metadata about a
> specific component. All services are listed via
> {{/system/console/services.json}}. This can be used to extract information
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type
> (FELIX-5761).
> See also the related discussion at:
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
[
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292636#comment-16292636
]
Andrei Dulvac commented on SLING-7297:
--
I had a look and merged the PR. Thanks.
> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
>
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service
> to be available (i.e. active). Just waiting for the bundle is not necessarily
> enough, as the contained services/components might not yet have been started.
> Therefore having the following additional two methods would be beneficial:
> # {{waitComponentRegistered(String componentName, long, long}} to wait until
> the component with given name is active and
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long,
> long)}} to wait until a service of the given type is available. If the
> bundleSymbolicName is not null it should also check that this service is
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to
> check for that.
> {{/system/console/components/.json}} returns metadata about a
> specific component. All services are listed via
> {{/system/console/services.json}}. This can be used to extract information
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type
> (FELIX-5761).
> See also the related discussion at:
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
[
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-7297.
--
Resolution: Fixed
Assignee: Andrei Dulvac
> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
>
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.1.14
>
>
> Sometimes in an IT you need to wait for a specific OSGi component or service
> to be available (i.e. active). Just waiting for the bundle is not necessarily
> enough, as the contained services/components might not yet have been started.
> Therefore having the following additional two methods would be beneficial:
> # {{waitComponentRegistered(String componentName, long, long}} to wait until
> the component with given name is active and
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long,
> long)}} to wait until a service of the given type is available. If the
> bundleSymbolicName is not null it should also check that this service is
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to
> check for that.
> {{/system/console/components/.json}} returns metadata about a
> specific component. All services are listed via
> {{/system/console/services.json}}. This can be used to extract information
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type
> (FELIX-5761).
> See also the related discussion at:
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
[
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-7297:
-
Fix Version/s: Apache Sling Testing Clients 1.1.14
> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
>
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
> Issue Type: Improvement
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.1.14
>
>
> Sometimes in an IT you need to wait for a specific OSGi component or service
> to be available (i.e. active). Just waiting for the bundle is not necessarily
> enough, as the contained services/components might not yet have been started.
> Therefore having the following additional two methods would be beneficial:
> # {{waitComponentRegistered(String componentName, long, long}} to wait until
> the component with given name is active and
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long,
> long)}} to wait until a service of the given type is available. If the
> bundleSymbolicName is not null it should also check that this service is
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to
> check for that.
> {{/system/console/components/.json}} returns metadata about a
> specific component. All services are listed via
> {{/system/console/services.json}}. This can be used to extract information
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type
> (FELIX-5761).
> See also the related discussion at:
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7405) [o.a.s.testing.clients] The poller in {{Polling}} should wait for the delay even in case of exceptions
Andrei Dulvac created SLING-7405:
Summary: [o.a.s.testing.clients] The poller in {{Polling}} should
wait for the delay even in case of exceptions
Key: SLING-7405
URL: https://issues.apache.org/jira/browse/SLING-7405
Project: Sling
Issue Type: Bug
Components: Apache Sling Testing Clients
Affects Versions: Apache Sling Testing Clients 1.1.12
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
Fix For: Apache Sling Testing Clients 1.1.14
In case of an exception, {{Polling#poll}}
([https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java)]
doesn't get to the {{Thread.sleep}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7405) [o.a.s.testing.clients] The poller in {{Polling}} should wait for the delay even in case of exceptions
[
https://issues.apache.org/jira/browse/SLING-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-7405.
--
Resolution: Fixed
Fixed in
[https://github.com/apache/sling-org-apache-sling-testing-clients/pull/4]
Thanks [~andrei.tuicu]
> [o.a.s.testing.clients] The poller in {{Polling}} should wait for the delay
> even in case of exceptions
> --
>
> Key: SLING-7405
> URL: https://issues.apache.org/jira/browse/SLING-7405
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.1.14
>
>
> In case of an exception, {{Polling#poll}}
> ([https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java)]
> doesn't get to the {{Thread.sleep}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7405) [o.a.s.testing.clients] The poller in {{Polling}} should wait for the delay even in case of exceptions
[
https://issues.apache.org/jira/browse/SLING-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-7405:
-
Description: In case of an exception, {{Polling#poll}}
([https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java|https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java)]
doesn't get to the {{Thread.sleep}} (was: In case of an exception,
{{Polling#poll}}
([https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java)]
doesn't get to the {{Thread.sleep}})
> [o.a.s.testing.clients] The poller in {{Polling}} should wait for the delay
> even in case of exceptions
> --
>
> Key: SLING-7405
> URL: https://issues.apache.org/jira/browse/SLING-7405
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.1.14
>
>
> In case of an exception, {{Polling#poll}}
> ([https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java|https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java)]
> doesn't get to the {{Thread.sleep}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7405) [o.a.s.testing.clients] The poller in {{Polling}} should wait for the delay even in case of exceptions
[
https://issues.apache.org/jira/browse/SLING-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-7405:
-
Description: In case of an exception,
[Polling#poll|https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java]
doesn't get to the {{Thread.sleep}} (was: In case of an exception,
[{{Polling#poll}}|[https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java]]
doesn't get to the {{Thread.sleep}})
> [o.a.s.testing.clients] The poller in {{Polling}} should wait for the delay
> even in case of exceptions
> --
>
> Key: SLING-7405
> URL: https://issues.apache.org/jira/browse/SLING-7405
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.1.14
>
>
> In case of an exception,
> [Polling#poll|https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java]
> doesn't get to the {{Thread.sleep}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7405) [o.a.s.testing.clients] The poller in {{Polling}} should wait for the delay even in case of exceptions
[
https://issues.apache.org/jira/browse/SLING-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-7405:
-
Description: In case of an exception,
[{{Polling#poll}}|[https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java]]
doesn't get to the {{Thread.sleep}} (was: In case of an exception,
{{Polling#poll}}
([https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java|https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java)]
doesn't get to the {{Thread.sleep}})
> [o.a.s.testing.clients] The poller in {{Polling}} should wait for the delay
> even in case of exceptions
> --
>
> Key: SLING-7405
> URL: https://issues.apache.org/jira/browse/SLING-7405
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.1.14
>
>
> In case of an exception,
> [{{Polling#poll}}|[https://github.com/andreituicu/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java]]
> doesn't get to the {{Thread.sleep}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7669) StartupManager overwrites the frameworkstartlevel property and there is no way to retrieve the intended target start level
Andrei Dulvac created SLING-7669:
Summary: StartupManager overwrites the frameworkstartlevel
property and there is no way to retrieve the intended target start level
Key: SLING-7669
URL: https://issues.apache.org/jira/browse/SLING-7669
Project: Sling
Issue Type: Bug
Components: Launchpad
Reporter: Andrei Dulvac
Assignee: Andrei Dulvac
In incremental mode, the {{StartupManager}} keeps the target startlevel in a
private field, but overwrites "org.osgi.framework.startlevel.beginning" (for a
reason), but leaves no other way to retrieve the "target start level" of the
application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7669) StartupManager overwrites the frameworkstartlevel property and there is no way to retrieve the intended target start level
[
https://issues.apache.org/jira/browse/SLING-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-7669.
--
Resolution: Fixed
Fix Version/s: Launchpad Base 2.6.26
> StartupManager overwrites the frameworkstartlevel property and there is no
> way to retrieve the intended target start level
> --
>
> Key: SLING-7669
> URL: https://issues.apache.org/jira/browse/SLING-7669
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Launchpad Base 2.6.26
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In incremental mode, the {{StartupManager}} keeps the target startlevel in a
> private field, but overwrites "org.osgi.framework.startlevel.beginning" (for
> a reason), but leaves no other way to retrieve the "target start level" of
> the application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7724) Change scope to QueryServlet dependencies
[
https://issues.apache.org/jira/browse/SLING-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac resolved SLING-7724.
--
Resolution: Fixed
Assignee: Andrei Dulvac
> Change scope to QueryServlet dependencies
> -
>
> Key: SLING-7724
> URL: https://issues.apache.org/jira/browse/SLING-7724
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.0
>Reporter: Valentin Olteanu
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.2.2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, all the server-side dependencies for {{QueryServlet}} are listed
> with {{provided}} in the pom.
> These dependencies get lost in test bundles that have a dependency to
> sling.testing.clients, so {{TinyBundles}} fails to create a bundle with
> {{QueryServlet}}.
> The dependencies need to be compile-scoped to keep them in the resulting jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7724) Change scope to QueryServlet dependencies
[
https://issues.apache.org/jira/browse/SLING-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510690#comment-16510690
]
Andrei Dulvac commented on SLING-7724:
--
Thanks for the PR!
> Change scope to QueryServlet dependencies
> -
>
> Key: SLING-7724
> URL: https://issues.apache.org/jira/browse/SLING-7724
> Project: Sling
> Issue Type: Bug
> Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.0
>Reporter: Valentin Olteanu
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.2.2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, all the server-side dependencies for {{QueryServlet}} are listed
> with {{provided}} in the pom.
> These dependencies get lost in test bundles that have a dependency to
> sling.testing.clients, so {{TinyBundles}} fails to create a bundle with
> {{QueryServlet}}.
> The dependencies need to be compile-scoped to keep them in the resulting jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-5474) [HApi] Move sightly use objects to a different package
[
https://issues.apache.org/jira/browse/SLING-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-5474:
-
Attachment: SLING-5474.diff
Attached patch, can be applied with {{patch -p0 -i SLING-5474.diff}}
> [HApi] Move sightly use objects to a different package
> --
>
> Key: SLING-5474
> URL: https://issues.apache.org/jira/browse/SLING-5474
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Andrei Dulvac
> Labels: hapi
> Attachments: SLING-5474.diff
>
>
> Move HApiUse and TypeView use objects to the {{sightly}} sub-package
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-5474) [HApi] Move sightly use objects to a different package
[
https://issues.apache.org/jira/browse/SLING-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126494#comment-15126494
]
Andrei Dulvac commented on SLING-5474:
--
[~cziegeler], could you review?
> [HApi] Move sightly use objects to a different package
> --
>
> Key: SLING-5474
> URL: https://issues.apache.org/jira/browse/SLING-5474
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Andrei Dulvac
> Labels: hapi
> Attachments: SLING-5474.diff
>
>
> Move HApiUse and TypeView use objects to the {{sightly}} sub-package
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-5474) [HApi] Move sightly use objects to a different package
Andrei Dulvac created SLING-5474:
Summary: [HApi] Move sightly use objects to a different package
Key: SLING-5474
URL: https://issues.apache.org/jira/browse/SLING-5474
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Andrei Dulvac
Move HApiUse and TypeView use objects to the {{sightly}} sub-package
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-5694) introduce 'Slow' category to allow excluding slow running tests
[
https://issues.apache.org/jira/browse/SLING-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259921#comment-15259921
]
Andrei Dulvac commented on SLING-5694:
--
Hi Stefan, my [e-mail on the dev
list|https://mail-archives.apache.org/mod_mbox/sling-dev/201604.mbox/%3CCACfebH8Hfqg9RafceEqSauWATT8PLWsieFK+1xJWKKni=xa...@mail.gmail.com%3E]
proposes a contribution to sling/testing.
It also includes [some
categories|https://github.com/dulvac/sling/tree/sling-testing-tools/testing/http/rules/src/main/java/org/apache/sling/testing/rules/category]
along other junit goodies and http testing tooling. It is geared for
http-level testing, though. Just thought I'd mention it here.
> introduce 'Slow' category to allow excluding slow running tests
> ---
>
> Key: SLING-5694
> URL: https://issues.apache.org/jira/browse/SLING-5694
> Project: Sling
> Issue Type: Improvement
> Components: Commons
>Affects Versions: Commons Testing 2.0.24
>Reporter: Stefan Egli
>Assignee: Stefan Egli
> Fix For: Commons Testing 2.0.26
>
>
> As a follow up of a [discussion|http://markmail.org/message/yad5awqg53epk3ck]
> on the list and a concrete suggestion also done as part of SLING-5598 this is
> about introducing a junit category called {{Slow}} that can then be excluded
> from particular bundles' test goal by default. This does not yet exclude
> {{Slow}} in the parent/pom - we can do that separately if we deem that
> useful. For now this is needed by SLING-5598.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-5703) Split sling-testing-tools and improve the http clients and junit tooling
Andrei Dulvac created SLING-5703: Summary: Split sling-testing-tools and improve the http clients and junit tooling Key: SLING-5703 URL: https://issues.apache.org/jira/browse/SLING-5703 Project: Sling Issue Type: Bug Components: Testing, Tooling Reporter: Andrei Dulvac The sling-testing-tools [0] has become a container for different small pieces of code that don't fit in the other projects under testing/ . What I have identified to be unrelated tools in there are: * jarexec + serversetup * http clients * some junit tooling We would like to also contribute some classes that improve the http and junit tooling. The changes are: The changes would be the following: * leave the tools/ (sling testing tools) untouched, with the idea to eventually deprecate it if the other modules fit the needs. * create a new module, called serversetup with the jarexec and serversetup packages copied from sling-testing-tools. * create module http/clients with some stuff like the WebconsoleClient copied from tools/ and a bunch of classes that replace the RequestExecutor and client with Threadsafe, well-tested and HttpClient-compatible http tooling. * create module junit/rules with junit tooling dependent on the clients which follow the more modern approach to junit rules rather than test base classes and provide ootb rules with clients, junit filtering, configuring references to available sling instances, etc. Both this and clients are designed with extendability in mind. * adapt the "testing/samples" tests to use the junit rules and clients -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-5703) Split sling-testing-tools and improve the http clients and junit tooling
[ https://issues.apache.org/jira/browse/SLING-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-5703: - Description: The sling-testing-tools [0] has become a container for different small pieces of code that don't fit in the other projects under testing/ . What I have identified to be unrelated tools in there are: * jarexec + serversetup * http clients * some junit tooling We would like to also contribute some classes that improve the http and junit tooling. The changes are: The changes would be the following: * leave the tools/ (sling testing tools) untouched, with the idea to eventually deprecate it if the other modules fit the needs. * create a new module, called serversetup with the jarexec and serversetup packages copied from sling-testing-tools. * create module http/clients with some stuff like the WebconsoleClient copied from tools/ and a bunch of classes that replace the RequestExecutor and client with Threadsafe, well-tested and HttpClient-compatible http tooling. * create module junit/rules with junit tooling dependent on the clients which follow the more modern approach to junit rules rather than test base classes and provide ootb rules with clients, junit filtering, configuring references to available sling instances, etc. Both this and clients are designed with extendability in mind. * adapt the "testing/samples" tests to use the junit rules and clients Pull-request on github: https://github.com/apache/sling/pull/136 was: The sling-testing-tools [0] has become a container for different small pieces of code that don't fit in the other projects under testing/ . What I have identified to be unrelated tools in there are: * jarexec + serversetup * http clients * some junit tooling We would like to also contribute some classes that improve the http and junit tooling. The changes are: The changes would be the following: * leave the tools/ (sling testing tools) untouched, with the idea to eventually deprecate it if the other modules fit the needs. * create a new module, called serversetup with the jarexec and serversetup packages copied from sling-testing-tools. * create module http/clients with some stuff like the WebconsoleClient copied from tools/ and a bunch of classes that replace the RequestExecutor and client with Threadsafe, well-tested and HttpClient-compatible http tooling. * create module junit/rules with junit tooling dependent on the clients which follow the more modern approach to junit rules rather than test base classes and provide ootb rules with clients, junit filtering, configuring references to available sling instances, etc. Both this and clients are designed with extendability in mind. * adapt the "testing/samples" tests to use the junit rules and clients > Split sling-testing-tools and improve the http clients and junit tooling > > > Key: SLING-5703 > URL: https://issues.apache.org/jira/browse/SLING-5703 > Project: Sling > Issue Type: Bug > Components: Testing, Tooling >Reporter: Andrei Dulvac > Labels: sling-testing-tools, testing, testing-http-clients > > The sling-testing-tools [0] has become a container for different small pieces > of code that don't fit in the other projects under testing/ . What I have > identified to be unrelated tools in there are: > * jarexec + serversetup > * http clients > * some junit tooling > We would like to also contribute some classes that improve the http and junit > tooling. The changes are: > The changes would be the following: > * leave the tools/ (sling testing tools) untouched, with the idea to > eventually deprecate it if the other modules fit the needs. > * create a new module, called serversetup with the jarexec and serversetup > packages copied from sling-testing-tools. > * create module http/clients with some stuff like the WebconsoleClient copied > from tools/ and a bunch of classes that replace the RequestExecutor and > client with Threadsafe, well-tested and HttpClient-compatible http tooling. > * create module junit/rules with junit tooling dependent on the clients which > follow the more modern approach to junit rules rather than test base classes > and provide ootb rules with clients, junit filtering, configuring references > to available sling instances, etc. Both this and clients are designed with > extendability in mind. > * adapt the "testing/samples" tests to use the junit rules and clients > Pull-request on github: https://github.com/apache/sling/pull/136 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5703) Split sling-testing-tools and improve the http clients and junit tooling
[ https://issues.apache.org/jira/browse/SLING-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264158#comment-15264158 ] Andrei Dulvac commented on SLING-5703: -- All looks great, thanks Bertrand. > Split sling-testing-tools and improve the http clients and junit tooling > > > Key: SLING-5703 > URL: https://issues.apache.org/jira/browse/SLING-5703 > Project: Sling > Issue Type: Bug > Components: Testing, Tooling >Reporter: Andrei Dulvac >Assignee: Bertrand Delacretaz > Labels: sling-testing-tools, testing, testing-http-clients > > The sling-testing-tools [0] has become a container for different small pieces > of code that don't fit in the other projects under testing/ . What I have > identified to be unrelated tools in there are: > * jarexec + serversetup > * http clients > * some junit tooling > We would like to also contribute some classes that improve the http and junit > tooling. The changes are: > The changes would be the following: > * leave the tools/ (sling testing tools) untouched, with the idea to > eventually deprecate it if the other modules fit the needs. > * create a new module, called serversetup with the jarexec and serversetup > packages copied from sling-testing-tools. > * create module http/clients with some stuff like the WebconsoleClient copied > from tools/ and a bunch of classes that replace the RequestExecutor and > client with Threadsafe, well-tested and HttpClient-compatible http tooling. > * create module junit/rules with junit tooling dependent on the clients which > follow the more modern approach to junit rules rather than test base classes > and provide ootb rules with clients, junit filtering, configuring references > to available sling instances, etc. Both this and clients are designed with > extendability in mind. > * adapt the "testing/samples" tests to use the junit rules and clients > Pull-request on github: https://github.com/apache/sling/pull/136 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-5706) testing junit rules - add documentation with examples
Andrei Dulvac created SLING-5706: Summary: testing junit rules - add documentation with examples Key: SLING-5706 URL: https://issues.apache.org/jira/browse/SLING-5706 Project: Sling Issue Type: Bug Components: Testing Reporter: Andrei Dulvac Priority: Minor Add a documentation with examples of how to start an integration test using the testing/junit/rules and testing/http/clients -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-5706) testing junit rules - add documentation with examples
[
https://issues.apache.org/jira/browse/SLING-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulvac updated SLING-5706:
-
Attachment: SLING-5706.patch
Attached patch with README.md for junit/rules.
To be applied from the sling project root with {{patch -p0 -i SLING-5706.patch}}
> testing junit rules - add documentation with examples
> -
>
> Key: SLING-5706
> URL: https://issues.apache.org/jira/browse/SLING-5706
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Andrei Dulvac
>Priority: Minor
> Labels: testing-http-clients, testing-http-rules
> Attachments: SLING-5706.patch
>
>
> Add a documentation with examples of how to start an integration test using
> the testing/junit/rules and testing/http/clients
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-5707) [hapi] Add fromResource to HapiUtil and deprecate fromNode
Andrei Dulvac created SLING-5707: Summary: [hapi] Add fromResource to HapiUtil and deprecate fromNode Key: SLING-5707 URL: https://issues.apache.org/jira/browse/SLING-5707 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac HapiUtil has the method fromNode, which takes in a jcr Node. The attached patch deprecates fromNode and adds fromResource, to get a HApiType from a sling Resource. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5707) [hapi] Add fromResource to HapiUtil and deprecate fromNode
[
https://issues.apache.org/jira/browse/SLING-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266924#comment-15266924
]
Andrei Dulvac commented on SLING-5707:
--
SLING-5707.patch can also be applied from the sling project root with {{patch
-p0 -i SLING-5707.patch}}
> [hapi] Add fromResource to HapiUtil and deprecate fromNode
> --
>
> Key: SLING-5707
> URL: https://issues.apache.org/jira/browse/SLING-5707
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Reporter: Andrei Dulvac
> Labels: hapi
> Attachments: SLING-5707.patch
>
>
> HapiUtil has the method fromNode, which takes in a jcr Node.
> The attached patch deprecates fromNode and adds fromResource, to get a
> HApiType from a sling Resource.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-5707) [hapi] Add fromResource to HapiUtil and deprecate fromNode
[ https://issues.apache.org/jira/browse/SLING-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-5707: - Attachment: SLING-5707.patch > [hapi] Add fromResource to HapiUtil and deprecate fromNode > -- > > Key: SLING-5707 > URL: https://issues.apache.org/jira/browse/SLING-5707 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac > Labels: hapi > Attachments: SLING-5707.patch > > > HapiUtil has the method fromNode, which takes in a jcr Node. > The attached patch deprecates fromNode and adds fromResource, to get a > HApiType from a sling Resource. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5707) [hapi] Add fromResource to HapiUtil and deprecate fromNode
[ https://issues.apache.org/jira/browse/SLING-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266926#comment-15266926 ] Andrei Dulvac commented on SLING-5707: -- [~bdelacretaz], I'd highly appreciate your review on this if you have the time. > [hapi] Add fromResource to HapiUtil and deprecate fromNode > -- > > Key: SLING-5707 > URL: https://issues.apache.org/jira/browse/SLING-5707 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac > Labels: hapi > Attachments: SLING-5707.patch > > > HapiUtil has the method fromNode, which takes in a jcr Node. > The attached patch deprecates fromNode and adds fromResource, to get a > HApiType from a sling Resource. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5706) testing junit rules - add documentation with examples
[ https://issues.apache.org/jira/browse/SLING-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266927#comment-15266927 ] Andrei Dulvac commented on SLING-5706: -- [~bdelacretaz], Could you help me with this? > testing junit rules - add documentation with examples > - > > Key: SLING-5706 > URL: https://issues.apache.org/jira/browse/SLING-5706 > Project: Sling > Issue Type: Bug > Components: Testing >Reporter: Andrei Dulvac >Priority: Minor > Labels: testing-http-clients, testing-http-rules > Attachments: SLING-5706.patch > > > Add a documentation with examples of how to start an integration test using > the testing/junit/rules and testing/http/clients -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5725) New artifact org.apache.sling.testing.clients still has dependency on org.apache.sling.testing.tools
[
https://issues.apache.org/jira/browse/SLING-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282603#comment-15282603
]
Andrei Dulvac commented on SLING-5725:
--
Hi,
I created https://github.com/apache/sling/pull/141 for this.
> New artifact org.apache.sling.testing.clients still has dependency on
> org.apache.sling.testing.tools
>
>
> Key: SLING-5725
> URL: https://issues.apache.org/jira/browse/SLING-5725
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Konrad Windszus
> Labels: testing-http-clients
>
> Currently the pom.xml in
> https://github.com/apache/sling/blob/trunk/testing/http/clients/pom.xml still
> has a dependency towards {{org.apache.sling.testing.tools}}. That should be
> removed because the new artifact should be a replacement for the testing
> tools. The only place where classes are still referenced is the
> {{WebconsoleClient}}
> (https://github.com/apache/sling/blob/trunk/testing/http/clients/src/main/java/org/apache/sling/testing/clients/osgi/WebconsoleClient.java).
> Those references should be removed and also the {{WebconsoleClient}} should
> probably be merged with the {{OsgiConsoleClient}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SLING-5725) New artifact org.apache.sling.testing.clients still has dependency on org.apache.sling.testing.tools
[
https://issues.apache.org/jira/browse/SLING-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282603#comment-15282603
]
Andrei Dulvac edited comment on SLING-5725 at 5/13/16 10:21 AM:
Hi,
I created https://github.com/apache/sling/pull/141 for this.
Summary:
* Removed WebconsoleClient and added methods to install/ start/ unistall
bundles in OsgiConsoleClient
* Adapted BundlesInstaller
* Removed dependency on sling-testin-tools for testing-http-clients
was (Author: andrei.dulvac):
Hi,
I created https://github.com/apache/sling/pull/141 for this.
> New artifact org.apache.sling.testing.clients still has dependency on
> org.apache.sling.testing.tools
>
>
> Key: SLING-5725
> URL: https://issues.apache.org/jira/browse/SLING-5725
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Konrad Windszus
> Labels: testing-http-clients
>
> Currently the pom.xml in
> https://github.com/apache/sling/blob/trunk/testing/http/clients/pom.xml still
> has a dependency towards {{org.apache.sling.testing.tools}}. That should be
> removed because the new artifact should be a replacement for the testing
> tools. The only place where classes are still referenced is the
> {{WebconsoleClient}}
> (https://github.com/apache/sling/blob/trunk/testing/http/clients/src/main/java/org/apache/sling/testing/clients/osgi/WebconsoleClient.java).
> Those references should be removed and also the {{WebconsoleClient}} should
> probably be merged with the {{OsgiConsoleClient}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-5725) New artifact org.apache.sling.testing.clients still has dependency on org.apache.sling.testing.tools
[
https://issues.apache.org/jira/browse/SLING-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282685#comment-15282685
]
Andrei Dulvac commented on SLING-5725:
--
Hi Bertrand, thanks for adding me as a contributor.
I've addressed the two issues - added reference to the webconsole http api url
+ fixed missing file from OsgiConsoleClient#installBundle.
> New artifact org.apache.sling.testing.clients still has dependency on
> org.apache.sling.testing.tools
>
>
> Key: SLING-5725
> URL: https://issues.apache.org/jira/browse/SLING-5725
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Konrad Windszus
> Labels: testing-http-clients
>
> Currently the pom.xml in
> https://github.com/apache/sling/blob/trunk/testing/http/clients/pom.xml still
> has a dependency towards {{org.apache.sling.testing.tools}}. That should be
> removed because the new artifact should be a replacement for the testing
> tools. The only place where classes are still referenced is the
> {{WebconsoleClient}}
> (https://github.com/apache/sling/blob/trunk/testing/http/clients/src/main/java/org/apache/sling/testing/clients/osgi/WebconsoleClient.java).
> Those references should be removed and also the {{WebconsoleClient}} should
> probably be merged with the {{OsgiConsoleClient}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-5727) Remove o.a.s.testing.tools dependency in o.a.s.testing.serversetup and adapt http code
Andrei Dulvac created SLING-5727: Summary: Remove o.a.s.testing.tools dependency in o.a.s.testing.serversetup and adapt http code Key: SLING-5727 URL: https://issues.apache.org/jira/browse/SLING-5727 Project: Sling Issue Type: Bug Components: Testing Reporter: Andrei Dulvac o.a.s.testing.serversetup has a dependency on o.a.s.testing.tools, out of which it came to life. The idea is to deprecate the testing-tools. To do this, SlingTestBase (which should probably be renamed) should be adapted to use o.a.s.testing.clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-5727) Remove o.a.s.testing.tools dependency in o.a.s.testing.serversetup and adapt http code
[ https://issues.apache.org/jira/browse/SLING-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-5727. -- Resolution: Fixed Assignee: Andrei Dulvac Fix Version/s: Sample Integration Tests 1.0.8 Fixed in rev 1748594 > Remove o.a.s.testing.tools dependency in o.a.s.testing.serversetup and adapt > http code > -- > > Key: SLING-5727 > URL: https://issues.apache.org/jira/browse/SLING-5727 > Project: Sling > Issue Type: Bug > Components: Testing >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac > Labels: testing-http-clients > Fix For: Sample Integration Tests 1.0.8 > > > o.a.s.testing.serversetup has a dependency on o.a.s.testing.tools, out of > which it came to life. The idea is to deprecate the testing-tools. > To do this, SlingTestBase (which should probably be renamed) should be > adapted to use o.a.s.testing.clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-5793) Add client that can leverage hapi client in testing http clients
Andrei Dulvac created SLING-5793: Summary: Add client that can leverage hapi client in testing http clients Key: SLING-5793 URL: https://issues.apache.org/jira/browse/SLING-5793 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac Assignee: Andrei Dulvac Priority: Minor For leveraging the hypermedia api and hapi, a simpl SlingClient that implements o.a.s.hapi.HtmlClient is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-5793) Add client that can leverage hapi client in testing http clients
[ https://issues.apache.org/jira/browse/SLING-5793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-5793: - Description: For leveraging the hypermedia api and hapi, a simple SlingClient that implements o.a.s.hapi.HtmlClient is needed. (was: For leveraging the hypermedia api and hapi, a simpl SlingClient that implements o.a.s.hapi.HtmlClient is needed.) > Add client that can leverage hapi client in testing http clients > > > Key: SLING-5793 > URL: https://issues.apache.org/jira/browse/SLING-5793 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Minor > Labels: testing-http-clients > > For leveraging the hypermedia api and hapi, a simple SlingClient that > implements o.a.s.hapi.HtmlClient is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-5793) Add client that can leverage hapi client in testing http clients
[ https://issues.apache.org/jira/browse/SLING-5793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-5793: - Labels: testing-http-clients (was: ) > Add client that can leverage hapi client in testing http clients > > > Key: SLING-5793 > URL: https://issues.apache.org/jira/browse/SLING-5793 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Minor > Labels: testing-http-clients > > For leveraging the hypermedia api and hapi, a simpl SlingClient that > implements o.a.s.hapi.HtmlClient is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-5793) Add client that can leverage hapi client in testing http clients
[ https://issues.apache.org/jira/browse/SLING-5793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-5793. -- Resolution: Fixed > Add client that can leverage hapi client in testing http clients > > > Key: SLING-5793 > URL: https://issues.apache.org/jira/browse/SLING-5793 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Minor > Labels: testing-http-clients > > For leveraging the hypermedia api and hapi, a simple SlingClient that > implements o.a.s.hapi.HtmlClient is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
