[jira] [Comment Edited] (SLING-10845) Update logback to 1.2.6 version
[ https://issues.apache.org/jira/browse/SLING-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422659#comment-17422659 ] Ashok Kumar edited comment on SLING-10845 at 9/30/21, 9:35 AM: --- [~sagarmiglani], kindly provide patch here. For historical reference, follow https://issues.apache.org/jira/browse/SLING-7220 was (Author: ashokpanghal): [~sagarmiglani], kindly provide patch here > Update logback to 1.2.6 version > > > Key: SLING-10845 > URL: https://issues.apache.org/jira/browse/SLING-10845 > Project: Sling > Issue Type: Task > Components: Commons >Affects Versions: Commons Log 5.1.12 >Reporter: Ashok Kumar >Priority: Major > Fix For: Commons Log 5.1.14 > > > To address vulnerability [https://jira.qos.ch/browse/LOGBACK-1465] , we need > to upgrade to 1.2.6 of logback -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10845) Update logback to 1.2.6 version
[ https://issues.apache.org/jira/browse/SLING-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422659#comment-17422659 ] Ashok Kumar commented on SLING-10845: - [~sagarmiglani], kindly provide patch here > Update logback to 1.2.6 version > > > Key: SLING-10845 > URL: https://issues.apache.org/jira/browse/SLING-10845 > Project: Sling > Issue Type: Task > Components: Commons >Affects Versions: Commons Log 5.1.12 >Reporter: Ashok Kumar >Priority: Major > Fix For: Commons Log 5.1.14 > > > To address vulnerability [https://jira.qos.ch/browse/LOGBACK-1465] , we need > to upgrade to 1.2.6 of logback -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10845) Update logback to 1.2.6 version
Ashok Kumar created SLING-10845: --- Summary: Update logback to 1.2.6 version Key: SLING-10845 URL: https://issues.apache.org/jira/browse/SLING-10845 Project: Sling Issue Type: Task Components: Commons Affects Versions: Commons Log 5.1.12 Reporter: Ashok Kumar Fix For: Commons Log 5.1.14 To address vulnerability [https://jira.qos.ch/browse/LOGBACK-1465] , we need to upgrade to 1.2.6 of logback -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8777) Sling activation bundle overrides default CommandMap with wrong type
[ https://issues.apache.org/jira/browse/SLING-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952745#comment-16952745 ] Ashok Kumar commented on SLING-8777: [~karlpauls] created SLING-8780 for mimepull part and removed it from this JIRA. > Sling activation bundle overrides default CommandMap with wrong type > > > Key: SLING-8777 > URL: https://issues.apache.org/jira/browse/SLING-8777 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: javax.activation 0.1.0 >Reporter: Ashok Kumar >Priority: Major > Fix For: javax.activation 0.2.0 > > Attachments: SLING-8777.patch > > > The root cause of the issue is that the bundle > org.apache.sling.javax.activation 0.1.0 overrides the Default > javax.activation.CommandMap extending directly from CommandMap instead of > MailcapCommandMap: > > [https://github.com/apache/sling-org-apache-sling-javax-activation/blob/master/src/main/java/org/apache/sling/javax/activation/internal/OsgiMailcapCommandMap.java#L50] > The call fails due to this, here: > > [https://github.com/samskivert/ikvm-openjdk/blob/master/build/linux-amd64/impsrc/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java#L112] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8777) Sling activation bundle overrides default CommandMap with wrong type
[ https://issues.apache.org/jira/browse/SLING-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-8777: --- Description: The root cause of the issue is that the bundle org.apache.sling.javax.activation 0.1.0 overrides the Default javax.activation.CommandMap extending directly from CommandMap instead of MailcapCommandMap: [https://github.com/apache/sling-org-apache-sling-javax-activation/blob/master/src/main/java/org/apache/sling/javax/activation/internal/OsgiMailcapCommandMap.java#L50] The call fails due to this, here: [https://github.com/samskivert/ikvm-openjdk/blob/master/build/linux-amd64/impsrc/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java#L112] was: The root cause of the issue is that the bundle org.apache.sling.javax.activation 0.1.0 overrides the Default javax.activation.CommandMap extending directly from CommandMap instead of MailcapCommandMap: [https://github.com/apache/sling-org-apache-sling-javax-activation/blob/master/src/main/java/org/apache/sling/javax/activation/internal/OsgiMailcapCommandMap.java#L50] The call fails due to this, here: [https://github.com/samskivert/ikvm-openjdk/blob/master/build/linux-amd64/impsrc/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java#L112] [|http://repo1.maven.org/maven2/org/jvnet/mimepull/mimepull/1.9.7/mimepull-1.9.7.jar] > Sling activation bundle overrides default CommandMap with wrong type > > > Key: SLING-8777 > URL: https://issues.apache.org/jira/browse/SLING-8777 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: javax.activation 0.1.0 >Reporter: Ashok Kumar >Priority: Major > Fix For: javax.activation 0.2.0 > > Attachments: SLING-8777.patch > > > The root cause of the issue is that the bundle > org.apache.sling.javax.activation 0.1.0 overrides the Default > javax.activation.CommandMap extending directly from CommandMap instead of > MailcapCommandMap: > > [https://github.com/apache/sling-org-apache-sling-javax-activation/blob/master/src/main/java/org/apache/sling/javax/activation/internal/OsgiMailcapCommandMap.java#L50] > The call fails due to this, here: > > [https://github.com/samskivert/ikvm-openjdk/blob/master/build/linux-amd64/impsrc/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java#L112] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8780) Include mimepull bundle to Sling for SOAP attachments
Ashok Kumar created SLING-8780: -- Summary: Include mimepull bundle to Sling for SOAP attachments Key: SLING-8780 URL: https://issues.apache.org/jira/browse/SLING-8780 Project: Sling Issue Type: Bug Components: Starter Reporter: Ashok Kumar There is a missing dependency of mimepull. This dependency needs to be added to Sling. [http://repo1.maven.org/maven2/org/jvnet/mimepull/mimepull/1.9.7/mimepull-1.9.7.jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8777) Sling activation bundle overrides default CommandMap with wrong type
[ https://issues.apache.org/jira/browse/SLING-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-8777: --- Description: The root cause of the issue is that the bundle org.apache.sling.javax.activation 0.1.0 overrides the Default javax.activation.CommandMap extending directly from CommandMap instead of MailcapCommandMap: [https://github.com/apache/sling-org-apache-sling-javax-activation/blob/master/src/main/java/org/apache/sling/javax/activation/internal/OsgiMailcapCommandMap.java#L50] The call fails due to this, here: [https://github.com/samskivert/ikvm-openjdk/blob/master/build/linux-amd64/impsrc/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java#L112] [|http://repo1.maven.org/maven2/org/jvnet/mimepull/mimepull/1.9.7/mimepull-1.9.7.jar] was: The root cause of the issue is that the bundle org.apache.sling.javax.activation 0.1.0 overrides the Default javax.activation.CommandMap extending directly from CommandMap instead of MailcapCommandMap: [https://github.com/apache/sling-org-apache-sling-javax-activation/blob/master/src/main/java/org/apache/sling/javax/activation/internal/OsgiMailcapCommandMap.java#L50] The call fails due to this, here: [https://github.com/samskivert/ikvm-openjdk/blob/master/build/linux-amd64/impsrc/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java#L112] There is also a missing dependency of mimepull. This dependency needs to be added to AEM as well: [http://repo1.maven.org/maven2/org/jvnet/mimepull/mimepull/1.9.7/mimepull-1.9.7.jar] > Sling activation bundle overrides default CommandMap with wrong type > > > Key: SLING-8777 > URL: https://issues.apache.org/jira/browse/SLING-8777 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: javax.activation 0.1.0 >Reporter: Ashok Kumar >Priority: Major > Fix For: javax.activation 0.2.0 > > Attachments: SLING-8777.patch > > > The root cause of the issue is that the bundle > org.apache.sling.javax.activation 0.1.0 overrides the Default > javax.activation.CommandMap extending directly from CommandMap instead of > MailcapCommandMap: > > [https://github.com/apache/sling-org-apache-sling-javax-activation/blob/master/src/main/java/org/apache/sling/javax/activation/internal/OsgiMailcapCommandMap.java#L50] > The call fails due to this, here: > > [https://github.com/samskivert/ikvm-openjdk/blob/master/build/linux-amd64/impsrc/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java#L112] > [|http://repo1.maven.org/maven2/org/jvnet/mimepull/mimepull/1.9.7/mimepull-1.9.7.jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8777) Sling activation bundle overrides default CommandMap with wrong type
[ https://issues.apache.org/jira/browse/SLING-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-8777: --- Attachment: SLING-8777.patch > Sling activation bundle overrides default CommandMap with wrong type > > > Key: SLING-8777 > URL: https://issues.apache.org/jira/browse/SLING-8777 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: javax.activation 0.1.0 >Reporter: Ashok Kumar >Priority: Major > Fix For: javax.activation 0.2.0 > > Attachments: SLING-8777.patch > > > The root cause of the issue is that the bundle > org.apache.sling.javax.activation 0.1.0 overrides the Default > javax.activation.CommandMap extending directly from CommandMap instead of > MailcapCommandMap: > [https://github.com/apache/sling-org-apache-sling-javax-activation/blob/master/src/main/java/org/apache/sling/javax/activation/internal/OsgiMailcapCommandMap.java#L50] > The call fails due to this, here: > [https://github.com/samskivert/ikvm-openjdk/blob/master/build/linux-amd64/impsrc/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java#L112] > There is also a missing dependency of mimepull. This dependency needs to be > added to AEM as well: > [http://repo1.maven.org/maven2/org/jvnet/mimepull/mimepull/1.9.7/mimepull-1.9.7.jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8777) Sling activation bundle overrides default CommandMap with wrong type
Ashok Kumar created SLING-8777: -- Summary: Sling activation bundle overrides default CommandMap with wrong type Key: SLING-8777 URL: https://issues.apache.org/jira/browse/SLING-8777 Project: Sling Issue Type: Bug Components: Commons Affects Versions: javax.activation 0.1.0 Reporter: Ashok Kumar Fix For: javax.activation 0.2.0 The root cause of the issue is that the bundle org.apache.sling.javax.activation 0.1.0 overrides the Default javax.activation.CommandMap extending directly from CommandMap instead of MailcapCommandMap: [https://github.com/apache/sling-org-apache-sling-javax-activation/blob/master/src/main/java/org/apache/sling/javax/activation/internal/OsgiMailcapCommandMap.java#L50] The call fails due to this, here: [https://github.com/samskivert/ikvm-openjdk/blob/master/build/linux-amd64/impsrc/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java#L112] There is also a missing dependency of mimepull. This dependency needs to be added to AEM as well: [http://repo1.maven.org/maven2/org/jvnet/mimepull/mimepull/1.9.7/mimepull-1.9.7.jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8310) mimetypes Web Console Printer broken
[ https://issues.apache.org/jira/browse/SLING-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937502#comment-16937502 ] Ashok Kumar commented on SLING-8310: [~bdelacretaz] , [~cziegeler] may we get a new release out for commons-mime-2.2.2 with fix for this issue - SLING-8310 > mimetypes Web Console Printer broken > > > Key: SLING-8310 > URL: https://issues.apache.org/jira/browse/SLING-8310 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons Mime 2.2.0 >Reporter: Ashish Chopra >Priority: Major > Fix For: Commons Mime 2.2.2 > > Attachments: > 0001-SLING-8310-mimetypes-Web-Console-Printer-broken.patch > > Time Spent: 1h > Remaining Estimate: 0h > > {{/system/console/mimetypes}} is broken in v2.2.0 of CoOmmons MIME - post [0] > {{org.apache.sling.commons.mime.internal.MimeTypeWebConsolePlugin}} stays > unsatisfied, so the "Sling MIME Types" printer entry doesn't appear in the > system-console's Sling menu. > However, in subsequent commit (specifically due to [1]), the printer entry > does appear in the Menu (because the component is now satisfied), but the > page fails to load with stack-trace at [2] since the component fails > activation due to {{java.lang.InstantiationException: Constructor not found}}. > [0] > https://github.com/apache/sling-org-apache-sling-commons-mime/commit/4606f104d9fc15ab1681c125a0abcd7096dfcbdb > [1] > https://github.com/apache/sling-org-apache-sling-commons-mime/commit/13b5592d0657b8e382b13f911d121b37ff0686d9#diff-cbf2203631e848af70ed5a42adb0c350L61 > [2] > {noformat} > java.lang.InstantiationException: Constructor not found. > at > org.apache.felix.scr.impl.inject.ComponentConstructor.newInstance(ComponentConstructor.java:243) > at > org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:277) > at > org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:114) > at > org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:982) > at > org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:955) > at > org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:900) > at > org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:348) > at > org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:248) > at > org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:350) > at org.apache.felix.framework.Felix.getService(Felix.java:3954) > at > org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:450) > at > org.apache.felix.webconsole.internal.servlet.PluginHolder$ServletPlugin.doGetConsolePlugin(PluginHolder.java:719) > at > org.apache.felix.webconsole.internal.servlet.PluginHolder$Plugin.getConsolePlugin(PluginHolder.java:594) > at > org.apache.felix.webconsole.internal.servlet.PluginHolder.getPlugin(PluginHolder.java:205) > at > org.apache.felix.webconsole.internal.servlet.OsgiManager.getConsolePlugin(OsgiManager.java:645) > at > org.apache.felix.webconsole.internal.servlet.OsgiManager.service(OsgiManager.java:536) > at > org.apache.felix.webconsole.internal.servlet.OsgiManager$3.run(OsgiManager.java:465) > at java.security.AccessController.doPrivileged(Native Method) > at > org.apache.felix.webconsole.internal.servlet.OsgiManager.service(OsgiManager.java:461) > at > org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:123) > at > org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86) > at > com.adobe.granite.license.impl.LicenseCheckFilter.doFilter(LicenseCheckFilter.java:308) > at > org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142) > at > org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81) > at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131) > at > org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142) > at > org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81) > at > org.apache.felix.http.base.internal.dispatch.Dispatcher$1.doFilter(Dispatcher.java:146) > at > org.apache.felix.http.base.internal.whiteboard.WhiteboardManager$2.doFilter(WhiteboardManager.java:1002) > at > org.apache.sling.security.impl.ReferrerFilter.doFilter(ReferrerFilter.java:326) > at >
[jira] [Commented] (SLING-8720) HTTP Status 200 returned when JSP Engine fails due to JspFactoryHandler being null
[ https://issues.apache.org/jira/browse/SLING-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937399#comment-16937399 ] Ashok Kumar commented on SLING-8720: [~cziegeler] , [~kpauls] , kindly review and merge the patch/PR. Thank you. > HTTP Status 200 returned when JSP Engine fails due to JspFactoryHandler > being null > --- > > Key: SLING-8720 > URL: https://issues.apache.org/jira/browse/SLING-8720 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting JSP 2.3.4 >Reporter: Ashok Kumar >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > With fix from SLING-2704 , JspScriptEngineFactory returns no exception > (ultimately results in a http success response) for the case where > JspFactoryHandler gets null. It only logs the warning. Ideally, it should > throw an exception (result into http status 404 ) instead of http status 200. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8720) HTTP Status 200 returned when JSP Engine fails due to JspFactoryHandler being null
Ashok Kumar created SLING-8720: -- Summary: HTTP Status 200 returned when JSP Engine fails due to JspFactoryHandler being null Key: SLING-8720 URL: https://issues.apache.org/jira/browse/SLING-8720 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting JSP 2.3.4 Reporter: Ashok Kumar With fix from SLING-2704 , JspScriptEngineFactory returns no exception (ultimately results in a http success response) for the case where JspFactoryHandler gets null. It only logs the warning. Ideally, it should throw an exception (result into http status 404 ) instead of http status 200. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8523) Duplicate OSGI configs after upgrade
[ https://issues.apache.org/jira/browse/SLING-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870908#comment-16870908 ] Ashok Kumar commented on SLING-8523: [~cziegeler], PR updated as per review comments, new test case added for the special case. Please merge. > Duplicate OSGI configs after upgrade > > > Key: SLING-8523 > URL: https://issues.apache.org/jira/browse/SLING-8523 > Project: Sling > Issue Type: Bug > Components: Installer >Reporter: Ashok Kumar >Priority: Critical > Attachments: image-2019-06-20-15-29-56-200.png > > Time Spent: 50m > Remaining Estimate: 0h > > upgrade is resulting in duplicate factory configurations (configuration with > .PID versus ~PID format) files which affect the configs related > functionality. It happens for odd cases where alias comes as null. > Linked issue - SLING-7786 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8523) Duplicate OSGI configs after upgrade
Ashok Kumar created SLING-8523: -- Summary: Duplicate OSGI configs after upgrade Key: SLING-8523 URL: https://issues.apache.org/jira/browse/SLING-8523 Project: Sling Issue Type: Bug Components: Installer Reporter: Ashok Kumar Attachments: image-2019-06-20-15-29-56-200.png upgrade is resulting in duplicate factory configurations (configuration with .PID versus ~PID format) files which affect the configs related functionality. It happens for odd cases where alias comes as null. Linked issue - SLING-7786 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8388) XSS possible in system console - servletresolver
[ https://issues.apache.org/jira/browse/SLING-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833715#comment-16833715 ] Ashok Kumar commented on SLING-8388: Thank you [~kpauls] > XSS possible in system console - servletresolver > > > Key: SLING-8388 > URL: https://issues.apache.org/jira/browse/SLING-8388 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Servlets Resolver 2.5.2 >Reporter: Ashok Kumar >Assignee: Karl Pauls >Priority: Major > Fix For: Servlets Resolver 2.5.4 > > Time Spent: 20m > Remaining Estimate: 0h > > *Issue Summary :* There is a XSS possible in system console. > *Steps to reproduce :* > *Scenario 1 :* > # Open a local instance > # Open the link > [http://localhost:4502/system/console/services?filter=%22onmouseover=%22alert(%27xss%27)%22] > in Internet Explorer. > # Chrome would auto flag XSS exploit and prevent page load > *Scenario 2 :* > # Open a local instance > # Open the link > [http://localhost:4502/system/console/servletresolver?url=%2Fcontent%2Fdam%3Cscript%3Ealert%28%27123%27%29%3C%2Fscript%3E=GET] > in Internet Explorer. > # Chrome would auto flag XSS exploit and prevent page load > *Expected Behavior :* The pop up should not come up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8388) XSS possible in system console - servletresolver
[ https://issues.apache.org/jira/browse/SLING-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832239#comment-16832239 ] Ashok Kumar commented on SLING-8388: PR created with the fix - [https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/4] CC - [~kpauls], [~radu.cotescu] > XSS possible in system console - servletresolver > > > Key: SLING-8388 > URL: https://issues.apache.org/jira/browse/SLING-8388 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Servlets Resolver 2.5.2 >Reporter: Ashok Kumar >Priority: Major > Fix For: Servlets Resolver 2.5.4 > > Time Spent: 10m > Remaining Estimate: 0h > > *Issue Summary :* There is a XSS possible in system console. > *Steps to reproduce :* > *Scenario 1 :* > # Open a local instance > # Open the link > [http://localhost:4502/system/console/services?filter=%22onmouseover=%22alert(%27xss%27)%22] > in Internet Explorer. > # Chrome would auto flag XSS exploit and prevent page load > *Scenario 2 :* > # Open a local instance > # Open the link > [http://localhost:4502/system/console/servletresolver?url=%2Fcontent%2Fdam%3Cscript%3Ealert%28%27123%27%29%3C%2Fscript%3E=GET] > in Internet Explorer. > # Chrome would auto flag XSS exploit and prevent page load > *Expected Behavior :* The pop up should not come up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8388) XSS possible in system console - servletresolver
Ashok Kumar created SLING-8388: -- Summary: XSS possible in system console - servletresolver Key: SLING-8388 URL: https://issues.apache.org/jira/browse/SLING-8388 Project: Sling Issue Type: Bug Components: ResourceResolver Affects Versions: Servlets Resolver 2.5.2 Reporter: Ashok Kumar Fix For: Servlets Resolver 2.5.4 *Issue Summary :* There is a XSS possible in system console. *Steps to reproduce :* *Scenario 1 :* # Open a local instance # Open the link [http://localhost:4502/system/console/services?filter=%22onmouseover=%22alert(%27xss%27)%22] in Internet Explorer. # Chrome would auto flag XSS exploit and prevent page load *Scenario 2 :* # Open a local instance # Open the link [http://localhost:4502/system/console/servletresolver?url=%2Fcontent%2Fdam%3Cscript%3Ealert%28%27123%27%29%3C%2Fscript%3E=GET] in Internet Explorer. # Chrome would auto flag XSS exploit and prevent page load *Expected Behavior :* The pop up should not come up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8353) Change embedded ESAPI version in sling.xss
[ https://issues.apache.org/jira/browse/SLING-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817870#comment-16817870 ] Ashok Kumar commented on SLING-8353: PR - [https://github.com/apache/sling-org-apache-sling-xss/pull/6] . Please review. > Change embedded ESAPI version in sling.xss > -- > > Key: SLING-8353 > URL: https://issues.apache.org/jira/browse/SLING-8353 > Project: Sling > Issue Type: Bug > Components: XSS Protection API >Affects Versions: XSS Protection API 2.1.6 >Reporter: Ashok Kumar >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > org.apache.sling.xss embeds esapi 2.1.0. It would be good if we update this > to 2.1.0.1 atleast, which would bring more security fixes and still remains > backward compatible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8353) Change embedded ESAPI version in sling.xss
Ashok Kumar created SLING-8353: -- Summary: Change embedded ESAPI version in sling.xss Key: SLING-8353 URL: https://issues.apache.org/jira/browse/SLING-8353 Project: Sling Issue Type: Bug Components: XSS Protection API Affects Versions: XSS Protection API 2.1.6 Reporter: Ashok Kumar org.apache.sling.xss embeds esapi 2.1.0. It would be good if we update this to 2.1.0.1 atleast, which would bring more security fixes and still remains backward compatible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8349) resolver.map - map empty path to root path
[ https://issues.apache.org/jira/browse/SLING-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816143#comment-16816143 ] Ashok Kumar commented on SLING-8349: [~kpauls] , please review the PR - [https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/14] > resolver.map - map empty path to root path > --- > > Key: SLING-8349 > URL: https://issues.apache.org/jira/browse/SLING-8349 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.6.10 >Reporter: Ashok Kumar >Priority: Major > Fix For: Resource Resolver 1.6.12 > > Time Spent: 10m > Remaining Estimate: 0h > > Extend fix done in SLING-8335 to include check for empty path. > map empty path to root path not to a null resource -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8349) resolver.map - map empty path to root path
Ashok Kumar created SLING-8349: -- Summary: resolver.map - map empty path to root path Key: SLING-8349 URL: https://issues.apache.org/jira/browse/SLING-8349 Project: Sling Issue Type: Bug Components: ResourceResolver Affects Versions: Resource Resolver 1.6.10 Reporter: Ashok Kumar Fix For: Resource Resolver 1.6.12 Extend fix done in SLING-8335 to include check for empty path. map empty path to root path not to a null resource -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8341) unexpected results from resourceresolver.map when input path has adjacent '/'
[ https://issues.apache.org/jira/browse/SLING-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810605#comment-16810605 ] Ashok Kumar commented on SLING-8341: [~karlpauls], [~cziegeler] Please review the PR - [https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/13] Took approach of adjusting the extra slash counts while evaluating the pathinfo. Please suggest if there is a better alternative. Thank you. > unexpected results from resourceresolver.map when input path has adjacent '/' > - > > Key: SLING-8341 > URL: https://issues.apache.org/jira/browse/SLING-8341 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.6.8 >Reporter: Ashok Kumar >Assignee: Karl Pauls >Priority: Major > Fix For: Resource Resolver 1.6.10 > > Attachments: Variables-resolveInternal.png > > Time Spent: 10m > Remaining Estimate: 0h > > Scenario : - ResourceResolver.map(‘/content/we-retail/us*//*en.html’) results > in ‘/content/we-retail/us/enn.html’ > Steps to Reproduce : > 1. Go to console /system/console/jcrresolver > 2. input link "/content/we-retail/us//en.html" to Configuration Test > 3. click map > 4. the result shows > Output > Primary: /content/we-retail/us/enn.html. Other candidates: > /content/we-retail/us//en.html. > Analysis: > Attached is the variable states at Line 772 > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L769-L770] > > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L732-L763] > gives resolutionPath = "/content/we-retail/us/en" but original absPath input > param had an extra slash so pathinfo gets extra character in this case 'n'. > Refer attached variable state. If there are three adjacent slashes , pathinfo > would have two extra chars 'en'. > > Questions: - How to handle such input gracefully > what should be the output - throw an exception and exit OR return the > original path itself OR automatically remove adjacent slashes and replace > that with single '/' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8341) unexpected results from resourceresolver.map when input path has adjacent '/'
[ https://issues.apache.org/jira/browse/SLING-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-8341: --- Description: Scenario : - ResourceResolver.map(‘/content/we-retail/us*//*en.html’) results in ‘/content/we-retail/us/enn.html’ Steps to Reproduce : 1. Go to console /system/console/jcrresolver 2. input link "/content/we-retail/us//en.html" to Configuration Test 3. click map 4. the result shows Output Primary: /content/we-retail/us/enn.html. Other candidates: /content/we-retail/us//en.html. Analysis: Attached is the variable states at Line 772 [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L769-L770] [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L732-L763] gives resolutionPath = "/content/we-retail/us/en" but original absPath input param had an extra slash so pathinfo gets extra character in this case 'n'. Refer attached variable state. If there are three adjacent slashes , pathinfo would have two extra chars 'en'. Questions: - How to handle such input gracefully what should be the output - throw an exception and exit OR return the original path itself OR automatically remove adjacent slashes and replace that with single '/' was: Scenario : - ResourceResolver.map(‘/content/we-retail/us*//*en.html’) results in ‘/content/we-retail/us/enn.html’ Steps to Reproduce : 1. Go to console /system/console/jcrresolver 2. input link "/content/we-retail/us//en.html" to Configuration Test 3. click map 4. the result shows Output Primary: /content/we-retail/us/enn.html. Other candidates: /content/we-retail/us//en.html. Questions: - How to handle such input gracefully what should be the output - throw an exception and exit OR return the original path itself OR automatically remove adjacent slashes and replace that with single '/' > unexpected results from resourceresolver.map when input path has adjacent '/' > - > > Key: SLING-8341 > URL: https://issues.apache.org/jira/browse/SLING-8341 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.6.8 >Reporter: Ashok Kumar >Priority: Major > Attachments: Variables-resolveInternal.png > > > Scenario : - ResourceResolver.map(‘/content/we-retail/us*//*en.html’) results > in ‘/content/we-retail/us/enn.html’ > Steps to Reproduce : > 1. Go to console /system/console/jcrresolver > 2. input link "/content/we-retail/us//en.html" to Configuration Test > 3. click map > 4. the result shows > Output > Primary: /content/we-retail/us/enn.html. Other candidates: > /content/we-retail/us//en.html. > Analysis: > Attached is the variable states at Line 772 > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L769-L770] > > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L732-L763] > gives resolutionPath = "/content/we-retail/us/en" but original absPath input > param had an extra slash so pathinfo gets extra character in this case 'n'. > Refer attached variable state. If there are three adjacent slashes , pathinfo > would have two extra chars 'en'. > > Questions: - How to handle such input gracefully > what should be the output - throw an exception and exit OR return the > original path itself OR automatically remove adjacent slashes and replace > that with single '/' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8341) unexpected results from resourceresolver.map when input path has adjacent '/'
[ https://issues.apache.org/jira/browse/SLING-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-8341: --- Attachment: Variables-resolveInternal.png > unexpected results from resourceresolver.map when input path has adjacent '/' > - > > Key: SLING-8341 > URL: https://issues.apache.org/jira/browse/SLING-8341 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.6.8 >Reporter: Ashok Kumar >Priority: Major > Attachments: Variables-resolveInternal.png > > > Scenario : - ResourceResolver.map(‘/content/we-retail/us*//*en.html’) results > in ‘/content/we-retail/us/enn.html’ > Steps to Reproduce : > 1. Go to console /system/console/jcrresolver > 2. input link "/content/we-retail/us//en.html" to Configuration Test > 3. click map > 4. the result shows > Output > Primary: /content/we-retail/us/enn.html. Other candidates: > /content/we-retail/us//en.html. > > Questions: - How to handle such input gracefully > what should be the output - throw an exception and exit OR return the > original path itself OR automatically remove adjacent slashes and replace > that with single '/' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8341) unexpected results from resourceresolver.map when input path has adjacent '/'
[ https://issues.apache.org/jira/browse/SLING-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-8341: --- Description: Scenario : - ResourceResolver.map(‘/content/we-retail/us*//*en.html’) results in ‘/content/we-retail/us/enn.html’ Steps to Reproduce : 1. Go to console /system/console/jcrresolver 2. input link "/content/we-retail/us//en.html" to Configuration Test 3. click map 4. the result shows Output Primary: /content/we-retail/us/enn.html. Other candidates: /content/we-retail/us//en.html. Questions: - How to handle such input gracefully what should be the output - throw an exception and exit OR return the original path itself OR automatically remove adjacent slashes and replace that with single '/' was: ResourceResolver.map(‘/content/we-retail/us*//*en.html’) results in ‘/content/we-retail/us/enn.html’ Steps to Reproduce : 1. Go to console /system/console/jcrresolver 2. input link "/content/we-retail/us//en.html" to Configuration Test 3. click map 4. the result shows Output Primary: /content/we-retail/us/enn.html. Other candidates: /content/we-retail/us//en.html. > unexpected results from resourceresolver.map when input path has adjacent '/' > - > > Key: SLING-8341 > URL: https://issues.apache.org/jira/browse/SLING-8341 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.6.8 >Reporter: Ashok Kumar >Priority: Major > > Scenario : - ResourceResolver.map(‘/content/we-retail/us*//*en.html’) results > in ‘/content/we-retail/us/enn.html’ > Steps to Reproduce : > 1. Go to console /system/console/jcrresolver > 2. input link "/content/we-retail/us//en.html" to Configuration Test > 3. click map > 4. the result shows > Output > Primary: /content/we-retail/us/enn.html. Other candidates: > /content/we-retail/us//en.html. > > Questions: - How to handle such input gracefully > what should be the output - throw an exception and exit OR return the > original path itself OR automatically remove adjacent slashes and replace > that with single '/' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8341) unexpected results from resourceresolver.map when input path has adjacent '/'
Ashok Kumar created SLING-8341: -- Summary: unexpected results from resourceresolver.map when input path has adjacent '/' Key: SLING-8341 URL: https://issues.apache.org/jira/browse/SLING-8341 Project: Sling Issue Type: Bug Components: ResourceResolver Affects Versions: Resource Resolver 1.6.8 Reporter: Ashok Kumar ResourceResolver.map(‘/content/we-retail/us*//*en.html’) results in ‘/content/we-retail/us/enn.html’ Steps to Reproduce : 1. Go to console /system/console/jcrresolver 2. input link "/content/we-retail/us//en.html" to Configuration Test 3. click map 4. the result shows Output Primary: /content/we-retail/us/enn.html. Other candidates: /content/we-retail/us//en.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8335) StringIndexOutOfBoundsException from resolver.map with non absolute path
[ https://issues.apache.org/jira/browse/SLING-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808346#comment-16808346 ] Ashok Kumar commented on SLING-8335: [~kpauls], [~rombert] , please review the PR - and merge - [https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/12] > StringIndexOutOfBoundsException from resolver.map with non absolute path > > > Key: SLING-8335 > URL: https://issues.apache.org/jira/browse/SLING-8335 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.6.8 >Reporter: Ashok Kumar >Priority: Major > Attachments: StringIndexOutofBounds.patch > > Time Spent: 20m > Remaining Estimate: 0h > > ResourceResolver.map("content/we-retail/us/en”) - Forward Mapping > Steps to Reproduce : > 1. go to /system/console/jcrresolver console > 2. input "content/we-retail/us/en" in Test > 3. click map > Output > it give out the error message -: java.lang.StringIndexOutOfBoundsException: > String index out of range: -1 > > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L770] > {quote}final String pathInfo = absPath.substring(path.length()); > {quote} > path = "/content/we-retail/us/en" whereas absPath = "content/we-retail/us/en" > substring fails > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8335) StringIndexOutOfBoundsException from resolver.map with non absolute path
[ https://issues.apache.org/jira/browse/SLING-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806435#comment-16806435 ] Ashok Kumar commented on SLING-8335: [~rombert] Created the PR - [https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/12] . Thanks > StringIndexOutOfBoundsException from resolver.map with non absolute path > > > Key: SLING-8335 > URL: https://issues.apache.org/jira/browse/SLING-8335 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.6.8 >Reporter: Ashok Kumar >Priority: Major > Attachments: StringIndexOutofBounds.patch > > Time Spent: 10m > Remaining Estimate: 0h > > ResourceResolver.map("content/we-retail/us/en”) - Forward Mapping > Steps to Reproduce : > 1. go to /system/console/jcrresolver console > 2. input "content/we-retail/us/en" in Test > 3. click map > Output > it give out the error message -: java.lang.StringIndexOutOfBoundsException: > String index out of range: -1 > > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L770] > {quote}final String pathInfo = absPath.substring(path.length()); > {quote} > path = "/content/we-retail/us/en" whereas absPath = "content/we-retail/us/en" > substring fails > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8335) StringIndexOutOfBoundsException from resolver.map with non absolute path
[ https://issues.apache.org/jira/browse/SLING-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804815#comment-16804815 ] Ashok Kumar commented on SLING-8335: Attached patch has a localised fix as I am not sure if it should be a check right at the top of the method resolveInternal which expects absPath as parameter. > StringIndexOutOfBoundsException from resolver.map with non absolute path > > > Key: SLING-8335 > URL: https://issues.apache.org/jira/browse/SLING-8335 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.6.8 >Reporter: Ashok Kumar >Priority: Major > Attachments: StringIndexOutofBounds.patch > > > ResourceResolver.map("content/we-retail/us/en”) - Forward Mapping > Steps to Reproduce : > 1. go to /system/console/jcrresolver console > 2. input "content/we-retail/us/en" in Test > 3. click map > Output > it give out the error message -: java.lang.StringIndexOutOfBoundsException: > String index out of range: -1 > > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L770] > {quote}final String pathInfo = absPath.substring(path.length()); > {quote} > path = "/content/we-retail/us/en" whereas absPath = "content/we-retail/us/en" > substring fails > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8335) StringIndexOutOfBoundsException from resolver.map with non absolute path
[ https://issues.apache.org/jira/browse/SLING-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-8335: --- Attachment: StringIndexOutofBounds.patch > StringIndexOutOfBoundsException from resolver.map with non absolute path > > > Key: SLING-8335 > URL: https://issues.apache.org/jira/browse/SLING-8335 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.6.8 >Reporter: Ashok Kumar >Priority: Major > Attachments: StringIndexOutofBounds.patch > > > ResourceResolver.map("content/we-retail/us/en”) - Forward Mapping > Steps to Reproduce : > 1. go to /system/console/jcrresolver console > 2. input "content/we-retail/us/en" in Test > 3. click map > Output > it give out the error message -: java.lang.StringIndexOutOfBoundsException: > String index out of range: -1 > > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L770] > {quote}final String pathInfo = absPath.substring(path.length()); > {quote} > path = "/content/we-retail/us/en" whereas absPath = "content/we-retail/us/en" > substring fails > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8335) StringIndexOutOfBoundsException from resolver.map with non absolute path
Ashok Kumar created SLING-8335: -- Summary: StringIndexOutOfBoundsException from resolver.map with non absolute path Key: SLING-8335 URL: https://issues.apache.org/jira/browse/SLING-8335 Project: Sling Issue Type: Bug Components: ResourceResolver Affects Versions: Resource Resolver 1.6.8 Reporter: Ashok Kumar ResourceResolver.map("content/we-retail/us/en”) - Forward Mapping Steps to Reproduce : 1. go to /system/console/jcrresolver console 2. input "content/we-retail/us/en" in Test 3. click map Output it give out the error message -: java.lang.StringIndexOutOfBoundsException: String index out of range: -1 [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L770] {quote}final String pathInfo = absPath.substring(path.length()); {quote} path = "/content/we-retail/us/en" whereas absPath = "content/we-retail/us/en" substring fails -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8314) JCR Installer writeback - primitive array types get lower case prefix , convert primitive arrays to Object arrays
Ashok Kumar created SLING-8314: -- Summary: JCR Installer writeback - primitive array types get lower case prefix , convert primitive arrays to Object arrays Key: SLING-8314 URL: https://issues.apache.org/jira/browse/SLING-8314 Project: Sling Issue Type: Bug Components: Installer Affects Versions: JCR Installer 3.1.26 Reporter: Ashok Kumar When we put a upper case prefix in our config in the repo and then change it via the webconsole it gets the prefix converted into a lower case. This creates issues as Sling only support uppercase prefixes. As the writeback just uses some class from Felix to write the file back (that will write a lower case for primitive arrays and an upper case for Object arrays) the fix should be reasonable straight forward by just massaging the configurations before writing them out via that class and turning all primitive arrays into their respective Object array in updatehandler. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853755#comment-15853755 ] Ashok Kumar edited comment on SLING-6046 at 2/6/17 9:37 AM: To Support Range headers for 100KB and more, created a new [patch | https://issues.apache.org/jira/secure/attachment/12851138/StreamRendererServlet_100KB.patch ] was (Author: ashokpanghal): To Support Range headers for 100KB and more > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar >Assignee: Ian Boston > Fix For: Servlets Get 2.1.20 > > Attachments: Accept-Range Respone Header from S3.png, > NetworkDataS3VideoFromIE11.xml, S3video.html, > StreamRendererServlet_100KB.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-6046: --- Attachment: (was: StreamRendererServlet.java.patch) > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar >Assignee: Ian Boston > Fix For: Servlets Get 2.1.20 > > Attachments: Accept-Range Respone Header from S3.png, > NetworkDataS3VideoFromIE11.xml, S3video.html, > StreamRendererServlet_100KB.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-6046: --- Attachment: StreamRendererServlet_100KB.patch To Support Range headers for 100KB and more > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar >Assignee: Ian Boston > Fix For: Servlets Get 2.1.20 > > Attachments: Accept-Range Respone Header from S3.png, > NetworkDataS3VideoFromIE11.xml, S3video.html, > StreamRendererServlet_100KB.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853730#comment-15853730 ] Ashok Kumar commented on SLING-6046: [~fmeschbe] , The patch we finally applied actually sends Range header for sling.contentlength >100 MB but comment says 100 KB. I believe 100 MB was the real intention or if it was 100 KB , we need to redo the patch. > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar >Assignee: Ian Boston > Fix For: Servlets Get 2.1.20 > > Attachments: Accept-Range Respone Header from S3.png, > NetworkDataS3VideoFromIE11.xml, S3video.html, StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839776#comment-15839776 ] Ashok Kumar commented on SLING-6046: [~i...@tfd.co.uk] , could you please release the next version of get servlet bundle. CC: [~gschneck] > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar >Assignee: Ian Boston > Fix For: Servlets Get 2.1.20 > > Attachments: Accept-Range Respone Header from S3.png, > NetworkDataS3VideoFromIE11.xml, S3video.html, StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734962#comment-15734962 ] Ashok Kumar commented on SLING-6046: initial Patch was not given to address the issue as is but to help us understand that such an approach can resolve the issue. If we can get a consensus on mimetype, size etc. I can work upon a new patch. > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar > Fix For: Servlets Get 2.1.20 > > Attachments: Accept-Range Respone Header from S3.png, > NetworkDataS3VideoFromIE11.xml, S3video.html, StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-6046: --- Attachment: NetworkDataS3VideoFromIE11.xml [~ianeboston] , Attached is the network data for IE requests made for attached html file. 1st Request - For html file at local disk 2nd Request - Blank request for mp4 video url with no request method, response is aborted. No clue what kind of request this is 3rd request - GET request for mp4 video , response comes as 200 with Accept-Ranges header = bytes. 4th Request - GET request with Range request header this time and response comes as 206 . and it goes on till entire mp4 gets streamed. > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar > Attachments: Accept-Range Respone Header from S3.png, > NetworkDataS3VideoFromIE11.xml, S3video.html, StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490035#comment-15490035 ] Ashok Kumar commented on SLING-6046: [~ianeboston] We should send this header for all requests if we do not find a reason not to send it with all responses. Large File download requires download managers to support resume able downloads , only possible if sling supports true Byte Serving. E.g. sites like dropbox, google drive always sends partial response for heavy content stored in cloud. As you rightly said chunk transfer encoding does not support fast forwarding and user always end up downloading entire mp4 file but in chunks. whereas byte serving is by definition is to support streaming of area of interests , which is more powerful feature in case of videos where user wants to skip timelines. I was not sure if sending Accept-Range header with all responses from sling would be conflicting with other response-headers or not, so I did a patch only for video/mp4 format which gets played on MS browsers. I am in agreement to Julian's suggestion of putting it for all "video/*" as an interim relief to video consumers. CC: [~shgupta] , [~julian.resc...@gmx.de] > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar > Attachments: Accept-Range Respone Header from S3.png, S3video.html, > StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-6046: --- Attachment: Accept-Range Respone Header from S3.png S3video.html Attached is a sample html file with a video component having mp4 file get streamed from an S3 server with Partial Download response on IE browser. > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar > Attachments: Accept-Range Respone Header from S3.png, S3video.html, > StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484477#comment-15484477 ] Ashok Kumar commented on SLING-6046: Patch I attached is just to validate the issue , so specific to video/mp4 check. Agree with Shashank, Ideally we should send this header all the time so that any (mime-type) large file download request can be broken down into partial response for IE users. if all agree , I can attach new patch file. > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar > Attachments: StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484268#comment-15484268 ] Ashok Kumar edited comment on SLING-6046 at 9/12/16 2:25 PM: - [~reschke] , For other browsers its not required but IE and edge both wait for this response header before making requests with Range header. Below is excerpt sent by customer - "and alongside I have also reproduced the problem with Microsoft Edge. That would imply a large number of browsers not supporting partial content." was (Author: ashokpanghal): [~reschke] , For other browsers its not required but IE and edge both wait for this response header before making requests with Range header. Below is excerpt sent by customer - "and alongside I have also reproduced the problem with Microsoft Edge. That would imply a large number of browsers not supporting partial content." > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar > Attachments: StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484268#comment-15484268 ] Ashok Kumar commented on SLING-6046: [~reschke] , For other browsers its not required but IE and edge both wait for this response header before making requests with Range header. Below is excerpt sent by customer - "and alongside I have also reproduced the problem with Microsoft Edge. That would imply a large number of browsers not supporting partial content." > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar > Attachments: StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-6046: --- Description: Since IE 11 expects "Accept-Ranges" [0] response header to start making requests with Range header, so sling lack in streaming of video content for IE end users. We can add Accept-Ranges = bytes header to response , either selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or always. Without support of partial content response (206) for IE users, all large video files are being downloaded in single chunk and user need to wait for long to see video content playing. [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 was: Since IE 11 expects "Accept-Ranges" response header to start making requests with Range header, so sling lack in streaming of video content for IE end users. We can add Accept-Ranges = bytes header to response , either selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or always. Without support of partial content response (206) for IE users, all large video files are being downloaded in single chunk and user need to wait for long to see video content playing. > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar > Attachments: StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" [0] response header to start making > requests with Range header, so sling lack in streaming of video content for > IE end users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > [0] http://stackoverflow.com/questions/25654422/http-pseudo-streaming-in-ie11 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-6046: --- Description: Since IE 11 expects "Accept-Ranges" response header to start making requests with Range header, so sling lack in streaming of video content for IE end users. We can add Accept-Ranges = bytes header to response , either selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or always. Without support of partial content response (206) for IE users, all large video files are being downloaded in single chunk and user need to wait for long to see video content playing. was: Since IE 11 expects "Accept-Ranges" response header to start making requests with Range header, so sling lack in streaming of video content for IE end users. We can add Accept-Ranges = bytes header to response , either selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or always. > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar > Attachments: StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" response header to start making requests > with Range header, so sling lack in streaming of video content for IE end > users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > Without support of partial content response (206) for IE users, all large > video files are being downloaded in single chunk and user need to wait for > long to see video content playing. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
[ https://issues.apache.org/jira/browse/SLING-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Kumar updated SLING-6046: --- Attachment: StreamRendererServlet.java.patch Patch attached to ensure StreamRendererServlet sends "Accept-Ranges" header for video/mp4 contenttype to ensure smooth streaming on IE for large files. > While Streaming Video to IE 11, StreamRendererServlet do not use Partial > Content Response [code 206] > > > Key: SLING-6046 > URL: https://issues.apache.org/jira/browse/SLING-6046 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Ashok Kumar > Attachments: StreamRendererServlet.java.patch > > > Since IE 11 expects "Accept-Ranges" response header to start making requests > with Range header, so sling lack in streaming of video content for IE end > users. We can add Accept-Ranges = bytes header to response , either > selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or > always. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-6046) While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206]
Ashok Kumar created SLING-6046: -- Summary: While Streaming Video to IE 11, StreamRendererServlet do not use Partial Content Response [code 206] Key: SLING-6046 URL: https://issues.apache.org/jira/browse/SLING-6046 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Get 2.1.18 Reporter: Ashok Kumar Since IE 11 expects "Accept-Ranges" response header to start making requests with Range header, so sling lack in streaming of video content for IE end users. We can add Accept-Ranges = bytes header to response , either selectively only for video/mp4 mimetype ( video tag on IE looks for mp4 ) or always. -- This message was sent by Atlassian JIRA (v6.3.4#6332)