[jira] [Commented] (SLING-2002) Migrate the Sling website to the ASF CMS
[
https://issues.apache.org/jira/browse/SLING-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245439#comment-13245439
]
Bertrand Delacretaz commented on SLING-2002:
And note also the other adjustments done in the current confluence export
script [1]:
# copy downloads page and replace with patched
cp ${DLPAGE} ${DLTMP}
cat ${DLTMP} | sed
's/http:\/\/cwiki.apache.org\/confluence\/display\/SLINGxSITE\/%5Bpreferred%5D/[preferred]/g'
> ${DLPAGE}
# copy apache-sling.html to index.html
cp ${SITE}/apache-sling.html ${SITE}/index.html
[1] http://sling.apache.org/site/documentation.data/sling.sh
> Migrate the Sling website to the ASF CMS
>
>
> Key: SLING-2002
> URL: https://issues.apache.org/jira/browse/SLING-2002
> Project: Sling
> Issue Type: Task
> Components: Site
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>
> As discussed at http://markmail.org/thread/vbdqqnbaghpcxwp5
> I'll try the tools mentioned at
> http://wiki.apache.org/general/ApacheCms2010#Migrating_from_Confluence
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2002) Migrate the Sling website to the ASF CMS
[ https://issues.apache.org/jira/browse/SLING-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245434#comment-13245434 ] Bertrand Delacretaz commented on SLING-2002: About downloads.cgi, as described at SLING-1425 it seems like we just need to add an executable downloads.cgi script alongside downloads.html: !/bin/sh # Wrapper script around mirrors.cgi script # (we must change to that directory in order for python to pick up the # python includes correctly) cd /www/www.apache.org/dyn/mirrors /www/www.apache.org/dyn/mirrors/mirrors.cgi $* And once we switch we must also make sure the static website parts currently found on people.a.o:/www/sling.apache.org are also copied to the "new" site. > Migrate the Sling website to the ASF CMS > > > Key: SLING-2002 > URL: https://issues.apache.org/jira/browse/SLING-2002 > Project: Sling > Issue Type: Task > Components: Site >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > As discussed at http://markmail.org/thread/vbdqqnbaghpcxwp5 > I'll try the tools mentioned at > http://wiki.apache.org/general/ApacheCms2010#Migrating_from_Confluence -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2002) Migrate the Sling website to the ASF CMS
[ https://issues.apache.org/jira/browse/SLING-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245391#comment-13245391 ] Bertrand Delacretaz commented on SLING-2002: In the meantime, Dan Kulp and the Camel/CXF team has come up with a Maven-driven rendering of Confluence websites. With this we could continue editing our content in Confluence, and have it published much more quickly to sling.apache.org. I have started experimenting with this at https://svn.apache.org/repos/asf/sling/whiteboard/cwiki-to-svn, in revision 1308967 the export works (with no real CSS yet), and updates are correctly detected when running the export again 1-2 minutes after changing a page in Confluence. One thing to look at is the rendering of the http://sling.apache.org/site/downloads.cgi page - I'm not sure at this what's needed to make it dynamic on the live website. See also: http://www.dankulp.com/blog/2012/03/svnpubsub-for-confluence-sites/ http://www.apache.org/dev/project-site.html > Migrate the Sling website to the ASF CMS > > > Key: SLING-2002 > URL: https://issues.apache.org/jira/browse/SLING-2002 > Project: Sling > Issue Type: Task > Components: Site >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > As discussed at http://markmail.org/thread/vbdqqnbaghpcxwp5 > I'll try the tools mentioned at > http://wiki.apache.org/general/ApacheCms2010#Migrating_from_Confluence -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-1725) Register internal post operations as services for consumption by servlets other than the SlingPostServlet
[ https://issues.apache.org/jira/browse/SLING-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245294#comment-13245294 ] Bertrand Delacretaz commented on SLING-1725: I have also updated the "Extending the SlingPostServlet" docs at http://sling.apache.org/site/manipulating-content-the-slingpostservlet-servletspost.html to reflect this change, should be online soon > Register internal post operations as services for consumption by servlets > other than the SlingPostServlet > - > > Key: SLING-1725 > URL: https://issues.apache.org/jira/browse/SLING-1725 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Post 2.0.4 >Reporter: Felix Meschberger >Assignee: Bertrand Delacretaz > Fix For: Servlets Post 2.1.2 > > Attachments: SLING-1725.patch > > > As discussed in [1] it would be useful to have the internal operations of the > Sling POST Servlet available as services for other bundles to reuse. > [1] http://markmail.org/message/a7vrtyhictf7tv4m -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-1437) GSoC 2010: create more unit and integration tests for Sling
[ https://issues.apache.org/jira/browse/SLING-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243695#comment-13243695 ] Bertrand Delacretaz commented on SLING-1437: If a student has specific skills/interests that match this project we might be able to make it happen in 2012 - best is to contact us via the Sling developer's mailing list, http://sling.apache.org/site/project-information.html#ProjectInformation-lists > GSoC 2010: create more unit and integration tests for Sling > --- > > Key: SLING-1437 > URL: https://issues.apache.org/jira/browse/SLING-1437 > Project: Sling > Issue Type: Task > Components: Testing >Reporter: Bertrand Delacretaz > Labels: gsoc, gsoc2010sling, mentor, testing > > Sling already has fairly good test coverage, but there's always room for > improvement. > The goal of this Google Summer of Code project is to create more unit and > integration tests for Sling. > The student will have to get familiar with the Sling codebase, identify areas > where tests are missing, write unit and integration tests to improve the test > coverage, and submit the result as patches that the Sling committers can > verify and hopefully apply. > Another aspect is measuring and reporting (automatically, ideally as part of > our Hudson builds) the actual test coverage - that's easy for unit tests > which run as part of the module builds, but seems to be harder for > integration tests which run in a separate JVM than the one that executes > tests. > See http://tinyurl.com/asfgsoc for the full list of GSoC 2010 projects at the > ASF, and http://community.apache.org/gsoc for general GSoC information. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2443) Missing WWW-Authenticate header on OPTIONS request with trunk servlets.resolver bundle
[
https://issues.apache.org/jira/browse/SLING-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234392#comment-13234392
]
Bertrand Delacretaz commented on SLING-2443:
I agree about the reset in general, but the following pattern seems reasonable
to me:
// Sling servlet is in trouble
response.setHeader("X-something-specific", "some useful value")
response.sendError(...)
And if you do this in a Sling servlet now that won't work...maybe we should
preserve the headers instead of resetting everything?
> Missing WWW-Authenticate header on OPTIONS request with trunk
> servlets.resolver bundle
> --
>
> Key: SLING-2443
> URL: https://issues.apache.org/jira/browse/SLING-2443
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Reporter: Bertrand Delacretaz
>
> Running the launchpad/builder standalone jar from the trunk correctly returns
> an WWW-Authenticate header on an OPTIONS request with no credentials:
> $ curl -D - -X OPTIONS http://localhost:8080/
> HTTP/1.1 401 Unauthorized
> WWW-Authenticate: Basic realm="Jackrabbit Webdav Server"
> Content-Type: ...
> But if I replace the org.apache.sling.servlets.resolver 2.1.0 bundle that's
> in there with the latest snapshot (revision 1302994) that header is missing:
> it gets removed by the response.reset() call in
> DefaultErrorHandlerServlet.sendIntro(...), which makes it impossible to
> connect with WebDAV.
> That response.reset() call was not present in 2.1.0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2443) Missing WWW-Authenticate header on OPTIONS request with trunk servlets.resolver bundle
[
https://issues.apache.org/jira/browse/SLING-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233562#comment-13233562
]
Bertrand Delacretaz commented on SLING-2443:
IIUC it's jackrabbit's AbstractWebdavServlet. sendUnauthorized(...) method that
sends this:
response.setHeader("WWW-Authenticate", getAuthenticateHeaderValue());
if (error == null || error.getErrorCode() !=
HttpServletResponse.SC_UNAUTHORIZED) {
response.sendError(HttpServletResponse.SC_UNAUTHORIZED);
} else {
response.sendError(error.getErrorCode(), error.getStatusPhrase());
}
and that looks a bit tricky to override (just had a quick look)
[1]
http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/server/AbstractWebdavServlet.java
> Missing WWW-Authenticate header on OPTIONS request with trunk
> servlets.resolver bundle
> --
>
> Key: SLING-2443
> URL: https://issues.apache.org/jira/browse/SLING-2443
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Reporter: Bertrand Delacretaz
>
> Running the launchpad/builder standalone jar from the trunk correctly returns
> an WWW-Authenticate header on an OPTIONS request with no credentials:
> $ curl -D - -X OPTIONS http://localhost:8080/
> HTTP/1.1 401 Unauthorized
> WWW-Authenticate: Basic realm="Jackrabbit Webdav Server"
> Content-Type: ...
> But if I replace the org.apache.sling.servlets.resolver 2.1.0 bundle that's
> in there with the latest snapshot (revision 1302994) that header is missing:
> it gets removed by the response.reset() call in
> DefaultErrorHandlerServlet.sendIntro(...), which makes it impossible to
> connect with WebDAV.
> That response.reset() call was not present in 2.1.0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2376) New Startup Features
[ https://issues.apache.org/jira/browse/SLING-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205361#comment-13205361 ] Bertrand Delacretaz commented on SLING-2376: Just so that this info is complete, Carsten's "more information" email thread is at http://markmail.org/message/cikqwmp562vew6pr > New Startup Features > > > Key: SLING-2376 > URL: https://issues.apache.org/jira/browse/SLING-2376 > Project: Sling > Issue Type: New Feature > Components: Launchpad >Affects Versions: Launchpad Installer 1.0.6, Launchpad Base 2.3.0, > Launchpad API 1.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: Launchpad Installer 1.1.0, Launchpad Base 2.4.0, > Launchpad API 1.1.0 > > > With SLING-2372 we have now a mechanism to decide what kind of startup > currently is processed > We could leverage this to create new functionality: > Enhance lauchpad api with the startup mode, the possibility to register > listener which are informed about the startup mode and progress. > Another feature would be to not directly go to the beginning start level of > the framework, but stop at an intermediate level on installs and updates and > from there increase the start level one by one. > This makes updates and installs much smoother > For more information I'll write an email to the dev list :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2380) Make RepositoryTestBase's repository usable from JUnit 4.x style tests
[ https://issues.apache.org/jira/browse/SLING-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191263#comment-13191263 ] Bertrand Delacretaz commented on SLING-2380: Yes, but it doesn't have the on-demand initialization and automatic shutdown that RepositoryTestBase provides. > Make RepositoryTestBase's repository usable from JUnit 4.x style tests > -- > > Key: SLING-2380 > URL: https://issues.apache.org/jira/browse/SLING-2380 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > > Tests currently need to inherit from that class to get a TestRepository, > which forces them to use the old JUnit3.x style. > I'll add a static method to that class, that JUnit 4.x tests can use to get a > repository. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2327) Visible TODOs in the background servlets console
[ https://issues.apache.org/jira/browse/SLING-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185648#comment-13185648 ] Bertrand Delacretaz commented on SLING-2327: > Disabling the plugin by configuration is IMHO not required because the Web > Console is targeted at admins only. ok, I see your point - I'll leave the setting in for now, I don't think it hurts to have it. > Visible TODOs in the background servlets console > > > Key: SLING-2327 > URL: https://issues.apache.org/jira/browse/SLING-2327 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Bertrand Delacretaz >Priority: Minor > > The console plugin of the contrib/extensions/bgservlets displays some ugly > TODOs, those should be removed. > It might also be good to make this plugin optional, in case users want to > supply a custom variant. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2347) Startup filter: allow requests to be rejected with a 503 during startup
[ https://issues.apache.org/jira/browse/SLING-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179608#comment-13179608 ] Bertrand Delacretaz commented on SLING-2347: Whiteboard pattern implemented in revision 1227210 > Startup filter: allow requests to be rejected with a 503 during startup > --- > > Key: SLING-2347 > URL: https://issues.apache.org/jira/browse/SLING-2347 > Project: Sling > Issue Type: New Feature > Components: Extensions >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > > To provide a clear status during startup, especially when that implies > automatic application or content upgrades, I have implemented a simple filter > that causes all Sling requests to return a 503 status until another component > decides that Sling is ready to accept requests. > The use case is to start the bundle that contains this filter at start level > lower than that of the Sling engine, so that the 503 filter kicks in as soon > as the Sling servlet starts, with a simple API to provide progress > information (returned in the body of the 503 response) and remove the filter > when the system is ready. > I'll add that filter as a new bundle under contrib/extensions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after SLING-2094
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174201#comment-13174201 ] Bertrand Delacretaz commented on SLING-2340: > Do we have some samples for forward? or tests? ;-) > jsp:forward no longer works after SLING-2094 > > > Key: SLING-2340 > URL: https://issues.apache.org/jira/browse/SLING-2340 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting JSP 2.0.18 >Reporter: Justin Edelson >Priority: Critical > > The changes made for SLING-2094 seem to have completely broken support for > jsp:forward. Whereas the foward method in PageContextImpl() used to do a > forward, now it just throws an exception: > > http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2288) Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150597#comment-13150597 ] Bertrand Delacretaz commented on SLING-2288: The jar file spec doesn't seem to mention this, but the jar tool docs [1] indicates that jar always puts the manifest first in the jar. https://issuetracker.springsource.com/browse/BNDLR-287 mentions that JarInputStream does enforce it while JarFile does not - I haven't checked that myself in the current JDKs. So it looks like it's really a de facto requirement, and logging a warning is the right thing to do to avoid surprises. [1] http://download.oracle.com/javase/1.3/docs/tooldocs/solaris/jar.html > Bundle jar is silently ignored by the installer if MANIFEST.MF is not the > first file in the archive > --- > > Key: SLING-2288 > URL: https://issues.apache.org/jira/browse/SLING-2288 > Project: Sling > Issue Type: Bug > Components: Installer >Reporter: Bertrand Delacretaz >Assignee: Carsten Ziegeler >Priority: Minor > > A jar file where the MANIFEST.MF is not the first file in the jar is silently > ignored by the installer. > We should at least output a warning, and maybe try harder to find the > manifest, in the Util.getManifest(...) method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2288) Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150584#comment-13150584 ] Bertrand Delacretaz commented on SLING-2288: I'm absolutely fine with just logging - but if we can find the actual spec that helps explain what happens when people have to cope with broken jars. > Bundle jar is silently ignored by the installer if MANIFEST.MF is not the > first file in the archive > --- > > Key: SLING-2288 > URL: https://issues.apache.org/jira/browse/SLING-2288 > Project: Sling > Issue Type: Bug > Components: Installer >Reporter: Bertrand Delacretaz >Assignee: Carsten Ziegeler >Priority: Minor > > A jar file where the MANIFEST.MF is not the first file in the jar is silently > ignored by the installer. > We should at least output a warning, and maybe try harder to find the > manifest, in the Util.getManifest(...) method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2288) Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150562#comment-13150562 ] Bertrand Delacretaz commented on SLING-2288: Do you have an URL to that spec? I see posts from usually knowledgeable people saying that having MANIFEST.MF first in a jar file is not required by the spec, so having that would be good ;-) > Bundle jar is silently ignored by the installer if MANIFEST.MF is not the > first file in the archive > --- > > Key: SLING-2288 > URL: https://issues.apache.org/jira/browse/SLING-2288 > Project: Sling > Issue Type: Bug > Components: Installer >Reporter: Bertrand Delacretaz >Assignee: Carsten Ziegeler >Priority: Minor > > A jar file where the MANIFEST.MF is not the first file in the jar is silently > ignored by the installer. > We should at least output a warning, and maybe try harder to find the > manifest, in the Util.getManifest(...) method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2254) ConcurrentModificationException in AdapterManagerImpl.createAdapterFactoryMap
[ https://issues.apache.org/jira/browse/SLING-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136973#comment-13136973 ] Bertrand Delacretaz commented on SLING-2254: Patch looks good to me > ConcurrentModificationException in AdapterManagerImpl.createAdapterFactoryMap > - > > Key: SLING-2254 > URL: https://issues.apache.org/jira/browse/SLING-2254 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Adapter 2.0.8 >Reporter: Bertrand Delacretaz >Priority: Minor > Attachments: FELIX-2254.patch > > > Got this exception at least once during testing: > org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught > Throwable java.util.ConcurrentModificationException > at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1100) > at java.util.TreeMap$ValueIterator.next(TreeMap.java:1145) > at > org.apache.sling.adapter.internal.AdapterManagerImpl.createAdapterFactoryMap(AdapterManagerImpl.java:385) > at > org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapterFactories(AdapterManagerImpl.java:354) > at > org.apache.sling.adapter.internal.AdapterManagerImpl.copyAdapterFactories(AdapterManagerImpl.java:432) > at > org.apache.sling.adapter.internal.AdapterManagerImpl.createAdapterFactoryMap(AdapterManagerImpl.java:401) > at > org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapterFactories(AdapterManagerImpl.java:354) > at > org.apache.sling.adapter.internal.AdapterManagerImpl.copyAdapterFactories(AdapterManagerImpl.java:432) > at > org.apache.sling.adapter.internal.AdapterManagerImpl.createAdapterFactoryMap(AdapterManagerImpl.java:407) > at > org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapterFactories(AdapterManagerImpl.java:354) > at > org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapterFactories(AdapterManagerImpl.java:331) > at > org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapter(AdapterManagerImpl.java:114) > at > org.apache.sling.api.adapter.SlingAdaptable.adaptTo(SlingAdaptable.java:82) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2254) ConcurrentModificationException in AdapterManagerImpl.createAdapterFactoryMap
[
https://issues.apache.org/jira/browse/SLING-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134983#comment-13134983
]
Bertrand Delacretaz commented on SLING-2254:
The corresponding code is this itreation in createAdapterFactoryMap(...) :
if (afdMap != null) {
for (AdapterFactoryDescriptor afd : afdMap.values()) {
...
> ConcurrentModificationException in AdapterManagerImpl.createAdapterFactoryMap
> -
>
> Key: SLING-2254
> URL: https://issues.apache.org/jira/browse/SLING-2254
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Adapter 2.0.8
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> Got this exception at least once during testing:
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> Throwable java.util.ConcurrentModificationException
> at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1100)
> at java.util.TreeMap$ValueIterator.next(TreeMap.java:1145)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.createAdapterFactoryMap(AdapterManagerImpl.java:385)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapterFactories(AdapterManagerImpl.java:354)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.copyAdapterFactories(AdapterManagerImpl.java:432)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.createAdapterFactoryMap(AdapterManagerImpl.java:401)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapterFactories(AdapterManagerImpl.java:354)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.copyAdapterFactories(AdapterManagerImpl.java:432)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.createAdapterFactoryMap(AdapterManagerImpl.java:407)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapterFactories(AdapterManagerImpl.java:354)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapterFactories(AdapterManagerImpl.java:331)
> at
> org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapter(AdapterManagerImpl.java:114)
> at
> org.apache.sling.api.adapter.SlingAdaptable.adaptTo(SlingAdaptable.java:82)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2245) Scala should use bundleized scala versions avialble in maven central
[ https://issues.apache.org/jira/browse/SLING-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127458#comment-13127458 ] Bertrand Delacretaz commented on SLING-2245: @Michael thanks for the info, I changed it already. We should probably configure animal sniffer to ignore such warnings for scala, but we don't have much more of that in our codebase currently so nothing urgent. > Scala should use bundleized scala versions avialble in maven central > > > Key: SLING-2245 > URL: https://issues.apache.org/jira/browse/SLING-2245 > Project: Sling > Issue Type: Improvement >Reporter: Reto Bachmann-Gmür >Assignee: Bertrand Delacretaz > Attachments: SCALA-BUNDLE-VERSION-2.patch, > SCALA-BUNDLE-VERSION.patch, contrib-patch-fixed > > > Currently it is using scala bundles from > http://scala-tools.org/repo-releases/, presumably equivalent artifacts are > avilable here: > http://repo2.maven.org/maven2/org/apache/servicemix/bundles/org.apache.servicemix.bundles.scala-compiler/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2245) Scala should use bundleized scala versions avialble in maven central
[ https://issues.apache.org/jira/browse/SLING-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127457#comment-13127457 ] Bertrand Delacretaz commented on SLING-2245: @Justin you're right, in this case animal sniffer catched the use of isEmpty() in compiled scala code, that's a good thing! Fixed in revision 1183298 > Scala should use bundleized scala versions avialble in maven central > > > Key: SLING-2245 > URL: https://issues.apache.org/jira/browse/SLING-2245 > Project: Sling > Issue Type: Improvement >Reporter: Reto Bachmann-Gmür >Assignee: Bertrand Delacretaz > Attachments: SCALA-BUNDLE-VERSION-2.patch, > SCALA-BUNDLE-VERSION.patch, contrib-patch-fixed > > > Currently it is using scala bundles from > http://scala-tools.org/repo-releases/, presumably equivalent artifacts are > avilable here: > http://repo2.maven.org/maven2/org/apache/servicemix/bundles/org.apache.servicemix.bundles.scala-compiler/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2245) Scala should use bundleized scala versions avialble in maven central
[
https://issues.apache.org/jira/browse/SLING-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127432#comment-13127432
]
Bertrand Delacretaz commented on SLING-2245:
I'm trying the contrib-patch-fixed, and the build fails with an animalSniffer
error due to this line of scala code in
script/src/main/scala/org/apache/sling/scripting/scala/BundleFS.scala
lazy val fullName: String = (path::name::Nil).filter(!_.isEmpty).mkString("/")
> Scala should use bundleized scala versions avialble in maven central
>
>
> Key: SLING-2245
> URL: https://issues.apache.org/jira/browse/SLING-2245
> Project: Sling
> Issue Type: Improvement
>Reporter: Reto Bachmann-Gmür
> Attachments: SCALA-BUNDLE-VERSION-2.patch,
> SCALA-BUNDLE-VERSION.patch, contrib-patch-fixed
>
>
> Currently it is using scala bundles from
> http://scala-tools.org/repo-releases/, presumably equivalent artifacts are
> avilable here:
> http://repo2.maven.org/maven2/org/apache/servicemix/bundles/org.apache.servicemix.bundles.scala-compiler/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2192) Support JAX-RS resource classes
[ https://issues.apache.org/jira/browse/SLING-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125683#comment-13125683 ] Bertrand Delacretaz commented on SLING-2192: Agreed, so that would be contrib/extensions/jaxrs, with integration tests under contrib/launchpad/testing > Support JAX-RS resource classes > --- > > Key: SLING-2192 > URL: https://issues.apache.org/jira/browse/SLING-2192 > Project: Sling > Issue Type: New Feature >Reporter: Reto Bachmann-Gmür > Attachments: SLING-2192-20110310.patch, SLING-2192-20111004.patch, > SLING-2192-new-jax-rs-bundle.patch, SLING-2192-new-jax-rs-bundle.patch, > SLING-2192-with-sling-style-style-registration.patch, > SLING-2192-with-tests.patch > > > It should be possible to register jax resource classes and providers as > services. As they don't implement a specific interface services that expose > java.lang.Object should be considered as javx-rs services iff they have the > service property "javax.ws.rs" set to true. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2192) Support JAX-RS resource classes
[ https://issues.apache.org/jira/browse/SLING-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125665#comment-13125665 ] Bertrand Delacretaz commented on SLING-2192: Thanks for the updated patch, I still have a few comments: 1) Are the RequestUriOptingServlet2Test.java and RequestUriOptingServlet2 tests useful with your latest patch? IIUC you switched to servlet filters so they're probably not needed, or should be part of a separate issue. 2) The SimpleRootResourceTest of my SLING-2192-with-tests patch is missing 3) The new bundle should be at bundles/extensions/jaxrs like in that patch 4) I think we don't need the samples/slingrs, we'll create integration tests instead, that also act as code samples > Support JAX-RS resource classes > --- > > Key: SLING-2192 > URL: https://issues.apache.org/jira/browse/SLING-2192 > Project: Sling > Issue Type: New Feature >Reporter: Reto Bachmann-Gmür > Attachments: SLING-2192-20110310.patch, SLING-2192-20111004.patch, > SLING-2192-new-jax-rs-bundle.patch, SLING-2192-new-jax-rs-bundle.patch, > SLING-2192-with-sling-style-style-registration.patch, > SLING-2192-with-tests.patch > > > It should be possible to register jax resource classes and providers as > services. As they don't implement a specific interface services that expose > java.lang.Object should be considered as javx-rs services iff they have the > service property "javax.ws.rs" set to true. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
