[jira] [Closed] (SLING-9061) Evaluate ORIGIN header in addition to Referer header in ReferrerFilter
[ https://issues.apache.org/jira/browse/SLING-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-9061. --- > Evaluate ORIGIN header in addition to Referer header in ReferrerFilter > -- > > Key: SLING-9061 > URL: https://issues.apache.org/jira/browse/SLING-9061 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Security 1.1.16 >Reporter: Konrad Windszus >Assignee: Dan Klco >Priority: Major > Fix For: Security 1.2.0 > > > As discussed in > https://issues.apache.org/jira/browse/SLING-9043?focusedCommentId=17031442&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17031442 > the origin header should be used to implement some CSRF protection. See also > https://owasp.org/www-project-cheat-sheets/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html#verifying-origin-with-standard-headers, > https://seclab.stanford.edu/websec/csrf/csrf.pdf and > https://www.sjoerdlangkemper.nl/2019/02/27/prevent-csrf-with-the-origin-http-request-header/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12324) Referrer Filter Reference Policy Should be Dynamic
Dan Klco created SLING-12324:
Summary: Referrer Filter Reference Policy Should be Dynamic
Key: SLING-12324
URL: https://issues.apache.org/jira/browse/SLING-12324
Project: Sling
Issue Type: Improvement
Components: Sling Security
Affects Versions: Security 1.2.0
Reporter: Dan Klco
Fix For: Security 1.2.2
The Reference Policy for amendments to the ReferrerFilter:
[https://github.com/apache/sling-org-apache-sling-security/blob/master/src/main/java/org/apache/sling/security/impl/ReferrerFilter.java#L283C39-L283C60]
are set to
{{policyOption = ReferencePolicyOption.GREEDY, cardinality =
ReferenceCardinality.MULTIPLE}} so they will pick up multiple amendments if
available at initialization, however because the ReferencePolicy is still
static, new amendments available after the component initializes will not be
detected.
To support this, the ReferencePolicy should be set to Dynamic. This will also
require changing from constructor based parameters to bind parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12403) Ability to review sling authenticators handling authentication request
[ https://issues.apache.org/jira/browse/SLING-12403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872041#comment-17872041 ] Dan Klco commented on SLING-12403: -- PR: [https://github.com/apache/sling-org-apache-sling-auth-core/pull/15] > Ability to review sling authenticators handling authentication request > -- > > Key: SLING-12403 > URL: https://issues.apache.org/jira/browse/SLING-12403 > Project: Sling > Issue Type: Improvement > Components: Authentication >Reporter: Patrique Legault >Priority: Major > > In situations where authentication is handled in correctly it is important to > be able to understand which authenticator was called upon to perform > authentication. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-2611) MockResource Properties
Dan Klco created SLING-2611: --- Summary: MockResource Properties Key: SLING-2611 URL: https://issues.apache.org/jira/browse/SLING-2611 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Commons Testing 2.0.10 Reporter: Dan Klco Priority: Minor A useful feature for the MockResource testing class would be the ability to specify additional properties and return them when the MockResource is adapted into a ValueMap. I use this on nearly every project I've been on to test services. I've attached a patch file which adds two methods: addProperty - add a single key, value set getProperties - returns the map of properties which can be modified And then in the adaptTo method I just added all of the properties in the map into the returned ValueMap. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2611) MockResource Properties
[ https://issues.apache.org/jira/browse/SLING-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2611: Attachment: MockResource-Properties.diff Attaching patch file > MockResource Properties > --- > > Key: SLING-2611 > URL: https://issues.apache.org/jira/browse/SLING-2611 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Commons Testing 2.0.10 >Reporter: Dan Klco >Priority: Minor > Labels: newbie, patch, test > Attachments: MockResource-Properties.diff > > > A useful feature for the MockResource testing class would be the ability to > specify additional properties and return them when the MockResource is > adapted into a ValueMap. > I use this on nearly every project I've been on to test services. I've > attached a patch file which adds two methods: > addProperty - add a single key, value set > getProperties - returns the map of properties which can be modified > And then in the adaptTo method I just added all of the properties in the map > into the returned ValueMap. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2629) [Tooling] Add tycho build to Slingclipse
[ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484310#comment-13484310 ] Dan Klco commented on SLING-2629: - I'll second the issue, the patch does not seem to be working for me. I tried through eclipse and the patch CLI tool. > [Tooling] Add tycho build to Slingclipse > > > Key: SLING-2629 > URL: https://issues.apache.org/jira/browse/SLING-2629 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Antonio Sanso >Assignee: Antonio Sanso >Priority: Minor > Attachments: SLING-2629-tycho-build.diff > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2629) [Tooling] Add tycho build to Slingclipse
[ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2629: Attachment: SLING-2629-tycho-build-1.diff I attached a new patch I created based on Robert's patch. It seemed to work when I applied it to a new checkout locally. Please check it out and let me know. > [Tooling] Add tycho build to Slingclipse > > > Key: SLING-2629 > URL: https://issues.apache.org/jira/browse/SLING-2629 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Antonio Sanso >Assignee: Antonio Sanso >Priority: Minor > Attachments: SLING-2629-tycho-build-1.diff, > SLING-2629-tycho-build.diff > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2634) [Tooling] Slingclipse should expose the operations it performs and their results
[ https://issues.apache.org/jira/browse/SLING-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484872#comment-13484872 ] Dan Klco commented on SLING-2634: - An interesting way to do that might be to create a SLF4J logger which logs to the console on INFO and logs to the console + Eclipse event log in errors and warnings. > [Tooling] Slingclipse should expose the operations it performs and their > results > > > Key: SLING-2634 > URL: https://issues.apache.org/jira/browse/SLING-2634 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Robert Munteanu >Priority: Minor > > I think that it's important for the user to know what Slingclipse is doing, > especially since it uses some heuristics to detect Sling-based projects. > My first thoughts would be: > * from a UI point of view start with something simple like a text-only > console . The subclipse console is a good starting point, we can simply log > things like > ADD $SLING_URL $PROJECT/$RESOURCE 200 OK > REMOVE $SLING_URL $PROJECT/$RESOURCE 500 Internal Server Error > * from an implementation point of view we could use something like a command > pattern ( SaveResource command, DeleteResourceCommand ) . This would have the > benefit of allowing this logging easily + encapsulating the operations for > batching, handling of offline operations, redo etc. > Thoughts? I'm willing to look into this, at least for a first iteration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2636) [Tooling] Add ability to Import from Sling Repository
Dan Klco created SLING-2636: --- Summary: [Tooling] Add ability to Import from Sling Repository Key: SLING-2636 URL: https://issues.apache.org/jira/browse/SLING-2636 Project: Sling Issue Type: Sub-task Components: Extensions Reporter: Dan Klco Priority: Minor -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2637) [Tooling] Ignore Build Output & Eclipse Metadata
Dan Klco created SLING-2637: --- Summary: [Tooling] Ignore Build Output & Eclipse Metadata Key: SLING-2637 URL: https://issues.apache.org/jira/browse/SLING-2637 Project: Sling Issue Type: Sub-task Components: Extensions Reporter: Dan Klco Priority: Trivial I prefer to ignore the following patters: .project .classpath target .settings They can all be rebuilt from the Maven POM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2637) [Tooling] Ignore Build Output & Eclipse Metadata
[ https://issues.apache.org/jira/browse/SLING-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2637: Attachment: SLING-2637-Ignore-Pattern.diff Attached is a patch for ignoring these files > [Tooling] Ignore Build Output & Eclipse Metadata > > > Key: SLING-2637 > URL: https://issues.apache.org/jira/browse/SLING-2637 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Dan Klco >Priority: Trivial > Attachments: SLING-2637-Ignore-Pattern.diff > > Original Estimate: 10m > Remaining Estimate: 10m > > I prefer to ignore the following patters: > .project > .classpath > target > .settings > They can all be rebuilt from the Maven POM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2631) [Tooling] Multiple logged exceptions related to Invalid URIs
[ https://issues.apache.org/jira/browse/SLING-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484948#comment-13484948 ] Dan Klco commented on SLING-2631: - I'm thinking we're going to want the option to enable/disable the save event on every project. We may even want to consider creating a custom project type for Sling projects. We will also definitely need the ability to define paths to ignore. For example, you certainly wouldn't want your code to be pushed to Sling every time your target was updated. > [Tooling] Multiple logged exceptions related to Invalid URIs > > > Key: SLING-2631 > URL: https://issues.apache.org/jira/browse/SLING-2631 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Robert Munteanu >Assignee: Antonio Sanso > Original Estimate: 0h > Remaining Estimate: 0h > > I get lots of such exceptions when I start Eclipse. I disabled sync after > every save for now. > !ENTRY org.eclipse.core.resources 4 2 2012-10-25 23:30:31.945 > !MESSAGE Problems occurred when invoking code from plug-in: > "org.eclipse.core.resources". > !STACK 0 > java.lang.IllegalArgumentException: Invalid uri > 'http://localhost:8080metrixx-commons-core/target/classes/META-INF': > invalid port number > at > org.apache.commons.httpclient.HttpMethodBase.(HttpMethodBase.java:222) > at > org.apache.commons.httpclient.methods.ExpectContinueMethod.(ExpectContinueMethod.java:93) > at > org.apache.commons.httpclient.methods.EntityEnclosingMethod.(EntityEnclosingMethod.java:119) > at > org.apache.commons.httpclient.methods.PostMethod.(PostMethod.java:106) > at > org.apache.sling.slingclipse.http.impl.RepositoryImpl.addNode(RepositoryImpl.java:37) > at > org.apache.sling.slingclipse.SlingclipseListener$1.visit(SlingclipseListener.java:91) > at > org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:69) > at > org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80) > at > org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80) > at > org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80) > at > org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80) > at > org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80) > at > org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:49) > at > org.apache.sling.slingclipse.SlingclipseListener.resourceChanged(SlingclipseListener.java:42) > at > org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:291) > at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) > at > org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:285) > at > org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:149) > at > org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:395) > at > org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1530) > at > org.eclipse.core.internal.resources.Resource.refreshLocal(Resource.java:1712) > at > org.eclipse.core.internal.refresh.RefreshJob.runInWorkspace(RefreshJob.java:167) > at > org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38) > at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2636) [Tooling] Add ability to Import from Sling Repository
[ https://issues.apache.org/jira/browse/SLING-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2636: Attachment: SLING-2636-Import-Wizard.diff Attached is a start for the UI for the Import Wizard. It's pretty crude, but it should work for the initial release. Right now the UI is there, but it doesn't actually import content from the repository. Eventually, it would be nice to have the ability to browse the repository instead of just entering a path. > [Tooling] Add ability to Import from Sling Repository > - > > Key: SLING-2636 > URL: https://issues.apache.org/jira/browse/SLING-2636 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Dan Klco >Priority: Minor > Attachments: SLING-2636-Import-Wizard.diff > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2636) [Tooling] Add ability to Import from Sling Repository
[ https://issues.apache.org/jira/browse/SLING-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2636: Attachment: SLING-2636-Import-IN-PROGRESS.diff Okay, cool. I have some code (attached) that is a work in progress, if you want that. One of the things I was thinking is that the FileInfo class would be a lot more useful if it could be directly instantiated from the Eclipse internal classes and then from it you could get the Filesystem File, Eclipse resource and corresponding Resource path. Also, how were you planning on parsing/constructing the JSON? It seems like Apache projects can use org.json code (http://www.apache.org/legal/resolved.html#json), so I was using that, but I don't think it's really optimal to directly include the source in our project. That being said, the way dependencies are handled in Eclipse plugins makes loading the code from the POM awkward as the classes handling the JSON parsing would have to be ouside of the reactor build. > [Tooling] Add ability to Import from Sling Repository > - > > Key: SLING-2636 > URL: https://issues.apache.org/jira/browse/SLING-2636 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Dan Klco >Assignee: Antonio Sanso >Priority: Minor > Attachments: SLING-2636-Import-IN-PROGRESS.diff, > SLING-2636-Import-Wizard.diff > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2635) [Tooling] Logging framework for Slingclipse
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487717#comment-13487717 ] Dan Klco edited comment on SLING-2635 at 10/31/12 12:46 PM: I think it may be cleaner to abstract the logging. I can look into creating a SLF4J wrapper for the Plugin's Eclipse logger. That way we can swap out with whatever we'd want if we decide to move in a different direction. was (Author: klcodanr): I'd actually recommend abstracting the logging. I can look into creating a SLF4J wrapper for the Plugin's Eclipse logger. That way we can swap out with whatever we'd want if we decide to move in a different direction. > [Tooling] Logging framework for Slingclipse > --- > > Key: SLING-2635 > URL: https://issues.apache.org/jira/browse/SLING-2635 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Antonio Sanso >Assignee: Antonio Sanso > Attachments: SLING-2635.diff > > > We need a Logging framework for Slingclipse. > I see two options at the moment: > - using a log framework as SLF4J logger or other similar > - using the embedded Eclipse logging framework -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2635) [Tooling] Logging framework for Slingclipse
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487717#comment-13487717 ] Dan Klco commented on SLING-2635: - I'd actually recommend abstracting the logging. I can look into creating a SLF4J wrapper for the Plugin's Eclipse logger. That way we can swap out with whatever we'd want if we decide to move in a different direction. > [Tooling] Logging framework for Slingclipse > --- > > Key: SLING-2635 > URL: https://issues.apache.org/jira/browse/SLING-2635 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Antonio Sanso >Assignee: Antonio Sanso > Attachments: SLING-2635.diff > > > We need a Logging framework for Slingclipse. > I see two options at the moment: > - using a log framework as SLF4J logger or other similar > - using the embedded Eclipse logging framework -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2641) Make listChildren() Iterable
Dan Klco created SLING-2641: --- Summary: Make listChildren() Iterable Key: SLING-2641 URL: https://issues.apache.org/jira/browse/SLING-2641 Project: Sling Issue Type: Improvement Components: API, General, ResourceResolver, Testing Affects Versions: API 2.2.4 Reporter: Dan Klco When you call Resource.listChildren() or resourceResolver.listChildren() it returns a Iterator, this is fine if you want to just iterate through the results using old-style while loops, but if you want to use enhanced loops, you are out of luck. I'm proposing adding an interface to return from these methods which extends both Iterator and Iterable. This will allow for using enhanced loops with the results of listChildren(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2641) Make listChildren() Iterable
[ https://issues.apache.org/jira/browse/SLING-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2641: Attachment: SLING-2641-Resource-Iterator.diff Patch for the change proposed in this issue. > Make listChildren() Iterable > > > Key: SLING-2641 > URL: https://issues.apache.org/jira/browse/SLING-2641 > Project: Sling > Issue Type: Improvement > Components: API, General, ResourceResolver, Testing >Affects Versions: API 2.2.4 >Reporter: Dan Klco > Labels: features, noob, patch > Attachments: SLING-2641-Resource-Iterator.diff > > > When you call Resource.listChildren() or resourceResolver.listChildren() it > returns a Iterator, this is fine if you want to just iterate > through the results using old-style while loops, but if you want to use > enhanced loops, you are out of luck. > I'm proposing adding an interface to return from these methods which extends > both Iterator and Iterable. This will allow for using > enhanced loops with the results of listChildren(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2642) org.apache.sling.commons.classloader
Dan Klco created SLING-2642: --- Summary: org.apache.sling.commons.classloader Key: SLING-2642 URL: https://issues.apache.org/jira/browse/SLING-2642 Project: Sling Issue Type: Bug Reporter: Dan Klco -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2642) org.apache.sling.commons.classloader Test Failure
[ https://issues.apache.org/jira/browse/SLING-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2642: Component/s: Commons Description: When attempting to compile Sling from the source based on the README in the root of the project, I get a NoClassDefFoundError error when it attempts to run the tests for org.apache.sling.commons.classloader. The following class is missing: org/ops4j/pax/swissbox/framework/RemoteFrameworkImpl Environment: Java(TM) SE Runtime Environment (build 1.6.0_30-b12) Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode) Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Windows 7 Affects Version/s: Commons ClassLoader 1.3.0 Summary: org.apache.sling.commons.classloader Test Failure (was: org.apache.sling.commons.classloader) > org.apache.sling.commons.classloader Test Failure > - > > Key: SLING-2642 > URL: https://issues.apache.org/jira/browse/SLING-2642 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons ClassLoader 1.3.0 > Environment: Java(TM) SE Runtime Environment (build 1.6.0_30-b12) > Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode) > Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) > Windows 7 >Reporter: Dan Klco > Attachments: failsafe-summary.xml, maven-output.txt, > org.apache.sling.commons.classloader.it.DynamicClassLoaderIT.txt, > TEST-org.apache.sling.commons.classloader.it.DynamicClassLoaderIT.xml > > > When attempting to compile Sling from the source based on the README in the > root of the project, I get a NoClassDefFoundError error when it attempts to > run the tests for org.apache.sling.commons.classloader. The following class > is missing: > org/ops4j/pax/swissbox/framework/RemoteFrameworkImpl -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2642) org.apache.sling.commons.classloader Test Failure
[ https://issues.apache.org/jira/browse/SLING-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2642: Attachment: maven-output.txt TEST-org.apache.sling.commons.classloader.it.DynamicClassLoaderIT.xml org.apache.sling.commons.classloader.it.DynamicClassLoaderIT.txt failsafe-summary.xml Attaching test results and Maven output > org.apache.sling.commons.classloader Test Failure > - > > Key: SLING-2642 > URL: https://issues.apache.org/jira/browse/SLING-2642 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons ClassLoader 1.3.0 > Environment: Java(TM) SE Runtime Environment (build 1.6.0_30-b12) > Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode) > Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) > Windows 7 >Reporter: Dan Klco > Attachments: failsafe-summary.xml, maven-output.txt, > org.apache.sling.commons.classloader.it.DynamicClassLoaderIT.txt, > TEST-org.apache.sling.commons.classloader.it.DynamicClassLoaderIT.xml > > > When attempting to compile Sling from the source based on the README in the > root of the project, I get a NoClassDefFoundError error when it attempts to > run the tests for org.apache.sling.commons.classloader. The following class > is missing: > org/ops4j/pax/swissbox/framework/RemoteFrameworkImpl -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2643) org.apache.sling.commons.log Test Failure
Dan Klco created SLING-2643: --- Summary: org.apache.sling.commons.log Test Failure Key: SLING-2643 URL: https://issues.apache.org/jira/browse/SLING-2643 Project: Sling Issue Type: Bug Components: Commons Affects Versions: Commons Log 3.0.0 Environment: Java(TM) SE Runtime Environment (build 1.6.0_30-b12) Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode) Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Windows 7 Reporter: Dan Klco Attachments: maven-logs.txt, org.apache.sling.commons.log.internal.slf4j.SlingLogWriterTest.txt, TEST-org.apache.sling.commons.log.internal.slf4j.SlingLogWriterTest.xml When attempting to compile Sling from the source based on the README in the root of the project, the tests for the project org.apache.sling.commons.log fail. I think the problem here is that it's not making the protectedParent directory locked when it should. In this case the test should just abort instead of failing. Not sure if this is an JVM/OS issue, the code doesn't seem to be checking the response from the attempt to deny write access to the directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2643) org.apache.sling.commons.log Test Failure
[ https://issues.apache.org/jira/browse/SLING-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2643: Attachment: TEST-org.apache.sling.commons.log.internal.slf4j.SlingLogWriterTest.xml org.apache.sling.commons.log.internal.slf4j.SlingLogWriterTest.txt maven-logs.txt Attaching Maven output and test results > org.apache.sling.commons.log Test Failure > - > > Key: SLING-2643 > URL: https://issues.apache.org/jira/browse/SLING-2643 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons Log 3.0.0 > Environment: Java(TM) SE Runtime Environment (build 1.6.0_30-b12) > Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode) > Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) > Windows 7 >Reporter: Dan Klco > Attachments: maven-logs.txt, > org.apache.sling.commons.log.internal.slf4j.SlingLogWriterTest.txt, > TEST-org.apache.sling.commons.log.internal.slf4j.SlingLogWriterTest.xml > > > When attempting to compile Sling from the source based on the README in the > root of the project, the tests for the project org.apache.sling.commons.log > fail. I think the problem here is that it's not making the protectedParent > directory locked when it should. In this case the test should just abort > instead of failing. > Not sure if this is an JVM/OS issue, the code doesn't seem to be checking the > response from the attempt to deny write access to the directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2643) org.apache.sling.commons.log Test Failure
[ https://issues.apache.org/jira/browse/SLING-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2643: Attachment: SLING-2643-Skip-If-Writable.diff I think the problem occurs when a user with administrative access runs this test. The user will still have write privileges in Windows at least. Attached is a patch which only executes the actual tests if the file is not writable instead of failing if the file is writable. > org.apache.sling.commons.log Test Failure > - > > Key: SLING-2643 > URL: https://issues.apache.org/jira/browse/SLING-2643 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons Log 3.0.0 > Environment: Java(TM) SE Runtime Environment (build 1.6.0_30-b12) > Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode) > Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) > Windows 7 >Reporter: Dan Klco > Attachments: maven-logs.txt, > org.apache.sling.commons.log.internal.slf4j.SlingLogWriterTest.txt, > SLING-2643-Skip-If-Writable.diff, > TEST-org.apache.sling.commons.log.internal.slf4j.SlingLogWriterTest.xml > > > When attempting to compile Sling from the source based on the README in the > root of the project, the tests for the project org.apache.sling.commons.log > fail. I think the problem here is that it's not making the protectedParent > directory locked when it should. In this case the test should just abort > instead of failing. > Not sure if this is an JVM/OS issue, the code doesn't seem to be checking the > response from the attempt to deny write access to the directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2641) Make listChildren() Iterable
[ https://issues.apache.org/jira/browse/SLING-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487936#comment-13487936 ] Dan Klco commented on SLING-2641: - [~cziegeler], that's a good idea. Actually, it would be nice if the method followed Java Bean naming standards (getChildren or getChildResources) so you could invoke it directly from JSTL. Ex: > Make listChildren() Iterable > > > Key: SLING-2641 > URL: https://issues.apache.org/jira/browse/SLING-2641 > Project: Sling > Issue Type: Improvement > Components: API, General, ResourceResolver, Testing >Affects Versions: API 2.2.4 >Reporter: Dan Klco > Labels: features, noob, patch > Attachments: SLING-2641-Resource-Iterator.diff > > > When you call Resource.listChildren() or resourceResolver.listChildren() it > returns a Iterator, this is fine if you want to just iterate > through the results using old-style while loops, but if you want to use > enhanced loops, you are out of luck. > I'm proposing adding an interface to return from these methods which extends > both Iterator and Iterable. This will allow for using > enhanced loops with the results of listChildren(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2641) Make listChildren() Iterable
[ https://issues.apache.org/jira/browse/SLING-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488798#comment-13488798 ] Dan Klco commented on SLING-2641: - Felix, so would the new method return an object which is an Iterator and also Iterable? Or might it even return an object which allows for random access as well? In that case you may have performance concerns over large sets of children, but it would be more of an convenience method. > Make listChildren() Iterable > > > Key: SLING-2641 > URL: https://issues.apache.org/jira/browse/SLING-2641 > Project: Sling > Issue Type: Improvement > Components: API, General, ResourceResolver, Testing >Affects Versions: API 2.2.4 >Reporter: Dan Klco > Labels: features, noob, patch > Attachments: SLING-2641-Resource-Iterator.diff > > > When you call Resource.listChildren() or resourceResolver.listChildren() it > returns a Iterator, this is fine if you want to just iterate > through the results using old-style while loops, but if you want to use > enhanced loops, you are out of luck. > I'm proposing adding an interface to return from these methods which extends > both Iterator and Iterable. This will allow for using > enhanced loops with the results of listChildren(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2642) org.apache.sling.commons.classloader Test Failure
[ https://issues.apache.org/jira/browse/SLING-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2642: Attachment: SLING-2642-Update-Pax-Exam-Version.diff To be honest, I'm still not sure what is breaking, but it seems like it's something internal to Pax Exam. When I updated from the Release Candidate to the Release for the version, this error went away. I kept the same version to avoid introducing any further errors. > org.apache.sling.commons.classloader Test Failure > - > > Key: SLING-2642 > URL: https://issues.apache.org/jira/browse/SLING-2642 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons ClassLoader 1.3.0 > Environment: Java(TM) SE Runtime Environment (build 1.6.0_30-b12) > Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode) > Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) > Windows 7 >Reporter: Dan Klco > Attachments: failsafe-summary.xml, maven-output.txt, > org.apache.sling.commons.classloader.it.DynamicClassLoaderIT.txt, > SLING-2642-Update-Pax-Exam-Version.diff, > TEST-org.apache.sling.commons.classloader.it.DynamicClassLoaderIT.xml > > > When attempting to compile Sling from the source based on the README in the > root of the project, I get a NoClassDefFoundError error when it attempts to > run the tests for org.apache.sling.commons.classloader. The following class > is missing: > org/ops4j/pax/swissbox/framework/RemoteFrameworkImpl -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2636) [Tooling] Add ability to Import from Sling Repository
[ https://issues.apache.org/jira/browse/SLING-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488979#comment-13488979 ] Dan Klco commented on SLING-2636: - Both make sense to me. One nice thing about the name not starting with a period is that you wouldn't have to change your settings in Eclipse to see it. How are we planning on handing nodes which are not nt:files or nt:folders? It seems like we may want to pull down the node type configuration from the repository and use it to determine how to serialize the JSON. > [Tooling] Add ability to Import from Sling Repository > - > > Key: SLING-2636 > URL: https://issues.apache.org/jira/browse/SLING-2636 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Dan Klco >Assignee: Antonio Sanso >Priority: Minor > Attachments: SLING-2636-Import-IN-PROGRESS.diff, > SLING-2636-Import-Wizard.diff > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2647) Track Import Progress
Dan Klco created SLING-2647: --- Summary: Track Import Progress Key: SLING-2647 URL: https://issues.apache.org/jira/browse/SLING-2647 Project: Sling Issue Type: Sub-task Components: Extensions Reporter: Dan Klco Priority: Minor We should track the progress of imports by using Jobs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2647) Track Import Progress
[ https://issues.apache.org/jira/browse/SLING-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2647: Attachment: SLING-2647-Track-Progress.diff Attached is a patch for tracking the progress. I also removed the check to make sure that the import path ends with jcr_root. I would think you'd often want to import just a subtree of the overall Repo. > Track Import Progress > - > > Key: SLING-2647 > URL: https://issues.apache.org/jira/browse/SLING-2647 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Dan Klco >Priority: Minor > Attachments: SLING-2647-Track-Progress.diff > > > We should track the progress of imports by using Jobs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2647) Track Import Progress
[ https://issues.apache.org/jira/browse/SLING-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489667#comment-13489667 ] Dan Klco commented on SLING-2647: - I wouldn't see a scenario where I would want to export the entire repository. It seems a lot more likely that I would want to export only the portion of the repository I'm working on. > Track Import Progress > - > > Key: SLING-2647 > URL: https://issues.apache.org/jira/browse/SLING-2647 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Dan Klco >Assignee: Antonio Sanso >Priority: Minor > Attachments: SLING-2647-Track-Progress.diff > > > We should track the progress of imports by using Jobs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2647) Track Import Progress
[ https://issues.apache.org/jira/browse/SLING-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489693#comment-13489693 ] Dan Klco commented on SLING-2647: - Right, that makes sense, so should it do a contains() rather than an endsWith()? > Track Import Progress > - > > Key: SLING-2647 > URL: https://issues.apache.org/jira/browse/SLING-2647 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Dan Klco >Assignee: Antonio Sanso >Priority: Minor > Attachments: SLING-2647-Track-Progress.diff > > > We should track the progress of imports by using Jobs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2648) Add Resource Access Tags
Dan Klco created SLING-2648:
---
Summary: Add Resource Access Tags
Key: SLING-2648
URL: https://issues.apache.org/jira/browse/SLING-2648
Project: Sling
Issue Type: New Feature
Components: Scripting
Affects Versions: Scripting JSP-Taglib 2.1.8
Reporter: Dan Klco
It would be really nice to be able to access resources through tags rather than
having to use Scriptlet for even basic Resource iteration. I've created a
patch for adding tags to:
- Get a Resource
- List Child Resources
- Adapt adaptables to other classes
- Get properties from ValueMaps (with default values)
With these new tags, you will be able to do things like create an entire
navigation without scriptlet:
Title: ${title}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2648) Add Resource Access Tags
[
https://issues.apache.org/jira/browse/SLING-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco updated SLING-2648:
Attachment: SLING-2648-Add-Resource-Access-Tags.diff
Adding a patch for the Resource Access Tags
> Add Resource Access Tags
>
>
> Key: SLING-2648
> URL: https://issues.apache.org/jira/browse/SLING-2648
> Project: Sling
> Issue Type: New Feature
> Components: Scripting
>Affects Versions: Scripting JSP-Taglib 2.1.8
>Reporter: Dan Klco
> Attachments: SLING-2648-Add-Resource-Access-Tags.diff
>
>
> It would be really nice to be able to access resources through tags rather
> than having to use Scriptlet for even basic Resource iteration. I've created
> a patch for adding tags to:
> - Get a Resource
> - List Child Resources
> - Adapt adaptables to other classes
> - Get properties from ValueMaps (with default values)
> With these new tags, you will be able to do things like create an entire
> navigation without scriptlet:
>
>
>
>
>
> path="${child.path}/jcr:content" />
> adaptTo="org.apache.sling.api.resource.ValueMap" var="childProperties" />
> var="title" properties="${childProperties}" />
> Title: ${title}
>
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2648) Add Resource Access Tags
[
https://issues.apache.org/jira/browse/SLING-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco updated SLING-2648:
Labels: patch scripting taglib (was: )
> Add Resource Access Tags
>
>
> Key: SLING-2648
> URL: https://issues.apache.org/jira/browse/SLING-2648
> Project: Sling
> Issue Type: New Feature
> Components: Scripting
>Affects Versions: Scripting JSP-Taglib 2.1.8
>Reporter: Dan Klco
> Labels: patch, scripting, taglib
> Attachments: SLING-2648-Add-Resource-Access-Tags.diff
>
>
> It would be really nice to be able to access resources through tags rather
> than having to use Scriptlet for even basic Resource iteration. I've created
> a patch for adding tags to:
> - Get a Resource
> - List Child Resources
> - Adapt adaptables to other classes
> - Get properties from ValueMaps (with default values)
> With these new tags, you will be able to do things like create an entire
> navigation without scriptlet:
>
>
>
>
>
> path="${child.path}/jcr:content" />
> adaptTo="org.apache.sling.api.resource.ValueMap" var="childProperties" />
> var="title" properties="${childProperties}" />
> Title: ${title}
>
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2648) Add Resource Access Tags
[
https://issues.apache.org/jira/browse/SLING-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco updated SLING-2648:
Attachment: SLING-2648-Document-Tags.diff
SLING-2648-Add-Resource-Access-Tags.diff
Updating the original patch to make a few more attributes required and adding a
patch to add a page documenting the available tags.
> Add Resource Access Tags
>
>
> Key: SLING-2648
> URL: https://issues.apache.org/jira/browse/SLING-2648
> Project: Sling
> Issue Type: New Feature
> Components: Scripting
>Affects Versions: Scripting JSP-Taglib 2.1.8
>Reporter: Dan Klco
> Labels: patch, scripting, taglib
> Attachments: SLING-2648-Add-Resource-Access-Tags.diff,
> SLING-2648-Add-Resource-Access-Tags.diff, SLING-2648-Document-Tags.diff
>
>
> It would be really nice to be able to access resources through tags rather
> than having to use Scriptlet for even basic Resource iteration. I've created
> a patch for adding tags to:
> - Get a Resource
> - List Child Resources
> - Adapt adaptables to other classes
> - Get properties from ValueMaps (with default values)
> With these new tags, you will be able to do things like create an entire
> navigation without scriptlet:
>
>
>
>
>
> path="${child.path}/jcr:content" />
> adaptTo="org.apache.sling.api.resource.ValueMap" var="childProperties" />
> var="title" properties="${childProperties}" />
> Title: ${title}
>
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2689) Document SlingServlet
Dan Klco created SLING-2689: --- Summary: Document SlingServlet Key: SLING-2689 URL: https://issues.apache.org/jira/browse/SLING-2689 Project: Sling Issue Type: Bug Components: Documentation, Servlets, Site Reporter: Dan Klco Priority: Trivial The @SlingServlet annotation should have some documentation on the Sling site, it seems like a better way of registering servlets. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2689) Document SlingServlet
[ https://issues.apache.org/jira/browse/SLING-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2689: Attachment: SLING-2689.diff Attaching a new copy of the page with the relevant documentation. I also documented an unexpected feature with the SlingServletResolver where every servlet must have one of the following properties set: sling.core.servletName, component.name, service.pid or service.id http://svn.apache.org/repos/asf/sling/trunk/bundles/servlets/resolver/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java > Document SlingServlet > - > > Key: SLING-2689 > URL: https://issues.apache.org/jira/browse/SLING-2689 > Project: Sling > Issue Type: Bug > Components: Documentation, Servlets, Site >Reporter: Dan Klco >Priority: Trivial > Attachments: SLING-2689.diff > > > The @SlingServlet annotation should have some documentation on the Sling > site, it seems like a better way of registering servlets. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2695) SlingServletResolver Logging
Dan Klco created SLING-2695: --- Summary: SlingServletResolver Logging Key: SLING-2695 URL: https://issues.apache.org/jira/browse/SLING-2695 Project: Sling Issue Type: Improvement Components: Servlets Affects Versions: Servlets Resolver 2.2.0 Reporter: Dan Klco Priority: Minor There are two odd things (to me at least) about the Sling Servlet Resolver. First, the logger for this class is public static final, which means it is effectively a global variable. It is actually referenced outside the class in the AbstractResourceCollector. Second, when the Sling Servlet Resolver is going to resolve a request and if finds that the request path is not in the servletresolver.paths set of allowed paths, it sends a log message to the getRequestProgressTracker, but I would think it should log at least an info message to the logs, letting the developer know that the script is not going to be executed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2695) SlingServletResolver Logging
[ https://issues.apache.org/jira/browse/SLING-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2695: Attachment: SLING-2695.diff Attached is a patch for switching the logger for the SlingServletResolver to be private static final and creating a new logger for the AbstractResourceCollector. It also has an enhancement to log an info message when a requested path is not inside the execution path. The only potential problem I could see here is that the messages could get verbose when running a production issue, but it seems like there has to be something as it really isn't clear to a developer why a servlet wouldn't be responding to the URL if it's not in the execution path. > SlingServletResolver Logging > > > Key: SLING-2695 > URL: https://issues.apache.org/jira/browse/SLING-2695 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Resolver 2.2.0 >Reporter: Dan Klco >Priority: Minor > Labels: patch > Attachments: SLING-2695.diff > > > There are two odd things (to me at least) about the Sling Servlet Resolver. > First, the logger for this class is public static final, which means it is > effectively a global variable. It is actually referenced outside the class > in the AbstractResourceCollector. > Second, when the Sling Servlet Resolver is going to resolve a request and if > finds that the request path is not in the servletresolver.paths set of > allowed paths, it sends a log message to the getRequestProgressTracker, but I > would think it should log at least an info message to the logs, letting the > developer know that the script is not going to be executed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2695) SlingServletResolver Logging
[ https://issues.apache.org/jira/browse/SLING-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527913#comment-13527913 ] Dan Klco commented on SLING-2695: - Not sure that's an advantage if you're trying to determine which class is doing something, but if it works then fine. Regarding the message in AbstractResouceCollector.isPathAllowed, the problem I see is that it's at the debug level. Most developers are probably not going to have debug logging running against the servlet resolver and I would expect that when I register a servlet under a path where it will never work, I would see something more prominent than a debug message. Instead, maybe it should either: a) log a warning when the servlet is first registered or b) return an error code when a servlet exists at the path, but it is not allowed to execute. > SlingServletResolver Logging > > > Key: SLING-2695 > URL: https://issues.apache.org/jira/browse/SLING-2695 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Resolver 2.2.0 >Reporter: Dan Klco >Priority: Minor > Labels: patch > Attachments: SLING-2695.diff > > > There are two odd things (to me at least) about the Sling Servlet Resolver. > First, the logger for this class is public static final, which means it is > effectively a global variable. It is actually referenced outside the class > in the AbstractResourceCollector. > Second, when the Sling Servlet Resolver is going to resolve a request and if > finds that the request path is not in the servletresolver.paths set of > allowed paths, it sends a log message to the getRequestProgressTracker, but I > would think it should log at least an info message to the logs, letting the > developer know that the script is not going to be executed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2648) Add Resource Access Tags
[
https://issues.apache.org/jira/browse/SLING-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco updated SLING-2648:
Attachment:
SLING-2648-Add-Resource-Access-Tags-With-Tests-And-Functions.diff
Attached a new patch with jUnit Tests and Expression Language functions for
listing children and getting a resource.
These expressions allow you to do the following:
Title: ${title}
> Add Resource Access Tags
>
>
> Key: SLING-2648
> URL: https://issues.apache.org/jira/browse/SLING-2648
> Project: Sling
> Issue Type: New Feature
> Components: Scripting
>Affects Versions: Scripting JSP-Taglib 2.1.8
>Reporter: Dan Klco
> Labels: patch, scripting, taglib
> Attachments: SLING-2648-Add-Resource-Access-Tags.diff,
> SLING-2648-Add-Resource-Access-Tags.diff,
> SLING-2648-Add-Resource-Access-Tags-With-Tests-And-Functions.diff,
> SLING-2648-Document-Tags.diff
>
>
> It would be really nice to be able to access resources through tags rather
> than having to use Scriptlet for even basic Resource iteration. I've created
> a patch for adding tags to:
> - Get a Resource
> - List Child Resources
> - Adapt adaptables to other classes
> - Get properties from ValueMaps (with default values)
> With these new tags, you will be able to do things like create an entire
> navigation without scriptlet:
>
>
>
>
>
> path="${child.path}/jcr:content" />
> adaptTo="org.apache.sling.api.resource.ValueMap" var="childProperties" />
> var="title" properties="${childProperties}" />
> Title: ${title}
>
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-1500) Patch Submission: Expression Language (EL) Functions for JSP Taglib
[ https://issues.apache.org/jira/browse/SLING-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-1500: Attachment: SLING-1500.diff Attached is a new patch to integrate the functionality provided by Mark into the SlingFunctions class for the 1.3 version of the Sling Taglibs. I did not reproduce the use of ResourceWrappers as the referenced issue has been closed. This patch adds the following: Tags: - New FindResources tag, for invoking the resourceResolver.findResources functionality - Updated: GetResources tag, adds the ability to specify a base resource under which to retrieve a relative resource New Functions: - adaptTo: adding the ability to adapt adaptables in EL functions - findResources: enable invoking the resourceResolver.findResources functionality EL functions - getRelativeResource: enables finding resources by a relative path in EL functions I've also included jUnit tests for all of these new methods and have verified them in a Sling 6 vanilla instance. > Patch Submission: Expression Language (EL) Functions for JSP Taglib > --- > > Key: SLING-1500 > URL: https://issues.apache.org/jira/browse/SLING-1500 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting JSP-Taglib 2.0.6 >Reporter: Mark Adamcin >Priority: Minor > Labels: el, function, jsp, scripting, sling, taglib > Attachments: add-files.zip, SLING-1500.diff, taglib11.tld.patch > > > I've noticed that the Sling Resource API is not very accessible for tag- and > EL-focused JSP development. In order to promote readable JSP code, I created > a set of static methods to implement commonly-used ResourceResolver methods > as well as to expose the rather useful ResourceUtil methods as EL functions. > The functions use ResourceWrappers to work around the isse > https://issues.apache.org/jira/browse/SLING-1414 where the Resource.getPath() > method is inaccessible in EL for JcrNodeResource objects. > I've found these taglib functions to be very useful for Day CQ5 development, > so I thought I'd offer to contribute them to the project. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2838) Broken Links Throughout Site
Dan Klco created SLING-2838: --- Summary: Broken Links Throughout Site Key: SLING-2838 URL: https://issues.apache.org/jira/browse/SLING-2838 Project: Sling Issue Type: Bug Components: Site Reporter: Dan Klco Assignee: Dan Klco I ran a link checker against the Sling Site as I was curious regarding some of the issues reported regarding broken links. The report returned a number of links being broken due to invalid markdown. Certain links use references, even though they are to external pages. This results in a blank URL. Additionally, there are links to resources which no longer exist. I resolved the issues as well as: - Fixing broken links to the nabble mailing list - Some minor spelling fixes - Removed an unnecessary, broken link to localhost:8080 (should these be removed in general?) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2838) Broken Links Throughout Site
[ https://issues.apache.org/jira/browse/SLING-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-2838: Attachment: SLING-2838.diff Adding a patch containing the changes. > Broken Links Throughout Site > > > Key: SLING-2838 > URL: https://issues.apache.org/jira/browse/SLING-2838 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Dan Klco >Assignee: Dan Klco > Labels: documentation > Attachments: SLING-2838.diff > > > I ran a link checker against the Sling Site as I was curious regarding some > of the issues reported regarding broken links. The report returned a number > of links being broken due to invalid markdown. > Certain links use references, even though they are to external pages. This > results in a blank URL. Additionally, there are links to resources which no > longer exist. > I resolved the issues as well as: > - Fixing broken links to the nabble mailing list > - Some minor spelling fixes > - Removed an unnecessary, broken link to localhost:8080 (should these be > removed in general?) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2838) Broken Links Throughout Site
[ https://issues.apache.org/jira/browse/SLING-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641913#comment-13641913 ] Dan Klco commented on SLING-2838: - After the initial push to Staging I found the following additional issues: - mailto: links on the security page not working - Links to the Apache Con PDFs on the links page not working - Reference links to the download page are broken - Anchors within the page content are broken - Table on the Sling Plugin is broken > Broken Links Throughout Site > > > Key: SLING-2838 > URL: https://issues.apache.org/jira/browse/SLING-2838 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Dan Klco >Assignee: Dan Klco > Labels: documentation > Attachments: SLING-2838.diff > > > I ran a link checker against the Sling Site as I was curious regarding some > of the issues reported regarding broken links. The report returned a number > of links being broken due to invalid markdown. > Certain links use references, even though they are to external pages. This > results in a blank URL. Additionally, there are links to resources which no > longer exist. > I resolved the issues as well as: > - Fixing broken links to the nabble mailing list > - Some minor spelling fixes > - Removed an unnecessary, broken link to localhost:8080 (should these be > removed in general?) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2838) Broken Links Throughout Site
[ https://issues.apache.org/jira/browse/SLING-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641971#comment-13641971 ] Dan Klco commented on SLING-2838: - Fair enough, I'll just replace the mailto links with security(at)sling.apache.org. > Broken Links Throughout Site > > > Key: SLING-2838 > URL: https://issues.apache.org/jira/browse/SLING-2838 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Dan Klco >Assignee: Dan Klco > Labels: documentation > Attachments: SLING-2838.diff > > > I ran a link checker against the Sling Site as I was curious regarding some > of the issues reported regarding broken links. The report returned a number > of links being broken due to invalid markdown. > Certain links use references, even though they are to external pages. This > results in a blank URL. Additionally, there are links to resources which no > longer exist. > I resolved the issues as well as: > - Fixing broken links to the nabble mailing list > - Some minor spelling fixes > - Removed an unnecessary, broken link to localhost:8080 (should these be > removed in general?) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2838) Broken Links Throughout Site
[ https://issues.apache.org/jira/browse/SLING-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642100#comment-13642100 ] Dan Klco commented on SLING-2838: - Found a few more issues: - site.css links to incorrect location for check icon - Link to OpenID Auth project incorrect in Authentication Actors - SLF4J URL has comma on logging page - Maven Launchpad Plugin has issues with tables and lists - Link to JackRabbit page broken on the Repository Development page > Broken Links Throughout Site > > > Key: SLING-2838 > URL: https://issues.apache.org/jira/browse/SLING-2838 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Dan Klco >Assignee: Dan Klco > Labels: documentation > Attachments: SLING-2838.diff > > > I ran a link checker against the Sling Site as I was curious regarding some > of the issues reported regarding broken links. The report returned a number > of links being broken due to invalid markdown. > Certain links use references, even though they are to external pages. This > results in a blank URL. Additionally, there are links to resources which no > longer exist. > I resolved the issues as well as: > - Fixing broken links to the nabble mailing list > - Some minor spelling fixes > - Removed an unnecessary, broken link to localhost:8080 (should these be > removed in general?) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2838) Broken Links Throughout Site
[ https://issues.apache.org/jira/browse/SLING-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-2838. - Resolution: Fixed The broken links found with the link checker have been resolved, except for a few which link to articles which no longer exist. > Broken Links Throughout Site > > > Key: SLING-2838 > URL: https://issues.apache.org/jira/browse/SLING-2838 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Dan Klco >Assignee: Dan Klco > Labels: documentation > Attachments: SLING-2838.diff > > > I ran a link checker against the Sling Site as I was curious regarding some > of the issues reported regarding broken links. The report returned a number > of links being broken due to invalid markdown. > Certain links use references, even though they are to external pages. This > results in a blank URL. Additionally, there are links to resources which no > longer exist. > I resolved the issues as well as: > - Fixing broken links to the nabble mailing list > - Some minor spelling fixes > - Removed an unnecessary, broken link to localhost:8080 (should these be > removed in general?) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2809) broken link
[ https://issues.apache.org/jira/browse/SLING-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-2809: --- Assignee: Dan Klco > broken link > --- > > Key: SLING-2809 > URL: https://issues.apache.org/jira/browse/SLING-2809 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Blaga Calin >Assignee: Dan Klco >Priority: Minor > > There is a broken link, it's anchor(named Development) can be found here: > http://sling.apache.org/ at the section Contents. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2689) Document SlingServlet
[ https://issues.apache.org/jira/browse/SLING-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-2689: --- Assignee: Dan Klco > Document SlingServlet > - > > Key: SLING-2689 > URL: https://issues.apache.org/jira/browse/SLING-2689 > Project: Sling > Issue Type: Bug > Components: Documentation, Servlets, Site >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Attachments: SLING-2689.diff > > > The @SlingServlet annotation should have some documentation on the Sling > site, it seems like a better way of registering servlets. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2689) Document SlingServlet
[ https://issues.apache.org/jira/browse/SLING-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-2689. - Resolution: Fixed This was fixed by [~bdelacretaz] in revision 1453820 > Document SlingServlet > - > > Key: SLING-2689 > URL: https://issues.apache.org/jira/browse/SLING-2689 > Project: Sling > Issue Type: Bug > Components: Documentation, Servlets, Site >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Attachments: SLING-2689.diff > > > The @SlingServlet annotation should have some documentation on the Sling > site, it seems like a better way of registering servlets. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-1500) Patch Submission: Expression Language (EL) Functions for JSP Taglib
[ https://issues.apache.org/jira/browse/SLING-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-1500: --- Assignee: Dan Klco > Patch Submission: Expression Language (EL) Functions for JSP Taglib > --- > > Key: SLING-1500 > URL: https://issues.apache.org/jira/browse/SLING-1500 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting JSP-Taglib 2.0.6 >Reporter: Mark Adamcin >Assignee: Dan Klco >Priority: Minor > Labels: el, function, jsp, scripting, sling, taglib > Attachments: add-files.zip, SLING-1500.diff, taglib11.tld.patch > > > I've noticed that the Sling Resource API is not very accessible for tag- and > EL-focused JSP development. In order to promote readable JSP code, I created > a set of static methods to implement commonly-used ResourceResolver methods > as well as to expose the rather useful ResourceUtil methods as EL functions. > The functions use ResourceWrappers to work around the isse > https://issues.apache.org/jira/browse/SLING-1414 where the Resource.getPath() > method is inaccessible in EL for JcrNodeResource objects. > I've found these taglib functions to be very useful for Day CQ5 development, > so I thought I'd offer to contribute them to the project. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2861) Include Apache Commons Lang in Dependency Management
Dan Klco created SLING-2861: --- Summary: Include Apache Commons Lang in Dependency Management Key: SLING-2861 URL: https://issues.apache.org/jira/browse/SLING-2861 Project: Sling Issue Type: Improvement Components: General Reporter: Dan Klco Priority: Minor Right now, Apache Commons Lang is referenced in 8 locations and two different versions (2.4 and 2.5), given this it would seem much cleaner to move Apache Commons Lang into the dependency management of the root pom and remove the versions from the references. trunk bundles auth form pom.xml 152: commons-lang extensions adapter pom.xml 152: commons-lang servlets get pom.xml 133: commons-lang resolver pom.xml 104: commons-lang contrib extensions rewriter pom.xml 96: commons-lang scripting script-console pom.xml 97: commons-lang velocity pom.xml 135: commons-lang samples urlfilter pom.xml 95: commons-lang -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2861) Include Apache Commons Lang in Dependency Management
[ https://issues.apache.org/jira/browse/SLING-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-2861. - Resolution: Won't Fix Agreed, the cost of having to release a new parent to update this dependency is too large, closing as won't fix. > Include Apache Commons Lang in Dependency Management > > > Key: SLING-2861 > URL: https://issues.apache.org/jira/browse/SLING-2861 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Dan Klco >Priority: Minor > > Right now, Apache Commons Lang is referenced in 8 locations and two different > versions (2.4 and 2.5), given this it would seem much cleaner to move Apache > Commons Lang into the dependency management of the root pom and remove the > versions from the references. > trunk > bundles > auth > form > pom.xml > 152: > commons-lang > extensions > adapter > pom.xml > 152: commons-lang > servlets > get > pom.xml > 133: commons-lang > resolver > pom.xml > 104: commons-lang > contrib > extensions > rewriter > pom.xml > 96: > commons-lang > scripting > script-console > pom.xml > 97: commons-lang > velocity > pom.xml > 135: commons-lang > samples > urlfilter > pom.xml > 95: commons-lang -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2871) Make Function/Tag Names More Consistent
Dan Klco created SLING-2871: --- Summary: Make Function/Tag Names More Consistent Key: SLING-2871 URL: https://issues.apache.org/jira/browse/SLING-2871 Project: Sling Issue Type: Improvement Components: Scripting Affects Versions: Scripting JSP-Taglib 2.1.8 Reporter: Dan Klco Priority: Minor Right now there are a few names which are not consistent between the Tags, EL Functions and Sling API. This should be corrected to allow more easy usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2871) Make Function/Tag Names More Consistent
[ https://issues.apache.org/jira/browse/SLING-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-2871: --- Assignee: Dan Klco > Make Function/Tag Names More Consistent > --- > > Key: SLING-2871 > URL: https://issues.apache.org/jira/browse/SLING-2871 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting JSP-Taglib 2.1.8 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > > Right now there are a few names which are not consistent between the Tags, EL > Functions and Sling API. This should be corrected to allow more easy usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2871) Make Function/Tag Names More Consistent
[ https://issues.apache.org/jira/browse/SLING-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656439#comment-13656439 ] Dan Klco commented on SLING-2871: - I believe this is fixed, the only one which is somewhat different is that there is a function, getRelativeResource, but it having a different name is required as there is already a function getResource in the sling namespace. > Make Function/Tag Names More Consistent > --- > > Key: SLING-2871 > URL: https://issues.apache.org/jira/browse/SLING-2871 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting JSP-Taglib 2.1.8 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > > Right now there are a few names which are not consistent between the Tags, EL > Functions and Sling API. This should be corrected to allow more easy usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2863) unable to use taglib version 1.3 out of the box
[ https://issues.apache.org/jira/browse/SLING-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-2863: --- Assignee: Dan Klco > unable to use taglib version 1.3 out of the box > --- > > Key: SLING-2863 > URL: https://issues.apache.org/jira/browse/SLING-2863 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Ondrej Florian >Assignee: Dan Klco >Priority: Minor > Attachments: list.xml.patch, taglib13.tld.patch > > > while trying to use taglib 1.3 : > <%@taglib prefix="sling" uri="http://sling.apache.org/taglibs/sling/1.3"; %> > I am getting error: > The absolute uri: http://sling.apache.org/taglibs/sling/1.3 cannot be > resolved in either web.xml or the jar files deployed with this application > (500) > --- > the problem seems to be in the header of the taglib13.tld definition (please > see the attached patch) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2871) Make Function/Tag Names More Consistent
[ https://issues.apache.org/jira/browse/SLING-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-2871. - Resolution: Fixed Fixed in revision 1482119 > Make Function/Tag Names More Consistent > --- > > Key: SLING-2871 > URL: https://issues.apache.org/jira/browse/SLING-2871 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting JSP-Taglib 2.1.8 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > > Right now there are a few names which are not consistent between the Tags, EL > Functions and Sling API. This should be corrected to allow more easy usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2863) unable to use taglib version 1.3 out of the box
[ https://issues.apache.org/jira/browse/SLING-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-2863. - Resolution: Fixed Fix Version/s: Scripting JSP-Taglib 2.1.10 I used Geranimo's JSTL implementation instead of the Sling one, since that has already been released. Otherwise, the list is updated and should be good to go now. Once the next TagLib release is complete, I will update the release with the new TagLib version. > unable to use taglib version 1.3 out of the box > --- > > Key: SLING-2863 > URL: https://issues.apache.org/jira/browse/SLING-2863 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Ondrej Florian >Assignee: Dan Klco >Priority: Minor > Fix For: Scripting JSP-Taglib 2.1.10 > > Attachments: list.xml.patch, taglib13.tld.patch > > > while trying to use taglib 1.3 : > <%@taglib prefix="sling" uri="http://sling.apache.org/taglibs/sling/1.3"; %> > I am getting error: > The absolute uri: http://sling.apache.org/taglibs/sling/1.3 cannot be > resolved in either web.xml or the jar files deployed with this application > (500) > --- > the problem seems to be in the header of the taglib13.tld definition (please > see the attached patch) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2809) broken link
[ https://issues.apache.org/jira/browse/SLING-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-2809. - Resolution: Fixed [~calinb] I believe this issue is resolved, I was also able to fix a number of other broken links on the new site. Please check and let me know if you are still having the issue. > broken link > --- > > Key: SLING-2809 > URL: https://issues.apache.org/jira/browse/SLING-2809 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Blaga Calin >Assignee: Dan Klco >Priority: Minor > > There is a broken link, it's anchor(named Development) can be found here: > http://sling.apache.org/ at the section Contents. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2834) sling:include support two new attributes
[ https://issues.apache.org/jira/browse/SLING-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-2834: --- Assignee: Dan Klco > sling:include support two new attributes > > > Key: SLING-2834 > URL: https://issues.apache.org/jira/browse/SLING-2834 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Scripting JSP-Taglib 2.1.8 >Reporter: Michael J. Kelleher >Assignee: Dan Klco >Priority: Minor > Labels: features > Original Estimate: 72h > Remaining Estimate: 72h > > Look at the functionality of c:import for context to this request: > http://docs.oracle.com/cd/E17802_01/products/products/jsp/jstl/1.1/docs/tlddocs/index.html > That tag supports 2 attributes: var and varReader. These two variable > prevent the included resource from automatically being including the output > of current requests 'out' Stream. They do the following: > var - stores the output of the included resource as a String in the scoped > variable identified by 'var'. > varReader - stores a Reader to the included content in the scoped variable > 'varReader'. > Both of these would likely need the 'scope' attribute as well. > The current use case I have for this is that I do not want to extend or > modify the functionality of the included resource to serve my new > requirement. The change I need to make to the markup is fairly small, and > would not want to have to maintain a new component for such a small change. > I want to include a transformed version of the included resource. The > addition of these two attributes would allow me to store the resultant markup > and transform it before including it within my current request. > I can certainly write this functionality myself (and will be using > sling:include) but it would be nice if sling:include itself supported this > functionality. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2921) Remove Version from TLD URI
Dan Klco created SLING-2921: --- Summary: Remove Version from TLD URI Key: SLING-2921 URL: https://issues.apache.org/jira/browse/SLING-2921 Project: Sling Issue Type: Improvement Components: Scripting Affects Versions: Scripting JSP-Taglib 2.1.10 Reporter: Dan Klco Assignee: Dan Klco As per this discussion, we should remove the version from the Sling TagLib URI: http://markmail.org/thread/t4u5jy4qozubp5rs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2921) Remove Version from TLD URI
[ https://issues.apache.org/jira/browse/SLING-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-2921. - Resolution: Fixed Fixed for the next release of the Sling TagLib > Remove Version from TLD URI > --- > > Key: SLING-2921 > URL: https://issues.apache.org/jira/browse/SLING-2921 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting JSP-Taglib 2.1.10 >Reporter: Dan Klco >Assignee: Dan Klco > > As per this discussion, we should remove the version from the Sling TagLib > URI: > http://markmail.org/thread/t4u5jy4qozubp5rs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2922) ResourceResolver.findResources Broken In ResourceResolver 1.0.7-SNAPSHOT
Dan Klco created SLING-2922: --- Summary: ResourceResolver.findResources Broken In ResourceResolver 1.0.7-SNAPSHOT Key: SLING-2922 URL: https://issues.apache.org/jira/browse/SLING-2922 Project: Sling Issue Type: Bug Components: ResourceResolver Affects Versions: Resource Resolver 1.0.8 Reporter: Dan Klco Priority: Blocker I am getting some strange errors in the TagLib integration tests which seem to be point into to issues with the ResourceResolver.findResources method. It seems like the Find Resource JSP Tag is passing up an exception being thrown deep down in the implementation of Find Resources. As far as I can tell the code is valid and the query being execute should work. Please find the error I am receiving below: (500) The requested URL /SlingJSPTaglibTest/1371581300642/48_1371581300645.html resulted in an error in /apps/integration-test/taglib-test/taglib-test.jsp. Exception: org.apache.sling.api.SlingException: at org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.handleJspExceptionInternal(JspServletWrapper.java:672) at org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:608) at org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:533) at org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449) at org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:263) at org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:87) at org.apache.sling.scripting.jsp.JspScriptEngineFactory$JspScriptEngine.eval(JspScriptEngineFactory.java:450) at org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:361) at org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171) at org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463) at org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:508) at org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:261) at org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49) at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:64) at org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47) at org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25) at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:60) at org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47) at org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25) at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:60) at org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:64) at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:60) at org.apache.sling.engine.impl.SlingRequestProcessorImpl.processRequest(SlingRequestProcessorImpl.java:151) at org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:207) at org.apache.felix.http.base.internal.handler.ServletHandler.doHandle(ServletHandler.java:96) at org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:79) at org.apache.felix.http.base.internal.dispatch.ServletPipeline.handle(ServletPipeline.java:42) at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:49) at org.apache.felix.http.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:33) at org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47) at org.apache.sling.launchpad.testservices.filters.HttpServiceExtFilter.doFilter(HttpServiceExtFilter.java:27) at org.apache.felix.http.base.internal.handler.FilterHandler.doHandle(FilterHandler.java:88) at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:76) at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:47) at org.apache.felix.http.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:33) at org.apache.sling.engine.impl.log.RequestLoggerFilt
[jira] [Resolved] (SLING-1500) Patch Submission: Expression Language (EL) Functions for JSP Taglib
[ https://issues.apache.org/jira/browse/SLING-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-1500. - Resolution: Fixed Added support for getting default and casted values with the EL function 'getValue' I believe all other major pieces of functionality are complete. > Patch Submission: Expression Language (EL) Functions for JSP Taglib > --- > > Key: SLING-1500 > URL: https://issues.apache.org/jira/browse/SLING-1500 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting JSP-Taglib 2.0.6 >Reporter: Mark Adamcin >Assignee: Dan Klco >Priority: Minor > Labels: el, function, jsp, scripting, sling, taglib > Attachments: add-files.zip, SLING-1500.diff, taglib11.tld.patch > > > I've noticed that the Sling Resource API is not very accessible for tag- and > EL-focused JSP development. In order to promote readable JSP code, I created > a set of static methods to implement commonly-used ResourceResolver methods > as well as to expose the rather useful ResourceUtil methods as EL functions. > The functions use ResourceWrappers to work around the isse > https://issues.apache.org/jira/browse/SLING-1414 where the Resource.getPath() > method is inaccessible in EL for JcrNodeResource objects. > I've found these taglib functions to be very useful for Day CQ5 development, > so I thought I'd offer to contribute them to the project. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-8917) CMS - Add Support for LDAP
[ https://issues.apache.org/jira/browse/SLING-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8917. - Resolution: Fixed Fixed in [https://github.com/apache/sling-org-apache-sling-app-cms/commit/d913ef8c7515c1851c4a4be2e5072f374447d531] > CMS - Add Support for LDAP > -- > > Key: SLING-8917 > URL: https://issues.apache.org/jira/browse/SLING-8917 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Labels: backlog > > Look into adding LDAP support via OAK LDAP: > [https://jackrabbit.apache.org/oak/docs/security/authentication/ldap.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8917) CMS - Add Support for LDAP
[ https://issues.apache.org/jira/browse/SLING-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-8917: Fix Version/s: CMS 0.14.2 > CMS - Add Support for LDAP > -- > > Key: SLING-8917 > URL: https://issues.apache.org/jira/browse/SLING-8917 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Labels: backlog > Fix For: CMS 0.14.2 > > > Look into adding LDAP support via OAK LDAP: > [https://jackrabbit.apache.org/oak/docs/security/authentication/ldap.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9152) CMS Reference - Use Commons Messaging Mail
Dan Klco created SLING-9152: --- Summary: CMS Reference - Use Commons Messaging Mail Key: SLING-9152 URL: https://issues.apache.org/jira/browse/SLING-9152 Project: Sling Issue Type: Improvement Components: App CMS Reference Affects Versions: CMS 0.14.0 Reporter: Dan Klco Assignee: Dan Klco Fix For: CMS 0.14.2 Instead of rolling an email client, leverage the Commons Messaging Mail 1.0.0 client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9152) CMS Reference - Use Commons Messaging Mail
[ https://issues.apache.org/jira/browse/SLING-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-9152. - Resolution: Fixed Fixed in [https://github.com/apache/sling-org-apache-sling-app-cms/commit/09cf8aaa4672567d601311c5db68644d45bb21ec] > CMS Reference - Use Commons Messaging Mail > -- > > Key: SLING-9152 > URL: https://issues.apache.org/jira/browse/SLING-9152 > Project: Sling > Issue Type: Improvement > Components: App CMS Reference >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: CMS 0.14.2 > > > Instead of rolling an email client, leverage the Commons Messaging Mail 1.0.0 > client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9156) CMS - Add Thumbnail to Search
Dan Klco created SLING-9156: --- Summary: CMS - Add Thumbnail to Search Key: SLING-9156 URL: https://issues.apache.org/jira/browse/SLING-9156 Project: Sling Issue Type: Improvement Components: App CMS Affects Versions: CMS 0.14.0 Reporter: Dan Klco Assignee: Dan Klco Fix For: CMS 0.14.2 The search feature should display thumbnails for files to give users a visual indicator of what is being selected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9156) CMS - Add Thumbnail to Search
[ https://issues.apache.org/jira/browse/SLING-9156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-9156. - Resolution: Fixed Implemented in [https://github.com/apache/sling-org-apache-sling-app-cms/commit/866705bb364ffa6897c5f17184afae9ef7434820] > CMS - Add Thumbnail to Search > - > > Key: SLING-9156 > URL: https://issues.apache.org/jira/browse/SLING-9156 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: CMS 0.14.2 > > > The search feature should display thumbnails for files to give users a visual > indicator of what is being selected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8858) Model Cache causes NPE in sling.models.impl 1.4.10+
[
https://issues.apache.org/jira/browse/SLING-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco resolved SLING-8858.
-
Resolution: Fixed
Fixed in
[https://github.com/apache/sling-org-apache-sling-models-impl/pull/18/commits/92c0a7289924f209332af675311c044338347b62]
> Model Cache causes NPE in sling.models.impl 1.4.10+
> ---
>
> Key: SLING-8858
> URL: https://issues.apache.org/jira/browse/SLING-8858
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Affects Versions: Sling Models Impl 1.4.10
> Environment: Java SE 1.8.0_231
>Reporter: Frank Pauleickhoff
>Assignee: Dan Klco
>Priority: Major
> Fix For: Sling Models Impl 1.4.14
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In AEM 6.4 ServicePack 6 we face NullPointerExceptions when using the Sling
> model cache that used to work before (in SP 3).
> *Exception Stacktrace is:*
> {code:java}
> 22.11.2019 15:29:22.525 *ERROR* [127.0.0.1 [1574432957337] GET
> /content/mypage.html HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> SlingException
> org.apache.sling.scripting.sightly.SightlyException:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> Identifier xx.xxx.MyModel cannot be correctly instantiated by the Use API
> [...]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.sling.models.impl.ModelAdapterFactory.internalCreateModel(ModelAdapterFactory.java:407)
> at
> org.apache.sling.models.impl.ModelAdapterFactory.createModel(ModelAdapterFactory.java:314)
> {code}
> Problem seems to be related to introduction of WeakReferences in SLING-7586.
> Without knowing any details and being deeply into the Sling Model Caching
> implementation, I think a null-check is missing for "SoftReference" in Line
> 407:
> {code:java}
> SoftReference SoftReference = adaptableCache.get(requestedType);
> ModelType cachedObject = (ModelType) SoftReference.get();
> {code}
> That seems to cause caching to throw NPE for any not yet cached model.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-8858) Model Cache causes NPE in sling.models.impl 1.4.10+
[
https://issues.apache.org/jira/browse/SLING-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060171#comment-17060171
]
Dan Klco commented on SLING-8858:
-
Provided patch looks good to me as well. Moving to resolved.
> Model Cache causes NPE in sling.models.impl 1.4.10+
> ---
>
> Key: SLING-8858
> URL: https://issues.apache.org/jira/browse/SLING-8858
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Affects Versions: Sling Models Impl 1.4.10
> Environment: Java SE 1.8.0_231
>Reporter: Frank Pauleickhoff
>Assignee: Dan Klco
>Priority: Major
> Fix For: Sling Models Impl 1.4.14
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In AEM 6.4 ServicePack 6 we face NullPointerExceptions when using the Sling
> model cache that used to work before (in SP 3).
> *Exception Stacktrace is:*
> {code:java}
> 22.11.2019 15:29:22.525 *ERROR* [127.0.0.1 [1574432957337] GET
> /content/mypage.html HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> SlingException
> org.apache.sling.scripting.sightly.SightlyException:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript:
> Identifier xx.xxx.MyModel cannot be correctly instantiated by the Use API
> [...]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.sling.models.impl.ModelAdapterFactory.internalCreateModel(ModelAdapterFactory.java:407)
> at
> org.apache.sling.models.impl.ModelAdapterFactory.createModel(ModelAdapterFactory.java:314)
> {code}
> Problem seems to be related to introduction of WeakReferences in SLING-7586.
> Without knowing any details and being deeply into the Sling Model Caching
> implementation, I think a null-check is missing for "SoftReference" in Line
> 407:
> {code:java}
> SoftReference SoftReference = adaptableCache.get(requestedType);
> ModelType cachedObject = (ModelType) SoftReference.get();
> {code}
> That seems to cause caching to throw NPE for any not yet cached model.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9219) Comments in JSON Configuration
Dan Klco created SLING-9219:
---
Summary: Comments in JSON Configuration
Key: SLING-9219
URL: https://issues.apache.org/jira/browse/SLING-9219
Project: Sling
Issue Type: Bug
Components: Installer
Affects Versions: JCR Installer 3.2.0
Reporter: Dan Klco
Assignee: Konrad Windszus
With the latest version of JCR Installer, I'm seeing an exception when saving
OSGi Configurations from the console:
{{18.03.2020 19:57:44.565 *WARN* [JcrInstaller.2]
org.apache.sling.installer.core.impl.OsgiInstallerImpl Cannot create
InternalResource (resource will be ignored):InstallableResource, priority=200,
id=/apps/sling/install/org.apache.sling.cms.core.internal.repository.RevisionCleanupScheduler.cfg.json}}{{javax.json.stream.JsonParsingException:
Unexpected character '#' (Codepoint: 35) on [lineNumber=2, columnNumber=77,
streamOffset=76]. Reason is [[Expected structural character or digit or 't' or
'n' or 'f' or '-']]}}{{at
org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:966)}}{{at
org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:972)}}{{at
org.apache.johnzon.core.JsonStreamParserImpl.defaultHandling(JsonStreamParserImpl.java:422)}}{{at
org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:414)}}{{at
org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:353)}}{{at
org.apache.johnzon.core.JsonReaderImpl.parseObject(JsonReaderImpl.java:131)}}{{at
org.apache.johnzon.core.JsonReaderImpl.readValue(JsonReaderImpl.java:56)}}{{at
org.apache.johnzon.core.JsonReaderImpl.read(JsonReaderImpl.java:42)}}{{at
org.apache.felix.configurator.impl.json.JSONUtil.parseJSON(JSONUtil.java:331)
[org.apache.sling.installer.core:3.10.2]}}{{at
org.apache.felix.configurator.impl.json.JSONUtil.readJSON(JSONUtil.java:161)
[org.apache.sling.installer.core:3.10.2]}}{{at
org.apache.sling.installer.core.impl.InternalResource.readDictionary(InternalResource.java:274)
[org.apache.sling.installer.core:3.10.2]}}{{at
org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:106)
[org.apache.sling.installer.core:3.10.2]}}{{at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:385)
[org.apache.sling.installer.core:3.10.2]}}{{at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:425)
[org.apache.sling.installer.core:3.10.2]}}{{at
org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:465)
[org.apache.sling.installer.provider.jcr:3.2.0]}}{{at
org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:287)
[org.apache.sling.installer.provider.jcr:3.2.0]}}
The problem appears to be that the files are in JSON format, but contain a
prefix comment: " # Configuration created by Apache Sling JCR Installer"
This is due to the JCR Installer changing to write the configuration files in
JSON format, but still including the comment from when the configurations were
persisted as text files:
[https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blame/master/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java#L695]
The question [~kwin] it looks like there was a revert commit, so should the
config files revert to TXT format or remove the comment and have the
configurations in JSON format?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9225) CMS - Add JCR Cleanup Schedulers
Dan Klco created SLING-9225: --- Summary: CMS - Add JCR Cleanup Schedulers Key: SLING-9225 URL: https://issues.apache.org/jira/browse/SLING-9225 Project: Sling Issue Type: Improvement Components: App CMS Affects Versions: CMS 0.14.0 Reporter: Dan Klco Assignee: Dan Klco Fix For: CMS 0.14.2 Currently, the Sling CMS repository does not perform any automated cleanup including the Segment or Data Store. The application should include schedulers to perform Jackrabbit Oak Repository cleanup activities as provided in the Repository Manager MBean. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9225) CMS - Add JCR Cleanup Schedulers
[ https://issues.apache.org/jira/browse/SLING-9225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-9225. - Resolution: Fixed Fixed in [https://github.com/apache/sling-org-apache-sling-app-cms/commit/a364a3ab6ac8c38052d02e6623126cba18d5cecb] > CMS - Add JCR Cleanup Schedulers > > > Key: SLING-9225 > URL: https://issues.apache.org/jira/browse/SLING-9225 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.14.2 > > > Currently, the Sling CMS repository does not perform any automated cleanup > including the Segment or Data Store. > The application should include schedulers to perform Jackrabbit Oak > Repository cleanup activities as provided in the Repository Manager MBean. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9226) CMS - Move Fails with Same Name Resources
Dan Klco created SLING-9226: --- Summary: CMS - Move Fails with Same Name Resources Key: SLING-9226 URL: https://issues.apache.org/jira/browse/SLING-9226 Project: Sling Issue Type: Bug Components: App CMS Affects Versions: CMS 0.14.0 Reporter: Dan Klco Assignee: Dan Klco Fix For: CMS 0.14.2 When moving a resource to another container, if the container already contains a resource with the same name, the move operation fails. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9226) CMS - Move Fails with Same Name Resources
[ https://issues.apache.org/jira/browse/SLING-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062952#comment-17062952 ] Dan Klco commented on SLING-9226: - Fixed by generating a new resource name on move by combining the last segment of the resource type with a random string [https://github.com/apache/sling-org-apache-sling-app-cms/commit/6f1cf546f2673443df872e09ef65d362d716b31f] > CMS - Move Fails with Same Name Resources > - > > Key: SLING-9226 > URL: https://issues.apache.org/jira/browse/SLING-9226 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: CMS 0.14.2 > > > When moving a resource to another container, if the container already > contains a resource with the same name, the move operation fails. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9226) CMS - Move Fails with Same Name Resources
[ https://issues.apache.org/jira/browse/SLING-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-9226. - Resolution: Fixed > CMS - Move Fails with Same Name Resources > - > > Key: SLING-9226 > URL: https://issues.apache.org/jira/browse/SLING-9226 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: CMS 0.14.2 > > > When moving a resource to another container, if the container already > contains a resource with the same name, the move operation fails. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8953) CMS - Closing Search Issues
[ https://issues.apache.org/jira/browse/SLING-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8953. --- > CMS - Closing Search Issues > --- > > Key: SLING-8953 > URL: https://issues.apache.org/jira/browse/SLING-8953 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 0.12.0, CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.16.0 > > > There are two issues closing the search dialog: > * When closing from page properties, this also closes the page properties > dialog > * when closing without selecting a value from a component it just displays a > loader and does not reopen the editor -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8871) CMS - Upload Click Handler Registered Multiple Times
[ https://issues.apache.org/jira/browse/SLING-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8871. --- > CMS - Upload Click Handler Registered Multiple Times > > > Key: SLING-8871 > URL: https://issues.apache.org/jira/browse/SLING-8871 > Project: Sling > Issue Type: Bug >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.16.0 > > > When a user uploads a file and then closes the dialog and uploads another > file the click handler will register multiple times resulting in the UI > attempting to upload the same file multiple times. > This does not affect the drag and drop functionality. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8947) CMS - Grid View Missing Fields
[ https://issues.apache.org/jira/browse/SLING-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8947. --- > CMS - Grid View Missing Fields > -- > > Key: SLING-8947 > URL: https://issues.apache.org/jira/browse/SLING-8947 > Project: Sling > Issue Type: Bug >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.16.0 > > > Currently the table view shows data which is not visible on the grid view. We > should add the: > > * Title > * Modified date > * Publish status -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8872) CMS - Fails to Extract JPEG Metadata
[ https://issues.apache.org/jira/browse/SLING-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8872. --- > CMS - Fails to Extract JPEG Metadata > > > Key: SLING-8872 > URL: https://issues.apache.org/jira/browse/SLING-8872 > Project: Sling > Issue Type: Bug >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.16.0 > > > The File Metadata Extractor fails to extract the metadata of JPEG files due > to the errors described here: > https://issues.apache.org/jira/browse/TIKA-2987 > The fix is to: > * Update to Tika 1.22 > * Remove the Tika Parsers to avoid conflicting imports -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8930) CMS - i18n Not Reloading
[ https://issues.apache.org/jira/browse/SLING-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8930. --- > CMS - i18n Not Reloading > > > Key: SLING-8930 > URL: https://issues.apache.org/jira/browse/SLING-8930 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.16.0 > > > When adding a new entry to the i18n editor, the editor does not display a > value until the page is refreshed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8956) Archetype Token Replacement Issues
[ https://issues.apache.org/jira/browse/SLING-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8956. --- > Archetype Token Replacement Issues > -- > > Key: SLING-8956 > URL: https://issues.apache.org/jira/browse/SLING-8956 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.16.0 > > > The Sling CMS Archetype fails to replace tokens in the readme and page.json > and does not handle the path correctly in the java code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9156) CMS - Add Thumbnail to Search
[ https://issues.apache.org/jira/browse/SLING-9156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-9156. --- > CMS - Add Thumbnail to Search > - > > Key: SLING-9156 > URL: https://issues.apache.org/jira/browse/SLING-9156 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: CMS 0.16.0 > > > The search feature should display thumbnails for files to give users a visual > indicator of what is being selected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9152) CMS Reference - Use Commons Messaging Mail
[ https://issues.apache.org/jira/browse/SLING-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-9152. --- > CMS Reference - Use Commons Messaging Mail > -- > > Key: SLING-9152 > URL: https://issues.apache.org/jira/browse/SLING-9152 > Project: Sling > Issue Type: Improvement > Components: App CMS Reference >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: CMS 0.16.0 > > > Instead of rolling an email client, leverage the Commons Messaging Mail 1.0.0 > client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9226) CMS - Move Fails with Same Name Resources
[ https://issues.apache.org/jira/browse/SLING-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-9226. --- > CMS - Move Fails with Same Name Resources > - > > Key: SLING-9226 > URL: https://issues.apache.org/jira/browse/SLING-9226 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: CMS 0.16.0 > > > When moving a resource to another container, if the container already > contains a resource with the same name, the move operation fails. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9001) CMS - Cannot Create Page without Template Policy
[ https://issues.apache.org/jira/browse/SLING-9001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-9001. --- > CMS - Cannot Create Page without Template Policy > > > Key: SLING-9001 > URL: https://issues.apache.org/jira/browse/SLING-9001 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: CMS 0.16.0 > > > Template policies are required in the page template model so pages cannot be > created from a template where the policy is not set, even if the template > does not truly need a policy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8957) Tika Fallback Provider Fails on Large Files
[ https://issues.apache.org/jira/browse/SLING-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8957. --- > Tika Fallback Provider Fails on Large Files > --- > > Key: SLING-8957 > URL: https://issues.apache.org/jira/browse/SLING-8957 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.16.0 > > > Tika Fallback Provider Fails on Large(ish) Files -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9225) CMS - Add JCR Cleanup Schedulers
[ https://issues.apache.org/jira/browse/SLING-9225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-9225. --- > CMS - Add JCR Cleanup Schedulers > > > Key: SLING-9225 > URL: https://issues.apache.org/jira/browse/SLING-9225 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.16.0 > > > Currently, the Sling CMS repository does not perform any automated cleanup > including the Segment or Data Store. > The application should include schedulers to perform Jackrabbit Oak > Repository cleanup activities as provided in the Repository Manager MBean. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8952) CMS - Use Bulma Tags Instead of Buttons for Labelfield
[ https://issues.apache.org/jira/browse/SLING-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8952. --- > CMS - Use Bulma Tags Instead of Buttons for Labelfield > -- > > Key: SLING-8952 > URL: https://issues.apache.org/jira/browse/SLING-8952 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: CMS 0.16.0 > > > Currently, the taxonomy, members and membership fields use bulma buttons > instead of tags, tags provide a clearer and better UX. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8958) Return Default Thumbnail on Error
[ https://issues.apache.org/jira/browse/SLING-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8958. --- > Return Default Thumbnail on Error > - > > Key: SLING-8958 > URL: https://issues.apache.org/jira/browse/SLING-8958 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.16.0 > > > When the transformer fails to transform a file it would be friendlier to > return a default thumbnail than an error -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8917) CMS - Add Support for LDAP
[ https://issues.apache.org/jira/browse/SLING-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8917. --- > CMS - Add Support for LDAP > -- > > Key: SLING-8917 > URL: https://issues.apache.org/jira/browse/SLING-8917 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Labels: backlog > Fix For: CMS 0.16.0 > > > Look into adding LDAP support via OAK LDAP: > [https://jackrabbit.apache.org/oak/docs/security/authentication/ldap.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9000) CMS - Reload Fails When Editing Component
[ https://issues.apache.org/jira/browse/SLING-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-9000. --- > CMS - Reload Fails When Editing Component > - > > Key: SLING-9000 > URL: https://issues.apache.org/jira/browse/SLING-9000 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: CMS 0.14.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: CMS 0.16.0 > > > Reload Fails When Component Embedded Directly in Page Component due to a > JavaScript error: > editor.min.js:17 Uncaught TypeError: Cannot read property 'dataset' of null > at Object.reloadComponent (editor.min.js:17) > at scripts-all.min.js:72 > at HTMLButtonElement. (scripts-all.min.js:72) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9344) Sling CMS - Namespace for nodes is wrong in nodetypes.cnd
[ https://issues.apache.org/jira/browse/SLING-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-9344: --- Assignee: Dan Klco > Sling CMS - Namespace for nodes is wrong in nodetypes.cnd > - > > Key: SLING-9344 > URL: https://issues.apache.org/jira/browse/SLING-9344 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: CMS 0.16.0 > Environment: Hardware does not matter, I assume - but I did test on > two different macs with Amazon Corretto 8 as JDK. >Reporter: Matthias Herold >Assignee: Dan Klco >Priority: Major > Original Estimate: 1h > Remaining Estimate: 1h > > The namespace specified in the file > ui/src/main/resources/SLING-INF/nodetypes/nodetypes.cnd of repository > sling-org-apache-sling-app-cms is wrong. > Line 24 reads: http://www.sling.apache.org/sling/1.0'> > This should be: http://sling.apache.org/jcr/sling/1.0'> > This is a major issue when creating new repositories: when you build a custom > starter package including Apache CMS and create a new repository with this > starter package afterwards, the namespace of all nodes in the repository is > automatically wrong. In normal operation, you won't notice that. But when you > export content as package from a sling instance with the right namespace and > import the content to a sling instance with the wrong namespace the import > will fail. I did not test the other way round, but assume the issue also > occurs there. > Suggested fix: change > http://www.sling.apache.org/sling/1.0 > to > http://sling.apache.org/jcr/sling/1.0 > in > sling-org-apache-sling-app-cms/ui/src/main/resources/SLING-INF/nodetypes/nodetypes.cnd -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9344) Sling CMS - Namespace for nodes is wrong in nodetypes.cnd
[ https://issues.apache.org/jira/browse/SLING-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-9344: Affects Version/s: (was: CMS 0.16.0) App CMS 0.10.0 > Sling CMS - Namespace for nodes is wrong in nodetypes.cnd > - > > Key: SLING-9344 > URL: https://issues.apache.org/jira/browse/SLING-9344 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 0.10.0 > Environment: Hardware does not matter, I assume - but I did test on > two different macs with Amazon Corretto 8 as JDK. >Reporter: Matthias Herold >Assignee: Dan Klco >Priority: Major > Original Estimate: 1h > Remaining Estimate: 1h > > The namespace specified in the file > ui/src/main/resources/SLING-INF/nodetypes/nodetypes.cnd of repository > sling-org-apache-sling-app-cms is wrong. > Line 24 reads: http://www.sling.apache.org/sling/1.0'> > This should be: http://sling.apache.org/jcr/sling/1.0'> > This is a major issue when creating new repositories: when you build a custom > starter package including Apache CMS and create a new repository with this > starter package afterwards, the namespace of all nodes in the repository is > automatically wrong. In normal operation, you won't notice that. But when you > export content as package from a sling instance with the right namespace and > import the content to a sling instance with the wrong namespace the import > will fail. I did not test the other way round, but assume the issue also > occurs there. > Suggested fix: change > http://www.sling.apache.org/sling/1.0 > to > http://sling.apache.org/jcr/sling/1.0 > in > sling-org-apache-sling-app-cms/ui/src/main/resources/SLING-INF/nodetypes/nodetypes.cnd -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9344) Sling CMS - Namespace for nodes is wrong in nodetypes.cnd
[ https://issues.apache.org/jira/browse/SLING-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-9344: Fix Version/s: App CMS 0.16.2 > Sling CMS - Namespace for nodes is wrong in nodetypes.cnd > - > > Key: SLING-9344 > URL: https://issues.apache.org/jira/browse/SLING-9344 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 0.10.0 > Environment: Hardware does not matter, I assume - but I did test on > two different macs with Amazon Corretto 8 as JDK. >Reporter: Matthias Herold >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 0.16.2 > > Original Estimate: 1h > Remaining Estimate: 1h > > The namespace specified in the file > ui/src/main/resources/SLING-INF/nodetypes/nodetypes.cnd of repository > sling-org-apache-sling-app-cms is wrong. > Line 24 reads: http://www.sling.apache.org/sling/1.0'> > This should be: http://sling.apache.org/jcr/sling/1.0'> > This is a major issue when creating new repositories: when you build a custom > starter package including Apache CMS and create a new repository with this > starter package afterwards, the namespace of all nodes in the repository is > automatically wrong. In normal operation, you won't notice that. But when you > export content as package from a sling instance with the right namespace and > import the content to a sling instance with the wrong namespace the import > will fail. I did not test the other way round, but assume the issue also > occurs there. > Suggested fix: change > http://www.sling.apache.org/sling/1.0 > to > http://sling.apache.org/jcr/sling/1.0 > in > sling-org-apache-sling-app-cms/ui/src/main/resources/SLING-INF/nodetypes/nodetypes.cnd -- This message was sent by Atlassian Jira (v8.3.4#803005)
