Re: [VOTE] Release Apache Sling Feature Launcher Maven Plugin 0.1.6
+1 David On Fri, 7 Jul 2023 at 11:56, Robert Munteanu wrote: > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352559 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2763/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2763 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu >
[jira] [Commented] (SLING-11935) JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
[
https://issues.apache.org/jira/browse/SLING-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740637#comment-17740637
]
A. J. David Bosschaert commented on SLING-11935:
I have no access to a Windows machine at the moment, but looking into it
briefly I found that the test seems to be failing on this line:
https://github.com/apache/sling-slingfeature-maven-plugin/blob/master/src/test/java/org/apache/sling/feature/maven/mojos/JarDecompressorTest.java#L81C35-L81C35
That line is comparing this file
https://github.com/apache/sling-slingfeature-maven-plugin/blob/master/src/test/resources/repository/textfile.txt
with the result of what was extracted out of the jar file.
It looks like some automatic line feed conversion is done on the file compared
against, because I think the difference is that the line feeds on windows are
{{\r\n}} whereas in unix they're just {{\n}} which would add probably this
number of bytes.
> JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
>
>
> Key: SLING-11935
> URL: https://issues.apache.org/jira/browse/SLING-11935
> Project: Sling
> Issue Type: Bug
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.7.2
>
>
> This is the only CI failure, but I don't understand enough about the
> JarDecompressor to make an informed fix. I will ignore the test on Windows
> for now, but it would be great to understand the root cause and fix it.
> {noformat}[ERROR]
> org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar
> Time elapsed: 0.071 s <<< FAILURE!
> java.lang.AssertionError: expected:<2108> but was:<1984>
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failNotEquals(Assert.java:835)
> at org.junit.Assert.assertEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:633)
> at
> org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar(JarDecompressorTest.java:81)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11130) Make unpack converter retry downloads
[ https://issues.apache.org/jira/browse/SLING-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-11130. -- > Make unpack converter retry downloads > - > > Key: SLING-11130 > URL: https://issues.apache.org/jira/browse/SLING-11130 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Unpack Extension 0.2.0 > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model Unpack Extension 0.3.0 > > > The unpack converter [1] should retry downloads in case of failure. > [1] > https://github.com/apache/sling-org-apache-sling-feature-extension-unpack/blob/master/src/main/java/org/apache/sling/feature/extension/unpack/impl/converter/Converter.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11130) Make unpack converter retry downloads
[ https://issues.apache.org/jira/browse/SLING-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-11130. Resolution: Fixed > Make unpack converter retry downloads > - > > Key: SLING-11130 > URL: https://issues.apache.org/jira/browse/SLING-11130 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Unpack Extension 0.2.0 > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model Unpack Extension 0.3.0 > > > The unpack converter [1] should retry downloads in case of failure. > [1] > https://github.com/apache/sling-org-apache-sling-feature-extension-unpack/blob/master/src/main/java/org/apache/sling/feature/extension/unpack/impl/converter/Converter.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (SLING-11130) Make unpack converter retry downloads
[ https://issues.apache.org/jira/browse/SLING-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert reassigned SLING-11130: -- Assignee: A. J. David Bosschaert > Make unpack converter retry downloads > - > > Key: SLING-11130 > URL: https://issues.apache.org/jira/browse/SLING-11130 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Unpack Extension 0.2.0 > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Attachments: image-2022-02-08-10-04-58-565.png > > > The unpack converter [1] should retry downloads in case of failure. > [1] > https://github.com/apache/sling-org-apache-sling-feature-extension-unpack/blob/master/src/main/java/org/apache/sling/feature/extension/unpack/impl/converter/Converter.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11130) Make unpack converter retry downloads
[ https://issues.apache.org/jira/browse/SLING-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-11130: --- Fix Version/s: Feature Model Unpack Extension 0.3.0 > Make unpack converter retry downloads > - > > Key: SLING-11130 > URL: https://issues.apache.org/jira/browse/SLING-11130 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Unpack Extension 0.2.0 > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model Unpack Extension 0.3.0 > > Attachments: image-2022-02-08-10-04-58-565.png > > > The unpack converter [1] should retry downloads in case of failure. > [1] > https://github.com/apache/sling-org-apache-sling-feature-extension-unpack/blob/master/src/main/java/org/apache/sling/feature/extension/unpack/impl/converter/Converter.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11130) Make unpack converter retry downloads
A. J. David Bosschaert created SLING-11130: -- Summary: Make unpack converter retry downloads Key: SLING-11130 URL: https://issues.apache.org/jira/browse/SLING-11130 Project: Sling Issue Type: Improvement Components: Feature Model Affects Versions: Feature Model Unpack Extension 0.2.0 Reporter: A. J. David Bosschaert Attachments: image-2022-02-08-10-04-58-565.png The unpack converter [1] should retry downloads in case of failure. [1] https://github.com/apache/sling-org-apache-sling-feature-extension-unpack/blob/master/src/main/java/org/apache/sling/feature/extension/unpack/impl/converter/Converter.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11118) null returned even if OSGi service is found
[
https://issues.apache.org/jira/browse/SLING-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-8.
Resolution: Fixed
> null returned even if OSGi service is found
> ---
>
> Key: SLING-8
> URL: https://issues.apache.org/jira/browse/SLING-8
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.4.2
> Reporter: A. J. David Bosschaert
> Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Scripting Core 2.4.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> AbstractBundledRenderUnit.getService(String className) can return {{null}}
> for a service even if the service is found in the service registry.
> This is because the last line of this method always returns {{null}} which
> discards the result from the local {{this.services}} cache if it's found in
> there.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-11118) null returned even if OSGi service is found
[
https://issues.apache.org/jira/browse/SLING-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-8:
---
Fix Version/s: Scripting Core 2.4.4
> null returned even if OSGi service is found
> ---
>
> Key: SLING-8
> URL: https://issues.apache.org/jira/browse/SLING-8
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.4.2
> Reporter: A. J. David Bosschaert
> Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Scripting Core 2.4.4
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> AbstractBundledRenderUnit.getService(String className) can return {{null}}
> for a service even if the service is found in the service registry.
> This is because the last line of this method always returns {{null}} which
> discards the result from the local {{this.services}} cache if it's found in
> there.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11118) null returned even if OSGi service is found
[
https://issues.apache.org/jira/browse/SLING-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486635#comment-17486635
]
A. J. David Bosschaert commented on SLING-8:
PR: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/11
> null returned even if OSGi service is found
> ---
>
> Key: SLING-8
> URL: https://issues.apache.org/jira/browse/SLING-8
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.4.2
> Reporter: A. J. David Bosschaert
> Assignee: A. J. David Bosschaert
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> AbstractBundledRenderUnit.getService(String className) can return {{null}}
> for a service even if the service is found in the service registry.
> This is because the last line of this method always returns {{null}} which
> discards the result from the local {{this.services}} cache if it's found in
> there.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (SLING-11118) null returned even if OSGi service is found
[
https://issues.apache.org/jira/browse/SLING-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert reassigned SLING-8:
--
Assignee: A. J. David Bosschaert (was: Radu Cotescu)
> null returned even if OSGi service is found
> ---
>
> Key: SLING-8
> URL: https://issues.apache.org/jira/browse/SLING-8
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.4.2
> Reporter: A. J. David Bosschaert
> Assignee: A. J. David Bosschaert
>Priority: Major
>
> AbstractBundledRenderUnit.getService(String className) can return {{null}}
> for a service even if the service is found in the service registry.
> This is because the last line of this method always returns {{null}} which
> discards the result from the local {{this.services}} cache if it's found in
> there.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (SLING-11118) null returned even if OSGi service is found
A. J. David Bosschaert created SLING-8:
--
Summary: null returned even if OSGi service is found
Key: SLING-8
URL: https://issues.apache.org/jira/browse/SLING-8
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting Core 2.4.2
Reporter: A. J. David Bosschaert
AbstractBundledRenderUnit.getService(String className) can return {{null}} for
a service even if the service is found in the service registry.
This is because the last line of this method always returns {{null}} which
discards the result from the local {{this.services}} cache if it's found in
there.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (SLING-10859) runmode.mapping file does not contain all needed values
A. J. David Bosschaert created SLING-10859:
--
Summary: runmode.mapping file does not contain all needed values
Key: SLING-10859
URL: https://issues.apache.org/jira/browse/SLING-10859
Project: Sling
Issue Type: Bug
Components: Content-Package to Feature Model Converter
Affects Versions: Content-Package to Feature Model Converter 1.1.6
Reporter: A. J. David Bosschaert
In some cases the {{runmode.mapping}} file generated by the cpconverter does
not contain all the required file (feature model) references.
This can happen when certain filenames that need to be referenced are a
substring of other file names.
It centers around this code:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/RunmodeMapper.java#L63-L67
Assume that {{properties}} contains an entry {{(default)=>my-webapp-all.json}}.
Then next a feature file named {{all.json}} is processed. As the name of it is
a substring of the pre-existing value it will not append. In fact it will
replace the previous value with the new value and as such remove it.
The logic there should be fixed to not use substrings, but rather compare
entire names. Possibly a better idea would be to keep a Set internally
and convert that to a comma-separated list only once the Properties are
persisted in the {{save(()}} call.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10858) Incorrect API Regions generated in features
[
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10858:
---
Description:
In some cases the cpconverter generates an {{api-regions}} section with
{{global}} exports for packages, where the bundles providing those packages are
not actually listed in the feature. I have seen features with _no_ bundles
(just some configuration) and an {{api-regions}} section with lots of exports,
which clearly couldn't be satisfied by the feature as it did not have any
bundles at all.
I believe that this might be caused by the fact that the DefaultFeaturesManager
has the an apiRegionsExports field
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
which is not cleared between features, and as such the api-regions exports are
bleeding between generated features.
was:
In some cases the cpconverter generates an {{api-regions}} section with
{{global}} exports for packages, where the bundles providing those packages are
not actually listed in the feature. I have seen features with _not_ bundles
(just some configuration) and an {{api-regions}} section with lots of exports,
which clearly couldn't be satisfied by the feature as it did not have any
bundles at all.
I believe that this might be caused by the fact that the DefaultFeaturesManager
has the an apiRegionsExports field
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
which is not cleared between features, and as such the api-regions exports are
bleeding between generated features.
> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.6
> Reporter: A. J. David Bosschaert
>Priority: Major
>
> In some cases the cpconverter generates an {{api-regions}} section with
> {{global}} exports for packages, where the bundles providing those packages
> are not actually listed in the feature. I have seen features with _no_
> bundles (just some configuration) and an {{api-regions}} section with lots of
> exports, which clearly couldn't be satisfied by the feature as it did not
> have any bundles at all.
> I believe that this might be caused by the fact that the
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features, and as such the api-regions exports
> are bleeding between generated features.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10858) Incorrect API Regions generated in features
[
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10858:
---
Description:
In some cases the cpconverter generates an {{api-regions}} section with
{{global}} exports for packages, where the bundles providing those packages are
not actually listed in the feature. I have seen features with _no_ bundles
(just some configuration) and an {{api-regions}} section with lots of exports,
which clearly couldn't be satisfied by the feature as it did not have any
bundles at all.
I believe that this might be caused by the fact that the DefaultFeaturesManager
has the an apiRegionsExports field
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
which is not cleared between features being processed, and as such the
api-regions exports are bleeding between generated features.
was:
In some cases the cpconverter generates an {{api-regions}} section with
{{global}} exports for packages, where the bundles providing those packages are
not actually listed in the feature. I have seen features with _no_ bundles
(just some configuration) and an {{api-regions}} section with lots of exports,
which clearly couldn't be satisfied by the feature as it did not have any
bundles at all.
I believe that this might be caused by the fact that the DefaultFeaturesManager
has the an apiRegionsExports field
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
which is not cleared between features, and as such the api-regions exports are
bleeding between generated features.
> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.6
> Reporter: A. J. David Bosschaert
>Priority: Major
>
> In some cases the cpconverter generates an {{api-regions}} section with
> {{global}} exports for packages, where the bundles providing those packages
> are not actually listed in the feature. I have seen features with _no_
> bundles (just some configuration) and an {{api-regions}} section with lots of
> exports, which clearly couldn't be satisfied by the feature as it did not
> have any bundles at all.
> I believe that this might be caused by the fact that the
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features being processed, and as such the
> api-regions exports are bleeding between generated features.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10858) Incorrect API Regions generated in features
[
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10858:
---
Affects Version/s: (was: Content-Package to Feature Model Converter
1.1.10)
(was: Content-Package to Feature Model Converter
1.1.6)
(was: Content-Package to Feature Model Converter
1.1.4)
> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.8
> Reporter: A. J. David Bosschaert
>Priority: Major
>
> In some cases the cpconverter generates an {{api-regions}} section with
> {{global}} exports for packages, where the bundles providing those packages
> are not actually listed in the feature. I have seen features with _not_
> bundles (just some configuration) and an {{api-regions}} section with lots of
> exports, which clearly couldn't be satisfied by the feature as it did not
> have any bundles at all.
> I believe that this might be caused by the fact that the
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features, and as such the api-regions exports
> are bleeding between generated features.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10858) Incorrect API Regions generated in features
[
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10858:
---
Affects Version/s: (was: Content-Package to Feature Model Converter
1.1.2)
(was: Content-Package to Feature Model Converter
1.1.0)
> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.4,
> Content-Package to Feature Model Converter 1.1.6, Content-Package to Feature
> Model Converter 1.1.8, Content-Package to Feature Model Converter 1.1.10
>Reporter: A. J. David Bosschaert
>Priority: Major
>
> In some cases the cpconverter generates an {{api-regions}} section with
> {{global}} exports for packages, where the bundles providing those packages
> are not actually listed in the feature. I have seen features with _not_
> bundles (just some configuration) and an {{api-regions}} section with lots of
> exports, which clearly couldn't be satisfied by the feature as it did not
> have any bundles at all.
> I believe that this might be caused by the fact that the
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features, and as such the api-regions exports
> are bleeding between generated features.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10858) Incorrect API Regions generated in features
[
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10858:
---
Affects Version/s: (was: Content-Package to Feature Model Converter
1.1.8)
Content-Package to Feature Model Converter 1.1.6
> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.6
> Reporter: A. J. David Bosschaert
>Priority: Major
>
> In some cases the cpconverter generates an {{api-regions}} section with
> {{global}} exports for packages, where the bundles providing those packages
> are not actually listed in the feature. I have seen features with _not_
> bundles (just some configuration) and an {{api-regions}} section with lots of
> exports, which clearly couldn't be satisfied by the feature as it did not
> have any bundles at all.
> I believe that this might be caused by the fact that the
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features, and as such the api-regions exports
> are bleeding between generated features.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10858) Incorrect API Regions generated in features
[
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10858:
---
Affects Version/s: Content-Package to Feature Model Converter 1.1.2
Content-Package to Feature Model Converter 1.1.4
Content-Package to Feature Model Converter 1.1.6
Content-Package to Feature Model Converter 1.1.8
> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.0,
> Content-Package to Feature Model Converter 1.1.2, Content-Package to Feature
> Model Converter 1.1.4, Content-Package to Feature Model Converter 1.1.6,
> Content-Package to Feature Model Converter 1.1.8, Content-Package to Feature
> Model Converter 1.1.10
> Reporter: A. J. David Bosschaert
>Priority: Major
>
> In some cases the cpconverter generates an {{api-regions}} section with
> {{global}} exports for packages, where the bundles providing those packages
> are not actually listed in the feature. I have seen features with _not_
> bundles (just some configuration) and an {{api-regions}} section with lots of
> exports, which clearly couldn't be satisfied by the feature as it did not
> have any bundles at all.
> I believe that this might be caused by the fact that the
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features, and as such the api-regions exports
> are bleeding between generated features.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10858) Incorrect API Regions generated in features
[
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10858:
---
Affects Version/s: Content-Package to Feature Model Converter 1.1.0
> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.0,
> Content-Package to Feature Model Converter 1.1.10
> Reporter: A. J. David Bosschaert
>Priority: Major
>
> In some cases the cpconverter generates an {{api-regions}} section with
> {{global}} exports for packages, where the bundles providing those packages
> are not actually listed in the feature. I have seen features with _not_
> bundles (just some configuration) and an {{api-regions}} section with lots of
> exports, which clearly couldn't be satisfied by the feature as it did not
> have any bundles at all.
> I believe that this might be caused by the fact that the
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features, and as such the api-regions exports
> are bleeding between generated features.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10858) Incorrect API Regions generated in features
A. J. David Bosschaert created SLING-10858:
--
Summary: Incorrect API Regions generated in features
Key: SLING-10858
URL: https://issues.apache.org/jira/browse/SLING-10858
Project: Sling
Issue Type: Bug
Components: Content-Package to Feature Model Converter
Affects Versions: Content-Package to Feature Model Converter 1.1.10
Reporter: A. J. David Bosschaert
In some cases the cpconverter generates an {{api-regions}} section with
{{global}} exports for packages, where the bundles providing those packages are
not actually listed in the feature. I have seen features with _not_ bundles
(just some configuration) and an {{api-regions}} section with lots of exports,
which clearly couldn't be satisfied by the feature as it did not have any
bundles at all.
I believe that this might be caused by the fact that the DefaultFeaturesManager
has the an apiRegionsExports field
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
which is not cleared between features, and as such the api-regions exports are
bleeding between generated features.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10785) AclManager.addAcl adds an entry not an access control list
[
https://issues.apache.org/jira/browse/SLING-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10785.
--
> AclManager.addAcl adds an entry not an access control list
> --
>
> Key: SLING-10785
> URL: https://issues.apache.org/jira/browse/SLING-10785
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> the method {{AclManager.addAcl(@NotNull String systemUser, @NotNull
> AccessControlEntry acl)}} is somewhat confusing because it adds an access
> control entry and not a list.
> what was probably meant originally was 'adding some sort of access control
> related information'. anyway i would suggest to rename the method to
> "addAccessControlEntry" or "addAccessControl" or "addEntry".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10789) JsonConfigurationEntryHandler - sonar finding
[ https://issues.apache.org/jira/browse/SLING-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10789. -- > JsonConfigurationEntryHandler - sonar finding > - > > Key: SLING-10789 > URL: https://issues.apache.org/jira/browse/SLING-10789 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10481) Review filter.xml creation for content package output of converter
[ https://issues.apache.org/jira/browse/SLING-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10481. -- > Review filter.xml creation for content package output of converter > -- > > Key: SLING-10481 > URL: https://issues.apache.org/jira/browse/SLING-10481 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.4 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > > The converter used to recalculate the filters for content-packages. Starting > with SLING-10243 that was made optional (maybe to not do it for sling initial > content packages) - however, it looks like it is now not done at all anymore. > We have to see if that is what we want and if the filters are still correct > for the converted packages (especially in the context of the principal and > acl work). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10755) DefaultAclManager.CONTENT_XML_FILE_NAME should be replace by filevault constant
[
https://issues.apache.org/jira/browse/SLING-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10755.
--
> DefaultAclManager.CONTENT_XML_FILE_NAME should be replace by filevault
> constant
> ---
>
> Key: SLING-10755
> URL: https://issues.apache.org/jira/browse/SLING-10755
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.8
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Trivial
> Labels: technical_debt
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> in order to limit hardcoding strings the private constant
> _CONTENT_XML_FILE_NAME_ in {{DefaultAclManager}} should be replace by
> {{org.apache.jackrabbit.vault.util.DOT_CONTENT_XML}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10778) *PolicyEntryHandler, *PolicyParser - sonar findings
[ https://issues.apache.org/jira/browse/SLING-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10778. -- > *PolicyEntryHandler, *PolicyParser - sonar findings > --- > > Key: SLING-10778 > URL: https://issues.apache.org/jira/browse/SLING-10778 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.10 > > > there are a few sonar findings in > - AbstractPolicyEntryHandler > - AbstractPolicyParser > - RepPolicyEntryHandler > - RepPrincipalPolicyEntryHandler > in addition, i would suggest to improve a few of names that refer to the list > when actually entries (or an entry) is meant. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10754) Missing entries in filter.xml
[
https://issues.apache.org/jira/browse/SLING-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10754.
--
> Missing entries in filter.xml
> -
>
> Key: SLING-10754
> URL: https://issues.apache.org/jira/browse/SLING-10754
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.8
>Reporter: Karl Pauls
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> The calculation for the filter.xml of converted content packages can miss
> filters if the target is defined inside a content.xml. As an example, a
> content package with an entry like:
> {noformat}
> jcr_root/_oak_index/.content.xml
>
> ...
>
> .
> {noformat}
> and a filter.xml containing:
> {noformat}
>
[jira] [Closed] (SLING-10783) XmlConfigurationEntryHandler - sonar findings
[
https://issues.apache.org/jira/browse/SLING-10783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10783.
--
> XmlConfigurationEntryHandler - sonar findings
> --
>
> Key: SLING-10783
> URL: https://issues.apache.org/jira/browse/SLING-10783
> Project: Sling
> Issue Type: Sub-task
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> see
> https://sonarcloud.io/code?id=apache_sling-org-apache-sling-feature-cpconverter=apache_sling-org-apache-sling-feature-cpconverter%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Ffeature%2Fcpconverter%2Fhandlers%2FXmlConfigurationEntryHandler.java
> in addition:
> the name of the inner class {{JcrConfigurationHandler extends
> AbstractJcrNodeParser}} is confusing. for the sake of consistency it should
> be named 'JcrConfigurationParser' instead of handler.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10758) Removed unused class SyntheticPathFilter
[
https://issues.apache.org/jira/browse/SLING-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10758.
--
> Removed unused class SyntheticPathFilter
>
>
> Key: SLING-10758
> URL: https://issues.apache.org/jira/browse/SLING-10758
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Labels: technical_debt
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> [~kpauls], the package private class
> {{org.apache.sling.feature.cpconverter.vltpkg.SyntheticPathFilter}} is not
> used anywhere. i would suggest that we get rid of it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10786) DefaultAclManager - sonar finding
[ https://issues.apache.org/jira/browse/SLING-10786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10786. -- > DefaultAclManager - sonar finding > - > > Key: SLING-10786 > URL: https://issues.apache.org/jira/browse/SLING-10786 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10780) AbstractConfigurationEntryHandler - sonar findings
[
https://issues.apache.org/jira/browse/SLING-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10780.
--
> AbstractConfigurationEntryHandler - sonar findings
> --
>
> Key: SLING-10780
> URL: https://issues.apache.org/jira/browse/SLING-10780
> Project: Sling
> Issue Type: Sub-task
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> fix sonar findings wrt public constructor and complexity.
> in addition: there are typos in comments and method names
> ({{setEnforceConfgurationBelowConfigFolder}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10769) VaultPackageAssembler should not implement EntryHandler
[
https://issues.apache.org/jira/browse/SLING-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10769.
--
> VaultPackageAssembler should not implement EntryHandler
> ---
>
> Key: SLING-10769
> URL: https://issues.apache.org/jira/browse/SLING-10769
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> [~kpauls], as stated with the PR for SLING-10754 i find it quite confusing
> the {{VaultPackageAssembler}} implements {{EntryHandler}} and is used as
> default in {{ContentPackage2FeatureModelConverter}}. even more so as the
> assembler is accessed by other {{EntryHandler}} implementations to add
> package entries that don't end up in repo-init.
> while the effect is likely the same if the {{EntryHandler}} methods get moved
> to a separate {{DefaultHandler}}, it would IMHO make the code easier to read.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10705) Improve exception handling and error reporting
[ https://issues.apache.org/jira/browse/SLING-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10705. -- > Improve exception handling and error reporting > -- > > Key: SLING-10705 > URL: https://issues.apache.org/jira/browse/SLING-10705 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > > The code is currently not distinguishing between user errors and tooling > errors. For example an IllegalStateException might be thrown if an OSGi > configuration is in the wrong place inside the content package as well as if > there is an internal error inside the tool. > While the first category of errors can be fixed by users fixing/adjusting > their code/content packlages - the second category hints at bugs in the code. > However both are reported exactly the same way. > I suggest we report the first one as errors via logging while the second one > throws an exception to the "outside". > We can probably achieve this without much effort by using a special exception > type for the first category. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10748) Feature Analyser should not embed dependencies
[ https://issues.apache.org/jira/browse/SLING-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10748. -- > Feature Analyser should not embed dependencies > -- > > Key: SLING-10748 > URL: https://issues.apache.org/jira/browse/SLING-10748 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 1.3.34 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 1.3.38, slingfeature-maven-plugin > 1.5.16 > > > Although the feature model analyser is a bundle with proper import statements > it is embedding some of the dependencies, like jackrabbit or the repoinit > parser. > This way, each time a new jackrabbit version or repoinit parser is released a > new release of the analyser is required - which we should avoid and decouple -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10776) DefaultFeaturesManager - sonar findings
[ https://issues.apache.org/jira/browse/SLING-10776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10776. -- > DefaultFeaturesManager - sonar findings > --- > > Key: SLING-10776 > URL: https://issues.apache.org/jira/browse/SLING-10776 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10788) ClassCastException is thrown when calling Json.createReader from a launcher extension
[
https://issues.apache.org/jira/browse/SLING-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10788.
--
> ClassCastException is thrown when calling Json.createReader from a launcher
> extension
> -
>
> Key: SLING-10788
> URL: https://issues.apache.org/jira/browse/SLING-10788
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model Launcher 1.1.22
> Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Launcher 1.1.26
>
>
> A ClassCastException is thrown when calling Json.createReader (JSON-P) from a
> launcher extension. The following stack trace shows the exception.
> {code}
> [ERROR] Error while running launcher:
> org.apache.johnzon.core.JsonProviderImpl not found
> javax.json.JsonException: org.apache.johnzon.core.JsonProviderImpl not found
> at javax.json.spi.JsonProvider.doLoadProvider(JsonProvider.java:118)
> at javax.json.spi.JsonProvider.provider(JsonProvider.java:89)
> at javax.json.Json.createReader(Json.java:88)
> ...
> at
> org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:268)
> at
> org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:170)
> at org.apache.sling.feature.launcher.impl.Main.main(Main.java:402)
> Caused by: java.lang.ClassCastException: Cannot cast
> org.apache.johnzon.core.JsonProviderImpl to javax.json.spi.JsonProvider
> at java.base/java.lang.Class.cast(Class.java:3605)
> at javax.json.spi.JsonProvider.doLoadProvider(JsonProvider.java:116)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10782) AbstractRegexEntryHandler - sonar findings
[ https://issues.apache.org/jira/browse/SLING-10782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10782. -- > AbstractRegexEntryHandler - sonar findings > -- > > Key: SLING-10782 > URL: https://issues.apache.org/jira/browse/SLING-10782 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.10 > > > accessibility of constructors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10777) VersionResolverContentPackageEntryHandler - sonar finding
[ https://issues.apache.org/jira/browse/SLING-10777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10777. -- > VersionResolverContentPackageEntryHandler - sonar finding > - > > Key: SLING-10777 > URL: https://issues.apache.org/jira/browse/SLING-10777 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10772) Reformat code in DefaultFeaturesManager, FeaturesManager
[
https://issues.apache.org/jira/browse/SLING-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10772.
--
> Reformat code in DefaultFeaturesManager, FeaturesManager
>
>
> Key: SLING-10772
> URL: https://issues.apache.org/jira/browse/SLING-10772
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Trivial
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> the indention is inconsistent and somewhat garbled in
> {{DefaultFeaturesManager}}, and {{FeaturesManager}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10788) ClassCastException is thrown when calling Json.createReader from a launcher extension
[
https://issues.apache.org/jira/browse/SLING-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-10788.
Resolution: Fixed
> ClassCastException is thrown when calling Json.createReader from a launcher
> extension
> -
>
> Key: SLING-10788
> URL: https://issues.apache.org/jira/browse/SLING-10788
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model Launcher 1.1.22
> Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Launcher 1.1.24
>
>
> A ClassCastException is thrown when calling Json.createReader (JSON-P) from a
> launcher extension. The following stack trace shows the exception.
> {code}
> [ERROR] Error while running launcher:
> org.apache.johnzon.core.JsonProviderImpl not found
> javax.json.JsonException: org.apache.johnzon.core.JsonProviderImpl not found
> at javax.json.spi.JsonProvider.doLoadProvider(JsonProvider.java:118)
> at javax.json.spi.JsonProvider.provider(JsonProvider.java:89)
> at javax.json.Json.createReader(Json.java:88)
> ...
> at
> org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:268)
> at
> org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:170)
> at org.apache.sling.feature.launcher.impl.Main.main(Main.java:402)
> Caused by: java.lang.ClassCastException: Cannot cast
> org.apache.johnzon.core.JsonProviderImpl to javax.json.spi.JsonProvider
> at java.base/java.lang.Class.cast(Class.java:3605)
> at javax.json.spi.JsonProvider.doLoadProvider(JsonProvider.java:116)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10788) ClassCastException is thrown when calling Json.createReader from a launcher extension
A. J. David Bosschaert created SLING-10788:
--
Summary: ClassCastException is thrown when calling
Json.createReader from a launcher extension
Key: SLING-10788
URL: https://issues.apache.org/jira/browse/SLING-10788
Project: Sling
Issue Type: Bug
Components: Feature Model
Affects Versions: Feature Model Launcher 1.1.22
Reporter: A. J. David Bosschaert
Fix For: Feature Model Launcher 1.1.24
A ClassCastException is thrown when calling Json.createReader (JSON-P) from a
launcher extension. The following stack trace shows the exception.
{code}
[ERROR] Error while running launcher: org.apache.johnzon.core.JsonProviderImpl
not found
javax.json.JsonException: org.apache.johnzon.core.JsonProviderImpl not found
at javax.json.spi.JsonProvider.doLoadProvider(JsonProvider.java:118)
at javax.json.spi.JsonProvider.provider(JsonProvider.java:89)
at javax.json.Json.createReader(Json.java:88)
...
at
org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:268)
at
org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:170)
at org.apache.sling.feature.launcher.impl.Main.main(Main.java:402)
Caused by: java.lang.ClassCastException: Cannot cast
org.apache.johnzon.core.JsonProviderImpl to javax.json.spi.JsonProvider
at java.base/java.lang.Class.cast(Class.java:3605)
at javax.json.spi.JsonProvider.doLoadProvider(JsonProvider.java:116)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-10788) ClassCastException is thrown when calling Json.createReader from a launcher extension
[
https://issues.apache.org/jira/browse/SLING-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert reassigned SLING-10788:
--
Assignee: A. J. David Bosschaert
> ClassCastException is thrown when calling Json.createReader from a launcher
> extension
> -
>
> Key: SLING-10788
> URL: https://issues.apache.org/jira/browse/SLING-10788
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model Launcher 1.1.22
> Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Launcher 1.1.24
>
>
> A ClassCastException is thrown when calling Json.createReader (JSON-P) from a
> launcher extension. The following stack trace shows the exception.
> {code}
> [ERROR] Error while running launcher:
> org.apache.johnzon.core.JsonProviderImpl not found
> javax.json.JsonException: org.apache.johnzon.core.JsonProviderImpl not found
> at javax.json.spi.JsonProvider.doLoadProvider(JsonProvider.java:118)
> at javax.json.spi.JsonProvider.provider(JsonProvider.java:89)
> at javax.json.Json.createReader(Json.java:88)
> ...
> at
> org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:268)
> at
> org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:170)
> at org.apache.sling.feature.launcher.impl.Main.main(Main.java:402)
> Caused by: java.lang.ClassCastException: Cannot cast
> org.apache.johnzon.core.JsonProviderImpl to javax.json.spi.JsonProvider
> at java.base/java.lang.Class.cast(Class.java:3605)
> at javax.json.spi.JsonProvider.doLoadProvider(JsonProvider.java:116)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10705) Improve exception handling and error reporting
[ https://issues.apache.org/jira/browse/SLING-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-10705: --- Fix Version/s: (was: Content-Package to Feature Model Converter 1.1.8) Content-Package to Feature Model Converter 1.1.10 > Improve exception handling and error reporting > -- > > Key: SLING-10705 > URL: https://issues.apache.org/jira/browse/SLING-10705 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.10 > > > The code is currently not distinguishing between user errors and tooling > errors. For example an IllegalStateException might be thrown if an OSGi > configuration is in the wrong place inside the content package as well as if > there is an internal error inside the tool. > While the first category of errors can be fixed by users fixing/adjusting > their code/content packlages - the second category hints at bugs in the code. > However both are reported exactly the same way. > I suggest we report the first one as errors via logging while the second one > throws an exception to the "outside". > We can probably achieve this without much effort by using a special exception > type for the first category. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10744) Generating Javadoc with parent 44 fails
[
https://issues.apache.org/jira/browse/SLING-10744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10744:
---
Fix Version/s: (was: Feature Model Analyser 1.3.36)
> Generating Javadoc with parent 44 fails
> ---
>
> Key: SLING-10744
> URL: https://issues.apache.org/jira/browse/SLING-10744
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model Analyser 1.3.34
> Reporter: A. J. David Bosschaert
>Priority: Major
>
> When running {{mvn javadoc:jar}} with parent 44 the execution fails as
> follows:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M4:perform (default-cli)
> on project org.apache.sling.feature.analyser: Maven execution failed, exit
> code: '1' -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-release-plugin:3.0.0-M4:perform
> (default-cli) on project org.apache.sling.feature.analyser: Maven execution
> failed, exit code: '1'
> {code}
> Seems to be some date/time problem with the Javadoc:
> {code}
> [INFO] Caused by: java.time.format.DateTimeParseException: Text '1' could not
> be parsed at index 0
> [INFO] at java.time.format.DateTimeFormatter.parseResolved0
> (DateTimeFormatter.java:2046)
> [INFO] at java.time.format.DateTimeFormatter.parse
> (DateTimeFormatter.java:1874)
> [INFO] at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getBottomText
> (AbstractJavadocMojo.java:3007)
> [INFO] at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addStandardDocletOptions
> (AbstractJavadocMojo.java:5549)
> [INFO] at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport
> (AbstractJavadocMojo.java:2170)
> [INFO] at org.apache.maven.plugins.javadoc.JavadocJar.doExecute
> (JavadocJar.java:199)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10744) Generating Javadoc with parent 44 fails
[
https://issues.apache.org/jira/browse/SLING-10744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-10744.
Resolution: Duplicate
> Generating Javadoc with parent 44 fails
> ---
>
> Key: SLING-10744
> URL: https://issues.apache.org/jira/browse/SLING-10744
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model Analyser 1.3.34
> Reporter: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Analyser 1.3.36
>
>
> When running {{mvn javadoc:jar}} with parent 44 the execution fails as
> follows:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M4:perform (default-cli)
> on project org.apache.sling.feature.analyser: Maven execution failed, exit
> code: '1' -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-release-plugin:3.0.0-M4:perform
> (default-cli) on project org.apache.sling.feature.analyser: Maven execution
> failed, exit code: '1'
> {code}
> Seems to be some date/time problem with the Javadoc:
> {code}
> [INFO] Caused by: java.time.format.DateTimeParseException: Text '1' could not
> be parsed at index 0
> [INFO] at java.time.format.DateTimeFormatter.parseResolved0
> (DateTimeFormatter.java:2046)
> [INFO] at java.time.format.DateTimeFormatter.parse
> (DateTimeFormatter.java:1874)
> [INFO] at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getBottomText
> (AbstractJavadocMojo.java:3007)
> [INFO] at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addStandardDocletOptions
> (AbstractJavadocMojo.java:5549)
> [INFO] at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport
> (AbstractJavadocMojo.java:2170)
> [INFO] at org.apache.maven.plugins.javadoc.JavadocJar.doExecute
> (JavadocJar.java:199)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10744) Generating Javadoc with parent 44 fails
[
https://issues.apache.org/jira/browse/SLING-10744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10744:
---
Component/s: (was: Feature Model Analyser)
Feature Model
> Generating Javadoc with parent 44 fails
> ---
>
> Key: SLING-10744
> URL: https://issues.apache.org/jira/browse/SLING-10744
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model Analyser 1.3.34
> Reporter: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Analyser 1.3.36
>
>
> When running {{mvn javadoc:jar}} with parent 44 the execution fails as
> follows:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M4:perform (default-cli)
> on project org.apache.sling.feature.analyser: Maven execution failed, exit
> code: '1' -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-release-plugin:3.0.0-M4:perform
> (default-cli) on project org.apache.sling.feature.analyser: Maven execution
> failed, exit code: '1'
> {code}
> Seems to be some date/time problem with the Javadoc:
> {code}
> [INFO] Caused by: java.time.format.DateTimeParseException: Text '1' could not
> be parsed at index 0
> [INFO] at java.time.format.DateTimeFormatter.parseResolved0
> (DateTimeFormatter.java:2046)
> [INFO] at java.time.format.DateTimeFormatter.parse
> (DateTimeFormatter.java:1874)
> [INFO] at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getBottomText
> (AbstractJavadocMojo.java:3007)
> [INFO] at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addStandardDocletOptions
> (AbstractJavadocMojo.java:5549)
> [INFO] at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport
> (AbstractJavadocMojo.java:2170)
> [INFO] at org.apache.maven.plugins.javadoc.JavadocJar.doExecute
> (JavadocJar.java:199)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10744) Generating Javadoc with parent 44 fails
A. J. David Bosschaert created SLING-10744:
--
Summary: Generating Javadoc with parent 44 fails
Key: SLING-10744
URL: https://issues.apache.org/jira/browse/SLING-10744
Project: Sling
Issue Type: Bug
Components: Feature Model Analyser
Affects Versions: Feature Model Analyser 1.3.34
Reporter: A. J. David Bosschaert
Fix For: Feature Model Analyser 1.3.36
When running {{mvn javadoc:jar}} with parent 44 the execution fails as follows:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:3.0.0-M4:perform (default-cli) on
project org.apache.sling.feature.analyser: Maven execution failed, exit code:
'1' -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:3.0.0-M4:perform (default-cli) on
project org.apache.sling.feature.analyser: Maven execution failed, exit code:
'1'
{code}
Seems to be some date/time problem with the Javadoc:
{code}
[INFO] Caused by: java.time.format.DateTimeParseException: Text '1' could not
be parsed at index 0
[INFO] at java.time.format.DateTimeFormatter.parseResolved0
(DateTimeFormatter.java:2046)
[INFO] at java.time.format.DateTimeFormatter.parse
(DateTimeFormatter.java:1874)
[INFO] at
org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getBottomText
(AbstractJavadocMojo.java:3007)
[INFO] at
org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addStandardDocletOptions
(AbstractJavadocMojo.java:5549)
[INFO] at
org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport
(AbstractJavadocMojo.java:2170)
[INFO] at org.apache.maven.plugins.javadoc.JavadocJar.doExecute
(JavadocJar.java:199)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10587) Update to feature model 1.2.28 to avoid FileSystemNotFoundExceptions
[ https://issues.apache.org/jira/browse/SLING-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-10587. Assignee: Carsten Ziegeler (was: A. J. David Bosschaert) Resolution: Fixed > Update to feature model 1.2.28 to avoid FileSystemNotFoundExceptions > > > Key: SLING-10587 > URL: https://issues.apache.org/jira/browse/SLING-10587 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Launcher 1.1.20 >Reporter: Karl Pauls >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Launcher 1.1.22 > > > We need to update the launcher to the latest feature model dependency (when > it is released) to avoid FileSystemNotFoundException on startup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10587) Update to feature model 1.2.28 to avoid FileSystemNotFoundExceptions
[ https://issues.apache.org/jira/browse/SLING-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401720#comment-17401720 ] A. J. David Bosschaert commented on SLING-10587: Ah I see this one is already fixed. Thanks [~cziegeler]! > Update to feature model 1.2.28 to avoid FileSystemNotFoundExceptions > > > Key: SLING-10587 > URL: https://issues.apache.org/jira/browse/SLING-10587 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Launcher 1.1.20 >Reporter: Karl Pauls > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model Launcher 1.1.22 > > > We need to update the launcher to the latest feature model dependency (when > it is released) to avoid FileSystemNotFoundException on startup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10587) Update to feature model 1.2.28 to avoid FileSystemNotFoundExceptions
[ https://issues.apache.org/jira/browse/SLING-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert reassigned SLING-10587: -- Assignee: A. J. David Bosschaert > Update to feature model 1.2.28 to avoid FileSystemNotFoundExceptions > > > Key: SLING-10587 > URL: https://issues.apache.org/jira/browse/SLING-10587 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Launcher 1.1.20 >Reporter: Karl Pauls > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model Launcher 1.1.22 > > > We need to update the launcher to the latest feature model dependency (when > it is released) to avoid FileSystemNotFoundException on startup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10572) Update to latest dependencies
[ https://issues.apache.org/jira/browse/SLING-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10572. -- > Update to latest dependencies > - > > Key: SLING-10572 > URL: https://issues.apache.org/jira/browse/SLING-10572 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.5.8 > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.5.10 > > > Update the slingfeature-maven-plugin to use the latest dependencies of the > feature model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10565) Additional properties are not validated according to the validation mode
[ https://issues.apache.org/jira/browse/SLING-10565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10565. -- > Additional properties are not validated according to the validation mode > > > Key: SLING-10565 > URL: https://issues.apache.org/jira/browse/SLING-10565 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model API Regions Extension 1.3.2 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model API Regions Extension 1.3.4 > > > When a configuration is having additional (internal) properties, this > currently always results in a validation error regardless of the validation > mode -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10568) Use configuration property origin for validation
[ https://issues.apache.org/jira/browse/SLING-10568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10568. -- > Use configuration property origin for validation > > > Key: SLING-10568 > URL: https://issues.apache.org/jira/browse/SLING-10568 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model API Regions Extension 1.3.4 > > > With SLING-10566 feature origins are tracked per configuration property. This > information should be leveraged to properly validate configuration properties -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10566) Keep track of feature origins per configuration property
[ https://issues.apache.org/jira/browse/SLING-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10566. -- > Keep track of feature origins per configuration property > > > Key: SLING-10566 > URL: https://issues.apache.org/jira/browse/SLING-10566 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 1.2.26 > > > When features are merged, currently only the origins of a complete > configuration are tracked - however this not allow to know from which feature > a particular property of that configuration originated > We should extend the tracking to properties (like we do with framework > properties) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10567) NPE when obtaining ArtifactManager
[
https://issues.apache.org/jira/browse/SLING-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10567.
--
> NPE when obtaining ArtifactManager
> --
>
> Key: SLING-10567
> URL: https://issues.apache.org/jira/browse/SLING-10567
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model 1.2.24
> Reporter: A. J. David Bosschaert
> Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model 1.2.26
>
>
> When obtaining and {{ArtifactManager}} it's possible to get an NPE:
> {code}
> java.lang.NullPointerException
> at
> org.apache.sling.feature.io.artifacts.ArtifactManager$DefaultArtifactHandler.init(ArtifactManager.java:357)
> at
> org.apache.sling.feature.io.artifacts.ArtifactManager.(ArtifactManager.java:107)
> at
> org.apache.sling.feature.io.artifacts.ArtifactManager.getArtifactManager(ArtifactManager.java:92)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [osgi] mixing Consumer and Provider interfaces + best practices around Consumer/Provider
Hi Bertrand, The OSGi semantic versioning whitepaper has a lot of info about this: https://docs.osgi.org/whitepaper/semantic-versioning/ Best regards, David On Tue, 29 Jun 2021 at 15:49, Bertrand Delacretaz wrote: > Hi Konrad, > > On Tue, Jun 29, 2021 at 3:04 PM Konrad Windszus wrote: > > - Please don't mix Consumer and Provider interfaces in the same package > > ( > https://github.com/apache/sling-org-apache-sling-sitemap/tree/master/src/main/java/org/apache/sling/sitemap/generator > > and > > > https://github.com/apache/sling-org-apache-sling-sitemap/tree/master/src/main/java/org/apache/sling/sitemap/builder/extensions > ) > > as that enforces updates to break more consumers than necessary > > Could you elaborate on that? The issue is not obvious to me. > > More generally, I think it would be useful for us to document best > practices around Consumer and Provider interfaces. > > If someone has links to such best practices that would be great, > otherwise feel free to add some notes in response to this message and > I'll write something up for https://sling.apache.org/ > > -Bertrand >
[jira] [Resolved] (SLING-10572) Update to latest dependencies
[ https://issues.apache.org/jira/browse/SLING-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-10572. Resolution: Fixed > Update to latest dependencies > - > > Key: SLING-10572 > URL: https://issues.apache.org/jira/browse/SLING-10572 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.5.8 > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.5.10 > > > Update the slingfeature-maven-plugin to use the latest dependencies of the > feature model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10572) Update to latest dependencies
[ https://issues.apache.org/jira/browse/SLING-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-10572: --- Affects Version/s: slingfeature-maven-plugin 1.5.8 > Update to latest dependencies > - > > Key: SLING-10572 > URL: https://issues.apache.org/jira/browse/SLING-10572 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.5.8 > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.5.8 > > > Update the slingfeature-maven-plugin to use the latest dependencies of the > feature model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10572) Update to latest dependencies
[ https://issues.apache.org/jira/browse/SLING-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-10572: --- Fix Version/s: (was: slingfeature-maven-plugin 1.5.8) slingfeature-maven-plugin 1.5.10 > Update to latest dependencies > - > > Key: SLING-10572 > URL: https://issues.apache.org/jira/browse/SLING-10572 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.5.8 > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.5.10 > > > Update the slingfeature-maven-plugin to use the latest dependencies of the > feature model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10572) Update to latest dependencies
A. J. David Bosschaert created SLING-10572: -- Summary: Update to latest dependencies Key: SLING-10572 URL: https://issues.apache.org/jira/browse/SLING-10572 Project: Sling Issue Type: Improvement Components: Feature Model, Maven Plugins and Archetypes Reporter: A. J. David Bosschaert Assignee: A. J. David Bosschaert Fix For: slingfeature-maven-plugin 1.5.8 Update the slingfeature-maven-plugin to use the latest dependencies of the feature model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10494) Configuration API should have a way to allow empty configurations
[ https://issues.apache.org/jira/browse/SLING-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10494. -- > Configuration API should have a way to allow empty configurations > - > > Key: SLING-10494 > URL: https://issues.apache.org/jira/browse/SLING-10494 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model API Regions Extension 1.3.0 >Reporter: Karl Pauls >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model API Regions Extension 1.3.2 > > > The way the Configuration API currently handles configurations (and factory > configurations) is that an empty entry means don't allow. In other words, > listing an empty configuration (factory) is the same as marking it as > internal-configuration(-factory). > That makes sense in as far as that makes it nicer to be able to specify > configurations that are not allowed inline with the other configurations - > however, it misses a case where it is now impossible to allow an empty > configuration. > That could be problematic as sometimes, empty configurations are used to > configure e.g. services - that use case would at a minimum now not show up in > the Configuration API as one would be forced not to mention the configuration > at all in order to allow somebody to still be able to create an empty > configuration. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10511) Remove the ApiRegionsExtensionScanner
[ https://issues.apache.org/jira/browse/SLING-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10511. -- > Remove the ApiRegionsExtensionScanner > - > > Key: SLING-10511 > URL: https://issues.apache.org/jira/browse/SLING-10511 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model API Regions Extension 1.3.0 >Reporter: Natalia Angulo Herrera >Assignee: Carsten Ziegeler >Priority: Major > Labels: Scanner > Fix For: Feature Model API Regions Extension 1.3.2 > > > The api regions extension scanner shouldn't handle the content package > extension. We plan to remove it and don't fail if no extension is used to see > if the current content package extension issue that we are experiencing is > solved. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10552) Update to latest dependencies
[ https://issues.apache.org/jira/browse/SLING-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10552. -- > Update to latest dependencies > - > > Key: SLING-10552 > URL: https://issues.apache.org/jira/browse/SLING-10552 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.5.8 > > > Update the slingfeature-maven-plugin to use the latest dependencies of the > feature model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10530) Validation mode is not respected for internal configurations
[ https://issues.apache.org/jira/browse/SLING-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10530. -- > Validation mode is not respected for internal configurations > > > Key: SLING-10530 > URL: https://issues.apache.org/jira/browse/SLING-10530 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model API Regions Extension 1.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model API Regions Extension 1.3.2 > > > When internal configurations are listed just by name, then the validation > mode is not respected -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10501) The analyser scanner should pass the artifact url to the resource builder
[
https://issues.apache.org/jira/browse/SLING-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10501.
--
> The analyser scanner should pass the artifact url to the resource builder
> -
>
> Key: SLING-10501
> URL: https://issues.apache.org/jira/browse/SLING-10501
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.26
>Reporter: Karl Pauls
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.3.28
>
>
> When the scanner is parsing artifacts it uses the ResourceBuilder from Felix
> but doesn't give it the url of the artifact. That makes it so that if the
> artifact can not be parsed (e.g. because it has invalid metadata) an
> exception is thrown that doesn't give any indication of the artifact that
> caused it.
> Looks like this:
> {noformat}
> org.osgi.framework.BundleException: Unable to build resource for null:
> Duplicate import: foo
> {noformat}
> The scanner should pass the artifact url at [0] to the Resourcebuilder so
> that the exception contains the artifact id.
> [0]
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/89d5544fbc86adf6b5a99f7a2cb96055dcb3b3d1/src/main/java/org/apache/sling/feature/scanner/impl/BundleDescriptorImpl.java#L227
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10512) Analysers should not fail if no scanner is found
[ https://issues.apache.org/jira/browse/SLING-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10512. -- > Analysers should not fail if no scanner is found > > > Key: SLING-10512 > URL: https://issues.apache.org/jira/browse/SLING-10512 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 1.3.26 >Reporter: Natalia Angulo Herrera >Assignee: Carsten Ziegeler >Priority: Major > Labels: Scanner > Fix For: Feature Model Analyser 1.3.28 > > > Change analysers to not fail if no scanner is found > [https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/a5fe8cb8b73f226c32819fc0dd5c7c253a4f141d/src/main/java/org/apache/sling/feature/scanner/Scanner.java#L188] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10458) ArtifactManager: Use NIO Files
[ https://issues.apache.org/jira/browse/SLING-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10458. -- > ArtifactManager: Use NIO Files > -- > > Key: SLING-10458 > URL: https://issues.apache.org/jira/browse/SLING-10458 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Feature Model 1.2.24 > > > To improve exception handling and benefit from added methods only NIO Files > classes > (https://docs.oracle.com/javase/8/docs/api/java/nio/file/package-summary.html) > should be used. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10545) Make manifest for content packages optional
[ https://issues.apache.org/jira/browse/SLING-10545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10545. -- > Make manifest for content packages optional > --- > > Key: SLING-10545 > URL: https://issues.apache.org/jira/browse/SLING-10545 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 1.3.28 > > > The scanner for a content package always tries to parse the manifest, however > if that manifest is invalide (which seems to be quiet common), then the > scanner fails with an IOException. > As the manifest is unusable anyway - but for most analysers not needed, it > should gracefully ignore the exception and return null instead of the manifest -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10451) ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory
[
https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10451.
--
> ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp
> directory
> ---
>
> Key: SLING-10451
> URL: https://issues.apache.org/jira/browse/SLING-10451
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Feature Model 1.2.24
>
>
> With every run of {{FeatureBuilder.assemble}} empty folders starting with
> prefix {{slingfeature}} and followed by a random number are left in the java
> tmp folder. Those should be properly cleaned up. The creation happens in
> https://github.com/apache/sling-org-apache-sling-feature/blob/afbad06b30ad1ff81ce25d8a27d3dcd2abbfc035/src/main/java/org/apache/sling/feature/io/artifacts/ArtifactManagerConfig.java#L66.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10513) Merging artifact extensions will not preserve the feature origin of the first feature
[ https://issues.apache.org/jira/browse/SLING-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10513. -- > Merging artifact extensions will not preserve the feature origin of the first > feature > - > > Key: SLING-10513 > URL: https://issues.apache.org/jira/browse/SLING-10513 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model 1.2.22 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Feature Model 1.2.24 > > > When merging two features, the default merge for the artifact extensions > (like e.g. the content-packages extension) will not preserve the origin of > the first feature because it will just take the extension as is. Only the > second feature will get the feature origin when it is merged into the first > one. > We should fix this by making sure the feature origin is written even for the > first feature (the best way is probably to just merge the first feature with > an empty extension just like the second one will be merged). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10186) Enhance cli parsing on sling-feature-launcher
[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10186.
--
> Enhance cli parsing on sling-feature-launcher
> -
>
> Key: SLING-10186
> URL: https://issues.apache.org/jira/browse/SLING-10186
> Project: Sling
> Issue Type: Improvement
>Reporter: Stefan Bischof
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Launcher 1.1.20
>
>
> extract opts as Constants
> add longOpt to Options
> fix plural in description
> use Builder-pattern to build Options
> set numberOfArgs , valueSeparator(',')
> accept (but ignore) empty options without ParsingExceptions
> using .optionalArg(true) and Optionals
> option to set loglevel on verbose Option
> update common-cli version
> use DefaultParser not deprecated BasicParser
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10567) NPE when obtaining ArtifactManager
[
https://issues.apache.org/jira/browse/SLING-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-10567.
Resolution: Fixed
> NPE when obtaining ArtifactManager
> --
>
> Key: SLING-10567
> URL: https://issues.apache.org/jira/browse/SLING-10567
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model 1.2.24
> Reporter: A. J. David Bosschaert
> Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model 1.2.26
>
>
> When obtaining and {{ArtifactManager}} it's possible to get an NPE:
> {code}
> java.lang.NullPointerException
> at
> org.apache.sling.feature.io.artifacts.ArtifactManager$DefaultArtifactHandler.init(ArtifactManager.java:357)
> at
> org.apache.sling.feature.io.artifacts.ArtifactManager.(ArtifactManager.java:107)
> at
> org.apache.sling.feature.io.artifacts.ArtifactManager.getArtifactManager(ArtifactManager.java:92)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10567) NPE when obtaining ArtifactManager
A. J. David Bosschaert created SLING-10567:
--
Summary: NPE when obtaining ArtifactManager
Key: SLING-10567
URL: https://issues.apache.org/jira/browse/SLING-10567
Project: Sling
Issue Type: Bug
Components: Feature Model
Affects Versions: Feature Model 1.2.24
Reporter: A. J. David Bosschaert
Assignee: A. J. David Bosschaert
Fix For: Feature Model 1.2.26
When obtaining and {{ArtifactManager}} it's possible to get an NPE:
{code}
java.lang.NullPointerException
at
org.apache.sling.feature.io.artifacts.ArtifactManager$DefaultArtifactHandler.init(ArtifactManager.java:357)
at
org.apache.sling.feature.io.artifacts.ArtifactManager.(ArtifactManager.java:107)
at
org.apache.sling.feature.io.artifacts.ArtifactManager.getArtifactManager(ArtifactManager.java:92)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (SLING-10451) ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory
[
https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert reopened SLING-10451:
> ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp
> directory
> ---
>
> Key: SLING-10451
> URL: https://issues.apache.org/jira/browse/SLING-10451
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Feature Model 1.2.24
>
>
> With every run of {{FeatureBuilder.assemble}} empty folders starting with
> prefix {{slingfeature}} and followed by a random number are left in the java
> tmp folder. Those should be properly cleaned up. The creation happens in
> https://github.com/apache/sling-org-apache-sling-feature/blob/afbad06b30ad1ff81ce25d8a27d3dcd2abbfc035/src/main/java/org/apache/sling/feature/io/artifacts/ArtifactManagerConfig.java#L66.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10451) ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory
[
https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-10451.
Resolution: Fixed
> ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp
> directory
> ---
>
> Key: SLING-10451
> URL: https://issues.apache.org/jira/browse/SLING-10451
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Feature Model 1.2.24
>
>
> With every run of {{FeatureBuilder.assemble}} empty folders starting with
> prefix {{slingfeature}} and followed by a random number are left in the java
> tmp folder. Those should be properly cleaned up. The creation happens in
> https://github.com/apache/sling-org-apache-sling-feature/blob/afbad06b30ad1ff81ce25d8a27d3dcd2abbfc035/src/main/java/org/apache/sling/feature/io/artifacts/ArtifactManagerConfig.java#L66.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10552) Update to latest dependencies
[ https://issues.apache.org/jira/browse/SLING-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-10552. Resolution: Fixed > Update to latest dependencies > - > > Key: SLING-10552 > URL: https://issues.apache.org/jira/browse/SLING-10552 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.5.8 > > > Update the slingfeature-maven-plugin to use the latest dependencies of the > feature model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10552) Update to latest dependencies
[ https://issues.apache.org/jira/browse/SLING-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-10552: --- Fix Version/s: (was: slingfeature-maven-plugin 1.5.6) slingfeature-maven-plugin 1.5.8 > Update to latest dependencies > - > > Key: SLING-10552 > URL: https://issues.apache.org/jira/browse/SLING-10552 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes > Reporter: A. J. David Bosschaert > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.5.8 > > > Update the slingfeature-maven-plugin to use the latest dependencies of the > feature model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10552) Update to latest dependencies
A. J. David Bosschaert created SLING-10552: -- Summary: Update to latest dependencies Key: SLING-10552 URL: https://issues.apache.org/jira/browse/SLING-10552 Project: Sling Issue Type: Improvement Components: Feature Model, Maven Plugins and Archetypes Reporter: A. J. David Bosschaert Assignee: A. J. David Bosschaert Fix For: slingfeature-maven-plugin 1.5.6 Update the slingfeature-maven-plugin to use the latest dependencies of the feature model. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10186) Enhance cli parsing on sling-feature-launcher
[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10186:
---
Fix Version/s: (was: Feature Model Launcher 1.1.18)
Feature Model Launcher 1.1.20
> Enhance cli parsing on sling-feature-launcher
> -
>
> Key: SLING-10186
> URL: https://issues.apache.org/jira/browse/SLING-10186
> Project: Sling
> Issue Type: Improvement
>Reporter: Stefan Bischof
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Launcher 1.1.20
>
>
> extract opts as Constants
> add longOpt to Options
> fix plural in description
> use Builder-pattern to build Options
> set numberOfArgs , valueSeparator(',')
> accept (but ignore) empty options without ParsingExceptions
> using .optionalArg(true) and Optionals
> option to set loglevel on verbose Option
> update common-cli version
> use DefaultParser not deprecated BasicParser
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10457) SPI ArtifactProvider should implement Closeable
[ https://issues.apache.org/jira/browse/SLING-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-10457: --- Fix Version/s: (was: Feature Model 1.2.24) > SPI ArtifactProvider should implement Closeable > --- > > Key: SLING-10457 > URL: https://issues.apache.org/jira/browse/SLING-10457 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Konrad Windszus >Priority: Major > > The shutdown() method should be deprecated and instead a regular close() > should be used. That way exceptions can be propagated to the callers. > Compare with [https://github.com/adobe/aemanalyser-maven-plugin/issues/76] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10470) Add configuration for defining bundle metadata like symbolic name in manifest file
[ https://issues.apache.org/jira/browse/SLING-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10470. -- > Add configuration for defining bundle metadata like symbolic name in manifest > file > --- > > Key: SLING-10470 > URL: https://issues.apache.org/jira/browse/SLING-10470 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Darshan Mahor >Assignee: Carsten Ziegeler >Priority: Minor > Fix For: slingfeature-maven-plugin 1.5.6 > > > Currently, we use feature's artifactID for defining the bundle related > metadata like symbolic name , name, specification details and impl title in > manifest file. we should have a mechanism via which we can pass the config > for defining it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10475) plugin's apis-jar goal fails for empty jar
[
https://issues.apache.org/jira/browse/SLING-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10475.
--
> plugin's apis-jar goal fails for empty jar
> --
>
> Key: SLING-10475
> URL: https://issues.apache.org/jira/browse/SLING-10475
> Project: Sling
> Issue Type: Bug
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Darshan Mahor
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.5.6
>
>
> Plugin's apis-jar goal fails when we have empty APIs jar. It fails while
> writing the source-report.txt. We can fix this via ensuring that
> [https://github.com/apache/sling-slingfeature-maven-plugin/blob/master/src/main/java/org/apache/sling/feature/maven/mojos/ApisJarMojo.java#L425]
> directory exists before we write sources-report.
> {code:java}
> Caused by: org.apache.maven.plugin.MojoExecutionException: Unable to write
> /Users/admin/git_codebase/sdk-builder/target/apis-prerelease-jars/sdk-builder-sources-report.txt
> at org.apache.sling.feature.maven.mojos.apis.ApisUtil.writeSourceReport
> (ApisUtil.java:514)
> at org.apache.sling.feature.maven.mojos.ApisJarMojo.onFeature
> (ApisJarMojo.java:527)
> at org.apache.sling.feature.maven.mojos.ApisJarMojo.execute
> (ApisJarMojo.java:449)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10473) Provide a way to disable placeholder check
[ https://issues.apache.org/jira/browse/SLING-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10473. -- > Provide a way to disable placeholder check > -- > > Key: SLING-10473 > URL: https://issues.apache.org/jira/browse/SLING-10473 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model API Regions Extension 1.3.0 > > > The configuration api validation is currently based on the "raw" values > containing placeholders, skipping values with placeholders. > However, if the check is done against live values, then the placeholder > policy requiring a placeholder for a value (like a password) will fail - > although it should not -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10471) Allow giving and evaluating an optional removal date for deprecated package exports
[ https://issues.apache.org/jira/browse/SLING-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10471. -- > Allow giving and evaluating an optional removal date for deprecated package > exports > --- > > Key: SLING-10471 > URL: https://issues.apache.org/jira/browse/SLING-10471 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Affects Versions: Feature Model API Regions Extension 1.2.10 >Reporter: Konrad Windszus >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model API Regions Extension 1.3.0 > > > The [CheckDeprecatedApi > analyser|https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/blob/master/src/main/java/org/apache/sling/feature/extension/apiregions/analyser/CheckDeprecatedApi.java] > should automatically raise warnings to errors in case a deprecated package > is used which is soon to be removed. > That requires extending the > [ApiExport|https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/blob/30868952cdb97f6e0c63839ab808ff680bc092bc/src/main/java/org/apache/sling/feature/extension/apiregions/api/ApiExport.java#L38] > to allow it to hold a removal date for deprecated exported packages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10482) Make it possible to validate values with property placeholders
[
https://issues.apache.org/jira/browse/SLING-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10482.
--
> Make it possible to validate values with property placeholders
> --
>
> Key: SLING-10482
> URL: https://issues.apache.org/jira/browse/SLING-10482
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Reporter: A. J. David Bosschaert
> Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.3.0
>
>
> Properties with placeholders can still conform to a certain pattern. We need
> to be able to validate against such pattern.
> For example if you have a value:
> {{foobar $[env:FOO_BAR]}}
> Then it can still be validated against a regular expression.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10482) Make it possible to validate values with property placeholders
[
https://issues.apache.org/jira/browse/SLING-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-10482.
Resolution: Fixed
> Make it possible to validate values with property placeholders
> --
>
> Key: SLING-10482
> URL: https://issues.apache.org/jira/browse/SLING-10482
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Reporter: A. J. David Bosschaert
> Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.2.12
>
>
> Properties with placeholders can still conform to a certain pattern. We need
> to be able to validate against such pattern.
> For example if you have a value:
> {{foobar $[env:FOO_BAR]}}
> Then it can still be validated against a regular expression.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10482) Make it possible to validate values with property placeholders
A. J. David Bosschaert created SLING-10482:
--
Summary: Make it possible to validate values with property
placeholders
Key: SLING-10482
URL: https://issues.apache.org/jira/browse/SLING-10482
Project: Sling
Issue Type: Improvement
Components: Feature Model
Reporter: A. J. David Bosschaert
Assignee: A. J. David Bosschaert
Fix For: Feature Model API Regions Extension 1.2.12
Properties with placeholders can still conform to a certain pattern. We need to
be able to validate against such pattern.
For example if you have a value:
{{foobar $[env:FOO_BAR]}}
Then it can still be validated against a regular expression.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10434) ArrayIndexOutOfBoundsException in RegionConfiguration#handleMapConfig
[
https://issues.apache.org/jira/browse/SLING-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10434.
--
> ArrayIndexOutOfBoundsException in RegionConfiguration#handleMapConfig
> -
>
> Key: SLING-10434
> URL: https://issues.apache.org/jira/browse/SLING-10434
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.1.6
>Reporter: Dirk Rudolph
>Priority: Major
> Fix For: Feature Model API Regions Runtime Fragment 1.1.8
>
>
> I get the following ArrayIndexOutOfBoundsException for a similar feature
> model as provided below:
> {code:java}
> 28.05.2021 17:06:09.328 *ERROR* [FelixLogListener]
> org.apache.felix.configadmin Service
> [org.apache.felix.cm.ConfigurationAdmin,39,
> [org.osgi.service.cm.ConfigurationAdmin]] Unexpected problem delivering
> configuration event to [org.osgi.service.cm.SynchronousConfigurationListener,
> id=40, bundle=0/System Bundle] (java.lang.ArrayIndexOutOfBoundsException:
> Index 1 out of bounds for length 1)
> java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
> at
> org.apache.sling.feature.apiregions.impl.RegionConfiguration.handleMapConfig(RegionConfiguration.java:268)
> at
> org.apache.sling.feature.apiregions.impl.RegionConfiguration.updateConfiguration(RegionConfiguration.java:236)
> at
> org.apache.sling.feature.apiregions.impl.RegionConfiguration.setConfig(RegionConfiguration.java:471)
> at
> org.apache.sling.feature.apiregions.impl.Activator$3.invoke(Activator.java:269)
> at com.sun.proxy.$Proxy6.configurationEvent(Unknown Source)
> at
> org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.sendEvent(ConfigurationManager.java:1720)
> at
> org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.run(ConfigurationManager.java:1662)
> at
> org.apache.felix.cm.impl.ConfigurationManager.fireConfigurationEvent(ConfigurationManager.java:658)
> at
> org.apache.felix.cm.impl.ConfigurationManager.updated(ConfigurationManager.java:613)
> at
> org.apache.felix.cm.impl.ConfigurationImpl.update(ConfigurationImpl.java:467)
> at
> org.apache.felix.cm.impl.ConfigurationAdapter.update(ConfigurationAdapter.java:145)
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.execute(ConfigInstallTask.java:78)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:918)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:755)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:304)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
> Example Feature Model
> {code:java}
> {
>
> "id":"com.exmaple:my-cloud-ready-feature-pkg:slingosgifeature:tiera:12345-SNAPSHOT",
> "bundles":[
> {
> "id":"com.example:my-bundle:1.2.3-SNAPSHOT",
> "start-order":"20"
> }
> ],
> "api-regions:JSON|false":[
> {
> "name":"global",
> "exports":[
> "com.example.my"
> ]
> }
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10404) Log: 'No Configuration Admin API available' when it is available
[
https://issues.apache.org/jira/browse/SLING-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10404.
--
> Log: 'No Configuration Admin API available' when it is available
>
>
> Key: SLING-10404
> URL: https://issues.apache.org/jira/browse/SLING-10404
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.1.6
>Reporter: Karl Pauls
> Assignee: A. J. David Bosschaert
>Priority: Minor
> Fix For: Feature Model API Regions Runtime Fragment 1.1.8
>
>
> The api region extension logs a message:
> {code:java}
> No Configuration Admin API available
> {code}
> on info level. That is confusing as it seems to be the default. Maybe that
> log message should be moved somewhere else or the log level should be lower?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10434) ArrayIndexOutOfBoundsException in RegionConfiguration#handleMapConfig
[
https://issues.apache.org/jira/browse/SLING-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-10434.
Resolution: Fixed
> ArrayIndexOutOfBoundsException in RegionConfiguration#handleMapConfig
> -
>
> Key: SLING-10434
> URL: https://issues.apache.org/jira/browse/SLING-10434
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.1.6
>Reporter: Dirk Rudolph
>Priority: Major
> Fix For: Feature Model API Regions Runtime Fragment 1.1.8
>
>
> I get the following ArrayIndexOutOfBoundsException for a similar feature
> model as provided below:
> {code:java}
> 28.05.2021 17:06:09.328 *ERROR* [FelixLogListener]
> org.apache.felix.configadmin Service
> [org.apache.felix.cm.ConfigurationAdmin,39,
> [org.osgi.service.cm.ConfigurationAdmin]] Unexpected problem delivering
> configuration event to [org.osgi.service.cm.SynchronousConfigurationListener,
> id=40, bundle=0/System Bundle] (java.lang.ArrayIndexOutOfBoundsException:
> Index 1 out of bounds for length 1)
> java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
> at
> org.apache.sling.feature.apiregions.impl.RegionConfiguration.handleMapConfig(RegionConfiguration.java:268)
> at
> org.apache.sling.feature.apiregions.impl.RegionConfiguration.updateConfiguration(RegionConfiguration.java:236)
> at
> org.apache.sling.feature.apiregions.impl.RegionConfiguration.setConfig(RegionConfiguration.java:471)
> at
> org.apache.sling.feature.apiregions.impl.Activator$3.invoke(Activator.java:269)
> at com.sun.proxy.$Proxy6.configurationEvent(Unknown Source)
> at
> org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.sendEvent(ConfigurationManager.java:1720)
> at
> org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.run(ConfigurationManager.java:1662)
> at
> org.apache.felix.cm.impl.ConfigurationManager.fireConfigurationEvent(ConfigurationManager.java:658)
> at
> org.apache.felix.cm.impl.ConfigurationManager.updated(ConfigurationManager.java:613)
> at
> org.apache.felix.cm.impl.ConfigurationImpl.update(ConfigurationImpl.java:467)
> at
> org.apache.felix.cm.impl.ConfigurationAdapter.update(ConfigurationAdapter.java:145)
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.execute(ConfigInstallTask.java:78)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:918)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:755)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:304)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
> Example Feature Model
> {code:java}
> {
>
> "id":"com.exmaple:my-cloud-ready-feature-pkg:slingosgifeature:tiera:12345-SNAPSHOT",
> "bundles":[
> {
> "id":"com.example:my-bundle:1.2.3-SNAPSHOT",
> "start-order":"20"
> }
> ],
> "api-regions:JSON|false":[
> {
> "name":"global",
> "exports":[
> "com.example.my"
> ]
> }
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10434) ArrayIndexOutOfBoundsException in RegionConfiguration#handleMapConfig
[
https://issues.apache.org/jira/browse/SLING-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10434:
---
Fix Version/s: Feature Model API Regions Runtime Fragment 1.1.8
> ArrayIndexOutOfBoundsException in RegionConfiguration#handleMapConfig
> -
>
> Key: SLING-10434
> URL: https://issues.apache.org/jira/browse/SLING-10434
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.1.6
>Reporter: Dirk Rudolph
>Priority: Major
> Fix For: Feature Model API Regions Runtime Fragment 1.1.8
>
>
> I get the following ArrayIndexOutOfBoundsException for a similar feature
> model as provided below:
> {code:java}
> 28.05.2021 17:06:09.328 *ERROR* [FelixLogListener]
> org.apache.felix.configadmin Service
> [org.apache.felix.cm.ConfigurationAdmin,39,
> [org.osgi.service.cm.ConfigurationAdmin]] Unexpected problem delivering
> configuration event to [org.osgi.service.cm.SynchronousConfigurationListener,
> id=40, bundle=0/System Bundle] (java.lang.ArrayIndexOutOfBoundsException:
> Index 1 out of bounds for length 1)
> java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
> at
> org.apache.sling.feature.apiregions.impl.RegionConfiguration.handleMapConfig(RegionConfiguration.java:268)
> at
> org.apache.sling.feature.apiregions.impl.RegionConfiguration.updateConfiguration(RegionConfiguration.java:236)
> at
> org.apache.sling.feature.apiregions.impl.RegionConfiguration.setConfig(RegionConfiguration.java:471)
> at
> org.apache.sling.feature.apiregions.impl.Activator$3.invoke(Activator.java:269)
> at com.sun.proxy.$Proxy6.configurationEvent(Unknown Source)
> at
> org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.sendEvent(ConfigurationManager.java:1720)
> at
> org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.run(ConfigurationManager.java:1662)
> at
> org.apache.felix.cm.impl.ConfigurationManager.fireConfigurationEvent(ConfigurationManager.java:658)
> at
> org.apache.felix.cm.impl.ConfigurationManager.updated(ConfigurationManager.java:613)
> at
> org.apache.felix.cm.impl.ConfigurationImpl.update(ConfigurationImpl.java:467)
> at
> org.apache.felix.cm.impl.ConfigurationAdapter.update(ConfigurationAdapter.java:145)
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.execute(ConfigInstallTask.java:78)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:918)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:755)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:304)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
> Example Feature Model
> {code:java}
> {
>
> "id":"com.exmaple:my-cloud-ready-feature-pkg:slingosgifeature:tiera:12345-SNAPSHOT",
> "bundles":[
> {
> "id":"com.example:my-bundle:1.2.3-SNAPSHOT",
> "start-order":"20"
> }
> ],
> "api-regions:JSON|false":[
> {
> "name":"global",
> "exports":[
> "com.example.my"
> ]
> }
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10404) Log: 'No Configuration Admin API available' when it is available
[
https://issues.apache.org/jira/browse/SLING-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-10404.
Resolution: Fixed
> Log: 'No Configuration Admin API available' when it is available
>
>
> Key: SLING-10404
> URL: https://issues.apache.org/jira/browse/SLING-10404
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.1.6
>Reporter: Karl Pauls
> Assignee: A. J. David Bosschaert
>Priority: Minor
> Fix For: Feature Model API Regions Runtime Fragment 1.1.8
>
>
> The api region extension logs a message:
> {code:java}
> No Configuration Admin API available
> {code}
> on info level. That is confusing as it seems to be the default. Maybe that
> log message should be moved somewhere else or the log level should be lower?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10404) Log: 'No Configuration Admin API available' when it is available
[
https://issues.apache.org/jira/browse/SLING-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10404:
---
Summary: Log: 'No Configuration Admin API available' when it is available
(was: No Configuration Admin API available)
> Log: 'No Configuration Admin API available' when it is available
>
>
> Key: SLING-10404
> URL: https://issues.apache.org/jira/browse/SLING-10404
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.1.6
>Reporter: Karl Pauls
> Assignee: A. J. David Bosschaert
>Priority: Minor
> Fix For: Feature Model API Regions Runtime Fragment 1.1.8
>
>
> The api region extension logs a message:
> {code:java}
> No Configuration Admin API available
> {code}
> on info level. That is confusing as it seems to be the default. Maybe that
> log message should be moved somewhere else or the log level should be lower?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10404) No Configuration Admin API available
[
https://issues.apache.org/jira/browse/SLING-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350406#comment-17350406
]
A. J. David Bosschaert commented on SLING-10404:
Due to an error in the code, that log message is written regardless of wether
the API is found or not. Working on a fix.
> No Configuration Admin API available
>
>
> Key: SLING-10404
> URL: https://issues.apache.org/jira/browse/SLING-10404
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.1.6
>Reporter: Karl Pauls
> Assignee: A. J. David Bosschaert
>Priority: Minor
> Fix For: Feature Model API Regions Runtime Fragment 1.1.8
>
>
> The api region extension logs a message:
> {code:java}
> No Configuration Admin API available
> {code}
> on info level. That is confusing as it seems to be the default. Maybe that
> log message should be moved somewhere else or the log level should be lower?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-10404) No Configuration Admin API available
[
https://issues.apache.org/jira/browse/SLING-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert reassigned SLING-10404:
--
Assignee: A. J. David Bosschaert (was: David Bosschaert)
> No Configuration Admin API available
>
>
> Key: SLING-10404
> URL: https://issues.apache.org/jira/browse/SLING-10404
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.1.6
>Reporter: Karl Pauls
> Assignee: A. J. David Bosschaert
>Priority: Minor
> Fix For: Feature Model API Regions Runtime Fragment 1.1.8
>
>
> The api region extension logs a message:
> {code:java}
> No Configuration Admin API available
> {code}
> on info level. That is confusing as it seems to be the default. Maybe that
> log message should be moved somewhere else or the log level should be lower?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10348) Number of errors and warnigs not logged correctly
[ https://issues.apache.org/jira/browse/SLING-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10348. -- > Number of errors and warnigs not logged correctly > - > > Key: SLING-10348 > URL: https://issues.apache.org/jira/browse/SLING-10348 > Project: Sling > Issue Type: Bug > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 1.3.24 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 1.3.26 > > > At the end of the analyser run, the Analyser logs the number of errors and > warnings. > If configuration errors are found, that number is missing those -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10376) Update to latest feature analyser and api extension
[ https://issues.apache.org/jira/browse/SLING-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10376. -- > Update to latest feature analyser and api extension > --- > > Key: SLING-10376 > URL: https://issues.apache.org/jira/browse/SLING-10376 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Carsten Ziegeler > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin-1.5.4 > > > We should update to the latest analyser to get some bug fixes and to the > latest api regions for new functionality -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10374) For API behind a toggle allow to specify the version of the previous package
[ https://issues.apache.org/jira/browse/SLING-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert closed SLING-10374. -- > For API behind a toggle allow to specify the version of the previous package > > > Key: SLING-10374 > URL: https://issues.apache.org/jira/browse/SLING-10374 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model API Regions Extension 1.2.4 > > > For api behind a toggle it is currently only possible to specify an artifact > id for the previous version - which is not consistent and makes processing > more complicated: it requires to fetch that artifact, parse the manifest to > get the previous version of the api package. > We should allow to directly specify the package - and make the artifact > optional -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10376) Update to latest feature analyser and api extension
[ https://issues.apache.org/jira/browse/SLING-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-10376. Resolution: Fixed > Update to latest feature analyser and api extension > --- > > Key: SLING-10376 > URL: https://issues.apache.org/jira/browse/SLING-10376 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Carsten Ziegeler > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin-1.5.4 > > > We should update to the latest analyser to get some bug fixes and to the > latest api regions for new functionality -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10376) Update to latest feature analyser and api extension
[ https://issues.apache.org/jira/browse/SLING-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert reassigned SLING-10376: -- Assignee: A. J. David Bosschaert (was: Carsten Ziegeler) > Update to latest feature analyser and api extension > --- > > Key: SLING-10376 > URL: https://issues.apache.org/jira/browse/SLING-10376 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Carsten Ziegeler > Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin-1.5.4 > > > We should update to the latest analyser to get some bug fixes and to the > latest api regions for new functionality -- This message was sent by Atlassian Jira (v8.3.4#803005)
