[jira] [Updated] (SLING-3323) Extend ResultLog.Entry to (optionally) hold an exception
[ https://issues.apache.org/jira/browse/SLING-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3323: - Attachment: SLING-3323-result-log-entry-with-optional-exception.patch The patch for this is slightly extending the API (2 new constructors, 1 new methods), but not breaking any existing classes. > Extend ResultLog.Entry to (optionally) hold an exception > > > Key: SLING-3323 > URL: https://issues.apache.org/jira/browse/SLING-3323 > Project: Sling > Issue Type: Improvement > Components: Health Check >Reporter: Georg Henzler > Attachments: SLING-3323-result-log-entry-with-optional-exception.patch > > > When things go wrong, a health check implementation should be able to > (optionally) add an exception to a result log entry. That way the exception > with its causes can be shown in a UI (e.g. the web console). The main > benefits are: > * The user in front of JMX or web console will always be technical and > therefore understand stack traces (and appreciate having this additional > information) > * If the exception is not added to the result, implementors can only use the > message of the exception and add it to the result message, thus loosing all > exception root cause information (e.g. root causes are very important when > using a special framework stack like CXF/SOAP) > This is a reduced version of the proposal of in SLING-3302 that will not be > fixed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3323) Extend ResultLog.Entry to (optionally) hold an exception
[ https://issues.apache.org/jira/browse/SLING-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3323: - Description: When things go wrong, a health check implementation should be able to (optionally) add an exception to a result log entry. That way the exception with its causes can be shown in a UI (e.g. the web console). The main benefits are: * The user in front of JMX or web console will always be technical and therefore understand stack traces (and appreciate having this additional information) * If the exception cannot be added to the result, implementors can only use the message of the exception and add it to the result message, thus losing all exception root cause information (e.g. root causes are very important when using a special framework stack like CXF/SOAP) This is a reduced version of the proposal of in SLING-3302 that will not be fixed. was: When things go wrong, a health check implementation should be able to (optionally) add an exception to a result log entry. That way the exception with its causes can be shown in a UI (e.g. the web console). The main benefits are: * The user in front of JMX or web console will always be technical and therefore understand stack traces (and appreciate having this additional information) * If the exception is not added to the result, implementors can only use the message of the exception and add it to the result message, thus loosing all exception root cause information (e.g. root causes are very important when using a special framework stack like CXF/SOAP) This is a reduced version of the proposal of in SLING-3302 that will not be fixed. > Extend ResultLog.Entry to (optionally) hold an exception > > > Key: SLING-3323 > URL: https://issues.apache.org/jira/browse/SLING-3323 > Project: Sling > Issue Type: Improvement > Components: Health Check >Reporter: Georg Henzler > Attachments: SLING-3323-result-log-entry-with-optional-exception.patch > > > When things go wrong, a health check implementation should be able to > (optionally) add an exception to a result log entry. That way the exception > with its causes can be shown in a UI (e.g. the web console). The main > benefits are: > * The user in front of JMX or web console will always be technical and > therefore understand stack traces (and appreciate having this additional > information) > * If the exception cannot be added to the result, implementors can only use > the message of the exception and add it to the result message, thus losing > all exception root cause information (e.g. root causes are very important > when using a special framework stack like CXF/SOAP) > This is a reduced version of the proposal of in SLING-3302 that will not be > fixed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (SLING-3324) Disk Space Health Check
Georg Henzler created SLING-3324: Summary: Disk Space Health Check Key: SLING-3324 URL: https://issues.apache.org/jira/browse/SLING-3324 Project: Sling Issue Type: New Feature Components: Health Check Reporter: Georg Henzler * Not active by default, use factory config to create n checks for multiple drives/partitions (any path pointing to a location on a drive/partition will work) * By default, 95% usage results in WARN, 99% usage in CRITICAL (thresholds are configurable) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3324) Disk Space Health Check
[ https://issues.apache.org/jira/browse/SLING-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3324: - Attachment: DiskSpaceCheck.java Class for package org.apache.sling.hc.core.impl > Disk Space Health Check > --- > > Key: SLING-3324 > URL: https://issues.apache.org/jira/browse/SLING-3324 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: DiskSpaceCheck.java > > > * Not active by default, use factory config to create n checks for multiple > drives/partitions (any path pointing to a location on a drive/partition will > work) > * By default, 95% usage results in WARN, 99% usage in CRITICAL (thresholds > are configurable) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3324) Create Disk Space Health Check
[ https://issues.apache.org/jira/browse/SLING-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3324: - Summary: Create Disk Space Health Check (was: Disk Space Health Check) > Create Disk Space Health Check > -- > > Key: SLING-3324 > URL: https://issues.apache.org/jira/browse/SLING-3324 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: DiskSpaceCheck.java > > > * Not active by default, use factory config to create n checks for multiple > drives/partitions (any path pointing to a location on a drive/partition will > work) > * By default, 95% usage results in WARN, 99% usage in CRITICAL (thresholds > are configurable) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (SLING-3325) Create Memory Health Check
Georg Henzler created SLING-3325: Summary: Create Memory Health Check Key: SLING-3325 URL: https://issues.apache.org/jira/browse/SLING-3325 Project: Sling Issue Type: New Feature Components: Health Check Reporter: Georg Henzler * Monitors available memory, active by default (no factory) * By default, 95% usage results in WARN, 99% usage in CRITICAL (thresholds are configurable) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3325) Create Memory Health Check
[ https://issues.apache.org/jira/browse/SLING-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3325: - Attachment: MemoryCheck.java Class for package org.apache.sling.hc.core.impl > Create Memory Health Check > -- > > Key: SLING-3325 > URL: https://issues.apache.org/jira/browse/SLING-3325 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: MemoryCheck.java > > > * Monitors available memory, active by default (no factory) > * By default, 95% usage results in WARN, 99% usage in CRITICAL (thresholds > are configurable) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (SLING-3326) Create "All bundles started" Health Check
Georg Henzler created SLING-3326: Summary: Create "All bundles started" Health Check Key: SLING-3326 URL: https://issues.apache.org/jira/browse/SLING-3326 Project: Sling Issue Type: New Feature Reporter: Georg Henzler * Checks if all bundles are started, active by default * Allows to exclude certain symbolic ids (e.g. useful if bundles like org.apache.sling.jcr.webdav should be disabled for security reasons) * There is a scripted version in the samples package (/org.apache.sling.hc.samples/src/main/resources/SLING-CONTENT/apps/hc/demo/install/org.apache.sling.hc.core.impl.ScriptableHealthCheck-2.json), but it does not allow to exclude bundles. As this is a very common use case, maybe a "hard-coded" java version would be better? -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3326) Create "All bundles started" Health Check
[ https://issues.apache.org/jira/browse/SLING-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3326: - Component/s: Health Check > Create "All bundles started" Health Check > - > > Key: SLING-3326 > URL: https://issues.apache.org/jira/browse/SLING-3326 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: BundlesStartedCheck.java > > > * Checks if all bundles are started, active by default > * Allows to exclude certain symbolic ids (e.g. useful if bundles like > org.apache.sling.jcr.webdav should be disabled for security reasons) > * There is a scripted version in the samples package > (/org.apache.sling.hc.samples/src/main/resources/SLING-CONTENT/apps/hc/demo/install/org.apache.sling.hc.core.impl.ScriptableHealthCheck-2.json), > but it does not allow to exclude bundles. As this is a very common use case, > maybe a "hard-coded" java version would be better? -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3326) Create "All bundles started" Health Check
[ https://issues.apache.org/jira/browse/SLING-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3326: - Attachment: BundlesStartedCheck.java Class for package org.apache.sling.hc.core.impl > Create "All bundles started" Health Check > - > > Key: SLING-3326 > URL: https://issues.apache.org/jira/browse/SLING-3326 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: BundlesStartedCheck.java > > > * Checks if all bundles are started, active by default > * Allows to exclude certain symbolic ids (e.g. useful if bundles like > org.apache.sling.jcr.webdav should be disabled for security reasons) > * There is a scripted version in the samples package > (/org.apache.sling.hc.samples/src/main/resources/SLING-CONTENT/apps/hc/demo/install/org.apache.sling.hc.core.impl.ScriptableHealthCheck-2.json), > but it does not allow to exclude bundles. As this is a very common use case, > maybe a "hard-coded" java version would be better? -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3324) Create Disk Space Health Check
[ https://issues.apache.org/jira/browse/SLING-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3324: - Attachment: DiskSpaceCheck.java > Create Disk Space Health Check > -- > > Key: SLING-3324 > URL: https://issues.apache.org/jira/browse/SLING-3324 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: DiskSpaceCheck.java > > > * Not active by default, use factory config to create n checks for multiple > drives/partitions (any path pointing to a location on a drive/partition will > work) > * By default, 95% usage results in WARN, 99% usage in CRITICAL (thresholds > are configurable) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3326) Create "All bundles started" Health Check
[ https://issues.apache.org/jira/browse/SLING-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3326: - Attachment: (was: BundlesStartedCheck.java) > Create "All bundles started" Health Check > - > > Key: SLING-3326 > URL: https://issues.apache.org/jira/browse/SLING-3326 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > > * Checks if all bundles are started, active by default > * Allows to exclude certain symbolic ids (e.g. useful if bundles like > org.apache.sling.jcr.webdav should be disabled for security reasons) > * There is a scripted version in the samples package > (/org.apache.sling.hc.samples/src/main/resources/SLING-CONTENT/apps/hc/demo/install/org.apache.sling.hc.core.impl.ScriptableHealthCheck-2.json), > but it does not allow to exclude bundles. As this is a very common use case, > maybe a "hard-coded" java version would be better? -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3325) Create Memory Health Check
[ https://issues.apache.org/jira/browse/SLING-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3325: - Attachment: (was: MemoryCheck.java) > Create Memory Health Check > -- > > Key: SLING-3325 > URL: https://issues.apache.org/jira/browse/SLING-3325 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: MemoryCheck.java > > > * Monitors available memory, active by default (no factory) > * By default, 95% usage results in WARN, 99% usage in CRITICAL (thresholds > are configurable) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3325) Create Memory Health Check
[ https://issues.apache.org/jira/browse/SLING-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3325: - Attachment: MemoryCheck.java > Create Memory Health Check > -- > > Key: SLING-3325 > URL: https://issues.apache.org/jira/browse/SLING-3325 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: MemoryCheck.java > > > * Monitors available memory, active by default (no factory) > * By default, 95% usage results in WARN, 99% usage in CRITICAL (thresholds > are configurable) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3324) Create Disk Space Health Check
[ https://issues.apache.org/jira/browse/SLING-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3324: - Attachment: (was: DiskSpaceCheck.java) > Create Disk Space Health Check > -- > > Key: SLING-3324 > URL: https://issues.apache.org/jira/browse/SLING-3324 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: DiskSpaceCheck.java > > > * Not active by default, use factory config to create n checks for multiple > drives/partitions (any path pointing to a location on a drive/partition will > work) > * By default, 95% usage results in WARN, 99% usage in CRITICAL (thresholds > are configurable) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3326) Create "All bundles started" Health Check
[ https://issues.apache.org/jira/browse/SLING-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-3326: - Attachment: BundlesStartedCheck.java > Create "All bundles started" Health Check > - > > Key: SLING-3326 > URL: https://issues.apache.org/jira/browse/SLING-3326 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: BundlesStartedCheck.java > > > * Checks if all bundles are started, active by default > * Allows to exclude certain symbolic ids (e.g. useful if bundles like > org.apache.sling.jcr.webdav should be disabled for security reasons) > * There is a scripted version in the samples package > (/org.apache.sling.hc.samples/src/main/resources/SLING-CONTENT/apps/hc/demo/install/org.apache.sling.hc.core.impl.ScriptableHealthCheck-2.json), > but it does not allow to exclude bundles. As this is a very common use case, > maybe a "hard-coded" java version would be better? -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3326) Create "All bundles started" Health Check
[ https://issues.apache.org/jira/browse/SLING-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876431#comment-13876431 ] Georg Henzler commented on SLING-3326: -- - ignoredBundles is probably a better name, +1 for that - if the strategy is that no HCs are activated without configuration, then I agree policy=ConfigurationPolicy.REQUIRE without a config factory is the way to go (a factory does not make sense here I believe) > Create "All bundles started" Health Check > - > > Key: SLING-3326 > URL: https://issues.apache.org/jira/browse/SLING-3326 > Project: Sling > Issue Type: New Feature > Components: Health Check >Reporter: Georg Henzler > Attachments: BundlesStartedCheck.java > > > * Checks if all bundles are started, active by default > * Allows to exclude certain symbolic ids (e.g. useful if bundles like > org.apache.sling.jcr.webdav should be disabled for security reasons) > * There is a scripted version in the samples package > (/org.apache.sling.hc.samples/src/main/resources/SLING-CONTENT/apps/hc/demo/install/org.apache.sling.hc.core.impl.ScriptableHealthCheck-2.json), > but it does not allow to exclude bundles. As this is a very common use case, > maybe a "hard-coded" java version would be better? -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3324) Create Disk Space Health Check
[
https://issues.apache.org/jira/browse/SLING-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876439#comment-13876439
]
Georg Henzler commented on SLING-3324:
--
Configuring the current directory (".") works cross-plattform to be able to
provide a sample config.
> Create Disk Space Health Check
> --
>
> Key: SLING-3324
> URL: https://issues.apache.org/jira/browse/SLING-3324
> Project: Sling
> Issue Type: New Feature
> Components: Health Check
>Reporter: Georg Henzler
> Attachments: DiskSpaceCheck.java
>
>
> * Not active by default, use factory config to create n checks for multiple
> drives/partitions (any path pointing to a location on a drive/partition will
> work)
> * By default, 95% usage results in WARN, 99% usage in CRITICAL (thresholds
> are configurable)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
[
https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560889#comment-17560889
]
Georg Henzler commented on SLING-11141:
---
Let's move forward, we can deprecate this ScriptedHealthCheck in the next
release and for this release, it will work side by side with the Felix 3.x one.
> Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
> ---
>
> Key: SLING-11141
> URL: https://issues.apache.org/jira/browse/SLING-11141
> Project: Sling
> Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Health Check Support 1.0.8
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> After updating to the org.apache.felix.healthcheck.generalchecks version
> 3.0.0 release, the org.apache.sling.hc.support bundle fails during the
> feature analyzer with this error:
> {noformat}
> [ERROR] [bundle-packages] org.apache.sling:org.apache.sling.hc.support:1.0.6:
> is importing package(s) org.apache.felix.hc.generalchecks.util in start
> level 20 but no bundle is exporting these for that start level.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-10871) Add builder API for request/resource objects
[
https://issues.apache.org/jira/browse/SLING-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434828#comment-17434828
]
Georg Henzler commented on SLING-10871:
---
[~cziegeler] Just came across
[RequestPathInfoImpl|https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/request/builder/impl/RequestPathInfoImpl.java]
that is already merged (but not released), shouldn't we use
[SlingUri|https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/uri/SlingUri.java]
that implements RequestPathInfo as well instead to avoid duplicate code?
[SlingHttpServletRequestBuilder|https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java]
would not have to change (it's simplifying the impl only, it could provide the
method {{withSlingUri}} but maybe it's not clear then what happens in case a
URI with a host is used)
> Add builder API for request/resource objects
>
>
> Key: SLING-10871
> URL: https://issues.apache.org/jira/browse/SLING-10871
> Project: Sling
> Issue Type: New Feature
> Components: API
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: API 2.24.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> As discussed in SLING-10840 and in [1] we should a builder api for Sling http
> servlet request/response objects which do not have a real request/response
> as a backing
> [1]
> https://lists.apache.org/thread.html/r7c66bcfb66b30f801f6e3a17d42b437cfeca7f233d240d965f471dfd%40%3Cdev.sling.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9662) Introduce an URI Mapping SPI
[ https://issues.apache.org/jira/browse/SLING-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434834#comment-17434834 ] Georg Henzler commented on SLING-9662: -- [~cziegeler] yes this part is still missing (while the first part SLING-9745 is done) - IMHO we should implement it but since we we said we move it before authentication, the change become quite big... maybe we should change strategy and start KISS and leave it "after authentication" that way the change would by far not be as impactful. > Introduce an URI Mapping SPI > > > Key: SLING-9662 > URL: https://issues.apache.org/jira/browse/SLING-9662 > Project: Sling > Issue Type: New Feature > Components: API >Reporter: Georg Henzler >Assignee: Georg Henzler >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > _an earlier version used the terms ResourceUri/ResourceToUriMapper (updated > this description during the discussion)_ > Introduce a simple SPI that allows to contribute to the resource resolver's > map() and resolve() methods: > Prerequisite *SlingUri:* (SLING-9745 to be completed first) > General purpose class to represent a ResourceUri (like e.g. a link in an html > tag). Immutable itself but adjustable using the builder pattern. Part of > the Sling API and can be used anywhere to simplify handling/modification of > Sling ResourceUri. Implements RequestPathInfo. ResourceUri can be created > easily from a String, a Request, a Resource, a URI or a RequestPathInfo. > *SlingUriMapper:* > SPI interface to be implemented as OSGi Service. All registered services > build a conceptual chain sorted by service ranking. The resource link is > passed through the chain while any SlingUriMapper chain member may or may not > make adjustments to the resource link. > rr.resolve() passes through the chain starting at the SlingUriMapper with > the highest service ranking and rr.map() passes through the > chain starting at the SlingUriMapper with the lowest service > ranking > *PathToUriMappingService:* > The new OSGi service to provide path to URI resolution and path to URI > mapping. The methods rr.resolve() and rr.map() and should delegate to this > service. > > _Mailing List References:_ > [https://www.mail-archive.com/dev@sling.apache.org/msg93537.html] > [https://www.mail-archive.com/dev@sling.apache.org/msg87736.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
