[jira] [Commented] (SLING-9558) slingpackager - the --install command does not work with upload command on Composum
[ https://issues.apache.org/jira/browse/SLING-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148065#comment-17148065 ] Henry Saginor commented on SLING-9558: -- This is fixed here - https://github.com/apache/sling-slingpackager/pull/1 > slingpackager - the --install command does not work with upload command on > Composum > --- > > Key: SLING-9558 > URL: https://issues.apache.org/jira/browse/SLING-9558 > Project: Sling > Issue Type: Bug >Reporter: Henry Saginor >Priority: Major > > The slingpackage tool upload command has --install option to automatically > install the package after it's uploaded. It only works with AEM Package > manager. It breaks with basic Sling + Composum due to a missing method > implementation. > This results in the following error - > lingpackager upload --install headwire-full-package-1.0-SNAPSHOT.zip > Uploading package > /home/rr/ws/peregrinesamples/samplesites/headwire-full-package-1.0-SNAPSHOT.zip > on http://localhost:8080 > successful > /home/rr/ws/peregrinesamples/sling-slingpackager/utils/composumpackager.js:64 > installPackage(url, username, password, json.path, maxRetry); > ^ > ReferenceError: installPackage is not defined > at callPostService > (/home/rr/ws/peregrinesamples/sling-slingpackager/utils/composumpackager.js:64:17) > at Request.request [as _callback] > (/home/rr/ws/peregrinesamples/sling-slingpackager/utils/composumpackager.js:295:21) > at Request.self.callback > (/home/rr/ws/peregrinesamples/sling-slingpackager/node_modules/request/request.js:185:22) > at Request.emit (events.js:198:13) > at Request. > (/home/rr/ws/peregrinesamples/sling-slingpackager/node_modules/request/request.js:1161:10) > at Request.emit (events.js:198:13) > at IncomingMessage. > (/home/rr/ws/peregrinesamples/sling-slingpackager/node_modules/request/request.js:1083:12) > at Object.onceWrapper (events.js:286:20) > at IncomingMessage.emit (events.js:203:15) > at endReadableNT (_stream_readable.js:1145:12) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9558) slingpackager - the --install command does not work with upload command on Composum
Henry Saginor created SLING-9558: Summary: slingpackager - the --install command does not work with upload command on Composum Key: SLING-9558 URL: https://issues.apache.org/jira/browse/SLING-9558 Project: Sling Issue Type: Bug Reporter: Henry Saginor The slingpackage tool upload command has --install option to automatically install the package after it's uploaded. It only works with AEM Package manager. It breaks with basic Sling + Composum due to a missing method implementation. This results in the following error - lingpackager upload --install headwire-full-package-1.0-SNAPSHOT.zip Uploading package /home/rr/ws/peregrinesamples/samplesites/headwire-full-package-1.0-SNAPSHOT.zip on http://localhost:8080 successful /home/rr/ws/peregrinesamples/sling-slingpackager/utils/composumpackager.js:64 installPackage(url, username, password, json.path, maxRetry); ^ ReferenceError: installPackage is not defined at callPostService (/home/rr/ws/peregrinesamples/sling-slingpackager/utils/composumpackager.js:64:17) at Request.request [as _callback] (/home/rr/ws/peregrinesamples/sling-slingpackager/utils/composumpackager.js:295:21) at Request.self.callback (/home/rr/ws/peregrinesamples/sling-slingpackager/node_modules/request/request.js:185:22) at Request.emit (events.js:198:13) at Request. (/home/rr/ws/peregrinesamples/sling-slingpackager/node_modules/request/request.js:1161:10) at Request.emit (events.js:198:13) at IncomingMessage. (/home/rr/ws/peregrinesamples/sling-slingpackager/node_modules/request/request.js:1083:12) at Object.onceWrapper (events.js:286:20) at IncomingMessage.emit (events.js:203:15) at endReadableNT (_stream_readable.js:1145:12) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (SLING-8584) Donation proposal of nodejs slingpackager
[
https://issues.apache.org/jira/browse/SLING-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888562#comment-16888562
]
Henry Saginor edited comment on SLING-8584 at 7/19/19 6:18 AM:
---
[~rombert]
Here is some additional info to test this quickliy
1) After you download the file and extract it cd into extracted folder and run
{code:java}
npm install
{code}
to install node dependencies.
2) Then
{code:java}
npm test
{code}
to run some basic test cases.
The tests at the moment assume Sling running at localhost:8080. You can also
run these tests against AEM if you uncomment relevant lines in
test/serverInfo.js.
>From our e-mail thread here is also the sample project that can be packaged
>with this
[https://github.com/peregrine-cms/simple-sling-vue-example]
was (Author: hsagi...@gmail.com):
[~rombert]
Here is some additional info to test this quickliy
1) After you download the file and extract it cd into extracted folder and run
{code:java}
npm install
{code}
to install node dependencies.
2) Then
{code:java}
npm test
{code}
to run some basic test cases.
The tests at the moment assume Sling running at localhost:8080. You also run
tests against AEM if you uncomment relevant lines in test/serverInfo.js.
>From our e-mail thread here is also the sample project that can be packaged
>with this
https://github.com/peregrine-cms/simple-sling-vue-example
> Donation proposal of nodejs slingpackager
> -
>
> Key: SLING-8584
> URL: https://issues.apache.org/jira/browse/SLING-8584
> Project: Sling
> Issue Type: New Feature
>Reporter: Henry Saginor
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: slingpackager.tar.gz
>
>
> h1. Modules
> This donation proposal covers one module.
> ||Module||Source||Description||
> |slingpackager|on
> [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib]
> or [^slingpackager.tar.gz]
> (shasum ee91c707070f81d9516c8fedbab0aec30605c225)|A nodejs based command line
> tool alternative to the maven plugin.
> This tool covers the following use cases.
> * build a content package form a local folder
> * upload a content package onto a server
> * install a content package on a server
> * list all installed packages on the server
> * uninstall a content package from the server
> * delete a content package on the server|
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (SLING-8584) Donation proposal of nodejs slingpackager
[
https://issues.apache.org/jira/browse/SLING-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888562#comment-16888562
]
Henry Saginor commented on SLING-8584:
--
[~rombert]
Here is some additional info to test this quickliy
1) After you download the file and extract it cd into extracted folder and run
{code:java}
npm install
{code}
to install node dependencies.
2) Then
{code:java}
npm test
{code}
to run some basic test cases.
The tests at the moment assume Sling running at localhost:8080. You also run
tests against AEM if you uncomment relevant lines in test/serverInfo.js.
>From our e-mail thread here is also the sample project that can be packaged
>with this
https://github.com/peregrine-cms/simple-sling-vue-example
> Donation proposal of nodejs slingpackager
> -
>
> Key: SLING-8584
> URL: https://issues.apache.org/jira/browse/SLING-8584
> Project: Sling
> Issue Type: New Feature
>Reporter: Henry Saginor
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: slingpackager.tar.gz
>
>
> h1. Modules
> This donation proposal covers one module.
> ||Module||Source||Description||
> |slingpackager|on
> [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib]
> or [^slingpackager.tar.gz]
> (shasum ee91c707070f81d9516c8fedbab0aec30605c225)|A nodejs based command line
> tool alternative to the maven plugin.
> This tool covers the following use cases.
> * build a content package form a local folder
> * upload a content package onto a server
> * install a content package on a server
> * list all installed packages on the server
> * uninstall a content package from the server
> * delete a content package on the server|
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (SLING-8584) Donation proposal of nodejs slingpackager
[ https://issues.apache.org/jira/browse/SLING-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888551#comment-16888551 ] Henry Saginor commented on SLING-8584: -- [~rombert] I updated the attachment with some changes and added shasum. Let me know if you need anything else. > Donation proposal of nodejs slingpackager > - > > Key: SLING-8584 > URL: https://issues.apache.org/jira/browse/SLING-8584 > Project: Sling > Issue Type: New Feature >Reporter: Henry Saginor >Assignee: Robert Munteanu >Priority: Minor > Attachments: slingpackager.tar.gz > > > h1. Modules > This donation proposal covers one module. > ||Module||Source||Description|| > |slingpackager|on > [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib] > or [^slingpackager.tar.gz] > (shasum ee91c707070f81d9516c8fedbab0aec30605c225)|A nodejs based command line > tool alternative to the maven plugin. > This tool covers the following use cases. > * build a content package form a local folder > * upload a content package onto a server > * install a content package on a server > * list all installed packages on the server > * uninstall a content package from the server > * delete a content package on the server| -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (SLING-8584) Donation proposal of nodejs slingpackager
[ https://issues.apache.org/jira/browse/SLING-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Saginor updated SLING-8584: - Description: h1. Modules This donation proposal covers one module. ||Module||Source||Description|| |slingpackager|on [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib] or [^slingpackager.tar.gz] (shasum ee91c707070f81d9516c8fedbab0aec30605c225)|A nodejs based command line tool alternative to the maven plugin. This tool covers the following use cases. * build a content package form a local folder * upload a content package onto a server * install a content package on a server * list all installed packages on the server * uninstall a content package from the server * delete a content package on the server| was: h1. Modules This donation proposal covers one module. ||Module||Source||Description|| |slingpackager|on [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib] or [^slingpackager.tar.gz]|A nodejs based command line tool alternative to the maven plugin. This tool covers the following use cases. * build a content package form a local folder * upload a content package onto a server * install a content package on a server * list all installed packages on the server * uninstall a content package from the server * delete a content package on the server| > Donation proposal of nodejs slingpackager > - > > Key: SLING-8584 > URL: https://issues.apache.org/jira/browse/SLING-8584 > Project: Sling > Issue Type: New Feature >Reporter: Henry Saginor >Assignee: Robert Munteanu >Priority: Minor > Attachments: slingpackager.tar.gz > > > h1. Modules > This donation proposal covers one module. > ||Module||Source||Description|| > |slingpackager|on > [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib] > or [^slingpackager.tar.gz] > (shasum ee91c707070f81d9516c8fedbab0aec30605c225)|A nodejs based command line > tool alternative to the maven plugin. > This tool covers the following use cases. > * build a content package form a local folder > * upload a content package onto a server > * install a content package on a server > * list all installed packages on the server > * uninstall a content package from the server > * delete a content package on the server| -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (SLING-8584) Donation proposal of nodejs slingpackager
[ https://issues.apache.org/jira/browse/SLING-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Saginor updated SLING-8584: - Attachment: slingpackager.tar.gz > Donation proposal of nodejs slingpackager > - > > Key: SLING-8584 > URL: https://issues.apache.org/jira/browse/SLING-8584 > Project: Sling > Issue Type: New Feature >Reporter: Henry Saginor >Assignee: Robert Munteanu >Priority: Minor > Attachments: slingpackager.tar.gz > > > h1. Modules > This donation proposal covers one module. > ||Module||Source||Description|| > |slingpackager|on > [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib] > or [^slingpackager.tar.gz]|A nodejs based command line tool alternative to > the maven plugin. > This tool covers the following use cases. > * build a content package form a local folder > * upload a content package onto a server > * install a content package on a server > * list all installed packages on the server > * uninstall a content package from the server > * delete a content package on the server| -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (SLING-8584) Donation proposal of nodejs slingpackager
[ https://issues.apache.org/jira/browse/SLING-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Saginor updated SLING-8584: - Attachment: (was: slingpackager.tar.gz) > Donation proposal of nodejs slingpackager > - > > Key: SLING-8584 > URL: https://issues.apache.org/jira/browse/SLING-8584 > Project: Sling > Issue Type: New Feature >Reporter: Henry Saginor >Assignee: Robert Munteanu >Priority: Minor > Attachments: slingpackager.tar.gz > > > h1. Modules > This donation proposal covers one module. > ||Module||Source||Description|| > |slingpackager|on > [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib] > or [^slingpackager.tar.gz]|A nodejs based command line tool alternative to > the maven plugin. > This tool covers the following use cases. > * build a content package form a local folder > * upload a content package onto a server > * install a content package on a server > * list all installed packages on the server > * uninstall a content package from the server > * delete a content package on the server| -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (SLING-8585) The acl page in Sling displays Apache License header
[ https://issues.apache.org/jira/browse/SLING-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Saginor updated SLING-8585: - Description: Start Sling and go to [http://localhost:8080/content.acl.html] Note Apache License comment rendered at the top of the page. PR with a fix: [https://github.com/apache/sling-org-apache-sling-starter-content/pull/2] was: Start Sling and go to [http://localhost:8080/content.acl.html] Note Apache License comment rendered at the top of the page. PR to fix this https://github.com/apache/sling-org-apache-sling-starter-content/pull/2 > The acl page in Sling displays Apache License header > > > Key: SLING-8585 > URL: https://issues.apache.org/jira/browse/SLING-8585 > Project: Sling > Issue Type: Bug >Reporter: Henry Saginor >Priority: Minor > > Start Sling and go to [http://localhost:8080/content.acl.html] > Note Apache License comment rendered at the top of the page. > PR with a fix: > [https://github.com/apache/sling-org-apache-sling-starter-content/pull/2] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (SLING-8585) The acl page in Sling displays Apache License header
[ https://issues.apache.org/jira/browse/SLING-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Saginor updated SLING-8585: - Description: Start Sling and go to [http://localhost:8080/content.acl.html] Note Apache License comment rendered at the top of the page. PR to fix this https://github.com/apache/sling-org-apache-sling-starter-content/pull/2 was: Start Sling and go to [http://localhost:8080/content.acl.html] Note Apache License comment rendered at the top of the page. > The acl page in Sling displays Apache License header > > > Key: SLING-8585 > URL: https://issues.apache.org/jira/browse/SLING-8585 > Project: Sling > Issue Type: Bug >Reporter: Henry Saginor >Priority: Minor > > Start Sling and go to [http://localhost:8080/content.acl.html] > Note Apache License comment rendered at the top of the page. > PR to fix this > https://github.com/apache/sling-org-apache-sling-starter-content/pull/2 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (SLING-8585) The acl page in Sling displays Apache License header
Henry Saginor created SLING-8585: Summary: The acl page in Sling displays Apache License header Key: SLING-8585 URL: https://issues.apache.org/jira/browse/SLING-8585 Project: Sling Issue Type: Bug Reporter: Henry Saginor Start Sling and go to [http://localhost:8080/content.acl.html] Note Apache License comment rendered at the top of the page. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (SLING-8584) Donation proposal of nodejs slingpackager
[ https://issues.apache.org/jira/browse/SLING-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Saginor updated SLING-8584: - Description: h1. Modules This donation proposal covers one module. ||Module||Source||Description|| |slingpackager|on [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib] or [^slingpackager.tar.gz]|A nodejs based command line tool alternative to the maven plugin. This tool covers the following use cases. * build a content package form a local folder * upload a content package onto a server * install a content package on a server * list all installed packages on the server * uninstall a content package from the server * delete a content package on the server| was: h1. Modules This donation proposal covers one module. ||Module||Source||Description|| |slingpackager|on [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib] or [^slingpackager.tar.gz]|This is a nodejs based command line tool alternative to the maven plugin.| > Donation proposal of nodejs slingpackager > - > > Key: SLING-8584 > URL: https://issues.apache.org/jira/browse/SLING-8584 > Project: Sling > Issue Type: New Feature >Reporter: Henry Saginor >Priority: Minor > Attachments: slingpackager.tar.gz > > > h1. Modules > This donation proposal covers one module. > ||Module||Source||Description|| > |slingpackager|on > [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib] > or [^slingpackager.tar.gz]|A nodejs based command line tool alternative to > the maven plugin. > This tool covers the following use cases. > * build a content package form a local folder > * upload a content package onto a server > * install a content package on a server > * list all installed packages on the server > * uninstall a content package from the server > * delete a content package on the server| -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (SLING-8584) Donation proposal of nodejs slingpackager
Henry Saginor created SLING-8584: Summary: Donation proposal of nodejs slingpackager Key: SLING-8584 URL: https://issues.apache.org/jira/browse/SLING-8584 Project: Sling Issue Type: New Feature Reporter: Henry Saginor Attachments: slingpackager.tar.gz h1. Modules This donation proposal covers one module. ||Module||Source||Description|| |slingpackager|on [GitHub|https://github.com/peregrine-cms/slingpackager/tree/apacheContrib] or [^slingpackager.tar.gz]|This is a nodejs based command line tool alternative to the maven plugin.| -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-8430) Use java.util.zip.ZipFile in Feature Model Analyser
[ https://issues.apache.org/jira/browse/SLING-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858841#comment-16858841 ] Henry Saginor commented on SLING-8430: -- [~karlpauls] I made the changes you suggested in the PR. Thank you for reviewing this. > Use java.util.zip.ZipFile in Feature Model Analyser > --- > > Key: SLING-8430 > URL: https://issues.apache.org/jira/browse/SLING-8430 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Henry Saginor >Assignee: Karl Pauls >Priority: Minor > > The ContentPackageScanner and FelixFrameworkScanner could use > java.util.zip.ZipFile API. In my estimation this should improve performance > over the current use of ZipInputStream. > Here is a pull request with suggested changes including a unit test for > ContentPackageScanner: > https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/14 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8430) Use java.util.zip.ZipFile in Feature Model Analyser
Henry Saginor created SLING-8430: Summary: Use java.util.zip.ZipFile in Feature Model Analyser Key: SLING-8430 URL: https://issues.apache.org/jira/browse/SLING-8430 Project: Sling Issue Type: Improvement Components: Feature Model Reporter: Henry Saginor The ContentPackageScanner and FelixFrameworkScanner could use java.util.zip.ZipFile API. In my estimation this should improve performance over the current use of ZipInputStream. Here is a pull request with suggested changes including a unit test for ContentPackageScanner: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/14 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-3148) Implement support for Feature Flags/Toggles in Sling
[ https://issues.apache.org/jira/browse/SLING-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820219#comment-13820219 ] Henry Saginor commented on SLING-3148: -- Thanks for looking into this. I agree with Bernard that this should be something more than turning OSGi services on and off. I would just add that the provider interface should have a method (or methods) for toggling a flag and there needs to be some admin UI managed by Sling to toggle them. Also it would be nice to have a hook in resource rendering (sling:include and sling servlets) to check flags once support for them is implemented. Flags should work in a clustered scenario btw. > Implement support for Feature Flags/Toggles in Sling > > > Key: SLING-3148 > URL: https://issues.apache.org/jira/browse/SLING-3148 > Project: Sling > Issue Type: New Feature > Components: General >Reporter: Henry Saginor >Priority: Minor > > It would be nice if sling provide support for feature flags (also called > toggles) pattern [1]. > I am thinking the implementation could provide the following. > 1) Integrate an existing framework such as togglz [2] or implement something > similar with UI/Configuration to toggle features. > 2) Create a jcr property (sling:Feature) which can be added to resource type > nodes. Then some conditional logic in , and get and post > servlets determines if the resource should be rendered if its resource type > contains such property. > [1] http://en.wikipedia.org/wiki/Feature_toggle > [2] http://www.togglz.org/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (SLING-3148) Implement support for Feature Flags/Toggles in Sling
Henry Saginor created SLING-3148: Summary: Implement support for Feature Flags/Toggles in Sling Key: SLING-3148 URL: https://issues.apache.org/jira/browse/SLING-3148 Project: Sling Issue Type: New Feature Components: General Reporter: Henry Saginor Priority: Minor It would be nice if sling provide support for feature flags (also called toggles) pattern [1]. I am thinking the implementation could provide the following. 1) Integrate an existing framework such as togglz [2] or implement something similar with UI/Configuration to toggle features. 2) Create a jcr property (sling:Feature) which can be added to resource type nodes. Then some conditional logic in , and get and post servlets determines if the resource should be rendered if its resource type contains such property. [1] http://en.wikipedia.org/wiki/Feature_toggle [2] http://www.togglz.org/ -- This message was sent by Atlassian JIRA (v6.1#6144)
