[jira] [Assigned] (SLING-12348) update to parent 60
[ https://issues.apache.org/jira/browse/SLING-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12348: - Assignee: Joerg Hoh > update to parent 60 > --- > > Key: SLING-12348 > URL: https://issues.apache.org/jira/browse/SLING-12348 > Project: Sling > Issue Type: Task > Components: Repoinit >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Repoinit JCR 1.1.52 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12348) update to parent 60
Joerg Hoh created SLING-12348: - Summary: update to parent 60 Key: SLING-12348 URL: https://issues.apache.org/jira/browse/SLING-12348 Project: Sling Issue Type: Task Components: Repoinit Reporter: Joerg Hoh Fix For: Repoinit JCR 1.1.52 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12347) Apply spotless formatting
Joerg Hoh created SLING-12347: - Summary: Apply spotless formatting Key: SLING-12347 URL: https://issues.apache.org/jira/browse/SLING-12347 Project: Sling Issue Type: Task Components: Repoinit Reporter: Joerg Hoh Assignee: Joerg Hoh Fix For: Repoinit JCR 1.1.52 as preparation for the update to parent 60 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12262) Repoinit: report failures via metrics
[ https://issues.apache.org/jira/browse/SLING-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12262: -- Fix Version/s: Repoinit JCR 1.1.52 > Repoinit: report failures via metrics > - > > Key: SLING-12262 > URL: https://issues.apache.org/jira/browse/SLING-12262 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Repoinit JCR 1.1.52 > > > When a repoinit statement fails (and for that reason the SlingRepository > service cannot be started, repoinit should expose this as a metric. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12264) check save() operations
[ https://issues.apache.org/jira/browse/SLING-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12264: -- Fix Version/s: Repoinit JCR 1.1.52 > check save() operations > --- > > Key: SLING-12264 > URL: https://issues.apache.org/jira/browse/SLING-12264 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Priority: Major > Fix For: Repoinit JCR 1.1.52 > > > Before doing a session.save() operation, it should always be checked if there > is something to save at all. > This can speed up the execution of individual repoinit statements if the > repoinit statement does not need to be applied. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12264) check save() operations
[ https://issues.apache.org/jira/browse/SLING-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852396#comment-17852396 ] Joerg Hoh commented on SLING-12264: --- I created OAK-10862 for it, but for the time being I add this improvement. > check save() operations > --- > > Key: SLING-12264 > URL: https://issues.apache.org/jira/browse/SLING-12264 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Priority: Major > > Before doing a session.save() operation, it should always be checked if there > is something to save at all. > This can speed up the execution of individual repoinit statements if the > repoinit statement does not need to be applied. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12321) Update parent pom to latest
[ https://issues.apache.org/jira/browse/SLING-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12321. - > Update parent pom to latest > --- > > Key: SLING-12321 > URL: https://issues.apache.org/jira/browse/SLING-12321 > Project: Sling > Issue Type: Task > Components: Engine >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > > Updating to parent 60 an force the result to be runable with Java 8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12330) Fix formatting
[ https://issues.apache.org/jira/browse/SLING-12330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12330. - > Fix formatting > -- > > Key: SLING-12330 > URL: https://issues.apache.org/jira/browse/SLING-12330 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12326) SocketExceptions are no longer handled as error
[ https://issues.apache.org/jira/browse/SLING-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12326. - > SocketExceptions are no longer handled as error > --- > > Key: SLING-12326 > URL: https://issues.apache.org/jira/browse/SLING-12326 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.8, Engine 2.15.10, Engine 2.15.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > > [This > commit|https://github.com/apache/sling-org-apache-sling-engine/commit/8ab96759cd435520a228271fbbb9d37955954c80] > introduced a special handling for SocketExceptions under the assumptions > that the only Socket Exceptions can happen when Sling/Jetty fails to stream > back the response to the client (browser). > But there are other types of SocketExceptions, which can happen during page > rendering, e.g. when a Servlet/Script does connections on its own, for > example to fetch data from a backend system. If these exceptions are wrapped > and thrown, it could lead to a situation, that the error handling in this > place is actually not kicking in at all, and also no logging for this > exception is done at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12317) Make Sling Engine build with Java 21
[
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-12317.
-
> Make Sling Engine build with Java 21
>
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> {noformat}[ERROR]
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
> Time elapsed: 0 s <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
> at
> java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
> at org.jmock.Mockery.mock(Mockery.java:167)
> at org.jmock.Mockery.mock(Mockery.java:143)
> at
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12316) Servlet Name might be set incorrectly after an exception
[
https://issues.apache.org/jira/browse/SLING-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-12316.
-
> Servlet Name might be set incorrectly after an exception
>
>
> Key: SLING-12316
> URL: https://issues.apache.org/jira/browse/SLING-12316
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> In case an exception happens, the name is not reset properly:
> [https://github.com/apache/sling-org-apache-sling-engine/blob/ad11b3b108764312e6db87aea7de18c3fa00db34/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L553]
> {{requestData.setActiveServletName(callerServlet);}} must be moved into the
> finally block
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12344) Lock contention in ScriptDependencyResolver
Joerg Hoh created SLING-12344:
-
Summary: Lock contention in ScriptDependencyResolver
Key: SLING-12344
URL: https://issues.apache.org/jira/browse/SLING-12344
Project: Sling
Issue Type: Task
Components: HTL
Affects Versions: Scripting HTL Engine 1.4.22-1.4.0
Reporter: Joerg Hoh
I see threaddumps which show lock contention in the ScriptDependencyResolver
like this:
{noformat}
at jdk.internal.misc.Unsafe.park(java.base@11.0.20/Native Method)
- parking to wait for <0x000496e16af0> (a
java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync)
at
java.util.concurrent.locks.LockSupport.park(java.base@11.0.20/LockSupport.java:194)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(java.base@11.0.20/AbstractQueuedSynchronizer.java:885)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(java.base@11.0.20/AbstractQueuedSynchronizer.java:917)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(java.base@11.0.20/AbstractQueuedSynchronizer.java:1240)
at
java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.lock(java.base@11.0.20/ReentrantReadWriteLock.java:959)
at
org.apache.sling.scripting.sightly.impl.utils.ScriptDependencyResolver.resolveScript(ScriptDependencyResolver.java:100)
at
org.apache.sling.scripting.sightly.impl.engine.extension.use.RenderUnitProvider.provide(RenderUnitProvider.java:95)
at
org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.call(UseRuntimeExtension.java:71)
at
org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:72)
at apps.components.x.y.y__002e__html.render(y__002e__html.java:39)
{noformat}
but also:
{noformat}
at jdk.internal.misc.Unsafe.park(java.base@11.0.20/Native Method)
- parking to wait for <0x000496e16af0> (a
java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync)
at
java.util.concurrent.locks.LockSupport.park(java.base@11.0.20/LockSupport.java:194)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(java.base@11.0.20/AbstractQueuedSynchronizer.java:885)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireShared(java.base@11.0.20/AbstractQueuedSynchronizer.java:1009)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireShared(java.base@11.0.20/AbstractQueuedSynchronizer.java:1324)
at
java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.lock(java.base@11.0.20/ReentrantReadWriteLock.java:738)
at
org.apache.sling.scripting.sightly.impl.utils.ScriptDependencyResolver.resolveScript(ScriptDependencyResolver.java:93)
at
org.apache.sling.scripting.sightly.impl.engine.extension.use.RenderUnitProvider.provide(RenderUnitProvider.java:95)
at
org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.call(UseRuntimeExtension.java:71)
at
org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:72)
at apps.components.a.b.b__002e__html$3.render(b__002e__html.java:218)
{noformat}
I see that the ScriptDependencyResolver holds cache, which just saves positive
results where the result has been found; if the result is null, it's not
cached, and it will be attempted over and over again.
Of course this situation mostly happens if a lot of these requests with invalid
scriptIdentifiers are done, which points to problems in the content. But it
would be great if the code behaves a bit better here, because I have a
situation here where requests holding the write lock block all other requests
which would have a cache hit.
(Thinking further, I don't really understand why a ReadWrite lock is used here
at all. As far as I can see a ConcurrentHashMap as a cache should be
sufficient.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12343) Add ProtectedBindings.putOnly
[ https://issues.apache.org/jira/browse/SLING-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12343: -- Fix Version/s: (was: Scripting Core 2.4.10) > Add ProtectedBindings.putOnly > - > > Key: SLING-12343 > URL: https://issues.apache.org/jira/browse/SLING-12343 > Project: Sling > Issue Type: Task > Components: Scripting >Reporter: Joerg Hoh >Priority: Major > > Next to SLING-12062 also the ProtectedBindings needs to be augmented by a > dedicated putOnly implementation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12343) Add ProtectedBindings.putOnly
[ https://issues.apache.org/jira/browse/SLING-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12343: -- Fix Version/s: Scripting Core 2.4.10 (was: API 2.27.4) > Add ProtectedBindings.putOnly > - > > Key: SLING-12343 > URL: https://issues.apache.org/jira/browse/SLING-12343 > Project: Sling > Issue Type: Task > Components: Scripting >Reporter: Joerg Hoh >Priority: Major > Fix For: Scripting Core 2.4.10 > > > Next to SLING-12062 also the ProtectedBindings needs to be augmented by a > dedicated putOnly implementation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12343) Add ProtectedBindings.putOnly
[ https://issues.apache.org/jira/browse/SLING-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12343: -- Component/s: Scripting (was: API) > Add ProtectedBindings.putOnly > - > > Key: SLING-12343 > URL: https://issues.apache.org/jira/browse/SLING-12343 > Project: Sling > Issue Type: Task > Components: Scripting >Reporter: Joerg Hoh >Priority: Major > Fix For: API 2.27.4 > > > Next to SLING-12062 also the ProtectedBindings needs to be augmented by a > dedicated putOnly implementation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12343) Add ProtectedBindings.putOnly
Joerg Hoh created SLING-12343: - Summary: Add ProtectedBindings.putOnly Key: SLING-12343 URL: https://issues.apache.org/jira/browse/SLING-12343 Project: Sling Issue Type: Task Components: API Reporter: Joerg Hoh Fix For: API 2.27.4 Next to SLING-12062 also the ProtectedBindings needs to be augmented by a dedicated putOnly implementation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12062) add LazyBindings.putOnly
[
https://issues.apache.org/jira/browse/SLING-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh resolved SLING-12062.
---
Resolution: Fixed
> add LazyBindings.putOnly
>
>
> Key: SLING-12062
> URL: https://issues.apache.org/jira/browse/SLING-12062
> Project: Sling
> Issue Type: Task
> Components: API
>Affects Versions: API 2.27.2
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: API 2.27.4
>
>
> The LazyBindings support the lazy evaluation of values to avoid the potential
> costly resolution of values at provisioning time (the values are only
> resolved when requested via {{get}}).
> But if for some reasons the same key is put twice into a LazyBinding, the
> second call to {{put(key, value)}} resolves the already provided value and
> returns it, but this return value of {{put}} is often ignored.
> So the LazyBindings should have a {{putOnly(key,value)}} method, which
> behaves the same way as the existing {{put}}, but does not return the
> (resolved) previous value. This can be used by all providers which just push
> data into the LazyBindings, but are not interested in any value returned by
> the normal {{put}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12062) add LazyBindings.putOnly
[
https://issues.apache.org/jira/browse/SLING-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12062:
--
Fix Version/s: API 2.27.4
> add LazyBindings.putOnly
>
>
> Key: SLING-12062
> URL: https://issues.apache.org/jira/browse/SLING-12062
> Project: Sling
> Issue Type: Task
> Components: API
>Affects Versions: API 2.27.2
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: API 2.27.4
>
>
> The LazyBindings support the lazy evaluation of values to avoid the potential
> costly resolution of values at provisioning time (the values are only
> resolved when requested via {{get}}).
> But if for some reasons the same key is put twice into a LazyBinding, the
> second call to {{put(key, value)}} resolves the already provided value and
> returns it, but this return value of {{put}} is often ignored.
> So the LazyBindings should have a {{putOnly(key,value)}} method, which
> behaves the same way as the existing {{put}}, but does not return the
> (resolved) previous value. This can be used by all providers which just push
> data into the LazyBindings, but are not interested in any value returned by
> the normal {{put}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12321) Update parent pom to latest
[ https://issues.apache.org/jira/browse/SLING-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850653#comment-17850653 ] Joerg Hoh commented on SLING-12321: --- [~kwin] I don't get it. * We decide to make Java11 the default runtime version (SLING-11841). I am fine with that and voted +1 for it. * I get here the recommendation NOT to require Java 11 as runtime, as the code does not require it, but still works with Java 8. So, should I read SLING-11841 in this way: * it is ok to use Java 11 features in the code, and then require a Java11 runtime. * but if you dont use Java11 features in the bundle, still build for Java 8? Your proposal explicitly mentions the lack of public support of Java 8 from Oracle as a main reason for changing the default to Java 11, so I don't understand why on a case-by-case basis we should still support Java 8. > Update parent pom to latest > --- > > Key: SLING-12321 > URL: https://issues.apache.org/jira/browse/SLING-12321 > Project: Sling > Issue Type: Task > Components: Engine >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > > Updating to parent 60 an force the result to be runable with Java 8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12330) Fix formatting
[ https://issues.apache.org/jira/browse/SLING-12330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12330. --- Resolution: Fixed > Fix formatting > -- > > Key: SLING-12330 > URL: https://issues.apache.org/jira/browse/SLING-12330 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12307) INFO logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12307. - > INFO logging in case no servlet can be resolved > --- > > Key: SLING-12307 > URL: https://issues.apache.org/jira/browse/SLING-12307 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.11.2 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > The Servlets Resolver should log INFO messages in case no servlet can be > resolved. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12307) INFO logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12307. --- Resolution: Duplicate Duplicate of SLING-12297 > INFO logging in case no servlet can be resolved > --- > > Key: SLING-12307 > URL: https://issues.apache.org/jira/browse/SLING-12307 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.11.2 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > The Servlets Resolver should log INFO messages in case no servlet can be > resolved. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12330) Fix formatting
Joerg Hoh created SLING-12330: - Summary: Fix formatting Key: SLING-12330 URL: https://issues.apache.org/jira/browse/SLING-12330 Project: Sling Issue Type: Task Components: Engine Affects Versions: Engine 2.15.14 Reporter: Joerg Hoh Assignee: Joerg Hoh Fix For: Engine 2.15.16 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12326) SocketExceptions are no longer handled as error
[ https://issues.apache.org/jira/browse/SLING-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12326. --- Resolution: Fixed > SocketExceptions are no longer handled as error > --- > > Key: SLING-12326 > URL: https://issues.apache.org/jira/browse/SLING-12326 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.8, Engine 2.15.10, Engine 2.15.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > > [This > commit|https://github.com/apache/sling-org-apache-sling-engine/commit/8ab96759cd435520a228271fbbb9d37955954c80] > introduced a special handling for SocketExceptions under the assumptions > that the only Socket Exceptions can happen when Sling/Jetty fails to stream > back the response to the client (browser). > But there are other types of SocketExceptions, which can happen during page > rendering, e.g. when a Servlet/Script does connections on its own, for > example to fetch data from a backend system. If these exceptions are wrapped > and thrown, it could lead to a situation, that the error handling in this > place is actually not kicking in at all, and also no logging for this > exception is done at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12321) Update parent pom to latest
[ https://issues.apache.org/jira/browse/SLING-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12321: -- Fix Version/s: Engine 2.15.16 (was: Engine 2.16.0) > Update parent pom to latest > --- > > Key: SLING-12321 > URL: https://issues.apache.org/jira/browse/SLING-12321 > Project: Sling > Issue Type: Task > Components: Engine >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > > Updating to parent 60 an force the result to be runable with Java 8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12317) Make Sling Engine build with Java 21
[
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12317:
--
Fix Version/s: Engine 2.15.16
(was: Engine 2.16.0)
> Make Sling Engine build with Java 21
>
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> {noformat}[ERROR]
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
> Time elapsed: 0 s <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
> at
> java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
> at org.jmock.Mockery.mock(Mockery.java:167)
> at org.jmock.Mockery.mock(Mockery.java:143)
> at
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12316) Servlet Name might be set incorrectly after an exception
[
https://issues.apache.org/jira/browse/SLING-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12316:
--
Fix Version/s: Engine 2.15.16
(was: Engine 2.16.0)
> Servlet Name might be set incorrectly after an exception
>
>
> Key: SLING-12316
> URL: https://issues.apache.org/jira/browse/SLING-12316
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> In case an exception happens, the name is not reset properly:
> [https://github.com/apache/sling-org-apache-sling-engine/blob/ad11b3b108764312e6db87aea7de18c3fa00db34/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L553]
> {{requestData.setActiveServletName(callerServlet);}} must be moved into the
> finally block
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12326) SocketExceptions are no longer handled as error
[ https://issues.apache.org/jira/browse/SLING-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12326: -- Fix Version/s: Engine 2.15.16 > SocketExceptions are no longer handled as error > --- > > Key: SLING-12326 > URL: https://issues.apache.org/jira/browse/SLING-12326 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.8, Engine 2.15.10, Engine 2.15.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.16 > > > [This > commit|https://github.com/apache/sling-org-apache-sling-engine/commit/8ab96759cd435520a228271fbbb9d37955954c80] > introduced a special handling for SocketExceptions under the assumptions > that the only Socket Exceptions can happen when Sling/Jetty fails to stream > back the response to the client (browser). > But there are other types of SocketExceptions, which can happen during page > rendering, e.g. when a Servlet/Script does connections on its own, for > example to fetch data from a backend system. If these exceptions are wrapped > and thrown, it could lead to a situation, that the error handling in this > place is actually not kicking in at all, and also no logging for this > exception is done at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12326) SocketExceptions are no longer handled as error
[ https://issues.apache.org/jira/browse/SLING-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12326: - Assignee: Joerg Hoh > SocketExceptions are no longer handled as error > --- > > Key: SLING-12326 > URL: https://issues.apache.org/jira/browse/SLING-12326 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.8, Engine 2.15.10, Engine 2.15.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > [This > commit|https://github.com/apache/sling-org-apache-sling-engine/commit/8ab96759cd435520a228271fbbb9d37955954c80] > introduced a special handling for SocketExceptions under the assumptions > that the only Socket Exceptions can happen when Sling/Jetty fails to stream > back the response to the client (browser). > But there are other types of SocketExceptions, which can happen during page > rendering, e.g. when a Servlet/Script does connections on its own, for > example to fetch data from a backend system. If these exceptions are wrapped > and thrown, it could lead to a situation, that the error handling in this > place is actually not kicking in at all, and also no logging for this > exception is done at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12326) SocketExceptions are no longer handled as error
Joerg Hoh created SLING-12326: - Summary: SocketExceptions are no longer handled as error Key: SLING-12326 URL: https://issues.apache.org/jira/browse/SLING-12326 Project: Sling Issue Type: Task Components: Engine Affects Versions: Engine 2.15.14, Engine 2.15.10, Engine 2.15.8 Reporter: Joerg Hoh [This commit|https://github.com/apache/sling-org-apache-sling-engine/commit/8ab96759cd435520a228271fbbb9d37955954c80] introduced a special handling for SocketExceptions under the assumptions that the only Socket Exceptions can happen when Sling/Jetty fails to stream back the response to the client (browser). But there are other types of SocketExceptions, which can happen during page rendering, e.g. when a Servlet/Script does connections on its own, for example to fetch data from a backend system. If these exceptions are wrapped and thrown, it could lead to a situation, that the error handling in this place is actually not kicking in at all, and also no logging for this exception is done at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12321) Update parent pom to latest
[ https://issues.apache.org/jira/browse/SLING-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12321: -- Description: Updating to parent 60 will forces to use at least Java 11 as runtime dependency. Java 8 will no longer be supported. Thus bumping the minor version. > Update parent pom to latest > --- > > Key: SLING-12321 > URL: https://issues.apache.org/jira/browse/SLING-12321 > Project: Sling > Issue Type: Task > Components: Engine >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.16.0 > > > Updating to parent 60 will forces to use at least Java 11 as runtime > dependency. Java 8 will no longer be supported. Thus bumping the minor > version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12316) Servlet Name might be set incorrectly after an exception
[
https://issues.apache.org/jira/browse/SLING-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12316:
--
Fix Version/s: Engine 2.16.0
(was: Engine 2.15.16)
> Servlet Name might be set incorrectly after an exception
>
>
> Key: SLING-12316
> URL: https://issues.apache.org/jira/browse/SLING-12316
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Engine 2.16.0
>
>
> In case an exception happens, the name is not reset properly:
> [https://github.com/apache/sling-org-apache-sling-engine/blob/ad11b3b108764312e6db87aea7de18c3fa00db34/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L553]
> {{requestData.setActiveServletName(callerServlet);}} must be moved into the
> finally block
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] (SLING-12317) Make Sling Engine build with Java 21
[ https://issues.apache.org/jira/browse/SLING-12317 ]
Joerg Hoh deleted comment on SLING-12317:
---
was (Author: joerghoh):
With this push the runtime requirements of the Sling Engine will be Java 11.
Thus bumping the minor release version number.
> Make Sling Engine build with Java 21
>
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Engine 2.16.0
>
>
> {noformat}[ERROR]
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
> Time elapsed: 0 s <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
> at
> java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
> at org.jmock.Mockery.mock(Mockery.java:167)
> at org.jmock.Mockery.mock(Mockery.java:143)
> at
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12317) Make Sling Engine build with Java 21
[
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12317:
--
Fix Version/s: (was: Engine 2.15.16)
> Make Sling Engine build with Java 21
>
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Engine 2.16.0
>
>
> {noformat}[ERROR]
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
> Time elapsed: 0 s <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
> at
> java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
> at org.jmock.Mockery.mock(Mockery.java:167)
> at org.jmock.Mockery.mock(Mockery.java:143)
> at
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12317) Make Sling Engine build with Java 21
[
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12317:
--
Fix Version/s: Engine 2.16.0
> Make Sling Engine build with Java 21
>
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Engine 2.15.16, Engine 2.16.0
>
>
> {noformat}[ERROR]
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
> Time elapsed: 0 s <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
> at
> java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
> at org.jmock.Mockery.mock(Mockery.java:167)
> at org.jmock.Mockery.mock(Mockery.java:143)
> at
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12321) Update parent pom to latest
[ https://issues.apache.org/jira/browse/SLING-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12321: -- Fix Version/s: Engine 2.16.0 (was: Engine 2.15.16) > Update parent pom to latest > --- > > Key: SLING-12321 > URL: https://issues.apache.org/jira/browse/SLING-12321 > Project: Sling > Issue Type: Task > Components: Engine >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.16.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12317) Make Sling Engine build with Java 21
[
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849559#comment-17849559
]
Joerg Hoh commented on SLING-12317:
---
With this push the runtime requirements of the Sling Engine will be Java 11.
Thus bumping the minor release version number.
> Make Sling Engine build with Java 21
>
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> {noformat}[ERROR]
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
> Time elapsed: 0 s <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
> at
> java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
> at
> org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
> at org.jmock.Mockery.mock(Mockery.java:167)
> at org.jmock.Mockery.mock(Mockery.java:143)
> at
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12321) Update parent pom to latest
Joerg Hoh created SLING-12321: - Summary: Update parent pom to latest Key: SLING-12321 URL: https://issues.apache.org/jira/browse/SLING-12321 Project: Sling Issue Type: Task Components: Engine Reporter: Joerg Hoh Fix For: Engine 2.15.16 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12316) Servlet Name might be set incorrectly after an exception
[
https://issues.apache.org/jira/browse/SLING-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh resolved SLING-12316.
---
Resolution: Fixed
PR merged
> Servlet Name might be set incorrectly after an exception
>
>
> Key: SLING-12316
> URL: https://issues.apache.org/jira/browse/SLING-12316
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
>
> In case an exception happens, the name is not reset properly:
> [https://github.com/apache/sling-org-apache-sling-engine/blob/ad11b3b108764312e6db87aea7de18c3fa00db34/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L553]
> {{requestData.setActiveServletName(callerServlet);}} must be moved into the
> finally block
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12316) Servlet Name might be set incorrectly after an exception
[
https://issues.apache.org/jira/browse/SLING-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12316:
--
Fix Version/s: Engine 2.15.16
> Servlet Name might be set incorrectly after an exception
>
>
> Key: SLING-12316
> URL: https://issues.apache.org/jira/browse/SLING-12316
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> In case an exception happens, the name is not reset properly:
> [https://github.com/apache/sling-org-apache-sling-engine/blob/ad11b3b108764312e6db87aea7de18c3fa00db34/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L553]
> {{requestData.setActiveServletName(callerServlet);}} must be moved into the
> finally block
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12318) Apply spotless formatting to Sling Engine
Joerg Hoh created SLING-12318: - Summary: Apply spotless formatting to Sling Engine Key: SLING-12318 URL: https://issues.apache.org/jira/browse/SLING-12318 Project: Sling Issue Type: Task Components: Engine Affects Versions: Engine 2.15.14 Reporter: Joerg Hoh Apply the formatting changes (and only that) of the maven spotless plugin to Sling Engine. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12317) Make Sling Engine build with Java 21
Joerg Hoh created SLING-12317: - Summary: Make Sling Engine build with Java 21 Key: SLING-12317 URL: https://issues.apache.org/jira/browse/SLING-12317 Project: Sling Issue Type: Task Components: Engine Affects Versions: Engine 2.15.14 Reporter: Joerg Hoh -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12316) Servlet Name might be set incorrectly after an exception
[
https://issues.apache.org/jira/browse/SLING-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845989#comment-17845989
]
Joerg Hoh commented on SLING-12316:
---
https://github.com/apache/sling-org-apache-sling-engine/pull/43
> Servlet Name might be set incorrectly after an exception
>
>
> Key: SLING-12316
> URL: https://issues.apache.org/jira/browse/SLING-12316
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Priority: Major
>
> In case an exception happens, the name is not reset properly:
> [https://github.com/apache/sling-org-apache-sling-engine/blob/ad11b3b108764312e6db87aea7de18c3fa00db34/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L553]
> {{requestData.setActiveServletName(callerServlet);}} must be moved into the
> finally block
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-12316) Servlet Name might be set incorrectly after an exception
[
https://issues.apache.org/jira/browse/SLING-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh reassigned SLING-12316:
-
Assignee: Joerg Hoh
> Servlet Name might be set incorrectly after an exception
>
>
> Key: SLING-12316
> URL: https://issues.apache.org/jira/browse/SLING-12316
> Project: Sling
> Issue Type: Task
> Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
>
> In case an exception happens, the name is not reset properly:
> [https://github.com/apache/sling-org-apache-sling-engine/blob/ad11b3b108764312e6db87aea7de18c3fa00db34/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L553]
> {{requestData.setActiveServletName(callerServlet);}} must be moved into the
> finally block
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12316) Servlet Name might be set incorrectly after an exception
Joerg Hoh created SLING-12316:
-
Summary: Servlet Name might be set incorrectly after an exception
Key: SLING-12316
URL: https://issues.apache.org/jira/browse/SLING-12316
Project: Sling
Issue Type: Task
Components: Engine
Affects Versions: Engine 2.15.14
Reporter: Joerg Hoh
In case an exception happens, the name is not reset properly:
[https://github.com/apache/sling-org-apache-sling-engine/blob/ad11b3b108764312e6db87aea7de18c3fa00db34/src/main/java/org/apache/sling/engine/impl/request/RequestData.java#L553]
{{requestData.setActiveServletName(callerServlet);}} must be moved into the
finally block
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-12307) INFO logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12307: - Assignee: Joerg Hoh > INFO logging in case no servlet can be resolved > --- > > Key: SLING-12307 > URL: https://issues.apache.org/jira/browse/SLING-12307 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.11.2 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > The Servlets Resolver should log INFO messages in case no servlet can be > resolved. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12307) INFO logging in case no servlet can be resolved
Joerg Hoh created SLING-12307: - Summary: INFO logging in case no servlet can be resolved Key: SLING-12307 URL: https://issues.apache.org/jira/browse/SLING-12307 Project: Sling Issue Type: Task Components: Servlets Affects Versions: Servlets Resolver 2.11.2 Reporter: Joerg Hoh The Servlets Resolver should log INFO messages in case no servlet can be resolved. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12297) Logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12297. - > Logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.14 > > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12301) Improve error handling during registration of ServletContext
[ https://issues.apache.org/jira/browse/SLING-12301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12301: -- Description: With SLING-11824 the registration of the ServletContext objects was made asynchronous using bare Threads. If this process fails with any exception, the thread just dies because there is no explicit exception handling and not logging for that case. We should add some logging to have at least traces if such a problem occurs. was: With SLING-11824 the registration of the ServletContext objects was made asynchronous using bare Threads. If this process fails with any exception, the thread just dies because there is no explicit exception handling and not logging for that case. We should add to have at least traces if such a problem occurs. > Improve error handling during registration of ServletContext > > > Key: SLING-12301 > URL: https://issues.apache.org/jira/browse/SLING-12301 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > > With SLING-11824 the registration of the ServletContext objects was made > asynchronous using bare Threads. > If this process fails with any exception, the thread just dies because there > is no explicit exception handling and not logging for that case. > We should add some logging to have at least traces if such a problem occurs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12301) Improve error handling during registration of ServletContext
[ https://issues.apache.org/jira/browse/SLING-12301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12301: -- Description: With SLING-11824 the registration of the ServletContext objects was made asynchronous using bare Threads. If this process fails with any exception, the thread just dies because there is no explicit exception handling and not logging for that case. We should add some logging to have at least traces that such a problem occurred. was: With SLING-11824 the registration of the ServletContext objects was made asynchronous using bare Threads. If this process fails with any exception, the thread just dies because there is no explicit exception handling and not logging for that case. We should add some logging to have at least traces if such a problem occurs. > Improve error handling during registration of ServletContext > > > Key: SLING-12301 > URL: https://issues.apache.org/jira/browse/SLING-12301 > Project: Sling > Issue Type: Task > Components: Engine >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > > With SLING-11824 the registration of the ServletContext objects was made > asynchronous using bare Threads. > If this process fails with any exception, the thread just dies because there > is no explicit exception handling and not logging for that case. > We should add some logging to have at least traces that such a problem > occurred. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12301) Improve error handling during registration of ServletContext
Joerg Hoh created SLING-12301: - Summary: Improve error handling during registration of ServletContext Key: SLING-12301 URL: https://issues.apache.org/jira/browse/SLING-12301 Project: Sling Issue Type: Task Components: Engine Affects Versions: Engine 2.15.10 Reporter: Joerg Hoh With SLING-11824 the registration of the ServletContext objects was made asynchronous using bare Threads. If this process fails with any exception, the thread just dies because there is no explicit exception handling and not logging for that case. We should add to have at least traces if such a problem occurs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12300) Provide a way to retrieve a JCR backed resource by its node identifier
[
https://issues.apache.org/jira/browse/SLING-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839459#comment-17839459
]
Joerg Hoh commented on SLING-12300:
---
{quote}I think I would prefer that the uuid not be addressable so easily. That
seems to be a security hole where someone could just do a brute force attack to
try all the possible values and find paths that exist.
{quote}
I want to address the "security hole" by stating that also here the
authorization setup of the underlying JCR repository applies. That means, also
by this method user cannot access nodes for which they are not authorized. If
you want to make nodes not available to the anonymous user, then don't provide
the anonymous user read access to it.
If your application has path-based restrictions to prevent direct access to
certain paths (on top of the existing JCR restrictions), this approach using
the UUID lookup has the ability to circumvent it and expose nodes which would
be otherwise not accessible due to the path restrictions. By then it should be
trivial to add another path-based restriction to prevent access to /jcr:id/ as
well.
> Provide a way to retrieve a JCR backed resource by its node identifier
> --
>
> Key: SLING-12300
> URL: https://issues.apache.org/jira/browse/SLING-12300
> Project: Sling
> Issue Type: New Feature
> Components: JCR
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: JCR Resource 3.3.0
>
>
> Since all {{javax.jcr.Nodes}} have an identifier [0], a useful feature would
> be {{Resource}} retrieval by node id, which could be its {{jcr:uuid}}
> property for referenceable nodes or the path. In systems that would like to
> use UUID addressing, this would reduce the need for executing JCR queries for
> resource retrieval and would avoid double-reads via the JCR and then Sling
> API to obtain the resource.
> In order to provide a unified behaviour, paths starting with the {{/jcr:id/}}
> prefix should use the resource retrieval by node identifier.
> [0] -
> https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Node.html#getIdentifier()
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-12300) Provide a way to retrieve a JCR backed resource by its node identifier
[
https://issues.apache.org/jira/browse/SLING-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839067#comment-17839067
]
Joerg Hoh edited comment on SLING-12300 at 4/19/24 5:30 PM:
I am not that happy with this magic string:
* It does not feel sling-ish (I would expect a ResourceProvider for it)
* I don't know if the implementation fulfills this requirement or not:
{noformat}
String jcrIdPath="/jcr:id/12345678";
Resoure r = resourceResolver.getResource(jcrIdPath);
assertEquals(jcrIdPath,r.getPath());
assertEquals(r.getPath(),r.adaptTo(Node.class).getPath());
{noformat}
(in other words: What's the path of such a retrieved resource?)
* is it possible to do a request to [http://localhost:8080/jcr:id/].html
and get the result rendered? Do we want this to happen?
* Right now it's not possible to turn off this behavior.
was (Author: joerghoh):
I am not that happy with this magic string:
* It does not feel sling-ish (I would expect a ResourceProvider for it)
* I don't know if the implementation fulfills this requirement or not:
{noformat}
String jcrIdPath="/jcr:id/12345678";
Resoure r = resourceResolver.getResource(jcrIdPath);
assertEquals(fullPath,r.getPath());
assertEquals(r.getPath(),r.adaptTo(Node.class).getPath());
{noformat}
(in other words: What's the path of such a retrieved resource?)
* is it possible to do a request to [http://localhost:8080/jcr:id/].html
and get the result rendered? Do we want this to happen?
* Right now it's not possible to turn off this behavior.
> Provide a way to retrieve a JCR backed resource by its node identifier
> --
>
> Key: SLING-12300
> URL: https://issues.apache.org/jira/browse/SLING-12300
> Project: Sling
> Issue Type: New Feature
> Components: JCR
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: JCR Resource 3.3.0
>
>
> Since all {{javax.jcr.Nodes}} have an identifier [0], a useful feature would
> be {{Resource}} retrieval by node id, which could be its {{jcr:uuid}}
> property for referenceable nodes or the path. In systems that would like to
> use UUID addressing, this would reduce the need for executing JCR queries for
> resource retrieval and would avoid double-reads via the JCR and then Sling
> API to obtain the resource.
> In order to provide a unified behaviour, paths starting with the {{/jcr:id/}}
> prefix should use the resource retrieval by node identifier.
> [0] -
> https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Node.html#getIdentifier()
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-12300) Provide a way to retrieve a JCR backed resource by its node identifier
[
https://issues.apache.org/jira/browse/SLING-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839067#comment-17839067
]
Joerg Hoh edited comment on SLING-12300 at 4/19/24 5:29 PM:
I am not that happy with this magic string:
* It does not feel sling-ish (I would expect a ResourceProvider for it)
* I don't know if the implementation fulfills this requirement or not:
{noformat}
String jcrIdPath="/jcr:id/12345678";
Resoure r = resourceResolver.getResource(jcrIdPath);
assertEquals(fullPath,r.getPath());
assertEquals(r.getPath(),r.adaptTo(Node.class).getPath());
{noformat}
(in other words: What's the path of such a retrieved resource?)
* is it possible to do a request to [http://localhost:8080/jcr:id/].html
and get the result rendered? Do we want this to happen?
* Right now it's not possible to turn off this behavior.
was (Author: joerghoh):
I am not that happy with this magic string:
* It does not feel sling-ish (I would expect a ResourceProvider for it)
* I don't know if the implementation fulfills this requirement or not:
{noformat}
String jcrIdPath="/jcr:id/12345678";
Resoure r = resourceResolver.getResource(jcrIdPath);
assertEquals(fullPath,r.getPath());
{noformat}
(in other words: What's the path of such a retrieved resource?)
* is it possible to do a request to [http://localhost:8080/jcr:id/].html
and get the result rendered? Do we want this to happen?
* Right now it's not possible to turn off this behavior.
> Provide a way to retrieve a JCR backed resource by its node identifier
> --
>
> Key: SLING-12300
> URL: https://issues.apache.org/jira/browse/SLING-12300
> Project: Sling
> Issue Type: New Feature
> Components: JCR
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: JCR Resource 3.3.0
>
>
> Since all {{javax.jcr.Nodes}} have an identifier [0], a useful feature would
> be {{Resource}} retrieval by node id, which could be its {{jcr:uuid}}
> property for referenceable nodes or the path. In systems that would like to
> use UUID addressing, this would reduce the need for executing JCR queries for
> resource retrieval and would avoid double-reads via the JCR and then Sling
> API to obtain the resource.
> In order to provide a unified behaviour, paths starting with the {{/jcr:id/}}
> prefix should use the resource retrieval by node identifier.
> [0] -
> https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Node.html#getIdentifier()
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-12300) Provide a way to retrieve a JCR backed resource by its node identifier
[
https://issues.apache.org/jira/browse/SLING-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839067#comment-17839067
]
Joerg Hoh edited comment on SLING-12300 at 4/19/24 5:28 PM:
I am not that happy with this magic string:
* It does not feel sling-ish (I would expect a ResourceProvider for it)
* I don't know if the implementation fulfills this requirement or not:
{noformat}
String jcrIdPath="/jcr:id/12345678";
Resoure r = resourceResolver.getResource(jcrIdPath);
assertEquals(fullPath,r.getPath());
{noformat}
(in other words: What's the path of such a retrieved resource?)
* is it possible to do a request to [http://localhost:8080/jcr:id/].html
and get the result rendered? Do we want this to happen?
* Right now it's not possible to turn off this behavior.
was (Author: joerghoh):
I am not that happy with this magic string:
* It does not feel sling-ish (I would expect a ResourceProvider for it)
* It might break code, which relies on
{noformat}
String jcrIdPath="/jcr:id/12345678";
Resoure r = resourceResolver.getResource(jcrIdPath);
assertEquals(fullPath,r.getPath());
{noformat}
(although such code might break in other cases already today, when using
aliases and vanity paths)
* is it possible to do a request to [http://localhost:8080/jcr:id/].html
and get the result rendered? Do we want this to happen?
* Right now it's not possible to turn off this behavior.
> Provide a way to retrieve a JCR backed resource by its node identifier
> --
>
> Key: SLING-12300
> URL: https://issues.apache.org/jira/browse/SLING-12300
> Project: Sling
> Issue Type: New Feature
> Components: JCR
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: JCR Resource 3.3.0
>
>
> Since all {{javax.jcr.Nodes}} have an identifier [0], a useful feature would
> be {{Resource}} retrieval by node id, which could be its {{jcr:uuid}}
> property for referenceable nodes or the path. In systems that would like to
> use UUID addressing, this would reduce the need for executing JCR queries for
> resource retrieval and would avoid double-reads via the JCR and then Sling
> API to obtain the resource.
> In order to provide a unified behaviour, paths starting with the {{/jcr:id/}}
> prefix should use the resource retrieval by node identifier.
> [0] -
> https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Node.html#getIdentifier()
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12300) Provide a way to retrieve a JCR backed resource by its node identifier
[
https://issues.apache.org/jira/browse/SLING-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839067#comment-17839067
]
Joerg Hoh commented on SLING-12300:
---
I am not that happy with this magic string:
* It does not feel sling-ish (I would expect a ResourceProvider for it)
* I might break code, which relies on
{noformat}
String jcrIdPath="/jcr:id/12345678";
Resoure r = resourceResolver.getResource(jcrIdPath);
assertEquals(fullPath,r.getPath());
{noformat}
(although such code might break in other cases already today, when using
aliases and vanity paths)
* is it possible to do a request to http://localhost:8080/jcr:id/.html and
get the result rendered? Do we want this to happen?
* Right now it's not possible to turn off this behavior.
> Provide a way to retrieve a JCR backed resource by its node identifier
> --
>
> Key: SLING-12300
> URL: https://issues.apache.org/jira/browse/SLING-12300
> Project: Sling
> Issue Type: New Feature
> Components: JCR
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: JCR Resource 3.3.0
>
>
> Since all {{javax.jcr.Nodes}} have an identifier [0], a useful feature would
> be {{Resource}} retrieval by node id, which could be its {{jcr:uuid}}
> property for referenceable nodes or the path. In systems that would like to
> use UUID addressing, this would reduce the need for executing JCR queries for
> resource retrieval and would avoid double-reads via the JCR and then Sling
> API to obtain the resource.
> In order to provide a unified behaviour, paths starting with the {{/jcr:id/}}
> prefix should use the resource retrieval by node identifier.
> [0] -
> https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Node.html#getIdentifier()
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-12300) Provide a way to retrieve a JCR backed resource by its node identifier
[
https://issues.apache.org/jira/browse/SLING-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839067#comment-17839067
]
Joerg Hoh edited comment on SLING-12300 at 4/19/24 5:25 PM:
I am not that happy with this magic string:
* It does not feel sling-ish (I would expect a ResourceProvider for it)
* It might break code, which relies on
{noformat}
String jcrIdPath="/jcr:id/12345678";
Resoure r = resourceResolver.getResource(jcrIdPath);
assertEquals(fullPath,r.getPath());
{noformat}
(although such code might break in other cases already today, when using
aliases and vanity paths)
* is it possible to do a request to [http://localhost:8080/jcr:id/].html
and get the result rendered? Do we want this to happen?
* Right now it's not possible to turn off this behavior.
was (Author: joerghoh):
I am not that happy with this magic string:
* It does not feel sling-ish (I would expect a ResourceProvider for it)
* I might break code, which relies on
{noformat}
String jcrIdPath="/jcr:id/12345678";
Resoure r = resourceResolver.getResource(jcrIdPath);
assertEquals(fullPath,r.getPath());
{noformat}
(although such code might break in other cases already today, when using
aliases and vanity paths)
* is it possible to do a request to http://localhost:8080/jcr:id/.html and
get the result rendered? Do we want this to happen?
* Right now it's not possible to turn off this behavior.
> Provide a way to retrieve a JCR backed resource by its node identifier
> --
>
> Key: SLING-12300
> URL: https://issues.apache.org/jira/browse/SLING-12300
> Project: Sling
> Issue Type: New Feature
> Components: JCR
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: JCR Resource 3.3.0
>
>
> Since all {{javax.jcr.Nodes}} have an identifier [0], a useful feature would
> be {{Resource}} retrieval by node id, which could be its {{jcr:uuid}}
> property for referenceable nodes or the path. In systems that would like to
> use UUID addressing, this would reduce the need for executing JCR queries for
> resource retrieval and would avoid double-reads via the JCR and then Sling
> API to obtain the resource.
> In order to provide a unified behaviour, paths starting with the {{/jcr:id/}}
> prefix should use the resource retrieval by node identifier.
> [0] -
> https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Node.html#getIdentifier()
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12297) Logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Fix Version/s: Engine 2.15.14 (was: Engine 2.15.12) > Logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.14 > > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12297) Logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12297. --- Resolution: Fixed > Logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.12 > > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12297) Logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12297: - Assignee: Joerg Hoh > Logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.12 > > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12297) Logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Fix Version/s: Engine 2.15.12 > Logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > Fix For: Engine 2.15.12 > > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12297) Adding logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Description: Right now the SlingEngine just returns a 404, if the no servlet was found to render the resource. It should also log a WARN message indicating that this happened. (was: Right now the ServletsResolver just returns a 404, if the no servlet was found to render the resource. It should also log a WARN message indicating that this happened.) > Adding logging in case no servlet can be resolved > - > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12297) Logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Summary: Logging in case no servlet can be resolved (was: Add logging in case no servlet can be resolved) > Logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12297) Add logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Summary: Add logging in case no servlet can be resolved (was: Adding logging in case no servlet can be resolved) > Add logging in case no servlet can be resolved > -- > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > > Right now the SlingEngine just returns a 404, if the no servlet was found to > render the resource. It should also log a WARN message indicating that this > happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12297) Adding logging in case no servlet can be resolved
[ https://issues.apache.org/jira/browse/SLING-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12297: -- Affects Version/s: Engine 2.15.10 (was: Servlets Resolver 2.11.2) > Adding logging in case no servlet can be resolved > - > > Key: SLING-12297 > URL: https://issues.apache.org/jira/browse/SLING-12297 > Project: Sling > Issue Type: Task >Affects Versions: Engine 2.15.10 >Reporter: Joerg Hoh >Priority: Major > > Right now the ServletsResolver just returns a 404, if the no servlet was > found to render the resource. It should also log a WARN message indicating > that this happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12297) Adding logging in case no servlet can be resolved
Joerg Hoh created SLING-12297: - Summary: Adding logging in case no servlet can be resolved Key: SLING-12297 URL: https://issues.apache.org/jira/browse/SLING-12297 Project: Sling Issue Type: Task Affects Versions: Servlets Resolver 2.11.2 Reporter: Joerg Hoh Right now the ServletsResolver just returns a 404, if the no servlet was found to render the resource. It should also log a WARN message indicating that this happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12264) check save() operations
[
https://issues.apache.org/jira/browse/SLING-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825199#comment-17825199
]
Joerg Hoh commented on SLING-12264:
---
Good point, but when I dug into the first few levels of the Oak implementation
of session.save() I did not find any hint which made me think that it actually
checks for any pending change first.
Also I consistently used this pattern
{noformat}
if (session.hasPendingChanges()) {
session.save();
}
{noformat}
if I was unsure if anything was changed at all, and noone pointed it out as
problematic.
But you are right, one could expect that the JCR implementation does that check
internally to avoid unnecessary work.
> check save() operations
> ---
>
> Key: SLING-12264
> URL: https://issues.apache.org/jira/browse/SLING-12264
> Project: Sling
> Issue Type: Task
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.46
>Reporter: Joerg Hoh
>Priority: Major
>
> Before doing a session.save() operation, it should always be checked if there
> is something to save at all.
> This can speed up the execution of individual repoinit statements if the
> repoinit statement does not need to be applied.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-12262) Repoinit: report failures via metrics
[ https://issues.apache.org/jira/browse/SLING-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12262: - Assignee: Joerg Hoh > Repoinit: report failures via metrics > - > > Key: SLING-12262 > URL: https://issues.apache.org/jira/browse/SLING-12262 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > When a repoinit statement fails (and for that reason the SlingRepository > service cannot be started, repoinit should expose this as a metric. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12264) check save() operations
Joerg Hoh created SLING-12264: - Summary: check save() operations Key: SLING-12264 URL: https://issues.apache.org/jira/browse/SLING-12264 Project: Sling Issue Type: Task Components: Repoinit Affects Versions: Repoinit JCR 1.1.46 Reporter: Joerg Hoh Before doing a session.save() operation, it should always be checked if there is something to save at all. This can speed up the execution of individual repoinit statements if the repoinit statement does not need to be applied. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12262) Repoinit: report failures via metrics
[ https://issues.apache.org/jira/browse/SLING-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824365#comment-17824365 ] Joerg Hoh commented on SLING-12262: --- We scrape metrics via prometheus and have an alertmanager instance to create alerts from it. If now an instance is not starting up, it's much easier to find out if repoinit is the culprit if you can query a metric than to search the logs for the characteristical exception of repoinit. That allows us to refine the "instance-not-starting-up" alert and convert it into an "instance-not-starting-up-because-of-repoinit-issues" alert, which is much more meaningful and which can be handled differently than the generic alert, which always requires the general triage process. > Repoinit: report failures via metrics > - > > Key: SLING-12262 > URL: https://issues.apache.org/jira/browse/SLING-12262 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Priority: Major > > When a repoinit statement fails (and for that reason the SlingRepository > service cannot be started, repoinit should expose this as a metric. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12262) Repoinit: report failures via metrics
Joerg Hoh created SLING-12262: - Summary: Repoinit: report failures via metrics Key: SLING-12262 URL: https://issues.apache.org/jira/browse/SLING-12262 Project: Sling Issue Type: Task Components: Repoinit Affects Versions: Repoinit JCR 1.1.46 Reporter: Joerg Hoh When a repoinit statement fails (and for that reason the SlingRepository service cannot be started, repoinit should expose this as a metric. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12256) update test dependencies
[ https://issues.apache.org/jira/browse/SLING-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12256. - > update test dependencies > > > Key: SLING-12256 > URL: https://issues.apache.org/jira/browse/SLING-12256 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
[
https://issues.apache.org/jira/browse/SLING-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-12253.
-
> ConcurrentModificationException in AbstractResourceCollector
>
>
> Key: SLING-12253
> URL: https://issues.apache.org/jira/browse/SLING-12253
> Project: Sling
> Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.14, Servlets Resolver 2.10.0,
> Servlets Resolver 2.11.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Servlets Resolver 2.11.2
>
>
> {noformat}
> [[::1] [1705550745690] GET /content/foobar.html HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> Throwable
> java.util.ConcurrentModificationException: null
> at
> java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
> at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
> at
> org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
> [org.apache.sling.servlets.resolver:2.9.14]
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12257) update spotbugs to support java21
[ https://issues.apache.org/jira/browse/SLING-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12257. - > update spotbugs to support java21 > - > > Key: SLING-12257 > URL: https://issues.apache.org/jira/browse/SLING-12257 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12255) Fix formatting
[ https://issues.apache.org/jira/browse/SLING-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-12255. - > Fix formatting > --- > > Key: SLING-12255 > URL: https://issues.apache.org/jira/browse/SLING-12255 > Project: Sling > Issue Type: Task >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Trivial > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12062) add LazyBindings.putOnly
[
https://issues.apache.org/jira/browse/SLING-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820724#comment-17820724
]
Joerg Hoh commented on SLING-12062:
---
PR: https://github.com/apache/sling-org-apache-sling-api/pull/52
> add LazyBindings.putOnly
>
>
> Key: SLING-12062
> URL: https://issues.apache.org/jira/browse/SLING-12062
> Project: Sling
> Issue Type: Task
> Components: API
>Affects Versions: API 2.27.2
>Reporter: Joerg Hoh
>Priority: Major
>
> The LazyBindings support the lazy evaluation of values to avoid the potential
> costly resolution of values at provisioning time (the values are only
> resolved when requested via {{get}}).
> But if for some reasons the same key is put twice into a LazyBinding, the
> second call to {{put(key, value)}} resolves the already provided value and
> returns it, but this return value of {{put}} is often ignored.
> So the LazyBindings should have a {{putOnly(key,value)}} method, which
> behaves the same way as the existing {{put}}, but does not return the
> (resolved) previous value. This can be used by all providers which just push
> data into the LazyBindings, but are not interested in any value returned by
> the normal {{put}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-12062) add LazyBindings.putOnly
[
https://issues.apache.org/jira/browse/SLING-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh reassigned SLING-12062:
-
Assignee: Joerg Hoh
> add LazyBindings.putOnly
>
>
> Key: SLING-12062
> URL: https://issues.apache.org/jira/browse/SLING-12062
> Project: Sling
> Issue Type: Task
> Components: API
>Affects Versions: API 2.27.2
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
>
> The LazyBindings support the lazy evaluation of values to avoid the potential
> costly resolution of values at provisioning time (the values are only
> resolved when requested via {{get}}).
> But if for some reasons the same key is put twice into a LazyBinding, the
> second call to {{put(key, value)}} resolves the already provided value and
> returns it, but this return value of {{put}} is often ignored.
> So the LazyBindings should have a {{putOnly(key,value)}} method, which
> behaves the same way as the existing {{put}}, but does not return the
> (resolved) previous value. This can be used by all providers which just push
> data into the LazyBindings, but are not interested in any value returned by
> the normal {{put}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12062) add LazyBindings.putOnly
[
https://issues.apache.org/jira/browse/SLING-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12062:
--
Description:
The LazyBindings support the lazy evaluation of values to avoid the potential
costly resolution of values at provisioning time (the values are only resolved
when requested via {{get}}).
But if for some reasons the same key is put twice into a LazyBinding, the
second call to {{put(key, value)}} resolves the already provided value and
returns it, but this return value of {{put}} is often ignored.
So the LazyBindings should have a {{putOnly(key,value)}} method, which behaves
the same way as the existing {{put}}, but does not return the (resolved)
previous value. This can be used by all providers which just push data into the
LazyBindings, but are not interested in any value returned by the normal
{{put}}.
was:
The LazyBindings support the lazy evaluation of values to avoid the potential
costly resolution of values at provisioning time (the values are only resolved
when requested via {{get}}).
But if for some reasons the same key is put twice into a LazyBinding, the
second call to {{put(key, value)}} resolves the already provided value and
returns it, but this return value of {{put}} is often ignored.
So the LazyBindings should have a {{putOnly(key,value)}} method, which behaves
the same way as the existing {{put}}, but does not return the (resolved)
previous value. This can be used by all providers which just push data into the
LazyBindings, but are not interested in any potential returned by the normal
{{put}}.
> add LazyBindings.putOnly
>
>
> Key: SLING-12062
> URL: https://issues.apache.org/jira/browse/SLING-12062
> Project: Sling
> Issue Type: Task
> Components: API
>Affects Versions: API 2.27.2
>Reporter: Joerg Hoh
>Priority: Major
>
> The LazyBindings support the lazy evaluation of values to avoid the potential
> costly resolution of values at provisioning time (the values are only
> resolved when requested via {{get}}).
> But if for some reasons the same key is put twice into a LazyBinding, the
> second call to {{put(key, value)}} resolves the already provided value and
> returns it, but this return value of {{put}} is often ignored.
> So the LazyBindings should have a {{putOnly(key,value)}} method, which
> behaves the same way as the existing {{put}}, but does not return the
> (resolved) previous value. This can be used by all providers which just push
> data into the LazyBindings, but are not interested in any value returned by
> the normal {{put}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12255) Fix formatting
[ https://issues.apache.org/jira/browse/SLING-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12255. --- Resolution: Fixed > Fix formatting > --- > > Key: SLING-12255 > URL: https://issues.apache.org/jira/browse/SLING-12255 > Project: Sling > Issue Type: Task >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Trivial > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
[
https://issues.apache.org/jira/browse/SLING-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh resolved SLING-12253.
---
Resolution: Fixed
> ConcurrentModificationException in AbstractResourceCollector
>
>
> Key: SLING-12253
> URL: https://issues.apache.org/jira/browse/SLING-12253
> Project: Sling
> Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.14, Servlets Resolver 2.10.0,
> Servlets Resolver 2.11.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Servlets Resolver 2.11.2
>
>
> {noformat}
> [[::1] [1705550745690] GET /content/foobar.html HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> Throwable
> java.util.ConcurrentModificationException: null
> at
> java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
> at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
> at
> org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
> [org.apache.sling.servlets.resolver:2.9.14]
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12257) update spotbugs to support java21
[ https://issues.apache.org/jira/browse/SLING-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12257. --- Resolution: Fixed > update spotbugs to support java21 > - > > Key: SLING-12257 > URL: https://issues.apache.org/jira/browse/SLING-12257 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12256) update test dependencies
[ https://issues.apache.org/jira/browse/SLING-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12256. --- Resolution: Fixed > update test dependencies > > > Key: SLING-12256 > URL: https://issues.apache.org/jira/browse/SLING-12256 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (SLING-12256) update test dependencies
[ https://issues.apache.org/jira/browse/SLING-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818808#comment-17818808 ] Joerg Hoh edited comment on SLING-12256 at 2/20/24 4:31 PM: PR: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/47 was (Author: joerghoh): PR: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/46 > update test dependencies > > > Key: SLING-12256 > URL: https://issues.apache.org/jira/browse/SLING-12256 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12257) update spotbugs to support java21
[ https://issues.apache.org/jira/browse/SLING-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12257: - Assignee: Joerg Hoh > update spotbugs to support java21 > - > > Key: SLING-12257 > URL: https://issues.apache.org/jira/browse/SLING-12257 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12257) update spotbugs to support java21
Joerg Hoh created SLING-12257: - Summary: update spotbugs to support java21 Key: SLING-12257 URL: https://issues.apache.org/jira/browse/SLING-12257 Project: Sling Issue Type: Task Components: Servlets Affects Versions: Servlets Resolver 2.9.14 Reporter: Joerg Hoh Fix For: Servlets Resolver 2.11.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12256) update test dependencies
[ https://issues.apache.org/jira/browse/SLING-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818808#comment-17818808 ] Joerg Hoh commented on SLING-12256: --- PR: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/46 > update test dependencies > > > Key: SLING-12256 > URL: https://issues.apache.org/jira/browse/SLING-12256 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12256) update test dependencies
[ https://issues.apache.org/jira/browse/SLING-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12256: - Assignee: Joerg Hoh > update test dependencies > > > Key: SLING-12256 > URL: https://issues.apache.org/jira/browse/SLING-12256 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12256) update test dependencies
Joerg Hoh created SLING-12256: - Summary: update test dependencies Key: SLING-12256 URL: https://issues.apache.org/jira/browse/SLING-12256 Project: Sling Issue Type: Task Components: Servlets Affects Versions: Servlets Resolver 2.11.0 Reporter: Joerg Hoh Fix For: Servlets Resolver 2.11.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
[
https://issues.apache.org/jira/browse/SLING-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh reassigned SLING-12253:
-
Assignee: Joerg Hoh
> ConcurrentModificationException in AbstractResourceCollector
>
>
> Key: SLING-12253
> URL: https://issues.apache.org/jira/browse/SLING-12253
> Project: Sling
> Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.14, Servlets Resolver 2.10.0,
> Servlets Resolver 2.11.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
>
> {noformat}
> [[::1] [1705550745690] GET /content/foobar.html HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> Throwable
> java.util.ConcurrentModificationException: null
> at
> java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
> at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
> at
> org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
> [org.apache.sling.servlets.resolver:2.9.14]
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
[
https://issues.apache.org/jira/browse/SLING-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12253:
--
Fix Version/s: Servlets Resolver 2.11.2
> ConcurrentModificationException in AbstractResourceCollector
>
>
> Key: SLING-12253
> URL: https://issues.apache.org/jira/browse/SLING-12253
> Project: Sling
> Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.14, Servlets Resolver 2.10.0,
> Servlets Resolver 2.11.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Servlets Resolver 2.11.2
>
>
> {noformat}
> [[::1] [1705550745690] GET /content/foobar.html HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> Throwable
> java.util.ConcurrentModificationException: null
> at
> java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
> at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
> at
> org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
> [org.apache.sling.servlets.resolver:2.9.14]
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12255) Fix formatting
[ https://issues.apache.org/jira/browse/SLING-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12255: -- Fix Version/s: Servlets Resolver 2.11.2 (was: Servlets Resolver 2.11.0) > Fix formatting > --- > > Key: SLING-12255 > URL: https://issues.apache.org/jira/browse/SLING-12255 > Project: Sling > Issue Type: Task >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Trivial > Fix For: Servlets Resolver 2.11.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12255) Fix formatting
[ https://issues.apache.org/jira/browse/SLING-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12255: -- Fix Version/s: Servlets Resolver 2.11.0 > Fix formatting > --- > > Key: SLING-12255 > URL: https://issues.apache.org/jira/browse/SLING-12255 > Project: Sling > Issue Type: Task >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Trivial > Fix For: Servlets Resolver 2.11.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12255) Fix formatting
[ https://issues.apache.org/jira/browse/SLING-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818803#comment-17818803 ] Joerg Hoh commented on SLING-12255: --- PR https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/44 > Fix formatting > --- > > Key: SLING-12255 > URL: https://issues.apache.org/jira/browse/SLING-12255 > Project: Sling > Issue Type: Task >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12255) Fix formatting
[ https://issues.apache.org/jira/browse/SLING-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12255: - Assignee: Joerg Hoh > Fix formatting > --- > > Key: SLING-12255 > URL: https://issues.apache.org/jira/browse/SLING-12255 > Project: Sling > Issue Type: Task >Affects Versions: Servlets Resolver 2.9.14 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12255) Fix formatting
Joerg Hoh created SLING-12255: - Summary: Fix formatting Key: SLING-12255 URL: https://issues.apache.org/jira/browse/SLING-12255 Project: Sling Issue Type: Task Affects Versions: Servlets Resolver 2.9.14 Reporter: Joerg Hoh -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
[
https://issues.apache.org/jira/browse/SLING-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12253:
--
Description:
{noformat}
[[::1] [1705550745690] GET /content/foobar.html HTTP/1.1]
org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
Throwable
java.util.ConcurrentModificationException: null
at
java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
at
org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
[org.apache.sling.servlets.resolver:2.9.14]
at
org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
[org.apache.sling.servlets.resolver:2.9.14]
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at
org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
[org.apache.sling.servlets.resolver:2.9.14]
at
org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
[org.apache.sling.servlets.resolver:2.9.14]
at
org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
[org.apache.sling.servlets.resolver:2.9.14]
...
{noformat}
was:
{noformat}
org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
Throwable
java.util.ConcurrentModificationException: null
at
java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
at
org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
[org.apache.sling.servlets.resolver:2.9.14]
at
org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
[org.apache.sling.servlets.resolver:2.9.14]
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at
org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
[org.apache.sling.servlets.resolver:2.9.14]
at
org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
[org.apache.sling.servlets.resolver:2.9.14]
at
org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
[org.apache.sling.servlets.resolver:2.9.14]
...
{noformat}
> ConcurrentModificationException in AbstractResourceCollector
>
>
> Key: SLING-12253
> URL: https://issues.apache.org/jira/browse/SLING-12253
> Project: Sling
> Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.14
>Reporter: Joerg Hoh
>Priority: Major
>
> {noformat}
> [[::1] [1705550745690] GET /content/foobar.html HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> Throwable
> java.util.ConcurrentModificationException: null
> at
> java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
> at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
> at
> org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
> [org.apache.sling.servlets.resolver:2.9.14]
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
Joerg Hoh created SLING-12253:
-
Summary: ConcurrentModificationException in
AbstractResourceCollector
Key: SLING-12253
URL: https://issues.apache.org/jira/browse/SLING-12253
Project: Sling
Issue Type: Task
Affects Versions: Servlets Resolver 2.9.14
Reporter: Joerg Hoh
{noformat}
org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
Throwable
java.util.ConcurrentModificationException: null
at
java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
at
org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
[org.apache.sling.servlets.resolver:2.9.14]
at
org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
[org.apache.sling.servlets.resolver:2.9.14]
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at
org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
[org.apache.sling.servlets.resolver:2.9.14]
at
org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
[org.apache.sling.servlets.resolver:2.9.14]
at
org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
[org.apache.sling.servlets.resolver:2.9.14]
...
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12244) cache results of ResourceResolver.getResourceParentType
[ https://issues.apache.org/jira/browse/SLING-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12244: -- Description: In the context of Sling Models I found that a lot of calls to ResourceResolver.getParentResourceType(Resource) are done, which result in repository access. But this can happen also outside of it. In a simple example (AEM wknd page) I found in total 320 calls to in total 36 resources. Caching these can save around 280 requests to the repository, which a reduction in repository access in the range of 2-3% when rendering the complete page. was: In the context of Sling Models I found that a lot of calls to ResourceResolver.getParentResourceType(Resource) are done, which result in repository access. But this can happen also outside of it. In a simple example (AEM wknd page) I found in total 320 calls to in total 36 resources. Caching these can save around 280 requests to the repository, which a reduction in the range of 2-3% when it comes to repository access when rendering the complete page. > cache results of ResourceResolver.getResourceParentType > --- > > Key: SLING-12244 > URL: https://issues.apache.org/jira/browse/SLING-12244 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > In the context of Sling Models I found that a lot of calls to > ResourceResolver.getParentResourceType(Resource) are done, which result in > repository access. But this can happen also outside of it. > In a simple example (AEM wknd page) I found in total 320 calls to in total 36 > resources. Caching these can save around 280 requests to the repository, > which a reduction in repository access in the range of 2-3% when rendering > the complete page. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12244) cache results of ResourceResolver.getResourceParentType
[ https://issues.apache.org/jira/browse/SLING-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12244: -- Description: In the context of Sling Models I found that a lot of calls to ResourceResolver.getParentResourceType(Resource) are done, which result in repository access. But this can happen also outside of it. In a simple example (AEM wknd page) I found in total 320 calls to in total 36 resources. Caching these can save around 280 requests to the repository, which a reduction in the range of 2-3% when it comes to repository access when rendering the complete page. was: In the context of Sling Models I found that a lot of calls to ResourceResolver.getParentResourceType(Resource) are done, which result in repository access. But this can happen also outside of it. In a simple example (AEM wknd page) I found in total 320 calls to in total 36 resources, which can around 280 requests to the repository, which a reduction in the range of 2-3% when it comes to repository access when rendering the complete page. > cache results of ResourceResolver.getResourceParentType > --- > > Key: SLING-12244 > URL: https://issues.apache.org/jira/browse/SLING-12244 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > In the context of Sling Models I found that a lot of calls to > ResourceResolver.getParentResourceType(Resource) are done, which result in > repository access. But this can happen also outside of it. > In a simple example (AEM wknd page) I found in total 320 calls to in total 36 > resources. Caching these can save around 280 requests to the repository, > which a reduction in the range of 2-3% when it comes to repository access > when rendering the complete page. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11605) Async VanityPathInitializer thread should log any exception
[ https://issues.apache.org/jira/browse/SLING-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816029#comment-17816029 ] Joerg Hoh commented on SLING-11605: --- [~reschke] The Sling threadpool implementation is logging if a thread fails with an exception. But this implementation here uses the raw Java Thread, and there is no logging in case the thread fails with an exception. > Async VanityPathInitializer thread should log any exception > --- > > Key: SLING-11605 > URL: https://issues.apache.org/jira/browse/SLING-11605 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver >Affects Versions: Resource Resolver 1.10.0 >Reporter: Joerg Hoh >Priority: Major > > In case the vanity paths are loaded asynchronously, the thread can be > terminated by an unchecked exception without leaving any trace in the logs. > The code should be changed that in case an unchecked exception thrown at > least the exception is logged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
