[jira] [Resolved] (SLING-8815) [API Regions] Prevent from resolving to customer-provided bundles
[
https://issues.apache.org/jira/browse/SLING-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8815.
---
Assignee: Simone Tripodi (was: Simone Tripodi)
Resolution: Fixed
Merged on {{master}}
> [API Regions] Prevent from resolving to customer-provided bundles
> -
>
> Key: SLING-8815
> URL: https://issues.apache.org/jira/browse/SLING-8815
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.0.2
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Feature Model API Regions Runtime Fragment 1.0.4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There is the case where a customer provides a different version of a bundle
> also provided by platform, preventing the system from resolving to
> customer-provided bundles is not yet implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-8815) [API Regions] Prevent from resolving to customer-provided bundles
Simone Tripodi created SLING-8815: - Summary: [API Regions] Prevent from resolving to customer-provided bundles Key: SLING-8815 URL: https://issues.apache.org/jira/browse/SLING-8815 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: Feature Model API Regions Extension 1.0.4 Reporter: Simone Tripodi Fix For: Feature Model API Regions Extension 1.1.0 There is the case where a customer provides a different version of a bundle also provided by platform, preventing the system from resolving to customer-provided bundles is not yet implemented. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8567) Support start levels declared via JCR path in input packages to cp2sf
[ https://issues.apache.org/jira/browse/SLING-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8567: -- Fix Version/s: Content-Package to Feature Model Converter 1.0.0 > Support start levels declared via JCR path in input packages to cp2sf > - > > Key: SLING-8567 > URL: https://issues.apache.org/jira/browse/SLING-8567 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Georg Henzler >Assignee: Georg Henzler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The JCR Installer provider supports start levels [1], hence the > Content-Package to Feature Model Converter should also support this feature. > [1] > https://sling.apache.org/documentation/bundles/jcr-installer-provider.html#start-level-support > - this was introduced with SLING-2011 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8608) Fail the conversion if the resulting attached content-package is MIXED type
[ https://issues.apache.org/jira/browse/SLING-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8608: -- Fix Version/s: Content-Package to Feature Model Converter 1.0.0 > Fail the conversion if the resulting attached content-package is MIXED type > --- > > Key: SLING-8608 > URL: https://issues.apache.org/jira/browse/SLING-8608 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.0 > > > It can be prevented from deploying mixed content-package(s) via Launcher, so > users are not surprised when mutable contents are ignored. > Conversion is stopped as early as possible with the appropriate error message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8573) ACLs are missing from the converted content packages for regular users and groups
[ https://issues.apache.org/jira/browse/SLING-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8573: -- Fix Version/s: Content-Package to Feature Model Converter 1.0.0 > ACLs are missing from the converted content packages for regular users and > groups > - > > Key: SLING-8573 > URL: https://issues.apache.org/jira/browse/SLING-8573 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Andrei Tuicu >Assignee: Simone Tripodi >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.0 > > > ACLs are missing from the converted content packages for regular users and > groups. > All "_rep_policy" nodes are removed by the converter from the resulting > content package and in the repoinit section of the JSON output there are only > the ACLs for service users. > We should either: > * Add the ACLs in the repo init for all users, groups, system users, or > * Don't remove the "_rep_policy" nodes from the resulting content package -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8573) ACLs are missing from the converted content packages for regular users and groups
[ https://issues.apache.org/jira/browse/SLING-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8573: -- Affects Version/s: Content-Package to Feature Model Converter 1.0.0 > ACLs are missing from the converted content packages for regular users and > groups > - > > Key: SLING-8573 > URL: https://issues.apache.org/jira/browse/SLING-8573 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Andrei Tuicu >Assignee: Simone Tripodi >Priority: Major > > ACLs are missing from the converted content packages for regular users and > groups. > All "_rep_policy" nodes are removed by the converter from the resulting > content package and in the repoinit section of the JSON output there are only > the ACLs for service users. > We should either: > * Add the ACLs in the repo init for all users, groups, system users, or > * Don't remove the "_rep_policy" nodes from the resulting content package -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8578) Nodes which contain : are not correctly processed
[
https://issues.apache.org/jira/browse/SLING-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi updated SLING-8578:
--
Fix Version/s: Content-Package to Feature Model Converter 1.0.0
> Nodes which contain : are not correctly processed
> -
>
> Key: SLING-8578
> URL: https://issues.apache.org/jira/browse/SLING-8578
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.0
>Reporter: Andrei Tuicu
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> h3. Problem
> Nodes that contain : character are put in content packages with the help of _
> , for example the following path /content/cq:tags/somenode in AEM would look
> in the content package like:
> /jcr_root/_cq_tags/somenode . This is done because Windows does not accept :
> in the name of it's files/folders.
> If the content package converter would process this path it would generate a
> the following repo:init lines
> {code}
> "create path (sling:Folder) /content/_cq_tags",
> "create path (cq:Tag) /content/_cq_tags/somenode",
> {code}
> Similar, if there are rep policies under that path, the output would look as
> following:
> {code}
> "set ACL for my-system-user",
> "allow
> jcr:versionManagement,jcr:read,rep:write,crx:replicate,jcr:lockManagement on
> /content/_cq_tags/somenode",
> {code}
> This results in the wrong node structure in the AEM instance, as follows:
> {code}
> /content
>/cq:tags### <- original AEM folder
>/_cq_tags ###<- folder created by the repoinit statements
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-8567) Support start levels declared via JCR path in input packages to cp2sf
[ https://issues.apache.org/jira/browse/SLING-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8567: -- Affects Version/s: Content-Package to Feature Model Converter 1.0.0 > Support start levels declared via JCR path in input packages to cp2sf > - > > Key: SLING-8567 > URL: https://issues.apache.org/jira/browse/SLING-8567 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Georg Henzler >Assignee: Georg Henzler >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The JCR Installer provider supports start levels [1], hence the > Content-Package to Feature Model Converter should also support this feature. > [1] > https://sling.apache.org/documentation/bundles/jcr-installer-provider.html#start-level-support > - this was introduced with SLING-2011 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8578) Nodes which contain : are not correctly processed
[
https://issues.apache.org/jira/browse/SLING-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi updated SLING-8578:
--
Affects Version/s: Content-Package to Feature Model Converter 1.0.0
> Nodes which contain : are not correctly processed
> -
>
> Key: SLING-8578
> URL: https://issues.apache.org/jira/browse/SLING-8578
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.0
>Reporter: Andrei Tuicu
>Assignee: Simone Tripodi
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> h3. Problem
> Nodes that contain : character are put in content packages with the help of _
> , for example the following path /content/cq:tags/somenode in AEM would look
> in the content package like:
> /jcr_root/_cq_tags/somenode . This is done because Windows does not accept :
> in the name of it's files/folders.
> If the content package converter would process this path it would generate a
> the following repo:init lines
> {code}
> "create path (sling:Folder) /content/_cq_tags",
> "create path (cq:Tag) /content/_cq_tags/somenode",
> {code}
> Similar, if there are rep policies under that path, the output would look as
> following:
> {code}
> "set ACL for my-system-user",
> "allow
> jcr:versionManagement,jcr:read,rep:write,crx:replicate,jcr:lockManagement on
> /content/_cq_tags/somenode",
> {code}
> This results in the wrong node structure in the AEM instance, as follows:
> {code}
> /content
>/cq:tags### <- original AEM folder
>/_cq_tags ###<- folder created by the repoinit statements
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-8569) Detect & reports PackageTypes and nesting structures during conversion
[ https://issues.apache.org/jira/browse/SLING-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8569: -- Fix Version/s: Content-Package to Feature Model Converter 1.0.0 > Detect & reports PackageTypes and nesting structures during conversion > -- > > Key: SLING-8569 > URL: https://issues.apache.org/jira/browse/SLING-8569 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Dominik Süß >Assignee: Simone Tripodi >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.0 > > > To be able to support legacy deployment structures that mixed (initial & > permission) content and application packages with application packages the > converter should generate an analysis of the originally passed packages in a > file reporting the following information: > * For each passed file report the nesting structures (including the paths > within the hosting packages) including multilevel nesting > * For each found package & subpackage detect & report the Package Type > (Application, Mixed, Content) > ** this should be detected from scratch as the optionally declared property > is not reliable (might be a false declaration) > ** detectionlogic should follow filevault semantics > (https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AbstractExporter.java#L374-L399) > but consider the type of nested packages - the jackrabbit implementation > currently doesn't analyze subpackages but considers those as "content" as > they are defined in "/etc" > This report should allow to detect any package that (either directly or in > its nested containers) contains content (nothing in apps & libs) and indicate > the location within the original package (potentially also requiring > unpacking multiple nesting levels). > //[~simone.tripodi] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8569) Detect & reports PackageTypes and nesting structures during conversion
[ https://issues.apache.org/jira/browse/SLING-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8569: -- Affects Version/s: Content-Package to Feature Model Converter 1.0.0 > Detect & reports PackageTypes and nesting structures during conversion > -- > > Key: SLING-8569 > URL: https://issues.apache.org/jira/browse/SLING-8569 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Dominik Süß >Assignee: Simone Tripodi >Priority: Major > > To be able to support legacy deployment structures that mixed (initial & > permission) content and application packages with application packages the > converter should generate an analysis of the originally passed packages in a > file reporting the following information: > * For each passed file report the nesting structures (including the paths > within the hosting packages) including multilevel nesting > * For each found package & subpackage detect & report the Package Type > (Application, Mixed, Content) > ** this should be detected from scratch as the optionally declared property > is not reliable (might be a false declaration) > ** detectionlogic should follow filevault semantics > (https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AbstractExporter.java#L374-L399) > but consider the type of nested packages - the jackrabbit implementation > currently doesn't analyze subpackages but considers those as "content" as > they are defined in "/etc" > This report should allow to detect any package that (either directly or in > its nested containers) contains content (nothing in apps & libs) and indicate > the location within the original package (potentially also requiring > unpacking multiple nesting levels). > //[~simone.tripodi] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-8623) Add support to cpConverter to drop content-packages of PackageType.CONTENT from targetmodel
[ https://issues.apache.org/jira/browse/SLING-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi reassigned SLING-8623: - Assignee: Simone Tripodi > Add support to cpConverter to drop content-packages of PackageType.CONTENT > from targetmodel > --- > > Key: SLING-8623 > URL: https://issues.apache.org/jira/browse/SLING-8623 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Dominik Süß >Assignee: Simone Tripodi >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.0 > > > In cases where content packages are converted for scenarios with use of > CompositeNodeStore to handle the immutable content the featureModels are > supposed to only install the immutable part of the repository - therefore the > content-packages of PackageType.Content should be droppable. They anyhow > can't be omitted from scanning & parsing as the conversion of service users, > CNDs etc. into repoinit is still supposed to happen. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8623) Add support to cpConverter to drop content-packages of PackageType.CONTENT from targetmodel
[ https://issues.apache.org/jira/browse/SLING-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8623: -- Fix Version/s: Content-Package to Feature Model Converter 1.0.0 > Add support to cpConverter to drop content-packages of PackageType.CONTENT > from targetmodel > --- > > Key: SLING-8623 > URL: https://issues.apache.org/jira/browse/SLING-8623 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Dominik Süß >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.0 > > > In cases where content packages are converted for scenarios with use of > CompositeNodeStore to handle the immutable content the featureModels are > supposed to only install the immutable part of the repository - therefore the > content-packages of PackageType.Content should be droppable. They anyhow > can't be omitted from scanning & parsing as the conversion of service users, > CNDs etc. into repoinit is still supposed to happen. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8608) Fail the conversion if the resulting attached content-package is MIXED type
[ https://issues.apache.org/jira/browse/SLING-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8608: -- Affects Version/s: Content-Package to Feature Model Converter 1.0.0 > Fail the conversion if the resulting attached content-package is MIXED type > --- > > Key: SLING-8608 > URL: https://issues.apache.org/jira/browse/SLING-8608 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > > It can be prevented from deploying mixed content-package(s) via Launcher, so > users are not surprised when mutable contents are ignored. > Conversion is stopped as early as possible with the appropriate error message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8623) Add support to cpConverter to drop content-packages of PackageType.CONTENT from targetmodel
[ https://issues.apache.org/jira/browse/SLING-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8623: -- Affects Version/s: Content-Package to Feature Model Converter 1.0.0 > Add support to cpConverter to drop content-packages of PackageType.CONTENT > from targetmodel > --- > > Key: SLING-8623 > URL: https://issues.apache.org/jira/browse/SLING-8623 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Dominik Süß >Priority: Major > > In cases where content packages are converted for scenarios with use of > CompositeNodeStore to handle the immutable content the featureModels are > supposed to only install the immutable part of the repository - therefore the > content-packages of PackageType.Content should be droppable. They anyhow > can't be omitted from scanning & parsing as the conversion of service users, > CNDs etc. into repoinit is still supposed to happen. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8623) Add support to cpConverter to drop content-packages of PackageType.CONTENT from targetmodel
[
https://issues.apache.org/jira/browse/SLING-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950994#comment-16950994
]
Simone Tripodi commented on SLING-8623:
---
[~dsuess] PR is merged already in the codemase in {{master}}, can we consider
this issue as resolved?
> Add support to cpConverter to drop content-packages of PackageType.CONTENT
> from targetmodel
> ---
>
> Key: SLING-8623
> URL: https://issues.apache.org/jira/browse/SLING-8623
> Project: Sling
> Issue Type: New Feature
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.0
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.0
>
>
> In cases where content packages are converted for scenarios with use of
> CompositeNodeStore to handle the immutable content the featureModels are
> supposed to only install the immutable part of the repository - therefore the
> content-packages of PackageType.Content should be droppable. They anyhow
> can't be omitted from scanning & parsing as the conversion of service users,
> CNDs etc. into repoinit is still supposed to happen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-8626) Content Package Converter is taking Group from Package Group instead of from Maven Group
[ https://issues.apache.org/jira/browse/SLING-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8626: -- Affects Version/s: Content-Package to Feature Model Converter 1.0.0 > Content Package Converter is taking Group from Package Group instead of from > Maven Group > > > Key: SLING-8626 > URL: https://issues.apache.org/jira/browse/SLING-8626 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 > Environment: Sling 11, Java 8 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > There are two issues with the Content Package to Feature Model Converter with > respect to groups: > # If a group is set in the Content Package then this group will be used in > the Feature Id as well as for the folder where it is created > # If anything changes in the Content Package Vault properties then this will > not be reflected in the conversion on a Mac (10.14, Mojave). This is because > the deflated file remains the same and in my testing the file did not change > even though the package did. > The issue with the group is severe as the original POM file and the > 'cp2fm-converted' file are not in the same location causing issues with the > launcher at least. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8626) Content Package Converter is taking Group from Package Group instead of from Maven Group
[ https://issues.apache.org/jira/browse/SLING-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8626: -- Fix Version/s: Content-Package to Feature Model Converter 1.0.0 > Content Package Converter is taking Group from Package Group instead of from > Maven Group > > > Key: SLING-8626 > URL: https://issues.apache.org/jira/browse/SLING-8626 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 > Environment: Sling 11, Java 8 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > There are two issues with the Content Package to Feature Model Converter with > respect to groups: > # If a group is set in the Content Package then this group will be used in > the Feature Id as well as for the folder where it is created > # If anything changes in the Content Package Vault properties then this will > not be reflected in the conversion on a Mac (10.14, Mojave). This is because > the deflated file remains the same and in my testing the file did not change > even though the package did. > The issue with the group is severe as the original POM file and the > 'cp2fm-converted' file are not in the same location causing issues with the > launcher at least. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8649) Missing dependencies when installing computed content-packages
[ https://issues.apache.org/jira/browse/SLING-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8649: -- Fix Version/s: Content-Package to Feature Model Converter 1.0.0 > Missing dependencies when installing computed content-packages > -- > > Key: SLING-8649 > URL: https://issues.apache.org/jira/browse/SLING-8649 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > filtering out mutable content-packages being installed via Feature Model, it > may causes a missing dependency issue when installing related transitive > dependencies content-packages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8649) Missing dependencies when installing computed content-packages
[ https://issues.apache.org/jira/browse/SLING-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8649: -- Affects Version/s: Content-Package to Feature Model Converter 1.0.0 > Missing dependencies when installing computed content-packages > -- > > Key: SLING-8649 > URL: https://issues.apache.org/jira/browse/SLING-8649 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > filtering out mutable content-packages being installed via Feature Model, it > may causes a missing dependency issue when installing related transitive > dependencies content-packages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8752) Release CP Converter
[ https://issues.apache.org/jira/browse/SLING-8752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8752: -- Affects Version/s: Content-Package to Feature Model Converter 1.0.0 > Release CP Converter > > > Key: SLING-8752 > URL: https://issues.apache.org/jira/browse/SLING-8752 > Project: Sling > Issue Type: Task > Components: Content-Package to Feature Model Converter, Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: andysch#1 >Assignee: Simone Tripodi >Priority: Blocker > > For the Feature Model Converter Maven Plugin I need to have this module > released. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8752) Release CP Converter
[ https://issues.apache.org/jira/browse/SLING-8752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8752: -- Fix Version/s: Content-Package to Feature Model Converter 1.0.0 > Release CP Converter > > > Key: SLING-8752 > URL: https://issues.apache.org/jira/browse/SLING-8752 > Project: Sling > Issue Type: Task > Components: Content-Package to Feature Model Converter, Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.0.0 >Reporter: andysch#1 >Assignee: Simone Tripodi >Priority: Blocker > Fix For: Content-Package to Feature Model Converter 1.0.0 > > > For the Feature Model Converter Maven Plugin I need to have this module > released. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8752) Release CP Converter
[ https://issues.apache.org/jira/browse/SLING-8752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8752: -- Affects Version/s: Content-Package to Feature Model Converter 1.0.0D > Release CP Converter > > > Key: SLING-8752 > URL: https://issues.apache.org/jira/browse/SLING-8752 > Project: Sling > Issue Type: Task > Components: Content-Package to Feature Model Converter, Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.0.0D >Reporter: andysch#1 >Assignee: Simone Tripodi >Priority: Blocker > Fix For: Content-Package to Feature Model Converter > 1.0.0UNRELEASED > > > For the Feature Model Converter Maven Plugin I need to have this module > released. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8752) Release CP Converter
[ https://issues.apache.org/jira/browse/SLING-8752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8752: -- Fix Version/s: Content-Package to Feature Model Converter 1.0.0UNRELEASED > Release CP Converter > > > Key: SLING-8752 > URL: https://issues.apache.org/jira/browse/SLING-8752 > Project: Sling > Issue Type: Task > Components: Content-Package to Feature Model Converter, Feature Model >Reporter: andysch#1 >Assignee: Simone Tripodi >Priority: Blocker > Fix For: Content-Package to Feature Model Converter > 1.0.0UNRELEASED > > > For the Feature Model Converter Maven Plugin I need to have this module > released. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8752) Release CP Converter
[ https://issues.apache.org/jira/browse/SLING-8752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8752: -- Component/s: Content-Package to Feature Model Converter > Release CP Converter > > > Key: SLING-8752 > URL: https://issues.apache.org/jira/browse/SLING-8752 > Project: Sling > Issue Type: Task > Components: Content-Package to Feature Model Converter, Feature Model >Reporter: andysch#1 >Assignee: Simone Tripodi >Priority: Blocker > > For the Feature Model Converter Maven Plugin I need to have this module > released. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-8752) Release CP Converter
[ https://issues.apache.org/jira/browse/SLING-8752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi reassigned SLING-8752: - Assignee: Simone Tripodi (was: Simone Tripodi) > Release CP Converter > > > Key: SLING-8752 > URL: https://issues.apache.org/jira/browse/SLING-8752 > Project: Sling > Issue Type: Task > Components: Feature Model >Reporter: andysch#1 >Assignee: Simone Tripodi >Priority: Blocker > > For the Feature Model Converter Maven Plugin I need to have this module > released. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8760) [cp2fm] multiple node type registrations are handled as single registration
[ https://issues.apache.org/jira/browse/SLING-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8760. --- Resolution: Fixed resolved in [fb37d8d|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/fb37d8da10d549ddb7c450c869e7f5fb9f7ace99] > [cp2fm] multiple node type registrations are handled as single registration > --- > > Key: SLING-8760 > URL: https://issues.apache.org/jira/browse/SLING-8760 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > > As per subject, multiple node type registrations are handled as single > registration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8760) [cp2fm] multiple node type registrations are handled as single registration
Simone Tripodi created SLING-8760: - Summary: [cp2fm] multiple node type registrations are handled as single registration Key: SLING-8760 URL: https://issues.apache.org/jira/browse/SLING-8760 Project: Sling Issue Type: Bug Components: Content-Package to Feature Model Converter Reporter: Simone Tripodi Assignee: Simone Tripodi As per subject, multiple node type registrations are handled as single registration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8749) [cp2fm] empty configurations have to be included in the resulting Feature Model
[
https://issues.apache.org/jira/browse/SLING-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8749.
---
Resolution: Fixed
Resolved in
[e94e8de|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/e94e8de8100105dde7782c6a6238522844e6a038]
> [cp2fm] empty configurations have to be included in the resulting Feature
> Model
> ---
>
> Key: SLING-8749
> URL: https://issues.apache.org/jira/browse/SLING-8749
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Simone Tripodi
>Priority: Major
>
> Currently, empty configurations are filtered out by the converter, see
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/AbstractConfigurationEntryHandler.java#L61
> They have to be included anyway otherwise they conflict with service which
> have {{ConfigurationPolicy.REQUIRE}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-8749) [cp2fm] empty configurations have to be included in the resulting Feature Model
Simone Tripodi created SLING-8749:
-
Summary: [cp2fm] empty configurations have to be included in the
resulting Feature Model
Key: SLING-8749
URL: https://issues.apache.org/jira/browse/SLING-8749
Project: Sling
Issue Type: Improvement
Components: Content-Package to Feature Model Converter
Reporter: Simone Tripodi
Currently, empty configurations are filtered out by the converter, see
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/AbstractConfigurationEntryHandler.java#L61
They have to be included anyway otherwise they conflict with service which have
{{ConfigurationPolicy.REQUIRE}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-8716) [cp2fm] content-packages have to be handled under /apps/*/install/* path
[ https://issues.apache.org/jira/browse/SLING-8716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8716. --- Resolution: Fixed resolved in [25b43e9|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/25b43e9f53250dc9e038018cdc945d0dd26b8f5b] > [cp2fm] content-packages have to be handled under /apps/*/install/* path > > > Key: SLING-8716 > URL: https://issues.apache.org/jira/browse/SLING-8716 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > > Currently, content-packages are detected by the handler only when enlisted > under /etc/packages/, behaviour has to be extended in order to support > /apps//install/ also -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (SLING-8716) [cp2fm] content-packages have to be handled under /apps/*/install/* path
Simone Tripodi created SLING-8716: - Summary: [cp2fm] content-packages have to be handled under /apps/*/install/* path Key: SLING-8716 URL: https://issues.apache.org/jira/browse/SLING-8716 Project: Sling Issue Type: Bug Components: Content-Package to Feature Model Converter Reporter: Simone Tripodi Assignee: Simone Tripodi Currently, content-packages are detected by the handler only when enlisted under /etc/packages/, behaviour has to be extended in order to support /apps//install/ also -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (SLING-8715) Feature Model Package should listen filters metadata
[ https://issues.apache.org/jira/browse/SLING-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8715. --- Resolution: Fixed Resolved in [b7ff19f|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/b7ff19f5efff13c45c64e23e5122c5adcbe092f2] > Feature Model Package should listen filters metadata > > > Key: SLING-8715 > URL: https://issues.apache.org/jira/browse/SLING-8715 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > > The cp2fm converter scrubs filters metadata, which are valuable debugging > information. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (SLING-8715) Feature Model Package should listen filters metadata
Simone Tripodi created SLING-8715: - Summary: Feature Model Package should listen filters metadata Key: SLING-8715 URL: https://issues.apache.org/jira/browse/SLING-8715 Project: Sling Issue Type: Bug Components: Content-Package to Feature Model Converter Reporter: Simone Tripodi Assignee: Simone Tripodi The cp2fm converter scrubs filters metadata, which are valuable debugging information. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (SLING-8608) Fail the conversion if the resulting attached content-package is MIXED type
[ https://issues.apache.org/jira/browse/SLING-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8608. --- Resolution: Fixed resolved in [c673c93|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/c673c939065975fcc8a4f397e045d6ebf0f5cfb8] > Fail the conversion if the resulting attached content-package is MIXED type > --- > > Key: SLING-8608 > URL: https://issues.apache.org/jira/browse/SLING-8608 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > > It can be prevented from deploying mixed content-package(s) via Launcher, so > users are not surprised when mutable contents are ignored. > Conversion is stopped as early as possible with the appropriate error message. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (SLING-8594) Create an API Jar analyser that checks that it's transitively closed
[ https://issues.apache.org/jira/browse/SLING-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8594. --- Resolution: Won't Fix Existing Analyzer Tasks provide the same check already > Create an API Jar analyser that checks that it's transitively closed > > > Key: SLING-8594 > URL: https://issues.apache.org/jira/browse/SLING-8594 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 1.0.4 >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Fix For: Feature Model Analyser 1.1.2 > > > The APIs exposed by an APIs Jar should be transitively closed. This means > that they should not refer to APIs that are not provided by the APIs jar > itself or the Java platform. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SLING-8682) IT apis-jar-wrapped-flattened-classes fails
[ https://issues.apache.org/jira/browse/SLING-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925559#comment-16925559 ] Simone Tripodi commented on SLING-8682: --- Theoretically, there shouldn't be cases where sources directories are empty - that means that: * the MOJO was not able to checkout sources, so please have a look at the WARNING messages in the build log; * or, worst case, a region does not export any APIs: that case IMHO should be prevented during the Analyzer phase. > IT apis-jar-wrapped-flattened-classes fails > --- > > Key: SLING-8682 > URL: https://issues.apache.org/jira/browse/SLING-8682 > Project: Sling > Issue Type: Bug > Components: Maven Plugins and Archetypes >Reporter: Carsten Ziegeler >Priority: Major > Fix For: slingfeature-maven-plugin 1.1.2 > > > With the correction of subpackage handling in SLING-8681 the > apis-jar-wrapped-flattened-classes fails now. > This might be a bug in our api handling code as the javadoc command does not > get a source -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (SLING-8667) [cp2fm] -SNAPSHOT sub content-packages are not overridden when extracting them from the main package
[
https://issues.apache.org/jira/browse/SLING-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8667.
---
Resolution: Fixed
fixed in
[acc3e98|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/acc3e9825730c86bfa92cb43ba210832fae0605e]
> [cp2fm] -SNAPSHOT sub content-packages are not overridden when extracting
> them from the main package
>
>
> Key: SLING-8667
> URL: https://issues.apache.org/jira/browse/SLING-8667
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
>
> {{-SNAPSHOT}} sub content-packages are not overridden when extracting them
> from the main package, so it happens that the previous version is used when
> building the target content-package.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Created] (SLING-8667) [cp2fm] -SNAPSHOT sub content-packages are not overridden when extracting them from the main package
Simone Tripodi created SLING-8667:
-
Summary: [cp2fm] -SNAPSHOT sub content-packages are not overridden
when extracting them from the main package
Key: SLING-8667
URL: https://issues.apache.org/jira/browse/SLING-8667
Project: Sling
Issue Type: Bug
Components: Content-Package to Feature Model Converter
Reporter: Simone Tripodi
Assignee: Simone Tripodi
{{-SNAPSHOT}} sub content-packages are not overridden when extracting them from
the main package, so it happens that the previous version is used when building
the target content-package.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Resolved] (SLING-8649) Missing dependencies when installing computed content-packages
[ https://issues.apache.org/jira/browse/SLING-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8649. --- Resolution: Fixed Fix + testcase merged on _master_ > Missing dependencies when installing computed content-packages > -- > > Key: SLING-8649 > URL: https://issues.apache.org/jira/browse/SLING-8649 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > filtering out mutable content-packages being installed via Feature Model, it > may causes a missing dependency issue when installing related transitive > dependencies content-packages. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SLING-8649) Missing dependencies when installing computed content-packages
[ https://issues.apache.org/jira/browse/SLING-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913224#comment-16913224 ] Simone Tripodi commented on SLING-8649: --- Unit test included in branch > Missing dependencies when installing computed content-packages > -- > > Key: SLING-8649 > URL: https://issues.apache.org/jira/browse/SLING-8649 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > > filtering out mutable content-packages being installed via Feature Model, it > may causes a missing dependency issue when installing related transitive > dependencies content-packages. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SLING-8649) Missing dependencies when installing computed content-packages
[ https://issues.apache.org/jira/browse/SLING-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912301#comment-16912301 ] Simone Tripodi commented on SLING-8649: --- Initial fix attempt on https://github.com/apache/sling-org-apache-sling-feature-cpconverter/tree/SLING-8649 > Missing dependencies when installing computed content-packages > -- > > Key: SLING-8649 > URL: https://issues.apache.org/jira/browse/SLING-8649 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > > filtering out mutable content-packages being installed via Feature Model, it > may causes a missing dependency issue when installing related transitive > dependencies content-packages. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (SLING-8649) Missing dependencies when installing computed content-packages
Simone Tripodi created SLING-8649: - Summary: Missing dependencies when installing computed content-packages Key: SLING-8649 URL: https://issues.apache.org/jira/browse/SLING-8649 Project: Sling Issue Type: Improvement Components: Content-Package to Feature Model Converter Reporter: Simone Tripodi Assignee: Simone Tripodi filtering out mutable content-packages being installed via Feature Model, it may causes a missing dependency issue when installing related transitive dependencies content-packages. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (SLING-8608) Fail the conversion if the resulting attached content-package is MIXED type
Simone Tripodi created SLING-8608: - Summary: Fail the conversion if the resulting attached content-package is MIXED type Key: SLING-8608 URL: https://issues.apache.org/jira/browse/SLING-8608 Project: Sling Issue Type: Improvement Components: Content-Package to Feature Model Converter Reporter: Simone Tripodi Assignee: Simone Tripodi It can be prevented from deploying mixed content-package(s) via Launcher, so users are not surprised when mutable contents are ignored. Conversion is stopped as early as possible with the appropriate error message. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (SLING-8569) Detect & reports PackageTypes and nesting structures during conversion
[ https://issues.apache.org/jira/browse/SLING-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8569. --- Resolution: Fixed apologise [~cziegeler] if it was left open, yes, this issue can be marked as resolved! :) > Detect & reports PackageTypes and nesting structures during conversion > -- > > Key: SLING-8569 > URL: https://issues.apache.org/jira/browse/SLING-8569 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Dominik Süß >Assignee: Simone Tripodi >Priority: Major > > To be able to support legacy deployment structures that mixed (initial & > permission) content and application packages with application packages the > converter should generate an analysis of the originally passed packages in a > file reporting the following information: > * For each passed file report the nesting structures (including the paths > within the hosting packages) including multilevel nesting > * For each found package & subpackage detect & report the Package Type > (Application, Mixed, Content) > ** this should be detected from scratch as the optionally declared property > is not reliable (might be a false declaration) > ** detectionlogic should follow filevault semantics > (https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AbstractExporter.java#L374-L399) > but consider the type of nested packages - the jackrabbit implementation > currently doesn't analyze subpackages but considers those as "content" as > they are defined in "/etc" > This report should allow to detect any package that (either directly or in > its nested containers) contains content (nothing in apps & libs) and indicate > the location within the original package (potentially also requiring > unpacking multiple nesting levels). > //[~simone.tripodi] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-8594) Create an API Jar analyser that checks that it's transitively closed
[ https://issues.apache.org/jira/browse/SLING-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890217#comment-16890217 ] Simone Tripodi commented on SLING-8594: --- Initial implementation provided in https://github.com/apache/sling-org-apache-sling-feature-analyser/tree/SLING-8594 feature branch > Create an API Jar analyser that checks that it's transitively closed > > > Key: SLING-8594 > URL: https://issues.apache.org/jira/browse/SLING-8594 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 1.0.4 >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Fix For: Feature Model Analyser 1.0.6 > > > The APIs exposed by an APIs Jar should be transitively closed. This means > that they should refer to APIs that are not provided by the APIs jar itself > or the Java platform. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (SLING-8594) Create an API Jar analyser that checks that it's transitively closed
Simone Tripodi created SLING-8594: - Summary: Create an API Jar analyser that checks that it's transitively closed Key: SLING-8594 URL: https://issues.apache.org/jira/browse/SLING-8594 Project: Sling Issue Type: Improvement Components: Feature Model Analyser Affects Versions: Feature Model Analyser 1.0.4 Reporter: Simone Tripodi Assignee: Simone Tripodi Fix For: Feature Model Analyser 1.0.6 The APIs exposed by an APIs Jar should be transitively closed. This means that they should refer to APIs that are not provided by the APIs jar itself or the Java platform. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (SLING-8586) [cp2fm] "create service user" repoinit instruction throws javax.jcr.nodetype.ConstraintViolationException
[
https://issues.apache.org/jira/browse/SLING-8586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8586.
---
Resolution: Fixed
> [cp2fm] "create service user" repoinit instruction throws
> javax.jcr.nodetype.ConstraintViolationException
> -
>
> Key: SLING-8586
> URL: https://issues.apache.org/jira/browse/SLING-8586
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Critical
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It happens that a {{create service user ... with path ...}} like the one
> below:
> {noformat}
> "create service user replication-user with path
> /home/users/system/communities"
> {noformat}
> Throws a {{javax.jcr.nodetype.ConstraintViolationException}}:
> {noformat}
> java.lang.RuntimeException: Session.save failed:
> javax.jcr.nodetype.ConstraintViolationException: OakConstraint0001:
> /home/users/system/communities[[rep:AuthorizableFolder]]: No matching
> definition found for child node replication-user with effective type
> [sling:Folder]
> {noformat}
> I am investigating if adding an extra sentence
> {noformat}
> create path (rep:AuthorizableFolder) /home/users/system/communities}}
> {noformat}
> before creating the user could fix the {{repoinit}} execution.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (SLING-8586) [cp2fm] "create service user" repoinit instruction throws javax.jcr.nodetype.ConstraintViolationException
[
https://issues.apache.org/jira/browse/SLING-8586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890035#comment-16890035
]
Simone Tripodi commented on SLING-8586:
---
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/13
merged
> [cp2fm] "create service user" repoinit instruction throws
> javax.jcr.nodetype.ConstraintViolationException
> -
>
> Key: SLING-8586
> URL: https://issues.apache.org/jira/browse/SLING-8586
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Critical
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It happens that a {{create service user ... with path ...}} like the one
> below:
> {noformat}
> "create service user replication-user with path
> /home/users/system/communities"
> {noformat}
> Throws a {{javax.jcr.nodetype.ConstraintViolationException}}:
> {noformat}
> java.lang.RuntimeException: Session.save failed:
> javax.jcr.nodetype.ConstraintViolationException: OakConstraint0001:
> /home/users/system/communities[[rep:AuthorizableFolder]]: No matching
> definition found for child node replication-user with effective type
> [sling:Folder]
> {noformat}
> I am investigating if adding an extra sentence
> {noformat}
> create path (rep:AuthorizableFolder) /home/users/system/communities}}
> {noformat}
> before creating the user could fix the {{repoinit}} execution.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (SLING-8586) [cp2fm] "create service user" repoinit instruction throws javax.jcr.nodetype.ConstraintViolationException
[
https://issues.apache.org/jira/browse/SLING-8586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888944#comment-16888944
]
Simone Tripodi commented on SLING-8586:
---
SLING-8586 branch experimental proposal has the potential fix
> [cp2fm] "create service user" repoinit instruction throws
> javax.jcr.nodetype.ConstraintViolationException
> -
>
> Key: SLING-8586
> URL: https://issues.apache.org/jira/browse/SLING-8586
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Critical
>
> It happens that a {{create service user ... with path ...}} like the one
> below:
> {noformat}
> "create service user replication-user with path
> /home/users/system/communities"
> {noformat}
> Throws a {{javax.jcr.nodetype.ConstraintViolationException}}:
> {noformat}
> java.lang.RuntimeException: Session.save failed:
> javax.jcr.nodetype.ConstraintViolationException: OakConstraint0001:
> /home/users/system/communities[[rep:AuthorizableFolder]]: No matching
> definition found for child node replication-user with effective type
> [sling:Folder]
> {noformat}
> I am investigating if adding an extra sentence
> {noformat}
> create path (rep:AuthorizableFolder) /home/users/system/communities}}
> {noformat}
> before creating the user could fix the {{repoinit}} execution.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (SLING-8586) [cp2fm] "create service user" repoinit instruction throws javax.jcr.nodetype.ConstraintViolationException
Simone Tripodi created SLING-8586:
-
Summary: [cp2fm] "create service user" repoinit instruction throws
javax.jcr.nodetype.ConstraintViolationException
Key: SLING-8586
URL: https://issues.apache.org/jira/browse/SLING-8586
Project: Sling
Issue Type: Bug
Components: Content-Package to Feature Model Converter
Reporter: Simone Tripodi
Assignee: Simone Tripodi
It happens that a {{create service user ... with path ...}} like the one below:
{noformat}
"create service user replication-user with path /home/users/system/communities"
{noformat}
Throws a {{javax.jcr.nodetype.ConstraintViolationException}}:
{noformat}
java.lang.RuntimeException: Session.save failed:
javax.jcr.nodetype.ConstraintViolationException: OakConstraint0001:
/home/users/system/communities[[rep:AuthorizableFolder]]: No matching
definition found for child node replication-user with effective type
[sling:Folder]
{noformat}
I am investigating if adding an extra sentence
{noformat}
create path (rep:AuthorizableFolder) /home/users/system/communities}}
{noformat}
before creating the user could fix the {{repoinit}} execution.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (SLING-8583) [r2f] Lookup bundles ArtifactId in idbsnver.properties and skip the bundle 0
[
https://issues.apache.org/jira/browse/SLING-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8583.
---
Resolution: Fixed
> [r2f] Lookup bundles ArtifactId in idbsnver.properties and skip the bundle 0
> -
>
> Key: SLING-8583
> URL: https://issues.apache.org/jira/browse/SLING-8583
> Project: Sling
> Issue Type: Bug
>Affects Versions: Feature Runtime2Feature 0.0.2
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Feature Runtime2Feature 0.0.4
>
>
> As per subject, once the instance is up and running, the
> {{idbsnver.properties}} contains the {{(BundleSymbolicName,Version) ->
> ArtifactId}} mapping, which is faster to query rather than computing bundles
> GAV by reading the nested {{pom.properties}}, which can be used if not
> previously found.
> Moreover, the bundle 0 must be skipped.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (SLING-8583) [r2f] Lookup bundles ArtifactId in idbsnver.properties and skip the bundle 0
[
https://issues.apache.org/jira/browse/SLING-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885081#comment-16885081
]
Simone Tripodi commented on SLING-8583:
---
initial fix implemented in
[3e7efcb|https://github.com/apache/sling-org-apache-sling-feature-r2f/commit/3e7efcb001d31b843d45e11628152961c479666f]
> [r2f] Lookup bundles ArtifactId in idbsnver.properties and skip the bundle 0
> -
>
> Key: SLING-8583
> URL: https://issues.apache.org/jira/browse/SLING-8583
> Project: Sling
> Issue Type: Bug
>Affects Versions: Feature Runtime2Feature 0.0.2
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Feature Runtime2Feature 0.0.4
>
>
> As per subject, once the instance is up and running, the
> {{idbsnver.properties}} contains the {{(BundleSymbolicName,Version) ->
> ArtifactId}} mapping, which is faster to query rather than computing bundles
> GAV by reading the nested {{pom.properties}}, which can be used if not
> previously found.
> Moreover, the bundle 0 must be skipped.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (SLING-8583) [r2f] Lookup bundles ArtifactId in idbsnver.properties and skip the bundle 0
Simone Tripodi created SLING-8583:
-
Summary: [r2f] Lookup bundles ArtifactId in idbsnver.properties
and skip the bundle 0
Key: SLING-8583
URL: https://issues.apache.org/jira/browse/SLING-8583
Project: Sling
Issue Type: Bug
Affects Versions: Feature Runtime2Feature 0.0.2
Reporter: Simone Tripodi
Assignee: Simone Tripodi
Fix For: Feature Runtime2Feature 0.0.4
As per subject, once the instance is up and running, the
{{idbsnver.properties}} contains the {{(BundleSymbolicName,Version) ->
ArtifactId}} mapping, which is faster to query rather than computing bundles
GAV by reading the nested {{pom.properties}}, which can be used if not
previously found.
Moreover, the bundle 0 must be skipped.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (SLING-8578) Nodes which contain : are not correctly processed
[
https://issues.apache.org/jira/browse/SLING-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8578.
---
Resolution: Fixed
Assignee: Simone Tripodi
PR merged on master
> Nodes which contain : are not correctly processed
> -
>
> Key: SLING-8578
> URL: https://issues.apache.org/jira/browse/SLING-8578
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Andrei Tuicu
>Assignee: Simone Tripodi
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> h3. Problem
> Nodes that contain : character are put in content packages with the help of _
> , for example the following path /content/cq:tags/somenode in AEM would look
> in the content package like:
> /jcr_root/_cq_tags/somenode . This is done because Windows does not accept :
> in the name of it's files/folders.
> If the content package converter would process this path it would generate a
> the following repo:init lines
> {code}
> "create path (sling:Folder) /content/_cq_tags",
> "create path (cq:Tag) /content/_cq_tags/somenode",
> {code}
> Similar, if there are rep policies under that path, the output would look as
> following:
> {code}
> "set ACL for my-system-user",
> "allow
> jcr:versionManagement,jcr:read,rep:write,crx:replicate,jcr:lockManagement on
> /content/_cq_tags/somenode",
> {code}
> This results in the wrong node structure in the AEM instance, as follows:
> {code}
> /content
>/cq:tags### <- original AEM folder
>/_cq_tags ###<- folder created by the repoinit statements
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (SLING-8580) [feature-diff] exclude 'service.pid' and 'service.factoryPid' OSGi configurations keys from comparison, which creates false positive diff
[ https://issues.apache.org/jira/browse/SLING-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8580. --- Resolution: Fixed fixed in [3e7bc10|https://github.com/apache/sling-org-apache-sling-feature-diff/commit/3e7bc1089727990ece0cacad3a8fae35da957225] > [feature-diff] exclude 'service.pid' and 'service.factoryPid' OSGi > configurations keys from comparison, which creates false positive diff > - > > Key: SLING-8580 > URL: https://issues.apache.org/jira/browse/SLING-8580 > Project: Sling > Issue Type: Bug >Affects Versions: Feature Diff 0.0.2 >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Fix For: Feature Diff 0.0.4 > > > As per subject, 'service.pid' and 'service.factoryPid' OSGi configurations > keys lead the comparator creating false positive differences -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (SLING-8579) [feature-diff] ServiceLoader does not correctly load comparators in OSGi environment
[ https://issues.apache.org/jira/browse/SLING-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8579: -- Affects Version/s: Feature Diff 0.0.2 > [feature-diff] ServiceLoader does not correctly load comparators in OSGi > environment > > > Key: SLING-8579 > URL: https://issues.apache.org/jira/browse/SLING-8579 > Project: Sling > Issue Type: Bug >Affects Versions: Feature Diff 0.0.2 >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Fix For: Feature Diff 0.0.4 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (SLING-8580) [feature-diff] exclude 'service.pid' and 'service.factoryPid' OSGi configurations keys from comparison, which creates false positive diff
Simone Tripodi created SLING-8580: - Summary: [feature-diff] exclude 'service.pid' and 'service.factoryPid' OSGi configurations keys from comparison, which creates false positive diff Key: SLING-8580 URL: https://issues.apache.org/jira/browse/SLING-8580 Project: Sling Issue Type: Bug Affects Versions: Feature Diff 0.0.2 Reporter: Simone Tripodi Assignee: Simone Tripodi Fix For: Feature Diff 0.0.4 As per subject, 'service.pid' and 'service.factoryPid' OSGi configurations keys lead the comparator creating false positive differences -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (SLING-8579) [feature-diff] ServiceLoader does not correctly load comparators in OSGi environment
[ https://issues.apache.org/jira/browse/SLING-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8579. --- Resolution: Fixed fixed in [82f4a63|https://github.com/apache/sling-org-apache-sling-feature-diff/commit/82f4a63025bf8117bc898b852dd0e67626130c45] > [feature-diff] ServiceLoader does not correctly load comparators in OSGi > environment > > > Key: SLING-8579 > URL: https://issues.apache.org/jira/browse/SLING-8579 > Project: Sling > Issue Type: Bug >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Fix For: Feature Diff 0.0.4 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (SLING-8579) [feature-diff] ServiceLoader does not correctly load comparators in OSGi environment
Simone Tripodi created SLING-8579: - Summary: [feature-diff] ServiceLoader does not correctly load comparators in OSGi environment Key: SLING-8579 URL: https://issues.apache.org/jira/browse/SLING-8579 Project: Sling Issue Type: Bug Reporter: Simone Tripodi Assignee: Simone Tripodi Fix For: Feature Diff 0.0.4 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-8569) Detect & reports PackageTypes and nesting structures during conversion
[
https://issues.apache.org/jira/browse/SLING-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883793#comment-16883793
]
Simone Tripodi commented on SLING-8569:
---
branch is up-to-date with rebased {{master}}
> Detect & reports PackageTypes and nesting structures during conversion
> --
>
> Key: SLING-8569
> URL: https://issues.apache.org/jira/browse/SLING-8569
> Project: Sling
> Issue Type: New Feature
> Components: Content-Package to Feature Model Converter
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Major
>
> To be able to support legacy deployment structures that mixed (initial &
> permission) content and application packages with application packages the
> converter should generate an analysis of the originally passed packages in a
> file reporting the following information:
> * For each passed file report the nesting structures (including the paths
> within the hosting packages) including multilevel nesting
> * For each found package & subpackage detect & report the Package Type
> (Application, Mixed, Content)
> ** this should be detected from scratch as the optionally declared property
> is not reliable (might be a false declaration)
> ** detectionlogic should follow filevault semantics
> (https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AbstractExporter.java#L374-L399)
> but consider the type of nested packages - the jackrabbit implementation
> currently doesn't analyze subpackages but considers those as "content" as
> they are defined in "/etc"
> This report should allow to detect any package that (either directly or in
> its nested containers) contains content (nothing in apps & libs) and indicate
> the location within the original package (potentially also requiring
> unpacking multiple nesting levels).
> //[~simone.tripodi]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (SLING-8573) ACLs are missing from the converted content packages for regular users and groups
[ https://issues.apache.org/jira/browse/SLING-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8573. --- Resolution: Fixed Working as describing in latest comment > ACLs are missing from the converted content packages for regular users and > groups > - > > Key: SLING-8573 > URL: https://issues.apache.org/jira/browse/SLING-8573 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Andrei Tuicu >Assignee: Simone Tripodi >Priority: Major > > ACLs are missing from the converted content packages for regular users and > groups. > All "_rep_policy" nodes are removed by the converter from the resulting > content package and in the repoinit section of the JSON output there are only > the ACLs for service users. > We should either: > * Add the ACLs in the repo init for all users, groups, system users, or > * Don't remove the "_rep_policy" nodes from the resulting content package -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-8573) ACLs are missing from the converted content packages for regular users and groups
[
https://issues.apache.org/jira/browse/SLING-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883134#comment-16883134
]
Simone Tripodi commented on SLING-8573:
---
Since {{_rep_policy.xml}} files can potentially contain ACLs for both
system/user/group, the 2-phases scan will detect all system users in the first
phase, then all system-users related ACLs will be moved in the {{repoinit}}
section of the generated Feature model, all other ACLs will be filtered and
preserved in the original files.
> ACLs are missing from the converted content packages for regular users and
> groups
> -
>
> Key: SLING-8573
> URL: https://issues.apache.org/jira/browse/SLING-8573
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Andrei Tuicu
>Assignee: Simone Tripodi
>Priority: Major
>
> ACLs are missing from the converted content packages for regular users and
> groups.
> All "_rep_policy" nodes are removed by the converter from the resulting
> content package and in the repoinit section of the JSON output there are only
> the ACLs for service users.
> We should either:
> * Add the ACLs in the repo init for all users, groups, system users, or
> * Don't remove the "_rep_policy" nodes from the resulting content package
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (SLING-8573) ACLs are missing from the converted content packages for regular users and groups
[ https://issues.apache.org/jira/browse/SLING-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883133#comment-16883133 ] Simone Tripodi commented on SLING-8573: --- improvement pushed in [cb03166|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/cb03166805d884549b27a02ab71e1b51eeaa4aef] > ACLs are missing from the converted content packages for regular users and > groups > - > > Key: SLING-8573 > URL: https://issues.apache.org/jira/browse/SLING-8573 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Andrei Tuicu >Assignee: Simone Tripodi >Priority: Major > > ACLs are missing from the converted content packages for regular users and > groups. > All "_rep_policy" nodes are removed by the converter from the resulting > content package and in the repoinit section of the JSON output there are only > the ACLs for service users. > We should either: > * Add the ACLs in the repo init for all users, groups, system users, or > * Don't remove the "_rep_policy" nodes from the resulting content package -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (SLING-8573) ACLs are missing from the converted content packages for regular users and groups
[ https://issues.apache.org/jira/browse/SLING-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi reassigned SLING-8573: - Assignee: Simone Tripodi > ACLs are missing from the converted content packages for regular users and > groups > - > > Key: SLING-8573 > URL: https://issues.apache.org/jira/browse/SLING-8573 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Andrei Tuicu >Assignee: Simone Tripodi >Priority: Major > > ACLs are missing from the converted content packages for regular users and > groups. > All "_rep_policy" nodes are removed by the converter from the resulting > content package and in the repoinit section of the JSON output there are only > the ACLs for service users. > We should either: > * Add the ACLs in the repo init for all users, groups, system users, or > * Don't remove the "_rep_policy" nodes from the resulting content package -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-8573) ACLs are missing from the converted content packages for regular users and groups
[ https://issues.apache.org/jira/browse/SLING-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882816#comment-16882816 ] Simone Tripodi commented on SLING-8573: --- Initial implementation pushed in [4008a61|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/4008a61c7068e6a6eb69c2e69ea65a4a642c2a01] > ACLs are missing from the converted content packages for regular users and > groups > - > > Key: SLING-8573 > URL: https://issues.apache.org/jira/browse/SLING-8573 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Andrei Tuicu >Priority: Major > > ACLs are missing from the converted content packages for regular users and > groups. > All "_rep_policy" nodes are removed by the converter from the resulting > content package and in the repoinit section of the JSON output there are only > the ACLs for service users. > We should either: > * Add the ACLs in the repo init for all users, groups, system users, or > * Don't remove the "_rep_policy" nodes from the resulting content package -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-8569) Detect & reports PackageTypes and nesting structures during conversion
[
https://issues.apache.org/jira/browse/SLING-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881929#comment-16881929
]
Simone Tripodi commented on SLING-8569:
---
The output will be stored in the
{{/content-packages.csv}} file and, as shown in
the test, output will be a CSV in the format below:
{noformat}
# File created on Wed Jul 10 11:58:54 CEST 2019 by the Apache Sling Content
Package to Sling Feature converter
# content-package path, content-package ID, content-package type,
content-package parent ID, path in parent content-package, absolute path
/org/apache/sling/content-package.zip,apache/sling:parent:1.0.0,MIXED,,,
/org/apache/sling/content-package.zip,apache/sling:content-child:1.0.0,CONTENT,apache/sling:parent:1.0.0,/jcr_root/etc/packages/org/apache/sling/content-child-1.0.zip,/org/apache/sling/content-package.zip!/jcr_root/etc/packages/org/apache/sling/content-child-1.0.zip
/org/apache/sling/content-package.zip,apache/sling:application-child:1.0.0,APPLICATION,apache/sling:parent:1.0.0,/jcr_root/etc/packages/org/apache/sling/application-child-1.0.zip,/org/apache/sling/content-package.zip!/jcr_root/etc/packages/org/apache/sling/application-child-1.0.zip
/org/apache/sling/content-package.zip,apache/sling:nested-child:1.0.0,CONTAINER,apache/sling:application-child:1.0.0,/jcr_root/etc/packages/org/apache/sling/nested-child-1.0.zip,/org/apache/sling/content-package.zip!/jcr_root/etc/packages/org/apache/sling/application-child-1.0.zip!/jcr_root/etc/packages/org/apache/sling/nested-child-1.0.zip
{noformat}
Like for Java classpath resources, the {{!}} character will split nested
content-packages
> Detect & reports PackageTypes and nesting structures during conversion
> --
>
> Key: SLING-8569
> URL: https://issues.apache.org/jira/browse/SLING-8569
> Project: Sling
> Issue Type: New Feature
> Components: Content-Package to Feature Model Converter
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Major
>
> To be able to support legacy deployment structures that mixed (initial &
> permission) content and application packages with application packages the
> converter should generate an analysis of the originally passed packages in a
> file reporting the following information:
> * For each passed file report the nesting structures (including the paths
> within the hosting packages) including multilevel nesting
> * For each found package & subpackage detect & report the Package Type
> (Application, Mixed, Content)
> ** this should be detected from scratch as the optionally declared property
> is not reliable (might be a false declaration)
> ** detectionlogic should follow filevault semantics
> (https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AbstractExporter.java#L374-L399)
> but consider the type of nested packages - the jackrabbit implementation
> currently doesn't analyze subpackages but considers those as "content" as
> they are defined in "/etc"
> This report should allow to detect any package that (either directly or in
> its nested containers) contains content (nothing in apps & libs) and indicate
> the location within the original package (potentially also requiring
> unpacking multiple nesting levels).
> //[~simone.tripodi]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8569) Detect & reports PackageTypes and nesting structures during conversion
[ https://issues.apache.org/jira/browse/SLING-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881266#comment-16881266 ] Simone Tripodi commented on SLING-8569: --- [~dsuess] initial implementation on https://github.com/apache/sling-org-apache-sling-feature-cpconverter/tree/SLING-8569 feature branch > Detect & reports PackageTypes and nesting structures during conversion > -- > > Key: SLING-8569 > URL: https://issues.apache.org/jira/browse/SLING-8569 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Dominik Süß >Assignee: Simone Tripodi >Priority: Major > > To be able to support legacy deployment structures that mixed (initial & > permission) content and application packages with application packages the > converter should generate an analysis of the originally passed packages in a > file reporting the following information: > * For each passed file report the nesting structures (including the paths > within the hosting packages) including multilevel nesting > * For each found package & subpackage detect & report the Package Type > (Application, Mixed, Content) > ** this should be detected from scratch as the optionally declared property > is not reliable (might be a false declaration) > ** detectionlogic should follow filevault semantics > (https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AbstractExporter.java#L374-L399) > but consider the type of nested packages - the jackrabbit implementation > currently doesn't analyze subpackages but considers those as "content" as > they are defined in "/etc" > This report should allow to detect any package that (either directly or in > its nested containers) contains content (nothing in apps & libs) and indicate > the location within the original package (potentially also requiring > unpacking multiple nesting levels). > //[~simone.tripodi] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-8569) Detect & reports PackageTypes and nesting structures during conversion
[ https://issues.apache.org/jira/browse/SLING-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi reassigned SLING-8569: - Assignee: Simone Tripodi > Detect & reports PackageTypes and nesting structures during conversion > -- > > Key: SLING-8569 > URL: https://issues.apache.org/jira/browse/SLING-8569 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Dominik Süß >Assignee: Simone Tripodi >Priority: Major > > To be able to support legacy deployment structures that mixed (initial & > permission) content and application packages with application packages the > converter should generate an analysis of the originally passed packages in a > file reporting the following information: > * For each passed file report the nesting structures (including the paths > within the hosting packages) including multilevel nesting > * For each found package & subpackage detect & report the Package Type > (Application, Mixed, Content) > ** this should be detected from scratch as the optionally declared property > is not reliable (might be a false declaration) > ** detectionlogic should follow filevault semantics > (https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AbstractExporter.java#L374-L399) > but consider the type of nested packages - the jackrabbit implementation > currently doesn't analyze subpackages but considers those as "content" as > they are defined in "/etc" > This report should allow to detect any package that (either directly or in > its nested containers) contains content (nothing in apps & libs) and indicate > the location within the original package (potentially also requiring > unpacking multiple nesting levels). > //[~simone.tripodi] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8468) [slingfeature-m-p] donate a new MOJO which is able to scan and detect differences between different versions of the same Feature model
[
https://issues.apache.org/jira/browse/SLING-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8468.
---
Resolution: Fixed
PR https://github.com/apache/sling-slingfeature-maven-plugin/pull/32 merged
> [slingfeature-m-p] donate a new MOJO which is able to scan and detect
> differences between different versions of the same Feature model
> --
>
> Key: SLING-8468
> URL: https://issues.apache.org/jira/browse/SLING-8468
> Project: Sling
> Issue Type: New Feature
> Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.0.2
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.6
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I would like to donate a new {{features-diff}} MOJO I developed in the spare
> time that could be helpful detecting systems evolution.
> I got inspiration from my previous contribution of the [Felix
> Baseline|https://felix.apache.org/components/bundle-plugin/baseline-mojo.html]
> MOJO, users can configure the feature selection (inherited by the
> {{AbstractIncludingFeatureMojo}}) and the previously released version of the
> they are interested comparing, i.e.:
> {noformat}
>
> org.apache.sling
> slingfeature-maven-plugin
>
>
> features-diff
> package
>
> features-diff
>
>
> 1.0.2
>
> cloud-ready
> base
>
> {noformat}
> then the plugin will take care of resolving the configured version of
> selected classified Feature and compare each other, producing the outputs in
> the {{target/features-diff/.diff.json}} files, enlisting for each
> Feature section what was added/removed/changed.
> The new MOJO relies on the [Feature Model API Regions
> model|https://github.com/apache/sling-org-apache-sling-feature-apiregions-model]
> and the [Feature
> Diff|https://github.com/apache/sling-whiteboard/tree/master/feature-diff]
> (still in the whiteboard) which contains the core implementation of the diff
> tool.
> I will start pushing the MOJO in a separated branch in order to discuss the
> development evolution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8561) ACLs on service users should be ignored because of randomised node names
[
https://issues.apache.org/jira/browse/SLING-8561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8561.
---
Resolution: Fixed
Fixed in
[937c5fd|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/937c5fd01152e2fa27b65da06502b7a2cf6fe0dd]
> ACLs on service users should be ignored because of randomised node names
>
>
> Key: SLING-8561
> URL: https://issues.apache.org/jira/browse/SLING-8561
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Christophe Jelger
>Assignee: Simone Tripodi
>Priority: Blocker
>
> The creation of service users via reponit creates randomised node names, for
> example, something like
> {code:java}
> /home/users/system/communities/7w6ebrYBWEGY5r5cHQ-E
> [social-enablement-replication-user]
> {code}
> This means than ACLs cannot be set later on that node name if the content
> package tries to set some ACLs on
> {code:java}
> /home/users/system/communities/social-enablement-replication-user
> {code}
> This means that we should currently ignore ACLs for service users, that is,
> nodes with primary type {{rep:SystemUser}} like.
> Which means in the repoinit section, the following 2 lines should for example
> be removed:
> {code:java}
> create path (sling:Folder)
> /home/users/system/communities/social-enablement-replication-user
> allow jcr:all on
> /home/users/system/communities/social-enablement-replication-user
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-8561) ACLs on service users should be ignored because of randomised node names
[
https://issues.apache.org/jira/browse/SLING-8561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi reassigned SLING-8561:
-
Assignee: Simone Tripodi
> ACLs on service users should be ignored because of randomised node names
>
>
> Key: SLING-8561
> URL: https://issues.apache.org/jira/browse/SLING-8561
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Christophe Jelger
>Assignee: Simone Tripodi
>Priority: Blocker
>
> The creation of service users via reponit creates randomised node names, for
> example, something like
> {code:java}
> /home/users/system/communities/7w6ebrYBWEGY5r5cHQ-E
> [social-enablement-replication-user]
> {code}
> This means than ACLs cannot be set later on that node name if the content
> package tries to set some ACLs on
> {code:java}
> /home/users/system/communities/social-enablement-replication-user
> {code}
> This means that we should currently ignore ACLs for service users, that is,
> nodes with primary type {{rep:SystemUser}} like for example
> [https://git.corp.adobe.com/CQ/social-enablement/blob/master/content/jcr_root/home/users/system/communities/social-enablement-replication-user/.content.xml]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8529) Avoid flattening of subpackages during convertion in featuremodel
[
https://issues.apache.org/jira/browse/SLING-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8529.
---
Resolution: Fixed
Feature branch merged to {{master}}
> Avoid flattening of subpackages during convertion in featuremodel
> -
>
> Key: SLING-8529
> URL: https://issues.apache.org/jira/browse/SLING-8529
> Project: Sling
> Issue Type: New Feature
> Components: Content-Package to Feature Model Converter
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> During testing of various valid scenarios it became apparent that certain
> dependency scenarios for nested subpackages might start failing. If packages
> start to depend on each other or even deeper nested packages depend on each
> other we currently do not preserve the right order when flattening).
> Instead the subpackages should be extracted (like bundles) and the implicit
> dependency to the (converted) parent package be made explicit (add dependency
> if not already existing.
> The solution would mean:
> * subpackages are extracted from the package and no longer handled as
> subpackages
> * the subpackages get an additional explicit dependency on the parent
> package (that was previously implicitly present)
> * the feature model contains all the converted packages and subpackages
> instead of a flattened one
> * converted package and converted subpackages end up in the defined cache
> folder
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8555) Converter generates broken repoinit statements when package contains type indicators for restriction
[
https://issues.apache.org/jira/browse/SLING-8555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877626#comment-16877626
]
Simone Tripodi commented on SLING-8555:
---
[~dsuess] fixed in
[de4d29a|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/de4d29a16b5dd9bab3e25084356eeb26b3105d05]
> Converter generates broken repoinit statements when package contains type
> indicators for restriction
>
>
> Key: SLING-8555
> URL: https://issues.apache.org/jira/browse/SLING-8555
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Karl Pauls
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Feature Model Converter 1.0.6
>
>
> The converter is generating a broken repoinit statement when a package
> contains type indicators for restrictions on an acl e.g.:
> {noformat}
> allow jcr:read on /home/users/system/foo
> restriction(rep:ntNames,{Name}[rep:AuthorizableFolder])
> {noformat}
> it should look something like:
> {noformat}
> allow jcr:read on /home/users/system/foo
> restriction(rep:ntNames,rep:AuthorizableFolder)
> {noformat}
> It looks like the conversion is taking the XML from vault directly. That
> needs to be translated to the right format first i.e., {noformat}
> {TYPE}[] -> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8528) ACLs for Serviceusers on nodes with nodetypes registered via content-package may break startup in repoinit.
[
https://issues.apache.org/jira/browse/SLING-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8528.
---
Resolution: Fixed
current codebase validated
> ACLs for Serviceusers on nodes with nodetypes registered via content-package
> may break startup in repoinit.
> ---
>
> Key: SLING-8528
> URL: https://issues.apache.org/jira/browse/SLING-8528
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Major
>
> If a content-package contains a CND with a new nodetype these nodetypes are
> processed and registered before the content is being installed. The CP to
> featuremodel converter creates paths for nodes on which ACLS for serviceusers
> are registered. These nodes may be created based on nodetypes defined in the
> own or another content-package it depends on.
> As repoinit is executed ahead of content-package installation the execution
> of repoinit may fail with {{javax.jcr.nodetype.NoSuchNodeTypeException: Node
> type my:NodeType does not exist}}
> To eliminate this problem altogether the converter should extract all node
> type definitions found in content-packages and registere via repoinit (see
> register nodetype section in
> https://sling.apache.org/documentation/bundles/repository-initialization.html)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-8542) Generate feature model from running instance
[ https://issues.apache.org/jira/browse/SLING-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8542: -- Fix Version/s: Feature Runtime2Feature 0.0.2 > Generate feature model from running instance > > > Key: SLING-8542 > URL: https://issues.apache.org/jira/browse/SLING-8542 > Project: Sling > Issue Type: New Feature > Components: Feature InventoryPrinters >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Fix For: Feature Runtime2Feature 0.0.2, Feature InventoryPrinter > 1.0.2 > > Time Spent: 20m > Remaining Estimate: 0h > > It would be very useful to have a running instance report the actual Feature > Model constructed from the what is really running in it. > Promoted bundles > * https://github.com/apache/sling-org-apache-sling-feature-diff > * https://github.com/apache/sling-org-apache-sling-feature-r2f > Can be used to meet this need -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8542) Generate feature model from running instance
[ https://issues.apache.org/jira/browse/SLING-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8542. --- Resolution: Fixed new InventoryPrinters are actually under release VOTE > Generate feature model from running instance > > > Key: SLING-8542 > URL: https://issues.apache.org/jira/browse/SLING-8542 > Project: Sling > Issue Type: New Feature > Components: Feature InventoryPrinters >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Fix For: Feature InventoryPrinter 1.0.2 > > Time Spent: 20m > Remaining Estimate: 0h > > It would be very useful to have a running instance report the actual Feature > Model constructed from the what is really running in it. > Promoted bundles > * https://github.com/apache/sling-org-apache-sling-feature-diff > * https://github.com/apache/sling-org-apache-sling-feature-r2f > Can be used to meet this need -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8542) Generate feature model from running instance
[ https://issues.apache.org/jira/browse/SLING-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8542: -- Fix Version/s: Feature InventoryPrinter 1.0.2 > Generate feature model from running instance > > > Key: SLING-8542 > URL: https://issues.apache.org/jira/browse/SLING-8542 > Project: Sling > Issue Type: New Feature > Components: Feature InventoryPrinters >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Fix For: Feature InventoryPrinter 1.0.2 > > Time Spent: 20m > Remaining Estimate: 0h > > It would be very useful to have a running instance report the actual Feature > Model constructed from the what is really running in it. > Promoted bundles > * https://github.com/apache/sling-org-apache-sling-feature-diff > * https://github.com/apache/sling-org-apache-sling-feature-r2f > Can be used to meet this need -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8544) [cp2fm] service users need to be created with intermediate path
[
https://issues.apache.org/jira/browse/SLING-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8544.
---
Resolution: Fixed
fixed in
[d934281|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/d934281c8a616f1fcf12728984751c723cd7f5cf]
> [cp2fm] service users need to be created with intermediate path
> ---
>
> Key: SLING-8544
> URL: https://issues.apache.org/jira/browse/SLING-8544
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
>
> Simply, the statement that creates the service user requires the relative
> subpath for the service user, it is needed to extract the path of the service
> users definitions extracted from content packages, and make sure this is
> added to {{create service user XXX with path /...}} where the path is a
> subfolder of {{/home/users/system}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8555) Converter generates broken repoinit statements when package contains type indicators for restriction
[
https://issues.apache.org/jira/browse/SLING-8555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8555.
---
Resolution: Fixed
Fix Version/s: Feature Model Converter 1.0.6
Fixed in
[b6af63e|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/b6af63e57937c77c380fdf94ca8c9ba00f2c607a]
> Converter generates broken repoinit statements when package contains type
> indicators for restriction
>
>
> Key: SLING-8555
> URL: https://issues.apache.org/jira/browse/SLING-8555
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Karl Pauls
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Feature Model Converter 1.0.6
>
>
> The converter is generating a broken repoinit statement when a package
> contains type indicators for restrictions on an acl e.g.:
> {noformat}
> allow jcr:read on /home/users/system/foo
> restriction(rep:ntNames,{Name}[rep:AuthorizableFolder])
> {noformat}
> it should look something like:
> {noformat}
> allow jcr:read on /home/users/system/foo
> restriction(rep:ntNames,rep:AuthorizableFolder)
> {noformat}
> It looks like the conversion is taking the XML from vault directly. That
> needs to be translated to the right format first i.e., {noformat}
> {TYPE}[] -> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (SLING-8544) [cp2fm] service users need to be created with intermediate path
[
https://issues.apache.org/jira/browse/SLING-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi reopened SLING-8544:
---
> [cp2fm] service users need to be created with intermediate path
> ---
>
> Key: SLING-8544
> URL: https://issues.apache.org/jira/browse/SLING-8544
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
> Fix For: Feature Model Converter 1.0.6
>
>
> Simply, the statement that creates the service user requires the relative
> subpath for the service user, it is needed to extract the path of the service
> users definitions extracted from content packages, and make sure this is
> added to {{create service user XXX with path /...}} where the path is a
> subfolder of {{/home/users/system}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8544) [cp2fm] service users need to be created with intermediate path
[
https://issues.apache.org/jira/browse/SLING-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8544.
---
Resolution: Fixed
resolved in
[9bcd28c|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/9bcd28cbc52127264086e17cb59e306333b9fc85]
> [cp2fm] service users need to be created with intermediate path
> ---
>
> Key: SLING-8544
> URL: https://issues.apache.org/jira/browse/SLING-8544
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
>
> Simply, the statement that creates the service user requires the relative
> subpath for the service user, it is needed to extract the path of the service
> users definitions extracted from content packages, and make sure this is
> added to {{create service user XXX with path /...}} where the path is a
> subfolder of {{/home/users/system}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-8544) [cp2fm] service users need to be created with intermediate path
Simone Tripodi created SLING-8544:
-
Summary: [cp2fm] service users need to be created with
intermediate path
Key: SLING-8544
URL: https://issues.apache.org/jira/browse/SLING-8544
Project: Sling
Issue Type: Bug
Components: Content-Package to Feature Model Converter
Reporter: Simone Tripodi
Assignee: Simone Tripodi
Simply, the statement that creates the service user requires the relative
subpath for the service user, it is needed to extract the path of the service
users definitions extracted from content packages, and make sure this is added
to {{create service user XXX with path /...}} where the path is a subfolder of
{{/home/users/system}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-8542) Generate feature model from running AEM instance
Simone Tripodi created SLING-8542: - Summary: Generate feature model from running AEM instance Key: SLING-8542 URL: https://issues.apache.org/jira/browse/SLING-8542 Project: Sling Issue Type: New Feature Components: Feature InventoryPrinters Reporter: Simone Tripodi Assignee: Simone Tripodi It would be very useful to have a running instance report the actual Feature Model constructed from the what is really running in it. Promoted bundles * https://github.com/apache/sling-org-apache-sling-feature-diff * https://github.com/apache/sling-org-apache-sling-feature-r2f Can be used to meet this need -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8540) ACL permissions from jcr_root are not correctly serialised
[
https://issues.apache.org/jira/browse/SLING-8540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8540.
---
Resolution: Fixed
Assignee: Simone Tripodi
Resolved in
[43ee3c0|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/43ee3c0833c9c22786c708239e82a670b2472e6c]
> ACL permissions from jcr_root are not correctly serialised
> --
>
> Key: SLING-8540
> URL: https://issues.apache.org/jira/browse/SLING-8540
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Andrei Tuicu
>Assignee: Simone Tripodi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> h3. Problem
> ACL permissions from jcr_root are not correctly serialised in the repoinit
> section, which causes AEM to fail to start. The path is missing from the
> definition.
> h3. Actual
> {code}
> ...
> "set ACL for myuser",
> "allow jcr:read on ",
> "end",
> ...
> {code}
> h3. Expected
> {code}
> ...
> "set ACL for myuser",
> "allow jcr:read on /",
> "end",
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-8536) /jcr_root/rep:policy node is not being processed by the CP- FM converter
[ https://issues.apache.org/jira/browse/SLING-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi reassigned SLING-8536: - Assignee: Simone Tripodi > /jcr_root/rep:policy node is not being processed by the CP- FM converter > > > Key: SLING-8536 > URL: https://issues.apache.org/jira/browse/SLING-8536 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Andrei Tuicu >Assignee: Simone Tripodi >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > h3. Problem > /jcr_root/rep:policy nodes is not processed due to the filter regex. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8536) /jcr_root/rep:policy node is not being processed by the CP- FM converter
[ https://issues.apache.org/jira/browse/SLING-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8536. --- Resolution: Fixed PR merged, thanks a lot Andrei! > /jcr_root/rep:policy node is not being processed by the CP- FM converter > > > Key: SLING-8536 > URL: https://issues.apache.org/jira/browse/SLING-8536 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Andrei Tuicu >Assignee: Simone Tripodi >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > h3. Problem > /jcr_root/rep:policy nodes is not processed due to the filter regex. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (SLING-8528) ACLs for Serviceusers on nodes with nodetypes registered via content-package may break startup in repoinit.
[
https://issues.apache.org/jira/browse/SLING-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi updated SLING-8528:
--
Comment: was deleted
(was: added the ability to detect namespaces and register them in
[e2a849c|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/e2a849caaf29e873b747822b5ddd257d4947d83d])
> ACLs for Serviceusers on nodes with nodetypes registered via content-package
> may break startup in repoinit.
> ---
>
> Key: SLING-8528
> URL: https://issues.apache.org/jira/browse/SLING-8528
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Major
>
> If a content-package contains a CND with a new nodetype these nodetypes are
> processed and registered before the content is being installed. The CP to
> featuremodel converter creates paths for nodes on which ACLS for serviceusers
> are registered. These nodes may be created based on nodetypes defined in the
> own or another content-package it depends on.
> As repoinit is executed ahead of content-package installation the execution
> of repoinit may fail with {{javax.jcr.nodetype.NoSuchNodeTypeException: Node
> type my:NodeType does not exist}}
> To eliminate this problem altogether the converter should extract all node
> type definitions found in content-packages and registere via repoinit (see
> register nodetype section in
> https://sling.apache.org/documentation/bundles/repository-initialization.html)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8528) ACLs for Serviceusers on nodes with nodetypes registered via content-package may break startup in repoinit.
[
https://issues.apache.org/jira/browse/SLING-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872369#comment-16872369
]
Simone Tripodi commented on SLING-8528:
---
added the ability to detect namespaces and register them in
[e2a849c|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/e2a849caaf29e873b747822b5ddd257d4947d83d]
> ACLs for Serviceusers on nodes with nodetypes registered via content-package
> may break startup in repoinit.
> ---
>
> Key: SLING-8528
> URL: https://issues.apache.org/jira/browse/SLING-8528
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Major
>
> If a content-package contains a CND with a new nodetype these nodetypes are
> processed and registered before the content is being installed. The CP to
> featuremodel converter creates paths for nodes on which ACLS for serviceusers
> are registered. These nodes may be created based on nodetypes defined in the
> own or another content-package it depends on.
> As repoinit is executed ahead of content-package installation the execution
> of repoinit may fail with {{javax.jcr.nodetype.NoSuchNodeTypeException: Node
> type my:NodeType does not exist}}
> To eliminate this problem altogether the converter should extract all node
> type definitions found in content-packages and registere via repoinit (see
> register nodetype section in
> https://sling.apache.org/documentation/bundles/repository-initialization.html)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8529) Avoid flattening of subpackages during convertion in featuremodel
[ https://issues.apache.org/jira/browse/SLING-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872350#comment-16872350 ] Simone Tripodi commented on SLING-8529: --- the [avoid_subpackages_flattering|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/tree/avoid_subpackages_flattering] branch is ready to be reviewed > Avoid flattening of subpackages during convertion in featuremodel > - > > Key: SLING-8529 > URL: https://issues.apache.org/jira/browse/SLING-8529 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > During testing of various valid scenarios it became apparent that certain > dependency scenarios for nested subpackages might start failing. If packages > start to depend on each other or even deeper nested packages depend on each > other we currently do not preserve the right order when flattening). > Instead the subpackages should be extracted (like bundles) and the implicit > dependency to the (converted) parent package be made explicit (add dependency > if not already existing. > The solution would mean: > * subpackages are extracted from the package and no longer handled as > subpackages > * the subpackages get an additional explicit dependency on the parent > package (that was previously implicitly present) > * the feature model contains all the converted packages and subpackages > instead of a flattened one > * converted package and converted subpackages end up in the defined cache > folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8529) Avoid flattening of subpackages during convertion in featuremodel
[ https://issues.apache.org/jira/browse/SLING-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872312#comment-16872312 ] Simone Tripodi commented on SLING-8529: --- an initial version is implemented in the [avoid_subpackages_flattering|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/tree/avoid_subpackages_flattering] branch > Avoid flattening of subpackages during convertion in featuremodel > - > > Key: SLING-8529 > URL: https://issues.apache.org/jira/browse/SLING-8529 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Simone Tripodi >Assignee: Simone Tripodi >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > During testing of various valid scenarios it became apparent that certain > dependency scenarios for nested subpackages might start failing. If packages > start to depend on each other or even deeper nested packages depend on each > other we currently do not preserve the right order when flattening). > Instead the subpackages should be extracted (like bundles) and the implicit > dependency to the (converted) parent package be made explicit (add dependency > if not already existing. > The solution would mean: > * subpackages are extracted from the package and no longer handled as > subpackages > * the subpackages get an additional explicit dependency on the parent > package (that was previously implicitly present) > * the feature model contains all the converted packages and subpackages > instead of a flattened one > * converted package and converted subpackages end up in the defined cache > folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8528) ACLs for Serviceusers on nodes with nodetypes registered via content-package may break startup in repoinit.
[
https://issues.apache.org/jira/browse/SLING-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872274#comment-16872274
]
Simone Tripodi commented on SLING-8528:
---
Codebase now includes a better restrictions and nodetype management
> ACLs for Serviceusers on nodes with nodetypes registered via content-package
> may break startup in repoinit.
> ---
>
> Key: SLING-8528
> URL: https://issues.apache.org/jira/browse/SLING-8528
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Major
>
> If a content-package contains a CND with a new nodetype these nodetypes are
> processed and registered before the content is being installed. The CP to
> featuremodel converter creates paths for nodes on which ACLS for serviceusers
> are registered. These nodes may be created based on nodetypes defined in the
> own or another content-package it depends on.
> As repoinit is executed ahead of content-package installation the execution
> of repoinit may fail with {{javax.jcr.nodetype.NoSuchNodeTypeException: Node
> type my:NodeType does not exist}}
> To eliminate this problem altogether the converter should extract all node
> type definitions found in content-packages and registere via repoinit (see
> register nodetype section in
> https://sling.apache.org/documentation/bundles/repository-initialization.html)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8528) ACLs for Serviceusers on nodes with nodetypes registered via content-package may break startup in repoinit.
[
https://issues.apache.org/jira/browse/SLING-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871882#comment-16871882
]
Simone Tripodi commented on SLING-8528:
---
Initial implementation defined in
[f33f968|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/f33f9680857d553d8c9c7a6d0f92322efde1fe78]
> ACLs for Serviceusers on nodes with nodetypes registered via content-package
> may break startup in repoinit.
> ---
>
> Key: SLING-8528
> URL: https://issues.apache.org/jira/browse/SLING-8528
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Major
>
> If a content-package contains a CND with a new nodetype these nodetypes are
> processed and registered before the content is being installed. The CP to
> featuremodel converter creates paths for nodes on which ACLS for serviceusers
> are registered. These nodes may be created based on nodetypes defined in the
> own or another content-package it depends on.
> As repoinit is executed ahead of content-package installation the execution
> of repoinit may fail with {{javax.jcr.nodetype.NoSuchNodeTypeException: Node
> type my:NodeType does not exist}}
> To eliminate this problem altogether the converter should extract all node
> type definitions found in content-packages and registere via repoinit (see
> register nodetype section in
> https://sling.apache.org/documentation/bundles/repository-initialization.html)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-8529) Avoid flattening of subpackages during convertion in featuremodel
Simone Tripodi created SLING-8529: - Summary: Avoid flattening of subpackages during convertion in featuremodel Key: SLING-8529 URL: https://issues.apache.org/jira/browse/SLING-8529 Project: Sling Issue Type: New Feature Components: Content-Package to Feature Model Converter Reporter: Simone Tripodi Assignee: Simone Tripodi During testing of various valid scenarios it became apparent that certain dependency scenarios for nested subpackages might start failing. If packages start to depend on each other or even deeper nested packages depend on each other we currently do not preserve the right order when flattening). Instead the subpackages should be extracted (like bundles) and the implicit dependency to the (converted) parent package be made explicit (add dependency if not already existing. The solution would mean: * subpackages are extracted from the package and no longer handled as subpackages * the subpackages get an additional explicit dependency on the parent package (that was previously implicitly present) * the feature model contains all the converted packages and subpackages instead of a flattened one * converted package and converted subpackages end up in the defined cache folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-8528) ACLs for Serviceusers on nodes with nodetypes registered via content-package may break startup in repoinit.
[
https://issues.apache.org/jira/browse/SLING-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi reassigned SLING-8528:
-
Assignee: Simone Tripodi
> ACLs for Serviceusers on nodes with nodetypes registered via content-package
> may break startup in repoinit.
> ---
>
> Key: SLING-8528
> URL: https://issues.apache.org/jira/browse/SLING-8528
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Major
>
> If a content-package contains a CND with a new nodetype these nodetypes are
> processed and registered before the content is being installed. The CP to
> featuremodel converter creates paths for nodes on which ACLS for serviceusers
> are registered. These nodes may be created based on nodetypes defined in the
> own or another content-package it depends on.
> As repoinit is executed ahead of content-package installation the execution
> of repoinit may fail with {{javax.jcr.nodetype.NoSuchNodeTypeException: Node
> type my:NodeType does not exist}}
> To eliminate this problem altogether the converter should extract all node
> type definitions found in content-packages and registere via repoinit (see
> register nodetype section in
> https://sling.apache.org/documentation/bundles/repository-initialization.html)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8527) Glob restrictions for content-package formatted wrong
[
https://issues.apache.org/jira/browse/SLING-8527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8527.
---
Resolution: Fixed
Fix Version/s: Feature Model Converter 1.0.6
fixed in
[812794e|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/812794edee8f406b036449b4d901f08f175903e8]
> Glob restrictions for content-package formatted wrong
> -
>
> Key: SLING-8527
> URL: https://issues.apache.org/jira/browse/SLING-8527
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Critical
> Fix For: Feature Model Converter 1.0.6
>
>
> A defined rep:glob on an acl is currently converted in something like this:
> {{"allow jcr:all on /home restriction(*/xyz/*)",}}
> while the result should be
> {{"allow jcr:all on /home restriction(rep:glob,*/xyz/*)",}}
> This renders the generated repoinit section unparsable. The current logic
> should be revised to make sure the generated repoinit statements really
> represent and generate what was defined in the package.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-8527) Glob restrictions for content-package formatted wrong
[
https://issues.apache.org/jira/browse/SLING-8527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi reassigned SLING-8527:
-
Assignee: Simone Tripodi
> Glob restrictions for content-package formatted wrong
> -
>
> Key: SLING-8527
> URL: https://issues.apache.org/jira/browse/SLING-8527
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Dominik Süß
>Assignee: Simone Tripodi
>Priority: Critical
>
> A defined rep:glob on an acl is currently converted in something like this:
> {{"allow jcr:all on /home restriction(*/xyz/*)",}}
> while the result should be
> {{"allow jcr:all on /home restriction(rep:glob,*/xyz/*)",}}
> This renders the generated repoinit section unparsable. The current logic
> should be revised to make sure the generated repoinit statements really
> represent and generate what was defined in the package.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8251) Support checking dependencies for content packages
[ https://issues.apache.org/jira/browse/SLING-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8251. --- Resolution: Feedback Received Fix Version/s: slingfeature-maven-plugin 1.0.6 Feature Model Analyser 1.0.6 modifications merged > Support checking dependencies for content packages > -- > > Key: SLING-8251 > URL: https://issues.apache.org/jira/browse/SLING-8251 > Project: Sling > Issue Type: New Feature > Components: Feature Model >Reporter: Robert Munteanu >Assignee: Simone Tripodi >Priority: Major > Fix For: Feature Model Analyser 1.0.6, slingfeature-maven-plugin > 1.0.6 > > Time Spent: 40m > Remaining Estimate: 0h > > When including content packages in a feature model there are some > dependencies that would be great to check at build time. Both of these are > defined as manifest headers: > # dependencies to other content pacakges - Content-Package-Dependencies > # dependencies to java packages - Import-Package (with the same syntax as the > OSGi bundle Import-Package header ). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8251) Support checking dependencies for content packages
[ https://issues.apache.org/jira/browse/SLING-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863028#comment-16863028 ] Simone Tripodi commented on SLING-8251: --- [~cziegeler] done in the follow up commit > Support checking dependencies for content packages > -- > > Key: SLING-8251 > URL: https://issues.apache.org/jira/browse/SLING-8251 > Project: Sling > Issue Type: New Feature > Components: Feature Model >Reporter: Robert Munteanu >Assignee: Simone Tripodi >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > When including content packages in a feature model there are some > dependencies that would be great to check at build time. Both of these are > defined as manifest headers: > # dependencies to other content pacakges - Content-Package-Dependencies > # dependencies to java packages - Import-Package (with the same syntax as the > OSGi bundle Import-Package header ). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8251) Support checking dependencies for content packages
[
https://issues.apache.org/jira/browse/SLING-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862983#comment-16862983
]
Simone Tripodi commented on SLING-8251:
---
[~cziegeler] apologise if things look confusing, but I din't change the logic -
I just dropped the {{try ... finally}} block since the {{File tempDir}} is now
deleted on exit, rather than in the {{finally}} block :)
> Support checking dependencies for content packages
> --
>
> Key: SLING-8251
> URL: https://issues.apache.org/jira/browse/SLING-8251
> Project: Sling
> Issue Type: New Feature
> Components: Feature Model
>Reporter: Robert Munteanu
>Assignee: Simone Tripodi
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When including content packages in a feature model there are some
> dependencies that would be great to check at build time. Both of these are
> defined as manifest headers:
> # dependencies to other content pacakges - Content-Package-Dependencies
> # dependencies to java packages - Import-Package (with the same syntax as the
> OSGi bundle Import-Package header ).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
