Hi Eric,
Thanks, and appologies for this!
I'm cancelling the release then.
Seems the fix in SLING-10204 was not enough. I will look into
reproducing this, ideally with a pax-exam, which this bundle doesn't
have yet unfortunately. But it might be good to have anyway.
Cheers,
Stefan
On 21.04.21 23:35, Eric Norman wrote:
-1 for me as switching to this release appears to cause some regressions
related to the changes from SLING-10204
Specifically, I noticed some of my local automated tests started to fail
with what appeared to be a problem with some of my JobConsumer components
no longer getting triggered. I took a look at the error.log and there are
numerous "java.lang.IllegalStateException: Resource resolver is already
closed." exceptions being reported with various stacktraces related
to OakClusterViewService.
I believe the following is the stack trace related to the JobConsumer
troubles:
21.04.2021 14:24:06.617 *ERROR* [Apache Sling Repository Startup Thread #1]
org.apache.sling.discovery.oak.cluster.OakClusterViewService
getLocalClusterView: repository exception: java.lang.IllegalStateException:
Resource resolver is already closed.
java.lang.IllegalStateException: Resource resolver is already closed.
at
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.checkClosed(ResourceResolverImpl.java:196)
[org.apache.sling.resourceresolver:1.7.4]
at
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.getResource(ResourceResolverImpl.java:447)
[org.apache.sling.resourceresolver:1.7.4]
at
org.apache.sling.api.resource.ResourceUtil.getOrCreateResourceInternal(ResourceUtil.java:644)
[org.apache.sling.api:2.23.1.SNAPSHOT]
at
org.apache.sling.api.resource.ResourceUtil.getOrCreateResource(ResourceUtil.java:603)
[org.apache.sling.api:2.23.1.SNAPSHOT]
at
org.apache.sling.api.resource.ResourceUtil.getOrCreateResource(ResourceUtil.java:571)
[org.apache.sling.api:2.23.1.SNAPSHOT]
at
org.apache.sling.discovery.commons.providers.util.ResourceHelper.getOrCreateResource(ResourceHelper.java:45)
[org.apache.sling.discovery.commons:1.0.20]
at
org.apache.sling.discovery.commons.providers.spi.base.IdMapService.readIdMap(IdMapService.java:302)
[org.apache.sling.discovery.commons:1.0.20]
at
org.apache.sling.discovery.commons.providers.spi.base.IdMapService.toSlingId(IdMapService.java:280)
[org.apache.sling.discovery.commons:1.0.20]
at
org.apache.sling.discovery.oak.cluster.OakClusterViewService.asClusterView(OakClusterViewService.java:187)
[org.apache.sling.discovery.oak:1.2.32]
at
org.apache.sling.discovery.oak.cluster.OakClusterViewService.getLocalClusterView(OakClusterViewService.java:137)
[org.apache.sling.discovery.oak:1.2.32]
at
org.apache.sling.discovery.base.commons.BaseDiscoveryService.getTopology(BaseDiscoveryService.java:77)
[org.apache.sling.discovery.base:2.0.8]
at
org.apache.sling.discovery.oak.OakDiscoveryService.checkForTopologyChange(OakDiscoveryService.java:678)
[org.apache.sling.discovery.oak:1.2.32]
at
org.apache.sling.discovery.oak.OakDiscoveryService.bindPropertyProviderInteral(OakDiscoveryService.java:414)
[org.apache.sling.discovery.oak:1.2.32]
at
org.apache.sling.discovery.oak.OakDiscoveryService.updatedPropertyProvider(OakDiscoveryService.java:428)
[org.apache.sling.discovery.oak:1.2.32]
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:244)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:685)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.inject.methods.BaseMethod$NotResolved.invoke(BaseMethod.java:639)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:529)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.manager.DependencyManager.invokeUpdatedMethod(DependencyManager.java:2135)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.manager.SingleComponentManager.invokeUpdatedMethod(SingleComponentManager.java:454)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:374)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:301)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1213)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1121)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:867)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1152)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:114)
[org.apache.felix.scr:2.1.26]
at
org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
at
org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
at
org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4863)
at org.apache.felix.framework.Felix.access$000(Felix.java:111)
at org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:440)
at
org.apache.felix.framework.ServiceRegistry.servicePropertiesModified(ServiceRegistry.java:623)
at
org.apache.felix.framework.ServiceRegistrationImpl.setProperties(ServiceRegistrationImpl.java:133)
at
org.apache.sling.event.impl.jobs.JobConsumerManager.bindService(JobConsumerManager.java:305)
[org.apache.sling.event:4.2.18]
at
org.apache.sling.event.impl.jobs.JobConsumerManager.bindJobConsumer(JobConsumerManager.java:243)
[org.apache.sling.event:4.2.18]
I've also reported the same details in the comments of SLING-10204 for
followup.
Regards,
-Eric
On Wed, Apr 21, 2021 at 2:19 AM Stefan Egli <stefane...@apache.org> wrote:
Hi,
We solved 3 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12348159
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2432/
You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
Usage:
sh check_staged_release.sh 2432 /tmp/sling-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
Cheers,
Stefan
