Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
On Mon, 2019-04-01 at 14:58 +0200, Robert Munteanu wrote: > On Mon, 2019-04-01 at 12:04 +0200, Julian Sedding wrote: > > I agree with Bertrand that "org-apache-sling-cli" is too generic > > and > > may even be misleading for users of Sling. > > > > What about "org-apache-sling-committer-cli"? That makes it explicit > > that the tool is not generally useful, but only for committers of > > Sling? > > I think that's a good compromise, so I propose that we go with > > org-apache-sling-committer-cli > > unless someone has another suggestion. Remembers to create the repository, https://github.com/apache/sling-org-apache-sling-committer-cli is now live. Thanks, Robert
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
On Mon, Apr 1, 2019 at 2:58 PM Robert Munteanu wrote: > ... org-apache-sling-committer-cli ... Works for me - my concern, as echoed by others here, was that I'd naturally think "cli" as being a tool for working *with* Sling, as opposed to working *on* Sling. -Bertrand
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
Hi Georg, On Mon, 2019-04-01 at 14:47 +0200, Georg Henzler wrote: > (although from a general direction I'd rather see this tooling in > Jenkins because it can be better automated there) I'll reply on the 'Scaling Sling Development' thread, since you added a more comprehensive reply there. Thanks, Robert
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
On Mon, 2019-04-01 at 12:04 +0200, Julian Sedding wrote: > I agree with Bertrand that "org-apache-sling-cli" is too generic and > may even be misleading for users of Sling. > > What about "org-apache-sling-committer-cli"? That makes it explicit > that the tool is not generally useful, but only for committers of > Sling? I think that's a good compromise, so I propose that we go with org-apache-sling-committer-cli unless someone has another suggestion. Thanks, Robert
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
Hi Ruben, On Fri, 2019-03-29 at 10:17 -0700, Ruben Reusser wrote: > Robert, > > On 3/29/2019 8:59 AM, Robert Munteanu wrote: > > Hi Ruben, > > > > On Fri, 2019-03-29 at 08:13 -0700, Ruben Reusser wrote: > > > Robert, > > > > > > I think as long as the 'maybe help with other stuff' part of your > > > email > > > is true I'd suggest not to use sling.cli > > Suggestions welcome, I'm not terribly good at naming :-) > > maybe sling.dc (sling developer companion) for things that are > relevant > to the work a sling developer does? You make a good point - we should definitely delimit the 'developer' tooling from the 'user' tooling. I would go as far as to follow Julian's lead and use the term 'committer' since the term 'developer' is overloaded. Our users are developers using Sling, even though not developers of Sling. > > > On a separate note, for the sling based peregrine-cms we chose to > > > use > > > nodejs for the cli [1] to lower the entry barrier a bit > > That's interesting. I briefly considered using something like go > > which > > seems better suited for CLI tools ... but ended up deciding for > > something familiar. How did you find node for writing CLI tools? > > writing cli tools with node is in fact very simple and straight > forward > as most nodejs based frameworks provide a cli tool. There is also a > cli > tool for front end developers working on AEM (aemfed) at [1] it > relies > on aemsync [2] That's good to know, thank you. For the time being I'll stick with that I know and I supposed that everyone else does. I'm open to experimenting with other langauges, of course, I just think that at the moment this is where our strength is. Thanks, Robert
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
Hi Julian, good point, it's the same difference as between dev@sling.apache.org and us...@sling.apache.org, so maybe org-apache-sling-dev-cli would be good? (although from a general direction I'd rather see this tooling in Jenkins because it can be better automated there) -Georg On 2019-04-01 12:04, Julian Sedding wrote: I agree with Bertrand that "org-apache-sling-cli" is too generic and may even be misleading for users of Sling. What about "org-apache-sling-committer-cli"? That makes it explicit that the tool is not generally useful, but only for committers of Sling?
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
I agree with Bertrand that "org-apache-sling-cli" is too generic and may even be misleading for users of Sling. What about "org-apache-sling-committer-cli"? That makes it explicit that the tool is not generally useful, but only for committers of Sling? Regards Julian On Fri, Mar 29, 2019 at 10:04 PM Georg Henzler wrote: > > Hi, > > > I am thinking that this CLI may the the basis for other commands. One > > which I would benefit personally from would be a > > > > code grep > ... > > > > pull-request list > > > > to list all open pull requests, which could be the basis of solving > > PRB-CONTRIB from [1]. > > > > Anyway, org-apache-sling-release-cli sounds OK to me, at least > > initially, and we can rename it later. > > > so if it is planned to introduce more goals that are > non-release-related, I'd prefer to start directly with > org-apache-sling-cli. > > -Georg
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
Hi, I am thinking that this CLI may the the basis for other commands. One which I would benefit personally from would be a code grep ... pull-request list to list all open pull requests, which could be the basis of solving PRB-CONTRIB from [1]. Anyway, org-apache-sling-release-cli sounds OK to me, at least initially, and we can rename it later. so if it is planned to introduce more goals that are non-release-related, I'd prefer to start directly with org-apache-sling-cli. -Georg
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
Robert, On 3/29/2019 8:59 AM, Robert Munteanu wrote: Hi Ruben, On Fri, 2019-03-29 at 08:13 -0700, Ruben Reusser wrote: Robert, I think as long as the 'maybe help with other stuff' part of your email is true I'd suggest not to use sling.cli Suggestions welcome, I'm not terribly good at naming :-) maybe sling.dc (sling developer companion) for things that are relevant to the work a sling developer does? On a separate note, for the sling based peregrine-cms we chose to use nodejs for the cli [1] to lower the entry barrier a bit That's interesting. I briefly considered using something like go which seems better suited for CLI tools ... but ended up deciding for something familiar. How did you find node for writing CLI tools? writing cli tools with node is in fact very simple and straight forward as most nodejs based frameworks provide a cli tool. There is also a cli tool for front end developers working on AEM (aemfed) at [1] it relies on aemsync [2] [1] https://www.npmjs.com/package/aemfed [2] https://www.npmjs.com/package/aemsync Robert Ruben [1] https://github.com/headwirecom/percli On 3/29/2019 2:13 AM, Robert Munteanu wrote: Hi, Radu and I have been working on a little tool to automate some of the release work [1] (and maybe help with other stuff). See [2] for background information. As it's starting to take shape and become usable we'd like to move it out of the whiteboard. I suggest we use 'org.apache.sling.cli' as the artifactId and 'sling- org-apache-sling-cli' as the repository. Thoughts? Thanks, Robert [1]: https://github.com/apache/sling-whiteboard/tree/master/cli [2]: https://lists.apache.org/thread.html/b3001deea28c800f81830701c9293e66634f5512d70bed0043fb2302@%3Cdev.sling.apache.org%3E
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
On Fri, 2019-03-29 at 10:31 +0100, Bertrand Delacretaz wrote: > On Fri, Mar 29, 2019 at 10:13 AM Robert Munteanu > wrote: > > ...I suggest we use 'org.apache.sling.cli' as the artifactId and > > 'sling- > > org-apache-sling-cli' as the repository... > > IIUC this tool is specifically about automating release, so how about > a more specific name? > > org-apache-sling-release-cli ? Hi Bertrand, I'm a bit undecided about this. Currently this is about releases, supporting the 'release' command and some other subcommands, e.g. release list release prepare-email release tally-votes release update-local-site I am thinking that this CLI may the the basis for other commands. One which I would benefit personally from would be a code grep one, which searches the Sling repos. Additionally some github integration would be useful such as pull-request list to list all open pull requests, which could be the basis of solving PRB-CONTRIB from [1]. Anyway, org-apache-sling-release-cli sounds OK to me, at least initially, and we can rename it later. Thanks, Robert [1]: https://cwiki.apache.org/confluence/display/SLING/Scaling+Sling+Development
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
On Fri, Mar 29, 2019 at 10:13 AM Robert Munteanu wrote: > ...I suggest we use 'org.apache.sling.cli' as the artifactId and 'sling- > org-apache-sling-cli' as the repository... IIUC this tool is specifically about automating release, so how about a more specific name? org-apache-sling-release-cli ? -Bertrand
[DISCUSS] Create new sling repo for org.apache.sling.cli
Hi, Radu and I have been working on a little tool to automate some of the release work [1] (and maybe help with other stuff). See [2] for background information. As it's starting to take shape and become usable we'd like to move it out of the whiteboard. I suggest we use 'org.apache.sling.cli' as the artifactId and 'sling- org-apache-sling-cli' as the repository. Thoughts? Thanks, Robert [1]: https://github.com/apache/sling-whiteboard/tree/master/cli [2]: https://lists.apache.org/thread.html/b3001deea28c800f81830701c9293e66634f5512d70bed0043fb2302@%3Cdev.sling.apache.org%3E
