[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #4: SLING-10489 : introducing partial startup detector
stefan-egli commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#issuecomment-1064116176 @mreutegg , now added a system property `org.apache.sling.discovery.oak.joinerdelay.enabled` that allows to overwrite the config as to whether this feature is enabled or not. The default of the config itself is disabled. The system property not being present hence results in the feature being disabled. This way IMO it is safe to go ahead with this PR, merge and release and revisit problems at a later stage if they arise. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #4: SLING-10489 : introducing partial startup detector
stefan-egli commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#issuecomment-982783322 Updated the PR with the following change: * disabled partial-startup-suppression by default to remain on the cautious side * if enabled, the suppression now also applies to previous but slow members of the cluster : those cannot otherwise be distinguished from a restarting slow member (and either we suppress them or not). ** the suggestion is instead to increase the minEventDelay to compensate for the removal of this strict check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #4: SLING-10489 : introducing partial startup detector
stefan-egli commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#issuecomment-920905198 @mreutegg , added a test case that reproduces your scenario : db70598681b76c4e6bb63fd2d35fa7b99ac6bcf0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #4: SLING-10489 : introducing partial startup detector
stefan-egli commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#issuecomment-861602221 PS1 : more test coverage to come PS2 : depends on minor change in discovery.commons : https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
