[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis
stefanseifert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1066617287 merging this PR as quick solution for Sling 12 release. discussion about more sustainable solution will continue in https://issues.apache.org/jira/browse/SLING-11203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis
stefanseifert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1064151813 played around a bit with "the other way around" letting the whiteboard directly register the content readers itself - in actual code it's not looking more elegant than the current approach. it sill prefer the approach from this PR, probably in combination with #13. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis
stefanseifert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1064060508 yes, that probably would be more elegant. in that case we have to use osgi framework instead of DS i suppose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis
stefanseifert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-106200 this would probably have been a better design decision initially, but for backward compatibility we have to handle all the existing bundles that expect the built-in providers to be always available. i vote to go with the approach of this PR, but make the list of readers configurable. introducing a new directive for this now makes the always quite complex list of parameters for content loading even more complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis
stefanseifert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062978854 making it configurable would have the benefit that it also supports custom content readers, they could be added to the check via configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis
stefanseifert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062960567 we've discussed this in https://issues.apache.org/jira/browse/SLING-11189 and at least for that ticket decided to keep this fix to the built-in content readers. i currently do not see a use case to disable some of the built-in content readers via OSGi - we already have support to disable readers in the bundle metadata (ignoreImportProviders). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
