[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on pull request #12: SLING-10010 update to sling-bundle-parent 40

2021-07-17 Thread GitBox


joerghoh commented on pull request #12:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/12#issuecomment-881912890


   @kwin I think we should drop the dependency to sling-commons-testing, we 
should start to use the sling mocks instead (they are maintained and much more 
easier to use). For that reason I added the 2 relevant classes in here, which 
serve as a replacement for the ones of sling-commons-testing, but Oak-based.
   
   I also think that we should invest in some time and update some Junit3 tests 
to Junit4, which I haven't done yet to keep the scope of the patch as narrow as 
possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on pull request #12: SLING-10010 update to sling-bundle-parent 40

2021-07-17 Thread GitBox


joerghoh commented on pull request #12:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/12#issuecomment-881949498


   ok, then I will just update it to parent 43 and leave everything else for a 
different ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org