[GitHub] [sling-org-apache-sling-starter] stefanseifert commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum
stefanseifert commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r823695462
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard":
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4
Review comment:
that would be possible, but is it worth taking those extra-roundtrip? i
think we are very close to the final solution, we have even two PRs in place
which actually fix the problem. once we have the final solution ready we could
release a new contentloader bundle version together with the final sling 12
starter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] stefanseifert commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum
stefanseifert commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822798054
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard":
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4
Review comment:
i do not like the approach with "minimum=4" (wherever it is defined) -
this is too subtle and will likely be forgotten if someone adds a 5th content
reader implementation in the future - and then it may produce unreliable
results again when it may happen that one random of the 5 readers is not ready.
it may also be unreliable when there are custom content readers in the system
from other bundles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
