[GitHub] [sling-org-apache-sling-superimposing] saurabh-khare commented on a change in pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations
saurabh-khare commented on a change in pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#discussion_r478183139 ## File path: pom.xml ## @@ -43,120 +42,120 @@ - + -org.apache.felix -maven-scr-plugin +org.apache.sling +sling-maven-plugin - + -org.apache.felix -maven-bundle-plugin -true - - - org.apache.sling.superimposing - org.apache.sling.superimposing.impl - org.apache.felix.webconsole - SLING-INF/nodetypes/superimposing.cnd - - +biz.aQute.bnd +bnd-maven-plugin - -org.apache.sling -maven-sling-plugin +biz.aQute.bnd +bnd-baseline-maven-plugin - org.apache.sling org.apache.sling.api -2.2.0 +2.18.4 provided org.apache.sling org.apache.sling.commons.osgi -2.1.0 +2.4.0 provided org.apache.sling org.apache.sling.settings -1.0.0 +1.3.8 provided - + + org.apache.sling + org.apache.sling.serviceusermapper + 1.3.6 + provided + + + org.apache.commons + commons-lang3 +3.6 + -commons-lang -commons-lang -2.4 + org.apache.commons + commons-collections4 +4.1 + + + + org.osgi + org.osgi.service.component.annotations provided - - -commons-collections -commons-collections -3.1 + + + org.osgi + org.osgi.service.metatype.annotations +1.4.0 Review comment: Removed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-superimposing] saurabh-khare commented on a change in pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations
saurabh-khare commented on a change in pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#discussion_r478182961 ## File path: pom.xml ## @@ -43,120 +42,120 @@ - + -org.apache.felix -maven-scr-plugin +org.apache.sling +sling-maven-plugin - + -org.apache.felix -maven-bundle-plugin -true - - - org.apache.sling.superimposing - org.apache.sling.superimposing.impl - org.apache.felix.webconsole - SLING-INF/nodetypes/superimposing.cnd - - +biz.aQute.bnd +bnd-maven-plugin - -org.apache.sling -maven-sling-plugin +biz.aQute.bnd +bnd-baseline-maven-plugin - org.apache.sling org.apache.sling.api -2.2.0 +2.18.4 Review comment: Reverted to previous versions for runtime dependencies This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-superimposing] saurabh-khare commented on a change in pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations
saurabh-khare commented on a change in pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#discussion_r478182354 ## File path: bnd.bnd ## @@ -0,0 +1,17 @@ +Bundle-Category: sling Review comment: Removed duplicated information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-superimposing] saurabh-khare commented on a change in pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations
saurabh-khare commented on a change in pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#discussion_r478182573 ## File path: pom.xml ## @@ -19,14 +19,13 @@ 4.0.0 org.apache.sling -sling -26 - +sling-bundle-parent +38 Review comment: Updated to version 39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
