[GitHub] rombert commented on issue #5: Feature/stop selector duplication
rombert commented on issue #5: Feature/stop selector duplication URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/5#issuecomment-410269967 I will start a release once #6 is done and merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rombert commented on issue #5: Feature/stop selector duplication
rombert commented on issue #5: Feature/stop selector duplication URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/5#issuecomment-409279442 Applied with minor modifications, thanks @toniedzwiedz ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rombert commented on issue #5: Feature/stop selector duplication
rombert commented on issue #5: Feature/stop selector duplication URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/5#issuecomment-408887166 @toniedzwiedz - thanks for the update. If you look at the generated manifest, you will see that the `urlbuilder` package is still included in the list of exported packages. I would suggest moving it to an `impl` or `internal` package so that it's automatically excluded from the export packages. Also, the release depends on whether we have other contributions to process, but it should be OK to start the release after the PR is merged, and then the release is available in ~3 days. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rombert commented on issue #5: Feature/stop selector duplication
rombert commented on issue #5: Feature/stop selector duplication URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/5#issuecomment-398399381 The change looks good to me @toniedzwiedz ! I like the way you extracted the reusable logic out and made it easily testable, that's always good. One suggestion that I would make is to move the `UrlBuilder` to an implementation package - this way we don't have to bump exported package versions and the project version at all. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
