[GitHub] trekawek commented on a change in pull request #21: Implement missing launchpad services.
trekawek commented on a change in pull request #21: Implement missing launchpad
services.
URL: https://github.com/apache/sling-whiteboard/pull/21#discussion_r236573821
##
File path:
startupmanager/src/main/java/org/apache/sling/launchpad/startupmanager/StartUpHandlerImpl.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.launchpad.startupmanager;
+
+import org.apache.sling.launchpad.api.StartupHandler;
+import org.apache.sling.launchpad.api.StartupMode;
+import org.osgi.framework.Bundle;
+import org.osgi.framework.ServiceFactory;
+
+public class StartUpHandlerImpl implements StartupHandler
+{
+private final Bundle framework;
+
+public StartUpHandlerImpl(Bundle bundle)
+{
+framework = bundle;
+}
+
+@Override
+public StartupMode getMode()
+{
+return StartupMode.RESTART;
+}
+
+@Override
+public boolean isFinished()
+{
+return framework.getState() == Bundle.ACTIVE;
Review comment:
I didn't notice that it's bundle "0". Thanks for the explanation!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] trekawek commented on a change in pull request #21: Implement missing launchpad services.
trekawek commented on a change in pull request #21: Implement missing launchpad
services.
URL: https://github.com/apache/sling-whiteboard/pull/21#discussion_r236216793
##
File path:
startupmanager/src/main/java/org/apache/sling/launchpad/startupmanager/Activator.java
##
@@ -37,40 +39,30 @@
private static final Logger log = LoggerFactory.getLogger(Activator.class);
-private ServiceRegistration mbeanServerReg;
-
-private ServiceRegistration mbeanStartupListenerReg;
-
private StartupListenerTracker startupListenerTracker;
@Override
public void start(final BundleContext bundleContext) {
startupListenerTracker = new StartupListenerTracker(bundleContext);
-mbeanServerReg = registerMBeanServer(bundleContext);
Review comment:
Don't we need to unregister all the created services?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] trekawek commented on a change in pull request #21: Implement missing launchpad services.
trekawek commented on a change in pull request #21: Implement missing launchpad
services.
URL: https://github.com/apache/sling-whiteboard/pull/21#discussion_r236217646
##
File path:
startupmanager/src/main/java/org/apache/sling/launchpad/startupmanager/StartUpHandlerImpl.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.launchpad.startupmanager;
+
+import org.apache.sling.launchpad.api.StartupHandler;
+import org.apache.sling.launchpad.api.StartupMode;
+import org.osgi.framework.Bundle;
+import org.osgi.framework.ServiceFactory;
+
+public class StartUpHandlerImpl implements StartupHandler
+{
+private final Bundle framework;
+
+public StartUpHandlerImpl(Bundle bundle)
+{
+framework = bundle;
+}
+
+@Override
+public StartupMode getMode()
+{
+return StartupMode.RESTART;
+}
+
+@Override
+public boolean isFinished()
+{
+return framework.getState() == Bundle.ACTIVE;
Review comment:
Shouldn't we wait until the whole framework is started, like in here:
https://github.com/apache/sling-whiteboard/blob/097012ca7db585044aaafe09875b2f5f292ec8b7/startupmanager/src/main/java/org/apache/sling/launchpad/startupmanager/StartupListenerTracker.java#L92-L97
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
