Re: [VOTE] Release Apache Sling Distributed Event Admin 1.0.0 and Eventing 3.4.0
On Thursday 23 October 2014 16:35:59 Carsten Ziegeler wrote: > Am 23.10.14 um 16:30 schrieb Oliver Lietz: > > On Tuesday 21 October 2014 10:11:26 Carsten Ziegeler wrote: > >> Hi, > >> > >> the distributed event admin moved out of the eventing to a new module > >> and we solved 12 issues for the eventing: > >> > >> https://issues.apache.org/jira/browse/SLING/fixforversion/12327843 > > > > just some remarks... > > > > is the component name > > "org.apache.sling.event.impl.DistributingEventHandler" for > > org.apache.sling.event.dea.impl.DistributedEventAdminImpl without dea in > > it intended? > > Yes :) This is for compatibility with the version previously in the > eventing bundle. > > > I don't like the dots in repository.path and cleanup.period as these > > properties are not part of a hierarchical configuration. > > Same here > > > And in general I like strict use of camel case instead of DEAConstants or > > OSGiServiceInjector or TXTSSMModelReader ;) > > :) Thanks, Carsten. O. > Carsten > > > though +1 for both > > > > O.
Re: [VOTE] Release Apache Sling Distributed Event Admin 1.0.0 and Eventing 3.4.0
Am 23.10.14 um 16:30 schrieb Oliver Lietz: > On Tuesday 21 October 2014 10:11:26 Carsten Ziegeler wrote: >> Hi, >> >> the distributed event admin moved out of the eventing to a new module >> and we solved 12 issues for the eventing: >> >> https://issues.apache.org/jira/browse/SLING/fixforversion/12327843 > > just some remarks... > > is the component name "org.apache.sling.event.impl.DistributingEventHandler" > for org.apache.sling.event.dea.impl.DistributedEventAdminImpl without dea in > it intended? > Yes :) This is for compatibility with the version previously in the eventing bundle. > I don't like the dots in repository.path and cleanup.period as these > properties are not part of a hierarchical configuration. > Same here > And in general I like strict use of camel case instead of DEAConstants or > OSGiServiceInjector or TXTSSMModelReader ;) :) Carsten > > though +1 for both > > O. > -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling Distributed Event Admin 1.0.0 and Eventing 3.4.0
On Tuesday 21 October 2014 10:11:26 Carsten Ziegeler wrote: > Hi, > > the distributed event admin moved out of the eventing to a new module > and we solved 12 issues for the eventing: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12327843 just some remarks... is the component name "org.apache.sling.event.impl.DistributingEventHandler" for org.apache.sling.event.dea.impl.DistributedEventAdminImpl without dea in it intended? I don't like the dots in repository.path and cleanup.period as these properties are not part of a hierarchical configuration. And in general I like strict use of camel case instead of DEAConstants or OSGiServiceInjector or TXTSSMModelReader ;) though +1 for both O.
Re: [VOTE] Release Apache Sling Distributed Event Admin 1.0.0 and Eventing 3.4.0
Am 21.10.14 um 10:11 schrieb Carsten Ziegeler: > Hi, > > the distributed event admin moved out of the eventing to a new module > and we solved 12 issues for the eventing: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12327843 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1142/ > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1142 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > +1 Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling Distributed Event Admin 1.0.0 and Eventing 3.4.0
+1 On Tue, Oct 21, 2014 at 7:14 AM, Robert Munteanu wrote: > +1 > > Robert > > On Tue, Oct 21, 2014 at 11:11 AM, Carsten Ziegeler > wrote: > > Hi, > > > > the distributed event admin moved out of the eventing to a new module > > and we solved 12 issues for the eventing: > > > > https://issues.apache.org/jira/browse/SLING/fixforversion/12327843 > > > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-1142/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 1142 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe Research Switzerland > > cziege...@apache.org >
Re: [VOTE] Release Apache Sling Distributed Event Admin 1.0.0 and Eventing 3.4.0
+1 Robert On Tue, Oct 21, 2014 at 11:11 AM, Carsten Ziegeler wrote: > Hi, > > the distributed event admin moved out of the eventing to a new module > and we solved 12 issues for the eventing: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12327843 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1142/ > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1142 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org
[VOTE] Release Apache Sling Distributed Event Admin 1.0.0 and Eventing 3.4.0
Hi, the distributed event admin moved out of the eventing to a new module and we solved 12 issues for the eventing: https://issues.apache.org/jira/browse/SLING/fixforversion/12327843 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1142/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1142 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org