[
https://issues.apache.org/jira/browse/SLING-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10769.
------------------------------------------
> VaultPackageAssembler should not implement EntryHandler
> -------------------------------------------------------
>
> Key: SLING-10769
> URL: https://issues.apache.org/jira/browse/SLING-10769
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
> Reporter: Angela Schreiber
> Assignee: Angela Schreiber
> Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.10
>
>
> [~kpauls], as stated with the PR for SLING-10754 i find it quite confusing
> the {{VaultPackageAssembler}} implements {{EntryHandler}} and is used as
> default in {{ContentPackage2FeatureModelConverter}}. even more so as the
> assembler is accessed by other {{EntryHandler}} implementations to add
> package entries that don't end up in repo-init.
> while the effect is likely the same if the {{EntryHandler}} methods get moved
> to a separate {{DefaultHandler}}, it would IMHO make the code easier to read.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
